Merge pull request #2891 from MetaMask/i2621-0xRecipientAddress

Account for 0x/empty string recipient

1 files changed, 32 insertions, 0 deletions

diff --git a/test/unit/tx-gas-util-test.js b/test/unit/tx-gas-util-test.js
new file mode 100644
index 000000000..ccef31359
--- /dev/null
+++ b/test/unit/tx-gas-util-test.js
@@ -0,0 +1,32 @@
+const assert = require('assert')
+const TxGasUtils = require('../../app/scripts/lib/tx-gas-utils')
+const { createStubedProvider } = require('../stub/provider')
+
+describe('Tx Gas Util', function () {
+  let txGasUtil, provider, providerResultStub
+  beforeEach(function () {
+    providerResultStub = {}
+    provider = createStubedProvider(providerResultStub)
+    txGasUtil = new TxGasUtils({
+      provider,
+    })
+  })
+
+  it('removes recipient for txParams with 0x when contract data is provided', function () {
+    const zeroRecipientandDataTxParams = {
+      from: '0x1678a085c290ebd122dc42cba69373b5953b831d',
+      to: '0x',
+      data: 'bytecode',
+    }
+    const sanitizedTxParams = txGasUtil.validateRecipient(zeroRecipientandDataTxParams)
+    assert.deepEqual(sanitizedTxParams, { from: '0x1678a085c290ebd122dc42cba69373b5953b831d', data: 'bytecode' }, 'no recipient with 0x')
+  })
+
+  it('should error when recipient is 0x', function () {
+    const zeroRecipientTxParams = {
+      from: '0x1678a085c290ebd122dc42cba69373b5953b831d',
+      to: '0x',
+    }
+    assert.throws(() => { txGasUtil.validateRecipient(zeroRecipientTxParams) }, Error, 'Invalid recipient address')
+  })
+})