I#5956 fix 1 (#6026)

* prevent invalid chainId's when adding cusstom rpcs

* migration 30 removes invalid chaids from preferences and networkController for custom rpcs

1 files changed, 37 insertions, 0 deletions

diff --git a/test/unit/migrations/030-test.js b/test/unit/migrations/030-test.js
new file mode 100644
index 000000000..ca410342f
--- /dev/null
+++ b/test/unit/migrations/030-test.js
@@ -0,0 +1,37 @@
+const assert = require('assert')
+const migrationTemplate = require('../../../app/scripts/migrations/030.js')
+const storage = {
+  meta: {},
+  data: {
+    NetworkController: {
+      network: 'fail',
+      provider: {
+        chainId: 'fail',
+        nickname: '',
+        rpcTarget: 'https://api.myetherwallet.com/eth',
+        ticker: 'ETH',
+        type: 'rinkeby',
+      },
+    },
+    PreferencesController: {
+      frequentRpcListDetail: [
+        {chainId: 'fail', nickname: '', rpcUrl: 'http://127.0.0.1:8545', ticker: ''},
+        {chainId: '1', nickname: '', rpcUrl: 'https://api.myetherwallet.com/eth', ticker: 'ETH'},
+      ],
+    },
+  },
+}
+
+describe('storage is migrated successfully', () => {
+  it('should work', (done) => {
+    migrationTemplate.migrate(storage)
+    .then((migratedData) => {
+      assert.equal(migratedData.meta.version, 30)
+      assert.equal(migratedData.data.PreferencesController.frequentRpcListDetail[0].chainId, undefined)
+      assert.equal(migratedData.data.PreferencesController.frequentRpcListDetail[1].chainId, '1')
+      assert.equal(migratedData.data.NetworkController.provider.chainId, undefined)
+      assert.equal(migratedData.data.NetworkController.network, undefined)
+      done()
+    }).catch(done)
+  })
+})