aboutsummaryrefslogtreecommitdiffstats
path: root/test/unit
diff options
context:
space:
mode:
authorDan Finlay <dan@danfinlay.com>2016-11-08 03:55:17 +0800
committerDan Finlay <dan@danfinlay.com>2016-11-08 03:56:20 +0800
commit1896928562c728612caa7498ed82559a82a09aeb (patch)
treefb13533f7f937f88ed814566528c83584af6fa1c /test/unit
parentfff5a6765ecc586bd855aa263c0fdfc3f957e8d7 (diff)
downloadtangerine-wallet-browser-1896928562c728612caa7498ed82559a82a09aeb.tar
tangerine-wallet-browser-1896928562c728612caa7498ed82559a82a09aeb.tar.gz
tangerine-wallet-browser-1896928562c728612caa7498ed82559a82a09aeb.tar.bz2
tangerine-wallet-browser-1896928562c728612caa7498ed82559a82a09aeb.tar.lz
tangerine-wallet-browser-1896928562c728612caa7498ed82559a82a09aeb.tar.xz
tangerine-wallet-browser-1896928562c728612caa7498ed82559a82a09aeb.tar.zst
tangerine-wallet-browser-1896928562c728612caa7498ed82559a82a09aeb.zip
Fix gas price buffering
Our gas price buffering logic had a bug, because bn.js has inconsistent behavior when using hex-prefixed output. The issue has been opened with them here: https://github.com/indutny/bn.js/issues/151 We've corrected our usage in the mean time.
Diffstat (limited to 'test/unit')
-rw-r--r--test/unit/idStore-test.js14
1 files changed, 6 insertions, 8 deletions
diff --git a/test/unit/idStore-test.js b/test/unit/idStore-test.js
index 34b0c992e..46b3d4809 100644
--- a/test/unit/idStore-test.js
+++ b/test/unit/idStore-test.js
@@ -169,20 +169,18 @@ describe('IdentityStore', function() {
const gas = '0x04ee59' // Actual estimated gas example
const tooBigOutput = '0x80674f9' // Actual bad output
- const bnGas = new BN(gas, 16)
+ const bnGas = new BN(ethUtil.stripHexPrefix(gas), 16)
const correctBuffer = new BN('100000', 10)
const correct = bnGas.add(correctBuffer)
const tooBig = new BN(tooBigOutput, 16)
- console.log(`Pure estimate is ${bnGas.toString(10)}`)
- console.log(`Too big is ${tooBig.toString(10)}`)
- console.log(`Buffer should be ${correctBuffer.toString(10)}`)
- console.log(`correct should be ${correct.toString(10)}`)
const result = idStore.addGasBuffer(gas)
- const bnResult = new BN(result, 16)
+ const bnResult = new BN(ethUtil.stripHexPrefix(result), 16)
- console.log(`Result was ${bnResult.toString(10)}`)
- assert.equal(result, correct.toString(16), 'add the right amount')
+ assert.equal(result.indexOf('0x'), 0, 'included hex prefix')
+ assert(bnResult.gt(bnGas), 'Estimate increased in value.')
+ assert.equal(bnResult.sub(bnGas).toString(10), '100000', 'added 100k gas')
+ assert.equal(result, '0x' + correct.toString(16), 'Added the right amount')
assert.notEqual(result, tooBigOutput, 'not that bad estimate')
})
})