diff options
author | tmashuang <thomas.b.huang@gmail.com> | 2018-05-22 07:36:48 +0800 |
---|---|---|
committer | tmashuang <thomas.b.huang@gmail.com> | 2018-05-22 07:36:48 +0800 |
commit | 238f2eb179895bbb9e2a2ec26863041564c90a9d (patch) | |
tree | ada33021efc445a4a995f1cb701cbbac9b683f94 /app | |
parent | 848f8f805b54104d57aaf15f0cc14c36aa37edd2 (diff) | |
parent | e8b2e11c5624d80f535c1344d9c9be48627b1319 (diff) | |
download | tangerine-wallet-browser-238f2eb179895bbb9e2a2ec26863041564c90a9d.tar tangerine-wallet-browser-238f2eb179895bbb9e2a2ec26863041564c90a9d.tar.gz tangerine-wallet-browser-238f2eb179895bbb9e2a2ec26863041564c90a9d.tar.bz2 tangerine-wallet-browser-238f2eb179895bbb9e2a2ec26863041564c90a9d.tar.lz tangerine-wallet-browser-238f2eb179895bbb9e2a2ec26863041564c90a9d.tar.xz tangerine-wallet-browser-238f2eb179895bbb9e2a2ec26863041564c90a9d.tar.zst tangerine-wallet-browser-238f2eb179895bbb9e2a2ec26863041564c90a9d.zip |
Merge branch 'develop' into testing
Diffstat (limited to 'app')
-rw-r--r-- | app/scripts/background.js | 2 | ||||
-rw-r--r-- | app/scripts/controllers/transactions/index.js | 15 | ||||
-rw-r--r-- | app/scripts/metamask-controller.js | 2 |
3 files changed, 2 insertions, 17 deletions
diff --git a/app/scripts/background.js b/app/scripts/background.js index 69d549c85..686296329 100644 --- a/app/scripts/background.js +++ b/app/scripts/background.js @@ -322,7 +322,7 @@ function setupController (initState, initLangCode) { /** * A runtime.Port object, as provided by the browser: - * @link https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/runtime/Port + * @see https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/runtime/Port * @typedef Port * @type Object */ diff --git a/app/scripts/controllers/transactions/index.js b/app/scripts/controllers/transactions/index.js index 3886db104..541f1db73 100644 --- a/app/scripts/controllers/transactions/index.js +++ b/app/scripts/controllers/transactions/index.js @@ -112,21 +112,6 @@ class TransactionController extends EventEmitter { } /** - Check if a txMeta in the list with the same nonce has been confirmed in a block - if the txParams dont have a nonce will return false - @returns {boolean} whether the nonce has been used in a transaction confirmed in a block - @param {object} txMeta - the txMeta object - */ - async isNonceTaken (txMeta) { - const { from, nonce } = txMeta.txParams - if ('nonce' in txMeta.txParams) { - const sameNonceTxList = this.txStateManager.getFilteredTxList({from, nonce, status: 'confirmed'}) - return (sameNonceTxList.length >= 1) - } - return false - } - - /** add a new unapproved transaction to the pipeline @returns {Promise<string>} the hash of the transaction after being submitted to the network diff --git a/app/scripts/metamask-controller.js b/app/scripts/metamask-controller.js index 807c9a0b9..1b1d26886 100644 --- a/app/scripts/metamask-controller.js +++ b/app/scripts/metamask-controller.js @@ -382,7 +382,7 @@ module.exports = class MetamaskController extends EventEmitter { updateTransaction: nodeify(txController.updateTransaction, txController), updateAndApproveTransaction: nodeify(txController.updateAndApproveTransaction, txController), retryTransaction: nodeify(this.retryTransaction, this), - isNonceTaken: nodeify(txController.isNonceTaken, txController), + getFilteredTxList: nodeify(txController.getFilteredTxList, txController), // messageManager signMessage: nodeify(this.signMessage, this), |