Merge pull request #745 from MetaMask/i743-FixDelegateCallFlag

Reproduced issue 743 in test case

1 files changed, 14 insertions, 9 deletions

diff --git a/app/scripts/lib/idStore.js b/app/scripts/lib/idStore.js
index 9d0ca7f19..402a5e612 100644
--- a/app/scripts/lib/idStore.js
+++ b/app/scripts/lib/idStore.js
@@ -249,15 +249,9 @@ IdentityStore.prototype.addUnconfirmedTransaction = function (txParams, onTxDone
     if (txParams.to) {
       query.getCode(txParams.to, function (err, result) {
         if (err) return cb(err)
-        var code = ethUtil.toBuffer(result)
-        if (code !== '0x') {
-          var ops = ethBinToOps(code)
-          var containsDelegateCall = ops.some((op) => op.name === 'DELEGATECALL')
-          txData.containsDelegateCall = containsDelegateCall
-          cb()
-        } else {
-          cb()
-        }
+        var containsDelegateCall = this.checkForDelegateCall(result)
+        txData.containsDelegateCall = containsDelegateCall
+        cb()
       })
     } else {
       cb()
@@ -282,6 +276,17 @@ IdentityStore.prototype.addUnconfirmedTransaction = function (txParams, onTxDone
   }
 }
 
+IdentityStore.prototype.checkForDelegateCall = function (codeHex) {
+  const code = ethUtil.toBuffer(codeHex)
+  if (code !== '0x') {
+    const ops = ethBinToOps(code)
+    const containsDelegateCall = ops.some((op) => op.name === 'DELEGATECALL')
+    return containsDelegateCall
+  } else {
+    return false
+  }
+}
+
 IdentityStore.prototype.addGasBuffer = function (gasHex) {
   var gas = new BN(gasHex, 16)
   var buffer = new BN('100000', 10)