aboutsummaryrefslogtreecommitdiffstats
path: root/app
diff options
context:
space:
mode:
authorDan Finlay <542863+danfinlay@users.noreply.github.com>2018-11-17 13:27:01 +0800
committerGitHub <noreply@github.com>2018-11-17 13:27:01 +0800
commitfdea642e6d5b23d4573759e4f1a1f4016557c0be (patch)
treef72b545aa959014be4e0ec53f75cf3b0d4bbf785 /app
parent1988e1e96b09a47ad5428083bb2ed38cb2d7e0a8 (diff)
downloadtangerine-wallet-browser-fdea642e6d5b23d4573759e4f1a1f4016557c0be.tar
tangerine-wallet-browser-fdea642e6d5b23d4573759e4f1a1f4016557c0be.tar.gz
tangerine-wallet-browser-fdea642e6d5b23d4573759e4f1a1f4016557c0be.tar.bz2
tangerine-wallet-browser-fdea642e6d5b23d4573759e4f1a1f4016557c0be.tar.lz
tangerine-wallet-browser-fdea642e6d5b23d4573759e4f1a1f4016557c0be.tar.xz
tangerine-wallet-browser-fdea642e6d5b23d4573759e4f1a1f4016557c0be.tar.zst
tangerine-wallet-browser-fdea642e6d5b23d4573759e4f1a1f4016557c0be.zip
Auto fail transactions that have been approved for over 12 hours (#5765)
* Auto fail transactions that have been approved for over 12 hours Converts txs using a migration. This migration uses a new helper function that generates tx-failing migrations, and only requires a version, error message, and condition to run on each transaction. * Linted * Only migrate approved txs to failed * Cleanup * Cleanup * Small lint fixes
Diffstat (limited to 'app')
-rw-r--r--app/scripts/migrations/029.js27
-rw-r--r--app/scripts/migrations/fail-tx.js41
-rw-r--r--app/scripts/migrations/index.js1
3 files changed, 69 insertions, 0 deletions
diff --git a/app/scripts/migrations/029.js b/app/scripts/migrations/029.js
new file mode 100644
index 000000000..e17479ccc
--- /dev/null
+++ b/app/scripts/migrations/029.js
@@ -0,0 +1,27 @@
+// next version number
+const version = 29
+const failTxsThat = require('./fail-tx')
+
+// time
+const seconds = 1000
+const minutes = 60 * seconds
+const hours = 60 * minutes
+const unacceptableDelay = 12 * hours
+
+/*
+
+normalizes txParams on unconfirmed txs
+
+*/
+
+module.exports = {
+ version,
+
+ migrate: failTxsThat(version, 'Stuck in approved state for too long.', (txMeta) => {
+ const isApproved = txMeta.status === 'approved'
+ const createdTime = txMeta.submittedTime
+ const now = Date.now()
+ return isApproved && now - createdTime > unacceptableDelay
+ }),
+}
+
diff --git a/app/scripts/migrations/fail-tx.js b/app/scripts/migrations/fail-tx.js
new file mode 100644
index 000000000..98e3ffddb
--- /dev/null
+++ b/app/scripts/migrations/fail-tx.js
@@ -0,0 +1,41 @@
+const clone = require('clone')
+
+module.exports = function (version, reason, condition) {
+ return function (originalVersionedData) {
+ const versionedData = clone(originalVersionedData)
+ versionedData.meta.version = version
+ try {
+ const state = versionedData.data
+ const newState = transformState(state, condition, reason)
+ versionedData.data = newState
+ } catch (err) {
+ console.warn(`MetaMask Migration #${version}` + err.stack)
+ }
+ return Promise.resolve(versionedData)
+
+ }
+}
+
+function transformState (state, condition, reason) {
+ const newState = state
+ const { TransactionController } = newState
+ if (TransactionController && TransactionController.transactions) {
+ const transactions = TransactionController.transactions
+
+ newState.TransactionController.transactions = transactions.map((txMeta) => {
+ if (!condition(txMeta)) {
+ return txMeta
+ }
+
+ txMeta.status = 'failed'
+ txMeta.err = {
+ message: reason,
+ note: `Tx automatically failed by migration because ${reason}`,
+ }
+
+ return txMeta
+ })
+ }
+ return newState
+}
+
diff --git a/app/scripts/migrations/index.js b/app/scripts/migrations/index.js
index 3b512715e..9344b77ed 100644
--- a/app/scripts/migrations/index.js
+++ b/app/scripts/migrations/index.js
@@ -39,4 +39,5 @@ module.exports = [
require('./026'),
require('./027'),
require('./028'),
+ require('./029'),
]