diff options
author | Whymarrh Whitby <whymarrh.whitby@gmail.com> | 2019-04-12 08:03:33 +0800 |
---|---|---|
committer | Whymarrh Whitby <whymarrh.whitby@gmail.com> | 2019-04-12 08:20:06 +0800 |
commit | c4a3d4ea82ef5488c8c91db77beca85679447722 (patch) | |
tree | 510ab68434b7637e01fa83c569bbc327a3630703 /ISSUE_TEMPLATE | |
parent | 2786932576a92f8e75ee798d91c8222741c774c9 (diff) | |
download | tangerine-wallet-browser-c4a3d4ea82ef5488c8c91db77beca85679447722.tar tangerine-wallet-browser-c4a3d4ea82ef5488c8c91db77beca85679447722.tar.gz tangerine-wallet-browser-c4a3d4ea82ef5488c8c91db77beca85679447722.tar.bz2 tangerine-wallet-browser-c4a3d4ea82ef5488c8c91db77beca85679447722.tar.lz tangerine-wallet-browser-c4a3d4ea82ef5488c8c91db77beca85679447722.tar.xz tangerine-wallet-browser-c4a3d4ea82ef5488c8c91db77beca85679447722.tar.zst tangerine-wallet-browser-c4a3d4ea82ef5488c8c91db77beca85679447722.zip |
Remove unneeded array cloning in getSendToAccounts selector
The use of `Object.entries` here to map the accounts into a new array effectively
produces a shallow clone of the array without guaranteeing the order of the original
array (as object iteration order is implementation-specific and variable). From MDN [1]:
> The **`Object.entries()`** method returns an array of a given object's own enumerable
> string-keyed property `[key, value]` pairs, in the same order as that provided by a
> `for...in` loop
And also:
> The ordering of the properties is the same as that given by looping over the
> property values of the object manually.
Both of which suggest that the iteration order is the same as `for...in`, which is to
say that it's not specified. [2] [3]
This changeset removes the cloning, keeping the shallow clone created the line before
which preserves the order of the items in the array.
[1]:https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/entries
[2]:https://stackoverflow.com/a/5525820/1267663
[3]:https://stackoverflow.com/a/30919039/1267663
Diffstat (limited to 'ISSUE_TEMPLATE')
0 files changed, 0 insertions, 0 deletions