aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDan J Miller <danjm.com@gmail.com>2019-08-03 07:00:50 +0800
committerGitHub <noreply@github.com>2019-08-03 07:00:50 +0800
commit165f44d3a487adc580cc4b68580d3ac42a34bcd0 (patch)
treeccc14f04f635fb35ca87e8349c88b2fa20531f94
parent9d5be5d29fcdab1273e30810f87de4624b8622a1 (diff)
downloadtangerine-wallet-browser-165f44d3a487adc580cc4b68580d3ac42a34bcd0.tar
tangerine-wallet-browser-165f44d3a487adc580cc4b68580d3ac42a34bcd0.tar.gz
tangerine-wallet-browser-165f44d3a487adc580cc4b68580d3ac42a34bcd0.tar.bz2
tangerine-wallet-browser-165f44d3a487adc580cc4b68580d3ac42a34bcd0.tar.lz
tangerine-wallet-browser-165f44d3a487adc580cc4b68580d3ac42a34bcd0.tar.xz
tangerine-wallet-browser-165f44d3a487adc580cc4b68580d3ac42a34bcd0.tar.zst
tangerine-wallet-browser-165f44d3a487adc580cc4b68580d3ac42a34bcd0.zip
Address book name save fix (#6945)
* Fix address book name saving and ens input errors on good inputs on unsupported networks * Add initial e2e test for address book send flow. * No longer need to click recipient row in e2e tests * Click write button in address book e2e test on seed confirm screen * Use correct seed phrase and private key in address-book.spec tests
-rw-r--r--test/e2e/address-book.spec.js347
-rw-r--r--test/e2e/from-import-ui.spec.js4
-rw-r--r--test/e2e/metamask-responsive-ui.spec.js4
-rw-r--r--test/e2e/metamask-ui.spec.js16
-rwxr-xr-xtest/e2e/run-all.sh12
-rw-r--r--test/e2e/send-edit.spec.js4
-rw-r--r--ui/app/helpers/utils/util.js8
-rw-r--r--ui/app/pages/send/send-content/add-recipient/ens-input.component.js10
-rw-r--r--ui/app/pages/send/send-footer/send-footer.utils.js2
-rw-r--r--ui/app/pages/send/send.component.js1
10 files changed, 375 insertions, 33 deletions
diff --git a/test/e2e/address-book.spec.js b/test/e2e/address-book.spec.js
new file mode 100644
index 000000000..3c5e78b50
--- /dev/null
+++ b/test/e2e/address-book.spec.js
@@ -0,0 +1,347 @@
+const path = require('path')
+const assert = require('assert')
+const webdriver = require('selenium-webdriver')
+const { By, until } = webdriver
+const {
+ delay,
+ buildChromeWebDriver,
+ buildFirefoxWebdriver,
+ installWebExt,
+ getExtensionIdChrome,
+ getExtensionIdFirefox,
+} = require('./func')
+const {
+ checkBrowserForConsoleErrors,
+ closeAllWindowHandlesExcept,
+ findElement,
+ findElements,
+ loadExtension,
+ verboseReportOnFailure,
+} = require('./helpers')
+const fetchMockResponses = require('./fetch-mocks.js')
+
+describe('MetaMask', function () {
+ let extensionId
+ let driver
+
+ const testSeedPhrase = 'forum vessel pink push lonely enact gentle tail admit parrot grunt dress'
+ const tinyDelayMs = 200
+ const regularDelayMs = tinyDelayMs * 2
+ const largeDelayMs = regularDelayMs * 2
+
+ this.timeout(0)
+ this.bail(true)
+
+ before(async function () {
+ let extensionUrl
+ switch (process.env.SELENIUM_BROWSER) {
+ case 'chrome': {
+ const extPath = path.resolve('dist/chrome')
+ driver = buildChromeWebDriver(extPath)
+ extensionId = await getExtensionIdChrome(driver)
+ await delay(largeDelayMs)
+ extensionUrl = `chrome-extension://${extensionId}/home.html`
+ break
+ }
+ case 'firefox': {
+ const extPath = path.resolve('dist/firefox')
+ driver = buildFirefoxWebdriver()
+ await installWebExt(driver, extPath)
+ await delay(largeDelayMs)
+ extensionId = await getExtensionIdFirefox(driver)
+ extensionUrl = `moz-extension://${extensionId}/home.html`
+ break
+ }
+ }
+ // Depending on the state of the application built into the above directory (extPath) and the value of
+ // METAMASK_DEBUG we will see different post-install behaviour and possibly some extra windows. Here we
+ // are closing any extraneous windows to reset us to a single window before continuing.
+ const [tab1] = await driver.getAllWindowHandles()
+ await closeAllWindowHandlesExcept(driver, [tab1])
+ await driver.switchTo().window(tab1)
+ await driver.get(extensionUrl)
+ })
+
+ beforeEach(async function () {
+ await driver.executeScript(
+ 'window.origFetch = window.fetch.bind(window);' +
+ 'window.fetch = ' +
+ '(...args) => { ' +
+ 'if (args[0] === "https://ethgasstation.info/json/ethgasAPI.json") { return ' +
+ 'Promise.resolve({ json: () => Promise.resolve(JSON.parse(\'' + fetchMockResponses.ethGasBasic + '\')) }); } else if ' +
+ '(args[0] === "https://ethgasstation.info/json/predictTable.json") { return ' +
+ 'Promise.resolve({ json: () => Promise.resolve(JSON.parse(\'' + fetchMockResponses.ethGasPredictTable + '\')) }); } else if ' +
+ '(args[0].match(/chromeextensionmm/)) { return ' +
+ 'Promise.resolve({ json: () => Promise.resolve(JSON.parse(\'' + fetchMockResponses.metametrics + '\')) }); } else if ' +
+ '(args[0] === "https://dev.blockscale.net/api/gasexpress.json") { return ' +
+ 'Promise.resolve({ json: () => Promise.resolve(JSON.parse(\'' + fetchMockResponses.gasExpress + '\')) }); } ' +
+ 'return window.origFetch(...args); };' +
+ 'function cancelInfuraRequest(requestDetails) {' +
+ 'console.log("Canceling: " + requestDetails.url);' +
+ 'return {' +
+ 'cancel: true' +
+ '};' +
+ ' }' +
+ 'window.chrome && window.chrome.webRequest && window.chrome.webRequest.onBeforeRequest.addListener(' +
+ 'cancelInfuraRequest,' +
+ '{urls: ["https://*.infura.io/*"]},' +
+ '["blocking"]' +
+ ');'
+ )
+ })
+
+ afterEach(async function () {
+ if (process.env.SELENIUM_BROWSER === 'chrome') {
+ const errors = await checkBrowserForConsoleErrors(driver)
+ if (errors.length) {
+ const errorReports = errors.map(err => err.message)
+ const errorMessage = `Errors found in browser console:\n${errorReports.join('\n')}`
+ console.error(new Error(errorMessage))
+ }
+ }
+ if (this.currentTest.state === 'failed') {
+ await verboseReportOnFailure(driver, this.currentTest)
+ }
+ })
+
+ after(async function () {
+ await driver.quit()
+ })
+
+ describe('Going through the first time flow', () => {
+ it('clicks the continue button on the welcome screen', async () => {
+ await findElement(driver, By.css('.welcome-page__header'))
+ const welcomeScreenBtn = await findElement(driver, By.css('.first-time-flow__button'))
+ welcomeScreenBtn.click()
+ await delay(largeDelayMs)
+ })
+
+ it('clicks the "Create New Wallet" option', async () => {
+ const customRpcButton = await findElement(driver, By.xpath(`//button[contains(text(), 'Create a Wallet')]`))
+ customRpcButton.click()
+ await delay(largeDelayMs)
+ })
+
+ it('clicks the "No thanks" option on the metametrics opt-in screen', async () => {
+ const optOutButton = await findElement(driver, By.css('.btn-default'))
+ optOutButton.click()
+ await delay(largeDelayMs)
+ })
+
+ it('accepts a secure password', async () => {
+ const passwordBox = await findElement(driver, By.css('.first-time-flow__form #create-password'))
+ const passwordBoxConfirm = await findElement(driver, By.css('.first-time-flow__form #confirm-password'))
+ const button = await findElement(driver, By.css('.first-time-flow__form button'))
+
+ await passwordBox.sendKeys('correct horse battery staple')
+ await passwordBoxConfirm.sendKeys('correct horse battery staple')
+
+ const tosCheckBox = await findElement(driver, By.css('.first-time-flow__checkbox'))
+ await tosCheckBox.click()
+
+ await button.click()
+ await delay(regularDelayMs)
+ })
+
+ let seedPhrase
+
+ it('reveals the seed phrase', async () => {
+ const byRevealButton = By.css('.reveal-seed-phrase__secret-blocker .reveal-seed-phrase__reveal-button')
+ await driver.wait(until.elementLocated(byRevealButton, 10000))
+ const revealSeedPhraseButton = await findElement(driver, byRevealButton, 10000)
+ await revealSeedPhraseButton.click()
+ await delay(regularDelayMs)
+
+ seedPhrase = await driver.findElement(By.css('.reveal-seed-phrase__secret-words')).getText()
+ assert.equal(seedPhrase.split(' ').length, 12)
+ await delay(regularDelayMs)
+
+ const nextScreen = (await findElements(driver, By.css('button.first-time-flow__button')))[1]
+ await nextScreen.click()
+ await delay(regularDelayMs)
+ })
+
+ async function clickWordAndWait (word) {
+ const xpath = `//div[contains(@class, 'confirm-seed-phrase__seed-word--shuffled') and not(contains(@class, 'confirm-seed-phrase__seed-word--selected')) and contains(text(), '${word}')]`
+ const word0 = await findElement(driver, By.xpath(xpath), 10000)
+
+ await word0.click()
+ await delay(tinyDelayMs)
+ }
+
+ async function retypeSeedPhrase (words, wasReloaded, count = 0) {
+ try {
+ if (wasReloaded) {
+ const byRevealButton = By.css('.reveal-seed-phrase__secret-blocker .reveal-seed-phrase__reveal-button')
+ await driver.wait(until.elementLocated(byRevealButton, 10000))
+ const revealSeedPhraseButton = await findElement(driver, byRevealButton, 10000)
+ await revealSeedPhraseButton.click()
+ await delay(regularDelayMs)
+
+ const nextScreen = await findElement(driver, By.css('button.first-time-flow__button'))
+ await nextScreen.click()
+ await delay(regularDelayMs)
+ }
+
+ for (let i = 0; i < 12; i++) {
+ await clickWordAndWait(words[i])
+ }
+ } catch (e) {
+ if (count > 2) {
+ throw e
+ } else {
+ await loadExtension(driver, extensionId)
+ await retypeSeedPhrase(words, true, count + 1)
+ }
+ }
+ }
+
+ it('can retype the seed phrase', async () => {
+ const words = seedPhrase.split(' ')
+
+ await retypeSeedPhrase(words)
+
+ const confirm = await findElement(driver, By.xpath(`//button[contains(text(), 'Confirm')]`))
+ await confirm.click()
+ await delay(regularDelayMs)
+ })
+
+ it('clicks through the success screen', async () => {
+ await findElement(driver, By.xpath(`//div[contains(text(), 'Congratulations')]`))
+ const doneButton = await findElement(driver, By.css('button.first-time-flow__button'))
+ await doneButton.click()
+ await delay(regularDelayMs)
+ })
+ })
+
+ describe('Import seed phrase', () => {
+ it('logs out of the vault', async () => {
+ await driver.findElement(By.css('.account-menu__icon')).click()
+ await delay(regularDelayMs)
+
+ const logoutButton = await findElement(driver, By.css('.account-menu__logout-button'))
+ assert.equal(await logoutButton.getText(), 'Log out')
+ await logoutButton.click()
+ await delay(regularDelayMs)
+ })
+
+ it('imports seed phrase', async () => {
+ const restoreSeedLink = await findElement(driver, By.css('.unlock-page__link--import'))
+ assert.equal(await restoreSeedLink.getText(), 'Import using account seed phrase')
+ await restoreSeedLink.click()
+ await delay(regularDelayMs)
+
+ const seedTextArea = await findElement(driver, By.css('textarea'))
+ await seedTextArea.sendKeys(testSeedPhrase)
+ await delay(regularDelayMs)
+
+ const passwordInputs = await driver.findElements(By.css('input'))
+ await delay(regularDelayMs)
+
+ await passwordInputs[0].sendKeys('correct horse battery staple')
+ await passwordInputs[1].sendKeys('correct horse battery staple')
+ await driver.findElement(By.css('.first-time-flow__button')).click()
+ await delay(regularDelayMs)
+ })
+
+ it('balance renders', async () => {
+ const balance = await findElement(driver, By.css('.balance-display .token-amount'))
+ await driver.wait(until.elementTextMatches(balance, /25\s*ETH/))
+ await delay(regularDelayMs)
+ })
+ })
+
+ describe('Adds an entry to the address book and sends eth to that address', () => {
+ it('starts a send transaction', async function () {
+ const sendButton = await findElement(driver, By.xpath(`//button[contains(text(), 'Send')]`))
+ await sendButton.click()
+ await delay(regularDelayMs)
+
+ const inputAddress = await findElement(driver, By.css('input[placeholder="Search, public address (0x), or ENS"]'))
+ await inputAddress.sendKeys('0x2f318C334780961FB129D2a6c30D0763d9a5C970')
+ await delay(regularDelayMs)
+
+ const addToAddressBookButton = await findElement(driver, By.css('.dialog.send__dialog.dialog--message'))
+ await addToAddressBookButton.click()
+
+ const addressBookAddModal = await driver.findElement(By.css('span .modal'))
+ await findElement(driver, By.css('.add-to-address-book-modal'))
+ const addressBookInput = await findElement(driver, By.css('.add-to-address-book-modal__input'))
+ await addressBookInput.sendKeys('Test Name 1')
+ await delay(tinyDelayMs)
+ const addressBookSaveButton = await findElement(driver, By.css('.add-to-address-book-modal__footer .btn-primary'))
+ await addressBookSaveButton.click()
+
+ await driver.wait(until.stalenessOf(addressBookAddModal))
+
+ const inputAmount = await findElement(driver, By.css('.unit-input__input'))
+ await inputAmount.sendKeys('1')
+
+ const inputValue = await inputAmount.getAttribute('value')
+ assert.equal(inputValue, '1')
+ await delay(regularDelayMs)
+
+ // Continue to next screen
+ const nextScreen = await findElement(driver, By.xpath(`//button[contains(text(), 'Next')]`))
+ await nextScreen.click()
+ await delay(regularDelayMs)
+ })
+
+ it('confirms the transaction', async function () {
+ const confirmButton = await findElement(driver, By.xpath(`//button[contains(text(), 'Confirm')]`))
+ await confirmButton.click()
+ await delay(largeDelayMs * 2)
+ })
+
+ it('finds the transaction in the transactions list', async function () {
+ const transactions = await findElements(driver, By.css('.transaction-list-item'))
+ assert.equal(transactions.length, 1)
+
+ if (process.env.SELENIUM_BROWSER !== 'firefox') {
+ const txValues = await findElement(driver, By.css('.transaction-list-item__amount--primary'))
+ await driver.wait(until.elementTextMatches(txValues, /-1\s*ETH/), 10000)
+ }
+ })
+ })
+
+ describe('Sends to an address book entry', () => {
+ it('starts a send transaction by clicking address book entry', async function () {
+ const sendButton = await findElement(driver, By.xpath(`//button[contains(text(), 'Send')]`))
+ await sendButton.click()
+ await delay(regularDelayMs)
+
+ const recipientRow = await findElement(driver, By.css('.send__select-recipient-wrapper__group-item'))
+ const recipientRowTitle = await findElement(driver, By.css('.send__select-recipient-wrapper__group-item__title'))
+ const recipientRowTitleString = await recipientRowTitle.getText()
+ assert.equal(recipientRowTitleString, 'Test Name 1')
+
+ await recipientRow.click()
+
+ await delay(regularDelayMs)
+ const inputAmount = await findElement(driver, By.css('.unit-input__input'))
+ await inputAmount.sendKeys('2')
+ await delay(regularDelayMs)
+
+ // Continue to next screen
+ const nextScreen = await findElement(driver, By.xpath(`//button[contains(text(), 'Next')]`))
+ await nextScreen.click()
+ await delay(regularDelayMs)
+ })
+
+ it('confirms the transaction', async function () {
+ const confirmButton = await findElement(driver, By.xpath(`//button[contains(text(), 'Confirm')]`))
+ await confirmButton.click()
+ await delay(largeDelayMs * 2)
+ })
+
+ it('finds the transaction in the transactions list', async function () {
+ const transactions = await findElements(driver, By.css('.transaction-list-item'))
+ assert.equal(transactions.length, 2)
+
+ if (process.env.SELENIUM_BROWSER !== 'firefox') {
+ const txValues = await findElement(driver, By.css('.transaction-list-item__amount--primary'))
+ await driver.wait(until.elementTextMatches(txValues, /-2\s*ETH/), 10000)
+ }
+ })
+ })
+})
diff --git a/test/e2e/from-import-ui.spec.js b/test/e2e/from-import-ui.spec.js
index e420f03ed..896447c77 100644
--- a/test/e2e/from-import-ui.spec.js
+++ b/test/e2e/from-import-ui.spec.js
@@ -258,10 +258,6 @@ describe('Using MetaMask with an existing account', function () {
const inputAddress = await findElement(driver, By.css('input[placeholder="Search, public address (0x), or ENS"]'))
await inputAddress.sendKeys('0x2f318C334780961FB129D2a6c30D0763d9a5C970')
- const recipientRow = await findElement(driver, By.css('.send__select-recipient-wrapper__group-item'))
- await recipientRow.click()
- await delay(regularDelayMs)
-
const inputAmount = await findElement(driver, By.css('.unit-input__input'))
await inputAmount.sendKeys('1')
diff --git a/test/e2e/metamask-responsive-ui.spec.js b/test/e2e/metamask-responsive-ui.spec.js
index b5d829ab4..fa7425d61 100644
--- a/test/e2e/metamask-responsive-ui.spec.js
+++ b/test/e2e/metamask-responsive-ui.spec.js
@@ -279,10 +279,6 @@ describe('MetaMask', function () {
const inputAddress = await findElement(driver, By.css('input[placeholder="Search, public address (0x), or ENS"]'))
await inputAddress.sendKeys('0x2f318C334780961FB129D2a6c30D0763d9a5C970')
- const recipientRow = await findElement(driver, By.css('.send__select-recipient-wrapper__group-item'))
- await recipientRow.click()
- await delay(regularDelayMs)
-
const inputAmount = await findElement(driver, By.css('.unit-input__input'))
await inputAmount.sendKeys('1')
diff --git a/test/e2e/metamask-ui.spec.js b/test/e2e/metamask-ui.spec.js
index ef1ec6d47..8d0942dc6 100644
--- a/test/e2e/metamask-ui.spec.js
+++ b/test/e2e/metamask-ui.spec.js
@@ -325,10 +325,6 @@ describe('MetaMask', function () {
const inputAddress = await findElement(driver, By.css('input[placeholder="Search, public address (0x), or ENS"]'))
await inputAddress.sendKeys('0x2f318C334780961FB129D2a6c30D0763d9a5C970')
- const recipientRow = await findElement(driver, By.css('.send__select-recipient-wrapper__group-item'))
- await recipientRow.click()
- await delay(regularDelayMs)
-
const inputAmount = await findElement(driver, By.css('.unit-input__input'))
await inputAmount.sendKeys('1000')
@@ -395,10 +391,6 @@ describe('MetaMask', function () {
const inputAddress = await findElement(driver, By.css('input[placeholder="Search, public address (0x), or ENS"]'))
await inputAddress.sendKeys('0x2f318C334780961FB129D2a6c30D0763d9a5C970')
- const recipientRow = await findElement(driver, By.css('.send__select-recipient-wrapper__group-item'))
- await recipientRow.click()
- await delay(regularDelayMs)
-
const inputAmount = await findElement(driver, By.css('.unit-input__input'))
await inputAmount.sendKeys('1')
@@ -442,10 +434,6 @@ describe('MetaMask', function () {
const inputAddress = await findElement(driver, By.css('input[placeholder="Search, public address (0x), or ENS"]'))
await inputAddress.sendKeys('0x2f318C334780961FB129D2a6c30D0763d9a5C970')
- const recipientRow = await findElement(driver, By.css('.send__select-recipient-wrapper__group-item'))
- await recipientRow.click()
- await delay(regularDelayMs)
-
const inputAmount = await findElement(driver, By.css('.unit-input__input'))
await inputAmount.sendKeys('1')
@@ -1050,10 +1038,6 @@ describe('MetaMask', function () {
const inputAddress = await findElement(driver, By.css('input[placeholder="Search, public address (0x), or ENS"]'))
await inputAddress.sendKeys('0x2f318C334780961FB129D2a6c30D0763d9a5C970')
- const recipientRow = await findElement(driver, By.css('.send__select-recipient-wrapper__group-item'))
- await recipientRow.click()
- await delay(regularDelayMs)
-
const inputAmount = await findElement(driver, By.css('.unit-input__input'))
await inputAmount.sendKeys('1')
diff --git a/test/e2e/run-all.sh b/test/e2e/run-all.sh
index 6f3f5e9be..0e3fdfcc4 100755
--- a/test/e2e/run-all.sh
+++ b/test/e2e/run-all.sh
@@ -32,7 +32,6 @@ concurrently --kill-others \
'yarn ganache:start' \
'sleep 5 && mocha test/e2e/from-import-ui.spec'
-
export GANACHE_ARGS="$GANACHE_ARGS --deterministic --account=0x53CB0AB5226EEBF4D872113D98332C1555DC304443BEE1CF759D15798D3C55A9,25000000000000000000"
concurrently --kill-others \
--names 'ganache,e2e' \
@@ -41,6 +40,7 @@ concurrently --kill-others \
'npm run ganache:start' \
'sleep 5 && mocha test/e2e/send-edit.spec'
+
export GANACHE_ARGS="$GANACHE_ARGS --deterministic --account=0x250F458997A364988956409A164BA4E16F0F99F916ACDD73ADCD3A1DE30CF8D1,0 --account=0x53CB0AB5226EEBF4D872113D98332C1555DC304443BEE1CF759D15798D3C55A9,25000000000000000000"
concurrently --kill-others \
--names 'ganache,sendwithprivatedapp,e2e' \
@@ -49,3 +49,13 @@ concurrently --kill-others \
'npm run ganache:start' \
'npm run sendwithprivatedapp' \
'sleep 5 && mocha test/e2e/incremental-security.spec'
+
+export GANACHE_ARGS="$GANACHE_ARGS --deterministic --account=0x53CB0AB5226EEBF4D872113D98332C1555DC304443BEE1CF759D15798D3C55A9,25000000000000000000"
+concurrently --kill-others \
+ --names 'ganache,dapp,e2e' \
+ --prefix '[{time}][{name}]' \
+ --success first \
+ 'yarn ganache:start' \
+ 'yarn dapp' \
+ 'sleep 5 && mocha test/e2e/address-book.spec'
+
diff --git a/test/e2e/send-edit.spec.js b/test/e2e/send-edit.spec.js
index b04e52f7f..4eca232ee 100644
--- a/test/e2e/send-edit.spec.js
+++ b/test/e2e/send-edit.spec.js
@@ -163,10 +163,6 @@ describe('Using MetaMask with an existing account', function () {
const inputAddress = await findElement(driver, By.css('input[placeholder="Search, public address (0x), or ENS"]'))
await inputAddress.sendKeys('0x2f318C334780961FB129D2a6c30D0763d9a5C970')
- const recipientRow = await findElement(driver, By.css('.send__select-recipient-wrapper__group-item'))
- await recipientRow.click()
- await delay(regularDelayMs)
-
const inputAmount = await findElement(driver, By.css('.unit-input__input'))
await inputAmount.sendKeys('1')
diff --git a/ui/app/helpers/utils/util.js b/ui/app/helpers/utils/util.js
index 94fa9ad42..b9e8e83c5 100644
--- a/ui/app/helpers/utils/util.js
+++ b/ui/app/helpers/utils/util.js
@@ -61,6 +61,7 @@ module.exports = {
checksumAddress,
addressSlicer,
isEthNetwork,
+ isValidAddressHead,
}
function isEthNetwork (netId) {
@@ -323,3 +324,10 @@ function addressSlicer (address = '') {
return `${address.slice(0, 6)}...${address.slice(-4)}`
}
+
+function isValidAddressHead (address) {
+ const addressLengthIsLessThanFull = address.length < 42
+ const addressIsHex = isHex(address)
+
+ return addressLengthIsLessThanFull && addressIsHex
+}
diff --git a/ui/app/pages/send/send-content/add-recipient/ens-input.component.js b/ui/app/pages/send/send-content/add-recipient/ens-input.component.js
index c8d022079..498d72605 100644
--- a/ui/app/pages/send/send-content/add-recipient/ens-input.component.js
+++ b/ui/app/pages/send/send-content/add-recipient/ens-input.component.js
@@ -1,7 +1,7 @@
import React, { Component } from 'react'
import PropTypes from 'prop-types'
import c from 'classnames'
-import { isValidENSAddress, isValidAddress } from '../../../../helpers/utils/util'
+import { isValidENSAddress, isValidAddress, isValidAddressHead } from '../../../../helpers/utils/util'
import {ellipsify} from '../../send.utils'
import debounce from 'debounce'
@@ -33,6 +33,7 @@ export default class EnsInput extends Component {
addressBook: PropTypes.array,
onPaste: PropTypes.func,
onReset: PropTypes.func,
+ onValidAddressTyped: PropTypes.func,
}
state = {
@@ -108,7 +109,7 @@ export default class EnsInput extends Component {
}
onChange = e => {
- const { network, onChange, updateEnsResolution, updateEnsResolutionError } = this.props
+ const { network, onChange, updateEnsResolution, updateEnsResolutionError, onValidAddressTyped } = this.props
const input = e.target.value
const networkHasEnsSupport = getNetworkEnsSupport(network)
@@ -116,7 +117,8 @@ export default class EnsInput extends Component {
// Empty ENS state if input is empty
// maybe scan ENS
- if (!input || isValidAddress(input) || !networkHasEnsSupport) {
+
+ if (!networkHasEnsSupport && !isValidAddress(input) && !isValidAddressHead(input)) {
updateEnsResolution('')
updateEnsResolutionError(!networkHasEnsSupport ? 'Network does not support ENS' : '')
return
@@ -124,6 +126,8 @@ export default class EnsInput extends Component {
if (isValidENSAddress(input)) {
this.lookupEnsName(input)
+ } else if (onValidAddressTyped && isValidAddress(input)) {
+ onValidAddressTyped(input)
} else {
updateEnsResolution('')
updateEnsResolutionError('')
diff --git a/ui/app/pages/send/send-footer/send-footer.utils.js b/ui/app/pages/send/send-footer/send-footer.utils.js
index 91ac29014..ce65535a6 100644
--- a/ui/app/pages/send/send-footer/send-footer.utils.js
+++ b/ui/app/pages/send/send-footer/send-footer.utils.js
@@ -76,7 +76,7 @@ function constructUpdatedTx ({
function addressIsNew (toAccounts, newAddress) {
const newAddressNormalized = newAddress.toLowerCase()
- const foundMatching = toAccounts.some(({ address }) => address === newAddressNormalized)
+ const foundMatching = toAccounts.some(({ address }) => address.toLowerCase() === newAddressNormalized)
return !foundMatching
}
diff --git a/ui/app/pages/send/send.component.js b/ui/app/pages/send/send.component.js
index 9cdf75536..cb07dcb59 100644
--- a/ui/app/pages/send/send.component.js
+++ b/ui/app/pages/send/send.component.js
@@ -303,6 +303,7 @@ export default class SendTransactionScreen extends PersistentForm {
this.props.scanQrCode()
}}
onChange={this.onRecipientInputChange}
+ onValidAddressTyped={(address) => this.props.updateSendTo(address, '')}
onPaste={text => this.props.updateSendTo(text)}
onReset={() => this.props.updateSendTo('', '')}
updateEnsResolution={this.props.updateSendEnsResolution}