diff options
author | Dan Miller <danjm.com@gmail.com> | 2018-10-10 00:53:48 +0800 |
---|---|---|
committer | Dan Miller <danjm.com@gmail.com> | 2018-12-04 11:36:05 +0800 |
commit | 6f8e2b1ad94fd70c3be976ef88179dc00ceebb45 (patch) | |
tree | cca1164e37cac4290d5eee2b9de1ba7f532c8c62 | |
parent | b95eb30ec60e4d169a61d987ad86fe333aa49523 (diff) | |
download | tangerine-wallet-browser-6f8e2b1ad94fd70c3be976ef88179dc00ceebb45.tar tangerine-wallet-browser-6f8e2b1ad94fd70c3be976ef88179dc00ceebb45.tar.gz tangerine-wallet-browser-6f8e2b1ad94fd70c3be976ef88179dc00ceebb45.tar.bz2 tangerine-wallet-browser-6f8e2b1ad94fd70c3be976ef88179dc00ceebb45.tar.lz tangerine-wallet-browser-6f8e2b1ad94fd70c3be976ef88179dc00ceebb45.tar.xz tangerine-wallet-browser-6f8e2b1ad94fd70c3be976ef88179dc00ceebb45.tar.zst tangerine-wallet-browser-6f8e2b1ad94fd70c3be976ef88179dc00ceebb45.zip |
Clean up for advanced gas tab customization changes.
3 files changed, 16 insertions, 19 deletions
diff --git a/app/_locales/en/messages.json b/app/_locales/en/messages.json index 1fd4c8e1e..31a2f0826 100644 --- a/app/_locales/en/messages.json +++ b/app/_locales/en/messages.json @@ -1084,6 +1084,9 @@ "send": { "message": "Send" }, + "sendAmount": { + "message": "Send Amount" + }, "sendETH": { "message": "Send ETH" }, diff --git a/ui/app/components/gas-customization/gas-modal-page-container/advanced-tab-content/tests/advanced-tab-content-component.test.js b/ui/app/components/gas-customization/gas-modal-page-container/advanced-tab-content/tests/advanced-tab-content-component.test.js index 1489c7696..14863e59d 100644 --- a/ui/app/components/gas-customization/gas-modal-page-container/advanced-tab-content/tests/advanced-tab-content-component.test.js +++ b/ui/app/components/gas-customization/gas-modal-page-container/advanced-tab-content/tests/advanced-tab-content-component.test.js @@ -68,10 +68,6 @@ describe('AdvancedTabContent Component', function () { 11, propsMethodSpies.updateCustomGasPrice, 23456, propsMethodSpies.updateCustomGasLimit, ]) }) - - it('should call renderGasEditRows with the expected params', () => { - - }) }) describe('renderDataSummary()', () => { diff --git a/ui/app/components/gas-customization/gas-modal-page-container/gas-modal-page-container.component.js b/ui/app/components/gas-customization/gas-modal-page-container/gas-modal-page-container.component.js index 07e55a1f0..88ef921c5 100644 --- a/ui/app/components/gas-customization/gas-modal-page-container/gas-modal-page-container.component.js +++ b/ui/app/components/gas-customization/gas-modal-page-container/gas-modal-page-container.component.js @@ -52,32 +52,30 @@ export default class GasModalPageContainer extends Component { updateCustomGasLimit={convertThenUpdateCustomGasLimit} customGasPrice={customGasPrice} customGasLimit={customGasLimit} - timeRemaining={'1 min 31 sec'} + timeRemaining="1 min 31 sec" totalFee={newTotalFiat} /> ) } renderInfoRows (newTotalFiat, newTotalEth, sendAmount, transactionFee) { - const baseClassName = 'gas-modal-content__info-row' - return ( <div> - <div className={baseClassName}> - <div className={`${baseClassName}__send-info`}> - <span className={`${baseClassName}__send-info__label`}>{`Send Amount`}</span> - <span className={`${baseClassName}__send-info__value`}>{sendAmount}</span> + <div className="gas-modal-content__info-row"> + <div className="gas-modal-content__info-row__send-info"> + <span className="gas-modal-content__info-row__send-info__label">{this.context.t('sendAmount')}</span> + <span className="gas-modal-content__info-row__send-info__value">{sendAmount}</span> </div> - <div className={`${baseClassName}__transaction-info`}> - <span className={`${baseClassName}__transaction-info__label`}>{`Transaction Fee`}</span> - <span className={`${baseClassName}__transaction-info__value`}>{transactionFee}</span> + <div className="gas-modal-content__info-row__transaction-info"> + <span className={'gas-modal-content__info-row__transaction-info__label'}>{this.context.t('transactionFee')}</span> + <span className="gas-modal-content__info-row__transaction-info__value">{transactionFee}</span> </div> - <div className={`${baseClassName}__total-info`}> - <span className={`${baseClassName}__total-info__label`}>{`New Total`}</span> - <span className={`${baseClassName}__total-info__value`}>{newTotalEth}</span> + <div className="gas-modal-content__info-row__total-info"> + <span className="gas-modal-content__info-row__total-info__label">{this.context.t('newTotal')}</span> + <span className="gas-modal-content__info-row__total-info__value">{newTotalEth}</span> </div> - <div className={`${baseClassName}__fiat-total-info`}> - <span className={`${baseClassName}__fiat-total-info__value`}>{newTotalFiat}</span> + <div className="gas-modal-content__info-row__fiat-total-info"> + <span className="gas-modal-content__info-row__fiat-total-info__value">{newTotalFiat}</span> </div> </div> </div> |