aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNoah Zinsmeister <noahwz@gmail.com>2018-12-10 21:17:52 +0800
committerWhymarrh Whitby <whymarrh.whitby@gmail.com>2018-12-10 21:17:52 +0800
commit49971e9ec250888746546f62fa176ed129bf9c74 (patch)
tree7ef8ece9fe372febf1a46030904979e0b7d5a4a2
parentd8ab9cc002c10757b7382a174dafff7a0247e307 (diff)
downloadtangerine-wallet-browser-49971e9ec250888746546f62fa176ed129bf9c74.tar
tangerine-wallet-browser-49971e9ec250888746546f62fa176ed129bf9c74.tar.gz
tangerine-wallet-browser-49971e9ec250888746546f62fa176ed129bf9c74.tar.bz2
tangerine-wallet-browser-49971e9ec250888746546f62fa176ed129bf9c74.tar.lz
tangerine-wallet-browser-49971e9ec250888746546f62fa176ed129bf9c74.tar.xz
tangerine-wallet-browser-49971e9ec250888746546f62fa176ed129bf9c74.tar.zst
tangerine-wallet-browser-49971e9ec250888746546f62fa176ed129bf9c74.zip
fix formatting of 32-byte strings in personal_sign (#5878)
-rw-r--r--CHANGELOG.md1
-rw-r--r--ui/app/components/signature-request.js2
2 files changed, 2 insertions, 1 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md
index f8c1937af..fd1348178 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -11,6 +11,7 @@
## 5.0.4 Thu Nov 29 2018
+- [#5878](https://github.com/MetaMask/metamask-extension/pull/5878): Formats 32-length byte strings passed to personal_sign as hex, rather than UTF8.
- [#5840](https://github.com/MetaMask/metamask-extension/pull/5840): transactions/tx-gas-utils - add the acctual response for eth_getCode for NO_CONTRACT_ERROR's && add a debug object to simulationFailed
- [#5848](https://github.com/MetaMask/metamask-extension/pull/5848): Soften accusatory language on phishing warning
- [#5835](https://github.com/MetaMask/metamask-extension/pull/5835): Open full-screen UI on install
diff --git a/ui/app/components/signature-request.js b/ui/app/components/signature-request.js
index 85af3b00b..715fea13f 100644
--- a/ui/app/components/signature-request.js
+++ b/ui/app/components/signature-request.js
@@ -164,7 +164,7 @@ SignatureRequest.prototype.msgHexToText = function (hex) {
try {
const stripped = ethUtil.stripHexPrefix(hex)
const buff = Buffer.from(stripped, 'hex')
- return buff.toString('utf8')
+ return buff.length === 32 ? hex : buff.toString('utf8')
} catch (e) {
return hex
}