aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDan Finlay <flyswatter@users.noreply.github.com>2017-01-17 02:12:49 +0800
committerGitHub <noreply@github.com>2017-01-17 02:12:49 +0800
commit15e91f823ce5bc09410b1985aff34ef00825da5b (patch)
treec35f894fd7ba2be00254d74662588a18ecfbb94e
parent86c0eaa5a430c1837f9ae203e3f0cadb88d0b777 (diff)
parent83468cbd032533542fea934e57d35f9ccec895de (diff)
downloadtangerine-wallet-browser-15e91f823ce5bc09410b1985aff34ef00825da5b.tar
tangerine-wallet-browser-15e91f823ce5bc09410b1985aff34ef00825da5b.tar.gz
tangerine-wallet-browser-15e91f823ce5bc09410b1985aff34ef00825da5b.tar.bz2
tangerine-wallet-browser-15e91f823ce5bc09410b1985aff34ef00825da5b.tar.lz
tangerine-wallet-browser-15e91f823ce5bc09410b1985aff34ef00825da5b.tar.xz
tangerine-wallet-browser-15e91f823ce5bc09410b1985aff34ef00825da5b.tar.zst
tangerine-wallet-browser-15e91f823ce5bc09410b1985aff34ef00825da5b.zip
Merge pull request #1004 from MetaMask/doubleRenderIssue
Dont render conf-tx if their are no txParams to show
-rw-r--r--CHANGELOG.md1
-rw-r--r--ui/app/conf-tx.js6
2 files changed, 5 insertions, 2 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 113d2f7cd..47ea81606 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,6 +2,7 @@
## Current Master
+- Fix Bug where you see a empty transaction flash by on the confirm transaction view.
- Create visible difference in transaction history between a approved but not yet included in a block transaction and a transaction who has been confirmed.
- Fix memory leak in RPC Cache
- Override RPC commands eth_syncing and web3_clientVersion
diff --git a/ui/app/conf-tx.js b/ui/app/conf-tx.js
index 8d8285f3d..8e255a867 100644
--- a/ui/app/conf-tx.js
+++ b/ui/app/conf-tx.js
@@ -43,9 +43,11 @@ ConfirmTxScreen.prototype.render = function () {
var unconfMsgs = state.unconfMsgs
var unconfTxList = txHelper(unconfTxs, unconfMsgs, network)
var index = state.index !== undefined ? state.index : 0
- var txData = unconfTxList[index] || {txParams: {}}
- var txParams = txData.txParams || {}
+ var txData = unconfTxList[index] || {}
+ var txParams = txData.txParams
var isNotification = isPopupOrNotification() === 'notification'
+ if (!txParams) return null
+
return (
h('.flex-column.flex-grow', [