aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDan Finlay <dan@danfinlay.com>2016-10-27 02:38:09 +0800
committerDan Finlay <dan@danfinlay.com>2016-10-27 02:38:09 +0800
commit0bf139188e4bd820a16203f161d29c9d2c8fb398 (patch)
treeec049a67fb02d34a682d3b03e0a6c5216b55bb4d
parentc834b4f637b5bd0b8d579b1a826c4ca529e65c39 (diff)
parent2dad59b56194a4094130ad8895340c0b084465c7 (diff)
downloadtangerine-wallet-browser-0bf139188e4bd820a16203f161d29c9d2c8fb398.tar
tangerine-wallet-browser-0bf139188e4bd820a16203f161d29c9d2c8fb398.tar.gz
tangerine-wallet-browser-0bf139188e4bd820a16203f161d29c9d2c8fb398.tar.bz2
tangerine-wallet-browser-0bf139188e4bd820a16203f161d29c9d2c8fb398.tar.lz
tangerine-wallet-browser-0bf139188e4bd820a16203f161d29c9d2c8fb398.tar.xz
tangerine-wallet-browser-0bf139188e4bd820a16203f161d29c9d2c8fb398.tar.zst
tangerine-wallet-browser-0bf139188e4bd820a16203f161d29c9d2c8fb398.zip
Merge branch 'master' into i762-RenameWalletToAccount
-rw-r--r--CHANGELOG.md2
-rw-r--r--ui/app/app.js15
-rw-r--r--ui/app/components/drop-menu-item.js2
3 files changed, 10 insertions, 9 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md
index ba2e25f27..fa0fb5a63 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -4,6 +4,8 @@
- Add a check for improper Transaction data.
- Now nicknaming new accounts "Account #" instead of "Wallet #" for clarity.
+- Fix bug where custom provider selection could show duplicate items.
+- Fix bug where connecting to a local morden node would make two providers appear selected.
- Fix bug that was sometimes preventing transactions from being sent.
## 2.13.5 2016-10-18
diff --git a/ui/app/app.js b/ui/app/app.js
index 71e0637d0..ae6fe7071 100644
--- a/ui/app/app.js
+++ b/ui/app/app.js
@@ -240,6 +240,7 @@ App.prototype.renderNetworkDropdown = function () {
action: () => props.dispatch(actions.setProviderType('testnet')),
icon: h('.menu-icon.red-dot'),
activeNetworkRender: props.network,
+ provider: props.provider,
}),
h(DropMenuItem, {
@@ -250,13 +251,6 @@ App.prototype.renderNetworkDropdown = function () {
activeNetworkRender: props.provider.rpcTarget,
}),
- h(DropMenuItem, {
- label: 'Custom RPC',
- closeMenu: () => this.setState({ isNetworkMenuOpen: false }),
- action: () => this.props.dispatch(actions.showConfigPage()),
- icon: h('i.fa.fa-question-circle.fa-lg'),
- }),
-
this.renderCustomOption(props.provider.rpcTarget),
])
}
@@ -508,7 +502,12 @@ App.prototype.toggleMetamaskActive = function () {
App.prototype.renderCustomOption = function (rpcTarget) {
switch (rpcTarget) {
case undefined:
- return null
+ return h(DropMenuItem, {
+ label: 'Custom RPC',
+ closeMenu: () => this.setState({ isNetworkMenuOpen: false }),
+ action: () => this.props.dispatch(actions.showConfigPage()),
+ icon: h('i.fa.fa-question-circle.fa-lg'),
+ })
case 'http://localhost:8545':
return h(DropMenuItem, {
diff --git a/ui/app/components/drop-menu-item.js b/ui/app/components/drop-menu-item.js
index 0ca1988c6..8088680c0 100644
--- a/ui/app/components/drop-menu-item.js
+++ b/ui/app/components/drop-menu-item.js
@@ -42,7 +42,7 @@ DropMenuItem.prototype.activeNetworkRender = function () {
if (providerType === 'mainnet') return h('.check', '✓')
break
case 'Morden Test Network':
- if (activeNetwork === '2') return h('.check', '✓')
+ if (provider.type === 'testnet') return h('.check', '✓')
break
case 'Localhost 8545':
if (activeNetwork === 'http://localhost:8545') return h('.check', '✓')