aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKevin Serrano <kevgagser@gmail.com>2016-08-25 07:20:59 +0800
committerGitHub <noreply@github.com>2016-08-25 07:20:59 +0800
commit07e5f94da817d56d5e096213b7af91fc2e0bb85a (patch)
tree53f6d83ded894c0b4b16b92cf81bcabb82eff818
parentc8c77aa8bd03125261e094b0cb264ed9fa9d9d77 (diff)
parenteee08457e51c6d4a4d4817671b93fa57933e338f (diff)
downloadtangerine-wallet-browser-07e5f94da817d56d5e096213b7af91fc2e0bb85a.tar
tangerine-wallet-browser-07e5f94da817d56d5e096213b7af91fc2e0bb85a.tar.gz
tangerine-wallet-browser-07e5f94da817d56d5e096213b7af91fc2e0bb85a.tar.bz2
tangerine-wallet-browser-07e5f94da817d56d5e096213b7af91fc2e0bb85a.tar.lz
tangerine-wallet-browser-07e5f94da817d56d5e096213b7af91fc2e0bb85a.tar.xz
tangerine-wallet-browser-07e5f94da817d56d5e096213b7af91fc2e0bb85a.tar.zst
tangerine-wallet-browser-07e5f94da817d56d5e096213b7af91fc2e0bb85a.zip
Merge pull request #581 from MetaMask/i484PersistPendingSignatures
Fix bug where unconfirmed message sig is lost when locked.
-rw-r--r--CHANGELOG.md1
-rw-r--r--app/scripts/metamask-controller.js1
2 files changed, 2 insertions, 0 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 20720e59d..aad989678 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,6 +5,7 @@
- Added static image as fallback for when WebGL isn't supported.
- Transaction history now has a hard limit.
- Added info link on account screen that visits Etherscan.
+- Fixed bug where a message signing request would be lost if the vault was locked.
- Added shortcut to open MetaMask (Ctrl+Alt+M or Cmd+Opt/Alt+M)
- Prevent API calls in tests.
- Fixed bug where sign message confirmation would sometimes render blank.
diff --git a/app/scripts/metamask-controller.js b/app/scripts/metamask-controller.js
index 218f1f72a..d53094e43 100644
--- a/app/scripts/metamask-controller.js
+++ b/app/scripts/metamask-controller.js
@@ -208,6 +208,7 @@ module.exports = class MetamaskController {
newUnsignedMessage (msgParams, cb) {
var state = this.idStore.getState()
if (!state.isUnlocked) {
+ this.idStore.addUnconfirmedMessage(msgParams, cb)
this.opts.unlockAccountMessage()
} else {
this.addUnconfirmedMessage(msgParams, cb)