diff options
| author | Dan J Miller <danjm.com@gmail.com> | 2018-08-09 08:43:41 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-08-09 08:43:41 +0800 |
| commit | d4af5b7bec19e034563f6b4b6e61cc1764bf6aaf (patch) | |
| tree | 336d6716b8752d5f23da89b739a6289aa7db9739 | |
| parent | 1ae668fa5e28e78bff542a363a2b72e4d0106479 (diff) | |
| parent | 973325a6c40c7721ee044d3a9308e58691974e24 (diff) | |
| download | tangerine-wallet-browser-d4af5b7bec19e034563f6b4b6e61cc1764bf6aaf.tar tangerine-wallet-browser-d4af5b7bec19e034563f6b4b6e61cc1764bf6aaf.tar.gz tangerine-wallet-browser-d4af5b7bec19e034563f6b4b6e61cc1764bf6aaf.tar.bz2 tangerine-wallet-browser-d4af5b7bec19e034563f6b4b6e61cc1764bf6aaf.tar.lz tangerine-wallet-browser-d4af5b7bec19e034563f6b4b6e61cc1764bf6aaf.tar.xz tangerine-wallet-browser-d4af5b7bec19e034563f6b4b6e61cc1764bf6aaf.tar.zst tangerine-wallet-browser-d4af5b7bec19e034563f6b4b6e61cc1764bf6aaf.zip | |
Merge pull request #5000 from MetaMask/contract-method-conf-sim-failure
Show error while allowing confirmation of tx where simulation fails
| -rw-r--r-- | ui/app/components/pages/confirm-transaction-base/confirm-transaction-base.component.js | 2 | ||||
| -rw-r--r-- | ui/app/constants/error-keys.js | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/ui/app/components/pages/confirm-transaction-base/confirm-transaction-base.component.js b/ui/app/components/pages/confirm-transaction-base/confirm-transaction-base.component.js index b170880b4..961aa304e 100644 --- a/ui/app/components/pages/confirm-transaction-base/confirm-transaction-base.component.js +++ b/ui/app/components/pages/confirm-transaction-base/confirm-transaction-base.component.js @@ -124,7 +124,7 @@ export default class ConfirmTransactionBase extends Component { if (simulationFails) { return { - valid: false, + valid: true, errorKey: TRANSACTION_ERROR_KEY, } } diff --git a/ui/app/constants/error-keys.js b/ui/app/constants/error-keys.js index 1b89be62e..f70ed3b19 100644 --- a/ui/app/constants/error-keys.js +++ b/ui/app/constants/error-keys.js @@ -1,3 +1,3 @@ export const INSUFFICIENT_FUNDS_ERROR_KEY = 'insufficientFunds' export const GAS_LIMIT_TOO_LOW_ERROR_KEY = 'gasLimitTooLow' -export const TRANSACTION_ERROR = 'transactionError' +export const TRANSACTION_ERROR_KEY = 'transactionError' |