aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorkumavis <kumavis@users.noreply.github.com>2017-05-23 07:21:24 +0800
committerGitHub <noreply@github.com>2017-05-23 07:21:24 +0800
commit99f28527a3a67867c758597ff980c341a8194562 (patch)
tree4c56d335413bd75e837b1fa41700381c3c4e6484
parent058b73221393467549cca04937267635e471aae1 (diff)
parent8520fe5afec432f45b54cbe51e6253e51dc54e89 (diff)
downloadtangerine-wallet-browser-99f28527a3a67867c758597ff980c341a8194562.tar
tangerine-wallet-browser-99f28527a3a67867c758597ff980c341a8194562.tar.gz
tangerine-wallet-browser-99f28527a3a67867c758597ff980c341a8194562.tar.bz2
tangerine-wallet-browser-99f28527a3a67867c758597ff980c341a8194562.tar.lz
tangerine-wallet-browser-99f28527a3a67867c758597ff980c341a8194562.tar.xz
tangerine-wallet-browser-99f28527a3a67867c758597ff980c341a8194562.tar.zst
tangerine-wallet-browser-99f28527a3a67867c758597ff980c341a8194562.zip
Merge branch 'master' into HelpDebugStalledTxs
-rw-r--r--CHANGELOG.md1
-rw-r--r--app/scripts/lib/inpage-provider.js22
-rw-r--r--package.json2
3 files changed, 19 insertions, 6 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 50fa0d858..265c239b2 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -4,6 +4,7 @@
- Add Transaction Number (nonce) to transaction list.
- Label the pending tx icon with a tooltip.
+- Fix bug where website filters would pile up and not deallocate when leaving a site.
## 3.6.5 2017-5-17
diff --git a/app/scripts/lib/inpage-provider.js b/app/scripts/lib/inpage-provider.js
index e5e398e24..e54f547bd 100644
--- a/app/scripts/lib/inpage-provider.js
+++ b/app/scripts/lib/inpage-provider.js
@@ -1,5 +1,7 @@
const pipe = require('pump')
-const StreamProvider = require('web3-stream-provider')
+const ProviderEngine = require('web3-provider-engine')
+const FilterSubprovider = require('web3-provider-engine/subproviders/filters')
+const StreamSubprovider = require('web3-provider-engine/subproviders/stream')
const LocalStorageStore = require('obs-store')
const ObjectMultiplex = require('./obj-multiplex')
const createRandomId = require('./random-id')
@@ -27,14 +29,24 @@ function MetamaskInpageProvider (connectionStream) {
)
// connect to async provider
- const asyncProvider = self.asyncProvider = new StreamProvider()
+ const engine = new ProviderEngine()
+
+ const filterSubprovider = new FilterSubprovider()
+ engine.addProvider(filterSubprovider)
+
+ const streamSubprovider = new StreamSubprovider()
+ engine.addProvider(streamSubprovider)
+
pipe(
- asyncProvider,
+ streamSubprovider,
multiStream.createStream('provider'),
- asyncProvider,
+ streamSubprovider,
(err) => logStreamDisconnectWarning('MetaMask RpcProvider', err)
)
+ // start polling
+ engine.start()
+
self.idMap = {}
// handle sendAsync requests via asyncProvider
self.sendAsync = function (payload, cb) {
@@ -46,7 +58,7 @@ function MetamaskInpageProvider (connectionStream) {
return message
})
// forward to asyncProvider
- asyncProvider.sendAsync(request, function (err, res) {
+ engine.sendAsync(request, function (err, res) {
if (err) return cb(err)
// transform messages to original ids
eachJsonMessage(res, (message) => {
diff --git a/package.json b/package.json
index 6fb9513d5..271e2a397 100644
--- a/package.json
+++ b/package.json
@@ -122,7 +122,7 @@
"valid-url": "^1.0.9",
"vreme": "^3.0.2",
"web3": "0.18.2",
- "web3-provider-engine": "^12.0.6",
+ "web3-provider-engine": "^12.1.0",
"web3-stream-provider": "^2.0.6",
"xtend": "^4.0.1"
},