aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorkumavis <kumavis@users.noreply.github.com>2017-03-07 08:30:01 +0800
committerGitHub <noreply@github.com>2017-03-07 08:30:01 +0800
commite91ddfcacc37c0b45289a6df017c32e803b55d88 (patch)
tree66b690e2feef0a1c08bee4e6195ad105fb91628b
parentd27b34cbcd92431e7a1a4e2038249dac182bfc32 (diff)
parent00d03d8179a61476432eb4a5f9b9b7fc940c27ba (diff)
downloadtangerine-wallet-browser-e91ddfcacc37c0b45289a6df017c32e803b55d88.tar
tangerine-wallet-browser-e91ddfcacc37c0b45289a6df017c32e803b55d88.tar.gz
tangerine-wallet-browser-e91ddfcacc37c0b45289a6df017c32e803b55d88.tar.bz2
tangerine-wallet-browser-e91ddfcacc37c0b45289a6df017c32e803b55d88.tar.lz
tangerine-wallet-browser-e91ddfcacc37c0b45289a6df017c32e803b55d88.tar.xz
tangerine-wallet-browser-e91ddfcacc37c0b45289a6df017c32e803b55d88.tar.zst
tangerine-wallet-browser-e91ddfcacc37c0b45289a6df017c32e803b55d88.zip
Merge pull request #1178 from MetaMask/i#1168
Fix issue txMetaObject had no hash
-rw-r--r--app/scripts/metamask-controller.js8
-rw-r--r--app/scripts/transaction-manager.js2
2 files changed, 5 insertions, 5 deletions
diff --git a/app/scripts/metamask-controller.js b/app/scripts/metamask-controller.js
index bd01a260d..3dddf7065 100644
--- a/app/scripts/metamask-controller.js
+++ b/app/scripts/metamask-controller.js
@@ -414,14 +414,14 @@ module.exports = class MetamaskController extends EventEmitter {
self.sendUpdate()
self.opts.showUnapprovedTx(txMeta)
// listen for tx completion (success, fail)
- self.txManager.once(`${txMeta.id}:finished`, (status) => {
- switch (status) {
+ self.txManager.once(`${txMeta.id}:finished`, (completedTx) => {
+ switch (completedTx.status) {
case 'submitted':
- return cb(null, txMeta.hash)
+ return cb(null, completedTx.hash)
case 'rejected':
return cb(new Error('MetaMask Tx Signature: User denied transaction signature.'))
default:
- return cb(new Error(`MetaMask Tx Signature: Unknown problem: ${JSON.stringify(txMeta.txParams)}`))
+ return cb(new Error(`MetaMask Tx Signature: Unknown problem: ${JSON.stringify(completedTx.txParams)}`))
}
})
})
diff --git a/app/scripts/transaction-manager.js b/app/scripts/transaction-manager.js
index 07c90af7e..c6cfdf11d 100644
--- a/app/scripts/transaction-manager.js
+++ b/app/scripts/transaction-manager.js
@@ -353,7 +353,7 @@ module.exports = class TransactionManager extends EventEmitter {
txMeta.status = status
this.emit(`${txMeta.id}:${status}`, txId)
if (status === 'submitted' || status === 'rejected') {
- this.emit(`${txMeta.id}:finished`, status)
+ this.emit(`${txMeta.id}:finished`, txMeta)
}
this.updateTx(txMeta)
this.emit('updateBadge')