diff options
author | Dan Finlay <flyswatter@users.noreply.github.com> | 2017-05-23 07:35:40 +0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2017-05-23 07:35:40 +0800 |
commit | 650365f9f21ab0a8d670656edd9c03d422c42f8f (patch) | |
tree | 4c56d335413bd75e837b1fa41700381c3c4e6484 | |
parent | 8520fe5afec432f45b54cbe51e6253e51dc54e89 (diff) | |
parent | 99f28527a3a67867c758597ff980c341a8194562 (diff) | |
download | tangerine-wallet-browser-650365f9f21ab0a8d670656edd9c03d422c42f8f.tar tangerine-wallet-browser-650365f9f21ab0a8d670656edd9c03d422c42f8f.tar.gz tangerine-wallet-browser-650365f9f21ab0a8d670656edd9c03d422c42f8f.tar.bz2 tangerine-wallet-browser-650365f9f21ab0a8d670656edd9c03d422c42f8f.tar.lz tangerine-wallet-browser-650365f9f21ab0a8d670656edd9c03d422c42f8f.tar.xz tangerine-wallet-browser-650365f9f21ab0a8d670656edd9c03d422c42f8f.tar.zst tangerine-wallet-browser-650365f9f21ab0a8d670656edd9c03d422c42f8f.zip |
Merge pull request #1468 from MetaMask/HelpDebugStalledTxs
Help debug stalled txs
-rw-r--r-- | CHANGELOG.md | 2 | ||||
-rw-r--r-- | package.json | 1 | ||||
-rw-r--r-- | ui/app/components/transaction-list-item-icon.js | 16 | ||||
-rw-r--r-- | ui/app/components/transaction-list-item.js | 19 |
4 files changed, 33 insertions, 5 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md index c31f26f04..265c239b2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,8 @@ ## Current Master +- Add Transaction Number (nonce) to transaction list. +- Label the pending tx icon with a tooltip. - Fix bug where website filters would pile up and not deallocate when leaving a site. ## 3.6.5 2017-5-17 diff --git a/package.json b/package.json index dba82d17c..271e2a397 100644 --- a/package.json +++ b/package.json @@ -87,6 +87,7 @@ "mississippi": "^1.2.0", "mkdirp": "^0.5.1", "multiplex": "^6.7.0", + "number-to-bn": "^1.7.0", "obs-store": "^2.3.1", "once": "^1.3.3", "ping-pong-stream": "^1.0.0", diff --git a/ui/app/components/transaction-list-item-icon.js b/ui/app/components/transaction-list-item-icon.js index d63cae259..431054340 100644 --- a/ui/app/components/transaction-list-item-icon.js +++ b/ui/app/components/transaction-list-item-icon.js @@ -1,6 +1,7 @@ const Component = require('react').Component const h = require('react-hyperscript') const inherits = require('util').inherits +const Tooltip = require('./tooltip') const Identicon = require('./identicon') @@ -32,11 +33,16 @@ TransactionIcon.prototype.render = function () { }) case 'submitted': - return h('i.fa.fa-ellipsis-h', { - style: { - fontSize: '27px', - }, - }) + return h(Tooltip, { + title: 'Pending', + position: 'bottom', + }, [ + h('i.fa.fa-ellipsis-h', { + style: { + fontSize: '27px', + }, + }), + ]) } if (isMsg) { diff --git a/ui/app/components/transaction-list-item.js b/ui/app/components/transaction-list-item.js index c2a585003..dbda66a31 100644 --- a/ui/app/components/transaction-list-item.js +++ b/ui/app/components/transaction-list-item.js @@ -8,6 +8,7 @@ const explorerLink = require('../../lib/explorer-link') const CopyButton = require('./copyButton') const vreme = new (require('vreme')) const Tooltip = require('./tooltip') +const numberToBN = require('number-to-bn') const TransactionIcon = require('./transaction-list-item-icon') const ShiftListItem = require('./shift-list-item') @@ -39,6 +40,8 @@ TransactionListItem.prototype.render = function () { txParams = transaction.msgParams } + const nonce = txParams.nonce ? numberToBN(txParams.nonce).toString(10) : '' + const isClickable = ('hash' in transaction && isLinkable) || isPending return ( h(`.transaction-list-item.flex-row.flex-space-between${isClickable ? '.pointer' : ''}`, { @@ -69,6 +72,22 @@ TransactionListItem.prototype.render = function () { ]), ]), + h(Tooltip, { + title: 'Transaction Number', + position: 'bottom', + }, [ + h('span', { + style: { + display: 'flex', + cursor: 'normal', + flexDirection: 'column', + alignItems: 'center', + justifyContent: 'center', + padding: '10px', + }, + }, nonce), + ]), + h('.flex-column', {style: {width: '200px', overflow: 'hidden'}}, [ domainField(txParams), h('div', date), |