diff options
author | Dan Finlay <542863+danfinlay@users.noreply.github.com> | 2018-11-30 08:08:03 +0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2018-11-30 08:08:03 +0800 |
commit | c7233e2cc7ba52308528a74e89938deada5394b8 (patch) | |
tree | 6537665dd517c2678c50e98e46be612a98c108e0 /.github | |
parent | 4be3fe5906d6c5fde0f1611847524ab61296ebbe (diff) | |
download | tangerine-wallet-browser-c7233e2cc7ba52308528a74e89938deada5394b8.tar tangerine-wallet-browser-c7233e2cc7ba52308528a74e89938deada5394b8.tar.gz tangerine-wallet-browser-c7233e2cc7ba52308528a74e89938deada5394b8.tar.bz2 tangerine-wallet-browser-c7233e2cc7ba52308528a74e89938deada5394b8.tar.lz tangerine-wallet-browser-c7233e2cc7ba52308528a74e89938deada5394b8.tar.xz tangerine-wallet-browser-c7233e2cc7ba52308528a74e89938deada5394b8.tar.zst tangerine-wallet-browser-c7233e2cc7ba52308528a74e89938deada5394b8.zip |
Fixed Vivek's bug (#5860)
* Fixed Vivek's bug
Fixes #5850
What was happening:
It seems that his MetaMask had crashed while some new transactions had
been loading defaults. He probably had a network connectivity issue to
Infura (which we are working with Infura to address).
As a result of this network cutout, his three unapproved transactions
were not marked failed, and were not marked as `loadingDefaults =
false`, as their gas prices had not yet been estimated.
Normally this behavior is supposed to clean itself up when the
transaction controller starts up, via the
`TransactionController._onBootCleanUp()` function, but in this case,
during unlock, that function was unable to do its job because when it
requested the transaction list, the current network was in the `loading`
state, making it proceed as if there were no pending transactions.
To fix this, I am doing two things:
- Setting transactions to loadingDefaults = false in more catch blocks.
- Calling `onBootCleanUp()` when the network store's status changes, so
that it will re-trigger when loading completes.
* Fixed reference
* Fixed infinite loop bug
Was refreshing the tx list on every tx state change instead of just
network changes, creating an infinite loop.
* Add notes to tx updates to clarify logs
Diffstat (limited to '.github')
0 files changed, 0 insertions, 0 deletions