From 20e520708906a428f8aad674e9197d4d0ed5ce65 Mon Sep 17 00:00:00 2001
From: kcwu <kcwu@63ad8ddf-47c3-0310-b6dd-a9e9d9715204>
Date: Wed, 10 Sep 2003 09:13:24 +0000
Subject: code audit

git-svn-id: http://opensvn.csie.org/pttbbs/trunk/pttbbs@1175 63ad8ddf-47c3-0310-b6dd-a9e9d9715204
---
 mbbsd/chc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

(limited to 'mbbsd')

diff --git a/mbbsd/chc.c b/mbbsd/chc.c
index fbd716a1..f63ae972 100644
--- a/mbbsd/chc.c
+++ b/mbbsd/chc.c
@@ -318,12 +318,13 @@ chc_log_poem(void)
     struct dirent **namelist;
     int n;
 
+    // TODO use readdir(), don't use lots of memory
     n = scandir(BBSHOME"/etc/chess", &namelist, chc_filter, alphasort);
     if (n < 0)
 	perror("scandir");
     else {
 	char buf[80];
-	FILE *fp;
+	FILE *fp; // XXX shadow global fp
 	sprintf(buf, BBSHOME"/etc/chess/%s", namelist[rand() % n]->d_name);
 	if ((fp = fopen(buf, "r")) == NULL)
 	    return -1;
-- 
cgit v1.2.3