From bcb832c7cfaf279e38a8aa2760ed9b0bfacb326e Mon Sep 17 00:00:00 2001 From: wens Date: Fri, 10 Jul 2009 08:47:22 +0000 Subject: Prevent memory leak. Pointer should be assigned after checking return value. realloc manpage: If realloc() fails the original block is left untouched; it is not freed or moved. git-svn-id: http://opensvn.csie.org/pttbbs/trunk/pttbbs@4736 63ad8ddf-47c3-0310-b6dd-a9e9d9715204 --- daemon/logind/logind.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/daemon/logind/logind.c b/daemon/logind/logind.c index 8587c670..748fdc49 100644 --- a/daemon/logind/logind.c +++ b/daemon/logind/logind.c @@ -795,12 +795,12 @@ load_text_screen_file(const char *filename, char **pptr) // check memory buffer s = realloc(*pptr, wsz); - *pptr = s; if (!s) { fclose(fp); return; } + *pptr = s; // prepare buffer memset(s, 0, wsz); -- cgit v1.2.3