From 947e45f3e1f20e26b4931eb1dbff5296521bb02e Mon Sep 17 00:00:00 2001 From: wens Date: Sat, 25 Jun 2011 16:32:52 +0000 Subject: Message strings should be static. Don't pass command in argv. git-svn-id: http://opensvn.csie.org/pttbbs/trunk@5364 63ad8ddf-47c3-0310-b6dd-a9e9d9715204 --- pttbbs/daemon/boardd/boardd.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/pttbbs/daemon/boardd/boardd.c b/pttbbs/daemon/boardd/boardd.c index e6e7966f..4ff29eb1 100644 --- a/pttbbs/daemon/boardd/boardd.c +++ b/pttbbs/daemon/boardd/boardd.c @@ -158,7 +158,7 @@ cmd_get(struct bufferevent *bev, void *ctx, int argc, char **argv) struct evbuffer *output = bufferevent_get_output(bev), *buf = evbuffer_new(); - if (*argv++ == NULL) { + if (*argv == NULL) { evbuffer_add_reference(output, "ERROR\r\n", 7, NULL, NULL); return; } @@ -178,14 +178,14 @@ cmd_get(struct bufferevent *bev, void *ctx, int argc, char **argv) void cmd_version(struct bufferevent *bev, void *ctx, int argc, char **argv) { - const char msg[] = "VERSION 0.0.1\r\n"; + static const char msg[] = "VERSION 0.0.1\r\n"; evbuffer_add_reference(bufferevent_get_output(bev), msg, strlen(msg), NULL, NULL); } void cmd_unknown(struct bufferevent *bev, void *ctx, int argc, char **argv) { - const char msg[] = "SERVER_ERROR Not implemented\r\n"; + static const char msg[] = "SERVER_ERROR Not implemented\r\n"; evbuffer_add_reference(bufferevent_get_output(bev), msg, strlen(msg), NULL, NULL); } @@ -223,7 +223,7 @@ client_read_cb(struct bufferevent *bev, void *ctx) if (evutil_ascii_strcasecmp(line, cmdlist[i].cmd) == 0) break; - (cmdlist[i].func)(bev, ctx, argc, argv); + (cmdlist[i].func)(bev, ctx, argc - 1, argv + 1); free(argv); free(line); -- cgit v1.2.3