diff options
author | victor <victor@63ad8ddf-47c3-0310-b6dd-a9e9d9715204> | 2005-08-09 18:29:43 +0800 |
---|---|---|
committer | victor <victor@63ad8ddf-47c3-0310-b6dd-a9e9d9715204> | 2005-08-09 18:29:43 +0800 |
commit | 6ac040991381bae9a499506bfb7538bca8191ece (patch) | |
tree | 19f264e78bde30dd0fa0b14208117095536ba099 /mbbsd/fav.c | |
parent | 01ae376a8e5736c8b754e85666280ab16f26314f (diff) | |
download | pttbbs-6ac040991381bae9a499506bfb7538bca8191ece.tar pttbbs-6ac040991381bae9a499506bfb7538bca8191ece.tar.gz pttbbs-6ac040991381bae9a499506bfb7538bca8191ece.tar.bz2 pttbbs-6ac040991381bae9a499506bfb7538bca8191ece.tar.lz pttbbs-6ac040991381bae9a499506bfb7538bca8191ece.tar.xz pttbbs-6ac040991381bae9a499506bfb7538bca8191ece.tar.zst pttbbs-6ac040991381bae9a499506bfb7538bca8191ece.zip |
fav.c: don't delete a fav entry implicitly
board.c: make data flow analysis easier to compiler
admin.c: pretty delete description
git-svn-id: http://opensvn.csie.org/pttbbs/trunk/pttbbs@3019 63ad8ddf-47c3-0310-b6dd-a9e9d9715204
Diffstat (limited to 'mbbsd/fav.c')
-rw-r--r-- | mbbsd/fav.c | 12 |
1 files changed, 5 insertions, 7 deletions
diff --git a/mbbsd/fav.c b/mbbsd/fav.c index a4a5802e..0b367fa4 100644 --- a/mbbsd/fav.c +++ b/mbbsd/fav.c @@ -300,12 +300,12 @@ inline int valid_item(fav_type_t *ft){ /** * 清除 fp(dir) 中無效的 entry/dir,如果 clean_invisible == true,該 user - * 看不見的看板也會被清除。 + * 看不見的看板也會被清除。「無效」指的是沒有 FAVH_FAV flag,所以不包含不 + * 存在的看板。 */ static void rebuild_fav(fav_t *fp, int clean_invisible) { int i, j, nData; - boardheader_t *bp; fav_type_t *ft; fav_number = 0; @@ -320,11 +320,9 @@ static void rebuild_fav(fav_t *fp, int clean_invisible) ft = &fp->favh[i]; switch (get_item_type(ft)){ case FAVT_BOARD: - bp = &bcache[cast_board(ft)->bid - 1]; - if (!bp->brdname[0]) - continue; - if ( clean_invisible && !HasBoardPerm(bp)) - continue; + if (clean_invisible) + if (!HasBoardPerm(&bcache[cast_board(ft)->bid - 1])); + continue; break; case FAVT_LINE: break; |