fix race of assession

note that SHM_t was modified


git-svn-id: http://opensvn.csie.org/pttbbs/trunk/pttbbs@2341 63ad8ddf-47c3-0310-b6dd-a9e9d9715204

1 files changed, 7 insertions, 7 deletions

diff --git a/mbbsd/assess.c b/mbbsd/assess.c
index 489054d4..ae5c43a2 100644
--- a/mbbsd/assess.c
+++ b/mbbsd/assess.c
@@ -14,16 +14,16 @@ inline static void inc(unsigned char *num, int n)
 	(*num) += n;
 }
 
-/* FIXME race occurs when he's online.
- * passwd_update in mbbsd.c:u_exit() override the later value. */
-#define modify_column(name) \
-int inc_##name(char *userid, int num) \
+#define modify_column(_attr) \
+int inc_##_attr(char *userid, int num) \
 { \
     int uid = getuser(userid);\
     if(uid>0 ){ \
-       inc(&xuser.name, num); \
-       passwd_update(uid, &xuser); \
-       return xuser.name; }\
+	userinfo_t *uinfo = search_ulistn(uid); \
+	inc(&uinfo->_attr, num); \
+	inc(&xuser._attr, num); \
+	passwd_update(uid, &xuser); \
+	return xuser._attr; }\
     return 0;\
 }