Prevent memory leak. Pointer should be assigned after checking return value.

realloc manpage: If realloc() fails the original block is left untouched; it is not freed or moved.


git-svn-id: http://opensvn.csie.org/pttbbs/trunk/pttbbs@4736 63ad8ddf-47c3-0310-b6dd-a9e9d9715204

1 files changed, 1 insertions, 1 deletions

diff --git a/daemon/logind/logind.c b/daemon/logind/logind.c
index 8587c670..748fdc49 100644
--- a/daemon/logind/logind.c
+++ b/daemon/logind/logind.c
@@ -795,12 +795,12 @@ load_text_screen_file(const char *filename, char **pptr)
 
     // check memory buffer
     s = realloc(*pptr, wsz);  
-    *pptr = s;
     if (!s)
     {
         fclose(fp);
         return;
     }
+    *pptr = s;
 
     // prepare buffer
     memset(s, 0, wsz);