1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
1561
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
1575
1576
1577
1578
1579
1580
1581
1582
1583
1584
1585
1586
1587
1588
1589
1590
1591
1592
1593
1594
1595
1596
1597
1598
1599
1600
1601
1602
1603
1604
1605
1606
1607
1608
1609
1610
1611
1612
1613
1614
1615
1616
1617
1618
1619
1620
1621
1622
1623
1624
1625
1626
1627
1628
1629
1630
1631
1632
1633
1634
1635
1636
1637
1638
1639
1640
1641
1642
1643
1644
1645
1646
1647
1648
1649
1650
1651
1652
1653
1654
1655
1656
1657
1658
1659
1660
1661
1662
1663
1664
1665
1666
1667
1668
1669
1670
1671
1672
1673
1674
1675
1676
1677
1678
1679
1680
1681
1682
1683
1684
1685
1686
1687
1688
1689
1690
1691
1692
1693
1694
1695
1696
1697
1698
1699
1700
1701
1702
1703
1704
1705
1706
1707
1708
1709
1710
1711
1712
1713
1714
1715
1716
1717
1718
1719
1720
1721
1722
1723
1724
1725
1726
1727
1728
1729
1730
1731
1732
1733
1734
1735
1736
1737
1738
1739
1740
1741
1742
1743
1744
1745
1746
1747
1748
1749
1750
1751
1752
1753
1754
1755
1756
1757
1758
1759
1760
1761
1762
1763
1764
1765
1766
1767
1768
1769
1770
1771
1772
1773
1774
1775
1776
1777
1778
1779
1780
1781
1782
1783
1784
1785
1786
1787
1788
1789
1790
1791
1792
1793
1794
1795
1796
1797
1798
1799
1800
1801
1802
1803
1804
1805
1806
1807
1808
1809
1810
1811
1812
1813
1814
1815
1816
1817
1818
1819
1820
1821
1822
1823
1824
1825
1826
1827
1828
1829
1830
1831
1832
1833
1834
1835
1836
1837
1838
1839
1840
1841
1842
1843
1844
1845
1846
1847
1848
1849
1850
1851
1852
1853
1854
1855
1856
1857
1858
1859
1860
1861
1862
1863
1864
1865
1866
1867
1868
1869
1870
1871
1872
1873
1874
1875
1876
1877
1878
1879
1880
1881
1882
1883
1884
1885
1886
1887
1888
1889
1890
1891
1892
1893
1894
1895
1896
1897
1898
1899
1900
1901
1902
1903
1904
1905
1906
1907
1908
1909
1910
1911
1912
1913
1914
1915
1916
1917
1918
1919
1920
1921
1922
1923
1924
1925
1926
1927
1928
1929
1930
1931
1932
1933
1934
1935
1936
1937
1938
1939
1940
1941
1942
1943
1944
1945
1946
1947
1948
1949
1950
1951
1952
1953
1954
1955
1956
1957
1958
1959
1960
1961
1962
1963
1964
1965
1966
1967
1968
1969
1970
1971
1972
1973
1974
1975
1976
1977
1978
1979
1980
1981
1982
1983
1984
1985
1986
1987
1988
1989
1990
1991
1992
1993
1994
1995
1996
1997
1998
1999
2000
2001
2002
2003
2004
2005
2006
2007
2008
2009
2010
2011
2012
2013
2014
2015
2016
2017
2018
2019
2020
2021
2022
2023
2024
2025
2026
2027
2028
2029
2030
2031
2032
2033
2034
2035
2036
2037
2038
2039
2040
2041
2042
2043
2044
2045
2046
2047
2048
2049
2050
2051
2052
2053
2054
2055
2056
2057
2058
2059
2060
2061
2062
2063
2064
2065
2066
2067
2068
2069
2070
2071
2072
2073
2074
2075
2076
2077
2078
2079
2080
2081
2082
2083
2084
2085
2086
2087
2088
2089
2090
2091
2092
2093
2094
2095
2096
2097
2098
2099
2100
2101
2102
2103
2104
2105
2106
2107
2108
2109
2110
2111
2112
2113
2114
2115
2116
2117
2118
2119
2120
2121
2122
2123
2124
2125
2126
2127
2128
2129
2130
2131
2132
2133
2134
2135
2136
2137
2138
2139
2140
2141
2142
2143
2144
2145
2146
2147
2148
2149
2150
2151
2152
2153
2154
2155
2156
2157
2158
2159
2160
2161
2162
2163
2164
2165
2166
2167
2168
2169
2170
2171
2172
2173
2174
2175
2176
2177
2178
2179
2180
2181
2182
2183
2184
2185
2186
2187
2188
2189
2190
2191
2192
2193
2194
2195
2196
2197
2198
2199
2200
2201
2202
2203
2204
2205
2206
2207
2208
2209
2210
2211
2212
2213
2214
2215
2216
2217
2218
2219
2220
2221
2222
2223
2224
2225
2226
2227
2228
2229
2230
2231
2232
2233
2234
2235
2236
2237
2238
2239
2240
2241
2242
2243
2244
2245
2246
2247
2248
2249
2250
2251
2252
2253
2254
2255
2256
2257
2258
2259
2260
2261
2262
2263
2264
2265
2266
2267
2268
2269
2270
2271
2272
2273
2274
2275
2276
2277
2278
2279
2280
2281
2282
2283
2284
2285
2286
2287
2288
2289
2290
2291
2292
2293
2294
2295
2296
2297
2298
2299
2300
2301
2302
2303
2304
2305
2306
2307
2308
2309
2310
2311
2312
2313
2314
2315
2316
2317
2318
2319
2320
2321
2322
2323
2324
2325
2326
2327
2328
2329
2330
2331
2332
2333
2334
2335
2336
2337
2338
2339
2340
2341
2342
2343
2344
2345
2346
2347
2348
2349
2350
2351
2352
2353
2354
2355
2356
2357
2358
2359
2360
2361
2362
2363
2364
2365
2366
2367
2368
2369
2370
2371
2372
2373
2374
2375
2376
2377
2378
2379
2380
2381
2382
2383
2384
2385
2386
2387
2388
2389
2390
2391
2392
2393
2394
2395
2396
2397
2398
2399
2400
2401
2402
2403
2404
2405
2406
2407
2408
2409
2410
2411
2412
2413
2414
2415
2416
2417
2418
2419
2420
2421
2422
2423
2424
2425
2426
2427
2428
2429
2430
2431
2432
2433
2434
2435
2436
2437
2438
2439
2440
2441
2442
2443
2444
2445
2446
2447
2448
2449
2450
2451
2452
2453
2454
2455
2456
2457
2458
2459
2460
2461
2462
2463
2464
2465
2466
2467
2468
2469
2470
2471
2472
2473
2474
2475
2476
2477
2478
2479
2480
2481
2482
2483
2484
2485
2486
2487
2488
2489
2490
2491
2492
2493
2494
2495
2496
2497
2498
2499
2500
2501
2502
2503
2504
2505
2506
2507
2508
2509
2510
2511
2512
2513
2514
2515
2516
2517
2518
2519
2520
2521
2522
2523
2524
2525
2526
2527
2528
2529
2530
2531
2532
2533
2534
2535
2536
2537
2538
2539
2540
2541
2542
2543
2544
2545
2546
2547
2548
2549
2550
2551
2552
2553
2554
2555
2556
2557
2558
2559
2560
2561
2562
2563
2564
2565
2566
2567
2568
2569
2570
2571
2572
2573
2574
2575
2576
2577
2578
2579
2580
2581
2582
2583
2584
2585
2586
2587
2588
2589
2590
2591
2592
2593
2594
2595
2596
2597
2598
2599
2600
2601
2602
2603
2604
2605
2606
2607
2608
2609
2610
2611
2612
2613
2614
2615
2616
2617
2618
2619
2620
2621
2622
2623
2624
2625
2626
2627
2628
2629
2630
2631
2632
2633
2634
2635
2636
2637
2638
2639
2640
2641
2642
2643
2644
2645
2646
2647
2648
2649
2650
2651
2652
2653
2654
2655
2656
2657
2658
2659
2660
2661
2662
2663
2664
2665
2666
2667
2668
2669
2670
2671
2672
2673
2674
2675
2676
2677
2678
2679
2680
2681
2682
2683
2684
2685
2686
2687
2688
2689
2690
2691
2692
2693
2694
2695
2696
2697
2698
2699
2700
2701
2702
2703
2704
2705
2706
2707
2708
2709
2710
2711
2712
2713
2714
2715
2716
2717
2718
2719
2720
2721
2722
2723
2724
2725
2726
2727
2728
2729
2730
2731
2732
2733
2734
2735
2736
2737
2738
2739
2740
2741
2742
2743
2744
2745
2746
2747
2748
2749
2750
2751
2752
2753
2754
2755
2756
2757
2758
2759
2760
2761
2762
2763
2764
2765
2766
2767
2768
2769
2770
2771
2772
2773
2774
2775
2776
2777
2778
2779
2780
2781
2782
2783
2784
2785
2786
2787
2788
2789
2790
2791
2792
2793
2794
2795
2796
2797
2798
2799
2800
2801
2802
2803
2804
2805
2806
2807
2808
2809
2810
2811
2812
2813
2814
2815
2816
2817
2818
2819
2820
2821
2822
2823
2824
2825
2826
2827
2828
2829
2830
2831
2832
2833
2834
2835
2836
2837
2838
2839
2840
2841
2842
2843
2844
2845
2846
2847
2848
2849
2850
2851
2852
2853
2854
2855
2856
2857
2858
2859
2860
2861
2862
2863
2864
2865
2866
2867
2868
2869
2870
2871
2872
2873
2874
2875
2876
2877
2878
2879
2880
2881
2882
2883
2884
2885
2886
2887
2888
2889
2890
2891
2892
2893
2894
2895
2896
2897
2898
2899
2900
2901
2902
2903
2904
2905
2906
2907
2908
2909
2910
2911
2912
2913
2914
2915
2916
2917
2918
2919
2920
2921
2922
2923
2924
2925
2926
2927
2928
2929
2930
2931
2932
2933
2934
2935
2936
2937
2938
2939
2940
2941
2942
2943
2944
2945
2946
2947
2948
2949
2950
2951
2952
2953
2954
2955
2956
2957
2958
2959
2960
2961
2962
2963
2964
2965
2966
2967
2968
2969
2970
2971
2972
2973
2974
2975
2976
2977
2978
2979
2980
2981
2982
2983
2984
2985
2986
2987
2988
2989
2990
2991
2992
2993
2994
2995
2996
2997
2998
2999
3000
3001
3002
3003
3004
3005
3006
3007
3008
3009
3010
3011
3012
3013
3014
3015
3016
3017
3018
3019
3020
3021
3022
3023
3024
3025
3026
3027
3028
3029
3030
3031
3032
3033
3034
3035
3036
3037
3038
3039
3040
3041
3042
3043
3044
3045
3046
3047
3048
3049
3050
3051
3052
3053
3054
3055
3056
3057
3058
3059
3060
3061
3062
3063
3064
3065
3066
3067
3068
3069
3070
3071
3072
3073
3074
3075
3076
3077
3078
3079
3080
3081
3082
3083
3084
3085
3086
3087
3088
3089
3090
3091
3092
3093
3094
3095
3096
3097
3098
3099
3100
3101
3102
3103
3104
3105
3106
3107
3108
3109
3110
3111
3112
3113
3114
3115
3116
3117
3118
3119
3120
3121
3122
3123
3124
3125
3126
3127
3128
3129
3130
3131
3132
3133
3134
3135
3136
3137
3138
3139
3140
3141
3142
3143
3144
3145
3146
3147
3148
3149
3150
3151
3152
3153
3154
3155
3156
3157
3158
3159
3160
3161
3162
3163
3164
3165
3166
3167
3168
3169
3170
3171
3172
3173
3174
3175
3176
3177
3178
3179
3180
3181
3182
3183
3184
3185
3186
3187
3188
3189
3190
3191
3192
3193
3194
3195
3196
3197
3198
3199
3200
3201
3202
3203
3204
3205
3206
3207
3208
3209
3210
3211
3212
3213
3214
3215
3216
3217
3218
3219
3220
3221
3222
3223
3224
3225
3226
3227
3228
3229
3230
3231
3232
3233
3234
3235
3236
3237
3238
3239
3240
3241
3242
3243
3244
3245
3246
3247
3248
3249
3250
3251
3252
3253
3254
3255
3256
3257
3258
3259
3260
3261
3262
3263
3264
3265
3266
3267
3268
3269
3270
3271
3272
3273
3274
3275
3276
3277
3278
3279
3280
3281
3282
3283
3284
3285
3286
3287
3288
3289
3290
3291
3292
3293
3294
3295
3296
3297
3298
3299
3300
3301
3302
3303
3304
3305
3306
3307
3308
3309
3310
3311
3312
3313
3314
3315
3316
3317
3318
3319
3320
3321
3322
3323
3324
3325
3326
3327
3328
3329
3330
3331
3332
3333
3334
3335
3336
3337
3338
3339
3340
3341
3342
3343
3344
3345
3346
3347
3348
3349
3350
3351
3352
3353
3354
3355
3356
3357
3358
3359
3360
3361
3362
3363
3364
3365
3366
3367
3368
3369
3370
3371
3372
3373
3374
3375
3376
3377
3378
3379
3380
3381
3382
3383
3384
3385
3386
3387
3388
3389
3390
3391
3392
3393
3394
3395
3396
3397
3398
3399
3400
3401
3402
3403
3404
3405
3406
3407
3408
3409
3410
3411
3412
3413
3414
3415
3416
3417
3418
3419
3420
3421
3422
3423
3424
3425
3426
3427
3428
3429
3430
3431
3432
3433
3434
3435
3436
3437
3438
3439
3440
3441
3442
3443
3444
3445
3446
3447
3448
3449
3450
3451
3452
3453
3454
3455
3456
3457
3458
3459
3460
3461
3462
3463
3464
3465
3466
3467
3468
3469
3470
3471
3472
3473
3474
3475
3476
3477
3478
3479
3480
3481
3482
3483
3484
3485
3486
3487
3488
3489
3490
3491
3492
3493
3494
3495
3496
3497
3498
3499
3500
3501
3502
3503
3504
3505
3506
3507
3508
3509
3510
3511
3512
3513
3514
3515
3516
3517
3518
3519
3520
3521
3522
3523
3524
3525
3526
3527
3528
3529
3530
3531
3532
3533
3534
3535
3536
3537
3538
3539
3540
3541
3542
3543
3544
3545
3546
3547
3548
3549
3550
3551
3552
3553
3554
3555
3556
3557
3558
3559
3560
3561
3562
3563
3564
3565
3566
3567
3568
3569
3570
3571
3572
3573
3574
3575
3576
3577
3578
3579
3580
3581
3582
3583
3584
3585
3586
3587
3588
3589
3590
3591
3592
3593
3594
3595
3596
3597
3598
3599
3600
3601
3602
3603
3604
3605
3606
3607
3608
3609
3610
3611
3612
3613
3614
3615
3616
3617
3618
3619
3620
3621
3622
3623
3624
3625
3626
3627
3628
3629
3630
3631
3632
3633
3634
3635
3636
3637
3638
3639
3640
3641
3642
3643
3644
3645
3646
3647
3648
3649
3650
3651
3652
3653
3654
3655
3656
3657
3658
3659
3660
3661
3662
3663
3664
3665
3666
3667
3668
3669
3670
3671
3672
3673
3674
3675
3676
3677
3678
3679
3680
3681
3682
3683
3684
3685
3686
3687
3688
3689
3690
3691
3692
3693
3694
3695
3696
3697
3698
3699
3700
3701
3702
3703
3704
3705
3706
3707
3708
3709
3710
3711
3712
3713
3714
3715
3716
3717
3718
3719
3720
3721
3722
3723
3724
3725
3726
3727
3728
3729
3730
3731
3732
3733
3734
3735
3736
3737
3738
3739
3740
3741
3742
3743
3744
3745
3746
3747
3748
3749
3750
3751
3752
3753
3754
3755
3756
3757
3758
3759
3760
3761
3762
3763
3764
3765
3766
3767
3768
3769
3770
3771
3772
3773
3774
3775
3776
3777
3778
3779
3780
3781
3782
3783
3784
3785
3786
3787
3788
3789
3790
3791
3792
3793
3794
3795
3796
3797
3798
3799
3800
3801
3802
3803
3804
3805
3806
3807
3808
3809
3810
3811
3812
3813
3814
3815
3816
3817
3818
3819
3820
3821
3822
3823
3824
3825
3826
3827
3828
3829
3830
3831
3832
3833
3834
3835
3836
3837
3838
3839
3840
3841
3842
3843
3844
3845
3846
3847
3848
3849
3850
3851
3852
3853
3854
3855
3856
3857
3858
3859
3860
3861
3862
3863
3864
3865
3866
3867
3868
3869
3870
3871
3872
3873
3874
3875
3876
3877
3878
3879
3880
3881
3882
3883
3884
3885
3886
3887
3888
3889
3890
3891
3892
3893
3894
3895
3896
3897
3898
3899
3900
3901
3902
3903
3904
3905
3906
3907
3908
3909
3910
3911
3912
3913
3914
3915
3916
3917
3918
3919
3920
3921
3922
3923
3924
3925
3926
3927
3928
3929
3930
3931
3932
3933
3934
3935
3936
3937
3938
3939
3940
3941
3942
3943
3944
3945
3946
3947
3948
3949
3950
3951
3952
3953
3954
3955
3956
3957
3958
3959
3960
3961
3962
3963
3964
3965
3966
3967
3968
3969
3970
3971
3972
3973
3974
3975
3976
3977
3978
3979
3980
3981
3982
3983
3984
3985
3986
3987
3988
3989
3990
3991
3992
3993
3994
3995
3996
3997
3998
3999
4000
4001
4002
4003
4004
4005
4006
4007
4008
4009
4010
4011
4012
4013
4014
4015
4016
4017
4018
4019
4020
4021
4022
4023
4024
4025
4026
4027
4028
4029
4030
4031
4032
4033
4034
4035
4036
4037
4038
4039
4040
4041
4042
4043
4044
4045
4046
4047
4048
4049
4050
4051
4052
4053
4054
4055
4056
4057
4058
4059
4060
4061
4062
4063
4064
4065
4066
4067
4068
4069
4070
4071
4072
4073
4074
4075
4076
4077
4078
4079
4080
4081
4082
4083
4084
4085
4086
4087
4088
4089
4090
4091
4092
4093
4094
4095
4096
4097
4098
4099
4100
4101
4102
4103
4104
4105
4106
4107
4108
4109
4110
4111
4112
4113
4114
4115
4116
4117
4118
4119
4120
4121
4122
4123
4124
4125
4126
4127
4128
4129
4130
4131
4132
4133
4134
4135
4136
4137
4138
4139
4140
4141
4142
4143
4144
4145
4146
4147
4148
4149
4150
4151
4152
4153
4154
4155
4156
4157
4158
4159
4160
4161
4162
4163
4164
4165
4166
4167
4168
4169
4170
4171
4172
4173
4174
4175
4176
4177
4178
4179
4180
4181
4182
4183
4184
4185
4186
4187
4188
4189
4190
4191
4192
4193
4194
4195
4196
4197
4198
4199
4200
4201
4202
4203
4204
4205
4206
4207
4208
4209
4210
4211
4212
4213
4214
4215
4216
4217
4218
4219
4220
4221
4222
4223
4224
4225
4226
4227
4228
4229
4230
4231
4232
4233
4234
4235
4236
4237
4238
4239
4240
4241
4242
4243
4244
4245
4246
4247
4248
4249
4250
4251
4252
4253
4254
4255
4256
4257
4258
4259
4260
4261
4262
4263
4264
4265
4266
4267
4268
4269
4270
4271
4272
4273
4274
4275
4276
4277
4278
4279
4280
4281
4282
4283
4284
4285
4286
4287
4288
4289
4290
4291
4292
4293
4294
4295
4296
4297
4298
4299
4300
4301
4302
4303
4304
4305
4306
4307
4308
4309
4310
4311
4312
4313
4314
4315
4316
4317
4318
4319
4320
4321
4322
4323
4324
4325
4326
4327
4328
4329
4330
4331
4332
4333
4334
4335
4336
4337
4338
4339
4340
4341
4342
4343
4344
4345
4346
4347
4348
4349
4350
4351
4352
4353
4354
4355
4356
4357
4358
4359
4360
4361
4362
4363
4364
4365
4366
4367
4368
4369
4370
4371
4372
4373
4374
4375
4376
4377
4378
4379
4380
4381
4382
4383
4384
4385
4386
4387
4388
4389
4390
4391
4392
4393
4394
4395
4396
4397
4398
4399
4400
4401
4402
4403
4404
4405
4406
4407
4408
4409
4410
4411
4412
4413
4414
4415
4416
4417
4418
4419
4420
4421
4422
4423
4424
4425
4426
4427
4428
4429
4430
4431
4432
4433
4434
4435
4436
4437
4438
4439
4440
4441
4442
4443
4444
4445
4446
4447
4448
4449
4450
4451
4452
4453
4454
4455
4456
4457
4458
4459
4460
4461
4462
4463
4464
4465
4466
4467
4468
4469
4470
4471
4472
4473
4474
4475
4476
4477
4478
4479
4480
4481
4482
4483
4484
4485
4486
4487
4488
4489
4490
4491
4492
4493
4494
4495
4496
4497
4498
4499
4500
4501
4502
4503
4504
4505
4506
4507
4508
4509
4510
4511
4512
4513
4514
4515
4516
4517
4518
4519
4520
4521
4522
4523
4524
4525
4526
4527
4528
4529
4530
4531
4532
4533
4534
4535
4536
4537
4538
4539
4540
4541
4542
4543
4544
4545
4546
4547
4548
4549
4550
4551
4552
4553
4554
4555
4556
4557
4558
4559
4560
4561
4562
4563
4564
4565
4566
4567
4568
4569
4570
4571
4572
4573
4574
4575
4576
4577
4578
4579
4580
4581
4582
4583
4584
4585
4586
4587
4588
4589
4590
4591
4592
4593
4594
4595
4596
4597
4598
4599
4600
4601
4602
4603
4604
4605
4606
4607
4608
4609
4610
4611
4612
4613
4614
4615
4616
4617
4618
4619
4620
4621
4622
4623
4624
4625
4626
4627
4628
4629
4630
4631
4632
4633
4634
4635
4636
4637
4638
4639
4640
4641
4642
4643
4644
4645
4646
4647
4648
4649
4650
4651
4652
4653
4654
4655
4656
4657
4658
4659
4660
4661
4662
4663
4664
4665
4666
4667
4668
4669
4670
4671
4672
4673
4674
4675
4676
4677
4678
4679
4680
4681
4682
4683
4684
4685
4686
4687
4688
4689
4690
4691
4692
4693
4694
4695
4696
4697
4698
4699
4700
4701
4702
4703
4704
4705
4706
4707
4708
4709
4710
4711
4712
4713
4714
4715
4716
4717
4718
4719
4720
4721
4722
4723
4724
4725
4726
4727
4728
4729
4730
4731
4732
4733
4734
4735
4736
4737
4738
4739
4740
4741
4742
4743
4744
4745
4746
4747
4748
4749
4750
4751
4752
4753
4754
4755
4756
4757
4758
4759
4760
4761
4762
4763
4764
4765
4766
4767
4768
4769
4770
4771
4772
4773
4774
4775
4776
4777
4778
4779
4780
4781
4782
4783
4784
4785
4786
4787
4788
4789
4790
4791
4792
4793
4794
4795
4796
4797
4798
4799
4800
4801
4802
4803
4804
4805
4806
4807
4808
4809
4810
4811
4812
4813
4814
4815
4816
4817
4818
4819
4820
4821
4822
4823
4824
4825
4826
4827
4828
4829
4830
4831
4832
4833
4834
4835
4836
4837
4838
4839
4840
4841
4842
4843
4844
4845
4846
4847
4848
4849
4850
4851
4852
4853
4854
4855
4856
4857
4858
4859
4860
4861
4862
4863
4864
4865
4866
4867
4868
4869
4870
4871
4872
4873
4874
4875
4876
4877
4878
4879
4880
4881
4882
4883
4884
4885
4886
4887
4888
4889
4890
4891
4892
4893
4894
4895
4896
4897
4898
4899
4900
4901
4902
4903
4904
4905
4906
4907
4908
4909
4910
4911
4912
4913
4914
4915
4916
4917
4918
4919
4920
4921
4922
4923
4924
4925
4926
4927
4928
4929
4930
4931
4932
4933
4934
4935
4936
4937
4938
4939
4940
4941
4942
4943
4944
4945
4946
4947
4948
4949
4950
4951
4952
4953
4954
4955
4956
4957
4958
4959
4960
4961
4962
4963
4964
4965
4966
4967
4968
4969
4970
4971
4972
4973
4974
4975
4976
4977
4978
4979
4980
4981
4982
4983
4984
4985
4986
4987
4988
4989
4990
4991
4992
4993
4994
4995
4996
4997
4998
4999
5000
5001
5002
5003
5004
5005
5006
5007
5008
5009
5010
5011
5012
5013
5014
5015
5016
5017
5018
5019
5020
5021
5022
5023
5024
5025
5026
5027
5028
5029
5030
5031
5032
5033
5034
5035
5036
5037
5038
5039
5040
5041
5042
5043
5044
5045
5046
5047
5048
5049
5050
5051
5052
5053
5054
5055
5056
5057
5058
5059
5060
5061
5062
5063
5064
5065
5066
5067
5068
5069
5070
5071
5072
5073
5074
5075
5076
5077
5078
5079
5080
5081
5082
5083
5084
5085
5086
5087
5088
5089
5090
5091
5092
5093
5094
5095
5096
5097
5098
5099
5100
5101
5102
5103
5104
5105
5106
5107
5108
5109
5110
5111
5112
5113
5114
5115
5116
5117
5118
5119
5120
5121
5122
5123
5124
5125
5126
5127
5128
5129
5130
5131
5132
5133
5134
5135
5136
5137
5138
5139
5140
5141
5142
5143
5144
5145
5146
5147
5148
5149
5150
5151
5152
5153
5154
5155
5156
5157
5158
5159
5160
5161
5162
5163
5164
5165
5166
5167
5168
5169
5170
5171
5172
5173
5174
5175
5176
5177
5178
5179
5180
5181
5182
5183
5184
5185
5186
5187
5188
5189
5190
5191
5192
5193
5194
5195
5196
5197
5198
5199
5200
5201
5202
5203
5204
5205
5206
5207
5208
5209
5210
5211
5212
5213
5214
5215
5216
5217
5218
5219
5220
5221
5222
5223
5224
5225
5226
5227
5228
5229
5230
5231
5232
5233
5234
5235
5236
5237
5238
5239
5240
5241
5242
5243
5244
5245
5246
5247
5248
5249
5250
5251
5252
5253
5254
5255
5256
5257
5258
5259
5260
5261
5262
5263
5264
5265
5266
5267
5268
5269
5270
5271
5272
5273
5274
5275
5276
5277
5278
5279
5280
5281
5282
5283
5284
5285
5286
5287
5288
5289
5290
5291
5292
5293
5294
5295
5296
5297
5298
5299
5300
5301
5302
5303
5304
5305
5306
5307
5308
5309
5310
5311
5312
5313
5314
5315
5316
5317
5318
5319
5320
5321
5322
5323
5324
5325
5326
5327
5328
5329
5330
5331
5332
5333
5334
5335
5336
5337
5338
5339
5340
5341
5342
5343
5344
5345
5346
5347
5348
5349
5350
5351
5352
5353
5354
5355
5356
5357
5358
5359
5360
5361
5362
5363
5364
5365
5366
5367
5368
5369
5370
5371
5372
5373
5374
5375
5376
5377
5378
5379
5380
5381
5382
5383
5384
5385
5386
5387
5388
5389
5390
5391
5392
5393
5394
5395
5396
5397
5398
5399
5400
5401
5402
5403
5404
5405
5406
5407
5408
5409
5410
5411
5412
5413
5414
5415
5416
5417
5418
5419
5420
5421
5422
5423
5424
5425
5426
5427
5428
5429
5430
5431
5432
5433
5434
5435
5436
5437
5438
5439
5440
5441
5442
5443
5444
5445
5446
5447
5448
5449
5450
5451
5452
5453
5454
5455
5456
5457
5458
5459
5460
5461
5462
5463
5464
5465
5466
5467
5468
5469
5470
5471
5472
5473
5474
5475
5476
5477
5478
5479
5480
5481
5482
5483
5484
5485
5486
5487
5488
5489
5490
5491
5492
5493
5494
5495
5496
5497
5498
5499
5500
5501
5502
5503
5504
5505
5506
5507
5508
5509
5510
5511
5512
5513
5514
5515
5516
5517
5518
5519
5520
5521
5522
5523
5524
5525
5526
5527
5528
5529
5530
5531
5532
5533
5534
5535
5536
5537
5538
5539
5540
5541
5542
5543
5544
5545
5546
5547
5548
5549
5550
5551
5552
5553
5554
5555
5556
5557
5558
5559
5560
5561
5562
5563
5564
5565
5566
5567
5568
5569
5570
5571
5572
5573
5574
5575
5576
5577
5578
5579
5580
5581
5582
5583
5584
5585
5586
5587
5588
5589
5590
5591
5592
5593
5594
5595
5596
5597
5598
5599
5600
5601
5602
5603
5604
5605
5606
5607
5608
5609
5610
5611
5612
5613
5614
5615
5616
5617
5618
5619
5620
5621
5622
5623
5624
5625
5626
5627
5628
5629
5630
5631
5632
5633
5634
5635
5636
5637
5638
5639
5640
5641
5642
5643
5644
5645
5646
5647
5648
5649
5650
5651
5652
5653
5654
5655
5656
5657
5658
5659
5660
5661
5662
5663
5664
5665
5666
5667
5668
5669
5670
5671
5672
5673
5674
5675
5676
5677
5678
5679
5680
5681
5682
5683
5684
5685
5686
5687
5688
5689
5690
5691
5692
5693
5694
5695
5696
5697
5698
5699
5700
5701
5702
5703
5704
5705
5706
5707
5708
5709
5710
5711
5712
5713
5714
5715
5716
5717
5718
5719
5720
5721
5722
5723
5724
5725
5726
5727
5728
5729
5730
5731
5732
5733
5734
5735
5736
5737
5738
5739
5740
5741
5742
5743
5744
5745
5746
5747
5748
5749
5750
5751
5752
5753
5754
5755
5756
5757
5758
5759
5760
5761
5762
5763
5764
5765
5766
5767
5768
5769
5770
5771
5772
5773
5774
5775
5776
5777
5778
5779
5780
5781
5782
5783
5784
5785
5786
5787
5788
5789
5790
5791
5792
5793
5794
5795
5796
5797
5798
5799
5800
5801
5802
5803
5804
5805
5806
5807
5808
5809
5810
5811
5812
5813
5814
5815
5816
5817
5818
5819
5820
5821
5822
5823
5824
5825
5826
5827
5828
5829
5830
5831
5832
5833
5834
5835
5836
5837
5838
5839
5840
5841
5842
5843
5844
5845
5846
5847
5848
5849
5850
5851
5852
5853
5854
5855
5856
5857
5858
5859
5860
5861
5862
5863
5864
5865
5866
5867
5868
5869
5870
5871
5872
5873
5874
5875
5876
5877
5878
5879
5880
5881
5882
5883
5884
5885
5886
5887
5888
5889
5890
5891
5892
5893
5894
5895
5896
5897
5898
5899
5900
5901
5902
5903
5904
5905
5906
5907
5908
5909
5910
5911
5912
5913
5914
5915
5916
5917
5918
5919
5920
5921
5922
5923
5924
5925
5926
5927
5928
5929
5930
5931
5932
5933
5934
5935
5936
5937
5938
5939
5940
5941
5942
5943
5944
5945
5946
5947
5948
5949
5950
5951
5952
5953
5954
5955
5956
5957
5958
5959
5960
5961
5962
5963
5964
5965
5966
5967
5968
5969
5970
5971
5972
5973
5974
5975
5976
5977
5978
5979
5980
5981
5982
5983
5984
5985
5986
5987
5988
5989
5990
5991
5992
5993
5994
5995
5996
5997
5998
5999
6000
6001
6002
6003
6004
6005
6006
6007
6008
6009
6010
6011
6012
6013
6014
6015
6016
6017
6018
6019
6020
6021
6022
6023
6024
6025
6026
6027
6028
6029
6030
6031
6032
6033
6034
6035
6036
6037
6038
6039
6040
6041
6042
6043
6044
6045
6046
6047
6048
6049
6050
6051
6052
6053
6054
6055
6056
6057
6058
6059
6060
6061
6062
6063
6064
6065
6066
6067
6068
6069
6070
6071
6072
6073
6074
6075
6076
6077
6078
6079
6080
6081
6082
6083
6084
6085
6086
6087
6088
6089
6090
6091
6092
6093
6094
6095
6096
6097
6098
6099
6100
6101
6102
6103
6104
6105
6106
6107
6108
6109
6110
6111
6112
6113
6114
6115
6116
6117
6118
6119
6120
6121
6122
6123
6124
6125
6126
6127
6128
6129
6130
6131
6132
6133
6134
6135
6136
6137
6138
6139
6140
6141
6142
6143
6144
6145
6146
6147
6148
6149
6150
6151
6152
6153
6154
6155
6156
6157
6158
6159
6160
6161
6162
6163
6164
6165
6166
6167
6168
6169
6170
6171
6172
6173
6174
6175
6176
6177
6178
6179
6180
6181
6182
6183
6184
6185
6186
6187
6188
6189
6190
6191
6192
6193
6194
6195
6196
6197
6198
6199
6200
6201
6202
6203
6204
6205
6206
6207
6208
6209
6210
6211
6212
6213
6214
6215
6216
6217
6218
6219
6220
6221
6222
6223
6224
6225
6226
6227
6228
6229
6230
6231
6232
6233
6234
6235
6236
6237
6238
6239
6240
6241
6242
6243
6244
6245
6246
6247
6248
6249
6250
6251
6252
6253
6254
6255
6256
6257
6258
6259
6260
6261
6262
6263
6264
6265
6266
6267
6268
6269
6270
6271
6272
6273
6274
6275
6276
6277
6278
6279
6280
6281
6282
6283
6284
6285
6286
6287
6288
6289
6290
6291
6292
6293
6294
6295
6296
6297
6298
6299
6300
6301
6302
6303
6304
6305
6306
6307
6308
6309
6310
6311
6312
6313
6314
6315
6316
6317
6318
6319
6320
6321
6322
6323
6324
6325
6326
6327
6328
6329
6330
6331
6332
6333
6334
6335
6336
6337
6338
6339
6340
6341
6342
6343
6344
6345
6346
6347
6348
6349
6350
6351
6352
6353
6354
6355
6356
6357
6358
6359
6360
6361
6362
6363
6364
6365
6366
6367
6368
6369
6370
6371
6372
6373
6374
6375
6376
6377
6378
6379
6380
6381
6382
6383
6384
6385
6386
6387
6388
6389
6390
6391
6392
6393
6394
6395
6396
6397
6398
6399
6400
6401
6402
6403
6404
6405
6406
6407
6408
6409
6410
6411
6412
6413
6414
6415
6416
6417
6418
6419
6420
6421
6422
6423
6424
6425
6426
6427
6428
6429
6430
6431
6432
6433
6434
6435
6436
6437
6438
6439
6440
6441
6442
6443
6444
6445
6446
6447
6448
6449
6450
6451
6452
6453
6454
6455
6456
6457
6458
6459
6460
6461
6462
6463
6464
6465
6466
6467
6468
6469
6470
6471
6472
6473
6474
6475
6476
6477
6478
6479
6480
6481
6482
6483
6484
6485
6486
6487
6488
6489
6490
6491
6492
6493
6494
6495
6496
6497
6498
6499
6500
6501
6502
6503
6504
6505
6506
6507
6508
6509
6510
6511
6512
6513
6514
6515
6516
6517
6518
6519
6520
6521
6522
6523
6524
6525
6526
6527
6528
6529
6530
6531
6532
6533
6534
6535
6536
6537
6538
6539
6540
6541
6542
6543
6544
6545
6546
6547
6548
6549
6550
6551
6552
6553
6554
6555
6556
6557
6558
6559
6560
6561
6562
6563
6564
6565
6566
6567
6568
6569
6570
6571
6572
6573
6574
6575
6576
6577
6578
6579
6580
6581
6582
6583
6584
6585
6586
6587
6588
6589
6590
6591
6592
6593
6594
6595
6596
6597
6598
6599
6600
6601
6602
6603
6604
6605
6606
6607
6608
6609
6610
6611
6612
6613
6614
6615
6616
6617
6618
6619
6620
6621
6622
6623
6624
6625
6626
6627
6628
6629
6630
6631
6632
6633
6634
6635
6636
6637
6638
6639
6640
6641
6642
6643
6644
6645
6646
6647
6648
6649
6650
6651
6652
6653
6654
6655
6656
6657
6658
6659
6660
6661
6662
6663
6664
6665
6666
6667
6668
6669
6670
6671
6672
6673
6674
6675
6676
6677
6678
6679
6680
6681
6682
6683
6684
6685
6686
6687
6688
6689
6690
6691
6692
6693
6694
6695
6696
6697
6698
6699
6700
6701
6702
6703
6704
6705
6706
6707
6708
6709
6710
6711
6712
6713
6714
6715
6716
6717
6718
6719
6720
6721
6722
6723
6724
6725
6726
6727
6728
6729
6730
6731
6732
6733
6734
6735
6736
6737
6738
6739
6740
6741
6742
6743
6744
6745
6746
6747
6748
6749
6750
6751
6752
6753
6754
6755
6756
6757
6758
6759
6760
6761
6762
6763
6764
6765
6766
6767
6768
6769
6770
6771
6772
6773
6774
6775
6776
6777
6778
6779
6780
6781
6782
6783
6784
6785
6786
6787
6788
6789
6790
6791
6792
6793
6794
6795
6796
6797
6798
6799
6800
6801
6802
6803
6804
6805
6806
6807
6808
6809
6810
6811
6812
6813
6814
6815
6816
6817
6818
6819
6820
6821
6822
6823
6824
6825
6826
6827
6828
6829
6830
6831
6832
6833
6834
6835
6836
6837
6838
6839
6840
6841
6842
6843
6844
6845
6846
6847
6848
6849
6850
6851
6852
6853
6854
6855
6856
6857
6858
6859
6860
6861
6862
6863
6864
6865
6866
6867
6868
6869
6870
6871
6872
6873
6874
6875
6876
6877
6878
6879
6880
6881
6882
6883
6884
6885
6886
6887
6888
6889
6890
6891
6892
6893
6894
6895
6896
6897
6898
6899
6900
6901
6902
6903
6904
6905
6906
6907
6908
6909
6910
6911
6912
6913
6914
6915
6916
6917
6918
6919
6920
6921
6922
6923
6924
6925
6926
6927
6928
6929
6930
6931
6932
6933
6934
6935
6936
6937
6938
6939
6940
6941
6942
6943
6944
6945
6946
6947
6948
6949
6950
6951
6952
6953
6954
6955
6956
6957
6958
6959
6960
6961
6962
6963
6964
6965
6966
6967
6968
6969
6970
6971
6972
6973
6974
6975
6976
6977
6978
6979
6980
6981
6982
6983
6984
6985
6986
6987
6988
6989
6990
6991
6992
6993
6994
6995
6996
6997
6998
6999
7000
7001
7002
7003
7004
7005
7006
7007
7008
7009
7010
7011
7012
7013
7014
7015
7016
7017
7018
7019
7020
7021
7022
7023
7024
7025
7026
7027
7028
7029
7030
7031
7032
7033
7034
7035
7036
7037
7038
7039
7040
7041
7042
7043
7044
7045
7046
7047
7048
7049
7050
7051
7052
7053
7054
7055
7056
7057
7058
7059
7060
7061
7062
7063
7064
7065
7066
7067
7068
7069
7070
7071
7072
7073
7074
7075
7076
7077
7078
7079
7080
7081
7082
7083
7084
7085
7086
7087
7088
7089
7090
7091
7092
7093
7094
7095
7096
7097
7098
7099
7100
7101
7102
7103
7104
7105
7106
7107
7108
7109
7110
7111
7112
7113
7114
7115
7116
7117
7118
7119
7120
7121
7122
7123
7124
7125
7126
7127
7128
7129
7130
7131
7132
7133
7134
7135
7136
7137
7138
7139
7140
7141
7142
7143
7144
7145
7146
7147
7148
7149
7150
7151
7152
7153
7154
7155
7156
7157
7158
7159
7160
7161
7162
7163
7164
7165
7166
7167
7168
7169
7170
7171
7172
7173
7174
7175
7176
7177
7178
7179
7180
7181
7182
7183
7184
7185
7186
7187
7188
7189
7190
7191
7192
7193
7194
7195
7196
7197
7198
7199
7200
7201
7202
7203
7204
7205
7206
7207
7208
7209
7210
7211
7212
7213
7214
7215
7216
7217
7218
7219
7220
7221
7222
7223
7224
7225
7226
7227
7228
7229
7230
7231
7232
7233
7234
7235
7236
7237
7238
7239
7240
7241
7242
7243
7244
7245
7246
7247
7248
7249
7250
7251
7252
7253
7254
7255
7256
7257
7258
7259
7260
7261
7262
7263
7264
7265
7266
7267
7268
7269
7270
7271
7272
7273
7274
7275
7276
7277
7278
7279
7280
7281
7282
7283
7284
7285
7286
7287
7288
7289
7290
7291
7292
7293
7294
7295
7296
7297
7298
7299
7300
7301
7302
7303
7304
7305
7306
7307
7308
7309
7310
7311
7312
7313
7314
7315
7316
7317
7318
7319
7320
7321
7322
7323
7324
7325
7326
7327
7328
7329
7330
7331
7332
7333
7334
7335
7336
7337
7338
7339
7340
7341
7342
7343
7344
7345
7346
7347
7348
7349
7350
7351
7352
7353
7354
7355
7356
7357
7358
7359
7360
7361
7362
7363
7364
7365
7366
7367
7368
7369
7370
7371
7372
7373
7374
7375
7376
7377
7378
7379
7380
7381
7382
7383
7384
7385
7386
7387
7388
7389
7390
7391
7392
7393
7394
7395
7396
7397
7398
7399
7400
7401
7402
7403
7404
7405
7406
7407
7408
7409
7410
7411
7412
7413
7414
7415
7416
7417
7418
7419
7420
7421
7422
7423
7424
7425
7426
7427
7428
7429
7430
7431
7432
7433
7434
7435
7436
7437
7438
7439
7440
7441
7442
7443
7444
7445
7446
7447
7448
7449
7450
7451
7452
7453
7454
7455
7456
7457
7458
7459
7460
7461
7462
7463
7464
7465
7466
7467
7468
7469
7470
7471
7472
7473
7474
7475
7476
7477
7478
7479
7480
7481
7482
7483
7484
7485
7486
7487
7488
7489
7490
7491
7492
7493
7494
7495
|
2001-01-04 Iain Holmes <iain@helixcode.com>
* mail-summary.c (idle_check): Check if the HTML for the current summary
has been created, and if not then keep trying until it has.
(new_folder_cb)
(removed_folder_cb)
(create_summary_view): Use the idle_check function to generate the
summary.
(create_summary_view): Don't set the HTML here. Set it via the pipe.
2001-01-05 Jeffrey Stedfast <fejj@helixcode.com>
* mail-account-editor.[c,h]: New source files to provide an
account editor widget.
* mail-config-druid.c (auth_type_changed): Set the authproto on
the druid so we can look it up later.
2001-01-05 Jeffrey Stedfast <fejj@helixcode.com>
* mail-accounts.c (mail_add): Since the druid now handles adding
the new account to the config, we'll just connect to the destroy
event and show the druid.
(mail_add_finished): Just reload the account list here.
* mail-config-druid.c (druid_finish): New callback to handle the
"finish" signal. On second thought, it seems it would be best for
the finish callback to be here rather than in mail-accounts.c.
* mail-accounts.[c,h]: Added. Contains source for the Account manager
window. And just like mail-config-druid.c, it's not yet complete.
* mail-config-druid.c (mail_config_druid_get_incoming_keep_mail):
Renamed from _delete_mail
(mail_config_druid_get_transport_url): New convenience function
that replaces the get_hostname, get_protocol, etc.
(mail_config_druid_get_source_url): Same.
* mail-config-druid.glade: Changed "Delete mail from server" to
"Keep mail on server" as this has a more positive ring to it. Both
I and Aaron agree this is the better phrase.
2001-01-04 Jeffrey Stedfast <fejj@helixcode.com>
* mail-config-druid.c: Fixed a few 'Oops'es.
* mail-config-druid.glade: Added a "Default" button for marking an
account as the default.
2001-01-04 Jeffrey Stedfast <fejj@helixcode.com>
* mail-config-druid.glade: Updated. What else can I say?
2001-01-04 Dan Winship <danw@helixcode.com>
* folder-browser.c (got_folder): Connect to "message_changed" on
the folder if it's on a remote storage.
(update_unread_count): Update the folder unread count / highlight
in the shell when the unread message count changes
2001-01-04 Not Zed <NotZed@HelixCode.com>
* mail-ops.c (mail_do_send_mail): Removed old implementation.
* folder-browser.c (do_message_selected): If we haven't got a real
uid, then clear the display instead.
* message-list.c (message_list_drag_data_get): Use new save
message function, and also wait for it to finish before
continuing.
(folder_changed):
(message_changed): Use mail_proxy_event instead of
mail_do_forward.
(mail_regen_list): New iplementation to replace the old.
: remove <gnome.h> from headers. Dont define timeit by default.
(main_folder_changed):
(message_list_set_folder):
(message_list_set_threaded):
(message_list_set_search):
(message_list_hide_add):
(message_list_hide_uids):
(message_list_hide_clear): Use mail_regen_list instead of
mail_do_regenerate_messagelist.
(mail_do_regenerate_messagelist): Removed the old stuff. No
functionality changed yet, just using different thread stuff.
* mail-callbacks.c (save_msg_ok): Use new save message function.
* component-factory.c (create_view):
(add_storage): Use mail_scan_subfolders to build the folder info.
(create_folder): Use new implementation with our own callback.
(owner_set_cb): Changed b ack to use mail_get_folder, but now wait
for it to finish. This will let any gui still run, but also gives
us the required synchronous operation.
(got_folder): Callback for when the folder has been opened.
* mail-ops.c (mail_get_folderinfo): New function to just get the
folder info in another thread.
(mail_scan_subfolders): New scan subfolder implementation that
uses mail_get_folderinfo.
(mail_do_scan_subfolders): Removed old implementation.
(mail_create_folder): Nerw implementation to create a folder, only.
(mail_do_create_folder): Removed old implementation.
(mail_save_messages): New implementation, fixes a couple of minor
problems, and now provides a return so it can be waited on. Also
check that the writes worked, etc.
(mail_do_save_messages): Remove previous implementation.
(mail_do_flag_messages): Removed, nothing uses it.
(mail_do_flag_messages): Removed, nothing uses it anymore.
(mail_get_folder): REturn the operation id, so callers can wait
for it.
(sync_folder_desc):
(expunge_folder_desc): Add describe functions so we know what its
doing.
(mail_send_mail): More generic implementation of sending mail.
* mail-mt.c (mail_msg_new): Lock around seq increment. And insert
each new message into a hash table of active messages.
(mail_msg_init): Init the active message table.
(mail_msg_free): Remove the message from the active message table.
(mail_msg_wait): New function, waits for a message to be
processed, by id.
(mail_msg_check_error): Dont display the error if it is a
user-cancelled operation.
(mail_proxy_event): new implementation of mail_op_forward_event.
Only real difference is it uses the new thread stuff, and you can
wait for it to finish if you want.
(mail_proxy_event): If we're already in the main thread, just call
the function.
2001-01-03 Jeffrey Stedfast <fejj@helixcode.com>
* mail-config-druid.c: New source file that implements
mail-config-druid. Note: this is not yet complete.
2001-01-03 Not Zed <NotZed@HelixCode.com>
* mail-view.c (view_forward_msg): Call
mail-callbacks.c:forward_messages(), so the behaviour is the same
as from the folder browser.
* mail-callbacks.c (forward_messages): New function to forward
messages, attached or not.
(forward_inlined): Changed to use new forward-messages
implementation.
(forward_attached): Likewise.
(do_forward_attach): Callback for forwarding as attachment, once
we have built it.
(do_forward_inline): Likewise, for inline, once we have retrieved
the message.
(forward_message): Removed.
* mail-ops.c (mail_build_attachment): New function to build an
attachment of messages.
(mail_do_attach_message): Removed, functionality superceeded by
above.
(mail_do_forward_message): Removed. Likewise.
(mail_create_folder): Started work on an alternative
implementation of create_folder, but not sure about it yet.
* mail-tools.c (mail_tool_generate_forward_subject): Remove locking.
(mail_tool_make_message_attachment): Free the description when done.
2001-01-03 Radek Doulik <rodo@helixcode.com>
* mail-format.c (write_headers): add font color setting for table,
changed border behavior
* mail-display.c (redisplay): don't set body bg and text color
2001-01-02 Not Zed <NotZed@HelixCode.com>
* mail-callbacks.c (view_msg): Fix for mail_get_message change,
use queue thread.
* folder-browser.c (done_message_selected): Fix mail_Get_message
calls, use new thread.
(do_message_selected): "
* mail-ops.c (mail_get_message): Add a thread argument so callers
can specify which queue it executes on.
* mail-mt.c (mail_msg_free): Fix a free order problem.
(mail_msg_destroy): Call mail_msg_free to do the work.
(mail_msgport_replied): "
(mail_msgport_replied): Check/display errors if we get them.
(mail_msgport_received): If we have a describe function, say what
we're doing, also set busy/unbusy.
(mail_msgport_replied): Clear busy when we get a reply.
(mail_get_password): Unset busy.
(mail_msg_received): Set busy as we go.
(mail_msg_destroy): Unset busy when done.
(mail_status): Blah blah, new status interface, the other wans't
workable with the way the shell api works.
2000-12-29 Not Zed <NotZed@HelixCode.com>
* folder-browser.c (do_message_selected): If we are reconfiguring,
just keep polling till we are done (yeah kinda shitty, but easy).
(folder_browser_set_uri): Clear reconfigure flag here. ick.
(got_folder): And here too.
(on_right_click): Remove locking.
(hide_sender): and here too.
(hide_subject): And here.
(on_right_click): If we are in reconfigure, then the whole menu is disabled.
* mail-mt.c (status_busy_timeout): Clear the status_busy_timeout_id.
* mail-local.c (local_storage_new_folder_cb): Made getting folders
completely synchronous. The shell expects it, and it was only
synchronous before by a sideeffect.
(do_reconfigure_folder): Remove locking stuff.
(do_reconfigure_folder): Use our own much simpler copying routine
than that stupid move_folder_contents thing.
(update_progress): Use mail_status_message() instead.
(do_reconfigure_folder): Set the reconfigure flag during
reconfigure & set busy flag.
(cleanup_reconfigure_folder): clear busy flag.
* mail-tools.c (mail_tool_uri_to_folder): Remove the tool_lock
stuff.
(mail_tool_uri_to_folder_noex): Clear exception on exit.
(mail_tool_move_folder_contents): Get rid of this really stupid
function that is only used in one place.
* component-factory.c (owner_set_cb): Use direct calls to get the
folders, as this code must run synchronous. Remove the event wait
stuff.
* mail-callbacks.c (edit_msg): Call mail_get_messages, and create
the composers ourself.
(do_edit_messages): get_messages callback, create the composers
and connect to signals we need.
(view_msg): Dont call do_view_messages, just call
mail_get_messge for each to get them in parallel.
(do_view_message): view a single message.
* mail-ops.c (mail_edit_messages): Just use mail_get_messages
for this operation. Removed the other async operation stuff.
Changed my mind, just removed entirely.
(mail_do_view_messages): Removed.
(mail_do_setup_folder): Removed.
(mail_do_scan_subfolders): Make this run synchronously, as every
caller expects it to (even if they didn't realise).
2000-12-28 Not Zed <NotZed@HelixCode.com>
* mail-callbacks.c (send_queued_mail): Dont expunge the folder
here, but in send_queue, otherwise it might execute out of order.
(expunge_folder): Remove the talbe prechange stuff, and infact
references to the message_list folder, as we have our own folder.
Also, dont allow expunge if we're already expunging.
(expunged_folder): Clkear the expunging flag if we're finished.
* folder-browser-factory.c (control_deactivate): Likewise here.
Hrm, i thought this function required a callback, silly me.
* mail-tools.c (mail_tool_make_message_attachment): Remov e
locking.
* folder-browser.c (on_message_selected): Use a timeout handler so
we dont select immediately.
(folder_browser_set_uri): Changed to use mail_get_folder.
(got_folder): New callback called when get_folder is finished.
(folder_browser_destroy): Use new sync interface.
* mail-ops.c (mail_get_message): New function to asynchrounously
get a message.
: #define out mail_tool_camel_lock stuff entirely.
(mail_get_folder): New function to asynchrounously get a folder.
(mail_do_load_folder): Removed, replaced by more generic function
above.
(mail_do_display_message): Removed, replaced by the more generic
funciton get_message.
(mail_get_messages): New function to get a list of messages
asynchronously.
(mail_sync_folder): New interface to sync a folder async.
(mail_expunge_folder): New interface for expunging folder, with
callback.
(do_send_queue): Remove lock stuff, and expunge if (and only if)
successful, also sync the sent folder while we're at it.
* session.c (mail_session_request_dialog): Changed to use new
mail_get_password call.
* mail-mt.[ch]: New threading/interthread messaging framework.
* main.c (main): Init the message/thread system.
2001-01-02 Dan Winship <danw@helixcode.com>
* mail-format.c (mail_part_is_inline):
(find_preferred_alternative):
* mail-display.c (launch_cb): Use header_content_type_simple, not
header_content_type_format.
2000-12-26 Jeffrey Stedfast <fejj@helixcode.com>
* mail-crypto.c (mail_crypto_openpgp_verify): Implemented.
2000-12-23 Jeffrey Stedfast <fejj@helixcode.com>
* mail-ops.c (mail_do_setup_trash): New function similar to
mail_do_setup_folder() except that this creates the Trash VFolder
(special-case).
2000-12-21 Jeffrey Stedfast <fejj@helixcode.com>
* mail-ops.c (do_send_mail): Don't free info inside the last
if-statement, if sent_folder doesn't exist we'll have a memory
leak. Instead free it afterward.
2000-12-29 Dan Winship <danw@helixcode.com>
* mail-crypto.c: Oops. Update this for CamelContentType stuff too.
2000-12-28 Dan Winship <danw@helixcode.com>
* mail-format.c (mail_part_is_inline, mail_get_message_body): Use
CamelContentType, and use header_content_type_is instead of doing
it by hand.
(handle_text_plain):
(handle_multipart_related):
(find_preferred_alternative):
(handle_message_external_body): Use CamelContentType and
header_content_type_* functions instead of GMimeContentField.
* mail-display.c (write_data_to_file, launch_cb): Use
CamelContentType and header_content_type_* functions instead of
GMimeContentField.
2000-12-26 Iain Holmes <iain@helixcode.com>
* mail-display.c (mail_display_init): Initialise the thumbnail cache.
(mail_display_destroy): Free the cache.
(pixbuf_gen_idle): Check the cache for a pixbuf, add the pixbuf to the
cache if it's not there.
2000-12-26 Iain Holmes <iain@helixcode.com>
* mail-summary.c (create_summary_view): Create a shared
BonoboEventSource object and use it for all the objects that
aggregate Bonobo::EventSource.
2000-12-27 Dan Winship <danw@helixcode.com>
* subscribe-dialog.c (setup_subscribe_folder): Use info->name, not
input->full_name. Fixes #1029 in bugzilla.helixcode.com.
({setup,do,cleanup}_subscribe_folder): Update previous fix: Jeff
had changed it to use ->full_name instead of ->name because that's
what camel_store_subscribe_folder needed. So we need to have
*both* names available, one for Camel, one for the shell.
2000-12-24 Christopher James Lahey <clahey@helixcode.com>
* message-list.c (filter_date): Changed this to format times in 12
hour time instead of 24 hour time.
2000-12-24 Christopher James Lahey <clahey@helixcode.com>
* message-list.c (filter_date): Changed this to do different
formatting of dates within the last week.
2000-12-24 Not Zed <NotZed@HelixCode.com>
* Merge from camel-mt-branch.
2000-12-23 Christopher James Lahey <clahey@helixcode.com>
* message-list.c (filter_date): Changed this to do different
formatting of dates based on the current time.
2000-12-23 Christopher James Lahey <clahey@helixcode.com>
* message-list.c (message_list_get_layout): Added titles to the
pixbuf columns.
2000-12-21 Iain Holmes <iain@helixcode.com>
* mail-summary.c: Added code to detect and regenerate the summary
when a new vfolder is created or removed.
* mail-vfolder.c: Export the vfolder_storage variable, so that
the summary can add a listener to it.
2000-12-05 Iain Holmes <iain@helixcode.com>
* component-factory.c (factory_destroy): Wait till all views have
gone and then destroy both factories.
2000-12-21 Dan Winship <danw@helixcode.com>
* mail-display.c (pixbuf_for_mime_type): Deal with the possibility
that we have an icon-filename listed for a MIME type, but the icon
file doesn't actually exist. Also, if gnome-unknown.png can't be
found, fall back. Might fix a crash people have been reporting...
2000-12-18 Chris Toshok <toshok@helixcode.com>
* mail-format.c (handle_multipart_encrypted): for now #ifdef
PGP_PROGRAM falling back to handle_multipart_mixed.
(handle_multipart_signed): same.
2000-12-18 Dan Winship <danw@helixcode.com>
* message-list.c (hide_save_state): Unlock camel when done to
prevent a hang later.
2000-12-18 Miguel de Icaza <miguel@helixcode.com>
* mail-tools.c (mail_tool_move_folder_contents): Only update
display every 2 seconds.
* mail-ops.c (do_view_messages): Only update display every 2 seconds.
2000-12-23 Not Zed <NotZed@HelixCode.com>
* message-list.h (MessageList): Add a specific hide data lock.
* message-list.c (message_list_drag_data_get): Do not use
cursor_uid, but get all currentlys elected messages directly off
the message-list.
(message_list_destroy): Removed mail_tool_camel_lock stuff.
(on_click): "
(message_list_hide_add, message_list_hide_uids, hide_load_state,
hide_save_state, message_list_hide_clear): ", but use a specfic
lock for the hide data.
(do_regenerate_messagelist): remove mail_tool_camel_lock stuff,
add hide_lock where required.
(message_list_init): Setup the hide_lock.
(message_list_destroy): Free the hide_lock.
2000-12-22 Not Zed <NotZed@HelixCode.com>
* mail-ops.c (mail_do_sync_folder): Run sync in different thread
each time. Just a quick litlte hack to check multithreading.
There are now few operations that single-queue. Need to work out
a way to make the allocation of threads & resources easier, so we
dont get overwhelmed with threads, but we dont block when we dont
have to, either.
* message-list.c (main_folder_changed): If we have only changed
events, then process them directly.
(mail_do_regenerate_messagelist): Run regenerate in a new thread
each time, another quick hack to check mutlithreading.
* mail-view.c (view_delete_msg): Call camel folder set message
flags directly. mail_do_set_message_flags() is now completely
unused.
* folder-browser.c (mark_msg_seen): Call camel folder
set_message_flags directly.
* mail-callbacks.c (flag_messages): New function, that just sets
flags of all selected messages, without all that messy thread
stuff (setting flags is in-memory).
(mark_as_seen): Use flag_messages().
(mark_as_unseen): "
(undelete_msg): "
(delete_msg): "
2000-12-20 Not Zed <NotZed@HelixCode.com>
* message-list.c (message_list_select): Free messageinfo lookups.
(message_list_drag_data_get): "
(subtree_unread): "
(subtree_size): "
(subtree_earliest): "
(ml_tree_value_at): " Also, keep the message info around in a
static variable, and ref'd, so that any internal references we
have to it dont vanish while we're not looking. This has a couple
of problems ... esp since we never unref the last access, although
camel-folder-summary wont check this when its unref'd, so we're
'safe'.
(save_node_state): free messageinfo lookups.
(on_click): "
(get_message_info): deconstify return.
* mail-tools.c (mail_tool_move_folder_contents): Free messageinfo
lookups.
* mail-ops.c (do_filter_ondemand): Free messageinfo lookups.
(do_flag_messages): "
(do_fetch_mail): Remove mail_tool_lock stuff.
(mail_operation_run): Quick hack to run an operation
asynchrounously, in a brand-new thread.
* folder-browser.c (on_right_click): Free messageinfo lookups.
2000-12-16 Not Zed <NotZed@HelixCode.com>
* message-list.c (build_tree): Always use the slow (full-update)
version of the tree update code, to get around a bug(?) in etree.
(build_flat): Likewise.
2000-12-15 Not Zed <NotZed@HelixCode.com>
* mail-display.c (write_data_to_file): Dont blindly convert all
parts to utf8, e.g. image/jpg. We only convert text/* parts, and
only then if required.
2000-12-14 Not Zed <NotZed@HelixCode.com>
* component-factory.c (create_view): cast over a warning.
* folder-browser-factory.c: Add verbs for hide functions.
* message-list.c (message_list_hide_clear):
(message_list_hide_uids):
(message_list_hide_add): Some api renaming.
(message_list_hide_add): Allow ML_HIDE_SAME to be passed to mean
not to change the upper/lower range at all.
(hide_save_state): Save the state of the hide list to stable
storage.
(hide_load_state): Load the state of hte hide list.
(message_list_set_folder): Load/save the state of the folder if it
is changed/set.
(message_list_destroy): Save the state of the folder hide list
when done.
(save_tree_state): If we wrote out an empty state file, simply
remove it instead.
* folder-browser.c (on_right_click): Add some hide menus.
(hide_read): Hide read messages.
(hide_deleted): Hide deleted messages.
(hide_selected): Hide selected/current message.
(hide_none): Show all hidden messages.
(on_right_click): Lock around accesses to the message (inside
mlist_detect_magic).
(on_right_click): Free the mailing list name.
2000-12-13 Not Zed <NotZed@HelixCode.com>
* folder-browser.c (on_right_click): Add camel locking since we
call it directly. Whoever heard of a lock you 'down' to unlock?
* message-list.c (mail_do_regenerate_messagelist): Added hide
expression, messages to hide. Fixed all callers.
(do_regenerate_messagelist): IF we have a hide expression, search
and remove those from the uid list. If we have a hide range,
apply that afterwards.
(cleanup_regenerate_messagelist): Handle freeing the hide uid
temporary data, if required.
(message_list_destroy): Free hide data, also lock around all camel
object stuff.
(message_list_length): New function to get the number of messages
avaialble to be hidden by range.
(message_list_set_hide): Set the hide expression and range.
Issue: Should hiding be remembered?
(message_list_unhide_all): Turn off all hiding.
(message_list_hide_uids): Hide a list of uid's.
2000-12-15 Dan Winship <danw@helixcode.com>
* subscribe-dialog.c (folder_toggle_cb): Update this for the new
signal handler prototype. Fixes the crash on double-click.
2000-12-15 Jeffrey Stedfast <fejj@helixcode.com>
* mail-format.c (handle_multipart_signed): New callback to handle
multipart/signed parts.
(decode_pgp): Update to account for the cipherlen argument needed
for openpgp_decrypt.
(is_rfc2015): Removed as we now have a better version in
mail-crypto.
(handle_multipart_encrypted): Updated to use the PGP/MIME utility
functions.
* mail-crypto.c (mail_crypto_openpgp_decrypt): Don't check
(!*plaintext) as it could be a binary stream. Now also takes a
cipherlen argument.
(mail_crypto_openpgp_sign): New function.
(pgp_mime_part_sign): New function to replace a mime part with the
pgp signed equivalent.
(pgp_mime_part_encrypt): New function to replace a mime part with
the pgp encrypted equivalent.
(pgp_mime_part_decrypt): New function to decrypt a pgp encrypted
mime part (like from pgp_mime_part_encrypt) and replace it.
(is_rfc2015_signed): New function to determine if a mime part is
an rfc2015 signed part.
(is_rfc2015_encrypted): New function to determine if a mime part
is an rfc2015 encrypted part.
(mail_crypto_openpgp_verify): New openpgp function to verify a
signature.
2000-12-14 Christopher James Lahey <clahey@helixcode.com>
* mail-threads.c (update_active_views): Unref the iterator when
we're done with it.
2000-12-14 Larry Ewing <lewing@helixcode.com>
* mail-display.c (mail_display_new): call
gtk_html_set_default_content_type to make gkthtml default to utf-8
when parsing. This requires gtkhtml >= the released 0.8.
2000-12-14 Ettore Perazzoli <ettore@helixcode.com>
* mail-threads.c (read_msg): Call `ui_set_busy()' before
`ui_set_message()' so that we are sure that the
set_busy/unset_busy calls always happen in order.
2000-12-13 Christopher James Lahey <clahey@helixcode.com>
* folder-browser.c (my_folder_browser_init): Made the vertical
scrollbar always be there.
* message-list.c (message_list_get_layout): Changed the minimum
width of some of the pixmap column headers.
2000-12-12 Christopher James Lahey <clahey@helixcode.com>
* component-factory.c (create_view): Added a cast.
* mail-summary.c: Added #include "mail-summary.h". Commented out
folder_free, summary_free, and view_destroy_cb since they're not
used.
(do_changed): Added a cast.
(create_summary_view): Changed some types so that casting would be
easier.
* session.c (mail_session_remember_password): Added a cast.
2000-12-12 Dan Winship <danw@helixcode.com>
* mail-summary.h: Fix to use the right .h instead of the
deprecated one.
2000-12-12 Jeffrey Stedfast <fejj@helixcode.com>
* mail-callbacks.c (forward_message): Attach a signature when
forwarding, fixes bug #826.
2000-12-11 Dan Winship <danw@helixcode.com>
* session.c (mail_session_enable_interaction): New function to
tell the code that it's ok (or not) to interact with the user when
trying to authenticate to a service. Starts out turned off.
(mail_session_request_dialog): If interaction is disabled, fail if
the password isn't in the cache.
* component-factory.c (owner_set_cb): Call
mail_session_enable_interaction() after everything else. (This
means that the IMAP password dialog will no longer pop up [under
the splash screen] at startup.)
2000-12-11 Dan Winship <danw@helixcode.com>
* component-factory.c (create_view): Deal with "mailstorage" type
views (top-level mail storages) by trying to fill the storage's
folder tree again if we failed before.
(add_storage): Create new storages with a URI and type
"mailstorage".
* mail-ops.c (cleanup_scan_subfolders): On success, mark the
storage as having been loaded, so create_view won't try again.
2000-12-11 Jeffrey Stedfast <fejj@helixcode.com>
* mail-format.c (decode_pgp): Updated to reflect arguments to the
openpgp functions - now also takes an outlen argument.
(try_inline_pgp): Updated.
(handle_multipart_encrypted): Updated here too.
* mail-crypto.c (crypto_exec_with_passwd): Updated to handle
binary streams and such.
(mail_crypto_openpgp_encrypt): Always initialize the passwd_fds
even if we don't plan on signing. Added an 'inlen' to specify the
length of the input data (as it could be binary). Also added a
'userid' argument for cases when we want to sign as well as
encrypt.
(mail_crypto_openpgp_decrypt): Updated to take an outlen argument
in case the ciphertext is encrypted binary data.
(mail_crypto_openpgp_clearsign): Added a 'hash' and 'detach'
arguments. 'hash' allows the program to specify the preferred hash
function (which will come in handy when generating
PGP/MIME). 'detach' allows the program to specify whether it wants
a detached signature or the entire signed text.
2000-12-11 Dan Winship <danw@helixcode.com>
* message-list.c: Remove the never-once-used BonoboObject stuff
and make MessageList be a GtkWidget instead. Also, keep track of
the ETable directly rather than repeatedly calling
e_table_scrolled_get_table.
* folder-browser.c (folder_browser_destroy): Use gtk methods
rather than bonobo methods to destroy the message list.
(on_right_click, on_double_click): These are being attached to the
ETable directly now, so fix the first argument (which isn't being
used anyway, but...). Ignore double-clicks on "active" columns
(the ones where clicking does something beyond "select"), fixing
bug #811, which is what got me started on this to begin with...
(folder_browser_gui_init): simplify now that MessageList itself is
a widget. Also use message_list->table rather than
e_table_scrolled_get_table.
* mail-local.c (mail_local_reconfigure_folder): Add "mail_" to
the beginning of this function name to match its prototype and the
other vague namespace conventions in the mailer.
* mail-callbacks.c (select_all, invert_selection): Use ml->table.
(configure_folder): s/local_reconfigure_folder/mail_&/
* mail-ops.c (do_flag_messages): clean up the cleanup a bit
* mail-tools.c (mail_tool_quote_message): Remove an unused
variable.
2000-12-11 Not Zed <NotZed@HelixCode.com>
* local-config.glade: reordered the options and added maildir,
mbox, maildir, mh, in that order.
* mail-local.c (reconfigure_clicked): Added maildir, re-ordered to
match the changed xml file too.
(do_reconfigure_folder): WHoever 'threaded' this code forgot to
check that folder_browser functions shouldn't be called here.
(cleanup_reconfigure_folder): Call it here instead.
(lookup_folder): Blah blah, we have to lookup the folder and
verify its still the same format, joy. Becaause someone thought
it would be wise to make the code 5x more complicated for no
reason, and totally break 'mail reconfigure' in the process. i'm
really happy about that one.
(cleanup_register_folder): Uh, yeah, so like, the
local_store->folders hashtable is supposed to point to like,
LocalFolders, not CamelFolders.
(free_local_folder): Free the localfolder struct properly.
(free_folder): Call above to free data properly.
(get_folder): Fix for fixing folders hashtable.
(local_storage_removed_folder_cb): Same here.
(local_storage_new_folder_cb): Ref the local_store when putting it
in the local_folder.
(cleanup_register_folder): Properly free the local_folder if the
op failed.
(free_local_folder): Unhook events also.
(d): Oops, left debug turned on.
2000-12-09 Christopher James Lahey <clahey@helixcode.com>
* message-list.c (message_list_init): Change the "drawfocus"
argument on e_table_scrolled_get_table(etable) instead of on
etable (etable is an ETableScrolled.)
2000-12-08 Jeffrey Stedfast <fejj@helixcode.com>
* mail-callbacks.c (save_msg_ok): Check to see if the file already
exists, if it does prompt the user to for permission to overwrite
the file.
(forward_message): g_strdup the cursor_uid if there is only a
single message to be forwarded or we'll segfault later.
* mail-ops.c (do_save_messages): Rewrote yet again. I'm back to
almost an identical implementation as the first time I wrote this
except now we write the From line which I had forgotten last
time. This means that we no longer have to unlink the .ev-summary
file created and we also use fewer resources (no need to create a
CamelMboxFolder object).
2000-12-08 JP Rosevear <jpr@helixcode.com>
* folder-browser.c (on_double_click): the e-table double-click
signal now has extra params
2000-12-07 Ettore Perazzoli <ettore@helixcode.com>
* component-factory.c (add_storage): Pass `NULL' as the
@toplevel_node_handler_id arg in `evolution_storage_new()'.
FIXME: We should be passing the ID of the mail component here.
* mail-vfolder.c (vfolder_create_storage): Likewise.
2000-12-08 Jeffrey Stedfast <fejj@helixcode.com>
* message-list.c (message_list_get_layout): Set the "Size" field
to sort using integer comparison instead of string.
(filter_size): New function to transform a integer size into a
more readable form.
(ml_value_to_string): Use filter_size.
(ml_value_is_empty): COL_SIZE is no longer a string, so handle
this as an integer.
(ml_initialize_value): Here too.
(ml_free_value): And here.
(ml_duplicate_value): And here too.
(message_list_create_extras): Setup the size etable cell.
2000-12-08 Christopher James Lahey <clahey@helixcode.com>
* folder-browser.c: Connect to signals on the ETable instead of
the ETableScrolled.
* subscribe-dialog.c: Used the e_table_scrolled_get_table function
instead of accessing the variable directly.
2000-12-08 Christopher James Lahey <clahey@helixcode.com>
* message-list.c: Connect to signals on the ETable instead of the
ETableScrolled.
2000-12-07 Christopher James Lahey <clahey@helixcode.com>
* message-list.c: Got rid of code referencing the ETableScrolled
proxy functions. Changed the call to e_table_set_cursor_row to
send a model row instead of a view row.
2000-12-07 Jeffrey Stedfast <fejj@helixcode.com>
* mail-callbacks.c (forward_message): Only do a
message_list_foreach if we plan on attaching messages, otherwise
just use ml->cursor_uid.
* mail-ops.c (cleanup_forward_messages): If attaching multiple
forwarded message, wrap them in a multipart/digest otherwise just
attach the single message as a message/rfc822.
2000-12-07 Dan Winship <danw@helixcode.com>
* mail-display.c (on_object_requested): Make the iTip hack spew a
g_warning and not crash if you have no identity configured. To be
revisited.
* mail-callbacks.c: (various)
* folder-browser.c (filter_mlist):
* mail-autofilter.c (filter_gui_add_from_message):
* mail-vfolder.c (vfolder_gui_add_from_message): Add some
g_return_if_fail()s to protect from crashes until the code to
enable/disable commands based on how many messages are selected is
done.
2000-12-06 Jeffrey Stedfast <fejj@helixcode.com>
* mail-vfolder.c (vfolder_gui_add_rule): Make the vfolder editor
resize correctly. Fixes bug #835.
2000-12-06 Dan Winship <danw@helixcode.com>
Fix up shutdown so that things that should be destroyed get
destroyed. Among other things, this fixes the bug where IMAP
stores weren't disconnected at shutdown.
* mail-threads.c (update_active_views): Update for
folder_browser_factory_get_control_list change to EList.
* folder-browser-factory.c: Turn control_list into an EList so
that we can safely remove items from it while it's being iterated
(which will happen as FolderBrowsers are destroyed at shutdown
while the thread code is trying to update the status bars).
(control_destroy_cb): Just destroy the folder_browser.
(browser_destroy_cb): New callback for FolderBrowser destroy.
Remove the control from control_list here instead of
control_destroy_cb, because the controls don't seem to get
destroyed reliably...
* component-factory.c: Clean up stuff.
(factory_destroy): Get rid of this.
(owner_unset_cb): Schedule an idle handler to quit.
(idle_quit): Wait for all of the FolderBrowsers to be destroyed
and then destroy the storages and quit.
* mail-summary.h (create_summary_view): Fix prototype
2000-12-06 Jeffrey Stedfast <fejj@helixcode.com>
* mail-config.c (mail_config_folder_to_cachename): Use
e_filename_make_safe (which used to be e_str_make_safe).
* mail-display.c (make_safe_filename): And here.
* message-list.c (message_list_drag_data_get): Here too.
2000-12-06 Dan Winship <danw@helixcode.com>
* mail-local.c (cleanup_register_folder): Run the folder_changed
code on message_changed as well, so the unread message counts
update as messages are read.
* folder-browser.c: Remove bits of filter-on-demand and toolbar
bug workaround cruft that don't do anything useful any more.
* mail-ops.c (cleanup_load_folder): unref the ref we added in
setup_load_folder.
2000-12-05 Jeffrey Stedfast <fejj@helixcode.com>
* mail-display.c (write_data_to_file): Use a charset filter to
make sure the data is written out in the charset it was meant to
be in instead of UTF-8.
* mail-format.c (mail_format_raw_message): Don't use the raw
message body as the format argument, use "%s" instead. If the raw
message contains %'s then it will segfault otherwise.
2000-12-04 Dan Winship <danw@helixcode.com>
* mail-config-gui.c (service_page_item_new): Fix a typo so that
toggling the "remember password" checkbox will activate the "OK"
button if it was inactive.
2000-12-05 Ettore Perazzoli <ettore@helixcode.com>
* mail-vfolder.c (vfolder_create_storage): Updated the call to
`evolution_storage_new()': pass NULL for @toplevel_node_uri.
* component-factory.c (add_storage): Updated the call to
`evolution_storage_new()': pass NULL for @toplevel_node_uri.
2000-12-04 Jeffrey Stedfast <fejj@helixcode.com>
* subscribe-dialog.c (setup_subscribe_folder): Use info->full_name
rather than info->name so that we get the namespace part of the
folder path as well.
2000-12-04 Ettore Perazzoli <ettore@helixcode.com>
* folder-browser-factory.c: Updated to define verbs
"MessageForwardInlined" and "MessageForwardAttached" instead of
"MessageForwardInline" and "MessageForwardAttach".
* folder-browser.c (on_right_click): Make forwarding as an
attachment the default.
* mail-callbacks.c (forward_inlined): Renamed from `forward_msg'.
(forward_attached): Renamed from `forward_attach'.
* mail-callbacks.h: Updated accordingly.
2000-12-01 Dan Winship <danw@helixcode.com>
* session.c (mail_session_remember_password): Writes out passwords
(to .gnome_private) in our patented proprietary "Best Awesome
Super Encryption 64" ("BASE64") format which could not possibly
ever be cracked by even the most cryptographically knowledgeable
five-year-olds.
(mail_session_init): Load remembered passwords at startup.
(mail_session_forget_passwords): Erase them from disk as well as
memory.
* mail-config.c: Add "remember_password" field to
MailConfigService.
(mail_config_write_on_exit): Call mail_session_remember_password
for services with "remember_password" set.
* mail-config-gui.c: Add "remember password" checkbox to the
dialogs, and make it appear and disappear as appropriate.
* component-factory.c (mail_load_storages): Unref the store
regardless of whether or not we're using it, so we don't leak
references to non-storage stores.
2000-12-01 Jeffrey Stedfast <fejj@helixcode.com>
* message-list.c (e_mail_address_new): Perform better
error-handling.
2000-12-01 Radek Doulik <rodo@helixcode.com>
* mail-ops.c (mail_op_report_status): use mail_op_set_message_plain
* mail-threads.c (mail_op_set_message_plain): plain version of
mail_op_set_message, doesn't use printf, passes message untouched,
use set_message
(mail_op_set_message): set_message
(set_message): helper function
2000-11-30 Jeffrey Stedfast <fejj@helixcode.com>
* mail-ops.c (cleanup_fetch_mail): Don't display a dialog, instead
inform the user that there was no new mail by setting a status
message.
* message-list.c (message_list_drag_data_get): Use the new
e_str_make_safe function.
* mail-display.c (make_safe_filename): And here.
* mail-config.c (mail_config_folder_to_cachename): Here too.
2000-11-30 Not Zed <NotZed@HelixCode.com>
* mail-ops.c (cleanup_load_folder): Set threaded view before
setting the folder (cleanup some flash ons tartup).
* message-list.c (message_list_init): Initialise a mempool for uid
string storage.
(new_id_from_uid): Added messagelist arg, allocate strings from
uid_pool.
(new_id_from_subject): Same. Fixed all callers.
(remove_node_diff): Dont free uid here.
(build_flat_diff): Nor here.
(clear_tree): Flush the mempool, rather than freeing the id's
directly.
(free_tree_ids): Removed, no longer required.
(free_tree_ids): Likewise.
(message_list_init): Dont connect to the table destroy signal
anymore to free the uid table.
(message_list_destroy): Free the uid pool here.
(*): Use accessors for messageid stuff.
(content_is_attachment): Removed, no longer required.
(ml_tree_value_at): Get the attachment flag directly from the
summary.
(ml_tree_value_at): For 'fake' nodes, try and do something better
than "?" for from, to, and size.
(subtree_size): New function, add up the total size of a subtree.
(subtree_earliest): Get the earliest date from a subtree.
(ml_tree_value_at): Return earliest date sent/received for fake
nodes.
(ml_tree_value_at): Return something to mark a fake subject line
as a fake subject, although i dont know, i guess this buggers up
sorting ...
(subtree_size): Check the info node is still there.
(subtree_earliest): Same here.
(subtree_unread): And here. The info node might vanish if the
folder has changed/is changing and we try and redraw stuff while
its doing it.
(message_list_drag_data_get): Use accessors.
2000-11-29 Jeffrey Stedfast <fejj@helixcode.com>
* message-list.c (message_list_drag_data_get): Implement.
(message_list_init): Connect the d&d signal.
* mail-ops.c (do_save_messages): Use camel a bit more to help us
out. Don't create the file ourselves, treat it as a CamelFolder so
we don't have to worry about formatting.
2000-11-29 Dan Winship <danw@helixcode.com>
* main.c (main): Remove no-longer-needed e_unicode_init.
* mail-tools.c (mail_tool_quote_message): Fix the allocation here
(again) and put a comment explaining it. (Fixes a crash when
replying.)
2000-11-28 Dan Winship <danw@helixcode.com>
* component-factory.c (owner_set_cb): Wait until after setting up
the local storage to find the Drafts/Outbox/Sent folders.
* mail-ops.c (do_setup_folder): Use the file: store rather than
mbox:.
2000-11-28 Jeffrey Stedfast <fejj@helixcode.com>
* folder-browser-factory.c: Added the SaveAs bonobo menu verb
thingy.
* mail-callbacks.c (save_msg): New callback for saving messages.
(save_msg_ok):
* folder-browser.c (on_right_click): Add a Save Ass menu item.
* mail-ops.c (cleanup_save_messages): Save all emails to the path
given.
2000-11-28 Dan Winship <danw@helixcode.com>
* mail-local.c (cleanup_register_folder): Fix the initial unread
counts after the last patch.
2000-11-27 Dan Winship <danw@helixcode.com>
* mail-local.c (local_folder_changed): This needs to run from the
main thread, not the camel thread, so add a proxy signal handler
to call mail_op_forward_event. Fixes hangs (eg bugzilla #909).
2000-11-27 Jeffrey Stedfast <fejj@helixcode.com>
* mail-display.c: Removed some unecessary debugging printf's
2000-11-27 Dan Winship <danw@helixcode.com>
* mail-config-druid.glade: Revert the new druid for now, until the
corresponding code is done, so that the druid will work again.
2000-11-21 Iain Holmes <iain@helixcode.com>
* mail-config-gui.c (mail_config): Don't use the "delete-event"
signal.
2000-11-21 Iain Holmes <iain@helixcode.com>
* mail-display.c (pixbuf_for_mime_type): free fm_icon.
* component-factory (summary_fn): Remove the configure param.
(factory_destroy): Made into a generic function so that the
summary_factory can be ref-counted as well as the normal
factory.
2000-11-21 Dan Winship <danw@helixcode.com>
* Makefile.am: add GPGME_CFLAGS and GPGME_LIBS
2000-11-21 Jeffrey Stedfast <fejj@helixcode.com>
* mail-config.c (mail_config_view_source): New function to return
if user wants to view message source.
(mail_config_set_view_source): New function to set whether the
view wants to view source.
* mail-ops.c (mail_do_view_message_sources): Removed. We're not
gonna view-source this way anymore.
* folder-browser-factory.c: Removed the ViewSource bonobo verb
from the Message menu.
(control_activate): Added ViewSource.
* folder-browser.c (on_right_click): Removed Message menu item to
view message source.
(folder_browser_toggle_view_source): New callback to set whether
or not the MailDisplay shows the raw message or the pretty-ified
message.
* mail-callbacks.c: Removed view_source.
* mail-display.c (redisplay): If toggle_raw is set then display
the raw message else display the pretty formatted message.
(mail_display_redisplay): New function to force the redisplay of a
message.
* mail-format.c (mail_format_raw_message): New function to
write the raw message data.
2000-11-21 Not Zed <NotZed@HelixCode.com>
* mail-vfolder.c (vfolder_uri_to_folder): IF we dont find a
source, clear the exception and ignore it silently. for e.g. if
the user reconfigured their mailboxes and one of them no longer
exists.
2000-11-21 Radek Doulik <rodo@helixcode.com>
* mail-display.c: #include <gtkhtml/gtkhtml-embedded.h>
2000-11-21 Not Zed <NotZed@HelixCode.com>
* message-thread.[ch]: Removed. No longer serves a purpose.
* Makefile.am (evolution_mail_SOURCES): Removed message-thread.[ch].
* message-list.c (build_subtree):
(node_equal):
(add_node_diff):
(build_subtree_diff):
(do_regenerate_messagelist):
(cleanup_regenerate_messagelist): Changed to use camel-folder-thread.
(message_list_set_folder): If we get set a new folder, unhook any
events before unrefing the folder too (the folder is never reset
currently, but this would cause problems).
(subtree_unread): Check for uid null, wont crash, but its a bug.
(ml_tree_value_at): If the uid is null, then fake an obviously bad
line.
(build_subtree): Yeah well, we can't like freeze/thaw here,
because this is called recursive, and freeze/thaw isn't
recursive, like pre model and post model change was.
(build_tree): Maybe we can try it here, although i dont think
it'll help much.
(build_flat): And this is also a tree. yes a tree.
(build_tree): Added changes arg. If set, then try the 'diff'
approach, unless the tree is already empty.
(message_list_set_threaded): Dont clear the tree here.
(message_list_set_search): Or here.
2000-11-20 Not Zed <NotZed@HelixCode.com>
* message-list.c (save_node_state): Save out the md5 hash of the
messageid as hex, since thats all we have for those nodes.
(build_subtree): Expand the messageid to a hex string first, then
check it.
(add_node_diff): And the same here.
* message-thread.c (thread_messages): Changed for changes to
messageid/references items.
(id_hash, id_equal): New functions to hash on the binary message id hash.
(thread_messages): removed some more no longer used dead code.
2000-11-20 Jeffrey Stedfast <fejj@helixcode.com>
* message-list.c (e_mail_address_compare): New comparison function
that will replace address_compare if/when we ever go to save the
preparsed addresses in the ETable rather than parsing them each
time. Also fixed it so that we should get better sorting when
addresses don't contain name parts (I was checking for NULL but
not '\0').
(address_compare): Use e_mail_address_compare.
2000-11-19 Peter Williams <peterw@helixcode.com>
* mail-ops.c (update_changed_folders): Instead of making the CORBA
call in the dispatch thread, store the new display names and have
cleanup_fetch_mail make the CORBA calls. Fixes deadlocks.
(cleanup_fech_mail): Loop through the update_infos and make the
CORBA calls.
(setup_fetch_mail): Clear some new data items.
2000-11-17 Jeffrey Stedfast <fejj@helixcode.com>
* mail-format.c (mail_generate_reply): Use the new quote_message
function and make it start with "On %s, %s wrote:" since people
seem to want that.
* mail-ops.c (cleanup_forward_messages): Use the new quote_message
function.
* mail-tools.c (mail_tool_quote_message): New convenience function
to quote a message body (since both the reply and forward code do
similar quoting)
2000-11-17 Not Zed <NotZed@HelixCode.com>
* message-list.c (message_list_destroy): Before we destroy
ourselves, unhook ourselves from the folder update events. Should
fix a common crash on exit case.
2000-11-16 Jeffrey Stedfast <fejj@helixcode.com>
* folder-browser-factory.c: Added the MessageViewSource bonobo
menu verb.
* mail-ops.c (mail_do_save_messages): New async function to save
messages as individual files in a given path.
2000-11-15 Jeffrey Stedfast <fejj@helixcode.com>
* folder-browser-factory.c: Added a new Forward as Attachment
bonobo menu item verb.
* mail-view.c (view_forward_msg): Updated to reflect changes to
mail_do_forward_message(). It now forwards the message without
attaching it - is this what we want?
* mail-ops.c (mail_do_view_message_sources): New async function to
display message source dialog windows.
(setup_forward_messages): If we were asked not to forward the
message(s) as attachment(s) and the user chose more than a single
message, then default to making each message an attachment.
(cleanup_forward_messages): If we aren't forwarding the message as
an attachment, then quote the text and set the composer's body
with it.
* mail-callbacks.c (view_source): New callback to view the message
source of all messages that are currently selected.
(forward_attach): New callback to forward a message as an
attachment (forward_msg is now for forwarding a message without it
being an attachment).
(forward_message): Convenience function for forwarding messages.
2000-11-13 Jeffrey Stedfast <fejj@helixcode.com>
* subscribe-dialog.c (subscribe_do_subscribe_folder): Take a
'subscribe' argument so that this can function as a subscribe AND
unsibscribe method.
(describe_subscribe_folder): Updated.
(do_subscribe_folder): Updated.
(cleanup_subscribe_folder): Updated.
(subscribe_folder_info): Pass along a TRUE as the 'subscribe'
param.
(unsubscribe_folder_info): Pass along a FALSE as the 'subscribe'
param.
2000-11-13 Christopher James Lahey <clahey@helixcode.com>
* message-list.c: Removed some e_table_model calls and replaced
them with e_tree_model calls.
2000-11-12 Dan Winship <danw@helixcode.com>
* mail-local.c (mail_do_register_folder): Do this the normal way
rather than calling mail_operation_wait_for_finish. There was some
reason for it originally, but it no longer applies. This makes
adding new folders from the folder selection dialog no longer
hang.
2000-11-12 Jeffrey Stedfast <fejj@helixcode.com>
* mail-ops.c (do_filter_ondemand): Sync the source folder.
2000-11-11 Matt Bissiri <bissiri@eecs.umich.edu>
* evolution-mail.oafinfo:
* mail-threads.c: (retrieve_shell_view_interface_from_control):
Update the remaining "IDL:Evolution*" to "IDL:GNOME/Evolution*"
to sync up with yesterday's IDL re-scoping.
2000-11-10 Michael Meeks <michael@helixcode.com>
* Makefile.am ($(EVOLUTION_MAIL_CORBA_GENERATED)): sort include order.
2000-11-09 Jeffrey Stedfast <fejj@helixcode.com>
* subscribe-dialog.glade[.h]: New glade file for possibly using to
create the subscribe dialog.
2000-11-08 Radek Doulik <rodo@helixcode.com>
* mail-format.c (mail_generate_reply): likewise
* mail-callbacks.c (create_msg_composer): added send_html arg to
e_msg_composer_new_with_sig_file call
2000-11-07 Jeffrey Stedfast <fejj@helixcode.com>
* mail-search-dialogue.c (mail_search_dialogue_construct): Allow
rule part to expand when the user resizes the dialog.
2000-11-07 Jeffrey Stedfast <fejj@helixcode.com>
* folder-browser.c (search_save): Don't handle custom searching
anymore... we don't want this.
(search_full): Same.
(folder_browser_search_menu_activated): Set the search entry
widget sensitive.
(folder_browser_search_query_changed): Same.
2000-11-07 Jeffrey Stedfast <fejj@helixcode.com>
* folder-browser.c (search_full_clicked): Updated to use the
ESearchBar object rather than the previously used search widgets.
(search_full): Same.
(search_save): Same. Also use enums to make it a little easier to
read now that we have to have enums anyway.
(folder_browser_search_menu_activated): New ESearchBar menu
callback.
(folder_browser_search_query_changed): New ESearchBar query
callback. Replaces search_set()
(folder_browser_clear_search): Updated to use the ESearchBar
object rather than the previously used search widgets.
(folder_browser_gui_init): Don't hand construct a search widget,
use the new ESearchBar convenience widget.
* mail-ops.c (cleanup_load_folder): Updated to reflect changes to
FolderBrowser.
2000-11-07 Jesse Pavel <jpavel@helixcode.com>
* mail-display.c (pixmap_press): modified some of the EPopupMenu
structures to account for differences in the popup menu API (as
informed by Jeff.
(on_object_requested): passed the user's default email address
to the iTip control.
2000-11-07 Ettore Perazzoli <ettore@helixcode.com>
* Makefile.am (INCLUDES): Add the composer dirs.
2000-11-07 Not Zed <NotZed@HelixCode.com>
* mail-display.c (on_object_requested): God, I sure wish people
would listen when i'm saying i'm changing and API. I mean
I even mailed everyone and everything. Can't see any changelog
either.
2000-11-06 Not Zed <NotZed@HelixCode.com>
* mail-autofilter.c (rule_from_message): Updates for api changes.
* mail-tools.c (mail_tool_generate_forward_subject): Fixed for api
changes. Sigh, whoever wrote the multithread code of the mailer,
had little idea. You can't just lock for getting a const value,
until you are finished with it, cause the owner still owns it.
Fixed this too. Yuck, what a horrid forwarding format, can we
change this, or make it configurable? The mail headers show who
forwarded it, we dont need to duplicate it in that UGLY subject.
* mail-format.c (write_field_to_stream): Removed some jeffness.
dont g_strdup stuff we dont need to, and remove the
value_is_encoded thing since we can get the unencoded address
now.
(write_address): New function to write an address field.
(write_headers): Uses write_address to write addresses, cleaner,
fixed the god-awful unreadable indenting too.
(handle_text_plain): Use a 'smarter' printf format, so we dont
need to allocate and copy substrings unecessarily (esp since
they're about to be allocated any copied another few times
anyway *sigh*).
(write_field_to_stream): Commented out the isprint check, which
afaik serves no purpose.
(list_add_addresses): New function to build a list of
display-ready addresses. Although I think the composer then uses
these as internet-ready addresses. It should probably take a list
of CamelAddress's if thats what it wants.
(mail_generate_reply): Cleaned up the address list creation stuff
a heap, and fixes for camel api changes. Also fixed a small
memory leak as a side effect (fulladdr wasn't freed if it was the
same as the sender).
* mail-display.c (on_object_requested): Changed for interface
changes to the from address. I think passing the encoded
(internet version) of the address is right here.
2000-11-06 Jeffrey Stedfast <fejj@helixcode.com>
* folder-browser.c (on_right_click): Move filter stuff into a
submenu of the popup menu.
2000-11-06 Jesse Pavel <jpavel@helixcode.com>
* mail-display.c: used Camel to parse the full address before
passing the email address to my iTip control.
2000-11-06 Dan Winship <danw@helixcode.com>
First draft of folder tree unread message indication for /local
mail folders.
* mail-local.c: Add a new CamelStore subclass, MailLocalStore,
which attaches to an Evolution_LocalStorage on one side and
CamelSession on the other, and keeps track of local folders. Some
of this code was previously in mail-local-storage.c, which no
longer exists.
(local_reconfigure_folder, etc): Various mail_op-related cleanups,
and wrap d() around a bunch of printfs.
* mail-tools.c (mail_tool_get_local_inbox_url,
mail_tool_get_local_movemail_url): Removed
(mail_tool_get_local_inbox): Simplified.
(mail_tool_do_movemail): Remove unused dest_url variable.
(mail_tool_uri_to_folder): Simplify. Now down to two cases
(vfolder, and everything else).
* component-factory.c (owner_set_cb): Pass evolution_dir to
mail_local_storage_startup.
* Makefile.am (evolution_mail_SOURCES): Remove
mail-local-storage.[ch]
* mail-summary.c: Remove mail-local-storage.h include
2000-11-06 Kjartan Maraas <kmaraas@gnome.org>
* mail-autofilter.c: Fix up #include <config.h>
* mail-crypto.c: Same here.
* mail-search-dialog.c: Here too.
* main.c: Fix indentation of #ifdef
* message-thread.c: Fix include.
2000-11-06 Jeffrey Stedfast <fejj@helixcode.com>
* mail-callbacks.c (delete_msg): Don't invert the flag.
(undelete_msg): Same (when multiple messages are selected).
2000-11-06 Jeffrey Stedfast <fejj@helixcode.com>
* folder-browser-factory.c: Updated to have the same menu items as
the new right-click menu - eventually these 2 menus should be the
same.
* folder-browser.c (on_right_click): Now correctly handles the
case of multiple selection.
* mail-callbacks.c (enumerate_msg): Make public so it can be used
in other source files (it's a useful function!)
2000-11-05 Jeffrey Stedfast <fejj@helixcode.com>
* folder-browser.c (on_right_click): Added an "Undelete" option to
the right-click menu and also set a mask so it was only selectable
if the message is marked as deleted. Also set a mask for "Mark as
Read" and "Mark as Unread".
* mail-callbacks.c (undelete_msg): New callback to undelete
messages.
2000-11-03 Dan Winship <danw@helixcode.com>
* message-list.c (cleanup_regenerate_messagelist): don't free the
MessageList search when it's being reused
2000-11-03 Jeffrey Stedfast <fejj@helixcode.com>
* mail-local.c (mail_local_map_uri): Don't show the passwd in the
url string.
(mail_tool_local_uri_to_folder): Same.
(do_reconfigure_folder): Same.
2000-11-03 Jeffrey Stedfast <fejj@helixcode.com>
* Makefile.am: Added new header files.
* component-factory.c (owner_set_cb):
s/session_init/mail_session_init
* session.c: Renamed public functions to mail_session_*.
FIXME: Rename session.c to mail-session.c
* folder-browser-factory.c: #include "mail-callbacks.h", #include
"mail-session.h" and replace forget_passwords with
mail_session_forget_passwords
* mail.h: Move session prototypes to mail-session.h, Move
mail-crypto prototypes to mail-crypto.h, Move mail-callback
prototypes to mail-callbacks.h
* mail-session.h: New header file containing public prototypes
for session.c
* mail-format.c: #include "mail-crypto.h"
* mail-view.c:
* folder-browser.c: #include "mail-callbacks.h"
* mail-crypto.h: New header file containing public prototypes
for mail-crypto.c
* mail-callbacks.h: New header file containing public prototypes
for mail-callbacks.c
* message-list.c (message_list_get_layout): Set useful defaults.
(message_list_setup_etable): Don't set the Outbox defaults on a
folder just because it doesn't have a corresponding saved file.
2000-11-03 Dan Winship <danw@helixcode.com>
* mail-config-gui.c (service_page_item_new): url_flags are now on
CamelProvider, not CamelService
* main.c:
* subscribe-dialog.c:
* mail-threads.c: Kill warnings
2000-11-03 Federico Mena Quintero <federico@helixcode.com>
* Makefile.am: Clean the idl-generated files properly.
2000-11-03 Not Zed <NotZed@HelixCode.com>
* mail-view.c: Added mail-display.h.
* mail-autofilter.c: Removed unecessary headers. Who ran indent
over this code? Sigh.
* mail-ops.c (display_message_input_s): Added messagedisplay.
(mail_do_display_message): Added messagedisplay arg.
(mail_do_display_message): Dont bother doing another thread when
we know we dont have a uid.
(): Added folder-browser.h to headers. Sigh.
* folder-browser-factory.c (control_activate): Setup the
viewthreaded callback to the folder_browser function.
* folder-browser.c (my_folder_browser_init): Connect to
right_click of etable of the messagelist here.
(on_right_click): Changed for argument changes.
(folder_browser_toggle_threads): Changed to take a fb, and to set
threaded mode on the messagelist.
(my_folder_browser_init): Connect also to the double_click signal.
(my_folder_browser_init): Connect to the message_selected signal
of the message_list.
(on_message_selected): Signal handler for message selected.
(my_folder_browser_init): Fix for change to message_list_new().
* message-list.h: Dont include folder-browser.h.
(message_list_toggle_threads): Moved into folder-browser.h.
(struct _MessageList): Removed folderbrowser.
* mail.h: Dont include folder-browser.h here either, but
mail-types.h instead.
Moved prototypes moved into folder-browser.c into
folder-browser.h. (vfolder_*, filter_*).
* mail-display.h: Dont include folder-browser.h here, but
mail-types.h and specific camel headers.
* message-thread.c (sort_node): Invert the sort order logic so the
list is sorted in mailbox order, not reverse mailbox order.
* message-list.c (free_tree_ids): Fix a merge foo.
(remove_node_diff): Removed unused row argument. Fixed
callers/prototype.
(clear_tree): pre_change on the removal of the root node.
(build_flat): Only perform pre_change if we are rebuilding the
whole lot. For incremental change let etable do its thing.
(build_tree): Likewise for building the tree view. If making
incremental updates, do them as we build it.
(vfolder_subject):
(vfolder_sender):
(vfolder_recipient):
(filter_subject):
(filter_sender):
(filter_recipient):
(filter_mlist):
(on_right_click): Moved to folder-browser.c, where they belong.
(message_list_init): Dont connect to right_click anymore.
(message_list_toggle_threads): Moved to folder-browser.c, renamed.
(on_double_click): Moved to folder-browser.c
(on_click): Set the flags directly, rather than in anothre thread,
which is just not necessary.
(message_list_class_init): Added a new signal 'message_selected',
to indicate when a message was selected.
(on_cursor_change_idle): Emit a signal, rather than directly
triggering the display update.
(select_row): Removed, no longer used.
(idle_select_row): And this too.
(select_msg): Removed as well.
(message_list_select): Emit a signal, rather
thandisplaying/clearing the mail-display directly.
(mark_msg_seen): Moved to folder-browser.c
(message_list_new): Removed folderbrowser argument.
2000-11-02 Jeffrey Stedfast <fejj@helixcode.com>
* message-list.c (on_right_click): Sync with message
menu. Addresses bugzilla bug #778.
2000-11-02 Christopher James Lahey <clahey@helixcode.com>
* message-list.c: Turn on draw grid for the main ETable (this may
not be working in ETable itself.)
2000-11-01 Jeffrey Stedfast <fejj@helixcode.com>
* mail-threads.c (mail_op_set_message): fmt argument should be
const.
2000-11-01 Dan Winship <danw@helixcode.com>
Make "Get Mail" even more functional on IMAP (scans all folders),
and do a first cut at folder tree highlighting (for IMAP/news
only).
* mail-ops.c (do_fetch_mail): For imap (sigh, we *still* shouldn't
be hardcoding that), rescan the store's folder tree, rescan each
changed folder for new messages, and update the shell folder tree.
(do_scan_subfolders): Update for component-factory.c changes, and
set folder display names and highlights appropriately when
building the storage.
* component-factory.c (add_storage): Make this static (was
mail_add_new_storage). Use camel_service_get_name for the name
rather than url->host. (Among other things, this lets you use a
single machine as both an IMAP server and a news server.)
(mail_lookup_storage): Hash storages based on their CamelStore
rather than the URL.
(factory_destroy): Disconnect each of the CamelStores in the
storages_hash.
* subscribe-dialog.c (cleanup_subscribe_folder):
* mail-vfolder.c (vfolder_refresh): Pass "highlighted" flag to
evolution_storage_new_folder
2000-11-01 Jeffrey Stedfast <fejj@helixcode.com>
* mail-ops.c (mail_op_report_status): Don't call the default
logging function.
(do_fetch_mail): Set the logfile and don't pass the logfile to
filter_driver_set_status_func - it's purpose has been altered.
(do_filter_ondemand): Same.
2000-11-02 Not Zed <NotZed@HelixCode.com>
** Merged in camel-incremental-branch.
* mail-format.c (mail_get_message_body): Jeff! Sigh.
We should definetly not be strduping the
content, it has already been copied and duplicated. Look at
get_data_wrapper_text.
2000-11-01 Chris Toshok <toshok@helixcode.com>
* subscribe-dialog.h: add fields search_entry and search_top.
* subscribe-dialog.c: add mail-ops.c style async operations for
getting the store (to remove deadlock in the case where a auth
dialog is dismissed at startup and then the subscribe dialog is
brought up), and subscribing/unsubscribing to folders. One case
remains, that is getting the list of all folders.
(subscribe_search): flesh out this function
(build_tree): use the search_top field so we can search for
groups/folders.
(subscribe_dialog_destroy): free search_top.
(subscribe_dialog_construct): init search_top.
2000-10-30 Iain Holmes <iain@helixcode.com>
* mail-summary.c (generate_folder_summaries): Fix spelling :)
Set folder->uri to NULL for the Inbox.
2000-10-26 Iain Holmes <iain@helixcode.com>
* mail-summary.c (generate_html_summary): Add view:// uris to
switch the display to that folder.
2000-11-01 Jeffrey Stedfast <fejj@helixcode.com>
* folder-browser-factory.c: Hmmm, someone can't spell Filder,
er...I mean Filter ;-)
2000-11-01 Jeffrey Stedfast <fejj@helixcode.com>
* mail-autofilter.c (rule_from_message): If the name is NULL or
empty, then set the title to "Mail from <address>". Closes
bugzilla bug #777. Also when filtering on Subject, set the file
name to "Subject is <subject>" rather than just "<subject>" - I
think this is a bit more user-friendly.
(strip_re): Use unsigned char when passing to is<type>()
functions from ctype.h.
(rule_add_subject): Use the "is" rule instead of "contains".
2000-11-01 Jesse Pavel <jpavel@helixcode.com>
* mail-display.c: added property bag support for Bonobo
controls, support which helps only the iTip control, currently.
2000-11-01 Dan Winship <danw@helixcode.com>
* mail-display.c (pixbuf_gen_idle): Lots of fixes and
simplifications. Should get rid of the "missing icon" problem.
There is still a problem with some images failing to get
thumbnails, even though they display correctly.
(pixbuf_for_mime_type): New function to try really hard to get the
right icon for a MIME type, including looking in mc and nautilus's
pixmap directories.
(on_object_requested): Always use pixbuf_gen_idle, even for
non-image types, to prevent code duplication.
2000-10-31 Jeffrey Stedfast <fejj@helixcode.com>
* mail-format.c (mail_get_message_body): Shouldn't we be
strdup'ing the content? This seems to fix the memory corruption
problems.
(mail_generate_reply): Make sure that the last char in the
generated reply text is '\0' (when body text doesn't end with a
\n, a random char will appear otherwise).
2000-10-31 Dan Winship <danw@helixcode.com>
* mail-config-gui.c (do_test_service): Update for
camel_service_disconnect change.
2000-10-31 Jeffrey Stedfast <fejj@helixcode.com>
* mail-autofilter.c (filter_gui_add_for_mailing_list): Match "is"
rather than "contains" now that we have the "is"-rule.
2000-10-30 Dan Winship <danw@helixcode.com>
* mail-config-gui.c (config_do_query_authtypes): Redo this so that
it works for all pages, not just the first page. (Now that this is
finally working again, I expect Anna to finish her redesign in the
next 15 minutes.)
(service_page_item_new): Fix up the sizing of the Auth line to
look more like everything else.
2000-10-29 Dan Winship <danw@helixcode.com>
* mail-tools.c (mail_tool_uri_to_folder): Simplify this a lot by
making IMAP and NNTP use the same code, now that the IMAP
namespace doesn't need special magic handling.
* message-list.c (mail_do_regenerate_messagelist): Don't try to
regenerate the message list if there is no folder. (The Bonobo UI
code will call this as the callback for the "Threaded View"
command.)
* mail-ops.c (do_fetch_mail): Sync the folder before refreshing so
we don't lose flag settings.
2000-10-27 Jeffrey Stedfast <fejj@helixcode.com>
* mail-callbacks.c (composer_send_cb): Check to make sure that the
recipient list is neither NULL nor a 0-length list of addresses
and pop up a dialog letting the user know why we are not allowing
him/her to send the message.
2000-10-26 Dan Winship <danw@helixcode.com>
* mail-display.c (write_data_to_file): Don't destroy a dialog
after run_and_close'ing it.
2000-10-26 Jeffrey Stedfast <fejj@helixcode.com>
* mail-callbacks.c (composer_send_cb): Check for the TO recipient
list being NULL and don't send.
2000-10-25 Jeffrey Stedfast <fejj@helixcode.com>
* mail-ops.c (do_send_mail): Don't forget to unref the
FilterDriver.
* mail-callbacks.c (apply_filters): New callback for applying
on-demand filters. (removed the old on-demand filters callback).
* mail-ops.c (do_filter_ondemand): Rewrote to apply "incoming"
filters to all selected messages.
(mail_do_filter_ondemand): No longer takes a FilterContext
argument or a destination folder argument (why did we ever need
this last one??) but now takes a uids argument.
* folder-browser-factory.c: Add a MessageApplyFilters menu item.
2000-10-25 Iain Holmes <iain@helixcode.com>
* mail-summary.[ch]: Updated for the new ExecutiveSummary code.
* Makefile.am: Added the summary files and the evolution-services CFLAGS
and LIB stuff.
* component-factory.c: Re-enabled the summary stuff.
2000-10-25 Dan Winship <danw@helixcode.com>
* main.c (main): Pass send/postpone signal handler functions to
evolution_composer_factory_init.
2000-10-25 Jeffrey Stedfast <fejj@helixcode.com>
* subscribe-dialog.c (subscribe_select_all): Implemented.
(subscribe_invert_selection): (was unselect_all) Implemented.
2000-10-25 Dan Winship <danw@helixcode.com>
* message-list.c: Add a "flagged" column, based on the Camel
"flagged" flag, for assigning an arbitrary "hey, I care about
this" flag to a message.
(ml_tree_set_value_at): Remove
(ml_tree_is_cell_editable): No, it's not.
(on_click): Handle the read/unread and flagged fields via the
click handler. Among other things, this makes it not select
a message when you change its read status.
2000-10-24 Dan Winship <danw@helixcode.com>
* subscribe-dialog.c (folder_info_subscribed,
subscribe_folder_info, unsubscribe_folder_info): Don't prepend "/"
to the folder's full_name. Deal with hierarchy in the
EvolutionStorage tree better.
(storage_tree_path): Helper function to build a storage path from
a CamelFolderInfo.
2000-10-23 Dan Winship <danw@helixcode.com>
* *: Add some missing _()s and N_()s.
2000-10-23 Dan Winship <danw@helixcode.com>
* Makefile.am (INCLUDES): Update EVOLUTION_LOCALEDIR.
2000-10-23 Jeffrey Stedfast <fejj@helixcode.com>
* mail-ops.c (do_send_mail): Apply outgoing filters to the
message.
2000-10-23 Christopher James Lahey <clahey@helixcode.com>
* message-list.c: Fixed a possible error in row numberings. This
needs to be changed quite a bit anyway, but this should make
things slightly nicer in some cases.
2000-10-23 Christopher James Lahey <clahey@helixcode.com>
* folder-browser.c: Made the top of the folder browser a little
prettier.
* mail-display.c, mail-vfolder.c: Made more dialogs resizable.
2000-10-23 Jeffrey Stedfast <fejj@helixcode.com>
* mail-autofilter.c (filter_gui_add_from_message): Don't forget to
set the rule source! (eg "incoming", "demand", or "outgoing")
2000-10-22 Ettore Perazzoli <ettore@helixcode.com>
* message-list.c (message_list_init): Always display the vertical
scrollbar.
* mail-display.c (mail_display_new): Always display the vertical
scrollbar.
2000-10-20 Jeffrey Stedfast <fejj@helixcode.com>
* mail-config.h: #include <camel/camel-folder.h>
2000-10-20 Michael Meeks <michael@helixcode.com>
* mail.h: s/BonoboUIHandler/BonoboUIComponent/
* mail-callbacks.c (run_filter_ondemand): ditto.
* session.c (forget_passwords): ditto.
2000-10-20 Dan Winship <danw@helixcode.com>
* evolution-mail.oafinfo: Declare composer factory.
* main.c (main): Initialize it
2000-10-19 Chris Toshok <toshok@helixcode.com>
* message-list.c (nuke_uids): e-tree-model is now opaque. use the
accessor to get the root node.
2000-10-19 Jeffrey Stedfast <fejj@helixcode.com>
* mail-callbacks.c: #include "mail-vfolder.h"
(vfolder_edit_vfolders): Don't call the dummy vfolder_edit
function.
* folder-browser-factory.c: s/VFolderEdit/SetVFolder
2000-10-19 Dan Winship <danw@helixcode.com>
* mail-ops.c: (do_fetch_mail): For an imap store, just refresh the
INBOX.
* folder-browser-factory.c (control_deactivate): Don't sync
non-existent folders.
* message-list.c (nuke_uids): Don't traverse non-existent trees.
2000-10-19 Ettore Perazzoli <ettore@helixcode.com>
* Makefile.am (glade_messages): New.
(EXTRA_DIST): Add `$(glade_messages)'.
2000-10-19 Dan Winship <danw@helixcode.com>
* mail-ops.c: Clean up some old #if 0 code.
2000-10-19 Jeffrey Stedfast <fejj@helixcode.com>
* mail-format.c (mail_generate_reply): Get the MailConfigIdentity
*before* we create a new composer object so that we can set the
signature file.
2000-10-18 Michael Meeks <michael@helixcode.com>
* folder-browser-factory.c (register_ondemand): kill.
(create_ondemand_hooks): die.
(control_activate): remove hook.
* test-mail.c (create_container): kill old UI handler.
2000-10-18 Christopher James Lahey <clahey@helixcode.com>
* message-list.c: Fixed some column widths.
2000-11-02 Not Zed <NotZed@HelixCode.com>
* message-list.c (get_message_info): Call get_message_uid to get
the uid, save some duplicated code.
(folder_changed): Handle the case of a NULL changes input.
* message-thread.c (thread_messages): Removed pointless
variable/assignment 'container'.
(thread_messages): Try and cope with duplicate message id's.
2000-11-01 Not Zed <NotZed@HelixCode.com>
* mail-callbacks.c (main_select_first_unread): Changed to use 0 as
the first row to select a message.
* mail-ops.h (mail_do_regenerate_messagelist): Removed from
header. This function is no longer public since it is really an
internal message-list function.
* folder-browser.c (search_full_clicked): Call the set_search()
function, rather than messagelist_rebuild, which is going private.
(search_set): Same here.
(folder_browser_clear_search): And here.
(etable_key): Call message_list_select() instead of
message_list_home and message_list_end. Removing some odd code
duplication.
* message-thread.c (do_thread_messages): Moved the mail lock to
here, rather than locking for each message lookup (which is
useless anyway). This is still not correct either, as the tree
references folder data ... but a bit better than it was.
(thread_messages): Removed the mail tool lock stuff, lock in
higher functions.
* message-list.h: Added a threaded indicator to the message list
itself.
(threaded_view): removed a mystery variable.
* message-list.c (do_regenerate_messagelist): Made the code a
little more readable.
(build_tree): Fixed argument to be a thread_messages struct, not a
container.
(cleanup_regenerate_messagelist): Free changeinfo.
(mail_do_regenerate_messagelist): If we are adding changes to a
flat view, we dont need to goto the other thread at all, so
process immediately.
(message_list_toggle_threads): Clear the tree if we're changing
the view mode.
(message_list_toggle_threads): And reset the rowmap, since it is no
longer valid.
(build_tree): If we are building into an already empty tree, just
build into that (probably irrelevant optimisation).
(build_subtree): Build hte subtree in the same order as we got it,
not inverted order.
(message_list_set_threaded): New function to select the threaded
view/flat view.
(mail_do_regenerate_messagelist): Removed references to
mail_config, get it from the ml->threaded var instead.
(message_list_destroy): No longer free the key data for the
uid_rowmap.
(new_id_from_uid): Convert a uid string into an id string.
(new_id_from_subject): Likewise for subject strings.
'id' strings replace the 'uid:' and 'subject:' stuff with
accessors and macros and use less memory and is more readable.
(id_is_uid): macro to check if an id string is a uid.
(id_uid): Returns the uid part of a uid id string.
(id_subject): Returns the uid part of a subject id string.
(build_subtree): Use the new id functions, and dont duplicate the
uid in the uid rowmap, but just reference it from the tree node.
(node_equal): Use new id functions.
(add_node_diff): And here too.
(remove_node_diff): And here. Also remove the uid from the
rowmap, and dont free it anymore.
(get_message_info): And here.
(get_message_uid): And here.
(subtree_unread): And here.
(ml_tree_value_at): "
(ml_tree_set_value_at): Noted a memory leak. do_flag_messages()
doesn't free the contents of the uid array, just the uid array
(well that i can tell, teh code has more problems anyway).
(ml_tree_set_value_at): And fix the id accessors.
(save_node_state): "
(build_flat): Use id macros/functions. Dont alloc memory for hash
key.
(build_flat_diff): Use id macros.
(build_flat_diff): Remove the hash table entry before freeing its
key data (in the node).
(free_key): Removed. Keys are no longer alloc'd.
(clear_tree): When we clear the tree, also clear the uid_rowmap,
as it is no longer valid (or contains allocated keys!).
(free_tree_ids): Renamed from nuke_uids.
(free_ids_cb): Renamed from nuke_uids_cb.
(free_tree_ids): Changed arg to be a ETreeModel directly.
(ml_tree_value_at): Map id to subject using the right macro.
(free_tree_ids): Check we have any nodes to traverse first.
(build_flat): Insert to row -1 to append the nodes (faster).
(remove_node_diff): Only remove the uid rowmap entry if it is
referencing this node (i.e. the key string is the same key string,
not just a matching key string).
(add_node_diff): Remove the uid rowmap entry before inserting a
new one to force the key to be replaced. This is required as the
tree may temporarily contain duplicate messages during the
rebuilding phase.
(message_list_set_search): New function, set the search string.
Only redo the search if it has changed, etc.
(mail_do_regenerate_messagelist): Made static. There is no need
for external code to call this.
(message_list_set_folder): NOP if the new folder is the same.
(message_list_set_folder): Clear the tree before rebuilding it.
(message_list_select): Ok, this wins the award for 'most bizarre
interface'. Changed the start row to mean the end of the list if
we supply -1, rather than the start of the list. Also fixed the
endpoints (it would never select message 0 if searching
backwards).
(idle_select_row): Changed start row to 0 from -1.
(message_list_end): Removed.
(message_list_home): Removed.
(go_to_message): Removed. message_list_select can do this.
(message_list_select): Check that direction is one of the valid
ones, otherwise we could be thrown for loops.
2000-10-31 Not Zed <NotZed@HelixCode.com>
* message-list.c (node_equal): Compares an etree node with a
message-thread node to see if they point to the same object.
(add_node_diff): Adds a new thread node to the etree.
(remove_node_diff): Removed an etree node, freeing any additional
data.
(build_subtree_diff): Takes an existing etree definition, and a
new thread definition and makes the etree match, using as few
operations as possible.
(do_regenerate_messagelist): No longer free/clear the uid/rowmap
here.
(regenerate_messagelist_input_t): Added a tree field - are we
building a tree view?
(regnerate_messagelist_data_t): Added a tree field, if we built a
tree result. Added a changes parameter, for building diff's after
search/etc.
(mail_do_regenerate_messagelist): Setup the tree indicator.
(build_flat_diff): Apply a changeset to a message list.
(build_flat): Added a changes argument, if present, use
build_flat_diff() to build the list.
(do_regenerate_messagelist): If we are generating a threaded view,
build the threaded list here, rather in another separate
invocation.
(cleanup_regenerate_messagelist): Call build_tree directly on the
threaded list.
(message_list_init): Init the uid_rowmap hash table here instead
of somewhere odd.
(message_list_destroy): Assume uid_rowmap exists.
(do_regenerate_messagelist): Remove the code here that is messing
with the message list data (search/uid_rowmap). We're in a
different thread boys ...
2000-10-26 Not Zed <NotZed@HelixCode.com>
* message-list.c (cleanup_regenerate_messagelist): Fixed some
logic to make more sense (gboolean)!pointer replaced with
(pointer != NULL).
(build_tree): Put the tree pre/post change stuff in here, where it
should be.
(build_flat): Same here.
(cleanup_regenerate_messagelist): Remove model_changed stuff here.
(setup_regenerate_messagelist): Remove pre_change stuff here.
2000-10-20 Not Zed <NotZed@HelixCode.com>
* message-list.c (main_folder_changed): Perform incremental update
of the display for flat view.
(ml_tree_value_at): Spit out a mroe meaningful warning when we
can't find the uid in our tree, in the folder.
* message-thread.c (thread_messages): Made public.
(thread_messages_free): Made public.
(thread_messages): Now we also return a struct _thread_messages,
which is passed to other functions.
(container_free): Renamed from thread_messages_free.
(thread_messages_free): Take a thread_messages argument.
(thread_messages_add): New function to add a list of uid's to the
thread list.
(thread_messages_remove): Likewise, for removing them.
(cleanup_thread_messages): Change for struct changes.
(do_thread_messages): Likewise.
2000-10-19 Not Zed <NotZed@HelixCode.com>
* mail-tools.c (mail_tool_do_movemail): removed unused var
* folder-browser.c (search_full_clicked): Fix for api changes,
such as it can be called an api, its mroe an utter mess infact.
(search_set): Same.
(search_set): And here.
(folder_browser_clear_search): And here.
* message-list.c (folder_changed): Copy and forward the changeinfo
list to the mian thread.
(main_folder_changed): Free the changeinfo. Todo: something smart
with this information.
(struct regenerate_messagelist_input_s): Added a changes field.
(mail_do_regenerate_messagelist): Added a change list argument.
(message_list_set_folder): Fix for mail_do_regenreate_messagelist
api.
(message_list_toggle_threads): Same.
2000-10-18 Iain Holmes <iain@helixcode.com>
* mail-config-gui.c (mail_config): Make all the CLists have passive
titles.
(identity_dialog): Make the default button the "OK" button, and set
the dialog to close on pressing return on the entryboxes.
2000-10-17 Iain Holmes <iain@helixcode.com>
* mail-config-gui.c (service_page_item_new): Disable the optionmenu
because it is empty.
(service_page_item_auth_fill): Enable the optionmenu as there's stuff
in it now.
* mail-callbacks.c (reply_to_sender): Call check_send_configuration
when we have the FolderBrowser because if it is done in mail_reply
(with passing NULL) it will only be able to continue if the mailer
has already been configured.
(reply_to_all): Same.
2000-10-18 Not Zed <NotZed@HelixCode.com>
* folder-browser.c (folder_browser_gui_init): No, we REALLY dont
want to perform an immediate search as the keys are pressed.
* mail-display.c (on_object_requested): Kill a minor warning with
a cast.
* mail-config.c: Include mising ctype.h to kill a warning.
* message-thread.c (main): Fixed the test case for api changes.
* message-list.c (message_list_drag_data_get): Set some flags to
get_folder(). I dont even think this will work because
mail_tool_get_folder doesn't handle file url's.
* mail-vfolder.c (vfolder_uri_to_folder): Pass appropriate flags.
* mail-ops.c (do_setup_folder): Pass appropriate flags. Hmm,
whats the difference between setup and create. *shrug*
(do_create_folder): Pass appropriate flags to get_folder. Needs a
way to specify the index flag.
* mail-tools.c (mail_tool_get_folder_from_urlname): Changed create
to flags argument.
(mail_tool_get_local_inbox_url): Add an index argument.
(mail_tool_get_local_inbox): honour index flag.
(mail_tool_get_inbox): Changed for api change.
(mail_tool_uri_to_folder): Fixed calls to store_get_folder();
* mail-local.c (load_metainfo): Added an indexed field to the metainfo.
(save_metainfo): And save it too.
(do_reconfigure_folder): Honour index flag when creating the new
folder. Do not open the old folder with an index at all.
(mail_local_map_uri): Add an index argument - tells if the mbox is
indexed.
(mail_tool_local_uri_to_folder): Create & pass flags properly.
(#include gnome.h): Dont include all of gnome, just what we use,
and explicity include xml-memory, so we get xmlFree().
2000-10-16 Jeffrey Stedfast <fejj@helixcode.com>
* folder-browser.c (search_full_clicked): Un #if 0'd out
(search_full): Same.
(folder_browser_gui_init): Connect search_full and search_activate.
(search_set): Uncomment search_full()
* Makefile.am: Re-add `mail-search-dialogue.h' and
`mail-search-dialogue.c'.
2000-10-16 Jeffrey Stedfast <fejj@helixcode.com>
* mail-format.c (mail_generate_reply): Decode recipient names so
that they display nicely in the To and Cc fields.
(write_field_to_stream): Now takes another argument
'value_is_encoded' so that we know if we should decode that string
before proceding onward. Since the message subject is already
decoded before it's passed in, we don't want to decode it again
(wasted cpu time and/or any 8bit chars will be assumed to be
latin1 encoded and thus the decoded value will be corrupt).
2000-10-16 Chris Toshok <toshok@helixcode.com>
* mail-config-gui.c (service_page_get_url): only set the url->user
field if the user string is non-NULL and not empty.
2000-10-16 Not Zed <NotZed@HelixCode.com>
* message-list.c (message_list_setup_etable): Uh, fixed jeff's
wrong fix for setting the speficiation (the function changed to
set_state(), as can be seen in the e_table-scrolled_load_state()
call only 2 lines above).
2000-10-13 Not Zed <NotZed@HelixCode.com>
* message-list.c (message_list_setup_etable): oops, chose the
wrong thing to cut out after a merge conflict.
2000-10-15 Chris Toshok <toshok@helixcode.com>
* message-list.c (subtree_unread): ETreePath != GNode now, use
accessors.
(ml_tree_value_at): same.
(save_node_state): same.
(save_tree_state): same.
(nuke_uids_cb): convert to e_tree_model_node_traverse required
type.
(nuke_uids): g_node_traverse -> e_tree_model_node_traverse.
2000-10-14 Ettore Perazzoli <ettore@helixcode.com>
* evolution-mail.oafinfo: Add "evolution:shell-component-icon"
attribute.
2000-10-13 Jeffrey Stedfast <fejj@helixcode.com>
* message-list.c (message_list_setup_etable): Don't free the
service name.
2000-10-12 Jeffrey Stedfast <fejj@helixcode.com>
* mail-ops.c (do_fetch_mail): sync & expunge the source folder
after filtering.
2000-10-12 Jeffrey Stedfast <fejj@helixcode.com>
* message-list.c (message_list_setup_etable): Create the 'spec'
and 'extras' arguments and call e_table_scrolled_new() rather than
set_specification as that function no longer (?) exists.
Also started to add drag & drop functionality to something like
Nautilus (but #if 0'd it out until I had time to finish it and
till after 0.6).
2000-10-12 Not Zed <NotZed@HelixCode.com>
* message-list.c (message_list_setup_etable): Duh, fix the test
for the folder name, strstr != strcmp is it.
2000-10-10 Not Zed <NotZed@HelixCode.com>
* message-list.c (folder_to_cachename): Removed, changed callers
to use mail_config_folder_to_cachename instead.
* mail-config.c (mail_config_folder_to_cachename): New utility
function to get a cache name for a folder.
* mail-tools.c (mail_tool_do_movemail): Changed to return the path
to the mbox, rather than opening a folder of it.
* mail-ops.c (mail_incorporate_messages): Dont bother making the
pseudo messageinfo, filder_driver_filter_message will do it for
us.
(report_status): Callback to report status of filtering operation.
(do_fetch_mail): Changed significantly - for the api changes to
the filtering system. Also now incorporates a mailbox file
directly, without having to import it into a camel folder first.
(mail_incorporate_messages): Removed entirely, no longer needed.
* mail-vfolder.c (vfolder_refresh): Fix for context api changes.
(vfolder_uri_to_folder): Likewise.
* folder-browser-factory.c (create_ondemand_hooks): Changed for
api changes. Also only adds demand filters to the menu (fixed a
small logic bug).
2000-10-11 Chris Toshok <toshok@helixcode.com>
* subscribe-dialog.c (folder_etree_value_at): special case for
folders with NULL urls (which aren't selected/subscribeable).
(unsubscribe_folder_info): can't (un)subscribe from folders with
non-NULL urls.
(subscribe_folder_info): same.
2000-10-12 Christopher James Lahey <clahey@helixcode.com>
* message-list.c: Replace To with From except in Drafts, Outbox,
or Sent boxes. Make Subject column pay attention to text
attributes like bold and strikethrough.
2000-10-12 Iain Holmes <iain@helixcode.com>
* component-factory.c: Disable the executive summary.
2000-10-11 Chris Toshok <toshok@helixcode.com>
* subscribe-dialog.c (FOLDER_ETABLE_SPEC): set expansion to 0.0,
minimum-width to 16, and resizable to false for the subscribed
column.
(folder_info_subscribed): new function so we can do the correct
path munging.
(subscribe_folder_info): only add the folder to the storage if
there wasn't an exception subscribing it.
(unsubscribe_folder_info): same, but unsubscribing.
(folder_etree_value_at): use folder_info_subscribed.
(folder_toggle_cb): same.
(unsubscribe_folder_foreach): same.
(subscribe_folder_foreach): same.
(subscribe_dialog_gui_init): set the bold column on the text cell,
and add the subscribed pixbuf.
2000-10-11 Anna Marie Dirks <anna@helixcode.com>
* mail-threads.c: Changed the password-getting dialog so that the
text entry has focus.
2000-10-11 Chris Toshok <toshok@helixcode.com>
* subscribe-dialog.c (STORE_ETABLE_SPEC): change cell type to
"string" since we're not including it in the extras.
2000-10-11 Christopher James Lahey <clahey@helixcode.com>
* message-list.c, message-list.h, subscribe-dialog.c: Changed
these to use the proper form for the column element.
2000-10-11 Christopher James Lahey <clahey@helixcode.com>
* message-list.c, message-list.h, subscribe-dialog.c: Updated
these to the new ETable style of specifications.
2000-10-11 Chris Toshok <toshok@helixcode.com>
* subscribe-dialog.c (subscribe_dialog_gui_init): convert to the
new gal e-table stuff.
(html_size_req):
(html_new):
(put_html): #if 0 out the html functions since description stuff
isn't used and we don't want the warnings.
2000-10-11 Chris Toshok <toshok@helixcode.com>
* subscribe-dialog.c (subscribe_dialog_gui_init): remove the html
description stuff for now.
2000-10-10 Chris Toshok <toshok@helixcode.com>
* subscribe-dialog.c (folder_toggle_cb): umm.. duh :) only
subscribe if it's not subscribed, and vice versa.
(subscribe_folder_foreach): make sure to call
e_tree_model_node_changed.
(unsubscribe_folder_foreach): make sure to call
e_tree_model_node_changed.
2000-10-10 Chris Toshok <toshok@helixcode.com>
* mail-ops.c (setup_scan_subfolders): add a ref to input->storage
here so that the ref/unref pattern more closely matches other
mail-ops. also, this keeps the storage from being freed when we
hit the unref in cleanup_scan_subfolders, which is important
because we maintain a reference to it in the storage_hash in
component-factory.c
* subscribe-dialog.h: add storage field.
* subscribe-dialog.c (subscribe_folder_info): new function,
subscribe to a folder given it's CamelFolderInfo, and add it to
the shell - we're generating a path from the name of the folder
which is bad.
(unsubscribe_folder_info): same (except we unsubscribe and remove
from the shell).
(storage_selected_cb): unref the currently selected storage.
(subscribe_dialog_destroy): unref the currently selected storage.
(subscribe_dialog_construct): sc->storage = NULL.
* component-factory.c (mail_lookup_storage): new function, to look
up a EvolutionStorage corresponding to a CamelService. we ref the
EvolutionStorage before passing it back.
(mail_add_new_storage): insert the storage into storages_hash if
result is EVOLUTION_STORAGE_OK.
* mail.h: add prototype for mail_lookup_storage.
2000-10-10 Larry Ewing <lewing@helixcode.com>
* mail-format.c (mail_generate_reply): make sure we dup the return
value of get_reply_to or get_from when building the recipient list.
2000-10-10 Iain Holmes <iain@helixcode.com>
* mail-summary.c (generate_html_summary): Removed the <li> from the
HTML.
2000-10-10 Cody Russell <bratsche@gnome.org>
* mail-threads.c: Added #include <errno.h>
2000-10-09 Iain Holmes <iain@helixcode.com>
* mail-summary.c: Removed the extra arguments to rule_context_load.
2000-10-09 Chris Toshok <toshok@helixcode.com>
* subscribe-dialog.c, subscribe-dialog.h: use our own etable to
display the stores, and get them from the mail-config api. put
#if 0'ed code in place to add/remove the folders from the shell
when they're subscribed/unsusbcribed. also, react to double
clicks in the folder etable by toggling subscription status.
2000-10-08 Iain Holmes <iain@helixcode.com>
* mail-summary.c (create_summary_view): Updated to use new icon code.
2000-10-08 Iain Holmes <iain@helixcode.com>
* mail-summary.c (generate_html_summary): Generic function to
recreate the HTML of the summary. Checks all the folder summaries.
(generate_folder_summarys): Create a summary of all the vfolders
and the Inbox.
(create_summary_view): Generate the folder summarys before the
HTML.
2000-10-09 Ettore Perazzoli <ettore@helixcode.com>
* folder-browser.c: Don't #include "mail-search-dialogue.h" as
it's missing from the repository.
(search_full_clicked): Temporarily `#if 0'ed out.
(search_full): Likewise.
(folder_browser_gui_init): Don't connect `search_full'.
(create_option_menu): Don't connect `search_menu_deactivate'.
(folder_browser_gui_init): Don't connect `search_activate'.
(search_set): Don't do `search_full()'.
(folder_browser_gui_init): Likewise.
* Makefile.am (evolution_mail_SOURCES): Remove
`mail-search-dialogue.h' and `mail-search-dialogue.c' as NotZed
forgot to put them into CVS.
2000-10-06 Not Zed <NotZed@HelixCode.com>
* mail-search-dialogue.c: New widget, full search dialogue for
mail.
* folder-browser.c (search_set): If we click on custom search, run
the full search dialogue.
(folder_browser_gui_init): Add a button to perform a full search.
(search_full): Bring up the mail search dialogue asynchronously.
(search_full_clicked): Handle search options.
(folder_browser_destroy): Free the saved rule if there is one
there.
(search_options[]): Added a custom option option - brings up the
full search dialogue.
(search_set): Disable the search entry if we are doing a full
search.
* mail-vfolder.c (vfolder_create_storage): Yay, finally
depeterised this stuff.
(vfolder_uri_to_folder): Removed an irrelevant comment.
* mail-callbacks.c (filter_edit): And here.
* mail-ops.c (do_fetch_mail): And here too.
* mail-autofilter.c (filter_gui_add_from_message): Fixed call to
context_load.
(filter_gui_add_for_mailing_list): And here too.
* folder-browser-factory.c (create_ondemand_hooks): Remove that
ondemand callback snot.
2000-10-05 Not Zed <NotZed@HelixCode.com>
* message-list.c (message_list_init_etable): Build the etable once
we know what folder we are going to use.
(save_header_state): Save the header spec to a cache file.
(message_list_destroy): Save the header spec.
(message_list_setup_etable): Setup the etable spec for this
folder, from a saved version if one exists, or to suit the folder
type (sent/received).
(message_list_set_folder): Setup the etable here once we have a folder.
2000-10-09 Michael Meeks <michael@helixcode.com>
* message-list.c (message_list_toggle_threads): re-write.
* folder-browser-factory.c (control_activate): update paths, need
CVS HEAD bonobo, use a listener not a verb.
2000-10-08 Miguel de Icaza <miguel@helixcode.com>
* mail-ops.c (mail_incorporate_messages): Tag string for translation
(do_flag_messages): ditto.
* mail-threads.c (pipe_write): Repeates writes on EINTRS.
(pipe_read): Repeats reads on EINTRS.
(mail_operation_queue): Use pipe_write
(mail_op_set_percentage): ditto.
(mail_op_hide_progressbar): ditto.
(mail_op_show_progressbar): ditto.
(mail_op_set_message): ditto.
(mail_op_get_password): ditto.
(mail_op_error): ditto.
(mail_op_forward_event): ditto.
(mail_operations_terminate): ditto.
(dispatch): use pipe_read.
(dispatch): use pipe_write
(dispatch): ditto.
* mail-ops.c (mail_incorporate_messages): Only show message being
incorporated every 2 seconds, to avoid a bunch of CORBA round trips.
(do_transfer_messages): ditto.
(do_forward_messages): ditto.
2000-10-07 Miguel de Icaza <miguel@helixcode.com>
* mail-ops.c (do_fetch_mail): Move the functionality to
incorporate messages into mail_incorporate_messages.
(mail_load_evolution_rule_context): New function. Move the
functionality for loading the context rules to its own function.
2000-10-06 Iain Holmes <iain@helixcode.com>
* mail-summary.c: Fix the locking up of the mail by only calling
camel functions from the camel thread, and ORBit functions from
the GTK thread. Watch for the message-changed signal again.
* component-factory.c (summary_fn, component_factory_init):
Re-enabled it, cos I think it works again.
* mail-display.h: Remove the pb_cache.
* Makefile.am: Readd the mail-summary.[ch] files and add the
evolution-services library to the link.
2000-10-06 Chris Toshok <toshok@helixcode.com>
* mail-ops.c (do_scan_subfolders): set the @subscribed_only
parameter to TRUE, since the subscribe UI is the only interface
that should show unsubscribed groups.
2000-10-06 Ettore Perazzoli <ettore@helixcode.com>
* mail-ops.c (do_scan_subfolders): Add missing @subscribed_only
parameter in the call to `camel_store_get_folder_info()'. [FALSE,
I hope that's right.]
2000-10-05 Jeffrey Stedfast <fejj@helixcode.com>
* mail-format.c (write_field_to_stream): Decode the header before
writing it to the header box.
* mail-callbacks.c (send_receieve_mail): fetch mail before
sending, this is a temp fix for POP-before-SMTP authentication.
2000-10-05 Michael Meeks <michael@helixcode.com>
* component-factory.c (summary_fn, component_factory_init):
Disable summary stuff, it appears to be badly broken.
* Makefile.am (evolution_mail_SOURCES): add mail-summary.[ch]
* subscribe-dialog.c (update_pixmaps): upd.
(set_pixmap): upd.
(subscribe_dialog_gui_init): upd.
remove redundant and annoying forward definitions.
* folder-browser-factory.c (control_deactivate): upd.
(control_activate_cb): upd.
(control_activate): upd.
(set_pixmap): upd.
(update_pixmaps): upd.
(register_ondemand): upd.
(create_ondemand_hooks): upd.
2000-10-04 Jeffrey Stedfast <fejj@helixcode.com>
* message-list.c (address_compare): Use CamelInternetAddress
instead of my quick hack (aka InternetAddress).
2000-10-05 Iain Holmes <iain@helixcode.com>
* mail-summary.c: Don't watch for the message-changed signal.
2000-10-05 Iain Holmes <iain@helixcode.com>
* component-factory.c (component_factory_init): Setup the summary
factory as well.
(summary_fn): New function to create the ExecutiveSummaryComponent.
* mail-summary.c: Create the view, and update it when something
changes.
2000-10-04 Iain Holmes <iain@helixcode.com>
* mail-display.c (on_object_requested): Removed the pixbuf cache
as it would return the pixbufs in the reverse order every so often
and generally get all confused.
2000-10-04 Dan Winship <danw@helixcode.com>
* folder-browser-factory.c (control_deactivate): Add back the
"sync folder on leave" hack that got lost in the UIHandler merge.
2000-10-04 Jeffrey Stedfast <fejj@helixcode.com>
* folder-browser-factory.c: Instead of UnSelectAll, we want
InvertSelection.
* mail-callbacks.c (select_all): Finished this function.
(invert_selection): Finished. (was unselect_all - but that's not
what we really wanted as it'd be pointless. invert_selection is a
much more useful callback :-)
2000-10-04 Chris Toshok <toshok@helixcode.com>
* mail-tools.c (mail_tool_get_root_of_store): remove news specific
check.
(mail_tool_uri_to_folder): news: -> nntp:
2000-10-04 Jeffrey Stedfast <fejj@helixcode.com>
* mail-ops.c (do_filter_ondemand): Don't expunge the source
mailbox on completion.
2000-10-04 Dan Winship <danw@helixcode.com>
* mail-ops.c (do_scan_subfolders): Don't try to add_folders if
get_folder_info returned NULL.
2000-10-04 Not Zed <NotZed@HelixCode.com>
* message-list.c (message_list_init_header): Fix the attachment
icon width.
(content_is_attachment): Perform some simple tests to see if the
message contains an attachment.
(build_subtree): Kill a pointless warning.
2000-10-04 Miguel de Icaza <miguel@helixcode.com>
* mail-callbacks.c (delete_msg): Added a comment to a piece of
code that I was trying to "fix" just to find that the strange
behaviour here that was about to be fixed, was actually a fix to
the problem I was trying to fix.
So put the original comments from Dan, and will hope that someone
with more knowledge about this can figure why the delete key wont
delete messages and select the next unread message.
2000-10-02 Chris Toshok <toshok@helixcode.com>
* subscribe-dialog.c (subscribe_dialog_destroy): destroy our
tree_model and remove the root node. also, release_unref our
control and view, and unref the listener.
* mail-tools.c (mail_tool_uri_to_folder): news url's contain host
names too, now.
2000-10-02 Chris Toshok <toshok@helixcode.com>
* subscribe-dialog.c, subscribe-dialog.h: add a
storage-set-view-listener, and add a little printf saying what
storage was selected.
2000-10-02 Chris Toshok <toshok@helixcode.com>
* subscribe-dialog.c (subscribe_dialog_gui_init): get
Evolution::StorageSetView interface on our storage set view
control, and set "show_folders" to FALSE.
2000-10-02 Chris Toshok <toshok@helixcode.com>
* Makefile.am (INCLUDES): add -I$(top_srcdir)/widgets/misc
* subscribe-dialog.c (subscribe_dialog_gui_init): change the
window title to Manage Subscriptions, bold subscribed folders, and
add a title bar ala the evolution shell (but without the close
button).
2000-10-02 Chris Toshok <toshok@helixcode.com>
* subscribe-dialog.h: add fields for the storage set
Bonobo_Control and Evolution_StorageSetView interfaces.
* subscribe-dialog.c (subscribe_dialog_gui_init): create the uih
as early as possible, and add the storage set view to the left
side of the hpaned.
2000-09-22 Michael Meeks <michael@helixcode.com>
* folder-browser-factory.c (set_pixmap): upd.
(control_activate): upd.
2000-10-02 Dan Winship <danw@helixcode.com>
* mail-config-gui.c: Remove "Port" entry from source dialog. We'll
use "host:port" like Netscape and other programs do.
(service_page_get_url): If host ends in ":###", use that as port.
(service_page_set_url): If URL contains a port, append it to the
hostname, separated by a colon.
2000-10-02 Chris Toshok <toshok@helixcode.com>
* Makefile.am (evolution_mail_SOURCES): subscribe-control.[ch] ->
subscribe_dialog.[ch]
* mail-callbacks.c (manage_subscriptions): subscribe_control ->
subscribe_dialog. Also, pass the shell to subscribe_dialog_new.
* mail-types.h: SubscribeControl -> SubscribeDialog.
* subscribe-dialog.c, subscribe-dialog.h: rename from
subscribe-control.[ch].
* subscribe-dialog.c (subscribe_dialog_construct): pass
Evolution_Shell in.
(subscribe_dialog_new): takes Evolution_Shell argument now.
2000-10-02 Chris Toshok <toshok@helixcode.com>
* message-list.c (message_list_init_renderers): remove the 2 tree
pixbufs, so adjust the offsets to the score pixbufs. also, pass
NULL for the open/closed pixbufs to the tree cell renderer.
2000-10-02 Dan Winship <danw@helixcode.com>
* mail-ops.c (mail_do_scan_subfolders, etc): Update for
CamelFolderInfo changes.
* message-list.c (message_list_destroy): Don't save_tree_state if
there's no folder associated with the MessageList.
* folder-browser.c (folder_browser_set_uri): Only call
mail_do_load_folder if the URI is not "".
2000-10-02 Iain Holmes <iain@helixcode.com>
* mail-display.[ch]: Add a cache for the pixbufs, hashed on CID,
so that we only have to make a thumbnail once.
2000-10-01 Iain Holmes <iain@helixcode.com>
* mail-display.c: Generate the thumbnails on an idle function so
that the user interface isn't locked. Checks in case the widget it
will use to display the image isn't destroyed.
2000-10-01 Iain Holmes <iain@helixcode.com>
* mail-display.c (on_object_requested): If the attachment is an
image display a thumbnail of it, instead of the generic image
icon.
2000-09-29 Miguel de Icaza <miguel@helixcode.com>
* folder-browser-factory.c: Add print preview verb here.
* mail-callbacks.c (do_mail_print): Handle printing here, the
complete engine.
(mail_print_preview_msg): new. does print previewing.
(mail_print_msg): does printing of the message.
2000-09-29 Chris Toshok <toshok@helixcode.com>
* subscribe-control-factory.c, subscribe-control-factory.h: nuked.
* subscribe-control.c, subscribe-control.h: lots of changes. we
now pop up a dialog, and will have a storage set view on our left
side, like the shell does.
* mail.h: add prototype for manage_subscriptions.
* mail-callbacks.c (manage_subscriptions): new function, pops up
the subscribe dialog.
* folder-browser-factory.c: add the verb for managing
subscriptions.
* Makefile.am (evolution_mail_SOURCES): add subscribe-control.[ch]
again.
2000-09-28 Chris Toshok <toshok@helixcode.com>
* subscribe-control.h (subscribe_search): added prototype.
* subscribe-control.c (subscribe_search): new function.
* subscribe-control-factory.c (make_folder_search_widget): new
function, to add search widget to toolbar.
(control_activate): create the search widget and add it to the
toolbar.
2000-09-28 Jeffrey Stedfast <fejj@helixcode.com>
* mail-ops.c (do_send_queue): Messages should be appended to Sent
as Seen.
(do_send_mail): Same.
2000-09-28 Ettore Perazzoli <ettore@helixcode.com>
* Makefile.am: Don't compile `subscribe-control' for now. It
needs to be converted to the new UI handler code in Bonobo; it
doesn't compile right now.
2000-09-27 Chris Toshok <toshok@helixcode.com>
* subscribe-control.c (subscribe_refresh_list): new function.
* subscribe-control.h (subscribe_refresh_list): new prototype.
* subscribe-control-factory.c (update_pixmaps): add RefreshList
pixmap. also, add it to the verbs list.
2000-09-27 Chris Toshok <toshok@helixcode.com>
* mail-types.h: add SubscribeControl typedef.
* Makefile.am (evolution_mail_SOURCES): add the subscribe stuff.
* subscribe-control-factory.h * subscribe-control-factory.c *
subscribe-control.c: * subscribe-control.h: Mostly mocked up
subscribe ui.
2000-09-27 Jeffrey Stedfast <fejj@helixcode.com>
Note: We need a configuration option to specify whether to log
filtering actions or not.
* mail-ops.c (do_filter_ondemand): Updated to pass a log file
pointer to filter_driver_run.
(do_fetch_mail): Same.
(mail_do_fetch_mail): Fixed a compiler warning.
2000-09-27 Jeffrey Stedfast <fejj@helixcode.com>
* mail-callbacks.c (composer_postpone_cb): Fix it so that "send
later" will still mark a message as being replied, forwarded,
whatever. Closes bug #568 on bugzilla.
2000-09-27 Jeffrey Stedfast <fejj@helixcode.com>
* mail-ops.c (do_filter_ondemand): If the message has been
deleted, don't try filtering it - skip to the next message. Fixes
bugzilla bug #639.
2000-09-25 Jeffrey Stedfast <fejj@helixcode.com>
* folder-browser-factory.c: Shuffling (un)select all menu items to
the Edit menu.
2000-09-25 Jeffrey Stedfast <fejj@helixcode.com>
* folder-browser-factory.c: Added new menu items
* mail-callbacks.c (mark_as_seen): New callback to mark all
selected messages as Seen.
(mark_as_unseen): New callback to mark all selected messages as
Unseen.
(select_all): New callback to select all messages (not yet
finished)
(unselect_all): New callback to unselect all messages (not yet
finished)
2000-09-25 Not Zed <NotZed@HelixCode.com>
* message-list.c (folder_to_cachename): Function to convert a
folder name/path to a filename for per-folder data.
(save_tree_state):
(load_tree_state):
(free_tree_state): For loading/saving the state of the expansion
of nodes in the tree.
(message_list_destroy): Save the tree state when done.
(save_node_state): Changed logic, we save when the node should be
closed on startup. i.e. any new nodes with children automatically
default to being open.
(subtree_unread): Check for unread messages in a subtree. So
false messages (for tree roots) are properly displayed.
2000-09-25 Jeffrey Stedfast <fejj@helixcode.com>
* message-list.c (address_compare): Updated to use Nat's
ENameWestern parser.
* Makefile.am: link against e-util/ename/libename.la
2000-09-25 Dan Winship <danw@helixcode.com>
* mail-ops.c: CamelException is not for compile-time errors.
Replace lots of argument checks in setup_ functions with
g_return_if_fails in the public functions. Also remove some
prototypes that weren't needed because they were for static
functions that are defined before they're used.
2000-09-23 Michael Meeks <michael@helixcode.com>
* folder-browser-factory.c (set_pixmap): upd.
(control_activate): upd.
2000-09-23 Ettore Perazzoli <ettore@helixcode.com>
* message-list.c (internet_address_new_from_string): Skip spaces
at the beginning of the string first before doing anything else.
The code that follows doesn't like the first character of the
string to be a space.
2000-09-22 Jeffrey Stedfast <fejj@helixcode.com>
* message-list.c (address_compare): New comparison function for
email addresses.
(subject_compare): New comparison function for message subjects.
(message_list_init_header): Updated to use the new compare funcs.
2000-09-21 Jeffrey Stedfast <fejj@helixcode.com>
* mail-format.c (mail_generate_reply): Fixed some memory
leakage. Call free_recipients() so we don't leak memory.
2000-09-19 Jeffrey Stedfast <fejj@helixcode.com>
* mail-ops.c (do_scan_subfolders): Use the folder's full_name so
recursive directory structures display correctly ;-)
2000-09-19 Dan Winship <danw@helixcode.com>
* mail-ops.c (do_scan_subfolders): Update for CamelFolder changes
(subfolder_names -> subfolder_info).
2000-09-19 Dan Winship <danw@helixcode.com>
* mail-callbacks.c (create_msg_composer, compose_msg, send_to_url,
mail_reply, forward_msg): * mail-format.c (mail_generate_reply): *
mail-ops.c (cleanup_edit_messages):
* mail-view.c (view_forward_msg): Deal with NULL composer.
2000-09-18 Dan Winship <danw@helixcode.com>
* main.c (main): Call gnome_vfs_init() since the composer now does
file operations (to get the MIME type of attachments).
2000-09-18 Jeffrey Stedfast <fejj@helixcode.com>
* message-list.c: Removed COL_ONLINE_STATUS because we don't want
that. Renamed COL_PRIORITY to COL_SCORE and set it up to sort-of
work, I'm not really sure which renderer I should use.
2000-09-18 Christopher James Lahey <clahey@helixcode.com>
* Makefile.am: Added $(EXTRA_GNOME_CFLAGS) and
$(EXTRA_GNOME_LIBS). Removed unneeded libraries.
* component-factory.c, folder-browser-factory.c, folder-browser.c,
mail-callbacks.c, mail-config-gui.c, mail-display.c,
mail-display.h, main.c, message-list.c, message-list.h: Fixed the
#include lines to deal properly with gal.
2000-09-16 Michael Meeks <michael@helixcode.com>
* Makefile.am (INCLUDES): add datadir
* folder-browser-factory.c (control_activate): use it.
2000-09-15 Dan Winship <danw@helixcode.com>
* mail-callbacks.c (transfer_msg): Revert **Temp fix** from below
since the relevant shell bug has been fixed now.
* mail-ops.c (do_fetch_mail): Fix the sense of the "keep on
server" check so we're not doing this backwards. Don't
get_message_flags, because POP doesn't support it and it's
pointless anyway since we're setting deleted, not toggling it.
call camel_folder_sync with expunge=TRUE so that the deletions are
actually recorded.
2000-09-15 Dan Winship <danw@helixcode.com>
This bug was so much fun to fix the first time that I decided to
fix it again.
2000-07-11 Dan Winship <danw@helixcode.com>
* mail-ops.c (real_send_mail): Set the post_send_data flag
rather than toggling it. (Maybe we'll need more control
over it later, but for now, the only flag we set is
"replied", and we want that set, not toggled.)
2000-09-14 Jeffrey Stedfast <fejj@helixcode.com>
* mail-callbacks.c (transfer_msg): **Temp fix** Send "" as the
default folder to select as anything else seems to cause a
segfault in shell's user_get_folder().
(check_configured): A spoon full of 'line wrapping' makes the
medicine go down, the medicine go dowwwwn...
2000-09-14 Iain Holmes <terrorist@gegl.org>
* mail-callbacks.c (check_configured): Ask if you want to
configure the mail client if it isn't configured already.
(check_send_configuration): Remove the error box if mail isn't
configured.
(send_queued_mail): Same.
2000-09-14 Dan Winship <danw@helixcode.com>
* mail-ops.c (setup_append_mail): camel_folder_append is perfectly
happy to take a NULL info.
2000-09-14 Michael Meeks <michael@helixcode.com>
* folder-browser-factory.c: move fn to bonobo.
(set_pixmap): update.
(control_deactivate): add bonobo_ui_handler_unset_container
2000-09-14 Christopher James Lahey <clahey@helixcode.com>
* mail-config-gui.h: Changed the include here because it caused
make distcheck to fail for me. I changed it from <Evolution.h> to
"shell/Evolution.h". This seems to have fixed things.
2000-09-14 Jeffrey Stedfast <fejj@helixcode.com>
* mail-ops.c (do_fetch_mail): Only use the cache if the user plans
to keep_on_server.
2000-09-14 Michael Meeks <michael@helixcode.com>
* folder-browser-factory.c (control_deactivate): kill
warning. (control_activate): set threaded toggle state,
add freeze / thaw.
(set_pixmap, fill_toolbar, update_pixmaps): update.
2000-09-13 Christopher James Lahey <clahey@helixcode.com>
* folder-browser-factory.c: Fixed a warning (Missing include
file.)
2000-09-12 Ettore Perazzoli <ettore@helixcode.com>
($(EVOLUTION_MAIL_CORBA_GENERATED)): Add space after `-I'.
2000-09-12 Ettore Perazzoli <ettore@helixcode.com>
* Makefile.am: Remove `ui.xml' stuff.
2000-09-12 Dan Winship <danw@helixcode.com>
* mail-local-storage.c (mail_local_storage_startup): set
folder_tree before adding the listener, since that will eventually
invoke callbacks that will look at it.
* folder-browser-factory.c (control_deactivate): sync the folder
on deactivate.
2000-09-12 Ettore Perazzoli <ettore@helixcode.com>
* message-list.c (on_right_click): Also display the name of the
mailing list in the "Filter on Mailing List" item for additional
Coolness factor.
* mail-autofilter.c (filter_gui_add_for_mailing_list): Create the
rule with `filter_filter_new()' so that it also has an action
part.
* mail-mlist-magic.c (get_header): Use the right header name to
retrieve the header.
2000-09-12 Ettore Perazzoli <ettore@helixcode.com>
* message-list.c (on_right_click): Grey out the mailing list
filter item if `mail_mlist_magic_detect_list()' returns NULL on
this message [i.e., if we cannot figure out a mailing list for
this message].
(filter_mlist): Good boys don't use F words.
* mail-mlist-magic.c (check_sender): Work safely if
`header_name_return' or `header_value_return' are NULL.
(check_x_been_there): Likewise.
(check_delivered_to): Likewise.
(check_x_mailing_list): Likewise.
(check_x_loop): Likewise.
(get_header): Use the right header name to retrieve the header.
* message-list.c (on_right_click): Mark strings for translation.
2000-09-12 Ettore Perazzoli <ettore@helixcode.com>
* folder-browser-factory.c: Use the latest, shiny, amazing TigerT
art for the toolbar.
* component-factory.c: #include "mail-local-storage.h".
(owner_set_cb): Removed unused variable.
* message-list.c (filter_sender): Made static.
(filter_recipient): Likewise.
(filter_subject): Likewise.
(vfolder_recipient): Likewise.
(vfolder_sender): Likewise.
(vfolder_subject): Likewise.
* mail.h (vfolder_subject): Removed prototype [WTF was this doing
here?!?!].
(vfolder_sender): Likewise.
(vfolder_recipient): Likewise.
(filter_subject): Likewise.
(filter_sender): Likewise.
(filter_recipient): Likewise.
* message-list.c: Added a new "Filter on mailing list" menu item.
(filter_mlist): Callback for this menu item. Use
`filter_gui_add_for_mailing_list' to pop up the filter dialog with
the appropriate rule.
* mail-autofilter.c (filter_gui_add_for_mailing_list): New.
* message-thread.c (dump_tree): Removed unused variable.
* mail-mlist-magic.c: New.
* mail-mlist-magic.h: New.
* mail-autofilter.c (rule_match_recipients): Mark strings for
translation.
(rule_from_message): Likewise.
(filter_gui_add_from_message): Likewise.
2000-09-12 Jeffrey Stedfast <fejj@helixcode.com>
* mail-ops.c (do_fetch_mail): Was trying to unhook an event from
the wrong folder - oops.
2000-09-12 Not Zed <NotZed@HelixCode.com>
* message-thread.c: Reverted to version 1.15.
(remove_node): Ok, if a node has a parent, remove it from the
parent list, otherwise remove it from the (supplied) root list.
(group_root_set): When we merge children, free the lost node.
(thread_messages_free): Remove the return, run as is.
(prune_empty): Plugged another small leak.
2000-09-11 Jeffrey Stedfast <fejj@helixcode.com>
* mail-callbacks.c (run_filter_ondemand): Updated to use the new
mail_do_filter_ondemand.
* mail-ops.c (do_fetch_mail): Update to use the new
filter_driver_run args.
(do_filter_ondemand): Updated to use the new filter_driver_run
args.
(mail_do_filter_ondemand): Take a FilterContext as a argument
instead of a driver as we need to destroy the filter inside the
do_filter_ondemand function and things'd get messy.
2000-09-11 Jeffrey Stedfast <fejj@helixcode.com>
* mail-ops.c (do_fetch_mail): Don't have the filter driver
self_destruct.
2000-09-11 Jeffrey Stedfast <fejj@helixcode.com>
* mail-ops.c (do_fetch_mail): If we're fetching from an mbox
formatted file then we need to do some special-casing.
2000-09-11 Ettore Perazzoli <ettore@helixcode.com>
* component-factory.c (owner_set_cb): Call
`mail_local_storage_startup()' to set up handling of the local
storage.
* mail-local-storage.c: New.
* mail-local-storage.h: New.
2000-09-11 Christopher James Lahey <clahey@helixcode.com>
* mail-display.c: Fixed some warnings.
2000-09-11 Dan Winship <danw@helixcode.com>
* mail-display.c, mail-format.c: Another big rewrite of this
stuff. Now all (well, most) attachments get a small icon with a
description and a (non-obvious) right-click pop-up menu with
options to save, open in an external program, or show/hide inline.
TODO: antialias the icon, add more options to the pop-up for
certain MIME types, add an icon to the headers, fix PGP to work
like everything else, fix message/external-body to work again,
add some icon caching action, etc, etc.
2000-09-09 Jeffrey Stedfast <fejj@helixcode.com>
* mail-ops.c (do_fetch_mail): Use the CamelUIDCache so that we
only retrieve *new* messages and also send notes to the status bar
telling it which message we're downloading so that Ettore can
sleep at night ;-)
2000-09-09 Jeffrey Stedfast <fejj@helixcode.com>
* mail-ops.c (do_fetch_mail): Updated to not send hook/unhook data
to filter_driver_run as it no longer takes those args.
(do_filter_ondemand): Same. Also wrap filtering in freeze/thaw to
prevent signals from being queued up
2000-09-09 Jeffrey Stedfast <fejj@helixcode.com>
* mail-ops.c (do_fetch_mail): Freeze the default folder before
filtering and thaw it afterward to prevent a ton of
"folder_changed" signals from being queued.
2000-09-08 Christopher James Lahey <clahey@helixcode.com>
* folder-browser.c, mail-config-gui.c, mail-ops.c: Fixed some
warnings.
* message-list.c: Added base ETableModel functions.
2000-09-08 Jeffrey Stedfast <fejj@helixcode.com>
* mail-ops.c (do_fetch_mail): Updated to pass a CamelMessageInfo
to filter_driver_run
(do_filter_ondemand): Same.
2000-09-07 Jeffrey Stedfast <fejj@helixcode.com>
* mail-ops.c (do_filter_ondemand): Updated to check the boolean
return code from filter_driver_run to find out whether or not the
message was filtered so that it can decide whether or not to
delete the message from the source folder or not.
2000-09-07 Jesse Pavel <jpavel@helixcode.com>
* mail-format.c (mail_generate_reply) Changed the behavior of
Reply-to-All so that the sender's address does not appear in
the cc: list.
2000-09-07 Jeffrey Stedfast <fejj@helixcode.com>
* mail-ops.c (do_fetch_mail): Updated to pass an exception to
filter_driver_run and also check the exception before deleting the
message from the source folder.
(do_filter_ondemand): Updated to pass an exception to
filter_driver_run
2000-09-07 Dan Winship <danw@helixcode.com>
* session.c (session_init): Pass a storage dir to
camel_session_new now.
* main.c (main): Can't call session_init here now, because it
requires evolution_dir to be set.
* component-factory.c (owner_set_cb): call session_init here.
* mail-ops.c (do_fetch_mail): Fix previous fix. (Free the uids,
just do it correctly.)
2000-09-07 Jeffrey Stedfast <fejj@helixcode.com>
* mail-ops.c (do_fetch_mail): Don't free uids, let the camel
folder do that when it gets finalized
2000-09-06 Jeffrey Stedfast <fejj@helixcode.com>
* mail-ops.c (mail_do_filter_ondemand): New async function to
filter messages on demand.
(do_fetch_mail): Updated to filter 1 message at a time using the
new filter-driver code
* mail-callbacks.c (composer_postpone_cb): Send NULL as the
message info.
(run_filter_ondemand): Use mail_do_filter_ondemand instead of
filter_driver_run
* mail-tools.c: Removed mail_tool_filter_contents_into and
mail_tool_fetch_mail_into_searchable as they have now been
deprecated.
2000-09-06 Dan Winship <danw@helixcode.com>
* message-list.c (clear_tree): set the data to NULL for the tree
root, so nuke_uids won't try to free anything.
2000-09-06 Ettore Perazzoli <ettore@helixcode.com>
* folder-browser.c (folder_browser_new): @shell made const.
`CORBA_Object_duplicate()' it before storing it.
(folder_browser_destroy): Free the shell object with
`CORBA_Object_release()', not `CORBA_free()'.
* folder-browser-factory.c (folder_browser_factory_new_control):
@shell made const.
2000-09-05 Dan Winship <danw@helixcode.com>
* mail-display.c (make_safe_filename):
* mail-format.c (handle_mystery):
* mail-identify.c (mail_identify_mime_part):
camel_mime_part_get_filename now deals with both
Content-Disposition and Content-Type.
2000-09-05 Peter Williams <peterw@helixcode.com>
* mail-ops.c (cleanup_load_folder): Check for NULL folder.
(mail_do_setup_folder): Copy the 'name' parameter so that
we can free it.
* message-list.c (nuke_uids): Depth '-1' means "unlimited", not 0.
2000-09-05 Dan Winship <danw@helixcode.com>
* component-factory.c (owner_set_cb): Re-rename "Sent".
* folder-browser.c (fb_resize_cb): Remove the "+ 90" here since it
seems to break things for me, and it's not commented anyway and
there's no excuse for adding 90 to a number with no explanation.
2000-09-05 Peter Williams <peterw@helixcode.com>
* folder-browser.c (folder_browser_destroy): Don't free the shell;
it's not ours.
2000-09-05 Dan Winship <danw@helixcode.com>
* mail-tools.c (mail_tool_move_folder_contents): only call
camel_folder_get_message_info if the folder has
summary_capability. Don't hack up a fake CamelMessageInfo:
append_message will take NULL.
* mail-ops.c: Replace mail_do_setup_draftbox,
mail_do_setup_outbox, and mail_do_setup_sentbox with
mail_do_setup_folder.
(do_send_mail, do_send_queue): s/sentbox_folder/sent_folder/
* component-factory.c (owner_set_cb): Use mail_do_setup_folder,
rename sentbox_folder to sent_folder, and call
mail_operation_wait_for_finish after the setup_folder calls in
case anything needs to use the _folder variables.
2000-09-04 Jeffrey Stedfast <fejj@helixcode.com>
* mail-format.c (mail_generate_reply): Applied Jesse's patch that
will append a signature to the replied message text
* folder-browser-factory.c: Changed "Send & Receieve" back to "Get
Mail" temporarily so that the toolbar buttons don't all get
stretched to some weird proportion
2000-09-03 JP Rosevear <jpr@helixcode.com>
* mail-config.c (mail_config_add_news): Copy the passed in item
before adding
(mail_config_add_source): ditto
(mail_config_add_identity): ditto
* mail-config-gui.c (mail_config): We don't actually need a notebook
pointer.
(identities_edit_clicked): Don't explicitly destroy, we are using
gtk_clist_set_data_full now
(sources_edit_clicked): ditto
(news_edit_clicked): ditto
(mail_config): Use gtk_clist_set_row_data_full to kill leaks
2000-09-03 Jeffrey Stedfast <fejj@helixcode.com>
* folder-browser-factory.c: Change the "Get Mail" toolbar button
to become "Send & Receieve"
* mail-callbacks.c (send_queued_mail): New callback function for
sending queued mail
(send_receieve_mail): New callback for Send & Receieve that
basically just calls send_queued_mail and then fetch_mail
* mail-ops.c (cleanup_send_mail): Mod to be able to handle a NULL
composer window
(setup_send_mail): Modified to handle a NULL composer widget
(mail_do_send_queue): New convenience async function to send all
messages in a folder (aka all messages in a queue)
2000-09-02 Jeffrey Stedfast <fejj@helixcode.com>
* mail-tools.c (mail_tool_move_folder_contents): Since POP3
doesn't implement get_message_info, we need to check for info to
be NULL. In this case, we need to make our own info structure to
pass to append_message and then remember to free it
afterward. Should we even bother with get_message_info? And if so,
should we then implement get_message_info for POP3?
2000-09-02 Ettore Perazzoli <ettore@helixcode.com>
* folder-browser.c (etable_key): Make the `Home' key to move to
the beginning of the list and `End' to the end of it, using
`message_list_home()' and `message_list_end()'.
* message-list.c (message_list_home): New.
(message_list_end): New.
* folder-browser.c (folder_browser_new): Don't ref the shell here.
(folder_browser_destroy): Don't unref the shell. Instead,
`CORBA_free()' the object reference.
* folder-browser-factory.c (control_activate): Bind "Open in New
Window" to `Ctrl-O'.
2000-09-02 Lauris Kaplinski <lauris@helixcode.com>
* mail-config-gui.c: Use e_utf8 wrappers
* main.c (main): Do e_unicode_init, so we are not confusing
libunicode
2000-09-01 Christopher James Lahey <clahey@helixcode.com>
* folder-browser.c: Removed a warning.
2000-09-01 Jeffrey Stedfast <fejj@helixcode.com>
* mail-callbacks.c (compose_msg): Attach a callback to the
postpone signal
(send_to_url): Same
(mail_reply): Same
(forward_msg): Same
(composer_postpone_cb): Callback function for the postpone signal
* mail-ops.c (mail_do_setup_outbox): New convenience function to
load the Outbox folder
(mail_do_setup_sentbox): Same, but for Sentbox.
(do_send_mail): Now saves messages in Sentbox if sent successfully
(mail_do_append_mail): New convenience async function for
appending messages to a folder
* component-factory.c: Added outbox_folder and sent_folder
(owner_set_cb): Call our new convenience functions to load Outbox
and Sentbox
2000-09-01 Ettore Perazzoli <ettore@helixcode.com>
* mail-ops.c (cleanup_scan_subfolders): Update for the extra arg
needed by `evolution_storage_new_folder()'.
* mail-vfolder.c (vfolder_refresh): Likewise.
2000-08-31 Peter Williams <peterw@helixcode.com>
* folder-browser.c (folder_browser_new): Don't ref the shell:
causes a race upon exit.
(folder_browser_destroy): Don't unref it.
* mail-config-gui.c (service_page_item_new): Add a checkbutton
"use default port" to make life simple.
(service_page_get_url): Honor use_default_port.
(service_page_set_url): Set use_default_port based on the input
URL.
(toggle_port): New function, sets the sensitivity of the
port entry based on "use default port"
(config_do_query_authtypes): Make this asynchronous, as it
may involve connecting to a server.
(service_page_detect): Call the async auth querier.
(service_page_item_new): Put the authentication stuff in if
the url_flags have URL_ALLOW_AUTH. Call the async auth querier
to get the info.
2000-08-30 Ettore Perazzoli <ettore@helixcode.com>
* mail-view.c (mail_view_create): Make the HTML widget grab the
focus.
2000-08-30 Peter Williams <peterw@helixcode.com>
* mail-config-gui.c (do_test_service): Explicitly connect to
the service again.
* component-factory.c (mail_load_storages): Now that
camel_service_get_provider exists, use it to make this function
much simpler.
2000-08-29 Peter Williams <peterw@helixcode.com>
* folder-browser.c (folder_browser_new): Ref the Evolution_Shell.
Is this correct, or is it a circular reference?
2000-08-29 Dan Winship <danw@helixcode.com>
* mail-ops.c (mail_do_send_mail): Update this and related
functions to no longer take a From address. (The composer deals
with it itself now.)
(do_send_mail): Add the Evolution version back to the X-Mailer
header (this change got lost in the thread migration).
* mail-callbacks.c (composer_send_cb): Don't re-fetch the From
address. It's set by the composer now. Don't free the
post_send_data from here.
(mail_reply): Attach to the composer's destroy signal to free the
psd. (The current code would free it more than once if an error
occurred while trying to send the first time.)
2000-08-28 Peter Williams <peterw@helixcode.com>
* mail-config-gui.c (mail_config_apply_clicked): Add new news sources,
not only stores.
2000-08-28 Jeffrey Stedfast <fejj@helixcode.com>
* mail-callbacks.c (composer_send_cb): Free the from address when
we're done with it. Also, e_msg_composer_hdrs_get_from returns
alloc'd memory so don't strdup it.
2000-08-28 Peter Williams <peterw@helixcode.com>
* mail-ops.c (do_transfer_messages): Add status messages.
(do_flag_messages): Same.
(do_scan_subfolders): Same.
(do_forward_messages): Same.
(do_view_messages): Same.
2000-08-28 Ettore Perazzoli <ettore@helixcode.com>
* mail-view.c (mail_view_create): Use `gnome_app_set_toolbar()'
the easy way instead of doing things manually with `GnomeDock' and
`gnome_app_add_toolbar()'.
(MINIMUM_WIDTH): New #define.
(MINIMUM_HEIGHT): New #define.
(view_size_allocate_cb): New, callback for the "size_allocate"
signal of the mail view. It saves the last allocation in a static
`last_allocation' variable.
(mail_view_create): Connect it.
(set_default_size): New function. Set the default width/height to
the last allocation width/height; if the width/height is less than
the `MINIUM_WIDTH' or `MINIMUM_HEIGHT', use that value instead.
* mail-tools.c (mail_tool_move_folder_contents): Show `i + 1', not
`i', so that we correctlly start counting from one instead of zero.
2000-08-28 Peter Williams <peterw@helixcode.com>
* *.c: s,mail_dialog_run,gnome_dialog_run,g.
* main.c (main): Since only the main thread is dealing with GTK+,
free the GDK threads mutex and never worry about locking again.
2000-08-28 Jeffrey Stedfast <fejj@helixcode.com>
* mail-crypto.c (mail_crypto_openpgp_encrypt): Fix to prevent
possible buffer overflows and a logic fix.
2000-08-27 Jeffrey Stedfast <fejj@helixcode.com>
* mail-crypto.c (mail_crypto_openpgp_clearsign): New crypto
function to clearsign plaintext
2000-08-27 Ariel Rios <ariel@arcavia.com>
* folder-browser-factory.c (control_activate): Added bonobo menu
handler for mark_all_deleted function.
* mail.h: (mark_all_deleted): Added prototype.
* mail-callbacks.c (mark_all_deleted): Added callback for marking
all displayed messages in a folder as deleted.
2000-08-26 Ettore Perazzoli <ettore@helixcode.com>
* mail-view.c (mail_view_create): Use
`gtk_window_set_default_size' on the toplevel instead of
`gtk_widget_set_usize()', and make the default size smaller.
2000-08-25 Christopher James Lahey <clahey@helixcode.com>
* mail-crypto.c: Fixed an uninitialized variable.
2000-08-26 JP Rosevear <jpr@helixcode.com>
* evolution-mail.gnorba: Kill
* Makefile.am: Remove gnorba related stuff
2000-08-25 Peter Williams <peterw@helixcode.com>
* mail-config-gui.c (service_page_item_new): If the service wants
a host, also let the user specify a port.
(MailDialogServicePageItem): Add members for the port GtkEntry and
the default port.
(service_page_get_url): Translate the port in the entry back into
the CamelURL.
(service_page_set_url): Read in the port from the URL or use
the default.
2000-08-25 Jeffrey Stedfast <fejj@helixcode.com>
* mail-crypto.c (mail_crypto_openpgp_encrypt): Implemented PGP 2.x
encryption. We only need to get the passphrase if we plan to sign
the text, otherwise we don't need to worry about getting the
passphrase.
2000-08-24 Lauris Kaplinski <lauris@helixcode.com>
* folder-browser.c: Use e_utf8 wrappers
* mail-config-gui.c: Use e_utf8 wrappers
2000-08-24 Peter Williams <peterw@helixcode.com>
* folder-browser-factory.c (control_activate): Add all the
functions from message-list.c's popup menu to the main
menu as well
* message-list.c (vfolder_subject): These functions become
public.
* mail-callbacks.c (mark_all_seen): Don't call camel_folder_get_uids
here. IMAP, for example, will try to communicate with the IMAP
server during that call.
* mail-ops.c (cleanup_fetch_mail): Tell the user
which URL has no new mail, as they may be checking
more than one source.
(mail_do_flag_all_messages): New function. Flags all of
the messages in a folder. Something of a hack. This merely
extends the flag_messages operation; it doesn't implement
a new one.
(do_flag_messages et al): Fetch the uids if we need to;
use camel_folder_free_uids if necessary, etc.
* mail-tools.c (mail_tool_move_folder_contents): Add
messages to tell the user what's going on.
2000-08-24 Christopher James Lahey <clahey@helixcode.com>
* folder-browser-factory.c: Fixed some warnings in the uihandler
code.
2000-08-24 Peter Williams <peterw@helixcode.com>
* component-factory.c (mail_load_storages): New function.
Loads a list of URI's as mail storages, and inserts them
into the shell's folder tree if appropriate (really, only
puts them into the folder tree.)
(mail_add_new_storage): Insert a storage into the folder
tree. Not always appropriate (eg, /var/spool/mail/user is
a storage that shouldn't be in the folder tree.)
(create_view): Generate the Evolution_Shell and pass it
to folder_browser_factor_new_control so that its member
'shell' can be set.
(owner_set_cb): Instead of create_news_storage and
creating the imap storages, load the news storages and
mail storages via mail_load_storages().
* folder-browser-factory.c (control_activate): Change to
use providers_config again instead of mail_config. Pass
the folderbrowser so that the config code knows where
to insert the new storages if any are created. Pass
forget_passwords the folderbriwser, too, for good luck.
(folder_browser_factory_new_control): Take a new parameter,
the Evolution_Shell that we belong to. The field in
FolderBrowser has been there but was never getting set by
anything, and we need this to be able to insert new storages
into the shell's folder list.
* folder-browser.c (folder_browser_new): Accept the
new Evolution_Shell parameter. Set it. (Should we
ref it or something?)
* mail-config-gui.c (struct MailDruidDialog): Store an
Evolution_Shell. With this we can insert the stores into
the shell's folder list.
(struct MailDialog): Same.
(service_page_item_changed): Close a leak.
(identity_dialog): Unswitch the Add/Edit identity titles.
(news_dialog): Analogous to above.
(mail_druid_finish): Add the new mail source to the shell
view.
(mail_config_druid): Take a new Evolution_Shell parameter
for later use.
(mail_config_apply_clicked): Add all the mail sources to
the shell view.
(mail_config): Take a new Evolution_Shell parameter.
* mail-callbacks.c (check_configured): Accept a FolderBrowser
so that we know where to put the new storages if any are
created. Almost all the callbacks are passed a FB * anyway
so this isn't a big deal.
(check_send_configuration): Make sure that we're configured
enough to be able to send mail. composer_send_cb() used to
do this, but it would need a FolderBrowser *, and there are
too many entry points to composer_send_cb to make this
feasible.
(fetch_mail): Pass the extra parm to check_configured().
(free_psd): Move so that composer_send_cb can call this
directly.
(composer_send_cb): Don't check for proper configuration
here -- it is the caller's responsiblity to call
check_send_configuration(). Call free_psd() directly.
(compose_msg): Call check_send_configuration().
(send_to_url): Same. This is called from mail-display.c,
though, and cannot reasonably be passed a FB. So: we can't
start up the config dialog directly; the user must do it
manually. Oh well.
(mail_reply): Same as above.
(forward_msg): Same as compose_msg().
(edit_msg): Same as above.
(providers_config): Reenable so that we can pass mail_config
its FolderBrowser.
* mail-display.c (write_data_to_file): Use the much more
straightforward run_and_close to retrieve the user's answer,
instead of the reply callback stuff.
* mail-threads.c (mail_dialog_run): New wrapper for
gnome_dialog_run that will take care of the GDK lock correctly.
Far far more complicated than it should be.
(mail_dialog_run_and_close): Analogous to above.
(read_msg): Set inside_read_msg and unset it for the benefit
of the two above functions. Don't bracket ourselves in
GDK_THREADS_ENTER/_LEAVE anymore.
(mail_operation_queue): Use mail_dialog_run_and_close.
(show_error): As above.
(get_password): As above.
* mail-display.c (write_data_to_file): This has the only
exception to the rule that "use mail_dialog_run(_and_close)
instead of the gnome equivalent always." Not quite sure why
it doesn't work here (the file selection window?).
* mail-config-gui.c (identity_dialog): Change to
mail_dialog_run_and_close.
(source_dialog): Same as above.
(news_dialog): Same as above.
(cleanup_test_service): Same as above.
(mail_config): Change to mail_dialog_run().
* session.c (mail_request_dialog): Change to
mail_dialog_run_and_close.
* mail-tools.c (mail_tool_uri_to_folder_noex): As above.
* mail-ops.c (cleanup_fetch_mail): As above.
* mail-local.c (local_reconfigure_folder): As above.
* mail-callbacks.c (check_send_configuration): As above.
(ask_confirm_for_empty_subject): As above.
(edit_msg): As above.
(filter_edit): As above.
2000-08-23 Dan Winship <danw@helixcode.com>
* folder-browser-factory.c (control_activate): Reformat a bit,
make "Folder" appear before "Message", fill in the Message menu
more.
2000-08-23 Peter Williams <peterw@helixcode.com>
* mail-ops.c (describe_fetch_mail): Don't use the camel calls
to describe the operation.
2000-08-22 Peter Williams <peterw@helixcode.com>
* mail-tools.c (mail_tool_get_folder_from_urlname): Don't connect
to the service explicitly.
(mail_tool_send_via_transport): Don't connect to the transport
explicitly.
(mail_tool_get_root_of_store): Same.
* mail-config-gui.c (do_test_service): Just try camel_session_get_service,
which will now connect for us.
* message-thread.h: Add a note about *next being the first member
of struct _container... if it isn't, everything goes Very Wrong.
* message-thread.c (free_container): Extra debug print.
(remove_node): Handle the case of empty containers holding the child
that we're interested in.
(thread_messages_free): Extra debug print.
2000-08-20 Jeremy Wise <jwise@pathwaynet.com>
* folder-browser.c: (fb_resize_cb) Added function to monitor resize
of the e_paned in the main view.
2000-08-18 Peter Williams <peterw@helixcode.com>
* mail-tools.c (mail_tool_filter_contents_into): Fix a race. filter_driver_run is an
async operation so it won't even be started by the time we sync the folders and check
for the movemailbox to be emtpy. Thus the empty check for the movemail would fail
99% of the time.
* mail-callbacks.c (run_filter_ondemand): Pass he new argument to the ever-mushrooming
filter_driver_run.
2000-08-17 Peter Williams <peterw@helixcode.com>
* folder-browser-factory.c (control_activate): Fix menu item names.
(register_ondemand): Put the ondemand hooks into the new folder menu.
2000-08-17 Ettore Perazzoli <ettore@helixcode.com>
* mail-vfolder.c (vfolder_gui_add_rule): Use stock OK/Cancel
buttons and add i18n support.
* folder-browser-factory.c (control_activate): Changed menu item
label from "Mark all messages seen" to "Mark All Messages as
Read". Changed capitalization of some other menu items.
(control_activate): Put the message- and folder- related menu
items in new "Message" and "Folder" subtrees which are created in
the `<Component Placeholder>' item created by the shell.
(control_deactivate): Updated accordingly.
(control_activate): Put the filter and vfolder editors, the mail
configuration and the "forget password" command into the
"settings" menu.
(control_deactivate): Updated accordingly.
* mail-config-gui.c (transport_page_new): Add translation mark.
(service_page_new): Show the menu items before appending them.
(service_page_item_new): Use `GTK_FILL' for the "Detect supported
types..." button.
* local-config.glade: Change the apply button into an ok button.
2000-08-17 Peter Williams <peterw@helixcode.com>
Implement filtering on demand.
* folder-browser-factory.c (register_ondemand): New function. Callback
to put the filter-on-demand filters into the bonobo UIH;
(create_ondemand_hooks): New function. Read in our on-demand filters
and hook them into the UI.
(remove_ondemand_hooks): New function. Remove the hooks when done with
them.
(control_activate): Call create_ondemand_hooks()
(control_deactivate): Call remove_ondemand_hooks();
* mail-callbacks.c (run_filter_ondemand): New function. Callback
for running a filter on demand.
(filter_edit): Pass NULLs as the new arguments to rule_context_load.
* mail.h: Prototype run_filter_ondemand();
* folder-browser.c (oc_destroy): New function. Iterator to destroy
an fb_ondemand_closure.
(folder_browser_destroy): Free the data associated with the ondemand
menu items.
(my_folder_browser_init): Clear the filter_ variables.
* folder-browser.h: Two new members of FolderBrowser: filter_menu_paths,
a list of fb_ondemand_closures so that the menu items can be freed and
removed; and filter_context, a permanently loaded FilterContext for
running the ondemand filters. Prototype the new fb_ondemand_closure
structure.
* mail-autofilter.c (filter_gui_add_from_message): Pass NULLs as the
new parameters to rule_context_load (we don't need to hook up ondemand
menu items...)
* mail-tools.c (mail_tool_filter_get_folder_func): Rename from
get_folder_func() and make public so mail-callbacks.c:run_filter_ondemand()
can use it too.
(mail_tool_filter_contents_into): Use the new name of get_folder_func.
Pass NULLs as the extra arguments to rule_context_load. Pass the
extra source type to filter_driver_run (only use INCOMING).
* mail-tools.h: Publicly prototype mail_tool_filter_get_folder_func()
* mail-vfolder.c (vfolder_create_storage): Pass NULLs as the extra
arguments to rule_context_load.
* message-list.c (message_list_init): Free our strdup'd uids when
the table model gets destroyed.
(nuke_uids): New function. Walk the tree nodes to free the uids.
(nuke_uids_cb): New callback for nuke_uids();
2000-08-16 Richard Hult <rhult@hem.passagen.se>
* mail-ops.c (cleanup_display_message): Use a configurable timeout.
* mail-config.c (mail_config_set_mark_as_seen_timeout): New function
for the settable mark-as-seen timeout.
(mail_config_mark_as_seen_timeout): Likewise.
(mail_config_write): Write the timeout setting.
(config_read): Read timeout setting.
* mail-config-gui.c (mail_config): Add option for the settable
mark-as-seen timeout.
(mail_config_apply_clicked): Likewise.
(timeout_changed): New function for the timeout setting.
2000-08-16 Peter Williams <peterw@helixcode.com>
* message-thread.c (walk_containers): More (default disabled)
mem debugging here. Fix the big leaks.
* mail-format.c (get_url_for_icon): Copy the url_path so that
it can't get freed under us.
* mail-threads.c (mail_operation_queue): Fix a leak.
* mail-ops.c (mail_do_display_message): Fix another leak.
* message-list.c (message_list_destroy): Remove the seen_id timeout
if necessary.
* mail-local.c (mail_tool_local_uri_to_folder): Fix a leak.
* session.c (auth_callback): Fix a leak. Almost seems as if
I've been using Purify...
2000-08-15 Peter Williams <peterw@helixcode.com>
* message-thread.c (alloc_container): Add support for debugging
container allocations -- currently disabled. Make sure that
the g_strfreev works.
* message-list.c (main_message_changed): Address bug #496 --
possible race when forwading a message_changed event.
* mail-threads.c (dispatch): Close the dispatch thread's half of
pipes when about to exit.
(mail_operations_terminate): Close the main thread's half of the
pipes when about to exit.
(all): Add i18n support.
* mail-tools.c (all): Add i18n support.
* mail-ops.c (transfer_messages): Generalize move_messages into
transfer_messages so that we can copy too.
(all): Add i18n supprt where appropriate.
* mail-ops.h: Prototype the new mail_do_transfer_messages.
* folder-browser-factory.c: Add a UI hook for copy_msg.
* mail-callbacks.c (transfer_msg): Generalize move so that it supports
copy as well, and add a callback 'copy_msg'.
* message-list.c (on_right_click): Add a right-click hook for Copy Message.
* session.c (mail_request_dialog): Don't deadlock when in main thread.
2000-08-14 Peter Williams <peterw@helixcode.com>
* mail-threads.c (show_error): Fix the error dialogs.
(read_msg): Re-enable them.
* mail-ops.c (do_scan_subfolders): Silence a compile warning.
2000-08-13 Jeffrey Stedfast <fejj@helixcode.com>
* mail-crypto.c (mail_crypto_openpgp_encrypt): Added support for
encrypting via PGP 5.0
2000-08-13 Ettore Perazzoli <ettore@helixcode.com>
* mail-ops.c (cleanup_create_folder): Release the listener object
with `CORBA_Object_release()', not `CORBA_free()'.
2000-08-13 Ettore Perazzoli <ettore@helixcode.com>
* main.c (main): Set the signal handlers for `SIGSEGV' and
`SIGBUS' to the default ones.
2000-08-13 Jeffrey Stedfast <fejj@helixcode.com>
* mail-config.c (mail_config_write): Set config->configured to
TRUE
2000-08-13 Ettore Perazzoli <ettore@helixcode.com>
* mail-config-gui.c (mail_config_druid): Don't
`GDK_THREADS_ENTER()'/`GDK_THREADS_LEAVE()'.
2000-08-13 Ettore Perazzoli <ettore@helixcode.com>
* mail-threads.c (update_active_views): Just iterate through all
the controls, not just the active ones.
* folder-browser-factory.c: Don't keep track of active controls.
Rather, keep track of all of them.
(folder_browser_factory_get_active_control_list): Removed.
(folder_browser_factory_get_control_list): New.
2000-08-13 Dan Winship <danw@helixcode.com>
* Makefile.am (evolution_mail_SOURCES): add mail-local.h
2000-08-13 Ettore Perazzoli <ettore@helixcode.com>
* mail-threads.c (read_msg): For now, don't do anything about
errors.
2000-08-13 Dan Winship <danw@helixcode.com>
* mail-format.c (add_url): Fix some freed-memory references
* mail-threads.c (get_password): Don't free the prompt. It
doesn't belong to you.
2000-08-13 Ettore Perazzoli <ettore@helixcode.com>
* mail-ops.c (mail_do_create_folder): Duplicate the listener
object.
(cleanup_create_folder): Free the listener.
2000-08-13 Jeffrey Stedfast <fejj@helixcode.com>
* mail-threads.c (get_password): Don't wrap the gnome_dialog_run
in GDK_THREADS_ENTER/LEAVE
2000-08-13 Ettore Perazzoli <ettore@helixcode.com>
* folder-browser-factory.c (control_destroy_cb): Remove the
control from the active control list, if it's there.
* mail.h (folder_browser_factory_new_control): Removed prototype.
(folder_browser_factory_init): Removed prototype.
* folder-browser-factory.h: New.
* folder-browser-factory.c: New static variable `active_controls',
list of the currently active controls.
(control_activate): Add the control to it.
(control_deactivate): Remove the control from it.
(folder_browser_factory_get_active_control_list): New.
* mail-threads.c (mail_operations_get_status): New function.
* folder-browser.c (folder_browser_gui_init): Add i18n support for
the labels.
[The following is actually from a patch by Peter Williams
<peterw@helixcode.com>.]
* Removed types `PERCENTAGE', `HIDE_PBAR', `SHOW_PBAR'. New
struct `block_info_s'. Removed all the code to create and destroy
the progress window.
2000-08-13 Jeffrey Stedfast <fejj@helixcode.com>
* component-factory.c (create_news_storage): Updated to reflect
changes to mail_do_scan_subfolders
(create_imap_storage): Same.
* mail-ops.c (mail_do_scan_subfolders): No longer takes an
add_INBOX argument
2000-08-13 Dan Winship <danw@helixcode.com>
* mail-ops.c (do_scan_subfolders): Lose a reference to the store
on purpose. To be fixed later.
2000-08-12 Dan Winship <danw@helixcode.com>
* component-factory.c (create_imap_storage): Take the source as a
command-line argument rather than fetching it from mail-config.
(owner_set_cb): Call create_imap_storage on each configured IMAP
store.
* mail-format.c (decode_pgp): Redo this so that the lock icon
remains active after a failed decryption so you can click on it
and try again.
(try_inline_pgp, handle_multipart_encrypted): Put a border around
the decrypted data.
* message-list.c (cleanup_regenerate_messagelist): Don't clear the
tree here. If two "folder_changed"s arrive in close succession,
then one possible ordering of events is
cleanup_regenerate_messagelist, cleanup_regenerate_messagelist,
cleanup_thread_messages, cleanup_thread_messages. Which would
result in the message list being filled in twice without being
cleared in between. So don't clear it until the rebuilding
function itself is called.
(clear_tree): New function to empty out the ETreeModel in the
message list.
(build_tree): Change to simpler interface. Call clear_tree.
(build_subtree): Does most of the work of the old build_tree
(build_flat): Remove unused arg. Call clear_tree.
* message-thread.c (cleanup_thread_messages): Update for
build_tree interface change.
* mail-ops.c (do_send_mail): Don't leak the transport.
* mail-tools.c (mail_tool_get_folder_from_urlname): Don't ref the
store returned from camel_session_get_store. It's already reffed.
(mail_tool_get_root_of_store): Ditto.
(mail_tool_send_via_transport): Remove some commented-out code and
fix it to not leave the transport connected if sending fails.
* mail-callbacks.c (delete_msg): Toggling a flag is an
"instantaneous" operation, so if we're only doing one, just do it
and return, rather than queueing it for the other thread. This
makes the "Delete" key work correctly (move to the next message)
again.
* mail-identify.c: Remove workaround for gnome-vfs 0.2 bug.
* mail-format.c (lookup_handler): Remove workaround for function
introduced between gnome-vfs 0.2 and 0.3, since we depend on 0.3
now.
2000-08-12 Michael Meeks <michael@helixcode.com>
* main.c (main): kill using_oaf assertion.
2000-08-11 Peter Williams <peterw@helixcode.com>
* Makefile.am: Make it so that test-mail links
2000-08-11 JP Rosevear <jpr@helixcode.com>
* folder-browser-factory.c (control_activate): Move menu items
that affect a single message together, ditto with ones that
affect multiple messages, put a separator in.
2000-08-11 Christopher James Lahey <clahey@helixcode.com>
* mail-format.c, mail-tools.h, message-list.c: Fixed a warning.
2000-08-11 Dan Winship <danw@helixcode.com>
* mail-display.c, mail-format.c: Redo this again. Get rid of
struct mail_format_data and move most of that info into
MailDisplay itself, and pass the MailDisplay around. Add a GData**
to MailDisplay, and put the urls hash table into that. Also add
the ability to redisplay the currently-displayed message (with the
same GData**), and add a "show_pgp" datum to it that controls
whether or not to decrypt PGP messages, and redo the PGP stuff
(again) to take that into account. Now you don't get the annoying
PGP password dialog box without any warning.
2000-08-11 Peter Williams <peterw@helixcode.com>
* mail-config-gui.c (service_acceptable): Make verify-service
an asynchronous operation.
* Makefile.am (noinst_PROGRAMS): Don't build test-thread
while mail-threads.c is in flux.
* mail-threads.c (mail_operation_queue): Make the error
and query dialogs modal.
* mail-local.c (update_progress): Don't use the
temporarily-disabled mail_op_set_percentage().
2000-08-11 Chris Toshok <toshok@helixcode.com>
* mail-config.c (mail_config_get_default_news): use config->news
instead of config->sources.
2000-08-11 Dan Winship <danw@helixcode.com>
* mail-format.c (destroy_part): Update this for CamelObject
(try_inline_pgp): Deal with decrypting here rather than trying to
pawn the data off to handle_multipart_encrypted, since it most
likely won't be correct (won't have the proper MIME headers inside
the encrypted part).
(handle_multipart_encrypted): Add code from Nathan Thompson-Amato
to re-MIME-parse the decrypted data after decrypting.
* mail-crypto.c (mail_crypto_openpgp_{de,en}crypt): Get the
password here rather than having it passed in. Remove some dead
code.
* session.c (mail_request_dialog): Allow this to work in either a
sync or an async context.
2000-08-11 Peter Williams <peterw@helixcode.com>
* mail-tools.c (mail_tool_fetch_mail_into_searchable): Don't
do the imap check here... it's a silly place.
* mail-ops.c (do_fetch_mail): Do the imap check here.
2000-08-11 JP Rosevear <jpr@helixcode.com>
* mail-config-gui.c (service_page_new): Work around
gtk option menu bug.
(service_page_item_auth_fill): ditto
2000-08-11 Peter Williams <peterw@helixcode.com>
* mail-threads.c (read_msg): Fix the new FORWARD_EVENT handler
(didn't free msg, didn't write newline in the debug)
* mail-local.c (local_reconfigure_folder): Make the dialog
modal.
* mail-callbacks.c (select_first_unread): Fix some warnings.
* mail-threads.c (mail_op_forward_event): New function that
writes a FORWARD_EVENT signal to the compipe, to allow Camel
events to be handled in the main thread.
(read_msg): Handle a FORWARD_EVENT.
* mail-callbacks.c (select_first_unread): Forward the
event into the main thread to prevent the GTK calls in the
dispatcher thread.
(main_select_first_unread): New name of old select_first_unread.
* message-list.c (folder_changed): Same as above.
(main_folder_changed): Same as above.
(message_changed): Same as above.
(main_message_changed): Same as above.
* mail-format.c (free_byte_array): Note about using
mail_op_forward_event. (cmm_destroyed): Same.
2000-08-11 Dan Winship <danw@helixcode.com>
* message-list.c (message_list_select): If the caller passes "-1"
for the model row, translate that to view row 0.
* message-list.c (idle_select_row):
* mail-callbacks.c (select_first_unread): Use new
message_list_select kludge^H^H^H^H^H^Hfeature
2000-08-11 JP Rosevear <jpr@helixcode.com>
* mail-config-gui.c (source_dialog): Allow the window
to be growable
* mail-config.c: use void in empty declarations
2000-08-11 Peter Williams <peterw@helixcode.com>
* mail-config.c (mail_config_get_news): Change () to (void)
if a function takes no arguments.
* mail-config.h: Prototype mail_config_get_{sources,news}x
2000-08-11 JP Rosevear <jpr@helixcode.com>
* mail-config-gui.c (identity_dialog): iddialog, not sdialog
(news_edit_clicked): Kill leftover c-p crud
2000-08-11 JP Rosevear <jpr@helixcode.com>
* mail-config-gui.c (news_edit_clicked): Check nrow, not srow.
2000-08-11 JP Rosevear <jpr@helixcode.com>
* mail-config-gui.c (service_acceptable): Use camel_object_unref
instead of gtk_object_unref
(mail_druid_finish): Use new config accessors
(mail_config_druid): No need to call config functions
(news_add_clicked): Increments maxnrow, not maxsrow
(mail_config_apply_clicked): Use new config accessors
(mail_config): ditto
* component-factory.c (create_imap_storage): Use new
config accessors
(create_news_storage): ditto
* mail-config.glade: Set news clist name correctly
* mail-config.c (config_read): Rename from mail_config_read and
made private - no one should need to do a read manually.
(mail_config_set_send_html): New accessor
(mail_config_add_identity): ditto
(mail_config_get_sources): ditto
(mail_config_add_source): ditto
(mail_config_get_default_news): ditto
(mail_config_get_news): ditto
(mail_config_add_news): ditto
* mail-config.h: Prototype new accessors. Config struct is now
in mail-config.c and hidden from the world.
2000-08-11 Dan Winship <danw@helixcode.com>
* mail-ops.c (describe_fetch_mail): Use camel_service_get_name
rather than showing the URL to the user.
2000-08-11 Peter Williams <peterw@helixcode.com>
* mail-ops.c (do_refile_messages): Freeze the folders while moving.
(do_flag_messages): Same.
* mail-threads.c (get_password_clicked): Fix the case when the
user /doesn't/ use escape to cancel the dialog :-/
(show_error_clicked): Same.
2000-08-11 Dan Winship <danw@helixcode.com>
* mail-tools.c (mail_tool_get_folder_name): Add a function to
return a useful name for a folder (not just "mbox" or "mh" for
any local folder.)
* mail-ops.c: Use mail_tool_get_folder_name rather than
folder->full_name when printing folder names.
2000-08-11 Not Zed <NotZed@HelixCode.com>
* mail-tools.c (mail_tool_get_local_inbox_url): Properly handle
different local file formats. The folder isn't always mbox.
(mail_tool_do_movemail): Movemail always uses an mbox format
however.
(mail_tool_get_local_movemail_url): What is the mbox url, it is
always the same type, mbox.
(mail_tool_fetch_mail_into_searchable): Same here.
* mail-local.c (mail_local_map_uri): Map a local uri to the real uri.
2000-08-10 Christopher James Lahey <clahey@helixcode.com>
* folder-browser-factory.c, message-list.c, message-thread.c,
session.c: Fixed some warnings.
2000-08-10 Dan Winship <danw@helixcode.com>
* session.c (session_init): Don't call e_setup_base_dir. It was
wrong and it doesn't exist any more.
* component-factory.c (owner_set_cb): Update for changed
prototype, and record the evolution_homedir. Move call to
mail_config_init here from session.c so it happens after
evolution_dir is initialized.
* mail.h: define "extern char *evolution_dir;" (formerly in
e-util/e-setup.h)
* component-factory.c, mail-callbacks.c, mail-config-gui.c,
mail-config.c, mail-display.c, mail-format.c, mail-ops.c,
mail-tools.c, session.c: Remove "e-util/e-setup.h" include.
2000-08-10 Peter Williams <peterw@helixcode.com>
* test-thread.c (queue_ops): Use mail_operations_terminate() to
close the other thread nicely.
* mail-threads.c (get_password_deleted): Handle the "close" event
as a cancel.
(show_error): Same.
2000-08-10 Dan Winship <danw@helixcode.com>
* mail-tools.c (mail_tool_get_folder_from_urlname): Add a
"gboolean create" argument to pass to camel_store_get_folder.
* mail-ops.c (do_create_folder, do_setup_draftbox):
* mail-local.c (mail_tool_local_uri_to_folder):
* mail-vfolder.c (vfolder_uri_to_folder): Add create flag to
mail_tool_get_folder_from_urlname calls.
2000-08-10 Jeffrey Stedfast <fejj@helixcode.com>
* mail-callbacks.c (composer_send_cb): Fix compile warning by
casting the object to a CamelObject
2000-08-10 Peter Williams <peterw@helixcode.com>
* mail-tools.c (mail_tool_filter_contents_into): Delete the source
folder if told to and if it's empty
(mail_tool_get_local_movemail_path): New function.
2000-08-10 Dan Winship <danw@helixcode.com>
* mail-callbacks.c (reply_to_all): Fix a bug in the async changes.
(This was identical to reply_to_sender.)
2000-08-10 Not Zed <NotZed@HelixCode.com>
* mail-local.c (do_local_reconfigure_folder): Update for
append_message api change.
* message-list.c (message_list_regenerate): Change for search api
change.
(ml_tree_value_at): Add a colour column, based on the colour
assigned in the summary.
(message_list_init_renderers): Init colour column.
2000-08-09 Peter Williams <peterw@helixcode.com>
* mail-display.c (part_for_url): Remove a gtk_object_get_data
2000-08-09 Cody Russell <bratsche@gnome.org>
* folder-browser-factory.c, mail-view.c: Make the toolbars
honor the user's gnomecc settings for detachable toolbars.
2000-08-09 Jeffrey Stedfast <fejj@helixcode.com>
* mail-ops.c (composer_send_cb): Get the from address set in the
composer, if that fails ONLY THEN get the default from mail config
* mail-config.c (mail_config_get_identities): New convenience
function for getting a list of the configured identities
2000-08-09 Dan Winship <danw@helixcode.com>
* mail-display.c (on_object_requested): Support controls as well
as embeddables.
2000-08-09 Jeffrey Stedfast <fejj@helixcode.com>
* mail-view.c (mail_view_create): Changed to only take a
FolderBrowser argument
* mail-ops.c (real_view_msg): Create a new FolderBrowser for each
message being opened in a new window. Also set the
message_list->cursor_uid and mail_display->current_message to the
appropriate values.
(real_view_msg): Updated to reflect changes in the mail_view_create
* message-list.c (on_right_click): Nicify a little, add in a menu
separator between VFolder and Filter stuff.
* mail-ops.c (real_view_msg): Set the UID of the message that is
being displayed
2000-08-09 Ettore Perazzoli <ettore@helixcode.com>
* folder-browser-factory.c (control_activate): Use
`GNOME_STOCK_MENU_*' things instead of `GNOME_STOCK_PIXMAP_*'
things, that are too big and look bad.
2000-08-09 Peter Williams <peterw@helixcode.com>
* mail-view.c (mail_view_create): Save the top window so that on_close
can find it [with set_data].
(on_close): Recover the top window.
* mail-threads.c (read_msg): Destroy the window instead of hiding it.
2000-08-09 Not Zed <NotZed@HelixCode.com>
* mail-autofilter.c (filter_gui_add_from_message): Helper function
to add with confirm.
(rule_match_recipients): Dont set real name if its empty for the
filter name.
(rule_match_subject): was cutting ] off mailing list names.
* message-list.c (on_right_click): Added menu to install
vfolders/filters from message.
2000-08-09 Not Zed <NotZed@HelixCode.com>
* mail-autofilter.c: New file to hold auto filter/vfolder stuff.
2000-08-09 Christopher James Lahey <clahey@helixcode.com>
* mail-display.c, mail-format.c, mail-ops.c: Fixed some warnings.
* message-list.c: Fix the call to e_popup_menu_run to match the
new signature.
2000-08-09 Ettore Perazzoli <ettore@helixcode.com>
* folder-browser-factory.c (control_activate): Create a "print
message" menu item.
2000-08-09 Jeffrey Stedfast <fejj@helixcode.com>
* message-list.c (message_list_init): Attached a double_click
signal handler
(on_double_click): Our lovely new double_click callback. Will
display the current selected message in a new window
2000-08-08 Jeremy Wise <jwise@pathwaynet.com>
* mail-config.[ch], folder-browser.c: Added configuration work to
save the size of the vpaned widget. It will be functional when the
e_paned widget emits a "resized" signal
2000-08-08 Jeffrey Stedfast <fejj@helixcode.com>
* mail-config.h: Added void as an argument to functions not
needing any parameters to avoid compile warnings.
2000-08-08 Jeremy Wise <jwise@pathwaynet.com>
* mail-config.[ch], main.c, folder-browser-factory.c: State of the
threaded list toggle is now saved via gnome_config
2000-08-08 Dan Winship <danw@helixcode.com>
* mail-config-gui.c (service_page_item_new): Attach a signal
handler to call the "changed" function when the user clicks the
"keep on server" checkbox.
2000-08-08 Jeffrey Stedfast <fejj@helixcode.com>
* mail-ops.c (view_msg): New convenience function with params of a
normal Gtk callback function. We also now create a new
FolderBrowser object so that the message-view window isn't tied to
the display in the main window
(view_message): Now calls view_msg (this function is a bonobo
callback and can't be used with gtk widgets)
(edit_msg): Same idea as view_msg()
(edit_message): Again, same as view_message()
* message-list.c (on_right_click): Callback for creating an
e-popup-menu
(message_list_init): Added a right_click event to trigger a pop-up
menu to be displayed
2000-08-08 Dan Winship <danw@helixcode.com>
* mail-config-gui.c: Add "Don't delete messages from server"
button to remote SOURCEs that aren't STORAGEs (ie, POP).
(provider_list): Only list SOURCEs. (ie, not mh)
* mail-config.c: Save/load "keep_on_server" flag.
* mail-ops.c (fetch_remote_mail): New function, split out of
real_fetch_mail. Deals with copying mail from a remote server into
a temporary mbox, possibly using a CamelUIDCache to leave the
messages on the server.
* mail-crypto.c, mail-format.c, message-thread.c: Fix some
compiler warnings.
* mail-format.c (mail_generate_reply): Fix up format of addresses.
(write_headers): Use CamelAddress functions to simplify this.
2000-08-08 Jeffrey Stedfast <fejj@helixcode.com>
* mail-view.c: Lets get rid of the last separator in the toolbar
until we add n/p
2000-08-08 Ettore Perazzoli <ettore@helixcode.com>
* mail-threads.c (queue_window_delete_event_cb): Callback for
"delete_event", just doing nothing.
(create_queue_window): Connect it to the "delete_event" signal of
the progress dialog.
2000-08-08 Peter Williams <peterw@helixcode.com>
* mail-threads.c (remove_next_pending): Sanity check for
job queue, which seems to have some issues.
(read_msg): Make sure that the next operation isn't started
before the last one is cleaned up.
* mail-callbacks.c (fetch_mail): Fix erroneous free.
* mail-config-gui.c (mail_config_druid): Wrap the gtk_main call.
* mail-ops.c (do_flag_messages): Allow specification of whether
to set the flags unconditionally or toggle their current state.
* message-list.c (ml_tree_set_value_at): Toggle the seen status;
don't set it unconditionally.
* mail-callbacks.c (delete_msg): Toggle the deletion status;
don't set it unconditionally.
* mail-tools.c (mail_tool_do_movemail): Fix for undeclared tmpfd.
* mail-local.c (local_reconfigure_folder): Big rewrite; make into
an asynchronous operation. Use some mail tools to make life easy.
2000-08-08 Dan Winship <danw@helixcode.com>
* main.c (main): Move mail_config_init after session_init, since
it depends on evolution_dir being set.
2000-08-08 JP Rosevear <jpr@helixcode.com>
* mail-ops.c (check_configured): Use config accessors
(fetch_mail): ditto
(composer_send_cb): ditto
(create_msg_composer): ditto
* mail-config-gui.h: Update API
* mail-config.h: Update API
* mail-config.c: Add accessor functions
(mail_config_is_configured): accessor function
(mail_config_get_default_identity): ditto
(mail_config_get_default_source): ditto
(mail_config_get_transport): ditto
(mail_config_send_html): ditto
(identity_copy): Make public
(identity_destroy): ditto
(identity_destroy_each): ditto
(service_copy): ditto
(service_destroy): ditto
(service_destroy_each): ditto
(mail_config_init): Rename from init_config and make public
(mail_config_clear): Rename from clear_config and make public
(mail_config_read): Rename from read_config and make public
(mail_config_write): Reanme from write_config and make public
* main.c (main): Call mail_config_init.
* mail.h: Include mail-config-gui.h
* mail-config-gui.c: Move config gui stuff here.
(source_dialog): Kill memory leak from debug leftovers.
Make sure returned source is NULL by default
2000-08-07 Not Zed <NotZed@HelixCode.com>
* mail-local.c (local_reconfigure_folder): Redone to show a
dialogue first, and show progress of whats happening as its done.
* Makefile.am (glade_DATA): Added local-config.glade, for mailbox
reconfig dialogue.
2000-08-04 Not Zed <NotZed@HelixCode.com>
* folder-browser.c (mail_uri_to_folder): Use local_uri_to_folder()
for local uri's (file://).
* mail-local.c (local_uri_to_folder): Handle looking up folder
storage type before opening the store/folder.
(local_reconfigure_folder): Function to reconfigure the format of
a local mailbox into another storage format.
* Makefile.am (evolution_mail_SOURCES): Added mail-local.c and
missing mail-vfolder.h.
2000-08-07 Jeffrey Stedfast <fejj@helixcode.com>
* Makefile.am: Added mail-view.c
* folder-browser-factory.c (control_activate): Adda menu item for
viewing the message
* mail-view.c: New file containing methods for viewing messages in
separate windows
* mail-ops.c (view_message): New callback for viewing messages in
a new window.
2000-08-07 Jeffrey Stedfast <fejj@helixcode.com>
* component-factory.c (real_create_generic_storage): New function
to replace real_create_imap_storage and real_create_news_storage
(create_imap_storage): Updated.
(create_news_storage): Updated.
2000-08-07 Peter Williams <peterw@helixcode.com>
* mail-ops.c (cleanup_edit_messages): New operation: edit_messages
For continuing draft messages.
(attach_messages): Fix accidental 0 datasize.
(do_setup_draftbox): New operation: setup_draftbox. Soooo hacky.
* mail-callbacks.c: Move fejj's edit message to the async home.
* component-factory.c (owner_set_cb): Use mail_do_setup_draftbox.
2000-08-07 Jeffrey Stedfast <fejj@helixcode.com>
* mail-display.c:
* component-factory.c: s/strncasecmp/g_strncasecmp
* mail-format.c (write_headers): Get rid of kludge around subject
beginning with spaces.
(mail_generate_reply): Get rid of kludge around subject beginning
with spaces and also use g_strncasecmp instead of strncasecmp for
portability
* mail-ops.c (forward_msg): Get rid of kludges around subject
beginning with spaces.
2000-08-07 Dan Winship <danw@helixcode.com>
* message-list.c (message_list_select): Clarify that the input row
is a model row, and swap it to a view row when finding the
next/previous row.
(idle_select_row): Select view row 0, not model row 0.
* mail-ops.c (select_first_unread): Start from view row 0, not
model row 0.
2000-08-07 Jeffrey Stedfast <fejj@helixcode.com>
* mail-format.c (mail_get_message_body): Renamed from reply_body()
so other functions can use it
(mail_generate_reply): Updated to reflect function name changes
* mail-ops.c (real_edit_msg): Attach a callback to the send signal
2000-08-07 Jeffrey Stedfast <fejj@helixcode.com>
* folder-browser-factory.c (control_activate): New menu item under
Actions to allow editing of messages.
* mail-ops.c (edit_message): New function for editing messages.
* component-factory.c (owner_set_cb): Create a global reference to
the Drafts mbox folder for the Composer to use
2000-08-06 JP Rosevear <jpr@helixcode.com>
* mail-config.c (ndialog_page_undone): Desensitize ok button
(sdialog_page_undone): ditto
(iddialog_page_undone): ditto
(news_page_new): Typo - news, not mail
(transport_page_new): Typo - transport, not source
(identity_dialog): Set undone callback
(source_dialog): ditto
(news_dialog): ditto
(mail_druid_identity_undone): Desensitize next button and
mark done flag as false
(mail_druid_source_undone): ditto
(mail_druid_transport_undone): ditto
(mail_druid_identity_done): Mark done flag as true
(mail_druid_source_done): ditto
(mail_druid_transport_done): ditto
(mail_druid_prepare): Use done flag to set next button
sensitivity, fixes #467
2000-08-06 Jeffrey Stedfast <fejj@helixcode.com>
* mail-crypto.c (mail_crypto_openpgp_encrypt): Added support for
encrypting with GnuPG. Support for PGP5 and PGP2 are still in
progress.
2000-08-05 Dan Winship <danw@helixcode.com>
* folder-browser-factory.c (control_activate): Remove bonobo 0.15
vs 0.15-and-a-half ifdef, since we require post-0.16 now.
2000-08-04 Dan Winship <danw@helixcode.com>
* mail-threads.c (mail_operation_wait_for_finish): Don't use
"while (gtk_events_pending ()) gtk_main_iteration ();" inside
another tight loop, because it makes the thread spin rather than
blocking and waiting like it should.
2000-08-04 Peter Williams <peterw@helixcode.com>
* message-thread.c (do_thread_messages): Uninitialized variable
fix.
* mail-threads.c (read_msg): Small leak fix.
* component-factory.c (owner_unset_cb): Use mail_operations_
terminate() instead of wait_for_finish().
* mail-threads.c (mail_operation_queue): Centralize the clur
handling functions; fix a race condition where the dispatcher
would overwrite the closure before the main thread could
free the old one.
(mail_operations_terminate): New function, wait for ops to
finished and kill the other thread.
(dispatch): changes to die when terminate is called (abort
on NULL spec).
* mail-ops.c (cleanup_display_message): Fix improper handling
of displaying a NULL message (which means clear the message
display).
2000-08-04 Ettore Perazzoli <ettore@helixcode.com>
* message-list.c (message_list_regenerate): Free the GPtrArray
correctly instead of using `g_strfreev()'.
2000-08-04 Michael Meeks <michael@helixcode.com>
* folder-browser-factory.c (control_activate): release the ui_handler
after set_container.
2000-08-03 Michael Meeks <michael@helixcode.com>
* mail-config.c (identity_page_new): only whack the sig in if the
file exists.
* component-factory.c (factory_fn): count running instances,
attach destroy signal (factory_destroy): add.
* main.c (main): pass orb around.
2000-08-03 Jeffrey Stedfast <fejj@helixcode.com>
* mail-ops.c (composer_send_cb): Yay, no more compiler warnings
* mail-config.c: set config = NULL
(provider_list) Eek! Initialize news to NULL! Also, use
g_slist_prepend() for "performance" gains ;-)
(init_config): Set the config member data to NULL just to be on
the safe side
(clear_config): Don't bother freeing slist data if the slist is
NULL
2000-08-03 Peter Williams <peterw@helixcode.com>
* mail-ops.c (op_forward_messages): Use the new dynamic
operation naming.
* message-thread.c (describe_thread_messages): Ditto.
* message-list.c (describe_regenerate_messagelist): Ditto.
* mail-threads.c (get_password_clicked): Dynamic generation
of descriptive text for mail operations. "Opening a folder" ->
"Opening INBOX". Supported only so far, will be implemented
quickly.
g_strdup() the old_message when changing the queue_window_label's
text.
* main.c (main): One more gconf reference to take out...
* mail-ops.c (composer_send_cb): Check for an identity before
sending.
2000-08-03 JP Rosevear <jpr@helixcode.com>
* mail-config.glade: Increase window size slightly, rename
"Transport" to "Mail Transport"
* mail-config.c (init_config): Remove gconf references
(clear_config): ditto
(read_config): ditto
(write_config): ditto
(mail_config): Null provider lists before filling them
(mail_config_druid): ditto
(identity_page_new): Increase spacing of vbox
(service_page_new): ditto
* Makefile.am: Remove gconf references.
2000-08-02 Dan Winship <danw@helixcode.com>
* mail-config.c (service_page_item_new): Make the "test settings"
button FILL rather than SHRINK so it doesn't end up oddly-placed.
* mail-config-druid.glade: Make the icon background dark blue
like the surrounding area.
2000-08-02 Peter Williams <peterw@helixcode.com>
* component-factory.c (owner_unset_cb): Wait for async operations
to finish before exiting.
2000-08-02 Christopher James Lahey <clahey@helixcode.com>
* mail-ops.c, message-list.c: Emit "model_pre_change" where
appropriate.
2000-08-02 Peter Williams <peterw@helixcode.com>
* mail-config.h: #ifdef _MAIL_CONFIG_H protect the header.
2000-08-01 Peter Williams <peterw@helixcode.com>
* mail-threads.c: Implement Solaris threads. Attempt
to join to the thread upon exit -- hopefully prevents
all those nasty zombie processes from popping up :-(
2000-08-01 Dan Winship <danw@helixcode.com>
* mail-crypto.c: New code to spawn off GPG/PGP to do stuff.
Currently only deals with decryption. From Nathan Thompson-Amato
<ndt@jps.net>, with bunches of changes from me.
* session.c (mail_request_dialog): Expose the password dialog to
the rest of the app (for use by the GPG/PGP code).
* mail-format.c (handle_text_plain): Handle special inline data
types. (Currently uuencoding, BinHex, and PGP encryption.) This is
not the best way to deal with it, but it works for now.
(try_inline_pgp): Convert an inline PGP-encrypted message into a
multipart/encrypted part.
(try_inline_binhex): Convert an inline BinHex attachment into an
application/mac-binhex40 part (which we currently don't deal
with...)
(try_uudecoding): Convert a uuencoded attachment to an
application/octet-stream part.
(handle_multipart_encrypted): Deal with RFC2015 MIME-encoded PGP
encrypted messages. (From ndt.)
* mail-display.c (mail_text_write, mail_error_write): New utility
functions.
* Makefile.am (evolution_mail_SOURCES): add mail-crypto.c
2000-07-31 Christopher James Lahey <clahey@helixcode.com>
* component-factory.c, folder-browser.c: Fixed some warnings.
* message-list.c: Made the icon column non sortable.
2000-07-31 Dan Winship <danw@helixcode.com>
* mail-config.c (service_page_set_url): Fix a NULL-pointer strcmp
noticed by peterw.
2000-07-31 Not Zed <NotZed@HelixCode.com>
* mail-vfolder.h: Header for vfolder functions.
* folder-browser.c (mail_uri_to_folder): Use new scheme to open
vfolders.
(search_save): New button/function to save a search as a vfolder.
* mail-vfolder.c (vfolder_edit): Made asynchronous.
(vfolder_uri_to_folder): New function for loading vfolders and
setting up their source folders.
(vfolder_refresh): Change shell vfolder uri's to indirect
references rather than the real vfolder uri.
(vfolder_gui_add_rule): Add a rule with user confirmation.
(vfolder_create_part): Get a new part by name, for creating rules
in code.
* message-thread.c (thread_messages): Check for uid lookup
failure, which indicates an error in the folder or calling code.
2000-07-29 Not Zed <NotZed@HelixCode.com>
* component-factory.c (create_view): Remove hack to pass the
storage around.
* folder-browser-factory.c (control_activate): Changed to call
renamed vfolder editor.
* mail-ops.c (vfolder_edit_vfolders): renamed from vfolder_edit,
call new edit function.
(vfolder_editor_clicked): Removed.
(filter_druid_clicked):
(filter_edit): Updated for api change.
(real_fetch_mail): Fixed up for api change and fucked up indent.
(filter_get_folder): callback for filter driver.
* mail-vfolder.c: New file to manage virtual folders.
2000-07-29 JP Rosevear <jpr@helixcode.com>
* mail-format.c (mail_generate_reply): Use new mail config stuff
* component-factory.c (create_imap_storage): Use new mail config
stuff
(create_news_storage): ditto
* evolution-mail.schemas: Gconf schema for evolution mail
* mail-config-druid.glade: Gladification of config druid
* mail-config.h: New header with config structs.
* mail-config.c: Rewrite of GUI configuration tools to use
new config structs. Stores multiple identities and sources now.
Still only uses the first one found.
(mail_config_fetch): Returns MailConfig struct to caller
for configuration queries.
(mail_config): Renamed function to show mail config dialog.
(mail_config_druid): Renamed function to show mail config druid.
* mail-ops.c (create_msg_composer): Use
e_msg_composer_new_with_sig_file and new config stuff
(check_configured): Use new config stuff
(fetch_mail): ditto
(composer_send_cb): ditto
2000-07-28 Cody Russell <bratsche@gnome.org>
* mail-ops.c, mail.h: Added mark_all_seen(), to mark every
message in the list with CAMEL_MESSAGE_SEEN.
* folder-browser-factory.c: Added "Actions/Mark all seen".
2000-07-27 Jeffrey Stedfast <fejj@helixcode.com>
* mail-config.c: Lets fix Dan's kludge the Right Way (tm)
(set_service_url): Only strip off the leading "/" from the
url->path if url->host is NULL
(get_service_url): Only prepend a leading "/" to the path if the
host is NULL
2000-07-27 Dan Winship <danw@helixcode.com>
* mail-config.c (get_service_url): toss in a kludge to deal with
the IMAP vs mbox path problem for now.
2000-07-26 Christopher James Lahey <clahey@helixcode.com>
* message-list.c, message-list.h: Removed counting of selected
messages.
2000-07-26 Dan Winship <danw@helixcode.com>
* mail-ops.c (real_fetch_mail): Don't create the tmp_mbox before
calling movemail, because the external movemail requires it to not
exist. Contrariwise, delete it in the cleanup code if it's empty.
Update for camel_movemail interface change. Do the "No new
messages" dialog in the mbox case as well as the remote mail
issue.
2000-07-26 Jeffrey Stedfast <fejj@helixcode.com>
* mail-ops.c: s/struct refile_data/struct move_data
(real_move_msg): Renamed from real_refile_msg()
(move_msg): Renamed from refile_msg()
* folder-browser-factory.c: Changed Refile to Move.
2000-07-26 Dan Winship <danw@helixcode.com>
* mail-format.c (lookup_handler): Update for OAF and for external
apps as well as components.
(handle_via_external): Handler to set up for data that can be
displayed by an external application.
* mail-display.c (on_link_clicked, etc): Refactor the save_data()
code and add launch_external() as a handler for
x-evolution-external URLs.
(embeddable_destroy_cb): Remove this, since it seems like it's all
wrong.
(on_object_requested): Update for OAF, and fix some bugs.
2000-07-25 Jeffrey Stedfast <fejj@helixcode.com>
* mail-config.c (get_service_url): Always prepend a leading "/" to
the url->path.
(set_service_url): Added more error checking and also strip the
leading '/' from the url->path
(create_identity_page): Set the signature file to the one specified in
the identity record, else set the default path to ~/.sugnature
2000-07-25 Michael Meeks <michael@helixcode.com>
* mail-config.c (create_identity_page): set default signature to
~/.signature
2000-07-25 Peter Williams <peterw@helixcode.com>
* mail-ops.c (reply): Check for the case of fb->mail_display->
current_message = NULL, which shouldn't happen, but has happened
to me.
2000-07-25 Dan Winship <danw@helixcode.com>
* message-thread.c (group_root_set): Don't group together messages
with the same non-Re: subject and no References/In-Reply-To. More
often than not, they're unrelated. (eg, "[No subject]".)
(thread_messages): Handle messages with no Message-Id. "This
shouldn't happen", but it does sometimes, and it's not much code
to make it just work.
2000-07-25 Ettore Perazzoli <ettore@helixcode.com>
* mail-config.c (create_service_page): Call
`gtk_option_menu_set_menu()' as the last thing, as `GtkOptionMenu'
is fscking broken. Also, `gtk_widget_show()' the individual menu
items.
2000-07-24 Dan Winship <danw@helixcode.com>
* message-list.c (mark_msg_seen, ml_tree_set_value_at,
message_list_regenerate): Update for CamelFolder API changes.
(Certain functions no longer take a CamelException.)
* mail-ops.c (real_fetch_mail, real_send_mail, real_delete_msg):
ditto
* component-factory.c (real_create_imap_storage,
real_create_news_storage): ditto
2000-07-24 Dan Winship <danw@helixcode.com>
* component-factory.c, folder-browser-factory.c, test-mail.c:
Remove GOAD support.
* main.c: Remove GOAD support.
(main): More "guess the build mistake" fun, this time for the
failure to initialize Bonobo case.
2000-07-24 Peter Williams <peterw@helixcode.com>
* mail-tools.c (mail_tool_set_uid_flags): Change
function to faithfully pass parameters to
camel_folder_set_message_flags; this function is
somewhat useless now. Other files synced with
API change.
* mail-ops.c (op_display_message): Change "display
a message" into "retrieve a messsage" in the
description of mail_op_display_message.
* mail-threads.c (display_timeout): New function.
Only display the progress dialog if the operation
takes more than a second to perform.
(hide_queue_window): New function. Hide the queue
window as an idle function... I'm thinking maybe
the problem with hiding it was due to us not
being in a GTK event sequence? Perhaps it's only
the timeout, which was not being cancelled, which
is now.
* message-list.c (get_message_uid): New function,
copy of get_message_info, except gets only the
UID, as that's all that most functions want, and
we avoid a Camel call.
2000-07-23 Ettore Perazzoli <ettore@helixcode.com>
* mail-ops.c (create_message_composer): New.
(compose_msg): Use it.
(send_to_url): Likewise.
(forward_msg): Likewise.
* folder-browser-factory.c (control_activate): Use `_()' instead
of `N_()'.
2000-07-21 Peter Williams <peterw@helixcode.com>
* message-thread.c (setup_thread_messages): New
operation: thread_messages, simple wrapper around
thread_messages () and thread_messages_free();
* message-list.c (cleanup_regenerate_messagelist):
Use new thread_messages operation instead of just
calling ... thread_messages :-)
* folder-browser.c (folder_browser_destroy): Use new
sync_folder operation instead of calling camel_folder_sync
directly.
* component-factory.c (create_folder): Changed to use
new create_folder operation.
* mail-ops.c (mail_do_create_folder): New operation: create
folder. New operation: sync folder.
* mail-format.c (cmm_destroyed): Remove the url hashtable from
the larger hashtable when it gets destroyed.
* mail-callbacks.c (fetch_mail): Pass a hook function and data
down the chain to pick up the folder_changed and change the view.
* mail-ops.c: Rename from mail-ops-new.c now that it's a little more
solid.
(fetch_mail): Add new options to hook and unhook an event while the
filter driver runs. A hack, but all of the operations are to some
extent.
(cleanup_fetch_mail): Unref the destination folder if not NULL.
* mail-tools.c (mail_tool_filter_contents_into): Intermediate the
event hook/unhook hack here.
2000-07-20 Peter Williams <peterw@helixcode.com>
* mail-ops-new.c (setup_send_mail): Fix silly forgetting-to-ref
problem on some sends (when not replying). Note the early exit
path with a big comment.
* message-list.c (message_list_set_folder): Don't call
folder_changed, call mail_do_regenerate_messagelist, as
the GDK_THREADS_ENTER in the former can deadlock us!
* folder-browser.c (folder_browser_set_uri): Ah, screw it.
Make 'load folder' asynchronous and pretend that it always
succeeds.
* mail-ops-new.c (mail_do_load_folder): New operation, loads
a folder into a FolderBrowser.
* mail-threads.c (read_msg): Check if the exception is
a user cancel; don't complain if it is.
(mail_operation_queue): Same.
(dispatch_func): Same.
2000-07-20 Peter Williams <peterw@helixcode.com>
* mail-ops-new.c (cleanup_send_mail): Fix evil mistaken
unref.
* test-thread.c: Fit the new mail_operation_spec prototype.
* mail-callbacks.c (composer_send_cb): Hide the composer upon
start of send operation.
* folder-browser.c: #include "mail-ops-new.h"
* mail-threads.h: Change text fields of mail_operation_spec to
provide two forms of the name.
* mail-threads.c: Use appropriate new string fields.
(dispatch_func): Hide the progressbar by default.
* message-list.c (op_regenerate_messagelist): Fix the datasize from
0 -> sizeof (regenerate_messagelist_data_t). Add the new gerund and
infinitive strings.
(do_regenerate_messagelist): Include some code that fell between the
cracks.
* mail-ops-new.c (op_scan_subfolders): Same datasize fix for
scan_subfolders.
(op_forward_message): Same.
(all): Add new gerund and inifinitive strings for mail_operation_spec.
(cleanup_send_mail): Destroy the composer on success; re-show it on
error. I'm so clever!
2000-07-20 Ettore Perazzoli <ettore@helixcode.com>
* component-factory.c (factory_fn): Updated for the new
`evolution_shell_component_new()' arg.
2000-07-19 Jeffrey Stedfast <fejj@helixcode.com>
* message-thread.c (thread_messages): What if message info is NULL?
2000-07-17 Peter Williams <peterw@helixcode.com>
* component-factory.c (real_create_{imap,news}_storage): Instead of
directly calling evolution_storage_new_folder, queue up a list of
folders to register so that we don't do our CORBA in The Other Thread.
(create_{imap,news}_storage): Changes ancillary to the above.
(add_new_mailbox): New function to queue up a folder
(cleanup_create_info): New function to dequeue the folders and free mem.
* test-thread.c: s,ENABLE_BROKEN_THREADS,USE_BROKEN_THREADS -- oops
* mail-format.c: (mail_lookup_url_table): New function to get the url
table associated with a CamelMimeMessage because we can no longer
gtk_object_get_data on it.
* mail-display.c: replace 'gtk_object_get_data( message, "urls" )'
with 'mail_lookup_url_table( message )'
2000-07-16 Jeffrey Stedfast <fejj@helixcode.com>
* folder-browser.c, component-factory.c: Initial code to support
IMAP folders that don't use "/" as a directory separator.
2000-07-15 Ettore Perazzoli <ettore@helixcode.com>
* mail-ops.c (set_x_mailer_header): New helper function to set the
`X-Mailer:' header to to `Evolution <version> [Developer
Preview]".
(real_send_mail): Call it.
2000-07-14 Peter Williams <peterw@curious-george.helixcode.com>
* message-list.c (message_list_set_folder): Ported to CamelObject:
GTK_OBJECT->CAMEL_OBJECT; gtk_signal_connect->camel_object_hook_event;
GDK_THREADS_ENTER/LEAVE around "changed" event hooks.
* folder-browser.c (folder_browser_destroy): likewise.
(mail_uri_to_folder): likewise.
(folder_browser_load_folder): likewise.
2000-07-14 Ettore Perazzoli <ettore@helixcode.com>
* Makefile.am (evolution_mail_LDADD): Add `GCONF_LIBS'.
2000-07-14 Dan Winship <danw@helixcode.com>
* mail-format.c (write_headers): put a <p> at the end of the
header table. (I think there used to be whitespace after it, but
then some gtkhtml change got rid of it...)
(handle_text_plain): Don't do this <PRE>. Instead, CONVERT_NL and
CONVERT_SPACES and wrap it in <TT>. Now if the sender didn't
include any newlines, it will be wrapped to the width of the
window instead of extending off into infinity.
2000-07-13 Dan Winship <danw@helixcode.com>
* message-list.c (message_list_destroy): Only unref the folder if
it's been set.
* folder-browser.c (folder_browser_destroy): Only sync the folder
if it's been set.
2000-07-13 Jonathan Blandford <jrb@redhat.com>
* mail-config.c (create_transport):
s/CAMEL_SERVICE_NEED_HOST/CAMEL_SERVICE_URL_NEED_HOST.
2000-07-13 Dan Winship <danw@helixcode.com>
* mail-config.c (add_row): Add a "gboolean required" argument, and
set its value on the entry.
(create_source, create_transport): Create rows for URL elements if
the URL ALLOWs them. Mark them required if it NEEDs them.
(service_note_doneness): Only require the required fields to be
filled in.
Now the IMAP config page allows the user to enter a path, but
doesn't require it.
2000-07-13 Jeffrey Stedfast <fejj@helixcode.com>
* mail-ops.c (real_fetch_mail): Back to the old way to avoid
g_warnings, yay. Also fix append to send a flags argument (0)
2000-07-12 Chris Toshok <toshok@helixcode.com>
* mail-config.c (providers_config_new): fix some cut & paste bung.
2000-07-12 Chris Toshok <toshok@helixcode.com>
* mail-format.c (setup_function_table): add "message/news" to the
mime_function_table using the same handler as message/rfc822.
2000-07-12 Chris Toshok <toshok@helixcode.com>
* mail-config.glade*: add news server tab to dialog.
* mail-config.c (on_NewsServerConfigDialogButton_clicked): new function.
(on_clistNewsServers_select_row): new function.
(on_cmdNewsServersAdd_clicked): new function.
(on_cmdNewsServersEdit_clicked): new function.
(on_cmdNewsServersDelete_clicked): new function.
(providers_config_new): mirror the source tab's code to fill in
the news server tab.
(write_config): save out the news server.
(create_news_server_config_dialog): new function.
(create_news_server_page): new function.
2000-07-12 Peter Williams <peterw@helixcode.com>
* mail-display.c (save_data): Change from evolution_dir to
g_get_home_dir() for default location of save file.
2000-07-11 Dan Winship <danw@helixcode.com>
* Update for CamelFolder API changes
2000-07-11 Jeffrey Stedfast <fejj@helixcode.com>
* mail-ops.c (real_fetch_mail): Changed to use
camel_folder_move_message_to () rather than get_message () and then
append_message (). This also makes it so we don't have to worry about
fetching message flags to pass to the new append_message () method.
* folder-browser.c (folder_browser_load_folder): Disable
Search capability menu/entry if folder doesn't support it.
* message-list.c (message_list_regenerate): Don't perform
a search if the folder doesn't support it.
2000-07-11 Dan Winship <danw@helixcode.com>
* mail-ops.c (real_send_mail): Set the post_send_data flag rather
than toggling it. (Maybe we'll need more control over it later,
but for now, the only flag we set is "replied", and we want
that set, not toggled.)
2000-07-10 Dan Winship <danw@helixcode.com>
* folder-browser-factory.c (control_activate): Work with both
current and 0.15 bonobo
* kill more debugging messages
* mail-ops.c (real_fetch_mail): Don't multiply free dest_url.
* message-list.c (message_list_select): Update
message_list_select_next to do either next or previous.
* folder-browser.c (etable_key): Make 'n' and 'p' do next and
previous unread message.
* mail-ops.c (select_first_unread): Update.
(real_fetch_mail): clean up a bit.
2000-07-10 Ettore Perazzoli <ettore@helixcode.com>
* mail-ops.c (forward_msg): Initialize `fwd_subj' to NULL if
`from' is NULL.
2000-07-10 Jeffrey Stedfast <fejj@helixcode.com>
* mail-ops.c (real_fetch_mail): Fixed broken POP fetching
2000-07-10 Ettore Perazzoli <ettore@helixcode.com>
* component-factory.c: Removed variable `browsers'.
(create_view): Don't update it.
(owner_unset_cb): Don't sync the folders here anymore, because at
this point the folder browser is dead already so we cannot get a
valid list of folders from it anymore.
* folder-browser.c (folder_browser_destroy): Sync the associated
mailbox first.
2000-07-10 Christopher James Lahey <clahey@helixcode.com>
* message-list.c, message-list.h: Switched from ETable to
ETableScrolled.
2000-07-10 Jeffrey Stedfast <fejj@helixcode.com>
* mail-ops.c (real_fetch_mail): Fixed movemail so that it too would
deliver to Inbox.
2000-07-09 Dan Winship <danw@helixcode.com>
* message-list.c (get_message_info): Don't g_warn if the user
selects a fake tree parent.
(message_list_select_next): Ignore fake rows
(build_tree): Store the "root_subject" for fake rows
(ml_tree_value_at): Display the correct subject for fake rows.
(on_cursor_change_cmd): Update for the other changes and set
cursor_uid to NULL when the cursor is on a fake row.
* mail-ops.c (reply): Don't try to reply when no (real) message is
selected.
(forward_msg): Ditto.
2000-07-09 Christopher James Lahey <clahey@helixcode.com>
* message-list.c: Remove setting of dnd_code since that's handled
internally to ETable.
2000-07-08 Dan Winship <danw@helixcode.com>
* folder-browser.c (etable_key): Fix up the pageup/pagedown
increment a bit.
* folder-browser-factory.c (control_activate): Add a "Threaded
Message List" item to the "View" menu.
* message-list.c (message_list_toggle_threads): Handler for that.
(build_flat): New function to build a "flat" message list using
the tree model.
(message_list_regenerate): Build tree or flat message list
depending on the global setting.
* message-thread.c (get_root_subject): fix a "Re:" parsing bug
2000-07-08 Jeffrey Stedfast <fejj@helixcode.com>
* mail-ops.c (real_fetch_mail): Always dump incoming messages to
Inbox (assuming not filtered to another location).
2000-07-08 Ettore Perazzoli <ettore@helixcode.com>
* folder-browser-factory.c (control_activate): Move the
"Expunge" item to the "Action" menu.
(control_deactivate): Accordingly.
2000-07-08 Dan Winship <danw@helixcode.com>
* mail-ops.c (forward_msg): Deal with having multiple selected
messages.
* mail-format.c (mail_generate_forward): Removed. (Integrated into
forward_msg)
2000-07-08 Jeffrey Stedfast <fejj@helixcode.com>
* message-list.c (build_tree): Small fix to stop uid data from
being set on a message-list tree node when it didn't correspond
to an actual message.
2000-07-08 Dan Winship <danw@helixcode.com>
* message-list.c (get_message_info): Fix Jeff's FIXME: This does
get called with out-of-range data sometimes, so we do need the
check. Use e_table_model_row_count to get the actual right answer.
2000-07-07 Jeffrey Stedfast <fejj@helixcode.com>
* message-list.c (get_message_info): This wasn't quite right, it
will now work but still isn't perfect. See FIXME comment.
2000-07-07 Dan Winship <danw@helixcode.com>
* message-thread.c (remove_node): Add another argument "clast"
pointing to the container before the current one in the list,
which it can update if that turns out to be the one that it
removed.
(group_root_set): Update for remove_node change, and remove both
nodes in the "subjects are common" case. Fixes a bug that would
cause the message list to be truncated if this rule was invoked.
(sort_node): sort the tree by the original order of the messages
in the folder rather than by date.
2000-07-07 Dan Winship <danw@helixcode.com>
* message-list.c: Lots of changes. Store uids as node data on the
tree nodes and use those rather than rows where possible. (The
concept of "row" is just getting too complicated.) Get rid of the
summary_table, because given a uid we can call
camel_folder_get_message_info, which makes more sense than keeping
a separate uid->row hash table ourselves.
(get_message_info): update
(get_message_row): removed
(ml_col_cound, ml_row_count, ml_value_at, ml_set_value_at,
ml_cell_is_editable, ml_duplicate_value, ml_free_value,
ml_initialize_value, ml_value_is_empty, ml_value_to_string):
Removed. We always use the tree model now.
(message_list_init): Remove the non-tree code.
(build_tree): store uids in the tree rather than row numbers,
and build the message_list->uid_rowmap to map from uids to rows
when needed.
(message_list_regenerate): Renamed from _set_search, since it's
used to redraw in non-search cases too.
(message_changed): Use the uid_rowmap to get a model row number.
* message-thread.c (thread_messages): Change the interface on this
to work with the new MessageList.
* folder-browser.c (search_set, folder_browser_clear_search):
s/message_list_set_search/message_list_regenerate/
2000-07-07 Christopher James Lahey <clahey@helixcode.com>
* message-list.c (get_message_info): Handle a row number of -1
properly.
2000-07-06 Dan Winship <danw@helixcode.com>
* message-list.c (get_message_info): Map tree model row numbers to
summary row numbers.
(ml_tree_value_at, ml_tree_set_value_at,
ml_tree_is_cell_editable): So don't do that here.
2000-07-06 JP Rosevear <jpr@arcavia.com>
* mail-config.glade*: Glade files for the configuration dialog.
* mail-config.c (providers_config_new): Build the dialog with
glade.
2000-07-06 Dan Winship <danw@helixcode.com>
* folder-browser-factory.c, folder-browser.c, mail-ops.c,
message-list.c: fix warnings.
* main.c (main): gtkhtmllib_init is no more. Call gconf_init
directly instead.
* message-list.c (message_list_select_next): New function to
select the first message on or after the given row that meets
certain flag criteria.
* mail-ops.c (real_fetch_mail): call message_list_select_next to
select first unread message in current folder if it changes.
(real_delete_msg): Remove the code to move the etable cursor. It
only makes sense really if you deleted the message with the
keyboard, so do it from etable_key.
* folder-browser.c (etable_key): call message_list_select_next to
select next non-deleted message after Delete.
* mail-identify.c: Add a workaround for a small gnome-vfs 0.2 bug
so we don't need to require CVS gnome-vfs.
2000-07-06 Not Zed <NotZed@HelixCode.com>
* message-thread.c (sort_thread): sort messages based on date for
the initial sort order.
(thread_messages_free): Implement.
* message-list.c (message_list_init_header): Setup the subject
renderer to a tree in tree mode.
(on_cursor_change_cmd): For a tree model, map the view row to the
data row.
(build_tree): Builds the tree data structure of all messages.
(message_list_set_search): For a tree model, build the tree here.
(ml_tree_icon_at): Icon callback, returns nothing.
(ml_tree_value_at):
(ml_tree_set_value_at):
(ml_tree_is_cell_editable): Maps tree node to data row, and calls
the equivalent table callback
(message_list_init_renderers): Setup the tree renderer if needed.
(message_list_init): set the root node invisible afterall.
(message_list_set_search): Clear the old tree before putting in a
new one.
* message-list.h: Add a tree renderer to render list, and
tree_view indicator.
* message-thread.[ch]: Code for message threading.
2000-07-05 Dan Winship <danw@helixcode.com>
* mail-identify.c (mail_identify_mime_part): Oops. My gnome-vfs
was out-of-date. Update for changed function name.
2000-07-05 Dan Winship <danw@helixcode.com>
* mail-identify.c (mail_identify_mime_part): Use the gnomevfs
sniff buffer interface to try to identify the MIME type when
everything else fails.
* mail-display.c (on_object_requested):
* mail-format.c (lookup_handler, handle_undisplayable,
handle_audio): s/gnome_mime/gnome_vfs_mime/
* Makefile.am: Add gnomevfs stuff
2000-07-03 Ettore Perazzoli <ettore@helixcode.com>
* component-factory.c (create_folder): Get rid of a compiler
warning by making sure `folder' is always initialized to some
value for any code path.
2000-07-03 Dan Winship <danw@helixcode.com>
* message-list.c (select_msg): call mail_display_set_message with
NULL if the message we tried to select doesn't exist (probably
meaning we tried to selecte the first message and the folder is
empty.)
* mail-display.c (mail_display_set_message): deal with NULL as an
input (meaning "undisplay previous message and display nothing").
2000-07-02 Dan Winship <danw@helixcode.com>
* mail-ops.c (real_fetch_mail): Remove hack to redisplay the
inbox, since folder_changed signals will now be emitted
appropriately.
* component-factory.c (create_vfolder_storage): Fix
filter_driver_new invocation.
* Makefile.am (bin_PROGRAMS): test-mail and test-thread should be
noinst.
* mail-ops.c (real_fetch_mail):
(vfolder_editor_clicked):
* component-factory.c (create_vfolder_storage):
Pass mail_uri_to_folder and rules to filter_driver_new.
2000-07-02 Ettore Perazzoli <ettore@helixcode.com>
* folder-browser.c (mail_uri_to_folder): Fix double freeing of the
local exception `ex'.
2000-07-01 Ettore Perazzoli <ettore@helixcode.com>
* mail-ops.c (refile_msg): Only allow type "mail" in the folder
selection dialog.
2000-07-01 Dan Winship <danw@helixcode.com>
* pixmaps.h, pixmaps/*.xpm: Removed. These aren't being used any
more. (The real pixmaps are in ../art.)
2000-07-01 Jeffrey Stedfast <fejj@helixcode.com>
* message-list.c (get_message_info):
(select_msg): Updated to reflect camel-folder changes.
* mail-ops.c (real_fetch_mail): Modified to reflect camel-folder
changes.
2000-06-30 Dan Winship <danw@helixcode.com>
* mail-ops.c (print_msg): Use gnome-print to do a print preview.
* folder-browser-factory.c: Hook up "Print" button.
* message-list.c (message_list_foreach): New function, a wrapper
around e_table_selected_row_foreach, which calls the callback
function with UIDs rather than row numbers.
* folder-browser-factory.c: Remove never-used "Find" button from
the toolbar and replace it with "Refile". (We need a better icon
for this...). Hook up "Refile" to "refile_msg".
* mail-ops.c (refile_msg): Call the shell's user_select_folder
routine, and then use message_list_foreach and real_refile_msg to
do the work.
(delete_msg): Update to use message_list_foreach.
* folder-browser.c (mail_uri_to_folder): new function, extracted
from folder_browser_load_folder, to turn a URI into a folder.
(folder_browser_load_folder): Use it.
2000-06-30 Peter Williams <peterw@curious-george.helixcode.com>
* component-factory.c (create_news_storage, create_imap_storage):
Fixed to use new EvolutionShellClient proxy thingamajiggie.
2000-06-30 Dan Winship <danw@helixcode.com>
* message-list.c (on_row_selection): use the ETable row_selection
signal to track how many rows are selected. Eventually we will use
this info to disable toolbar buttons when you have too few/too
many messages selected, but the current toolbar widget doesn't
allow that.
* message-list.h, message-list.c, mail-ops.c: Change selected_row
and selected_uid fields of MessageList to cursor_row and
cursor_uid to be more correct according to the new ETable
interfaces.
2000-06-30 Ettore Perazzoli <ettore@helixcode.com>
* component-factory.c: Eeek. Fix typo: add missing star in the
declaration of `global_shell_client'.
2000-06-29 Ettore Perazzoli <ettore@helixcode.com>
* component-factory.c: Replace `global_shell_interface' with
`global_shell_client'.
2000-06-29 Jeffrey Stedfast <fejj@helixcode.com>
* mail-ops.c (delete_msg): Clean up compile warnings
(real_fetch_mail): Fetching from IMAP should do nothing
2000-06-29 Christopher James Lahey <clahey@helixcode.com>
* mail-ops.c: Handle multiple deletes (change by Peter Williams.)
2000-06-29 Jeffrey Stedfast <fejj@helixcode.com>
* folder-browser-factory.c: Changed "Send" to "Compose" to
avoid user confusion. Compose is a little more intuitive.
Also changed the pixmap to MAIL_NEW instead of MAIL_SND
* mail-ops.c (compose_msg): Renamed to avoid confusion
2000-06-29 Dan Winship <danw@helixcode.com>
* component-factory.c (create_imap_storage, create_news_storage):
remove some code incorrectly copied and pasted from
create_vfolder_storage which caused vfolder creation to stop
working.
2000-06-29 Christopher James Lahey <clahey@helixcode.com>
* message-list.c, mail-ops.c: Changed the name of
e_table_select_row to e_table_set_cursor_row.
2000-06-29 Peter Williams <peterw@helixcode.com>
* message-list.c (message_list_init): Set the dnd_code of the
ETableHeader to something so that Solaris sprintf doesn't die
on a NULL string.
* mail-config.c (providers_config_new): Check for a null "transport"
string (not all OS' handle NULL strings well *cough* Solaris)
2000-06-28 Dan Winship <danw@helixcode.com>
* mail-format.c (mail_generate_forward): add default subjects
* component-factory.c (create_folder): Refuse to create folders
not of type "mail", and correctly create an empty "mbox" folder
for new folders in /local.
* main.c (init_corba): Call od_assert_using_oaf() or
od_assert_using_goad() as appropriate to make sure people didn't
somehow trick the build system.
2000-06-28 Jeffrey Stedfast <fejj@helixcode.com>
* message-list.c: Added prototype for filter_date to make
it build cleanly
2000-06-27 Christopher James Lahey <clahey@helixcode.com>
* message-list.c: Made dates display grouping information
properly.
2000-06-27 Peter Williams <peterw@curious-george.helixcode.com>
* message-list.c (mark_msg_seen): Need to return a value
on error.
* main.c (main): Don't start threads or enter threads if
there's no threading! Sigh.
* test-thread.c: Don't compile if no threads.
* session.c: Work without broken threads.
* message-list.c (filter_date): Solve the ctime_r problem the
correct way, with the magic of autoconf.
2000-06-27 Christopher James Lahey <clahey@helixcode.com>
* message-list.c: Work around mismatched ctime_r functions. This
will be fixed.
2000-06-27 Peter Williams <peterw@curious-george.helixcode.com>
* mail-threads.c: Don't compile this if we don't have
threads enabled. This should maybe be on the Makefile.am
level.
2000-06-27 Michael Zucchi <zucchi@zedzone.mmc.com.au>
* component-factory.c (owner_set_cb): Put in a gross hack to
export the shell reference elsewhere.
2000-06-26 Christopher James Lahey <clahey@helixcode.com>
* message-list.c: Added a value_to_string handler.
2000-06-26 Peter Williams <peterw@helixcode.com>
* component-factory.c, mail-ops.c: #ifdef the threads stuff so
that if USE_BROKEN_THREADS is not defined we just call the functions
in the main thread.
* mail-threads.h: Don't declare funcs if USE_BROKEN_THREADS not
defined.
* mail-threads.c: Put the query and message boxes on top so that
you can see them.
2000-06-26 Jeffrey Stedfast <fejj@helixcode.com>
* mail-config.c (error_dialog): va_start() returns void, don't
assign it's retval to a variable.
2000-06-26 Ettore Perazzoli <ettore@helixcode.com>
* main.c (main): Call `GDK_THREADS_ENTER()' and
`GDK_THREADS_LEAVE()' around the main loop as in the examples from
the GTK+ FAQ.
* mail-threads.c (DEBUG): New macro for debugging.
(read_msg): Use it.
2000-06-25 Peter Williams <peterw@helixcode.com>
* Makefile.am: Clean up the various _LIBS and _CFLAGS
to work with simpler THREADS_LIBS and THREADS_CFLAGS scheme.
2000-06-23 Jeffrey Stedfast <fejj@helixcode.com>
* folder-browser.c (folder_browser_load_folder): Improved the
code to separate the imap namespace from the folder name.
2000-06-23 Peter Williams <peterw@curious-george.helixcode.com>
* component-factory.c: Include e-util/e-setup.h for the
prototype of evolution_dir; prototype create_news_storage.
(real_create_imap_storage, real_create_news_storage): New
functions moving the camel stuff into the async callback.
(create_imap_storage, create_news_storage): Chopped in
half to move camel stuff as above.
* mail-ops.c: Include "mail-threads.h" for threading protos.
(real_fetch_mail, real_send_mail, real_expunge_folder):
New functions moving the camel stuff into the async callback.
(async_mail_exception_dialog): A version of mail_exception_dialog
to be called from the async handlers (just calls mail_op_error())
(fetch_mail, expunge_folder, composer_send_cb): Cut in half to
move camel stuff as above.
(cleanup_send_mail): Clean up after the async real_send_mail
with the gtk_object_destroys et al.
* mail-threads.c: Instead of hiding the progress bar, make it
zip back and forth constantly.
(progress_timeout): New func. Timeout called to make the pbar
shimmy.
(timeout_toggle): New func. Turn on and off the shimmy effect.
(check_cond): New func. Make sure that the GCond for modal
operation is initialized before mail_op_{error,get_password}.
(show_error_clicked, read_msg, get_password_clicked): Move
over to timeout_toggle.
(mail_op_error,mail_op_get_password): Add check_cond() call.
* main.c: (main) Call g_thread_init.
* session.c: Change auth_callback stuff over to assume that it's
being called async. Note: no real good way to tell if this is
the case or not.
(request_callback): ifdef'ed out
(evolution_auth_callback): Use mail_op_get_password.
2000-06-22 Jeffrey Stedfast <fejj@helixcode.com>
* folder-browser.c (folder_browser_load_folder): Now should
correctly get the selected folder from the given URL.
2000-06-22 Chris Toshok <toshok@helixcode.com>
* folder-browser.c (folder_browser_load_folder): add handling for
loading "news:" folders.
* component-factory.c (create_news_storage): add a root for news
source.
(owner_set_cb): call create_news_storage.
2000-06-22 Jeffrey Stedfast <fejj@helixcode.com>
* folder-browser.c (folder_browser_load_folder): Updated to
prepend url-> path if it exists for that imap store.
* component-factory.c (create_imap_storage): Modified to not
prepend a hard-coded namespace.
2000-06-22 Chris Toshok <toshok@helixcode.com>
* mail-ops.c (fetch_mail_cleanup): new function, passed as arg to
mail_operation_try.
(fetch_mail): add cleanup func arg.
2000-06-22 Christopher James Lahey <clahey@helixcode.com>
* message-list.c: Changed ml_value_at to return "" instead of NULL
in some cases.
2000-06-22 Peter Williams <peterw@curious-george.helixcode.com>
* Makefile.am: Add GNOME_EXTRA_LIBS so that we get libgthread
in our LIBS for evolution-mail.
* mail-threads.c: Make the dialog boxes for error and
question non-modal. They're modal relative to the dispatch
thread, but before they would also eg lock up the toolbar
buttons (while the menus, managed by another process, were
active -- a weird effect).
2000-06-22 Peter Williams <peterw@curious-george.helixcode.com>
* mail-threads.[ch]: Extra argument to mail_operation_try:
'cleanup', a function to be called in the main thread after
the dispatcher thread exits. gtk_object_destroy's et al may
attempt to unmap windows so we can't do them in the dispatcher
thread :-(
* test-thread.c: Updated with demo of new argument working.
2000-06-22 Peter Williams <peterw@helixcode.com>
* test-thread.c (op_5): New tests for the get_password
hook.
* mail-threads.[ch]: New hook, mail_op_get_password, for
getting a user response from an async operation. The operation
blocks while waiting for the response. A big whole mutex
condition threading blocking dealie to make sure that it
works.
Also the error hook creates a dialog again, which also needs
to block its caller while we wait for the user to press ok.
2000-06-22 Peter Williams <peterw@helixcode.com>
* mail-threads.c (various functions): Prettify the UI
so that the progress bar doesn't become all huge 'n stuff.
(mail_operation_try): Now save the operation's description,
so that we can display it later as the default message.
(read_msg): When the operation starts set the label to its
UI-friendly name.
(dispatch_func): Free the saved prettyname.
2000-06-21 Christopher James Lahey <clahey@helixcode.com>
* message-list.c: Removed an erroneous comment.
2000-06-21 Dan Winship <danw@helixcode.com>
* mail-config.c (create_transport_page): Make this not crash if
you don't have a transport configured.
* message-list.c: Update received date to work like sent date.
2000-06-21 Peter Williams <peterw@helixcode.com>
* mail-thread.{c,h}: New files -- a simple API for executing
the major mail ops (fetch_mail etc) asynchronously, allowing
the operations to send messages and update a progress bar.
* test-thread.{c,h}: Tests the mail-thread API.
* Makefile.am: add mail-thread.[ch] to evolution_mail_SOURCES
and declare the test_thread noinst_PROGRAM.
2000-06-21 Peter Williams <peterw@helixcode.com>
* mail-format.c (mail_generate_reply): Include "e-setup.h" to
get the prototype for evolution_dir.
2000-06-20 Jeffrey Stedfast <fejj@helixcode.com>
* component-factory.c (create_imap_storage): Oops. Should
have checked for a NULL sources.
2000-06-20 Dan Winship <danw@helixcode.com>
* message-list.c (mark_msg_seen): Quick hack to prevent a NULL
pointer dereference. Things need to be cleaned up a bit more here
though.
* mail-sources.c: Oops. This should have been removed a long time
ago.
2000-06-20 Jeffrey Stedfast <fejj@helixcode.com>
* folder-browser.c (folder_browser_load_folder): Working on getting
this to work :)
* component-factory.c (create_imap_storage): Should now correctly
construct the folder path allowing the selection of a folder.
2000-06-20 Ettore Perazzoli <ettore@helixcode.com>
* mail-format.c (mail_generate_reply): Declare `evolution_dir'.
Ugly, ugly, ugly, but I am not sure where it should go instead.
2000-06-19 Ettore Perazzoli <ettore@helixcode.com>
* mail-ops.c (ask_confirm_for_empty_subject): New function to ask
confirmation for an empty subject line.
(composer_send_cb): Use it if the subject is empty and only send
the message if the user confirms.
2000-06-20 Jeffrey Stedfast <fejj@helixcode.com>
* component-factory.c (create_imap_storage): Now creates the IMAP
storage (listing subfolders and such)
2000-06-19 Dan Winship <danw@helixcode.com>
* mail-format.c (find_preferred_alternative): add an option to
prefer text/plain.
(reply_body): add an option to prefer text/plain
(mail_generate_reply): Check the mail sending preferences, and
generate a text/plain reply if the user prefers to send plain text
(and we have a text/plain part to generate a reply from).
2000-06-19 Jeffrey Stedfast <fejj@helixcode.com>
* mail-config.c (providers_config_new): Should now correctly display
the Transport page (made it set the optionmenu correctly, before it
would only set SMTP).
(create_transport_page): Updated to set the page info to sendmail/smtp
based on the url.
(create_service_page): Had to add some code to set data on some objects
so I could grab the objects I needed to modify in the above function.
2000-06-18 Jeffrey Stedfast <fejj@helixcode.com>
* folder-browser.c (folder_browser_load_folder): started to add
code to load an IMAP folder.
* component-factory.c: Started to add a create_imap_storage
method so that we can eventually have our IMAP store displayed
in the tree view.
(create_vfolder_storage): Renamed from
create_test_storage().
(owner_set_cb): Updated.
2000-06-17 Dan Winship <danw@helixcode.com>
* message-list.c (message_list_set_folder): Prevent double-freeing
action on summary_table and uid_rowmap.
2000-06-16 Dan Winship <danw@helixcode.com>
* message-list.c (ml_set_value_at): Implement clicking on the
envelope icon to set read/unread. Based on a patch by clahey.
(select_msg): keep the timeout id for the "seen" flagging in the
message_list structure, so ml_set_value_at can clear it so it
doesn't re-mark a message seen after you click it unseen.
2000-06-16 Dan Winship <danw@helixcode.com>
* message-list.c (get_message_row): new function to do a uid to
row mapping.
(mark_msg_seen, select_msg, message_changed,
message_list_set_folder): Update for Camel flag changes.
(on_cursor_change_cmd): Rename "row_to_select" to "selected_row",
and keep a "selected_uid" as well.
* mail-ops.c (composer_send_cb): Update for Camel flag changes,
and fix some memory-handling bugs. (Free the post_send_data when
the composer is destroyed, not when the user clicks "send", which
could happen never, or more than once.)
(delete_msg): Update for Camel flag changes, and fix the "holding
down the delete key skips some messages" bug.
2000-06-15 Dan Winship <danw@helixcode.com>
* mail-ops.c (fetch_mail):
* component-factory.c (owner_unset_cb):
* message-list.c (message_list_set_folder): Update for CamelFolder
changes.
* folder-browser.c (folder_browser_clear_search): New function to
revert back to non-searching mode.
* mail-ops.c (fetch_mail): Use folder_browser_clear_search.
* mail-display.c (on_url_requested): if the document requests an
unknown URL, it's not an error; just ignore the URL.
* mail-ops.c (fetch_mail): If there's no new mail, tell the user.
2000-06-14 Radek Doulik <rodo@helixcode.com>
* main.c (main): call gtkhtmllib_init here
2000-06-13 Jeffrey Stedfast <fejj@helixcode.com>
* mail-config.c (on_SourceConfigDialogButton_clicked): Make sure source
is always pointing to something, so a blank is not written to the config file
on close.
2000-06-13 Ettore Perazzoli <ettore@helixcode.com>
* Makefile.am (SHELL_OBJS): Removed.
(evolution_mail_LDADD): Use `libeshell.a'. Also use
`top_builddir' consistently.
2000-06-12 Jeffrey Stedfast <fejj@helixcode.com>
* mail-config.c: Got rid of sources_max_row and identities_max_row
as they are not really needed (just use clist->rows)
(on_cmdSourcesEdit_clicked): Modified to make 'source'
point to the data being edited.
(on_cmdSourcesAdd_clicked): Adds a new clist item and selects it so the
editor knows where to stick the data when it's done.
2000-06-12 Federico Mena Quintero <federico@helixcode.com>
* message-list.c: Removed the ETableModel thaw handler.
2000-06-12 Dan Winship <danw@helixcode.com>
* folder-browser.c (folder_browser_set_uri): Return the result of
folder_browser_load_folder.
(get_prop, set_prop, folder_browser_properties_init): Remove. No
longer needed.
* folder-browser-factory.c (folder_browser_factory_new_control):
Add a "uri" argument, return NULL if setting it fails.
(folder_browser_factory_new_control): Remove property bag stuff.
(folder_browser_factory_init, folder_browser_factory): Remove
this, since we're using the component factory now.
* component-factory.c (create_view): Update for
folder_browser_factory_new_control change and return NOTFOUND as
appropriate.
* main.c (main): Don't call folder_browser_factory_init.
* mail-format.c (mail_generate_reply): Fix the subject generation
so we don't get "Re: Re:". This is working around something that
may later be declared a misfeature in Camel.
2000-06-10 Ettore Perazzoli <ettore@helixcode.com>
* component-factory.c (create_folder): New stub implementation for
the folder creation function in the EvolutionShellComponent we
expose [it simply returns success all the time].
(factory_fn): Pass this function to `evolution_shell_component_new'.
2000-06-09 Dan Winship <danw@helixcode.com>
* folder-browser.c (folder_browser_new): Add a serial number to
FolderBrowser.
* folder-browser-factory.c (control_activate, control_deactivate):
Include fb serial number in the name of the Bonobo toolbar to
prevent problems with disappearing toolbars. This is a kludge and
should go away.
* mail-ops.c (expunge_folder): display error from
camel_folder_expunge if there is one.
* message-list.c (select_row): install an idle function to
select the row rather than doing it directly. Ugh. What a
kludge, but at least it works now.
* session.c (evolution_auth_callback): Update for
CamelAuthCallback changes. (Uncache passwords when asked to.)
* mail-ops.c (fetch_mail): close and expunge the source folder
after copying it to a local folder.
2000-06-09 Ettore Perazzoli <ettore@helixcode.com>
* component-factory.c (create_view): Updated to match the changes
to the definition of `EvolutionShellComponentCreateFn'. If @type
is not "mail", return an "unsupported type" error.
(factory_fn): Pass NULL for the `remove_folder' and
`create_folder' functions.
2000-06-09 Dan Winship <danw@helixcode.com>
* mail-format.c: Redo things a bit so that whitespace-only
text parts aren't displayed. (In particular, so that
whitespace-only subparts of multipart/mixed aren't displayed as
separate (empty) parts.)
2000-06-06 Dan Winship <danw@helixcode.com>
* mail-ops.c (fetch_mail):
* folder-browser.c (folder_browser_load_folder): Update for folder
creation/existence changes.
* message-list.c (message_list_set_folder): Remove the code to
create the folder if it doesn't exist, since we don't want to do
that.
2000-06-05 Dan Winship <danw@helixcode.com>
* mail-ops.c (composer_send_cb): Leave the composer window around
if the message doesn't get sent.
2000-06-05 Matt Loper <matt@helixcode.com>
* folder-browser.c (etable_key): Allow "GDK_KP_Delete", a keypad
delete key, to delete a message.
2000-06-05 Dan Winship <danw@helixcode.com>
* session.c (evolution_auth_callback): Remember passwords between
calls.
(forget_passwords): Callback for "Forget Passwords" menu item.
* folder-browser-factory.c (control_activate):
(control_deactivate): Add "Forget Passwords" menu item.
* mail.h, mail-ops.c: fix some function prototypes
* folder-browser.c (etable_key): Add "Delete" = delete message.
* mail-format.c (mail_generate_forward): Update for new composer
attachment interface.
2000-06-02 Jeffrey Stedfast <fejj@helixcode.com>
* mail-config.c (providers_config_new): Added a new notebook
page that allowed for mail format (text/plain or
multipart/alternative)
2000-06-02 Dan Winship <danw@helixcode.com>
* message-list.c (filter_date): If the date in the summary is 0,
output "?".
* component-factory.c (create_view): keep a GList of folder
browsers created
(owner_unset_cb): Go through the list and close each folder before
exiting so they sync their summary state, etc to disk.
* mail-ops.c (fetch_mail): Use camel_service_connect, not
connect_with_url, since we already passed the URL into
camel_session_get_store.
2000-06-02 Christopher James Lahey <clahey@helixcode.com>
* message-list.c: Use camel_folder_free_summary instead of
g_ptr_array_free. Unref the folder when we're done with it.
2000-06-02 Christopher James Lahey <clahey@helixcode.com>
* session.c: Revert removal of e_setup_base_dir.
2000-06-02 Dan Winship <danw@helixcode.com>
* folder-browser.c (my_folder_browser_init): Connect to ETable's
key_press signal.
(etable_key): scroll mail on space/backspace.
2000-06-02 Christopher James Lahey <clahey@helixcode.com>
* message-list.c: Made sent column as wide as from column.
2000-06-02 Jeffrey Stedfast <fejj@helixcode.com>
* mail-config.c (on_cmdSourcesAdd_clicked): Changed identity_row
to source_row as this is a Sources clist we are dealing with and
not an identity clist
(on_cmdSourcesEdit_clicked): same
(on_cmdSourcesDelete_clicked): again, same
(on_cmdSourcesEdit_clicked): Source editor now fills in data from
the clist
2000-06-01 Dan Winship <danw@helixcode.com>
* message-list.c: Add a date column.
(COL_SENT_WIDTH_MIN): Make this wider.
(ml_value_at): return the sent date (as a time_t) for COL_SENT.
(Fix COL_TO too while I'm here.)
(ml_duplicate_value, ml_free_value, ml_initialize_value,
ml_value_is_empty): COL_SENT is numeric now.
(message_list_init_renderers): Create a date renderer (using
text_filter to translate the time_t into a string).
(message_list_init_header): Use render_date for COL_SENT.
2000-06-01 Christopher James Lahey <clahey@helixcode.com>
* session.c: Don't call e_setup_base_dir.
2000-06-01 Dan Winship <danw@helixcode.com>
* mail-format.c (mail_generate_forward): Fix forwarding to work
for people other than me. :) [Although apparently it doesn't
really.]
* mail-ops.c (delete_msg): Add a quick hack to move the selection
down a row when you delete a message.
* mail-format.c (handle_message_rfc822): use <blockquote> rather
than <center><table border=1 width=95%> to frame the embedded
message. If <pre> text in the subtable won't fit in the 95% width,
GtkHTML will write past the border of the table (and
<blockquote><table border=1> causes creeping updates so it's not
usable for now).
2000-06-01 Christopher James Lahey <clahey@helixcode.com>
* message-list.c (message_list_init): Turn off the grid in our
ETable.
2000-06-01 Dan Winship <danw@helixcode.com>
* mail-format.c (write_headers): Oops. This needs to take a
message argument because we might be writing headers for an
embedded message/rfc822 subpart rather than the root document.
2000-06-01 Jeffrey Stedfast <fejj@helixcode.com>
* mail-config.c: Config dialogs are completed.
(service_acceptable): Fixed a segfault caused by duplicate
camel_exception_free()
(providers_config_new): Identity and Source clists are now filled in
when the dialog is created as well as the Transport page
* folder-browser-factory.c: Renamed Tool/ menu items
Vfolder was changed to Virtual Folder and
Configure Camel Providers was changed to Mail Configuration
2000-06-01 Ettore Perazzoli <ettore@helixcode.com>
* Makefile.am (evolution_mail_LDADD): Link with
`libemiscwidgets.a'.
* mail-display.c (mail_display_new): Use an EScrollFrame instead
of a GtkScrolledWindow.
(mail_display_set_message): Likewise.
* mail-display.h: Replace the GtkScrolledWindow with an
EScrollFrame.
2000-06-01 Dan Winship <danw@helixcode.com>
* component-factory.c (owner_unset_cb): Quit when the shell exits.
This is a kludge, but a pretty necessary one until the refcounting
bugs that keep the component from exiting properly are fixed.
2000-05-31 Jeffrey Stedfast <fejj@helixcode.com>
* mail-config.c: Partially implemented the source
configuration, seems to segfault due to a destroyed
gnome dialog being destroyed again in the method
on_SourceConfigDialogButton_clicked()
2000-05-31 Dan Winship <danw@helixcode.com>
* mail-format.c (free_url, handle_text_enriched,
get_url_for_icon): Fix up memory management of x-evolution-data
URLs so the URLs and/or their data don't get freed while there are
still references to them.
* message-list.c (message_list_init_header): redo the (unused)
online status column to no longer refer to pixmaps that no longer
exist.
2000-06-01 Ettore Perazzoli <ettore@helixcode.com>
* folder-browser-factory.c (control_activate): Put the toolbar
into a frame to make it look like standard GNOME toolbars. Also,
set `GNOME_DOCK_ITEM_BEH_NEVER_VERTICAL' so that it does not do
evil things when its moved to the left or the right of the window.
2000-05-31 Jeffrey Stedfast <fejj@helixcode.com>
* mail-config.c: Configuration dialog now allows
adding/editing/deleting of Identities (which leaves
adding/editing/deleting of sources left to implement).
The data is also saved when the dialog is exited via
the OK button.
2000-05-31 Dan Winship <danw@helixcode.com>
* mail-format.c (mail_format_mime_message): Initialize the "urls"
hash table stored on the message and store cid and other URLs
there rather than as object data on the message.
(get_cid): rewrite this a bunch
(handle_text_enriched): move the code from write_iframe_string()
into here, since it's the only place that actually needs it.
(handle_text_html): simplify this a lot. We can use a cid: URL
here rather than x-evolution-data.
(get_url_for_icon): New routine to return URLs for icons, and
cache the results, so we don't have to keep re-reading the icon
files (and so we can't be spoofed into reading non-icon files).
(handle_mystery, handle_audio): use get_url_for_icon.
* mail-display.c (save_data): move the CamelMimePart filename
extracting code from get_cid to here.
(on_link_clicked, on_object_requested): Update for cid: changes.
(on_url_requested): Kill off the kludgy, exploitable x-gnome-icon
URL schema, update cid and x-evolution-data to match
mail-format.c.
It should now be easier to implement RFC 2557 (Content-Location,
etc), but that RFC still pretty much sucks.
2000-05-30 Dan Winship <danw@helixcode.com>
* mail-format.c: Redo this back to the old way: a single GtkHTML
with various things inline in it. (Gets rid of flicker, simplifies
some scrolling, selecting, and printing issues.)
(handle_text_enriched, handle_text_html): Use <iframe>s for these,
to protect the rest of the document from their possibily invalid
HTML.
(handle_via_bonobo): Use (new-and-improved) <object> tags for
this, moving most of the work back into mail-display.c
* mail-display.c (on_object_requested): Move the Bonobo embedding
code back here again (reorganized a bit).
(on_url_requested): add x-evolution-data handler, for iframe
bodies.
(mail_html_new, mail_html_end): removed
(mail_display_set_message, mail_display_new): Update for NWO.
2000-05-30 Not Zed <NotZed@HelixCode.com>
* folder-browser.c (search_set): Properly encode the search string.
2000-05-30 Jeffrey Stedfast <fejj@helixcode.com>
* mail.h: Added a prototype for providers_config_new() which
is the constructor for the configuration dialog window
* mail-config.c: Added set_service_url() which is basically
the reverse of get_service_url().
Implemented on_cmdCamelServicesOK_clicked() - The configuration
window will now remember the Sendmail/SMTP data that the user
had entered in the previous session.
Removed on_cmdCamelServicesApply_clicked() - No need for this.
2000-05-30 Dan Winship <danw@helixcode.com>
* message-list.c (message_changed): call
e_table_model_row_changed, not e_table_model_changed so we do less
work, and don't lose the current selection.
(select_msg): Set up a timer to mark the displayed message as
"seen" if it's selected for longer than 1.5 seconds (a number
pulled out of Matt's butt).
(ml_value_at): Use the MESSAGE_STATUS column for read/unread as
well as deleted.
* message-list.c: use the "new" tigert pixmaps rather than the
older ones. Includes a "replied to" icon (which is used now), but
no "deleted" icon (although we have the strikeout renderer for
that now).
2000-05-30 Christopher James Lahey <clahey@helixcode.com>
* message-list.c, message-list.h: Added bold for unread messages.
2000-05-30 Jeffrey Stedfast <fejj@helixcode.com>
* mail.h: Added a prototype for providers_config()
which is the callback for a new menu item that
will construct a configuration dialog for the camel
providers and identities and display it
* mail-config.c: Added some code to construct the
new providers dialog and a bunch of callbacks (most
of which are not yet useful)
* mail-ops.c: Added the code for the providers_confi()
callback
* folder-browser-factory.c: Added the
"Tools/Camel Providers Configuration ..." menu item
2000-05-30 Christopher James Lahey <clahey@helixcode.com>
* message-list.c: Switched to using "cursor_change" signal instead
of "row_selection" for switching messages. Select the first row
(still doesn't work because of ETable.) Adapt to some small
ETable changes. Set drawfocus to FALSE.
2000-05-29 Not Zed <NotZed@HelixCode.com>
* folder-browser.c (folder_browser_load_folder): Hardcode the
vfolder source to just the inbox (so at least it returns
something).
* component-factory.c (create_test_storage): Create a vfolder dir
first, and put the folders in that.
(create_test_storage): Create the storage as VFolders, not
"storage_name" :)
2000-05-28 Dan Winship <danw@helixcode.com>
* mail-config.c (error_dialog): helper function since we need to
set "modal" on the dialogs returned by gnome_error_dialog to make
them work when popped up from the modal Druid.
(service_acceptable): New function to check if the info entered on
a store/transport page actually checks out.
(mail_config_druid): Connect to the "next" signal on the store and
transport pages and don't let the user continue if the data is
bad and "check this before continuing" is checked. Also, only
display sources/transports in the "mail" domain. (Ie, not
"vfolder".)
* mail-format.c (write_recipients_to_stream): Use `foo@bar' rather
than `<foo@bar>' for recipient with no name.
* mail-ops.c (fetch_mail): don't put up an error message if the
user cancels the password dialog.
2000-05-27 Not Zed <NotZed@HelixCode.com>
* Makefile.am (SHELL_OBJS): Include mail storage so we can
initialise folders.
* component-factory.c (create_test_storage): Parses vfolder
defintions and adds them to the storage. Definetly needs more
work.
* folder-browser-factory.c (control_activate): Add the VFolder
druid menu item.
(control_deactivate): And remove it.
* mail-ops.c (vfolder_editor_clicked): For editing vfolder
definitions (rather like filters, oddly enough :). Tries to
update the shell but it doesn't seem to work properly - requires a
mail component restart to take effect.
* folder-browser.c (folder_browser_load_folder): Handle vfolder:
urls' appropriately and map to camel. Still needs a way to tell
the vfolder what folders to search! (all vfolders come up empty!).
2000-05-28 Christopher James Lahey <clahey@helixcode.com>
* message-list.c, message-list.h: Added a COL_DELETED and made it
the strikeout column for both text renderers.
2000-05-27 Dan Winship <danw@helixcode.com>
* mail-format.c: Various improvements:
(call_handler_function, etc): Add a "mime_type" argument to the
handlers, so that if a part is tagged as
"application/octet-stream", and we figure out that it's really
something else, the handler we call can know what that something
else is.
(handle_text_enriched): Small fixes to make this not do
text/enriched-specific syntax in text/richtext or vice versa.
(handle_mystery): Allow for mystery data that can't even be saved
to disk. (ie, unrecognized external-body). Let the caller specify
the URL to use.
(handle_message_external_body): New function to deal with
message/external-body parts. Generates URLs for anon-ftp,
local-file, and URL access-types, and a more-useful-than-before
descriptive message for other types.
(handle_audio, handle_undisplayable): Use gnome_mime_get_value to
try to get a description of the MIME type to display to the user
rather than the raw form. (This will only work if the user has
recent gnome-vfs installed. [If they don't, it works just like
it used to.])
2000-05-26 Dan Winship <danw@helixcode.com>
* mail-format.c (handle_text_html): Fix a bug (security/stability)
in its usage of mail_html_write.
* mail-ops.c (composer_send_cb, reply): set CAMEL_MESSAGE_ANSWERED
on a message after a successful reply.
* message-list.c (folder_changed): free the summary with
camel_folder_free_summary rather than g_ptr_array_free.
* mail-format.c (handle_via_bonobo): Update for PersistStream
changes
2000-05-25 Ettore Perazzoli <ettore@helixcode.com>
* main.c (main): Initialize the component factory.
* Makefile.am (evolution_mail_LDADD): Link with
`evolution-shell-component.o' from the shell directory.
* evolution-mail.oafinfo: Updated with the
Evolution::ShellComponent OAFIID.
* evolution-mail.gnorba: Updated with the
Evolution::ShellComponent GOAD ID.
* folder-browser-factory.c (folder_browser_factory_new_control):
New function; code moved out from `folder_browser_factory'.
(folder_browser_factory): Use it.
* component-factory.c: New.
* component-factory.h: New.
2000-05-24 Dan Winship <danw@helixcode.com>
* mail-ops.c (composer_send_cb): connect to and disconnect from
the transport.
2000-05-24 Christopher James Lahey <clahey@helixcode.com>
* Makefile.am: Added libepaned.a.
* folder-browser.c: Switched from GtkPaned to EPaned.
2000-05-23 Ettore Perazzoli <ettore@helixcode.com>
* Makefile.am: Don't link to `evolution-service-repository.o'
anymore.
* folder-browser-factory.c: Don't use crufty service-repository
anymore.
2000-05-21 Ettore Perazzoli <ettore@helixcode.com>
* message-list.c (get_message_info): Made static.
(ml_initialize_value): Return NULL to placate compiler.
* folder-browser.c (folder_browser_gui_init): Add cast.
* mail-display.c (mail_html_new): Don't pass an empty URL to
`gtk_html_begin()' anymore.
* mail-config.c (put_html): Don't pass an empty URL to
`gtk_html_begin()' anymore.
* mail-display.h: Updated for the new GtkHTML API that uses
`GtkHTMLStream *' instead of `GtkHTMLStreamHandle'.
* mail-display.c: Likewise.
* mail-config.c: Likewise.
* mail-format.c: Likewise.
2000-05-19 NotZed <NotZed@HelixCode.com>
* mail-format.c: Fixes for stream stuff.
* mail-display.c (save_data_cb): Remove exception stuff on streams.
2000-05-19 Christopher James Lahey <clahey@helixcode.com>
* message-list.c: Added initialize_value and value_is_empty
callbacks.
2000-05-18 Dan Winship <danw@helixcode.com>
* folder-browser-factory.c (folder_browser_factory): Remove
development_warning (moved to shell)
* message-list.c (select_msg): Update for camel_folder_get_uids
(folder_changed, message_list_set_folder): Update for
camel_folder_get_summary
* mail-ops.c (fetch_mail): Update for camel_folder_get_uids
2000-05-17 Dan Winship <danw@helixcode.com>
* mail-component.c: This seems to be cruft. Nuke it.
* mail-display.c (save_data_cb, save_data, on_url_requested):
* mail-format.c (handle_text_plain_flowed, handle_text_html):
Use camel_data_wrapper_write_to_stream rather than
camel_data_wrapper_get_output_stream.
2000-05-16 NotZed <NotZed@HelixCode.com>
* mail-ops.c (filter_edit): Function to bring up the filter editor.
(filter_druid_clicked): Save/close dialogue.
(fetch_mail): Apply filters to incoming mail ... *hold breath*
If we are coming from a non-indexed/searchable/etc source, then
copy it to an mbox first. When copying mail from an mbox source,
dont remove it aftewards, open it for append, so partially
filtered mail isn't lost.
* Makefile.am (evolution_mail_LDADD): Added libfilter.
(INCLUDES): Add EVOLUTION_DATADIR, and fix matt's brokeneditor(tm)
for putting spaces instead of tabs in.
2000-05-16 Christopher James Lahey <clahey@helixcode.com>
* mail-format.c: Removed usage of bonobo_object_destroy.
2000-05-14 Christopher James Lahey <clahey@helixcode.com>
* message-list.c: Updated to work with new ETable resizing.
2000-05-12 NotZed <NotZed@HelixCode.com>
* mail-ops.c (fetch_mail): Use 6 X's to mkstemp, as required by
the man page, just a temp fix, this should probably change to a
known filename.
2000-05-11 Dan Winship <danw@helixcode.com>
* folder-browser-factory.c (control_activate): Now that we depend
on current gnome-libs we can make the toolbar detachable again.
2000-05-11 Federico Mena Quintero <federico@helixcode.com>
* folder-browser-factory.c (development_warning): Left-justify the
message.
2000-05-10 Christopher James Lahey <clahey@helixcode.com>
* folder-browser-factory.c (development_warning): Made this dialog
have fewer buttons.
2000-05-10 Christopher James Lahey <clahey@helixcode.com>
* folder-browser-factory.c (development_warning): New development
warning text from Nat.
2000-05-10 Larry Ewing <lewing@helixcode.com>
* mail-config.c (html_new): only set the default background color
if style is not NULL.
2000-05-09 Christopher James Lahey <clahey@helixcode.com>
* Makefile.am: Removed folder-browser-factory.h since it doesn't
exist. Added mail-display.h, mail-types.h, pixmaps.h.
2000-05-09 Matt Loper <matt@helixcode.com>
* folder-browser-factory.c (control_activate): Remove "File->mail"
menuitem.
* mail-config.c (mail_config_druid): Fill in "blah blah blah".
2000-05-09 Dan Winship <danw@helixcode.com>
* folder-browser.c (folder_browser_load_folder): make this a
little less kludgy. Use gnome_error_dialog rather than printf on
errors.
* mail-ops.c (fetch_mail): Fix to work with the new shell stuff...
sorta. Will need more fixing later when the new shell framework is
more done.
* mail-config.c (finish): Call gnome_config_sync so the data
actually gets written.
2000-05-08 Dan Winship <danw@helixcode.com>
* mail-display.c (save_data_cb):
(on_url_requested): Update for CamelStream CamelException changes.
* mail-format.c: Pass NULL for a CamelException in a bunch of
places... the user will see that the data is not being displayed,
and there's not a lot we can do, and none of these things should
be failing anyway. Maybe fix this later.
2000-05-07 NotZed <NotZed@HelixCode.com>
* message-list.c (ml_value_at): Size moved to message info, rather
than content info structure.
2000-05-07 Dan Winship <danw@helixcode.com>
* message-list.c (select_msg): unref the message after displaying
it.
* mail-format.c (get_data_wrapper_text):
(handle_text_plain_flowed):
(handle_via_bonobo): Replace camel_stream_close calls.
2000-05-07 Matt Loper <matt@helixcode.com>
* folder-browser-factory.c: Changed a toolbar button from saying
"New mail" (which suggests you might be composing new mail) to
"Get mail".
2000-05-06 Dan Winship <danw@helixcode.com>
* folder-browser-factory.c (folder_browser_factory): Don't
hardcode "inbox" here.
* folder-browser.c (folder_browser_set_uri): Don't hardcode
"inbox" here either.
(folder_browser_load_folder): Create a new store according to the
folder browser's URI, and load the mbox file from that store.
Parts of this are temporary.
* session.c, mail.h: There is no longer a global store, just a
global session.
* mail-config.c, mail-ops.c: Update for default_session -> session
change. fetch_mail is currently broken.
2000-05-06 Dan Winship <danw@helixcode.com>
* mail-config.c: New code to configure identity, mail source, and
mail transport.
(mail_config_druid): A druid using the config widgets. (Only
allows configuration of a single identity, source, and transport.)
* mail-ops.c (check_configured): New function to make sure the
user has configured stuff, and call the druid if not.
(fetch_mail, send_msg, send_to_url, reply, forward_msg): Call
check_configured
(composer_send_cb): Make this pass the message to a CamelTransport
rather than just printing it to stdout.
* folder-browser-factory.c (development_warning): Add a warning
about sending mail, since you can do that now.
2000-05-06 Chris Toshok <toshok@HelixCode.com>
* .cvsignore: ignore evolution-mail.pure
* Makefile.am: add support for building evolution-mail.pure
2000-05-06 Dan Winship <danw@helixcode.com>
* mail.h: consolidate mail-format.h, mail-identify.h, mail-ops.h,
main.h and session.h into this new file. There's no reason to have
a .h for every .c.
2000-05-05 Anders Carlsson <andersca@gnu.org>
* test-mail.c (create_container): Use the OAFIID when using an
OAF-enabled build of bonobo.
2000-05-04 NotZed <NotZed@HelixCode.com>
* message-list.c (message_list_set_folder): Get the whole message
summary right away.
(folder_changed): And if we change too.
(ml_row_count): Use the match count or summary table length as the
row count.
(get_message_info): Use array references to lookup message summary
info. For the search result list, use the summary_search_cache to
cache the info lookup.
(message_list_init): Allocate the summary search cache.
(message_list_destroy): Free the summary search cache and the
summary table, if there is one to free.
(message_list_set_search): Save the match count, and clear the
summary search cache for reuse.
(folder_changed): Re-retrieve the summary list if the folder has
changed.
(message_list_set_folder): Retrieve the summary list when opening
the folder.
2000-05-03 Jason Leach <leach@wam.umd.edu>
* Makefile.am (evolution_mail_LDADD): s/-lunicode/$(UNICODE_LIBS)/
in the LDADD section.
2000-05-03 Dan Winship <danw@helixcode.com>
* mail-format.c (write_recipients_to_stream, write_headers): Make
the "Cc:" field optional again. (Before, we could check if
camel_mime_message_get_recipients returned NULL, but now we need
to actually look into the returned CamelInternetAddress object.)
2000-05-03 Larry Ewing <lewing@helixcode.com>
* folder-browser.c (folder_browser_gui_init): comment out the
changed signal for now.
2000-05-02 Matt Loper <matt@helixcode.com>
* Makefile.am: set G_LOG_DOMAIN.
2000-05-02 Larry Ewing <lewing@helixcode.com>
* message-list.c (message_list_set_search): only free search if it
is not NULL.
2000-05-02 NotZed <NotZed@HelixCode.com>
* folder-browser.c (folder_browser_gui_init): Connect the changed
signal to search, so it searched immediately?
2000-05-01 NotZed <NotZed@HelixCode.com>
* pixmaps.h: Added envelope-deleted state.
* folder-browser-factory.c: Setup callback for actual delete op.
(control_activate): Setup a tool menu item to expnge deleted
messages.
* mail-ops.c (delete_msg): Toggle the delete flag on a message.
(expunge_folder): New function to expunge deleted messages from
the current folder.
* folder-browser.c (folder_browser_gui_init): A hackish little
quick-search entry.
(search_activate): Perform a quick-search on the folder subject
only.
(folder_browser_gui_init): Add an option meny to the search line.
(create_option_menu): Build the option menu from a table.
(search_set): Build a search from another string whent he option
menu or text item is changed. 5 search options are defined so
far.
* message-list.c (get_message_info): If there is an active search,
then get the data from that ... use this instead of
_get_message_info().
(ml_row_count): If we have an active search, get the info from its
result.
(select_msg): Changed to use get_message_info, so searches work.
(ml_value_at): And same here.
(message_list_init_renderers): Added a 3rd state to message_status
= deleted.
(ml_value_at): Show the message state as deleted, if it is marked
for deletion.
(folder_changed): When the folder changes, update the display.
(message_list_set_folder): Connect to the folder_changed event
here.
(message_changed): Callback to update the display when the message
changes.
(select_msg): And connect to the message_changed signal so we know
when it cahgnes.
(message_list_set_search): Save the search string.
(folder_changed): If the folder changes, re-run the search,
otherwise we may end up with invalid entries in the display.
* mail-display.c: Include missing errno.h.
2000-04-30 Dan Winship <danw@helixcode.com>
* session.c (session_providers_init): This is no longer necessary.
* mail-ops.c (fetch_mail): Remove kludge to load remote provider,
as camel can do it by itself now.
2000-04-29 Dan Winship <danw@helixcode.com>
* mail-display.c (on_link_clicked): Handle clicks on "cid" URLs by
popping up a "Save Attachment" dialog.
* mail-format.c (get_cid): if the part has a Content-Disposition
with a filename specified, record (a sanitized version of) that on
the wrapper when creating the cid reference, so the "save
attachment" code can use it later.
(handle_mystery): fix a bug in the cid generation here.
2000-04-29 Dan Winship <danw@helixcode.com>
* mail-format.c (lookup_handler, etc): Improve the builtin vs
bonobo selection code.
(handle_mystery): Include name and Content-Description in the
"mystery data" info, when available
(handle_unknown_type): Call mail_identify_mime_part before
giving up.
(handle_undisplayable): Split out of handle_unknown_type now
that handle_unknown_type can try alternate viewers.
(handle_via_bonobo): Fall back to handle_undisplayable if the
bonobo control fails.
* mail-identify.c (mail_identify_mime_part): New function to
attempt to identify a MIME part that we can't identify based on
Content-Type alone.
* mail-display.c (on_url_requested): redo the mystery data icon
display stuff less kludgily.
2000-04-28 Dan Winship <danw@helixcode.com>
* mail-format.c (write_recipients_to_stream, write_headers,
mail_generate_reply): Update (minimally) for Camel recipient
changes.
2000-04-28 Ettore Perazzoli <ettore@helixcode.com>
* main.c (init_bonobo): Don't call `init_corba()' and don't get
any args.
(init_corba) [!USING_OAF]: Fix args.
2000-04-27 Ettore Perazzoli <ettore@helixcode.com>
* folder-browser-factory.c: New macro `CONTROL_FACTORY_ID', which
is #defined to a different value according to whether we are
`USING_OAF' or not.
(folder_browser_factory_init): Use `CONTROL_FACTORY_ID'.
* test-mail.c
(init_corba): New helper function, implemented differently
according to `USING_OAF'.
(main): Use `init_corba()'.
* main.c
(init_corba): New helper function, implemented differently
according to `USING_OAF'.
(init_bonobo): Use `init_corba()'.
* Makefile.am: Install OAF stuff if `USING_OAF'. Add
`-I$(datadir)/idl' to the `orbit-idl' command-line so that we can
use Bonobo IDL files installed under our prefix as well. Also,
use `$(ORBIT_IDL)' instead of hardcoded `orbit-idl'.
* evolution-mail.oafinfo: New file.
2000-04-27 Dan Winship <danw@helixcode.com>
* mail-format.c: Move text_to_html to e-util.
* mail-ops.c (send_to_url): New routine. Thin wrapper for
e_msg_composer_new_from_url.
* mail-display.c (on_link_clicked): print a warning for news or
nntp URLs (which we'll deal with some day), and call send_to_url
for mailto URLs.
* mail-format.c (text_to_html): Improve URL conversion code.
Recognize https, recognize "www\..*" without a prefixed "http://".
Properly escape &, <, >, etc in URL strings. Don't be fooled by
"mailto:", "http://", etc with no following data.
2000-04-26 Dan Winship <danw@helixcode.com>
* mail-format.c (text_to_html): Reorganize a bit and add a new
flag, TEXT_TO_HTML_CONVERT_URLS to recognize and wrap URLs
in text.
* mail-display.c (mail_html_new): Add link_clicked signal handler.
(on_link_clicked): Use gnome_url_show to launch a browser.
* mail-format.c: update for CamelStream changes. Update for
CamelMimeBodyPart -> CamelMimePart
2000-04-25 Dan Winship <danw@helixcode.com>
* mail-display.c, mail-format.c: Redo large chunks of this. The
mail display now consists of a vbox in a scrolled window, in which
we put multiple GtkHTML objects. This means broken HTML in one
part can't corrupt other parts. The headers now scroll with the
body. Unrecognized attachments look prettier, but still don't do
anything, and will probably be changed later. We can also now
display nested message/rfc822 parts and multipart/alternatives
with multipart subparts. Oh, and text/{richtext,enriched}, since
we had all these ancient sample messages that use it and the lack
of support annoyed me. :)
Bonobo embeddables are broken right now, but I don't think that's
my fault.
* mail-format.c (reply_body): Fix some bugs that crept into reply
generation. This needs a lot more work to deal correctly with
complicated bodies.
(setup_function_table): pass unknown text subtypes to
handle_text_plain.
(handle_multipart_appledouble): new handler. Just ignores the
first (application/applefile) part and tries to display the
second part. Since the second part is usually
application/octet-stream, this doesn't work very well still
usually.
(reply_body): Make this deal better with multiparts.
* mail-format.c, mail-display.c: Now that we're not limited to
a single GtkHTML for the display, there's no reason to embed
Bonobo objects for unrecognized content-types in GtkHTML rather
than embedded them into the vbox directly. So do that.
Meanwhile, fix up the handler-selection code so that we can
declare which built-in handlers are more desirable than external
handlers and which are less. (Of course, eventually we'll want
this to be customizable.) Add some cleverness to
handle_multipart_alternative as well so it doesn't accept an
alternative which we can display generically over one we can
display specifically.
* mail-format.c (text_to_html): add a convert_space_hack flag,
which turns N spaces into N-1 s and a space.
(handle_text_plain): Check for "format=flowed" in the
Content-Type.
(handle_text_plain_flowed): Spinoff of handle_text_plain to deal
with RFC 2646 flowed text. (All the examples I can find of it
are generated by Eudora, but it's a pretty cool idea that ought
to be used more widely.)
2000-04-23 Dan Winship <danw@helixcode.com>
* folder-browser-factory.c: rename "send" to "send_msg", to avoid
name clash with the tcp function. Connect the "forward" button.
* mail-ops.c: rename "send" to "send_msg", to avoid name clash
with the tcp function. Add forward_msg function.
* mail-format.c (mail_generate_forward): support function for
forward_msg. Pretty much a big kludge right now, pending the
attachment/attachment-bar changes.
2000-04-22 Dan Winship <danw@helixcode.com>
* mail-display.c (on_url_requested): Change cid expectations to
match current camel reality.
* main.c (main): call glade_gnome_init, for composer.
* folder-browser-factory.c: move msg_composer_cb and
msg_composer_send_cb to mail-ops. Attach send, reply, and "reply
to all" buttons.
* mail-ops.c (composer_send_cb, send): moved from
folder-browser-factory.c.
(reply_to_sender, reply_to_all): new functions to do replies.
* mail-format.c (text_to_html): Add an "add_pre" flag, to make
it wrap the output in <pre></pre>.
(mail_generate_reply): New function to create a composer and build
a reply in it.
2000-04-21 Dan Winship <danw@helixcode.com>
* mail-display.c (on_url_requested): deal with cid: URLs.
(find_cid): helper routine for above. (This could be much better.)
(mail_display_init): connect url_requested signal
* mail-format.c (handle_multipart_related): Make this work.
* mail-display.c (mail_display_set_message): ref the message we
display, since we're going to unref it when we remove it. Fixes a
bug that showed up with the new camel code, but it's not obvious
if it's due to a bug or a feature in the new code.
2000-04-20 NotZed <NotZed@HelixCode.com>
* Makefile.am (evolution_mail_LDADD): Add libibex.la to link.
* message-list.h: Removed folder summary.
* message-list.c: Dont include folder-summary anymore.
(select_msg): Changed to use folder, not summary in
summary_get_message_info(). God this code is grotty.
(ml_value_at): Ditto.
(ml_value_at): Changed to use new interface. Hmm, this returns a
static variable, that seems wrong.
(message_list_set_folder): Remove folder summary.
(ml_row_count): Oops, remove some debug i put there.
2000-04-20 Dan Winship <danw@helixcode.com>
* mail-display.c: update for bonobo change, and remove a
now-unused variable.
2000-04-17 Chris Toshok <toshok@helixcode.com>
* message-list.c (on_row_selection_idle): new function, actually
calls select_msg.
(on_row_selection_cmd): register an idle instead of calling
select_msg directly. this fixes the lag before the row is
selected - selection is instantaneous now, with message loading
happening afterward.
* message-list.h: add row_to_select and an idle_id to the message
list to make the select_msg call happen in an idle func.
* message-list.c (message_list_init_renderers): no more
e_cell_set_editable. this info always comes from the model.
2000-04-14 Dan Winship <danw@helixcode.com>
* mail-format.[ch]: Moved from camel/camel-formatter, and changed
slightly. (More to come.)
* html-stream.[ch]: No longer necessary. mail-format uses
GtkHTMLStreamHandles directly.
* mail-display.[ch]: update for new message formatting code.
2000-04-14 Chris Toshok <toshok@helixcode.com>
* folder-browser-factory.c (control_activate): use
gnome_app_fill_toolbar_with_data, so we get the beautiful gnome
toolbar.
2000-04-14 Dan Winship <danw@helixcode.com>
* folder-browser-factory.c (development_warning): Fix up the
warning message a bit.
(folder_browser_factory): Make the warning bypassable.
2000-04-12 Miguel de Icaza <miguel@gnu.org>
* main.c (main): Call e_cursors_init.
2000-04-10 Dan Winship <danw@helixcode.com>
* mail-ops.c (fetch_mail): use camel_movemail when fetching mail
from an mbox store. This leaves behind temp files for now,
because CamelMboxFolder::delete is too confused to use, and NotZed
is rewriting CamelMboxFolder, so I'm not going to bother to try to
fix it.
* mail-ops.c: Add some #includes for the non-HAVE_MKSTEMP case
2000-04-09 Matt Loper <matt@helixcode.com>
* folder-browser.c (folder_browser_new): set folder_browser->uri
to NULL, so that we know when to free it.
2000-04-07 Miguel de Icaza <miguel@gnu.org>
* message-list.c (states_pixmaps): Add more beautiful art from
Miggue, the Diego Rivera of the next millenium.
(message_list_init_header): Use the beautiful art.
* pixmaps: Miguel rediscovers the "transparent" concept.
2000-04-07 Matt Loper <matt@helixcode.com>
* folder-browser.c (folder_browser_destroy): Unref the shell
interface that we have a handle to.
* folder-browser-factory.c (control_destroy_cb): New function;
destroys a folder-browser when its control is destroyed.
(folder_browser_factory): Hook up to the above.
2000-04-07 Dan Winship <danw@helixcode.com>
* mail-ops.c: new file, for toolbar/menu callbacks
(fetch_mail): fetch mail. Doesn't do mbox locking. Many kludges.
* folder-browser-factory.c (control_activate): use new fetch_mail
function as the callback for the "New mail" icon. Rename check_cb
to random_cb.
* Makefile.am: don't build test-sources since the version in
CVS doesn't do much and once I've fixed it it won't be a separate
program. Add mail-ops.[ch].
2000-04-06 Miguel de Icaza <miguel@gnu.org>
* message-list.c: Stick pixmaps here.
* mail-display.c (embeddable_destroy_cb): Replaced C++ comments
with C comments.
* message-list.c (load_internal_images): New function, loads images.
(message_list_init_renderers): Load images, fix previous attempt
at loading images.
* Makefile.am (dist-hook): Added distribution of pixmaps.
* pixmaps: New directory, used to hold the XPMs we ship with.
* pixmaps/envelope-closed.xpm, pixmaps/envelope-open.xpm: Tigert's
envelopes incorporated.
2000-03-31 Miguel de Icaza <miguel@gnu.org>
* message-list.c (ml_value_at): Fix miss-used variable.
2000-04-01 Michael Meeks <michael@helixcode.com>
* folder-browser.c (folder_browser_properties_init): update to
new property (folder_browser_property_changed): kill.
(get_prop, set_prop): do the donkey work + make properly RW.
2000-03-31 Dan Winship <danw@helixcode.com>
* folder-browser-factory.c (folder_browser_set_shell):
* folder-browser.c (folder_browser_new):
* message-list.c (on_row_selection_cmd, select_msg,
message_list_init, message_list_set_folder):
remove debugging printf()s that no longer seem useful
2000-03-29 Dan Winship <danw@helixcode.com>
* folder-browser-factory.c (control_activate): build a toolbar.
(control_deactivate): and hide it.
2000-03-27 Chris Toshok <toshok@helixcode.com>
* mail-display.c: quiet warnings when building in ../po
2000-03-26 Miguel de Icaza <miguel@gnu.org>
* folder-browser-factory.c (folder_browser_set_shell): Memory leak
fix.
2000-03-25 Dan Winship <danw@helixcode.com>
* message-list.c (select_msg, ml_value_at): update for summary
changes. Hey, neat, it really does make it more efficient.
2000-03-22 Christopher James Lahey <clahey@helixcode.com>
* .cvsignore: Updated .cvsignore.
2000-03-21 Matt Loper <matt@helixcode.com>
* mail-display.c: Minor cleanup & commenting.
* folder-browser-factory.c: Minor cleanup & warning elimination.
2000-03-21 bertrand <bertrand@helixcode.com>
* message-list.c (ml_value_at): display message size
2000-03-20 Christopher James Lahey <clahey@helixcode.com>
* message-list.c: Properly ref & sink the table and header models.
2000-03-14 Dan Winship <danw@helixcode.com>
* mail-sources.c: First cut at a mail source selection wizard.
Basically a rigged demo at this point. Doesn't use camel to get
its information, and is not yet complete or integrated with the
mail component. Did I mention that the code is ugly?
2000-03-13 bertrand <bertrand@helixcode.com>
* folder-browser-factory.c (folder_browser_set_shell):
for testing and demonstration purpose, immediately
register a fake service.
2000-03-12 bertrand <bertrand@helixcode.com>
* folder-browser-factory.c (folder_browser_factory_init):
name change.
(control_activate_cb): when the control is activated,
it merges its own UI with the remote UIHandler.
(control_add_menu): sample menu merging.
(folder_browser_factory): connect the control "activate" signal.
* evolution-mail.gnorba:
name changes
* folder-browser.h: added a reference to an
Evolution::Shell object.
* folder-browser-factory.c (folder_browser_set_shell):
(folder_browser_control_add_service_repository_interface):
(folder_browser_factory): the folder-browser control now
implements the Evolution/ServiceRepository interface.
2000-03-07 bertrand <bertrand@helixcode.com>
* folder-browser-factory.c (development_warning):
added a warning so that the user knows that this
version may crash his mails.
2000-03-05 bertrand <bertrand@helixcode.com>
* message-list.h: include a referrence to the parent
folder browser.
* message-list.c (ml_value_at): use the message summary
from the
* html-stream.c (html_stream_close): when the stream
is closed, set the html stream to NULL
(html_stream_write): don't write anything if the
html handle does not exist.
(html_stream_reset): implemented. close the current
html handle and begins a new html parser.
* session.c (session_store_new): use static exception
here.
2000-03-05 Christopher James Lahey <clahey@helixcode.com>
* message-list.c: Added a prototype message listing.
2000-03-04 Christopher James Lahey <clahey@helixcode.com>
* message-list.c: Set up the column headers properly.
* folder-browser.c: Show the folder_browser widget.
2000-03-04 Christopher James Lahey <clahey@helixcode.com>
* message-list.c: Define ml_duplicate_value and ml_free_value
correctly.
2000-03-04 Christopher James Lahey <clahey@helixcode.com>
* message-list.c: Use g_int_compare and g_str_compare as we should
be instead of g_int_equal and g_str_equal.
2000-03-04 bertrand <bertrand@helixcode.com>
* test-mail.c (main): replace the bonobo-active/gtk-main
by bonobo-main.
Include Gnorba headers.
(main): don't call the container creation routine
before we entered the main loop. Use idle for that.
2000-03-04 Christopher James Lahey <clahey@helixcode.com>
* message-list.c: Change this to use the ETable widget itself
instead of building it from all the parts.
2000-03-03 Christopher James Lahey <clahey@helixcode.com>
* message-list.c: Ref the table columns since we unref them at the
end.
2000-03-01 Ettore Perazzoli <ettore@helixcode.com>
* Makefile.am (INCLUDES): Add `$(top_srcdir)'. Also, the
`top_srcdir' includes must come first everything else to avoid
including installed headers instead of our fresh ones.
2000-02-28 NotZed <NotZed@HelixCode.com>
* Makefile.am (evolution_mail_LDADD): Fixed references to eutil.
2000-02-24 Christopher James Lahey <clahey@helixcode.com>
* message-list.c: Changed to match new e_table_simple interface.
2000-02-24 Dan Winship <danw@helixcode.com>
* message-list.c (message_list_set_folder): update for CamelFolder
changes
2000-02-24 Christopher James Lahey <clahey@helixcode.com>
* message-list.c: Changed this to not use the "x" and "y"
arguments to e-table-item.
2000-02-23 Matt Loper <matt@helixcode.com>
* message-list.c (message_list_set_folder): Check 'desc'riptions
of exceptions.
2000-02-22 bertrand <Bertrand.Guiheneuf@aful.org>
* message-list.c (message_list_set_folder):
fix to show a sample correct implementation.
2000-02-21 Matt Loper <matt@helixcode.com>
* Makefile.am: added -lunicode to evolution_mail_LDADD.
2000-02-21 Dan Winship <danw@helixcode.com>
* session.c (session_store_new): Pass a CamelAuthCallback
(evolution_auth_callback) to camel_session_new.
2000-02-21 Dan Winship <danw@helixcode.com>
* session.c (session_store_new): Update session_store_new to
deal with the fact that camel_session_get_store takes a
CamelException now. Doesn't actually do anything with the
exception yet, because nothing else does yet either.
2000-02-19 Matt Loper <matt@helixcode.com>
* .cvsignore: added test-mail.
2000-02-14 Miguel de Icaza <miguel@gnu.org>
* folder-browser.c (folder_browser_load_folder): New routine,
loads a camel folder.
(folder_browser_set_uri): redo.
* session.c: new file. Implements SessionStores to keep track of
a Session/Store tuple.
2000-02-13 Matt Loper <matt@helixcode.com>
* html-stream.c (html_stream_new): Second param of gtk_html_begin
should be "", not NULL.
(html_stream_new): gtk_html_parse() is deprecated, so the call was
removed.
* html-stream.h: HTMLStreamClass's parent changed to
CamelStreamClass, not CamelStream.
2000-02-11 Christopher James Lahey <clahey@helixcode.com>
* Makefile.am: Add the e-text directory to the includes list.
* message-list.c: Change the call to e_cell_text_new, since
there's an added argument.
2000-02-09 Christopher James Lahey <clahey@helixcode.com>
* Makefile.am: Added libetext as libetable depends on it.
2000-02-08 Iain Holmes <ih@csd.abdn.ac.uk>
* Makefile.am: Changed the order of the compilation so the CORBA stuff
was made before it was needed.
2000-01-19 Miguel de Icaza <miguel@gnu.org>
* Started work on the mail display engine.
* html-stream.c, html-stream.h: New files, they are CamelStreams
used to write to the GtkHTML widget.
|