2004-10-11 Not Zed * gui/e-cert-selector.c (e_cert_selector_new): dont try to deference NULL nickname or emailAddr on the cert. 2004-09-03 Not Zed ** See bug #64420. * lib/e-pkcs12.c (prompt_for_password): set the outptr after we've actually got a pointer for it allocated. 2004-08-16 Not Zed ** See bug #62963. * gui/cert-trust-dialog.c (ctd_response): fix c99 syntax. Spotted by Vincent Noel 2004-08-12 Carlos Garnacho Parro * gui/certificate-manager.c: Optionally use GtkFileChooser if compiled against Gtk+ >= 2.4.0 2004-08-10 Not Zed * gui/component.c (smime_pk11_passwd, smime_pk11_change_passwd): * lib/e-pkcs12.c (prompt_for_password): api change in e_passwords. 2004-08-02 Jeffrey Stedfast * lib/e-pkcs12.c (prompt_for_password): Fixed to work for both LE and BE architectures. 2004-07-16 Chris Toshok [ fixes #61490 ] * lib/e-cert-db.c (e_cert_db_import_pkcs12_file): un-ifdef this, as it's working.. (e_cert_db_export_pkcs12_file): and ifdef this one, since it's the function i meant to ifdef in the first place. 2004-06-17 JP Rosevear Fixes #56458 * gui/smime-ui.glade: make the buttons vertical 2004-06-17 Not Zed ** See #59885. * lib/e-cert-db.c (e_cert_db_import_pkcs12_file): move the #if notyet stuff inside the function so the symbol is defined, since we call it eslewhere. i dunno if it actually works yet. 2004-06-15 Jeffrey Stedfast * lib/Makefile.am: Added smime-marshal.list to EXTRA_DIST 2004-06-08 Chris Toshok * lib/e-cert-db.[ch]: quiet the compiler, and dobey. 2004-05-28 Not Zed * gui/certificate-manager.c (initialize_yourcerts_ui): set some columns resizable. (initialize_contactcerts_ui): same. ** See bugs #52061 & #52669. * gui/smime-ui.glade: added cert-trust-dialog and tweaked the ca-trust-dialog. * gui/ca-trust-dialog.c (ca_trust_dialog_show): Fix the %s in the label. Slack. (ca_trust_dialog_show): slight rearrangement. * gui/certificate-manager.c (add_contact_cert): fill out fields. * lib/e-cert.c (e_cert_get_usage): helper to get the usage of a cert. * gui/certificate-manager.c (edit_ca): use the right certdb, not the e-one. (add_user_cert): fill out missing columns. * lib/e-cert.c (e_cert_get_ca_cert): new method to find the ca cert of a cert. * gui/cert-trust-dialog.[ch]: peer cert trust editor. * gui/certificate-manager.c (edit_contact): implement. 2004-05-17 Jon Oberheide * gui/e-cert-selector.c (e_cert_selector_new): add "Select certificate" title to the previously untitled dialog. 2004-05-19 James Willcox * lib/e-cert-db.c: (pk11_password): Don't crash when the user presses 'cancel'. Fixes #58733. 2004-05-13 Not Zed * lib/e-cert-db.c (e_cert_db_login_to_slot): call SetPasswordFunc before calling authenticate - some nss calls can overwrite the setting. #52820. 2004-04-30 Chris Toshok [ fixes bug #52724 ] * gui/ca-trust-dialog.c (ca_trust_dialog_set_trust): new function, set the toggle buttons' states. * gui/ca-trust-dialog.h (ca_trust_dialog_set_trust): add prototype. * gui/certificate-manager.c (edit_ca): flesh out the rest of the editing here. set the existing trust levels and get them back from the dialog when OK is clicked (and store them to the cert db.) 2004-03-24 Chris Toshok * lib/smime-marshal.list: add BOOL:POINTER,POINTER,POINTER,POINTER for confirm_ca_cert_import. * lib/e-cert-db.c (e_cert_db_class_init): initialize the confirm_ca_cert_import signal. (confirm_download_ca_cert): emit confirm_ca_cert_import and use the returned values. (handle_ca_cert_download): fix the ca trust foo. (e_cert_db_import_certs): pass the cerdb to handle_ca_cert_download since we need to emit something on that object. * lib/e-cert-db.h (struct _ECertDBClass): add confirm_ca_cert_import signal. * gui/smime-ui.glade: give names to the check buttons in the ca trust dialog. * gui/component.c (smime_confirm_ca_cert_import): new function, show the trust dialog. (smime_component_init): connect to "confirm_ca_cert_import" signal. * gui/certificate-viewer.c (fill_in_general): fix lots of uninitialized variable accesses. (certificate_viewer_show): don't show the dialog (or connect to the response signal.) that's the caller's job. * gui/certificate-manager.c (view_your): do the showing of the certificate_viewer here. (view_contact): same. (view_ca): same. (edit_ca): new function, pop up the ca trust dialog. we need more here though, to fill in the toggle buttons when bringing up the dialog, and also to save out the settings when the user clicks ok. (initialize_authoritycerts_ui): hook up the edit_ca button. * gui/Makefile.am (libevolution_smime_la_SOURCES): add ca-trust-dialog.[ch]. * gui/ca-trust-dialog.[ch]: new file implementing the ca trust dialog used for importing/editing ca trust levels. 2004-03-19 Chris Toshok [ fixes bug #52667 ] * gui/certificate-manager.c (import_ca): don't expand the CA tree by default. (populate_ui): same. 2004-03-19 Chris Toshok [ fixes bug #52829 ] * lib/smime-marshal.list: add BOOL:POINTER,POINTER for pk11_change_passwd. * lib/e-cert-db.c (e_cert_db_class_init): initialize the pk11_change_passwd signal. (e_cert_db_login_to_slot): emit "pk11_change_passwd" with old_passwd == NULL to initialize the database. * lib/e-cert-db.h: add pk11_change_passwd signal slot. * gui/component.c (smime_pk11_change_passwd): implement the portion of this that gets called with old_passwd == NULL (the only part that needs implementing yet, since we don't have a UI for changing the password.) (smime_component_init): hook up to the pk11_change_passwd signal on ECertDB. 2004-03-10 Rodney Dawes * gui/certificate-viewer.c (certificate_viewer_show): Fix the border width setting for the button area, to be HIG-compliant * gui/smime-ui.glade: Update some border widths for the cert viweer Remove dialog separators (This portion from William Jon McCann) 2004-02-26 Jeffrey Stedfast * gui/component.c: include config.h 2004-02-24 JP Rosevear * gui/Makefile.am: fix includes for builddir != srcdir 2004-02-11 Jeffrey Stedfast * lib/e-pkcs12.c: #include (e_pkcs12_export_to_file): Hmm. I gather this needs to be implemented. return FALSE here until someone implements this so gcc doesn't complain about control reaching the end of a non-void function. (handle_error): Same. * lib/e-cert-trust.c: And here. * lib/e-cert-db.c: Same. * lib/e-asn1-object.c: And here. * lib/e-cert.c: Here too. * gui/e-cert-selector.c: Same. * gui/certificate-viewer.c: Same. * gui/certificate-manager.c: #include 2004-01-07 Not Zed * gui/e-cert-selector.c (ecs_find_current): check certlist != NULL, CERT_LIST_EMPTY dereferences it. Bug #52457. 2004-01-05 Chris Toshok * lib/e-cert-db.c (e_cert_db_login_to_slot): oops, remove hardcoded test passwd :) * gui/component.c (smime_pk11_passwd): new function, implement the password dialog for PK11 slot authentication. (smime_component_init): new function, initialize any gui related signals that the backend exposes. * gui/certificate-manager.c (import_your): use e_cert_db_import_pkcs12_file. (delete_your): new function, implement. (view_your): same. (backup_your): new function, stub out. (backup_all_your): same. (create_yourcerts_treemodel): new function. (initialize_yourcerts_ui): do all the sorting foo, and hook up all the signals. (ainitialize_contactcerts_ui): same. (initialize_authoritycerts_ui): same. (view_contact): treemodel -> streemodel. (view_ca): same. (delete_contact): same, and convert from the sort iter to the child iter before we remove. (delete_ca): same. (import_contact): call gtk_tree_view_expand_all. (import_ca): same. (add_user_cert): append to the child model, not the sort model. (add_contact_cert): same. (add_ca_cert): same. (unload_certs): implement the E_CERT_USER case, and fix the USER/CA stuff to use the sorted treemodels. (load_certs): remove spew. (populate_ui): expand all the tree views. * lib/.cvsignore: ignore the generated marshalling files. * lib/Makefile.am: add the marshalling foo. * lib/smime-marshal.list (BOOL): new file. * lib/e-cert-db.c (pk11_password): new function, emit the pk11_passwd signal. (initialize_nss): new function, split out all the nss init code here, and add all the PKCS12 cipers. (install_loadable_roots): new function, split this code out from the class_init. (e_cert_db_class_init): call initialize_nss() and install_loadable_roots(). also register our pk11_passwd signal. (e_cert_db_import_pkcs12_file): implement. (e_cert_db_login_to_slot): new function, implement. * lib/e-cert-db.h (struct _ECertDBClass): add pk11_passwd signal, and add prototype for e_cert_db_login_to_slot. * lib/e-pkcs12.c (input_to_decoder): remove spew. (prompt_for_password): fix this. (import_from_file_helper): fix fix fix, and remove spew. (write_export_file): nuke, we don't need this. 2004-01-04 Chris Toshok * gui/certificate-viewer.c (fill_in_general): use markup around the fingerprints, and italicize the Not part of certificate text. (fill_in_details): create a monospace text tag to be used in the field value textbuffer. (fields_selection_changed): use the text tag when inserting text. 2003-12-10 Not Zed * gui/e-cert-selector.c (e_cert_selector_new): if we get no matching certs, show empty menu rather than crashing. #51922. 2003-12-05 JP Rosevear * lib/e-cert.c: fix for C89 2003-12-04 Chris Toshok * gui/certificate-viewer.c (certificate_viewer_show): set the window title based on e_cert_get_window_title. * lib/e-cert.c (e_cert_get_window_title): new function, for use with the certificate viewer. (create_asn1_struct): call e_cert_get_window_title. 2003-12-04 Chris Toshok * lib/e-cert.h: add prototype for e_cert_get_asn1_struct. * lib/e-cert.c (e_cert_dispose): unref the asn1 object. (get_int_value): copy and massage from mozilla source. (process_version): same. (process_serial_number_der): same. (get_default_oid_format): same. (get_oid_text): same. (process_raw_bytes): same. (process_sec_algorithm_id): same. (process_subject_public_key_info): same. (process_ns_cert_type_extensions): same. (process_key_usage_extensions): same. (process_extension_data): same. (process_single_extension): same. (process_extensions): same. (process_name): same. (create_tbs_certificate_asn1_struct): same. (create_asn1_struct): same. (e_cert_get_asn1_struct): new function. * lib/e-asn1-object.c (e_asn1_object_dispose): free the display name, value, and children. (e_asn1_object_init): assume it's a valid container unless we hear otherwise. (e_asn1_object_new_from_cert): nuke. (e_asn1_object_set_valid_container): implement. (e_asn1_object_append_child): same. (e_asn1_object_set_display_name): same. (e_asn1_object_set_display_value): same. * lib/e-asn1-object.h: add prototypes for e_asn1_object_set_valid_container, e_asn1_object_set_display_name, e_asn1_object_set_display_value, and e_asn1_object_append_child. * gui/certificate-viewer.c (populate_fields_tree): populate the tree from the asn structure. (hierarchy_selection_changed): blow away the old fields_tree content and populate it again. (fields_selection_changed): implement, set the text view's contents to the asn1 object's display_value. (fill_in_details): expand all nodes in the hierarchy tree. 2003-12-03 Chris Toshok * lib/Makefile.am (libessmime_la_SOURCES): add e-asn1-object.[ch] * gui/smime-ui.glade: rename the ca trust dialog, and give it a proper id. * gui/certificate-manager.c (yourcerts_selection_changed): just use @selection. (contactcerts_selection_changed): same. (authoritycerts_selection_changed): same. * gui/certificate-viewer.c (free_data): free the cert chain. (fill_in_general): move all the general tab stuff here. (hierarchy_selection_changed): new function. not finished. (fields_selection_changed): new function, unimplemented. (fill_in_details): new function, fill in the heirarchy and hook up signals and stuff. (certificate_viewer_show): call fill_in_general/fill_in_details. * lib/e-cert.c (e_cert_get_chain): new function. * lib/e-cert.h: add prototype for e_cert_get_chain. 2003-12-03 Chris Toshok * lib/e-cert-db.c (e_cert_db_class_init): grovel around at startup time for mozilla's pkcs11 module so we can get the same default set of root certs. 2003-11-30 Larry Ewing * lib/e-pkcs12.c (nickname_collision): make sure declarations precede logic for older compilers. * gui/Makefile.am (INCLUDES): don't define GTK_DISABLE_DEPRECATED it breakes on gtk-2.3 with gtk_option_menu_get_history. 2003-11-26 Chris Toshok * gui/certificate-viewer.[ch]: mostly implement a viewer for certificates. * gui/smime-ui.glade: fingerprints-sh1 -> fingerprints-sha1. * gui/certificate-manager.c (import_your): new function, use e-pkcs12 to implement it. (initialize_yourcerts_ui): hook up the import button. (view_contact): new function, bring up the certificate viewer. (initialize_contactcerts_ui): hook up the view button. (view_ca): new function, bring up the certificate viewer. (initialize_authoritycerts_ui): hook up the view button. * gui/Makefile.am (libevolution_smime_la_SOURCES): add certificate-viewer.[ch] * lib/e-cert.c (e_cert_dispose): free all the new cached foo. (e_cert_populate): populate all the new cached foo. (e_cert_get_issuer_cn): new function. (e_cert_get_issuer_org): same. (e_cert_get_issuer_org_unit): same. (e_cert_get_issued_on_time): same. (e_cert_get_issued_on): same. (e_cert_get_expires_on_time): same. (e_cert_get_expires_on): same. (e_cert_get_serial_number): same. (e_cert_get_sha1_fingerprint): same. (e_cert_get_md5_fingerprint): same. * lib/e-cert.h: add prototypes for lots more accessors. * lib/e-cert-db.c (e_cert_db_find_cert_by_key): fix typo. (e_cert_db_find_cert_by_email_address): call CERT_DestroyCertificate to free the cert. (default_nickname): new function. (e_cert_db_import_user_cert): implement. (e_cert_db_import_server_cert): add blurb. * lib/e-pkcs12.[ch]: new files. * lib/Makefile.am (libessmime_la_SOURCES): add e-pkcs12.[ch] 2003-11-12 Not Zed * gui/smime-ui.glade: added cert_selector widget to be placed inside a dialog. * gui/e-cert-selector.[ch]: new class to allow user to select a certificate for signing or encrypting. 2003-11-12 Chris Toshok * lib/e-cert.c (e_cert_get_cert_type): implement using the e-cert-trust foo. (e_cert_get_email): implement. * lib/e-cert.h: add UNKNOWN cert type. * gui/smime-ui.glade: fix capitalization of "Import" on the contact certificate page. * gui/certificate-manager.c (import_contact): new function. implement email cert importing. (delete_contact): new function. (unload_certs): implement for E_CERT_CONTACT. (certificate_manager_config_control_new): get the contact cert action buttons from libglade. * lib/e-cert-db.c (handle_ca_cert_download): mostly implement the trust settings correctly. this still needs work pending the CA trust dialog's completion. (e_cert_db_delete_cert): fix the ifdef'ed code. (e_cert_db_import_user_cert): remove the ifdef'ed body of this, since it was copied from the CA code. * lib/Makefile.am (libessmime_la_SOURCES): add e-cert-trust.[ch] * lib/e-cert-trust.[ch]: new files, basically c&p nsNSSCertTrust from mozilla's PSM. 2003-11-11 Chris Toshok * tests/import-cert.c (main): don't init NSS here. it's done in e_cert_db_peek. * lib/Makefile.am (libessmime_la_SOURCES): add e-cert-db.[ch] * gui/smime-ui.glade: set the initial sensitivity of the buttons here, and add the beginnings of the CA import dialog (where you assign trust levels to it.) * gui/certificate-manager.c (handle_selection_changed): sensitize/desensitize all the various buttons correctly when the GtkTreeView's selection changes. (yourcerts_selection_changed): new, selection change handler for the Your Certs tab. (initialize_yourcerts_ui): hook up the tree selection, and add a model column for the ECert. (contactcerts_selection_changed): new, selection change handler for the Contact Certs tab. (initialize_contactcerts_ui): hook up the tree selection, and add a model column for the ECert. (import_ca): new function. (delete_ca): new function. (authoritycerts_selection_changed): new, selection change handler for the Authority Certs tab. (create_authoritycerts_treemodel): new function for creating the authority cert tree model. the other tabs will eventually use a separate function for this too, as unload_certs gets fleshed out. (initialize_authoritycerts_ui): hook up the tree selection, and add import/delete buttons. (destroy_key): dtor for the keys in our hashes. (destroy_value): dtor for the values in our hashes. (unload_certs): new function. basically destroy/recreate the model and hash for the particular cert type/tab. (load_certs): use e_cert_get_cert_type. (populate_ui): use unload_certs as well as load_certs. (certificate_manager_config_control_new): call e_cert_db_peek ,which will initialize all of NSS. hook up all the widgets from libglade. * lib/e-cert.h: add prototypes for all the new methods, and add the ECertType enum. * lib/e-cert.c (e_cert_dispose): handle deletion from the DB here. (e_cert_new_from_der): new function. (e_cert_get_internal_cert): new function. (e_cert_get_raw_der): new function. (e_cert_get_issuer_name): new (e_cert_get_subject_name): new (e_cert_mark_for_deletion): new (e_cert_get_cert_type): new. (e_cert_is_ca_cert): nuke. * lib/e-cert-db.[ch]: new, partly implemented, derived from mozilla's nsNSSCertificateDB code. 2003-10-30 Chris Toshok * gui/certificate-manager.h: add boilerplate. * gui/certificate-manager.c (certificate_manager_config_control_new): return NULL if the NSS_InitReadWrite fails - we should probably give better status though, or return a GtkLabel with an error message.... * gui/Makefile.am (INCLUDES): use CERT_UI_CFLAGS. (TEST_LIBS): use CERT_UI_LIBS. 2003-10-30 Chris Toshok * tests/Makefile.am (INCLUDES): use CERT_UI_CFLAGS. (TEST_LIBS): use CERT_UI_LIBS. 2003-10-28 Chris Toshok * gui/Makefile.am (libevolution_smime_la_SOURCES): add certificate-manager.h 2003-10-23 Chris Toshok * lib/e-cert.[ch], lib/Makefile.am, gui/certificate-manager.[ch], gui/Makefile.am, gui/smime-ui.glade, Makefile.am: initial addition of s/mime foo.