2004-06-28 Not Zed * mail-component.c (impl__get_userCreatableItems): fix accelerators. #56746. 2004-06-23 Jeffrey Stedfast * em-folder-selector.c (em_folder_selector_get_selected_path): Don't prepend the path string with a '/'. * em-folder-tree.c (em_folder_tree_create_folder): This takes a full_name so update the argument to make that clear. (emft_create_folder): Same and also don't strip a leading '/' 2004-06-25 Not Zed * em-folder-tree.c (folder_tree_new): set search column. #60152. 2004-06-24 Rodney Dawes * em-utils.c (em_utils_add_address): Add code to set the parent, position, and type hint of the "Add address" dialog Fixes #60030 2004-06-23 Not Zed ** See #54030. * e-searching-tokenizer.c (e_searching_tokenizer_match_count): only return a count if we're using the primary search string. * em-format-html-display.c (efhd_search_response): set the primary search string to NULL instead of resetting it. (efhd_update_search): dont noop if we have a null search text, just set an empty search. * e-searching-tokenizer.c (e_searching_tokenizer_reset): remove this, revert jeff's fixes for 54030. this is incomplete and so doesn't work either (search text stays remembered and secondary search text lost too). ** See #60523. * em-folder-view.c (emfv_finalise): unhook the folder changed before destroying the async thing, and move it all to destroy event anyway. (emfv_destroy): as above. 2004-06-22 Jeffrey Stedfast * em-folder-tree-model.c (sort_cb): Same as below. (em_folder_tree_model_remove_folders): Same. * em-folder-tree.c (emft_maybe_expand_row): As toshok discovered, gtk_tree_model_get() strdup's string arguments, *sigh*, so we need to free them. (tree_drag_data_delete): Same. (tree_drag_data_get): Same. (tree_drag_data_received): Same. (emft_drop_target): Same (em_folder_tree_get_selected_uris): Same. (get_selected_uris_path_iterate): Same. (emft_update_model_expanded_state): Same. (emft_tree_row_expanded): Same. (emft_tree_row_activated): Same. (emft_popup_delete_response): Same. (emft_popup_delete_folder): Same. (emft_popup_rename_folder): Same. (emft_popup_properties): Same. (emft_tree_button_press): Same. (emft_tree_selection_changed): Same. 2004-06-22 Chris Toshok * em-folder-tree.c (render_pixbuf): gtk_tree_model_get on a string field allocates the return value. free path. 2004-06-22 Jeffrey Stedfast * em-popup.c (emp_apps_open_in): If the app requires a terminal to run, give it a bloody terminal (who uses vi in an xterm to view attached text files? *sigh*). Fixes bug #51259. 2004-06-21 Chris Toshok * em-folder-tree.c (render_display_name): gtk_tree_model_get on a string field allocates the return value. free name. 2004-06-21 Radek Doulik * em-junk-filter.c (em_junk_sa_test_spamd): make sure we test for -p and --port only and not for other options as --pidfile Fixes #60260 (em_junk_sa_test_spamd): try to get spamd/spamc binaries from gconf Implements #59368 2004-06-18 Not Zed ** See #31027. * em-vfolder-editor.c (em_vfolder_editor_new): make sure we construct the rule editor with a source of 'incoming', otherwise newly created rules have no source in the current session. * em-vfolder-rule.c (em_vfolder_rule_init): init the vfolder source to 'incoming' always. * mail-vfolder.c (uri_is_ignore): fix debug statement. ** See #60214. * em-folder-view.c (em_folder_view_print): re-arrange code to make the dialogue async. We also now load the message every time before printing. (emfv_print_response): handle response to print. * em-format-html-print.c (em_format_html_print_message): new api to print a specific uid on a specific folder. 2004-06-18 Not Zed * em-vfolder-rule.c (get_widget): use mail dialogs.glade. * mail-dialogs.glade: move the vfolder-source window here from mail-config.glade. * Makefile.am (glade_DATA): fix the glade list. * mail-license.glade, subscribe-dialog.glade, mail-security.glade, * mail-search.glade: Merged into mail-dialogs.glade. Should be easier to manage. * message-tag-followup.c (construct): use mail dialogs glade file. * mail-account-gui.c (display_license): use mail dialogs glade file. * em-subscribe-editor.c (em_subscribe_editor_new): use new glade file. * em-format-html-display.c (em_format_html_display_search): use merged glade file. (efhd_xpkcs7mime_validity_clicked): same. * mail-dialogs.glade: merge various glade files into here. 2004-06-17 Not Zed ** See #59885. ** Moved all of the mail specific filtering stuff from filter/* to here. Renamed appropriately into em* space, etc. * em-filter-folder-element.c (emff_copy_value): implement for folders. * em-vfolder-rule.c (get_widget): read the vfolder glade from mail-config.glade. * mail-config.glade: moved the vfolder source selector here. * em-search-context.c: new mail search specific rule context. * mail-component.c (setup_search_context): use the new em_search_context. * vfolder-rule.c (validate): change error to mail context. * filter-folder.c (validate): change error to mail context. * Makefile.am (em-filter-i18n.h): added rule for i18n of mail filter type stuff. (libevolution_mail_la_SOURCES): added in the filter and vfolder rule stuff specific to mail. ** See #59885. * em-format-html-quote.[ch]: remove and remove from build, not used. * Makefile.am (libevolution_mail_la_LIBADD): add libeabutil and evolutionsmime. * mail-component-factory.c (factory): there is no mail_config anymore. 2004-06-16 Rodney Dawes * em-folder-properties.c: Include gtk[hv]box.h so we can use them (emfp_dialog_got_folder): Fix the border widths and spacings for the internal widgets and the dialog's vbox and action area to be compliant with the HIG Fix the general layout of the dialog to be HIG-compliant as well Use ngettext for the row labels for number of messages Add a cancel button, since we are not instant-apply Align the message counts to the right Part of this patch is from Christian Neumair * mail-component.c (view_changed_cb): Fix a typo for the sent folder send is not a pluralization of sent 2004-06-16 JP Rosevear * em-composer-prefs.c (spell_set_ui): clear the error, don't free it, so NULL is handled properly 2004-06-16 Not Zed * em-utils.c (em_utils_selection_get_urilist): handle comments in the urilist. Can't remember the rfc for it. ** See #56479. * em-utils.c (em_utils_in_addressbook): use the main thread to setup the addressbook list. (em_utils_in_addressbook): only check against the "completion" sources, not all of them. 2004-06-15 Not Zed * em-folder-browser.c (emfb_mail_stop): call mail_cancel_all to implement the stop button. * em-utils.c (emu_addr_sources_refresh): don't unref the group list, otherwise the sources become broken now (?). (em_utils_in_addressbook): add some locking. add cancellation. this is almost certainly going to cause issues. * mail-mt.c (mail_cancel_hook_add, mail_cancel_hook_remove) (mail_cancel_all): new functions to implement a global mailer stop button. 2004-06-15 Jeffrey Stedfast * mail-ops.c (save_part_save): This code no longer needs to do charset conversion. Yay. Fixes bug #60225. * em-utils.c (em_utils_save_part_to_file): Use the proper e-error namespace. 2004-06-15 Jeffrey Stedfast * em-folder-tree.c (emft_popup_copy_folder_selected): frombase is simply the select_path, since selected_path is now just the full_name rather than the path. Fixes bug #60075. * em-composer-utils.c (attribution_format): New function to format an attribution string (won't crash if translators were sloppy with their strftime/printf-style formatters). Also nice/extendable for future feature enhancements such as user-customisable attribution strings. (composer_set_body): Use above function rather than using e_strftime/etc ourselves. 2004-06-15 Jeffrey Stedfast * em-folder-view.c (emfv_init): Changed the second gtk_selection_add_target() to use GDK_SELECTION_CLIPBOARD rather than GDK_SELECTION_PRIMARY again. This should fix bug #60022. 2004-06-14 Radek Doulik * em-mailer-prefs.c (em_mailer_prefs_construct): the check button label has now opposite meaning (after UI changes), call toggle_button_init with 'not' parameter set to TRUE (toggle_button_toggled_not): new helper function, sets negative value to gconf bool key 2004-06-14 Not Zed * mail-vfolder.c (rule_changed): don't check rule->source, its irrelevent to vfolder sources, and clean up the logic a bit. #59158. * em-folder-tree.c (emft_popup_new_folder_response): destroy the create dialogue if we're firing up the vfolder creation window. * em-composer-utils.c (get_reply_all): if we removed all of the addresses because they were 'us', add the first to address back. otherwise reply-to-all behaves strange. 2004-06-11 Jeffrey Stedfast * em-folder-tree.c (em_folder_tree_set_selected): Free any old select_uri string we may have. (emft_tree_row_expanded): Remove the gross hack that was here. (emft_get_folder_info__got): Check for priv->select_uri and try selecting it (if we can't select it yet, it'll just be re-queued for later). (emft_tree_row_activated): Clear the select_uri if set, the user's selection overrules any auto-selection. (emft_tree_selection_changed): Same. 2004-06-11 Not Zed * em-folder-tree.c (emft_tree_button_press): rearrange the setting up of the target flags, stores can have a null path. * em-folder-selector.c (emfs_create_name_changed): use get_selected_uri rather than path. a valid uri may have a null path now. (emfs_create_name_activate): and here too. (em_folder_selector_get_selected_path): check the uri is null for a selected path, and then handle a null path. * em-folder-tree-model.c (em_folder_tree_model_add_store): revert previous change. Stupid emftm. * em-utils.c (em_uri_from_camel): handle a null path or fragment. * em-folder-tree-model.c (em_folder_tree_model_add_store): set the full name of the store to "". Fixes #59925 and probably other issues. Related to the removal of folderinfo->path. 2004-06-10 Jeffrey Stedfast Fixes bug #58825. Ugh. Really Gross Hack (tm). * em-folder-tree.c (emft_tree_row_expanded): If the store that we are expanding matches the uri that we've been requested to select (e.g. from before the store was added to the tree), then give the uri to the get_folder_info_op. (em_folder_tree_set_selected): If the store for the uri isn't in the tree yet, save the uri for later. * mail-component.c (folder_selected_cb): Set the selected state of the folder-tree and save it. (impl_createControls): Restore the selected state on the folder-tree. * em-folder-tree-model.c (em_folder_tree_model_set_selected): New function to set the selected-uri saved state. (em_folder_tree_model_get_selected): New function to get the selected uri saved state. (em_folder_tree_model_save_state): Renamed. * em-folder-tree.c (emft_update_model_expanded_state): Don't let path be NULL if the node is a store node (path == NULL for any other case is a bug). (emft_maybe_expand_row): Same. 2004-06-10 Not Zed * message-list.c (message_list_set_selected): use new etreeselectionmodel api to select paths in one call. Fixes #59546. * em-folder-view.c (emfv_message_reply): check that we have content selected, not just a selection, before trying to reply to that content. #59146. (emfv_message_reply): strip call content-* headers (fixme), and set transfer-encoding to 8bit. 2004-06-08 Rodney Dawes * mail-config.glade: Fix for SSL options appearing for sendmail 2004-06-08 Jeffrey Stedfast * em-folder-tree.c (em_folder_tree_set_selected): Scroll to the selected folder if needed. Fixes bug #59609. * em-folder-selector.c (em_folder_selector_construct): Make the chooser non-modal. Fixes bug #53735. * em-folder-tree.c (emft_tree_row_collapsed): Only change the cursor if the currently selected folder is a subfolder of the folder collapsed. Fixes bug #59801 without breaking bug #57665. (emft_tree_test_collapse_row): Renamed from emft_tree_collapse_row() to match the new signal we are connected to. 2004-06-07 Jeffrey Stedfast * em-folder-tree-model.c (em_folder_tree_model_add_store): Set the store's FULL_NAME to NULL here. Fixes the crash in bug #59713. 2004-06-07 Dan Winship * em-folder-view.c (emfv_popup_menu, emfv_message_pixmaps): s/stock_save_as/stock_save-as/ * em-popup.c (emp_standard_select_popups, emp_standard_object_popups): Likewise 2004-06-05 Christian Neumair * em-folder-tree.c: Shuffle usage of trailing "..." in menus according to the HIG. 2004-06-05 Christian Neumair * mail-component.c (view_changed_cb): Use ngettext for message count information. 2004-06-04 Radek Doulik * default/C/Inbox (Content-Type): added size info to IMG tags so that it loads the message smoother 2004-06-03 William Jon McCann * mail-session.c (request_password): Don't pack entry and checkbox widgets directly into the dialog vbox so that they line up correctly with the action area buttons. 2004-06-02 Not Zed * mail-component.c (mc_add_local_store_done): put this back in, local folders not being noted properly all the time. 2004-06-01 Jeffrey Stedfast * em-composer-utils.c (forward_non_attached): Don't attach anything ever. This is confusing way too many users who expect it to attach all or nothing. Since Forward-Attached is what users should be using to forward a message and all attachments, make these not attach anything (which is what other mailers do anyway). This wlso makes Forward-Quoted consistant with Reply-Quoted which is a Good Thing (tm). 2004-06-01 Not Zed * em-folder-selector.c (em_folder_selector_get_selected_uri): set the right path on the url. * mail-signature-editor.c (load_signature): ugh, unlike camel exceptions, you can't pass NULL to CORBA calls. (mail_signature_editor): ditto. See bug #58815. 2004-05-28 Jeffrey Stedfast * em-folder-tree.c (d): Disable debug here too - all this code has been working fine. * em-folder-selector.c (d): Disable debug spew here too (not that this debug was ever seen since it never hit those conditions). * mail-folder-cache.c (d): Disable debug here too. * em-folder-tree-model.c: Disable debug spewage that we don't need anymore. The amount of debug spewage on the console is getting to be too much to find anything. * em-folder-tree.c (emft_expand_node): Use p+1 as the full_name rather than p. Fixes bug #59187. 2004-05-27 Jeffrey Stedfast * em-folder-tree.c (emft_get_folder_info__got): Instead of removing the "Loading..." row for toplevel folder nodes on failure (which indicates a failure conenct to the server, most likely), collapse the store node so that if the user expands the store node, it will automagically try connecting again. Fixes bug #57493. 2004-05-27 Rodney Dawes * Makefile.am (EXTRA_DIST): Add $(error_i18n) 2004-05-26 Not Zed * mail-vfolder.c (vfolder_adduri_desc): initialise desc to NULL before using it later on. gcc doesn't warn on this if you're not optimising. Sigh. Probably fix #59070, #59060, #58972 and friends. * importers/evolution-mbox-importer.c (create_control_fn): set the default selection to inbox. * importers/evolution-outlook-importer.c (folder_selected) (create_control_fn): copied from mbox importer. fixes a crash & lets you choose the target folder. 2004-05-25 Jeffrey Stedfast * mail-errors.xml: a few fixes. * em-format-quote.c (emfq_text_plain): Only strip the signature if we are in some wy modifying the content (we don't want to remove the signature if we are editing the message as a new message). Fixes bug #58826. 2004-05-25 Not Zed * mail-component.c (mc_add_local_store_done): removed, now redundant. * em-folder-tree.c (em_folder_tree_set_selected): fix for path changes. * em-folder-tree-model.c (em_folder_tree_model_set_unread_count): change to use full name rather than path name. * em-folder-tree-model.h: renamed path_hash to full_hash. * em-folder-tree-model.c (folder_subscribed): dont use g_path_get_dirname here, it is os dependent, we want / always. (full_hash_free): rename from path_hash free. * em-folder-view.c (emfv_popup_menu[]): disable add sender to addressbook bar if it is also disabled. #58955. 2004-05-24 Not Zed * mail-account-gui.c (mail_account_gui_build_extra_conf): don't enable the widget based on its writability if it is a dependent option which is now disable. (setup_toggle): return whether the widget is sensitive too. #57171. * em-popup.c (em_popup_target_new_select): only enable add sender if we also have 1 selected. #56663. * em-folder-view.c (emfv_enable_menus): remove some debug. * em-format-html.c (efh_format_header): output commas between newsgroups, and also append_printf. 2004-05-24 Sivaiah Nallagatla * mail-account-gui.c (mail_account_gui_build_extra_conf): added empty handling for CAMEL_PROVIDER_CONF_HIDDEN (extract_values): added handling for CAMEL_PROVIDER_CONF_HIDDEN 2004-05-24 Not Zed * em-folder-tree.c (em_folder_tree_set_selected): use set_cursor instead of scroll_to_row. See #58383. (get_selected_uris_iterate): removed. (em_folder_tree_get_selected_uris): use an interative call based on gtk_tree_selection_get_selected_rows rather than selected_foreach, as the gtk+ docs suggest. was trying to fix a bug but it seems gtktreeselection bug (shift-select rows using keyboard only) * message-list.c (regen_list_regened): pull the message from the regen list before we check the list and pending uid. * em-folder-view.c (emfv_enable_menus): remove the hack for enabling select delete from here and put it in the right place. (em_folder_view_get_popup_target): put it here so its consistent. 2004-05-22 Not Zed * mail-tools.c (mail_tool_uri_to_folder): put note_store back in. Quick hack to fix the issue of folders being opened before we hook onto folder_created. * mail-folder-cache.c: remove 'name' from update struct, not used anymore ** Another unread count bug, #58814. * mail-vfolder.c (context_rule_added): * mail-tools.c (mail_tool_uri_to_folder): * mail-component.c (mc_add_local_store_done): don't call mail note folder anymore, fix up headers. * mail-folder-cache.c (store_folder_opened) (mail_note_store_remove, mail_note_store): handle the new store:folder_opened signal. Don't need the mail_note_folder hack anymore, mail_tool_uri_to_folder slowly does less. 2004-05-21 Not Zed * mail-mt.c (do_call): add marshaller for p_ppppp call. * mail-session.c (get_password): fix for camel api changes. (forget_password): same. ** See #58376. * message-list.c (mail_regen_list): do some timeout foo so we don't keep doing list regnerations if we're getting called too often. God knows what this will break. (message_list_set_selected): removede bug printf. (regen_list_free): move the message-list poking stuff into regen_list_regened. (message_list_set_folder): call mail_regen_cancel to cancel any regen stuff. (mail_regen_cancel): cancel/clear outstanding regenerations. (message_list_destroy): do it here too. (message_list_select_uid): also set the pending select uid if we have a timeout pending. * mail-component.c (impl_createControls): set the defualt parent to the main folderview as soon as its created. * em-folder-tree.c (emft_popup_copy_folder_selected): use get_toplevel rather than get_ancestor. seems the more reliable one. also we're always parented so we shoudl always find a toplevel window. (em_folder_tree_create_folder): same. (emft_popup_delete_response): set error parent. (emft_popup_delete_folder, emft_popup_rename_folder) (emft_popup_rename_folder, emft_popup_rename_folder): * em-migrate.c (update_passwords_1_2): finally put the 1.2 password upgrade patch in. Untested. #42721. 2004-05-20 Jeffrey Stedfast Fixes for bug #57305. * mail-account-gui.c (sig_add_new_signature): Updated for changes below. * em-composer-prefs.c (em_composer_prefs_new_signature): No longer takes a script argument (makes no sense to edit a script with an HTML editor if we require that the script already exist before we let the user add it anyway). (sig_add_cb): Updated for above change. (sig_add_script_response): Don't pop up an editor window for the newly added script, the script has already been created! Instead simply create a new ESignature object, set the sig->name, and add it to the signature list. 2004-05-20 Radek Doulik * em-mailer-prefs.c (em_mailer_prefs_construct): remove "use daemon" handling code Fixes #56909 2004-05-20 Not Zed ** See #58388. * mail-mt.c (mail_msg_check_error): surpress any errors about messages not found because of invalid uid's. They're really just internal errors. ** See #57583. * message-list.c (build_tree): save/restore the selection when we update. (message_list_set_selected): util to set the selected messages from a list of uids. (build_flat): same. I wonder if etree's unbroken enough to use it more directly? ** See #58693. * mail-send-recv.c (mail_autoreceive_setup): add bounds checking so sloppy ui work wont break it again. * mail-config.glade: put the minimum for autocheck back to 1 minute. Naughty jeff. 2004-05-19 Chris Toshok * importers/pine-importer.c (import_contacts): use the new e_book_new_* and e_book_open apis. * em-utils.c (em_utils_in_addressbook): use the new e_book_new_* and e_book_open apis. 2004-05-19 Jeffrey Stedfast * message-tags.glade: Fixed the icon name to get the right one. * message-list.c (message_list_init_images): Changed to load an empty pixbuf manually rather than relying on the pixbuf returned for "" from e_icon_factory_get_icon() since it has changed to return a broken image icon. 2004-05-19 JP Rosevear * Makefile.am: don't dist the error .h file 2004-05-19 Not Zed * mail-ops.c (send_queue_send): set seen when we set deleted. ? #56549. * em-inline-filter.c (emif_add_part): if we end up with an application/octet-stream part, pre-snoop it so we set the right mime type to start with. Fixes #58554. * em-format.c (emf_snoop_part): removed, now in em-utils. * em-utils.c (em_utils_snoop_type): rah rah, snoop a mime part's type. * em-format-html.c (efh_text_plain): Revert jeff's fix for #56290. Ugh, we already have all the citation info in local data. Removed the need for gconf too. 2004-05-19 Not Zed * em-format-html.c (efh_format_secure): make this match the efhd stuff. * em-format-html-display.c: removed stock_signature-nokey since it doesn't exist in gnome-icon-theme. (efhd_xpkcs7mime_button): if there is no signing, but encryption, use its icon. if there's no encryption too, use a broken icon (?). 2004-05-05 William Jon McCann * GNOME_Evolution_Mail.server.in.in: Add menu_label and menu_accelerator. 2004-05-19 Not Zed * mail-component.c (mc_quit_sync): fixed up the empty trash on exit thing, to update for all stores, not update the timestamp on the first store synced. 2004-05-18 Cantona Su * em-format-html.c: Added header "X-Newsreader" for handle Outlook Express as Mailer. 2004-05-18 Not Zed * em-folder-browser.c (em_folder_browser_show_preview): don't nomarkseen when we restore the message when we show the preview. #58387. * mail-folder-cache.c (folder_changed): no new message test if its the drafts folder too. * mail-vfolder.c (vfolder_adduri_desc): use a nicer, account-based formatter for folder names. Hmm, that was a good waste of time. For #55412. * em-folder-view.c (emfv_list_selection_change): Listen to the tree selection change event directly & proxy out, so we can update the status bar properly. Blah. For #58600. ** Quick fix for #57434 * em-format.c (emf_format_clone): fix the FIXME about cloning headers shown. * em-format-html.c (efh_format_headers): only show rupert if we're showing rupert. * em-format-html-print.c (efhp_init): default show_rupert to off. * em-format-html.c (efh_init): default show_rupert to on. * em-format-html.h: added show_rupert bit. * mail-folder-cache.c (folder_changed): don't emit new mail if its any vfolder, not just vtrash folder. #56350. * em-folder-view.c (emfv_list_done_message_selected): run enable_menu's to make sure we're up to date. #58352. ** crappy hacks for #58385. * em-folder-selection-button.c (em_folder_selection_button_clicked): leave Ok button for this selection. * em-folder-selection.c (em_select_folder): added oklabel here too. * em-folder-selector.c (em_folder_selector_new) (em_folder_selector_construct, em_folder_selector_create_new): Added oklabel- text for ok label. (em_folder_selector_create_new): Set the ok label to Create. * em-message-browser.c (emmb_set_message): don't mark message seen if user has disabled auto-mark seen feature. #58629. * em-format.c (em_format_part): if we have no content-type header, then we get no mime-type set, so assume text/plain. #58470. 2004-05-17 Jeffrey Stedfast * em-mailer-prefs.c: #include . Fixes bug #58407. 2004-05-17 Not Zed * mail-account-gui.c (mail_account_gui_setup): put the None item at the head of the providers list. (mail_account_gui_setup): only set the transport default fallback if it is not a STORE_AND_TRANSPORT type provider (since that was just disabled). #57939. * message-list.c (on_selection_changed_cmd): only NOOP if we have no selection and no uid, if we have a selection and no uid, then always update. Fixes #58267 without breaking the double-load thing. * em-folder-view.c (em_folder_view_open_selected): keep the hide deleted status. Makes #51082 work at last. ** Bug #6556. * message-list.c (ml_drop_async_desc, ml_drop_async_drop) (ml_drop_async_done, ml_drop_async_free, ml_drag_data_action) (ml_drop_popup_copy, ml_drop_popup_move, ml_drop_popup_cancel) (ml_tree_drag_data_received): implement async drop operations and the ask drop option menu. 2004-05-14 Not Zed ** Bug #6556. * message-list.c (ml_selection_received_uidlist): removed, not needed anymore. (ml_selection_received): call get_uidlist to paste the selection. (ml_tree_drag_data_received): same here. * em-folder-tree.c (emft_drop_uid_list): removed, not needed because of below change. * em-utils.c (em_utils_selection_get_uidlist): actually do the copy now, don't just decode the data. * em-folder-tree.c (tree_drag_data_received): just copy the selection data data itself, dont decode yet. (emft_import_message_rfc822): removed, not needed, use em utils stuff instead. (emft_drop_message_rfc822): same. (emft_drop_text_uri_list): same. (emft_drop_async_free): simply free stuff. (emft_drop_async_drop): call em_utils stuff where they exist to do the drop. * message-list.c (ml_tree_drag_data_get): send x-mailbox instead of message/rfc822 for the mailbox. (ml_tree_drag_data_received): handle drop of x-mailbox differently to message/rfc822. (ml_tree_drag_motion): implement so proper options are setup whilst dragging. (message_list_construct): seutp the drag src/dest types for changes typs and with ASK action. * em-utils.c (em_utils_read_messages_from_stream): dont unref the stream when we get it. (em_utils_selection_get_mailbox): add an argument to scan from or not, for message/rfc822 vs x-mailbox drops. (em_utils_read_messages_from_stream): Same. * em-folder-tree.c (tree_drag_motion): default to move properly. * message-list.c (ml_selection_received_uidlist): take a move flag. (ml_tree_drag_data_received): handle move action. * em-folder-tree.c (em_folder_tree_new_with_model): got sick of this bloody warning. * em-format.c (default_headers[]): just remove x-mailer from the header list, if it isn't on by default. This is the default list. (em_format_default_headers): loop through everything. 2004-05-14 Jeffrey Stedfast * em-popup.h: s/RESEND/EDIT/ * em-popup.c (em_popup_target_new_select): s/RESEND/EDIT/ * em-folder-view.c: s/RESEND/EDIT/ (emfv_popup_edit): Renamed from emfv_popup_resend. Part of the fix for bug #58358 (The main fix was just a change to the ui file). * mail-config.c (mail_config_init): Build the path to the gtkrc filename and store it on the config struct so we don't have to keep rebuilding it. (config_write_style): Reuse config->gtkrc string instead of constructing the path again. (mail_config_write_on_exit): Free the gtkrc path. (config_write_style): fflush the gtkrc file. * em-popup.c (emp_popup_resend): Updated the #if 0'd code for the API chanegs made to em_utils_edit_messages(). * em-folder-view.c (em_folder_view_open_selected): Pass TRUE as the replace argument to em_utils_edit_messages() here. (emfv_popup_resend): Pass FALSE here. Fixes bug #58357. * em-composer-utils.c (em_utils_edit_messages): Now takes a 'replace' argument specifying whether or not the original message should be deleted when the edited message is sent or saved. * em-format-html.c (efh_format_secure): Same. Also changed the "Valid signature, cannot verify sender" string to "Valid signature but cannot verify sender" as I think it reads nicer. * em-format-html-display.c (efhd_format_secure): Since signature status is a tri-state, use 3 different colours too (yellow for valid sig but unknown sender). 2004-05-13 Jeffrey Stedfast * em-format.c (em_format_default_headers): Don't include the last default_header when setting the default headers. If the user has configured Evolution to display the Mailer header, then it will be set in em-folder-view.c as appropriate when it checks the gconf settings. Fixes bug #58217. * em-mailer-prefs.c (em_mailer_prefs_construct): Default "x-evolution-mailer" header to disabled. * em-format-quote.c (emfq_text_plain): Add a stripsig filter. Fixes bug #52767. * em-stripsig-filter.[c,h]: New filter class to strip signatures. Useful when generating forwards/replies. 2004-05-13 Not Zed * em-migrate.c (em_migrate_folder): move ignore case outside of block. Stupid c language. * em-folder-view.c (emfv_format_popup_event): fix warning with cast. ** See bug #58304. * em-junk-filter.c (em_junk_sa_setting_notify): listen to sa settings changes, update some globals. (em_junk_filter_get_plugin): setup the gconf client here and listen to changes. (em_junk_sa_get_local_only, em_junk_sa_get_use_daemon) (em_junk_sa_get_daemon_port): removed, use globals instead. 2004-05-13 Not Zed * em-folder-view.c (emfv_message_reply): re-enabled the reply to selection stuff. I worked out how to make it work; I think. * em-format-html-display.c (efhd_html_button_press_event): if we aren't on a clickable object, do a null popup event instead. * em-folder-view.c (emfv_format_popup_event): do the full popup if we aren't on anything (not on a uri or part). See #8414. * GNOME_Evolution_Mail.server.in.in: added "email" to the uri_schema's attribute. * mail-component.c (impl_handleURI): handle email: uri's, specify opening a message on a folder. (handleuri_got_folder): open the message. For some 1337 s3Kr3t ha0x. 2004-05-12 Not Zed ** See bug #58302. * em-composer-utils.c (em_utils_post_to_folder): * em-composer-utils.c (em_utils_compose_new_message_with_mailto): poke the composer headers from account directly, don't call set headers which overwrites stuff. 2004-05-12 Not Zed * mail-component.c (setup_search_context): enable threading option type on the search bar. * mail-errors.xml.h: add for translators. * Makefile.am (%.xml.h): fix for xml i18n stuff. * mail-errors.xml: moved from the .xml.in file. 2004-05-11 Not Zed * em-utils.c (em_uri_from_camel): pass an exception to provider_get, it relies on one. * em-migrate.c (em_migrate_1_4): fix some error messages, and fail with fatal errors properly. (em_migrate_local_folders_1_4): EEP! Who cares if this fails! Well I do. Setup exceptions and return codes. (em_migrate_dir): and here too. Sloppy! (em_migrate_dir): change the code slightly, 1.4 would recurse all folders, even if the parent folder doesn't have a folder-metadata.xml. Make sure we copy that mode. (get_local_store_uri): Make it copy the 1.4 behaviour properly. Any error -> use defaults. (em_migrate_dir): lots of changes. (mbox_build_filename): take the output string as an arg. (cp): add an argument to overwrite/append or require a unique empty file. (cp_r): add mode arg here too. (em_migrate_folder): split the folder copy stuff from em_migrate dir entirely. blah. (em_upgrade_accounts_1_4): can't fail, remove return code, etc. (em_upgrade_xml_1_4): removed this rather redundant odd api. (upgrade_xml_uris): this can't fail, remove return codes etc. (em_upgrade_xml_1_0): another oddly redundant function. (em_migrate_pop_uid_caches_1_4): error messages, blah blah. (em_migrate_folder_expand_state_1_4): no fatal states here. (em_migrate_folder_view_settings_1_4): nor here. (emm_setup_initial): do i18n 'better', using gnome_i18n_get_language_list, rather than hacky code. 2004-05-10 Not Zed * mail-tools.c: remove e-meta.h, not used anymore. 2004-05-11 Dan Winship * GNOME_Evolution_Mail.server.in.in: Remove the mail folder control factory * mail-component-factory.c (factory): Remove support for the mail folder control * mail-component.c: Remove the property bag stuff (mail_control_new): Gone 2004-05-10 David Malcolm * em-subscribe-editor.c (sub_queue_fill_level): Fixed warning 2004-05-10 Jeffrey Stedfast * em-mailer-prefs.c (em_mailer_prefs_construct): Default the Mailer header to enabled. Fixes bug #58217. 2004-05-10 JP Rosevear * mail-ops.c (mail_send_message): set header to just Evolution (mail_append_mail): ditto * em-message-browser.c (em_message_browser_window_new): set title to just Evolution 2004-05-10 Not Zed * em-folder-view.c (emfv_activate): cleanup the view menus if they were created. * em-folder-view.h: added list_active bit, means the view is showing the list and needs e.g. view menus. * em-folder-view.c (emfv_setup_view_instance): was create_view_instance. Now also setup the menu's if we're showing the list. * em-folder-browser.c (emfb_create_view_menus): removed. moved functionality into emfolderview. 2004-05-07 Jeffrey Stedfast Fix for bug #57152. * em-folder-tree.c (emft_get_folder_info__got): If we queried for a recursive folder-info listing, then pass fully_loaded as TRUE to set_folder_info(). (emft_get_folder_info__got): If we find that a folder doesn't have children, set the expanded state to FALSE. * em-folder-tree-model.c (em_folder_tree_model_set_folder_info): Now takes a "fully_loaded" argument to hint to set_folder_info whether or not folder-info's without child nodes can possibly have children (eg. if fully_loaded is set and fi->child is NULL, then 'load' will be FALSE no matter what fi->flags contains). 2004-05-07 Radek Doulik * mail-config.c (config_write_style): set cite_color property of gtkhtml widgets (mail_config_init): add /apps/evolution/mail/display dir to gconf client and watch for mark_citations and citation_colour changes See bug #57587 2004-05-07 Not Zed * mail-account-editor.c: include missing header. ** See bug #57935. * em-folder-view.c (emfv_set_message): add new arg, nomarkseen, don't mark the selected message seen once its loaded. (emfv_list_message_selected): clear the nomarkseen flag once we've processed the selection. (emfv_list_done_message_selected): handle the nomarkseen flag, don't mark a message seen if it was explictly selected. * em-folder-browser.c (emfb_list_built): use em_folder_view_select_message rather than doing it via the messagelist directly. ** Dunno why i bothered, but see bug #58090. * importers/netscape-importer.c (netscape_filter_parse_conditions): check for custom headers properly. (netscape_filter_flatfile_get_entry): put in some validate checks. (netscape_filter_to_evol_filter): implement custom headers properly. (ns_filter_condition_types): add missing "status" string. ** See #58017. * message-list.c (mail_regen_list): use thread_queued, so we don't regen out of order. * em-folder-view.c (emfv_list_message_selected): use the queue thread so we don't get messages out of order. * mail-ops.c (mail_transfer_messages): use thread_queued_slow. (mail_prep_offline): and here too. 2004-05-06 Jeffrey Stedfast * mail-component.c (folder_selected_cb): Check that the folder is selectable using the new flags argument. * em-folder-selector.c (folder_selected_cb): Updated for below changes. * em-folder-tree.c (emft_tree_selection_changed): Updated to pass a flags argument to the folder_selected signal. (emft_tree_row_activated): Same. 2004-05-06 Radek Doulik * em-composer-prefs.c (sig_selection_changed): reset the preview if no signature is selected Fixes #57167 2004-05-05 Jeffrey Stedfast * em-folder-tree.c (emft_tree_row_collapsed): Select the row that was just collapsed. Fixes bug #57665. * mail-autofilter.c (rule_match_thread): Removed. (rule_from_message): Removed the AUTO_THREAD bit. * em-folder-view.c: Removed vFolder/Filter on Thread. These were both broken. (struct _filter_data): Removed a bunch of data members since most of them weren't used. 2004-05-05 Not Zed ** See bug #57720. * em-folder-browser.c (emfb_create_view_menus): removed some stuff done in create_view_instance in the superclass. * em-folder-view.c (emfv_create_view_instance): moved here from em-folder-browser, setup the view instance for the folder. (emfv_set_folder): if the folder is set, create the view instance. * em-folder-browser.c: moved the galview instance and menu pointers to EMFolderView, since they're basically meta-data on the messagelist @ to fix issues. * em-folder-view.c (em_folder_view_open_selected): copy over the threaded list value when the message browser is brought up. ** some clean up * evolution-mail.schemas.in.in: removed xmailer_mask stuff. * em-migrate.c (mail_display_map[]): Removed xmailer_mask stuff. * em-folder-view.c (emfv_setting_notify): removed xmailer_mask stuff. * em-format-html.c (em_format_html_set_xmailer_mask): removed. This isn't used anymore. ** Fixes the double-draw on separate mail view. * message-list.c (on_cursor_activated_cmd): noop if the cursor and uid match for all cases (clearing uid). (on_selection_changed_cmd): noop if the cursor and new selection hasn't changed & fix a memleak. 2004-05-04 Jeffrey Stedfast Fix for bug #55303, but ideally there would be a nicer way of doing this - likely with some added ETree API but that's not likely to happen anytime soon. * em-folder-browser.c (scroll_idle_cb): Recall the saved scrollbar position state and set it, then reconnect to the message_list_scrolled signal. (emfb_list_built): Calculate a default scrollbar position for scroll_idle_cb to use if there's no saved state. (emfb_set_folder): Disconnect from the message_list_scrolled signal and the idle_scroll_id. (emfb_list_scrolled): Save the scrollbar position state. (emfb_destroy): Disconnect from list_scrolled_id and idle_scroll_id. Fix for bug #58004. * mail-account-gui.c (display_license): Fixed to compile. (select_account_signature): Activate the signature menu item. (signature_added): Connect to the activate signal for each item. (sig_changed): Removed. (prepare_signatures): Don't bother connecting to the "selection-done" signal, it doesn't seem to work the way we expected it to work. 2004-05-04 Sarfraaz Ahmed * mail-account-gui.c (display_license): This now takes CamelProvider as argument. Made the display message more generic. Removed the signal connects for buttons and replaced those with proper gtk_reponses. (mail_account_gui_check_for_license): Modified the gconf key for licenses to be a string list. * evolution-mail.schemas.in.in: Added the gconf schema entry for a string list to handle the component names whose licenses are accepted. * mail-license.glade: Modified the display string and added the appropriate gtk_response types for the buttons. 2004-05-03 Jeffrey Stedfast Fix for bug #57968 * message-list.c (message_list_set_folder): Save the tree/hide state of the current folder before clearing the message-list. (message_list_set_folder): Note that a new folder has just been set (now needed by the regen code to tell whether or not it should save the tree state before clearing the tree). (message_list_destroy): Save the tree/hide state before destroying the message-info's, not after. (regen_list_regened): If the regen is being performed in response to a message_list_set_folder, don't save the tree state before clearing the tree or we'll clobber the real state with bogus data. 2004-05-03 William Jon McCann * mail-account-gui.c: Add gtkdialog header to fix build. 2004-05-03 Not Zed * em-composer-utils.c (create_new_composer): take fromuri and subject to set the basic headers/account. (em_utils_compose_new_message) (em_utils_compose_new_message_with_mailto, forward_attached) (em_utils_forward_attached, forward_non_attached) (em_utils_forward_inline, em_utils_forward_quoted) (em_utils_forward_message, em_utils_forward_messages): Take the from folder uri to set the from account if it can. Fixed all callers. For #57964. * mail-send-recv.c (receive_update_done): removed. * em-mailer-prefs.h: * message-tag-followup.h: * mail-config-druid.h: * mail-tools.h: clean up & use forward decls. Fix users with busted includes. * em-composer-utils.c (em_utils_compose_new_message) (em_utils_compose_new_message_with_mailto) (em_utils_post_to_folder, em_utils_post_to_url) (em_utils_edit_message, em_utils_edit_messages) (em_utils_forward_attached, em_utils_forward_inline) (em_utils_forward_quoted, em_utils_forward_message) (em_utils_forward_messages, em_utils_redirect_message) (em_utils_redirect_message_by_uid) : (em_utils_reply_to_message, em_utils_reply_to_message_by_uid) (em_utils_post_reply_to_message_by_uid): Moved these here from em-utils.c. 2004-04-30 Priit Laes * mail-config.glade: fix typo. #53466. * evolution-mail.schemas.in.in: use American English instead of British. #53466. 2004-04-30 Jeffrey Stedfast Fix for bug #56645 * em-folder-tree.c (tree_drag_motion): If the row the cursor is hovering over has children and is not expanded already, setup a timer to auto-expand it if the user hovers there long enough. (tree_autoexpand): Callback to expand the row. (tree_drag_leave): Disconnect the timer. (tree_drag_drop): Same. (em_folder_tree_destroy): Same. 2004-04-30 Enver ALTIN * evolution-mail.schemas.in.in: Fixed a type-o. 2004-04-30 Jeffrey Stedfast * message-list.c (message_list_set_folder): Properly initialise the strikeout column for both types of folders (trash and not trash). Completes the fix for bug #57304. 2004-04-30 Not Zed * em-utils.c (emu_can_save): fix the overwrite? question. #57822. 2004-04-29 Not Zed * mail-errors.xml.in: change all the session-message-* things to just be secondary, otherwise they look awful all big fonted. * mail-session.c (error_type[]): forgot to prefix error type with "mail:" * em-account-prefs.c (account_delete_clicked): duh, use the right error id. * mail-send-recv.c (receive_update_got_store): call mail_note_store rather than get_folder_info so that unread counts are propagated to the ui too. * mail-errors.xml.in: fix the password dialogue text. 2004-04-28 Jeffrey Stedfast * em-folder-tree-model.c (sort_cb): Sort the VFolders. Fixes bug #56636. * em-mailer-prefs.c (citation_color_set): We only want 8bits per color. Fixes bug #57588. * em-folder-tree-model.c (em_folder_tree_model_remove_store): Duh. If the lookup of si fails, don't use si->display_name in the warning message. Actually, don't bother with a warning message at all, this is a perfectly valid situation. Fixes bug #57746. * mail-ops.c (mail_send_message): Don't set the Date header here anymore. It has either already been set (when written to the Outbox) or will automagially be set to the current time if a Date hasn't already been set when the transport sends it. Fixes bug #57599. * em-composer-prefs.c (sig_add_script_response): Use g_shell_parse_argv() to get the actual script path and then check that we can exec argv[0] rather than treating the entire command-line as the signature script. Fixes bug #57305. 2004-04-28 Not Zed * message-list.c (ml_selection_clear_event): return the right type, related to #53839. ** Changed error messages to use EError. 2004-04-27 Not Zed ** See bug #57659. * mail-ops.c (fix_unmatched_info): removed, done in camel now. ** See bug #57511. * mail-config.glade: gave the whole smime frame (vbox) a name so we can use it from code. * mail-account-gui.c (mail_account_gui_new): get the smime_vbox widget if we have no NSS, the name changed and the HIG patches didn't fix it. 2004-04-26 Radek Doulik * em-format-html.c (efh_format_timeout): set gtk_html_begin's flags to avoid scroll to top of the message and reloading+flickering of images * em-html-stream.c: added GtkHTMLBeginFlags flags field (em_html_stream_set_flags): new helper function to set new flags field (emhs_sync_write): use gtk_html_begin_full with new flags field (em_html_stream_new): zero flags field Fixes #51654 2004-04-23 Sarfraaz Ahmed * mail/mail-license.glade: Glade file for displaying the license. 2004-04-23 Not Zed * em-format-html.c (em_format_html_load_http): fix the check to see if we've already loaded the images. #57450. 2004-04-23 Sarfraaz Ahmed * mail-account-gui.c (mail_account_gui_source_complete): Added a check for HAS_LICENSE flag. (mail_account_gui_check_for_license)(display_license) (populate_text_entry)(check_button_state)(set_license_accepted) (set_license_rejected): Implemented 2004-04-22 Not Zed * em-migrate.c (em_migrate_imap_cmeta_1_4): do the imap cmeta files, it just does the sync offline stuff. #56674. (em_migrate_1_4): non-fatalise some of the options, call above. * mail-component.c (view_changed_cb): display selected count instead of unread if we have >1 selected. Also don't do special case drafts/sent/outbox stuff if folders are inbox or re-used. (view_control_activate_cb): force check of autosaved messages as soon as the mailer starts up (well, after a delay, this seems wrong). #57093. 2004-04-21 Not Zed * em-inline-filter.c (emif_scan): use a better test for non-full lines. * em-folder-browser.c (emfb_activate): dont desensitise HideDeleted just 'cause we have no folder, it needs to depend on Trash folder only. (emfb_set_folder): set the hidedeleted sensitivity based on whether we have a trash folder or not. Fixed #57226. * em-folder-view.c (emfv_class_init): use the right signal callback for the changed signal. Fixes #57246. * mail-component.c (impl_createControls): fix for e_user_creatable_items api changes. (create_item): split out the code to create the item. (create_local_item_cb): new callback for local item creation. (impl_requestCreateItem): call create_item to do the work. 2004-04-19 Jeffrey Stedfast * em-folder-browser.c: Use E_ICON_SIZE_* enums for the menu icon sizes. * em-folder-view.c: Use E_ICON_SIZE_* enums for the menu/toolbar icon sizes. * message-tag-followup.c (construct): Same. * message-list.c (message_list_init_images): Same. * mail-send-recv.c (build_dialog): Same. * mail-mt.c (do_op_status): Same. * mail-config-druid.c (evolution_mail_config_wizard_new): Same. * em-popup.c (em_popup_create_menu): Same. * em-format-html-display.c (efhd_format_prefix): Same. * em-format-html.c (efh_format_secure): Same as below. * em-folder-tree.c (render_pixbuf): Don't use absolute icon sizes, use the e-icon-factory enums. 2004-04-19 Jeffrey Stedfast * em-composer-prefs.h: Removed variables that got re-added with the icon-theme patch somehow. * em-account-prefs.c: Don't bother keeping global references to the enable_pixbuf anymore, since it's unnecessary. 2004-04-19 Michael Terry * GNOME_Evolution_Mail.server.in.in: * em-account-prefs.[ch]: * em-composer-prefs.[ch]: * em-folder-browser.c: * em-folder-tree.c: * em-folder-view.c: * em-format-html-display.c: * em-format-html.[ch]: * em-popup.c: * mail-component.c * mail-config-druid.c: * mail-config.glade: * mail-mt.c: * mail-send-recv.c: * message-list.c: * message-tag-followup.c: * message-tags.glade: Update the mailer to use icon themes through the EIconFactory object in e-util 2004-04-16 David Malcolm * importers/netscape-importer.c (netscape_import_accounts): Removed unused and uninitialised "url" local that gets g_free-ed 2004-04-15 Jeffrey Stedfast * mail-config.c (config_write_style): Change the message display widget names to match the ones we are using in 1.5 (rather than the ones from earlier versions). Fixes bug #57070. 2004-04-14 Jeffrey Stedfast * message-list.c: Added a new "message_list_scrolled" signal so our users can listen to this event in order to update saved state. (message_list_get_scrollbar_position): Simplified. (message_list_set_scrollbar_position): Simplified. * em-format.c: Don't complain about message errors ("Internal Error: ..."), instead silently fall back to display the message as source. Fixes bug #56876. 2004-04-14 Not Zed * em-folder-view.c (emfv_set_folder_uri): ugh, use the queued thread to get the folder, otherwise we can get folders set on the display out of order. * message-list.c (message_list_set_search): if we set this while frozen, save the search elsewhere. (message_list_thaw): if we had a frozen-time search, use it when we regenerate. * em-folder-browser.c (emfb_set_folder): freeze/thaw the messagelist around changes so we don't have multiple updates fire off changing folders. (emfb_activate): remove an unused variable i never used. * message-list.c (message_list_freeze, message_list_thaw): lock some updates to the ui, so you can do things like set folder and search atomically. (message_list_set_threaded, message_list_set_hidedeleted) (message_list_set_search, message_list_hide_uids) (message_list_hide_clear, message_list_set_folder): dont refresh the list if we're frozen. * mail-component.c (impl_createControls): remove debug comment. ** See #56641. * em-format-html-display.c (efhd_format_secure): fix a small memleak. (efhd_bonobo_unknown, efhd_format_attachment): close the tag properly, and
it as well to make sure its separated. * em-sync-stream.c: add some runtime and compile time stream logging stuff. ** See bug #56149. * em-folder-view.c (emfv_edit_cut): similar to below, use focus to determine who we select from. (emfv_edit_copy): ditto. * message-list.c: Remove primary selection stuff. It just annoys. * em-folder-browser.c (emfb_edit_copy): use focus rather than selection owner to determine who to copy from. (emfb_edit_cut): similarly. * em-format.c (emf_multipart_related): hmm, use the right pointer when iterating the pending uri list. 2004-04-13 Jeffrey Stedfast * mail-component.c (impl_createControls): We don't actually want to disallow clicking on \NoSelect folders. Fixes a bug campd has been complaining to me about :-) * mail-config.c (mail_config_signature_run_script): If we get an empty charset string from gconf, don't try to use the result to create a charset filter. Real fix for bug #51924. * mail-config.glade: Removed crackrock usage of GtkFixed as fillter. Also HIGified some other stuff. 2004-04-13 Not Zed * em-folder-view.c (emfv_set_folder): track the messagelist hidedeleted value since it looks it up when we set the folder. * em-folder-browser.c (emfb_hide_deleted): use new method below to propagate change. (emfb_activate): same. * em-folder-view.c (em_folder_view_set_hide_deleted): accessor to set the hide_deleted state, emits a view_changed event. * mail-component.c (view_changed_cb): use VISIBLE rather than TOTAL for the displayed total count. Also deleted if we're not in hide deleted mode. And do spethal things with spethal folders, etc. * mail-ops.c (mail_refresh_folder): run this in the thread_queued_slow, so it runs in sequence and after folder_sync. * em-folder-view.c (emfv_set_folder): fire off a refresh_folder once the folder is loaded. Addresses #56871. * em-format-html.c (efh_format_headers): use %% for %%. (efh_format_done): reset load_http_now once we've done, should fix #56338 finally. * em-folder-view.c (emfv_init, emfv_finalise, emfv_activate): revert dans' creatable items handler patch, moved to mail-component instead (which deals with the actual menu's). * mail-component.c (impl_createControls): setup a user creatable items handler on the view widget. (view_control_activate_cb): activate the user creatable items handler on the view widget. * em-folder-view.c (emfv_init): add a comment about jeff's last fix. * em-utils.c (forward_non_attached): Set attachments from forwardee before we set the body, otherwise images wont resolve properly. Related to #56566. 2004-04-12 Jeffrey Stedfast * em-folder-view.c (emfv_init): Need to set the session on the preview object. Fixes bug #56862. * em-folder-tree.c (em_folder_tree_set_selected): Scroll to the auto-selected folder. Fixes bug #56707. * message-list.c (message_list_get_scrollbar_position): New function. (message_list_set_scrollbar_position): New function. * em-utils.c (em_uri_to_camel): If the provider is unavailable, return euri like the other fail cases. Fixes bug #56846. 2004-04-10 Francisco Javier F. Serrador * evolution-mail.schemas.in.in.h: Correct typo s/hight/height/ at "Subscribe dialog default hight" 2004-04-09 Jeffrey Stedfast * mail-config.c (mail_config_init): Don't bother adding the autogen sig here, e-signature-list.c handles this now. * em-migrate.c (em_upgrade_accounts_1_4): Migrate the signature uids. Fixes bug #56726. 2004-04-09 Chris Toshok * importers/pine-importer.c (import_contact): use e_destination_export_to_vcard_attribute instead of exporting to xml, and use e_contact_set_attributes. * em-utils.c (em_utils_camel_address_to_destination): EABDestination -> EDestination. (reply_get_composer): same (post_reply_to_message): same. * em-composer-utils.c (ask_confirm_for_unwanted_html_mail): EABDestination -> EDestination. (composer_get_message): same. 2004-04-09 Radek Doulik * em-format-html.c (efh_format_headers): add width=16 height=16 to rupert's image so that it doesn't flicker/move 2004-04-09 Jeffrey Stedfast * em-folder-selection.c (em_select_folder): Set the excluded bits on the folder-tree. Don't allow the user to xfer messages into folders which are: NoSelect, Virtual, nor vTrash. Fixes bug #56229. 2004-04-09 Dan Winship * em-folder-view.c (emfv_init): Create an EUserCreatableItemsHandler for the view. (emfv_finalise): Unref it. (emfv_activate): Activate it * mail-component.c (impl__get_userCreatableItems): add object/folder flags to the items 2004-04-08 Jeffrey Stedfast * em-migrate.c (cp_r): Now takes a pattern argument to limit files that get copied over (so we can limit imap cache to only the summary files - makes it faster). * mail-account-gui.c (mail_account_gui_build_extra_conf): Fixed up a bit to look nicer and make it closer to HIG compliant. * em-folder-tree.c (emft_drop_folder): We need to recursively copy the dragged folder tree over to the drop location, not just the parent folder. We also need to subscribe to the newly created folder in some cases. 2004-04-08 Not Zed * em-format-html.c (efh_format_headers): add the monkey button if we're from evolution. See #52977. (emfh_gethttp): cast away a warning. * mail-folder-cache.c: (update_1folder): VJUNK_FOLDER's dont exist, they're VTRASH folders now. * em-folder-view.c: remove message_changed stuff from camel folder stuff. * mail-component.c (mail_component_init): don't setup the search context here, wait till its requested. Fixes #56672. 2004-04-07 Not Zed * mail-component.c (view_changed_cb): hook to update the info label when the folderview changes. * em-folder-view.c (emfv_class_init): added 2 signals 'loaded' and 'changed'. For when a folder is set/cleared or when some state changes. (emfv_set_folder): emit LOADED signal when we set the folder. (emfv_list_message_selected): emit changed event. (emfv_gui_folder_changed): emit changed event. 2004-04-07 Jeffrey Stedfast * em-folder-tree.c (emft_tree_button_press): Check that emft_selection_get_selected() returns TRUE before we try to use the iter. Fixes bug #56652. (emft_popup_delete_response): Same idea here. (emft_popup_delete_folder): Same. (emft_popup_rename_folder): Same. (emft_popup_properties): Same. Fix for bug #56538 * em-folder-view.c (emfv_set_folder_uri): Don't set the preview empty here. (emfv_set_folder): If the folder is the same as the folder already on the emfv, just return. Otherwise clear the preview and continue setting the folder as normal. 2004-04-07 Jeffrey Stedfast * em-account-prefs.c (em_account_prefs_apply): Removed. * em-mailer-prefs.c (em_mailer_prefs_apply): Removed. * em-composer-prefs.c (em_composer_prefs_apply): Removed. * mail-config-factory.c (mail_config_control_factory_cb): No longer need the Apply stuff. * em-mailer-prefs.c (em_mailer_prefs_construct): Don't call a function that doesn't exist anymore. 2004-04-06 Jeffrey Stedfast * em-mailer-prefs.c (em_mailer_prefs_construct): Changed to save the settings in the signal callbacks. (em_mailer_prefs_apply): Don't save the settings here. * em-composer-prefs.c (em_composer_prefs_apply): Don't save the settings here. (em_composer_prefs_construct): Changed to save the settings in the signal callbacks. 2004-04-06 Not Zed * em-folder-tree.c (emft_tree_row_expanded): ref the emfoldertree in our thread message. (em_folder_tree_set_selected): same. (emft_get_folder_info__free): unref it. * mail-folder-cache.c (ping_store): use thread_queued_slow not thread_queued - we dont care when it runs. * em-folder-view.c (emfv_set_folder_uri): use thread_new for getting the folder, we do elsewhere, and it aids interactivity. 2004-04-05 Jeffrey Stedfast * em-migrate.c (em_migrate_dir): Migrate the thread_list setting. Fixes bug #56297. 2004-04-05 Not Zed * em-format-html-display.c (efhd_xpkcs7mime_button): if we have no sign status, use signed-nokey, rather than no icon. (efhd_xpkcs7mime_viewcert_clicked): show the certificate viewer since certificate_viewer_show doesn't show it. (efhd_xpkcs7mime_viewcert_foad): foad foad foad. The api changed and we need to foad it ourselves. ** See bug #52822. * em-format-html-display.c (efhd_xpkcs7mime_add_cert_table): if we can't find the cert, then desensitise the cert button. ** See bug # 56402. * mail-folder-cache.c (update_folders): if we're cancelled, noop. (mail_note_store_remove): mark the update data cancelled. * mail-ops.c (add_special_info): removed, this is done in camel now. (fix_unmatched_info): renamed from add_unmatched_info. (get_folderinfo_got): Removed the meaningless comment here. 2004-04-02 Jeffrey Stedfast * em-migrate.c (cp_r): Revert my "fix" from yesterday. We can't necessarily show progress (progress window may have been destroyed already). Fixes bug #53851 * em-folder-view.c (emfv_popup_move_cb): Save the uri as the default for copy/move. (emfv_popup_move): Use the default copy/move uri. (emfv_popup_copy): Same. * em-folder-selection.c (em_select_folder): Select the uri *after* the dialog gets shown. 2004-04-02 Jeffrey Stedfast Fixes bug #37416 * mail-folder-cache.c (update_1folder): Same as below. Also add vJunk fodlers to the list of folders that we display the total count for (as discussed on the mailing lists). * em-folder-tree-model.c (em_folder_tree_model_set_folder_info): Use 'total - deleted' as the count for Outbox rather than just the total count. 2004-04-02 Not Zed * em-inline-filter.c: do a per-line validation of the uuencoded stuff, based on the length byte. ** See bug #56338. * em-format-html.c (emfh_gethttp): fix the fugly "load http if" that doesn't work to be a fugly "load http if" that does work. (efh_format_timeout): dont set load_http_now here, its only an override now. 2004-04-01 Jeffrey Stedfast * em-migrate.c (cp_r): Report progress. "Fixes" bug #56355. * mail-account-gui.c (signature_changed): Set the updated sig->name on the menu item. * importers/netscape-importer.c (netscape_import_accounts): Updated for signature API changes. * mail-account-gui.c: Same. * mail-signature-editor.c: Same. * em-composer-prefs.c: Same. * mail-config.c: Rewrote the signature stuff to use ESignatureList instead. Much cleaner and less broken. * em-mailer-prefs.c (em_mailer_prefs_construct): Always make the Add/Remove Header buttons de-sensitised at the start. Fixes bug #56284. 2004-04-01 Eric Zhao * mail-account-gui.c (transport_type_changed): Commented grabbing focus on hostname edit, fix the focus issue of Account Assistant. 2004-03-31 Jeffrey Stedfast * em-format-html.c (efh_text_plain): Only do citation colouring if the user has specified to do so and use the user's specified colour when appropriate. Fixes bug #56290. * em-subscribe-editor.c (em_subscribe_editor_new): Save/restore the subscribe dialog's window size. Fixes bug #56230. 2004-03-31 Not Zed * mail.h: REMOVED! And there was much rejoicing. * *.[ch]: Cleaned up header inclusions and added plenty of forward declarations. Sped up complete re-compilation by upto 20%. ** See bug #55950. * em-utils.c (em_utils_in_addressbook): utility for checking if an email address is in the addressbook. I can't tell if it works 'cause it crashes eds. * em-format-html.c (emfh_gethttp): handle addressbook checking. 2004-03-30 Not Zed * mail-config.h: clean up the headers and use some forward decl's instead. * em-format-html.c (em_format_html_set_load_http): change state to an int 'style' instead. * em-folder-view.c (emfv_setting_notify): set the format load http option to the config value directly. ** See bug #56147. * message-list.c (clear_info): set the node data to NULL when we unref its data. (ml_get_save_id): use a different test for the root node, and return NULL if we don't have any data on the node (because we're cleaing it). ** See bug #54962. * em-folder-tree.c (emft_popup_new_folder_response): put back the old hack to open the vfolder editor if you try to create a folder under vfolders. ** See bug #55940. * mail-autofilter.c (mail_filter_rename_uri): map the uri to an email uri before passing to filter code. (mail_filter_delete_uri): same here. 2004-03-30 Radek Doulik * mail-config.glade: add spellLiveToggled signal * em-composer-prefs.c (em_composer_prefs_construct): fix typo, call toggle_button_init on prefs->spell_check instead of againg on prefs->auto_smileys (spell_setup): connect spellLiveToggled signal Fixes #55964 2004-03-29 Jeffrey Stedfast * em-folder-tree.c (emft_create_folder__free): Free the folder-info. * em-folder-browser.c (emfb_activate): Instead of comparing sstate[0] to '1', compare it against '0' like all the other code does. 2004-03-25 Sivaiah Nallagatla * Makefile.am : remove local-config.glade from glade_DATA as it is removed from CVS 2004-03-25 Rodney Dawes * em-composer-prefs.c (sig_edit_cb): (sig_add_script_cb): Use gtk_window_present instead of doing a show then raise, as this also puts the window on the current workspace (em_composer_prefs_construct): Fix the border widths for the dialog vbox and action area to be HIG-compliant, and realize the window Remove the dialog separator Use a box_pack_start, rather than box_pack_start_defaults which causes some weird behaviour when changing the border widths * em-subscribe-editor.c (em_subscribe_editor_new): Realize the dialog and set the border widths for its vbox and action area to be compliant with the HIG * local-config.glade: Removed this file as it is no longer used * mail-account-editor.c (construct): Realize the dialog, remove its separator, and set the border widths for its vbox and action area to be HIG-compliant * mail-account-editor.c (source_type_changed): (transport_type_changed): Fix the showing and hiding of the widgets related to the SSL options (mail_account_gui_new): Get the transport/source frames for the SSL options, and hide them by default Show the default folder buttons by default here (mail_account_gui_setup): Only call _show not _show_all here, so we don't mess up the shown/hidden state of things * mail-account-gui.h: Add ssl_frame widget to the MailAccountGuiService * mail-config.glade: * mail-search.glade: * mail-security.glade: HIG-compliance fixes for the glade dialogs * message-tag-followup.c (construct): Don't set border_width on the dialog itself Remove the separator from the dialog Set the border_widths for the dialog's vbox and action areas to be compliant with the HIG * message-tags.glade: * subscribe-dialog.glade: HIG-compliance fixes for these dialogs Original patch from Martyn Russell 2004-03-24 Danilo Šegan * mail-ops.c (get_messages_desc): Use ngettext for handling plural forms (fixes bug #53464). 2004-03-23 Jeffrey Stedfast * em-format-html.c (emfh_gethttp): Use sizeof() to decide how big buffer is so that in the future, if we change the length of bufefr, things will Just Work (tm). * em-mailer-prefs.c (em_mailer_prefs_construct): Fixed the key to fetch the value from the correct location. It's junk/check_incoming, not junk/sa/check_incoming. Fixes bug #55903. * em-folder-tree-model.c (em_folder_tree_model_set_expanded): Fixed some logic bugs. 2004-03-23 Radek Doulik * em-format-html-display.c (efhd_format_attachment): use EM_FORMAT_HTML_VPAD * em-format-html.h (EM_FORMAT_HTML_VPAD): added new define for vertical padding * em-format-html.c (efh_format_message): change padding table so that it works OK with fixed gtkhtml 2004-03-23 Not Zed * em-format-html-display.c (efhd_attachment_popup): dont add the show/hide menu items if we can't ever show it inline. (efhd_attachment_button): disable the ">" button if we can't view the content inline. See #52086. * em-format-quote.c (emfq_format_attachment): format inline(d) parts automatically into the reply. Part of #55702. * em-utils.c (em_uri_from_camel): if we get an email uri passed in, just pass it out again, without first going to camel to do it. 2004-03-22 Not Zed * em-format.c: * em-mailer-prefs.c: Add Newsgroups to the default header list. * em-format-html.c (efh_format_header): handle the newsgroups header, output news: url's. For bug #??? i can't recall, i closed it already! 2004-03-19 Jeffrey Stedfast Fixes bug #54800. * em-folder-tree.c (tree_drag_drop): Remove the autoscroll timeout. (tree_drag_leave): Remove the autoscroll timeout. (tree_autoscroll): New autoscroll timeout callback - automagically scrolls the treeview if appropriate. (tree_drag_motion): Setup the autoscroll timeout. 2004-03-19 Not Zed * mail-component.c (mail_component_remove_store): ref the store before running the async disconnect, otherwise we unref one too many times. 2004-03-18 Jeffrey Stedfast * mail-account-gui.c (mail_account_gui_setup): Don't set the account source/transport types to disabled simply because the provider is NULL (think of the "None" option). (source_type_changed): Need to update widget sensitivity based on locked'ness here. (transport_type_changed): Same. * em-utils.c (em_utils_add_address): rfc2047 decode the address here before passing it off to the addressbook (which expects it to be in human-readable form, not encoded). Fixes bug #55591. 2004-03-18 Not Zed * mail-account-gui.c (mail_account_gui_new): save the source and transport vbox's to enable/disable the whole lot easier. (mail_account_gui_setup): enable above based on perms. (mail_account_gui_build_extra_conf): also disable extra page, as above. * em-account-prefs.c (account_cursor_change): disable the whole account editor if accounts are ro. 2004-03-17 Not Zed * em-format-html.c (efh_message_deliverystatus): format as plain text too. * em-format.c (emf_message_deliverystatus): format delivery status messages as plain text, rather than as messages. since they wont be CamelMimeMessages. Maybe they should be silently hidden. * mail-offline-handler.c (store_go_online): split this, only call add_store/note_store once we've actually set the store online. (store_went_online): set the store up once we're fully online. Works around a deadlock in #55618. * em-account-prefs.c (account_cursor_change): disable editing/adding/removing accounts etc if accounts aren't editable. (em_account_prefs_construct): call above after setup. * mail-component.c (mc_quit_sync): if we have empty on exit days, check that. keep track of the last empty on exit time. * em-mailer-prefs.c (emmp_empty_trash_init): init the trash stuff here. (em_mailer_prefs_apply): save empty trash on exit frequency. 2004-03-16 Not Zed * mail-account-gui.c (mail_account_gui_auto_detect_extra_conf): check extra conf items are writable. (mail_account_gui_build_extra_conf): same. (setup_service): add gui arg, and do above for auth and ssl args. 2004-03-16 Jeffrey Stedfast Fix for bug #55358. * em-folder-tree.c (emft_expand_node): Changed to be the callback function for em_folder_tree_model_expand_foreach(). (emft_maybe_expand_row): Renamed from emft_loading_row_cb(). We now handle both "loading-row" an "loaded-row" signals. Also updated for slight change in key generation. (em_folder_tree_new_with_model): Connect to the "loaded-row" signal. (emft_update_model_expanded_state): Updated for slight change in key generation. * em-folder-tree-model.c (em_folder_tree_model_add_store): Emit the "loaded-row" signal for the newly added store. (em_folder_tree_model_set_folder_info): Emit "loaded-row" for the row we've just set the info on (but only after we've added a child node if there is one, so the signal handler can expand the newly added row if appropriate). (em_folder_tree_model_class_init): Setup the "loaded-row" signal. (em_folder_tree_model_finalize): The tree-state is now an xml file and not a binary file, so change the expanded free func. (em_folder_tree_model_load_state): Load the expand-state xml file. If one doesn't exist, setup some defaults. (em_folder_tree_model_get_expanded): Scan the XML tree for the node. (em_folder_tree_model_set_expanded): Same. (em_folder_tree_model_save_expanded): Save the expand-state xml tree to disk. (em_folder_tree_model_expand_foreach): New function to iterate over all xml nodes and call the callback if the expand state is "true". 2004-03-16 Jeffrey Stedfast * mail-component.c (impl_requestCreateItem): Don't focus the name_entry widget here. * em-folder-selector.c (em_folder_selector_create_new): Focus the name_entry widget here rather than in mail-component.c * em-folder-tree.c (emft_drop_async_desc): New function to return a description of the async drop operation. Fixes bug #54808. 2004-03-15 Jeffrey Stedfast * em-utils.c (reply_to_message): If the mail_get_message() async op fails, it will still call us with a NULL message to check for that. Fixes bug #55612. (post_reply_to_message): Same. * em-folder-tree.c (emft_copy_folders__copy): Use camel_store_rename_folder() when appropriate (m->tostore == m->fromstore && m->delete) 2004-03-15 Not Zed * em-format.c (em_format_format_error): make this a varags function, which then calls the virtual method to do the work. (emf_multipart_appledouble, emf_multipart_mixed) (emf_multipart_alternative, emf_multipart_related) (emf_message_rfc822): print an error to explain why you're getting source content displayed. (em_format_format_secure): make this a function. and if we're done formatting a secure part, and we dont have a parent anymore, null out the validity. See #55541. 2004-03-12 Jeffrey Stedfast * em-folder-browser.c (emfb_search_search_activated): No-op if emfv->folder is NULL (this means we are looking at a store folder? or else the folder hasn't loaded yet). Fixes bug #55293. 2004-03-11 Radek Doulik * mail-ops.c: remove junk learning thread, it's handled in camel-folder.c:folder_changed now * em-folder-view.c (emfv_popup_mark_junk): use em_folder_view_mark_selected, set junk, junk-learn and seen flags (emfv_popup_mark_nojunk): similar, reset junk, set junk-learn flags 2004-03-12 Jeffrey Stedfast * mail-ops.c (mail_send_mail): Removed. No longer in use (hasn't been since before 1.2). (send_queue_send): Before enetring the main send loop, create a temporary uid array containing ONLY the messages we will send (ie. not any that have been marked deleted) so that we can more accurately report the number of messages total that we are sending. Also continue sending even if we encounter an exeption in mail_send_message() (unless, of course, it is a user-cancel). Merge any exceptions we get into the master exception variable and ALWAYS sync/expunge the queue folder. 2004-03-11 Jeffrey Stedfast * em-folder-browser.c (emfb_set_folder): Reverted signal blocking stuff. Doesn't work and is unneeded with the proper fix. * em-format-html.c (efh_format_header): Fixed a bug where txt wasn't being properly initialised in all cases for Date headers. Also fixed the x-evolution-mailer code to simply use the ehader->value that was passed in. (efh_format_headers): Fixed to handle the special X-Evolution-Mailer header. 2004-03-11 Not Zed * em-folder-browser.c (emfb_set_folder): a really gross hack, disable all search handlers before setting the search and set hte search manually rather than going through the callbacks. Partial fix for #55267, and ugly as it is. (emfb_init): save the search signal id's. (emfb_set_folder): ugh, properly set the defaults if the settings haven't been stored on the folder, and properly move them upstream to the bonobo menus. * em-folder-tree-model.c (sort_cb): when we sort, handle not having the node in the tree. otherwise we always compare against "" which puts it at the head of the branch, rather than the tail. See #55428. * em-folder-tree.c (tree_drag_motion): make dnd look funny for joe. #55246. * mail-component.c: change stores hash to point to a structure, in which we maintain the vtrash and vjunk folders for the entirety of the session. memory use be damned i guess. #55417 and partially #55391. 2004-03-11 Not Zed * em-format-html.c (efh_format_header): pass the raw header in instead of name and value. (efh_format_headers): if we have specific headers to show, iterate over all headers and print out all matching ones, so duplicate headers are properly displayed. Related to #55298. * em-folder-selector.c (em_folder_selector_construct): dont set this to be modal. otherwise you can't click on error popups. duh. 2004-03-08 Not Zed * em-folder-selection-button.c (em_folder_selection_button_clicked): don't let the user select virtual/vtrash folders or non-selectable folders. * mail-component.c (impl_createControls): disable selection of non-select rows. * em-folder-selector.c (em_folder_selector_create_new): exclude folders with noinferiors set. * em-folder-tree.c (folder_tree_new): add folder tree arg, hook onto the selection funciton for the tree selection. (emft_select_func): selection override function. allow certain things to be excluded. (em_folder_tree_set_excluded): api to set what is excluded from the selectability. (emft_tree_row_activated): call emft_select_func check to see if this row is excluded before emitting an activated signal. * em-folder-tree-model.c (em_folder_tree_model_set_folder_info): save folder info->flags in the tree store. * mail-folder-cache.c (create_folders): use tail recursion. (get_folders): tail recurse. * (*): Fixed for api changes in camel. 2004-03-10 Jeffrey Stedfast Fix for bug #55298. * em-format-html.c (efh_format_header): Now takes a default txt argument (header value). For address/date headers, if this isn't set, default back to the old behaviour of looking it up. (efh_format_headers): If we are iterating thru the camel raw headers, always pas the header value as the txt argument, otherwise always pass NULL. 2004-03-10 Jeffrey Stedfast * em-format-html-display.c (efhd_xpkcs7mime_validity_clicked): Removed an unused variable left over from an old attempted fix. * em-folder-selector.c (emfs_response): Select the same folder in the create-folder dialog as is selected in the parent selector dialog. Fixes the rest of bug #53862. Partial fix for bug #53862. * em-folder-selector.c (emfs_response): Connect to the newly added "folder-added" signal and save a created_uri string so that we can be sure to only listen for the creation of the folder the user created in *our* create-folder dilog (and not from some other place). * em-folder-tree-model.c (folder_subscribed): Emit a new "folder-added" signal. * mail-session.c (request_password): Focus the entry widget. Fixes bug #55330. 2004-03-10 Radek Doulik * em-junk-filter.c (pipe_to_sa_with_error): call camel_stream_close and close the fds[1] (pipe_to_sa_with_error): do not call close, camel_stream_close should be enough to be sure the fd was closed 2004-03-08 Jeffrey Stedfast * em-folder-tree.c (emft_create_folder): New async function to create a folder. (em_folder_tree_create_folder): Partly moved into emft_create_folder. Might be able to remove this code, but lewing might be using it in Connector or something? Need to ask him... (emft_popup_new_folder_response): Use emft_create_folder() instead. 2004-03-08 Radek Doulik * mail-ops.c (mail_filter_junk): new method, filter folder with FILTER_SOURCE_JUNKTEST type filter * em-folder-view.c: added Filter Junk command and junk icons to menus, added apply filters icon to popup menu (emfv_popup_filter_junk): new helper method, calls mail_filter_junk 2004-03-05 Jeffrey Stedfast * em-format-html-display.c (em_format_html_display_search): Don't set our parent window as the efhd, ehfd isn't even a widget. Fixes bug #54030 * em-format-html-display.c (efhd_search_response): Reset the searching tokeniser on Cancel. * e-searching-tokenizer.c (e_searching_tokenizer_reset): New function to reset a search tokeniser. 2004-03-05 Not Zed ** See bug #55096. * importers/evolution-mbox-importer.c (process_item_fn): hack, unref when complete * importers/evolution-outlook-importer.c (outlook_importer_new): init status lock. (process_item_fn): hack, unref ourselves when we're complete. i think the shell leaks the ref. 2004-03-04 Jeffrey Stedfast * em-folder-view.c (emfv_popup): If event == NULL, don't try to use event->key.time * em-migrate.c (upgrade_vfolder_sources_1_4): New function to upgrade vfolder sources. (em_upgrade_xml_1_4): If the doc is vfolders.xml, upgrade the sources nodes. 2004-03-03 Not Zed ** See bug #53738. * mail-ops.c (fetch_mail_fetch): if we've been cancelled, uncancel so syncing can work. and always sync the folder (with expunge if deleting). ** See bug #54924. * em-utils.c (em_utils_selection_set_urilist): Try to get the drop filename from the message subject, or folder name. (em_utils_empty_trash): kill warning. ** See bug #54121. * mail-component.c (impl_requestCreateItem) (emc_new_folder_response): Hack in a nastish implementation of create folder for the new menu. (impl__get_userCreatableItems): add 'new mail folder' to new button. 2004-03-03 Not Zed * em-folder-tree-model.c (em_folder_tree_model_set_folder_info): if we have the folder opened already, and its the outbox, then use the total count instead of unread count. Bit of hack, but copies mail-folder-cache stuff. * mail-component.c (mc_add_store): renamed from mail_component_add_store, internal call. Added a done callback. (mc_add_local_store): renamed from mc_add_store, callback for local store. (mail_component_add_store): call mc_add_store to do the work. (mc_add_local_store_done): ugh, the target of all this shit - note all the default folders now they should be setup. * mail-folder-cache.c (mail_note_folder): clean up the logic a bit. was gonna do osmething else but it didn't work. 2004-03-02 Not Zed * mail-send-recv.c (mail_send): if we're already sending, up the again count to tell it we need to re-send again. (receive_done): if we've been asked to run a send again while we were already running it, run it again to make sure we didn't miss any new messages. See bug #46839. * em-mailer-prefs.c (em_mailer_prefs_construct): update check_incoming_imap changes for merge conflicts. (settings_changed): i have no idea what these changes jeff did do, but check_incoming_imap is no longer needed, so i've deleted most of it. 2004-02-27 Not Zed * em-format.c (emf_multipart_encrypted, emf_multipart_signed): If validation fails, display as multipart/mixed rather than unkown attachment type, and make the error a little clearer that its an error. See #52939. 2004-02-26 Not Zed * message-list.c (regen_list_regened): NOOP if the folder has changed. * mail-session.c (mail_session_check_junk_notify): remove check_incoming_imap test. (mail_session_init): " * evolution-mail.schemas.in.in: Remove check_incoming_imap option. * mail-config.glade: Remove check incoming imap checkbox. * em-mailer-prefs.c (em_mailer_prefs_construct): remove check_incoming_imap test. (em_mailer_prefs_apply): " (settings_changed): " 2004-03-02 Jeffrey Stedfast * em-folder-tree.c (emft_tree_button_press): s/||/&&/. Fixes a dumb bug I introduced yesterday. 2004-03-01 Jeffrey Stedfast * em-folder-selector.c (em_folder_selector_construct): Connect to the folder-activated signal. (folder_activated_cb): Call gtk_dialog_response() with GTK_RESPONSE_OK. Fixes bug #54793. * em-folder-tree.c (emft_tree_row_activated): New callback to emit the "folder-activated" signal which is needed to fix bug #54793. (emft_tree_button_press): Handle button1 double-clicks too (also for bug #54793). (emft_tree_button_press): On right-click, we also want to select the folder the user right-clicked on. Fixes bug #54772. 2004-02-27 Jeffrey Stedfast * em-mailer-prefs.c (em_mailer_prefs_construct): Fixed some console warnings from my last commit. * em-folder-view.c (emfv_setting_notify): If gconf_entry_get_value() returns NULL, then it means the key was unset or something. Don't use g_return_if_fail() for that. First of the lockdown fixes... * em-composer-prefs.c (em_composer_prefs_construct): Same as below. * em-mailer-prefs.c (em_mailer_prefs_construct): Respect locked-down keys by disabling their sensitivity to the user. (settings_changed): Don't re-enable check_incoming_imap if the key is locked. 2004-02-26 Rodney Dawes * em-format-html-display.c (efhd_attachment_button): Create the arrows in these widgets as GTK_SHADOW_NONE, since the default arrow type in GTK+ 2.x is flat triangle arrows, and shadow types are generally ignored for arrows anyway, and so we don't look ugly with themes that handle shadow types on arrows correctly 2004-02-26 Jeffrey Stedfast Fix for bug #54352 * em-message-browser.c (emmb_class_init): Set update_message_style to FALSE. * em-folder-view.c (emfv_setting_notify): Only update message display style if our subclass wants us to. (emfv_class_init): Set update_message_style to TRUE. (emfv_view_mode): Don't save the gconf key unless our class allows us to. 2004-02-26 Jeffrey Stedfast * em-utils.c (em_utils_folder_name_from_uri): Make sure url->path is non-NULL before setting folder_name to url->path + 1. Could possibly fix bug #54853. 2004-02-25 Jeffrey Stedfast * em-format-html-display.c (efhd_attachment_button): Protect against using NULL pixbufs. Gets rid of a lot of console warning spewage on my system. * em-folder-view.c (emfv_list_key_press): Removed Delete/KP_Delete from here. Now handled via the bonobo-ui menu accels. Fixes bug #53504. 2004-02-25 Radek Doulik * mail-session.c (main_get_filter_driver): set seen flag for junk messages * em-folder-view.c (emfv_popup_mark_junk): do not set DELETED 2004-02-24 Jeffrey Stedfast * mail-account-editor.c (construct): Removed Apply button. As discussed on IRC, UI doesn't feel we should have an Apply button here. 2004-02-24 Jeffrey Stedfast * mail-account-editor.c (construct): Need to listen for changes to S/MIME options, the signature option menu, and any extra provider-specific config options. Fixes bug #54036. * em-folder-view.c (emfv_popup_mark_junk): Set the SEEN flag as well. (emfv_list_key_press): Removed the skip-to-next-message logic as this was already being handled in emfv_popup_delete(). Fixes bug #54471. (emfv_enable_menus): Re-enable MessageDelete here. Fixes bug #54770. * em-utils.c (em_utils_folder_is_drafts): Use the new camel_store_folder_uri_equal() function. (em_utils_folder_is_sent): Same. 2004-02-23 Jeffrey Stedfast Fix for bug #54057 * em-utils.c (em_utils_folder_is_sent): Use provider->url_equal() rather than camel_store_uri_cmp() since that function did not do anything close to what it claimed to do. Also use em_uri_to_camel() here on the account sent_folder_uri. (em_utils_folder_is_drafts): Same. 2004-02-23 Jeffrey Stedfast * em-message-browser.c (emmb_list_message_selected): Protect against NULL uids. (emmb_set_message): Same. * em-format-quote.c (emfq_format_message): Print the headers when forwarding inline/quoted. Fixes bug #53916. * em-folder-tree.c (tree_drag_motion): We want UID_LISTs to drop with the MOVE action by default. Fixes a common complaint from IRC. 2004-02-23 Not Zed * em-format.c (emf_multipart_signed): check mps->protocol != NULL before dereferencing it. See #54406. 2004-02-20 Jeffrey Stedfast * em-folder-view.c (emfv_list_key_press): Delete key should always delete, never undelete (bug #53215). Also fixes a bug where uids->len was being accessed after uids had been free'd. Fix for bug #53997 * em-folder-view.c (emfv_list_message_selected): Ref the emfv before spawning the async event. (emfv_list_done_message_selected): Check emfv->preview != NULL. Also unref the emfv when done. 2004-02-20 Dan Winship * mail-component.c (set_prop): Remove the debug message here. 2004-02-20 Not Zed * mail-vfolder.c (mail_vfolder_add_uri): fix for vfolder-rule api changes. * mail-folder-cache.c (unset_folder_info, setup_folder) (rename_folders): switch the sense of the no select checks. TEST! 2004-02-19 Chris Toshok * em-format.c (emf_application_xpkcs7mime): wrap code with ENABLE_SMIME instead of HAVE_NSS. (emf_multipart_signed): same. (type_builtin_table): same. 2004-02-19 Rodney Dawes * em-folder-tree.c (emft_save_state): Revert previous change, doh 2004-02-19 Rodney Dawes * em-folder-tree.c (emft_save_state): Don't set the timeout id to 0 and then immediately return FALSE, which tries to remove the timeout 2004-02-19 Not Zed * mail-send-recv.c (get_receive_type): * mail-config.c (mail_config_get_account_by_source_url) (mail_config_get_account_by_transport_url): * mail-component.c (mail_component_load_store_by_uri): * mail-account-gui.c (mail_account_gui_setup) (mail_account_gui_save): * em-utils.c (em_utils_empty_trash, em_uri_from_camel): * em-folder-tree-model.c (account_changed): * em-folder-selector.c (em_folder_selector_get_selected_uri): fix camel provider api changes. 2004-02-18 Jeffrey Stedfast * em-composer-prefs.c (sig_fill_list): Changed the name to not imply we are working with a GtkCList widget (since we are using a GtkTreeView). * em-folder-tree.c (emft_tree_button_press): Pass flags to em_popup_target_new_folder() instead of just an isstore arg. (emft_tree_button_press): Fake the fi flags for vTrash/vJunk so that em-popup.c can disable the delete flag for these. * em-popup.c (em_popup_target_new_folder): Instead of taking an isstore argument, take a flags argument so that our caller can give us hints about the selected folder/store. Also fixed a logic bug from my previous commit. 2004-02-12 Jeffrey Stedfast * em-folder-tree.c (emft_tree_button_press): Updated for em-popup API change (altho currently passes a dummy value). * em-popup.c (em_popup_target_new_folder): Check for vTrash/vJunk by checking the CAMEL_FOLDER_VIRTUAL info flags bit. (perhaps this flag should be renamed to SPECIAL? VIRTUAL might not have been a good name). Also changed to check flags & CAMEL_FOLDER_NOSELECT rather than checking the uri string for a noselect param. * mail-folder-cache.c (unset_folder_info): Instead of checking for ";noselect" in the uri, check for a CAMEL_FOLDER_NOSELECT flag on mfi->flags. (setup_folder): Copy the fi->flags to mfi->flags here. (rename_folders): Same. (setup_folder): Check fi->flags for CAMEL_FOLDER_NOSELECT here instead. (rename_folders): Same. Also gets rid of a FIXME. 2004-02-18 Jeffrey Stedfast * em-format-html-display.c (efhd_xpkcs7mime_validity_clicked): Revert change from yesterday. (efhd_xpkcs7mime_button): Use the icon from the table. 2004-02-18 Not Zed ** See bug #54492. * em-folder-tree.c (emft_popup_copy_folder_selected): check the store flags, not the fragment presence to find out if we use the fragment as the path. 2004-02-17 Jeffrey Stedfast Fix for bug #54060 (except for the "don't let users copy/move messages to Outbox" bit). * em-folder-tree.c (emft_drop_target): Rearranged a little. We can check for special dest folders right away. Also added a check for the default local folders (Drafts/Inbox/Outbox/Sent) since we don't want to be able to move them anywhere else (copying is ok). (emft_popup_copy_folder_selected): Don't allow moving any of the default local folders to be consistant with drag&drop changes. (emft_popup_rename_folder): Don't allow the user to rename a default local folder. (emft_popup_delete_folder): Don't allow deletion of special local folders. * mail-component.c (mail_component_peek_local_store): New function to peek the local store. 2004-02-17 Jeffrey Stedfast * em-format-html-display.c (efhd_xpkcs7mime_validity_clicked): Display an alternate description based on the trust value if we have a trust to work with. * em-folder-browser.c (emfb_hide_deleted): Set the hide_deleted bool on EMFolderView. * em-folder-view.c (emfv_popup_delete): Fix Sarfraaz Ahmed's fix to only jump to the previous message if hide_deleted is set. Otherwise his fix gets extremely irritating. (emfv_list_key_press): Same. 2004-02-17 Not Zed ** See bug #53914. * em-utils.c (guess_account): do some extra checks, message source, and source folder. (guess_account_folder): helper to guess account based on folder. ** See bug #54200. * em-popup.c (em_popup_target_new_select): add EM_POPUP_SELECT_FOLDER - to find out if we have a folder at all. Handle getting a NULL folder passed in. * em-folder-view.c (em_folder_view_get_popup_target): Added EM_FOLDER_VIEW_SELECT_FOLDER - to detect when we dont have a folder set on the emfolderview. * em-folder-browser.c (emfb_mark_all_read): if we don't have a folder, dont try and run. (emfb_enable_map[]): Disable a bunch of stuff we have no folder set. * importers/pine-importer.c (import_contact): fix for the weird-arsed e-contact list api. and fix a small memleak. 2004-02-13 Jeffrey Stedfast * em-folder-tree.c (emft_drop_folder): Make sure the drop-target folder doesn't already contain a folder named identical to the one we are dropping by using the new CAMEL_STORE_FOLDER_EXCL flag. Fixes bug #53810. 2004-02-13 Radek Doulik * evolution-mail.schemas.in.in: added defaults for composer width/height 2004-02-13 Sarfraaz Ahmed * em-folder-view.c (emfv_popup_delete): added the code to get the previous mail in a list, if get_next_mail fails. This is a fix for #54195 (emfv_list_key_press): Same as above 2004-02-13 Not Zed * importers/netscape-importer.c: use mail-importer to import the mail tree, fix the account stuff to talk directly to mail config. Added cancel button. etc. This is completely untested apart from compiling with no warnings. * importers/mail-importer.c (import_mbox_import): dont re-use the exception for syncing. * importers/evolution-outlook-importer.c: major reworking. Some platform fixes, runs in another thread, simpler/cleaner main loop. This is completely untested apart from compiling with no warnings. * importers/evolution-mbox-importer.c (support_format_fn): we dont want to check the From_ line case insensitive! (create_control_fn): implement this weird api. 2004-02-12 Not Zed * importers/elm-importer.c: rewrote all importing stuff. * importers/mail-importer.c (mail_importer_import_folders_sync): split out into a recursive function & entry. Now handles mozilla format stuff with a flag. (import_mbox_import): made the cameloperation properly save/restore multiple registrations. 2004-02-12 Radek Doulik * em-junk-filter.c (pipe_to_sa_with_error): use g_find_program_in_path to avoid fork in case program is not available 2004-02-11 Jeffrey Stedfast * mail-component.c (mail_control_new): Disable the bonobo-ui-component statusbar when using the EMFolderBrowser outside of the mail component. This prevents the Connector component from having 2 status bars. * em-popup.c: #include (em_popup_create_menu): Wrap item->label with _() so that the strings get translated properly. 2004-02-11 Christian Neumair * em-folder-tree-model.c (sort_cb): "On this Computer" -> "On This Computer". * mail-component.c (mc_setup_local_store): Ditto. 2004-02-11 Jeffrey Stedfast * em-format-html-print.c: Same. * em-junk-filter.c: #include * em-popup.c: Add license & config.h 2004-02-11 Radek Doulik * em-junk-filter.c (em_junk_sa_test_spamd): if spamc is not available, try /usr/sbin/spamc 2004-02-10 Radek Doulik * em-junk-filter.c (em_junk_sa_test_spamd): try to check if system wide spamd has --local parameter set according to our setting (em_junk_sa_test_spamd): in case we were unable to start our own spamd, try to run it from /usr/sbin before giving up 2004-02-11 Not Zed * importers/mail-importer.c (mail_importer_import_folders_sync): call the right recursive function, oops. * importers/mail-importer.h: don't include camel-operation.h, but fix up the forward decl usage. 2004-02-11 JP Rosevear * importers/mail-importer.h: include camel-operation.h 2004-02-11 Not Zed * importers/pine-importer.c: Basically rewrote this, the import tasks run in another thread. It tells you more about what's going on, and its cancellable. (pine_store_settings): changed the meaning of the settings slightly, if set it means we've processed them already. * mail-component-factory.c (factory): hook in importer factory callback. 2004-02-10 Not Zed * importers/*-importer.c: removed module init, just provide a new method. Updates for api changes. * Makefile.am: link mail importers in directly. * mail-importer.c: changed to do stuff in-memory with linked stuff, moved to importers/. * importers/GNOME_Evolution_Mail_Importers.server.in.in: merge all importer .server info's here, point them all to the mailer factory. Removed the others. * importers/Makefile.am: remove Mailer.idl stuff. Move all importers to a single library. 2004-02-09 Not Zed * em-folder-tree.c (tree_drag_data_delete): merged in code from em_folder_tree_model_drag_data_delete. (tree_drag_data_get): similar. (tree_drag_data_received): similar. (drag_text_uri_list): removed, use em_utils_selection_set_urilist in tree_drag_data_get instead. (em_folder_tree_enable_drag_and_drop): merged in em_folder_tree_model_set_drag_drop_types. (tree_drag_motion): merge in drop_possible, handle qualifiers, and return the right type. (em_folder_tree_model_row_drop_target): rename to emft_drop_target, and make private. Beefed up substantially, handles illogical drops, dropping on to special folders and properly handling vfolder uri's (at least within the same tree instance). * em-folder-tree-model.c: Moved all of the DND stuff to em-folder-tree, where it belongs, made it all static. Should allow for some sharing of code too. * em-format-quote.c (emfq_format_message): just print the \n after the credits in the same printf, rather than adding an else. Add a
too, otherwise it has no effect. 2004-02-06 Jeffrey Stedfast * em-format-html.c (efh_format_headers): Make private (only EMFormatHTMLQuote used it and that class is no longer in use). (efh_format_message): Updated for above change. * em-format-quote.c (emfq_format_message): Always write a \n after the credits line. * em-subscribe-editor.c (sub_folderinfo_get): Set the NO_VIRTUAL flag bit for get_folder_info(). Fixes bug #51887. 2004-02-06 Radek Doulik * em-folder-view.c (emfv_popup_mark_nojunk): move to the next message after mark not junk as well * em-junk-filter.c (em_junk_sa_test_spamd): split into spamassassin and spamd tests (em_junk_sa_is_available): test spamd only if spamd usage enabled (pipe_to_sa_with_error): extended pipe_to_sa, last added parametr specifies return value if an error occured (em_junk_sa_check_junk): don't use /bin/sh -c when running spamassassin, it's not needed and we need to avoid getting 126,127 exit codes from the shell (em_junk_sa_check_junk): pass 0 rv_err to pipe_to_sa_with_error to avoid false positives in case someone removes/uninstalls SA while evolution runs 2004-02-06 Not Zed ** See bug #53258. * em-format-html-display.c (efhd_find_handler): force any bonobo handler types to always be inline, even attachments. * em-format.c (em_format_is_inline): use handler flags for special cases, removing all hard-coded types. * em-format.h (EMFormatHandler): add a flags field, so far a flag to set default inline viewing of the content. 2004-02-06 Not Zed * em-folder-properties.c: include string.h to kill warning. ** See bug #53627. * em-folder-view.c (emfv_popup_mark_junk): changed to work like delete does, jumping to the next message if required, and marking things immediately, then queuing up the junk marking job if required. * mail-ops.c (mail_mark_junk): ugh, this stuff totally can't go accessing messagelist from another thread!!!! Changed so this code only does the junk reporting, not setting flags. UGH! It should be doing this implictly on the folder when you set the flags, or at least when you sync the folder!!! Changed ot use the queued thread. * message-list.c (find_next_undeleted): changed to find next-unhidden, i.e. junk as well as deleted, if we're in hide-deleted mode. (build_tree): always call find_next_undeleted if we have a cursor. (build_flat): same. 2004-02-05 Rodney Dawes * em-message-browser.c (emmb_list_message_selected): Grab focus on the HTML widget when we display Fixes #52942 2004-02-05 Jeffrey Stedfast * em-message-browser.c (emmb_list_message_selected): Set the new title. (em_message_browser_window_new): Connect to the message_selected signal in the message-list widget. Fixes bug #52232. * em-folder-tree-model.c (em_folder_tree_model_row_drop_target): Now takes a GdkContext arg... will need this later when we want to re-enable dnd of vfolders. * em-folder-browser.c (emfb_set_folder): Always set the search_state, even if it is NULL (NULL means default/unset state). * em-folder-view.c (emfv_mail_next_flagged): Pass TRUE as wraparound (to both be consistant with prev_flagged and to fix bug #48681. 2004-02-05 Not Zed * em-folder-tree.c (emft_copy_folders__copy): sync the from folder if we're going to delete it, otherwise we can't because its not empty. See #53815. 2004-02-05 Not Zed * em-folder-tree-model.c (em_folder_tree_model_drag_data_received): hmm, another well tested bit of code ... if you launch another thread you gotta copy the selection since it wont hang around until we're done with it. So copy/parse the selection data into appropriate structures. (drop_folder): just take the async message as an argument, rather than copying half of it to the stack. (drop_text_uri_list, drop_uid_list): replace most args with the thread message. (drop_message_rfc822): removed, now trivial. (emftm_drag_data_received_async__drop): change for changed args, and fix a memleak. (emftm_drag_data_received_async__free): fixed for changed structure. * em-folder-tree.c (em_folder_tree_create_folder): call abort before we unref, aid debugging if we hit it. * mail-vfolder.c (uri_is_spethal): check for vfolder/vtrash folders. Based on name check and store options. 2004-02-04 Jeffrey Stedfast * em-folder-tree-model.c (em_folder_tree_model_row_drop_target): Don't allow dropping into a vfolder (store). Fixes bug #53757. 2004-02-04 Not Zed ** See bug #53683. * mail-ops.c (mail_sync_store): new async op to call CamelStore::sync. * mail-component.c (impl_requestQuit): implement, check to see if we can quit, or have open or unsent messages (and are in online mode). (impl_quit): implement. Trigger off a sync of all open stores, and return FALSE until its done. (impl_upgradeFromVersion): fixed the signature to match the idl, killed that warning at last. ** See bug #53832. * em-folder-browser.c (emfb_folder_properties): only show this if we have a uri set. Strictly, the menu item shouldn't be activated. ** See bug #53131. * em-folder-browser.c (em_folder_browser_show_preview): copy the message list's cursor_uid before calling set_message, since it can get freed during setting the message. 2004-02-03 Jeffrey Stedfast * em-folder-tree.c (tree_drag_data_received): Modified slightly. The model now calls gtk_drag_finish() for us when it is done. * em-folder-tree-model.c (em_folder_tree_model_drag_data_received): Make this perform camel operations in another thread so we don't block. (em_folder_tree_model_drag_data_get): Updated args to be consistant with drag_data_received. 2004-02-03 Radek Doulik * em-junk-filter.c: handle the sa prefs here, have own gconf client with sa dir added * mail-session.c: removed sa prefs 2004-02-02 Jeffrey Stedfast Fix for bug #52941 * em-message-browser.c (em_message_browser_window_new): Set window size based on previous size; load from gconf if necessary. (window_size_allocate): Save window size changes. 2004-02-02 Not Zed ** See bug #53549. * em-folder-selector.c: Fix handling a parent path of "/". * mail-ops.c (mark_junk_mark): removed the really innacurate cut and paste comment. This has nothing to do with filter_folder. ** See bug #52994. * em-folder-properties.c (em_folder_properties_show): redirect vFolder uri's to the vFolder editor. ** See bug #53502. * em-folder-browser.c (emfb_folder_properties): implement. * em-folder-tree.c (emft_popup_properties): fixed for change below. * em-folder-properties.[ch]: Moved the folder properties window from em-folder-tree.c to its own file. 2004-02-02 Not Zed ** See bug #53559. * em-folder-tree.c (folder_tree_new): set CAN_FOCUS flag on the folder tree content widget. * em-folder-selector.c (em_folder_selector_construct): Don't wrap the folder tree in a scrolled window. Its already in one ????. (em_folder_selector_construct): dont set can_focus on the folder tree. 2004-02-01 Bill Zhu Fixes for bug #53530 * em-utils.c (em_utils_redirect_message): Removed the duplicate adding of attachments 2004-01-30 Jeffrey Stedfast Fixes for bug #53348 * mail-account-gui.c (mail_account_gui_save): Only add the new store to the mail-component if the mail-component doesn't already know about it (ie. only if we are adding a new account). * em-folder-tree-model.c (em_folder_tree_model_add_store): Hash our store-info based on account here. (em_folder_tree_model_init): Listen for account_changed/account_removed signals. (em_folder_tree_model_finalize): Disconnect above handlers. (account_changed): Tear down the account store node and replace it with the new store (assuming it belongs in the tree after the changes). (account_removed): Remove the account store from the tree. 2004-01-30 Jeffrey Stedfast * em-folder-tree.c (emft_tree_row_expanded): Get recursive folder listing (needed or folders that have as-of-yet-unloaded-subfolders that contain unread mail will not be bolded). Fixes bug #51045. Fix for bug #53195. * em-folder-browser.c (emfb_set_folder): Restore search_state. (emfb_search_search_activated): Save search_state. 2004-01-30 Not Zed ** See bug #53549, partial fix. * em-folder-selector.c (emfs_create_name_activate): only emit the ok response if the ok button would be active (i.e. entered a valid path). ** See bug #52992. * message-list.c (message_list_hide_clear): save the hide state after its been cleared, so any popup windows inherit it. (message_list_hide_uids): same. ** See bug #53123. * em-folder-tree-model.c (drop_folder): changed to take store and dest folder as arg, to handle the case of the parent folder being "" properly. (em_folder_tree_model_drag_data_received): special case dropping a folder, and don't allow dropping to "" for any other types. 2004-01-30 Not Zed ** See bug #53558 (plus other fixes/cleanups) * em-format.c (emf_format_secure): default implementation, handle output of inner part, but dont output any sign/encrypt info. (emf_multipart_signed, emf_multipart_encrypted): replaced with implementations from em-format-html.c, which now call em_format_format_secure to output guts. (emf_class_init): hook-up virtual method format_secure. * em-format.[ch]: add a virtual method for outputing secured parts. Moved all validity stuff from em-format-html.[ch] to here. * mail-component.c (impl_createControls): set the session interactive too. * em-format-html-display.c: make smime stuff dependent on HAVE_NSS. (efhd_multipart_signed, efhd_application_xpkcs7mime): removed, now handled by root class. (efhd_output_secure): renamed to efhd_format_secure, and use EMFormat::format_secure to kick off. (efhd_class_init): setup format_secure virtual method. * em-format-html.c (efh_multipart_encrypted): We need to handle this here so we can properly keep track of the ciphervalidity stuff. Also do it directly using the context, not multipartencrypted part. (efh_multipart_signed): with unsupported signature format, format as multipart/mixed, not as an attachment. (efh_multipart_signed): make the smime stuff optional. (efh_multipart_signed, efh_multipart_encrypted): Moved to em-format.c. (efh_application_xpkcs7mime): moved to em-format.c (efh_output_secure): renamed to efh_format_secure, linked into virtual method. call parent class to do the validation foo then output the info if needed. (efh_format_message): fixed access to validity stuff to parent object. (efh_class_init): hook up format_secure virtual method. (*): removed some now-unused headers. 2004-01-29 Nicel KM * mail-component.c: removed CAMEL_PROVIDER_IS_EXTERNAL check * mail-account-gui.c: likewise * mail-offline-handler.c: likewise 2004-01-29 Not Zed * em-format-html-display.c (efhd_attachment_button): check the snooped type for the icon/etc. (efhd_format_attachment): save the snooped type in the attach_puri. * em-format-html.c (efh_text_plain): If we had a snooped type, use that as the base type, rather than octet-stream, which will cause an attachment in attachment loop. * em-format.c (em_format_part_as): save the current snooped mime type in a stack if we had any. 2004-01-29 Not Zed ** See bug #53320 and probably others * message-list.c (message_list_set_folder): NULL out message_list->folder when we clear it so it isn't left for another free when we switch again. 2004-01-29 Not Zed ** See bug #52190. * message-list.c: Added folder/folder uri to the data stored for primary/secondary selection, uses a struct to store the data now. This is needed so when you cut/copy messages, and paste them, it doesn't end up 'pasting' the messages from the current folder, but from the one where the copy/cut took place. (clear_selection): helper to free data inside selection struct. 2004-01-29 Not Zed ** See bug #53506. * mail-tools.c (mail_tools_folder_to_url): use a camelurl to do this properly, and handle fragment folder-paths. * em-composer-utils.c (em_utils_composer_send_cb): removed outbox_folder local, not necessary. 2004-01-28 Jeffrey Stedfast * em-folder-tree-model.c (em_folder_tree_model_add_store): If the store is already in the model, remove it and then re-add it. Fixes bug #53422. 2004-01-28 Jeffrey Stedfast And thus completes the fixes for bug #52766. * em-folder-tree.c (tree_drag_drop): Don't call gtk_drag_get_data() manually here or we end up getting 2 drag-data-received callbacks which is Not Good (tm). * em-folder-tree-model.c (drop_folder): Now takes a moved argument to specify whether or not the contents were moved (the move argument is just a hint). (drop_uid_list): Same. (em_folder_tree_model_drag_data_received): Updated for the above api changes. 2004-01-28 Not Zed ** See bug #53179 * mail-tools.c (mail_tool_get_local_movemail_path): Fix the movemail path. * mail-component.c (load_accounts): hack alert! * mail-send-recv.c (get_receive_type): hack alert! hardcode mbox: to be a movemail source. 2004-01-28 Not Zed * mail-send-recv.c (setup_send_data): ref folder from mail_component_get_folder. * mail-ops.c (fetch_mail_fetch): ref the folder we get from mail_component_get_folder since it doesn't ref it. 2004-01-27 Jeffrey Stedfast * em-migrate.c (cp): Removed unneeded debug printfs. * em-folder-tree.c (tree_drag_data_received): Use gtk_tree_view_get_dest_row_at_pos() instead of gtk_tree_view_get_path_at_pos() since this is what Nautilus uses. Unfortunately, it still gives us back the wrong GtkTreePath so it looks to me like Gtk+ is borked. Apparently you need the latest and greatest gtk+-2.3.x cvs snapshot for this to work. * em-migrate.c (em_migrate_imap_caches_1_4): Copy the imap cache into the right place. Duh. 2004-01-27 Not Zed ** See bug #53084 and others. * em-migrate.c (em_migrate): remove the vfolder_revert hack. * em-composer-utils.c (ask_confirm_for_only_bcc): removed unused vars. * mail-tools.c (mail_tool_get_local_inbox): removed, handled by mail_component_get_folder now. * mail-component.c (mail_component_*): Changed the api slightly. Using NULL as the component argument automatically implies you want the default component. (em_uri_from_camel, em_uri_to_camel): moved to em-utils.[ch]. Ok so it isn't namespaced right ... *shrug*. (mail_component_get_local_inbox): removed. (mail_component_get_folder): single entry point for getting standard folders. This is MT-Safe. (mail_component_get_folder_uri): single entry point for getting standard folder uri's. This is MT-Safe. (add_store): removed, moved to mail_component_add_store. (mail_component_load_store_by_uri): call mail_component_add_store directly rather than copying its code. (default_*_folder*): Removed, use accessor methods instead, fixed all callers. (setup_local_store): renamed to mc_setup_local_store, use proper url encoding too. make run-once and thread-safe. (MailComponentPrivate): Added a lock. (mail_control_new): exported properly to kill warnings. (mail_component_init): dont setup_local_store or add accounts here. (impl_createControls): setup local store/accounts here. (mail_component_peek): dont setup vfolder storage here. (mc_startup): internal function to startup stuff needed for gui operation. (setup_search_context): make run-once. (mail_component_peek_search_context): call setup_search_context incase it isn't setup yet. (impl_upgradeFromVersion): remove the local store setup hack. 2004-01-27 Not Zed * em-folder-tree-model.c (folder_renamed): fix the parent-finding logic. 2004-01-23 Not Zed * mail-component.c (mail_component_init): add the offline handler interface to the component. (store_go_online, go_online): removed, handled by the offline handler. * mail-offline-handler.c (store_go_online): add the store to the tree model when we go online. 2004-01-26 Jeffrey Stedfast Fixes for bug #53251. * mail-account-gui.c (mail_account_gui_new): Convert the account drafts/sent folder uris to camel uris. (mail_account_gui_save): Convert drafts/sent camel uris into mailer uris when setting them on the account. Also, don't compare against file: anymore since those uris don't exist anymore. * em-migrate.c (em_upgrade_accounts_1_4): Update the drafts/sent folder uris. 2004-01-26 Jeffrey Stedfast * em-folder-tree.c (tree_drag_begin): Set priv->drag_row. 2004-01-26 Aaron Weber * mail/default/C/Inbox: edited default message 2004-01-26 Jeffrey Stedfast * em-folder-tree.c (emft_copy_folders__copy): Use FOLDER_INFO_FAST bitflag here, since we don't care about unread counts when copying folders around. (emft_popup_delete_folders): Same. (emft_tree_row_expanded): Don't use FOLDER_INFO_FAST here. 2004-01-26 Radek Doulik * mail-session.c (main_get_filter_driver): translate DEMAND to INCOMING to get the right rules * mail-ops.c (mail_filter_on_demand): use FILTER_SOURCE_DEMAND Fixes #53266 2004-01-25 Rodney Dawes * em-folder-selector.c (em_folder_selector_create_new): Cast the name entry to a GtkWidget to avoid a compiler warning * em-folder-tree.c (emft_popup_new_folder): Grab focus on the name entry when we show the dialog (#53089) Fixes #53089 2004-01-23 Jeffrey Stedfast * em-folder-tree-model.c (em_folder_tree_model_get_type): Removed the drag & drop interfaces, apparently these aren't good enough for what we need. Gotta implement this all the Hard Way (tm). (em_folder_tree_model_drag_data_received): Helper function called by the drag_data_received signal callback in em-folder-tree.c (em_folder_tree_model_row_drop_possible): Same idea. (em_folder_tree_model_row_drop_target): Again. (em_folder_tree_model_row_draggable): You get the idea... (em_folder_tree_model_drag_data_get): And again. (em_folder_tree_model_drag_data_delete): Same. (em_folder_tree_model_set_drag_drop_types): Setup the drag & drop types on the widget (since the target drag & drop types are now internal to the model code rathr than the tree code). * em-folder-tree.c (em_folder_tree_enable_drag_and_drop): Rewritten. Connect to all the drag & drop signals and implemnent them. 2004-01-23 Larry Ewing * mail-component-factory.c (factory): add the control id to the factory. 2004-01-23 Jeffrey Stedfast * em-migrate.c (upgrade_xml_uris_1_4): Handle where the file: url is roken (ie, points to a location out of the evolution namespace). 2004-01-23 Rodney Dawes * em-folder-selector.c: Set the mnemonic widget for "Folder _name:" Fixes #53088 2004-01-23 Radek Doulik * em-junk-filter.c: use mail_session_get_sa_daemon_port * em-mailer-prefs.c (em_mailer_prefs_construct): added check_incoming_imap (em_mailer_prefs_apply): ditto (settings_changed): set check_incoming_imap sensitivity by check_incoming state * mail-session.c: add sa_daemon_port (mail_session_init): init sa_daemon_port and check_junk_for_imap (mail_session_check_junk_notify): watch for sa_daemon_port and check_junk_for_imap (mail_session_get_sa_daemon_port): new wrapper (mail_session_set_sa_daemon_port): ditto 2004-01-22 Jeffrey Stedfast * em-junk-filter.c (em_junk_sa_test_spamd): Oops, when calling spamassassin rather than spamc, we need to invoke /bin/sh -c since spamassassin is a shell script. (em_junk_sa_check_junk): Same. Fixes bug #53175. * em-junk-filter.c (pipe_to_sa): Don't need an argc (we don't even seem to use it??). (em_junk_sa_test_spamd_running): Don't invoke /bin/sh. (em_junk_sa_test_spamd): Simplified, also don't invoke /bin/sh. (em_junk_sa_check_junk): Cleaned up/simplified. Also don't invoke /bin/sh. (em_junk_sa_report_junk): Same. (em_junk_sa_report_notjunk): Same. (em_junk_sa_commit_reports): Same. 2004-01-22 Gary Ekker ** See bug #53051 * em-subscribe-editor.c (subscribe_set_store): fix typo in label 2004-01-22 Radek Doulik * em-junk-filter.c (em_junk_sa_test_spamd): uncomment system wide spamd test 2004-01-20 Radek Doulik * em-junk-filter.c: lock report calls by em_junk_sa_report_lock mutex 2004-01-21 Jeffrey Stedfast * em-migrate.c (em_migrate_1_4): Migrate the ETree expanded state files as well as the GalView files. * message-list.c: s/hide_save_state/save_hide_state/g and s/hide_load_state/load_hide_state/g to be more consistant with the other state saving function names. 2004-01-21 Not Zed * em-migrate.c (cp_r): use camel_mkdir(0777) rather than 0777 & st.st_mode which isn't set anyway. (cp): use simple 0666 for the mode open, and then chmod after. (cp): check the return code of close, not just fsync. (cp): dont use fd[0] and fd[1] when we really just want simple variables, rename to readfd and writefd. ** See bug #53159. * em-format.c (emf_message_rfc822): removed incorrect comment, this is not a fallback. * em-format-html.c (efh_text_plain): check the content-type of the containee object, not the holder. ** See bug #52979. * em-format-html.c: take out text/x-patch and put in text/* for a text/plain fallback handler instead. * em-format-html-display.c (efhd_find_handler): allow the bonobo handlers to override the builtin ones. 2004-01-20 Jeffrey Stedfast * em-migrate.c (em_migrate_imap_caches_1_4): New function to migrate the imap cache. (em_migrate_1_4): Migrate the IMAP cache. Fixes bug #52985. (em_migrate_1_4): Copy over the searches.xml file. Fixes bug #52980. * mail-session.c (request_password): Changed the logic of the visibility of the passwd text so that we hid ethe passwd if the flags have the SECRET bit set. 2004-01-20 Not Zed ** See Bug #52817. * mail-session.c (request_password, do_get_pass, get_password): Fix for api changes to camel_session_get_password. (request_password): if we have a STATIC password, don't show any 'remember' checkbox. 2004-01-20 Not Zed * em-folder-view.c (EMFolderView): Make displayed_uid public. * em-folder-browser.c (em_folder_browser_show_preview): use em_folder_view_set_message rather than message_list_select_uid. When clearing, clear view->displayed_uid too. 2004-01-20 Not Zed ** See bug #52965. * mail-component.c (mail_component_init): removed an epfixme, it already is an object. (impl_upgradeFromVersion): call mail_note_store after running the upgrade for local folders. * em-migrate.c (em_migrate): revert the vfolders.xml after we've imported them. * mail-vfolder.c (vfolder_revert): new api to re-load the vfolders file. ** See bug #52885. * em-folder-browser.c (emfb_create_view_menus): unref the view instance/menu's rather than asserting, if they exist. (emfb_set_folder): call create_view_menu's rather than create_view_instance, so the view menu's are properly setup. (emfb_set_folder): call superclass first. ** See bug #53028. * message-list.c (on_selection_changed_cmd): emit the cursor_activated if more than 1 item is selected also. 2004-01-20 Not Zed ** See bug #52990. * mail-component.c (mail_component_init): re-enable auto-send-recv setup. ** See bug #52989. * message-list.c (hide_load_state): clear the hidden table if setup, before loading. 2004-01-19 Radek Doulik * mail-config.c (MAIL_CONFIG_RC_DIR): path to gtkhtml's rc file (config_write_style): use MAIL_CONFIG_RC_DIR (mail_config_init): ditto * see http://bugzilla.ximian.com/show_bug.cgi?id=52969 2004-01-19 Not Zed * mail-ops.c (add_vjunk_info, add_vtrash_info): removed this like i asked radek to ages ago, just call the parent directly. (add_vtrash_or_vjunk_info): renamed to something saner. add_special_info. (add_special_info): removed the 'unread count' parameter & return the added info. ** See bug #52854. * em-folder-tree.c (emft_tree_button_press): setup a FOLDER target for the popup menu. * em-popup.c (em_popup_target_free): implement free for TARGET_FOLDER, changed the target options somewhat. (em_popup_target_new_folder): implement folder selection target. Total Hack(tm) alert. (emp_standard_menu_factory): removed the stupid g_assert_if_not_reached() call. * message-list.c (message_list_destroy): NULL out the uid_nodemap when we destroy it. 2004-01-19 Not Zed * em-folder-browser.c (emfb_folder_expunge): get the toplevel widget here too, similar to bug 52161. ** See bug #52956 * em-composer-prefs.c (sig_edit_cb): The fileentry_add_script_script widget is a GnomeFileEntry not a GtkEntry. (sig_add_script_response): use get_full_path rather than snooping the gtkentry. Also, don't close/quit the script dialogue on a bad name. 2004-01-19 Not Zed * em-migrate.c (em_upgrade_pop_uid_caches_1_4): if we can't open the pop3 cache dir, because it doesn't exist, it is not an error. ** See bug #52983. * mail-component.c (em_uri_from_camel, em_uri_to_camel): Handle vfolder: uri's properly. And make sure local uri's are properly encoded. (mail_component_get_folder_from_evomail_uri) (mail_component_evomail_uri_from_folder): removed, no longer used. (em_uri_from_camel): don't leak the camelurl. (d): disable debug * mail-vfolder.c (vfolder_load_storage): move the vfolder storage location to ~/.evolution/mail/vfolder rather than ~/.evolution/mail (this is currently unused anyway). (uri_is_ignore): short-circuit exit if we find a match. (mail_vfolder_add_uri): dont exit immediately if we have a vfolder uri, but don't add it to local/remove either. (mail_vfolder_delete_uri): remove any uri from the local/remote source list while we're at it. 2004-01-19 Not Zed * em-folder-view.c (emfv_on_url_cb): properly decode the mailto url rather than treating it as a simple string. * em-format-html.c (efh_format_address): if we have a name part, add it to the mailto part. As per rfc2368. So it isn't lost for clicking/etc. 2004-01-16 JP Rosevear * em-format-html-display.c (efhd_bonobo_object): pass in an exception to use 2004-01-16 Jeffrey Stedfast * em-format-html.c (efh_format_address): Dump a struct _camel_header_address to an html string. (efh_format_header): Use efh_format_address() and set the EM_FORMAT_HTML_HEADER_HTML bit on the flags so we don't re-convert our html string into html. * mail-vfolder.c (mail_vfolder_rename_uri): s/g_fre/g_free/ * em-utils.c (guess_account): Change 'tmp' to not be const - fixes a compile warning. (em_utils_expunge_folder): Cast parent to a GtkWindow. (em_utils_empty_trash): Same. * em-migrate.c (cp): Oops, still need to stat() the src file so we can report what percentage of the file has been completed so far and also so we don't quit copying until we've copied the whole file. * message-list.c (message_list_set_folder): Move 'message_list->folder = folder;' out of the uri compare if-block and move it into the if-block that tests that folder != NULL. (regen_list_regen): Abort if the regen folder is not the same as the ml->folder. 2004-01-16 Not Zed * mail-folder-cache.c (storeinfo_find_folder_info): change this to check the store using the provider url_cmp and just lookup the folder name directly. folder_compare can't be used for uri's, this stuff was so broken, my fault :( ** See bug #52467. * em-folder-tree-model.c (sort_cb): handle null path (root?). * mail-vfolder.c (mail_vfolder_add_uri): map uri to euri before processing. (rule_changed): map uri to camel uri before looking up. (mail_vfolder_delete_uri): handle as euri internally. (mail_vfolder_rename_uri): " * mail-autofilter.c (vfolder_rule_from_message): map camel uri to euri before setting as vfolder source. 2004-01-16 Not Zed * default/C/Inbox: * default/C/Makefile.am: * default/Makefile.am: Startup files/folders. * em-migrate.c (emm_setup_initial): initial implementation of startup setup. ** See bug #52896. * em-format-html-display.c (efhd_html_button_press_event): do this based on get_object_at rather than get_point_at, so we get the offset properly. 2004-01-15 Jeffrey Stedfast * mail-vfolder.c: Make vfolder_store 'global'. * em-folder-tree-model.c (sort_cb): Fix bug #12600 by not sorting VFolders (ie. show them in the same order they appear in the editor). Fixes bug #52888 * em-folder-tree-model.c (sort_cb): New sort function for the folder-tree. (em_folder_tree_model_init): Set the default sort func. (em_folder_tree_model_new): Set the default sort column. * em-folder-browser.c (emfb_list_built): Don't select the first unread mesg in the case where no mesg was previously selected. Fixes bug #52887 until we are able to add a user preference (for 2.2?). * em-migrate.c (cp): Only abort the copy if the dest folder both exists and contains data. Fixes bug #52880. (em_migrate): Abort if config.xmldb cannot be loaded. Fixes bug #52886. 2004-01-15 Rodrigo Moya * em-folder-browser.c: removed ForgetPasswords verb. (emfb_forget_passwords): removed. 2004-01-15 Not Zed ** See bug #52891. * em-format-html.c (em_format_html_get_type): protect against http cache not being able to be created. ** See bug #52878. * em-folder-view.c (emfv_finalise): unhook message_changed too. (emfv_set_folder): hook/unhook message_changed too. (emfv_message_changed): implement, proxy to folder_changed. 2004-01-15 Not Zed ** See bugs #51609 and #43515. * em-format-html-display.c (efhd_format_prefix): output flag for followup details above the message. (efhd_write_image): added to output icon data. * em-format-html.c (efh_format_do): call format_prefix before outputting the message in normal display mode. * em-format.c (emf_format_prefix): method called to format data before the first message output. Default impl == noop. 2004-01-14 Jeremy Katz * evolution-mail.schemas.in.in: Add a description for /apps/evolution/mail/junk/sa/local_only. 2004-01-14 Jeffrey Stedfast * em-migrate.c: Split out the remapping code into e-util/e-bconf-map.[c,h] to be shared among components. 2004-01-13 Ross Burton * em-folder-browser.c (emfb_empty_trash): Pass the parent window, fixing a crasher. Bug #52161. 2004-01-14 Not Zed ** See bug 51660. * em-format-html-quote.c (efhq_multipart_related): setup part_id appropriately. * em-format-html-display.c (efhd_output_secure): use part_id in classid, and add .signed to part_id for subpart. (efhd_bonobo_unknown): use part_id in classid. (efhd_format_attachment): use part_id in classid's. * em-format-html.c (efh_multipart_related) (emfh_multipart_related_check): setup part_id for each subpart. (efh_output_secure): as above, and use the part_id for the classid. (em_format_html_add_pobject): use part_id for a generated classid. (efh_text_plain): setup pseudo-parts into part_id. * em-format.c (emf_format_clone): setup the part_id base, folder + uid. (emf_finalise): free the part_id gstring. (emf_init): allocate the part_id gstring. (em_format_add_puri): build the cid from the part_id rather than an arbitrary number, so it is more persistent. Also save the part_id in the puri for multipart/related use. (emf_multipart_mixed, emf_multipart_alternative) (emf_multipart_appledouble, emf_multipart_encrypted) (emf_multipart_related, emf_multipart_signed): Set the part_id for each subpart. (emf_clear_puri_node): free part_id. 2004-01-13 Not Zed ** See bug 51660. * em-format-html-print.c (em_format_html_print_print): dont take message, get the message from the source formatter. * em-format.c (emf_format_clone): Added folder and uid parameters, changed camelmedium to a mimemessage. * em-format-html-display.c (efhd_attachment_button): check the icon image cache and if the image is there use it. * em-icon-stream.c (em_icon_stream_get_image): api to lookup finished images in cache. (em_icon_stream_new): add a cache key arg. (emis_sync_close): store the image in the cache once its completed. 2004-01-13 Jeffrey Stedfast * em-migrate.c (em_migrate): Handle upgrading from 1.0.x and 1.2.x (code basically moved verbatim from e_config_upgrade). * mail-component.c (impl_upgradeFromVersion): Move all the major/minor/revision logic into em_migrate(). 2004-01-12 Meilof Veeningen * em-composer-utils.c: support for posting both to mail and to (multiple) folders * em-folder-browser.c: use em_utils_post_to_folder (works with NNTP) * em-folder-selection-button.[ch]: added multiple selection mode * em-folder-selector.[ch]: idem * em-folder-tree.[ch]: added multiple selection mode, no longer show disabled accounts * em-utils.c: various changes to allow posting to (multiple) folders * em-subscribe-editor.c: double-clicking a node in the editor updates it directly * mail-ops.c: for appending messages, set the "X-Mailer" header 2004-01-12 Radek Doulik * em-junk-filter.c (em_junk_sa_check_junk): use mail_session_get_sa_use_daemon * mail-session.c: added SA prefs (mail_session_get_sa_local_only): new helper method (mail_session_set_sa_local_only): ditto (mail_session_get_sa_use_daemon): ditto (mail_session_set_sa_use_daemon): ditto (mail_session_check_junk_notify): fix the key comparison (mail_session_init): add gconf dir so that we get notified * mail-config.glade: added SA preferences * em-mailer-prefs.c (em_mailer_prefs_construct): added more junk prefs (em_mailer_prefs_apply): ditto * em-junk-filter.c: use preferences 2004-01-12 Larry Ewing * GNOME_Evolution_Mail.server.in.in: fix up the controls factory location. * mail-component.c (mail_control_new): add new interface for getting a mail control with a folder_uri property bag. (get_prop): pbag get method. (set_prop): pbag set method. 2004-01-11 Jeffrey Stedfast * em-migrate.c (cp): Don't O_TRUNC the dest file, instead use O_EXCL and don't do anything if the dest file already exists (this way we don't re-migrate an mbox or corrupt any summary/ibex/meta files). 2004-01-12 Not Zed ** See bug 52737. * em-format-html.c (efh_text_plain): treat text/* as inline content from the made-up multipart. 2004-01-09 Not Zed ** See bug 52696. * mail-component.c (setup_search_context): move the searches to ~/.evolution/mail/searches.xml (migration?). (setup_search_context): fix a merge error, vfoldertypes.xml->searchtypes.xml since it includes the system searches now. 2004-01-09 Not Zed * em-folder-tree.c (emft_popup_properties_got_folder): add total + unread counts to properties page. * em-utils.c (filter_editor_response): * mail-vfolder.c (vfolder_editor_response): change for rule editor changes, ACCEPT->OK. 2004-01-09 Not Zed * em-format.c (em_format_format_text): keep the windows charset filter around until we're done since if we set it up we reference its memory. Causes warnings and breaks message display. ** See bug #52637. * em-inline-filter.c (em_inline_filter_new): added a content-type paramter for the base content type. (em_inline_filter_finalize): free base content type. (emif_types[]): Added 'plain' parameter, indicates type needs plain parameters set on content type. (emif_add_part): inherit the full base type if it is set, for plain parts. * em-format-html.c (efh_text_plain): pass the part's content-type to the inline filter. 2004-01-08 Not Zed ** See bug #50786 * GNOME_Evolution_Mail.server.in.in: Remove :: from startup wizard iid, and put the mail wizard into the right factory. * mail-component.c (impl_requestCreateItem, impl_handleURI): * em-folder-browser.c (emfb_mail_compose): check we have an account before trying to send mail. 2004-01-07 Jeffrey Stedfast * mail-component.c (mail_component_init): Don't migrate stuff here anymore. * mail-ops.c (uid_cachename_hack): Removed a hack that checked for the really old uid cache location and make the uid cache live in a better location (why have mail/pop/ and mail/pop3/cache-? simply put the cache file in mail/pop//uid-cache). * em-migrate.c (em_migrate_dir): When copying over mbox folders, don't abort if we fail to copy over a summary file (big whoop). Also, if indexing was turned on in the evolution 1.4 version of the folder, turn on indexing for that folder in the migrated mbox folder as well. (em_migrate_pop_uid_caches): Migrate the pop3 uid-cache files. Fixes bug #52464. (em_migrate): Call em_migrate_pop_uid_caches(). * em-format-html.c (efh_format_address): Removed. (efh_format_header): Handle address formatting a little differently to address dwmw's complaints. Also now handles other headers such as Resent-* and Sender as well. 2004-01-07 Radek Doulik * em-message-browser.c (emmb_init): as below * em-folder-browser.c (emfb_init): always show vertical scrollbar, we do the same for message list and it avoids ugly flicker 2004-01-06 Jeffrey Stedfast * em-message-browser.c (emmb_set_message): Protect against a NULL message-info. Afaik, this can only happen if the message has since been removed? Might be a larger problem here... Anyways, fixes the crash in bug #52297. 2004-01-05 Jeffrey Stedfast * em-folder-tree-model.c (folder_renamed_cb): Clone the CamelRenameInfo and ref the store before emitting the async event. (folder_deleted_cb): Same idea but for CamelFolderInfo's. (folder_created_cb): Here too. (folder_subscribed_cb): Same. (folder_unsubscribed_cb): And here. (folder_renamed): Split out from folder_rename_cb(), free the CamelRenameInfo and unref the store when done. (folder_unsubscribed): Same idea. (folder_subscribed): Same. 2004-01-05 Radek Doulik * em-junk-filter.c: add NULL at the end of argv for execvp (poited out by Frank Solensky, thanks) 2004-01-05 Jeffrey Stedfast * em-folder-browser.c (emfb_list_message_selected): Check that the folder isn't NULL (ie. no folder is selected). Fixes bug #52207. * message-list.c (message_list_set_folder): Remove the cursor-activated idle callback. * mail-send-recv.c (build_dialog): Set the send/recv dialog to non-modal. Fixes bug #50127. * em-folder-tree-model.c (folder_subscribed_cb): If we aren't in the main thread, proxy it over to the main thread. (folder_unsubscribed_cb): Same. (folder_created_cb): Here too. (folder_deleted_cb): And here. (folder_renamed_cb): Again here. * em-folder-view.c (emfv_set_folder_uri): Pass mail_thread_queued to mail_get_folder() instead of mail_thread_new so that we eliminate a race when switching folders in the UI. 2004-01-05 Not Zed ** See bug #50996. * em-format-html-display.c (efhd_find_handler): implement override for unknown types, try bonobo handlers. (efhd_bonobo_unknown): formathandler for bonobo objects. * em-format.c (em_format_find_handler): make virtual, rename to emf_find_handler. 2004-01-04 ERDI Gergo * em-folder-view.c (emfv_on_url_cb): Emit a hover-url signal when the user mouses over a URL, ... (emfv_hover_url_impl): ... and use BonoboUI to change the status bar message... (em_folder_view_set_statusbar): ... unless we are asked not to, ... * mail-component.c (impl_createControls): ... like in the case of the mail component, ... (view_hover_url_cb): ... that uses the ActivityHandler to do the same Add these together, and #127536 is neatly solved. 2004-01-04 David Woodhouse * em-format-html-display.c: Mail warning grammar typo fix. 2003-12-22 David Moore * em-popup.c (emp_part_popup_set_background): Implemented; sets an image attachment as the GNOME wallpaper. * em-utils.c (emu_save_part_done): Created a prototype at the top of the file. (em_utils_save_part_to_file): Added; save a message part to a specified file on disk. 2003-12-18 Rodney Dawes * em-message-browser.c (emmb_init): Merge in evolution-mail-message-display.xml first, since it is the parent UI XML, really fixes bug #49949 2003-12-16 JP Rosevear * em-format-html-display.c: #ifdef out certain code pieces if s/mime isn't supported 2003-12-14 JP Rosevear * em-folder-tree.c (emft_tree_row_collapsed): Fix erroneous function call Fixes #52120 2003-12-12 Not Zed * mail-config.c (config_write_style): put the style in .evolution. ** See bug #52023. * message-list.c (message_list_select_uid): noop if we've been destroyed (foldre == NULL). ** See bug #52108. * em-format.c (em_format_is_attachment): also recognise application/pkcs7-mime for mailers who like to make up their own standards. * em-format-html.c (type_builtin_table[]): * em-format-html-display.c (type_builtin_table[]): make recognise application/pkcs7-mime too. 2003-12-11 Chris Toshok * Makefile.am (INCLUDES): get the build moving again. add CERT_UI_CFLAGS here for the time being. 2003-12-11 Jeffrey Stedfast Fixes bug #1717. * em-folder-browser.c (emfb_list_built): If we have a uid to select, select that instead of selecting the first unread. (emfb_set_folder): CamelObject::meta_get() actually returns a strdup'd buffer, so we need to free it. Get the last selected uid and set that up as the uid to select when the message-list finishes building. (emfb_list_message_selected): Save the selected uid. (emfb_init): Connect to the message-list's message_selected signal so that we can save selected state (don't want to do this in EMFolderView or MessageList because we don't want the state to be saved for the EMMessageBrowser). 2003-12-11 Jeffrey Stedfast * em-folder-tree.c: Shorten the namespace of some internal functions to just emft. (emft_popup_delete_rec): Don't delete the contents of a folder if it is a vFolder. Fixes bug #52029. * em-mailer-prefs.c (em_mailer_prefs_construct): Use newv() here and pass an array of GTypes - makes it simpler to change the order of columns later and/or add new columns if we need to. Also makes the line shorter :-) 2003-12-11 Grahame Bowland * em-format-html.c (efh_format_header): display x-evolution-mailer pseudo header irrespective of xmailer_mask. This is now handled by a header configuration dialog. * mail-config.glade: add tab to mail configuration dialog to allow custom headers to be specified for display. * em-mailer-prefs.h: modify struct _EMMailerPrefs to add widgets for custom header tab. Add defines for custom header flags. Add struct EMMailerCustomHeader to describe custom headers, and add function em_mailer_custom_headers_from_xml to allow XML from gconf key to be parsed into this structure. * em-folder-view.c (emfv_setting_notify): catch changes to custom header gconf key and update mail view to correspond * em-mailer-prefs.c (em_mailer_prefs_apply): save custom headers to gconf (header_list_enabled_toggled): toggle clicked toggle column (add_header): add header to custom header list if valid (remove_header): remove selected custom header (is_valid_header): return true if passed header is valid, otherwise false (entry_header_changed): call add_header_update_sensitivity (em_mailer_prefs_construct): initialise header selection tab. Load gconf data for header selection dialog. (em_mailer_custom_header_to_xml): load a header structure from XML document structure (em_mailer_custom_header_from_xml): load a header structure from a string containing valid XML. if any failure, the header.name is set to NULL. (header_list_row_selected): call remove_header_update_sensitivity (remove_header_update_sensitivity): set the sensitivity of the remove button to FALSE if the list is empty or nothing is selected. Otherwise, set it to TRUE. (add_header_update_sensitivity): set the sensitivity of the the add button to FALSE if the entry box is empty, contains a duplicate header, or contains an invalid header. Otherwise, set it to TRUE. * evolution-mail.schemas.in.in: add mail/display/headers 2003-12-10 Larry Ewing * em-format-html.c: add text/x-patch as a plain type. (efh_text_enriched): add table around the enriched part so it matches html and text modes. 2003-12-10 Jeffrey Stedfast * em-migrate.c (em_migrate_dir): Modified to simply copy mbox files from one place to another (and the summary files) rather than going thru camel so as to bypass the need for parsing MIME. 2003-12-10 Jeffrey Stedfast * em-migrate.c (get_local_store): Fixed a leak. * mail-component.c (impl_upgradeFromVersion): Implemented. * em-folder-tree.c (em_folder_tree_set_selected): Add INFO_FAST here as we don't need it to get unread counts. (tree_row_expanded): Here too. * em-folder-tree-model.c (em_folder_tree_model_set_folder_info): Check CAMEL_FOLDER_NOCHILDREN. 2003-12-10 Jeffrey Stedfast Fixes bug #51045 * mail-folder-cache.c (real_flush_updates): Update the unread count in the model if the folder got new mail. * em-folder-selection.c (em_select_folder): Updated. * em-folder-selection-button.c (em_folder_selection_button_clicked): Updated. * em-folder-tree-model.c (em_folder_tree_model_set_unread_count): New function to update the unread count for a folder. * mail-component.c (mail_component_peek_tree_model): Don't ref the model. Also renamed s/get/peek/ 2003-12-10 Not Zed * em-folder-tree.c (em_folder_tree_get_folder_info__got): check m->fi != NULL before dereferencing it. 2003-12-10 Not Zed * em-format-html-display.c (efhd_multipart_signed): * em-format-html.c (efh_multipart_signed): * em-format.c (emf_multipart_signed): treat application/pkcs7-signature as application/x-pkcs-signature. Stupud non-rfc-compliant mailers from apple. Bug #51750. * em-folder-selection.c (em_select_folder): rewritten to get rid of hte old crap that should've been gotten rid of before. Bug #51602. (em_folder_selection_run_dialog_uri): removed. (em_folder_selection_run_dialog): removed. this file is gutted and should probably be removed. * em-folder-selector.h: use a POSITIVE value for the response value, gtk uses -ative ones. Bug #51752. * Makefile.am (INCLUDES): added smime/lib and smime/gui to includes. * em-folder-tree.c (emft_popup_rename_folder): removed unused 'why', why not? * em-format-html-display.c (efhd_xpkcs7mime_validity_clicked): setup a table of buttons to view any certs we have. * em-folder-browser.c (emfb_activate): separeate view_menu unreffing from view_instance. fixes a runtime warning. ** See bug #51718. * mail-component.c (em_uri_to_camel): handle an e-uri which has an account uid which isn't in user@host format. 2003-12-09 Not Zed ** See bug #51899. * em-folder-tree-model.c (em_folder_tree_model_set_folder_info): CAMEL_FOLDER_CHILDREN is only advisory, some servers don't give it to you. 2003-12-06 JP Rosevear * Makefile.am: Remove hard coded disable deprecated flags 2003-12-05 Rodney Dawes * em-folder-tree.c (render_display_name): Remove the extra || unread check in the conditional in the g_object_set () call 2003-12-05 Rodney Dawes Fixes bug #51482 * em-folder-tree.c (render_display_name): Don't hardcode colors for the folder tree, instead use bold for unread, as in 1.4 2003-12-05 Radek Doulik * em-html-stream.c (emhs_sync_flush): use new gtk_html_flush method instead of forcing processing of all gtk events 2003-12-04 Jeffrey Stedfast * em-folder-tree-model.c (em_folder_tree_model_remove_folders): Make sure folder_path is non-NULL ("Loading..." nodes will have a NULL path). Fixes bug #51731. 2003-12-04 Jeffrey Stedfast * mail-ops.c (empty_trash_empty): Get the proper local folders store uri (it's not file:/ anymore). Fixes bug #51618. 2003-12-04 Jeffrey Stedfast Fixes bug #51605. * em-folder-selector.c (emfs_response): Handle creating a new folder (pop up a create-folder-selector dialog). * em-folder-tree.c (emft_popup_new_folder_response): Moved all the logic into em_folder_tree_create_folder(). (em_folder_tree_create_folder): New function to create a folder. 2003-12-04 Radek Doulik * em-junk-filter.c (pipe_to_sa): add new err_retval parameter, which specifies which value to return if something went wrong (like failed to exec, ...). update all calls by that. actual junk check has err_retval = 0 to avoid marking false spam - non-zero retval means junk. * em-folder-view.c: set junk toolbar buttons pixmaps * mail-session.c: monitor gconf key /apps/evolution/mail/junk/check_incoming and keep session junk flag uptodate * em-mailer-prefs.c (em_mailer_prefs_construct): added junk preferences 2003-12-03 Jeffrey Stedfast * mail-config.c (uri_to_evname): Updated to add use mail subdirs. (mail_config_uri_renamed): Updated cachenames[] (mail_config_folder_to_cachename): Fixed to use the correct path. * em-folder-browser.c (emfb_create_view_menus): Updated the galview path to point to the evo-1.5 location. (emfb_set_folder): Update the galview view_instance. (emfb_create_view_instance): Split out from emfb_create_view_menus() (emfb_create_view_menus): Reduced code, call emfb_create_view_instance(). * em-folder-selector.c (emfs_create_name_activate): Emit the OK response, not the CREATE_NEW response. Also, g_signal_emit_by_name() does not take a GQuark detail argument, so don't pass one. Fixes bug #51661. 2003-12-03 Jeffrey Stedfast * em-folder-view.c (emfv_set_folder): Sync the folder before replacing it with the new folder. * em-folder-tree.c (em_folder_tree_set_selected): Need to prepend a "/" to path if the path is the url fragment. Also fixed to select the store node if path == "/". (emft_popup_rename_folder): Set oldpath and newpath to the proper values. Fixes bug #51656. * em-folder-selector.c (em_folder_selector_get_selected_uri): Fixed a FIXME by using the CamelProvider url flags to determine if the url used url->fragment or url->path as the folder path. (em_folder_selector_get_selected_path): Don't allow path strings to start with "//". 2003-12-03 JP Rosevear * em-folder-tree.c (em_folder_tree_destroy): remove the source before saving 2003-12-03 Jeffrey Stedfast * em-folder-tree.c (em_folder_tree_save_state): Set the save_state_id to 0 or we will never get a chance to run again. 2003-12-03 Ettore Perazzoli * mail-vfolder.c: Do not #include "evolution-shell-component.h". * Makefile.am (libevolution_mail_la_SOURCES): Don't compile mail-importer.[ch] for now. * mail-component-factory.c: Do not #include . * mail-config.c: Likewise. * mail-vfolder.h: Do not #include or . * mail.h: Do not #include . * mail-ops.h: Do not #include . (mail_scan_subfolders): Remove prototype. (mail_update_subfolders): Likewise. 2003-12-03 JP Rosevear * em-folder-tree.c (em_folder_tree_destroy): save the state immediately if there is a timeout set (em_folder_tree_save_state): be true GSourceFunc and just return FALSE to remove the source 2003-12-03 Not Zed * mail-autofilter.c (rule_match_thread): changed to setup the rule part properly, it could never have worked. Bug #51601. * em-popup.c (emp_uri_popup_address_add): implement. * em-folder-view.c (emfv_popup_add_sender): implement. (emfv_add_sender_addressbook): hook up to above func. * em-utils.c (em_utils_add_address): implementation to add an email address to the addressbook. (emu_add_address_cb): callback required for funny api. Bug #51321. 2003-12-02 Jeffrey Stedfast * em-folder-tree-model.c (drop_uid_list): Moved here. (drop_folder): Moved here. (import_message_rfc822): Moved here. (drop_message_rfc822): Moved here. (drop_text_uri_list): Moved here. (model_drag_data_received): Moved the logic from em-folder-tree.c into here. (model_row_drop_possible): Same. (model_row_draggable): Same. (drag_text_uri_list): Moved here. (model_drag_data_get): Moved logic here. (model_drag_data_delete): Moved logic here. * em-folder-tree.c (drag_data_get_cb): Pass the full_name to camel_store_get_folder() rather than the path. (drag_data_received_cb): Same. (drop_uid_list): Removed. (drop_folder): Removed. (import_message_rfc822): Removed. (drop_message_rfc822): Removed. (drop_text_uri_list): Removed. (drag_data_received_cb): Removed. (row_drop_possible_cb): Removed. (row_draggable_cb): Removed. (drag_text_uri_list): Removed. (drag_data_get_cb): Removed. (drag_data_delete_cb): Removed. (em_folder_tree_enable_drag_and_drop): Don't connect to any of the drag & drop signals, they don't exist anymore. * mail-component.c (impl_createControls): Enable drag-and-drop. * em-folder-tree.c (em_folder_tree_new_with_model): Connect to the loading row signal. (loading_row_cb): Expand the path if needed. (em_folder_tree_destroy): Disconnect from the loading-row signal. (em_folder_tree_enable_drag_and_drop): New function to enable drag-and-drop. (em_folder_tree_new): Remove drag-and-drop setup code. * em-folder-tree-model.c (em_folder_tree_model_class_init): Define the loading-row signal. (em_folder_tree_model_set_folder_info): emit the loading-row signal. 2003-12-02 Jeffrey Stedfast * em-folder-tree.c (em_folder_tree_new): Fixed to pass the evolution dir into em_folder_tree_model_new(). (model_save_state): Removed. (em_folder_tree_save_state): Moved all the saving logic into em_folder_tree_model_save_expanded(). * em-folder-tree-model.c (em_folder_tree_model_new): Load the expanded state off disk. (em_folder_tree_model_save_expanded): New function to save expanded state. (em_folder_tree_model_get_expanded): new function to get if a node should be expanded. (em_folder_tree_model_set_expanded): new function to set the expanded state of a node. * mail-component.c (mail_component_init): Pass the evo dir to em_folder_tree_model_new() which now requires it. 2003-12-02 Rodney Dawes * Makefile.am: Version the schemas * evolution-mail.schemas: Removed * evolution-mail.schemas.in.in: Added 2003-12-02 Not Zed * mail-config-druid.c (mail_config_druid_new): moved the gtk_widget_show_all to before we add the pages, otherwise it can override per-page logic. Bug #50790. * message-list.c (message_list_create_extras): setup another image (followup completed) to flag status list. (states_pixmaps[]): added flag_for_followup_done. (ml_tree_value_at): return 0,1 or 2 for completed icon. also use the real ints, these shouldn't have been true/false. Bug #43514. * evolution-mail.schemas: Added empty_trash prompt key. * em-utils.c (em_utils_prompt_user): changed to take the gconf 'prompt again' key directly. Fixed callers. (em_utils_expunge_folder): prompt the user with an expunge specific message. (em_utils_empty_trash): have an empty-trash specific message for prompting confirm. (emu_confirm_expunge): removed, no longer needed. Bug #38613. (em_utils_expunge_folder): remove most line feeds, let the label wrap them. (em_utils_empty_trash): ditto. * em-subscribe-editor.c (sub_folder_subscribed): update the ui selection state after we're done. maybe we should listen on the model but this is easier. Bug #50861. * em-message-browser.c (emmb_activate): hook up our own verb list. (emmb_message_verbs[], emmb_close): implement the close verb. Bug #51558. * em-format-html-display.c (efhd_attachment_popup): duh, actually add the menu list we create. Bug #49902. * em-format.c (d): turn off debug, committed by accident. 2003-12-01 Ettore Perazzoli * mail-mt.c (do_op_status): Use data->activity_id, not local activity_id. 2003-12-01 Ettore Perazzoli * mail-mt.c (struct _mail_msg_priv): Remove member "activity". (mail_operation_status): Un-#if 0 the code. * mail-component.c (struct _MailComponentPrivate): New member activity_handler. (mail_component_init): Initialize. (impl_dispose): Unref. (mail_component_peek_activity_handler): New. (impl_createControls): Create an ETaskBar, attach it to the ActivityHandler, and return it to the caller as the statusbar control. 2003-12-01 Ettore Perazzoli * mail-component.c (impl_createControls): Pass a label for the status bar control for now. 2003-12-01 Jeffrey Stedfast * mail-config.c (mail_config_signature_run_script): Use fcntl() to set FD_CLOEXEC on each fd rather than close()ing it. Apparently Linux's older pthread implementations use sockets and so this fouls threading up. GO LINUX! GO! 2003-12-01 Rodney Dawes * GNOME_Evlution_Mail.server.in.in: * em-account-prefs.c: * em-composer-prefs.c: * em-mailer-prefs.h: * mail-component-factory.c: * mail-config-factory.c: * mail-font-prefs.h: * importers/*.server.in.in: * importers/elm-importer.c: * importers/evolution-mbox-importer.c: * importers/evolution-outlook-importer.c: * importers/netscape-importer.c: * importers/pine-importer.c: Use BASE_VERSION for repo_ids and OAFIIDs 2003-12-01 Jeffrey Stedfast * em-folder-tree.c (em_folder_tree_get_folder_info__got): Updated to call em_folder_tree_model_set_folder_info(). (folder_subscribed_cb): Removed. (folder_unsubscribed_cb): Removed. (folder_created_cb): Removed. (folder_deleted_cb): Removed. (folder_renamed_cb): Removed. * em-folder-tree-model.c (em_folder_tree_store_set_folder_info): New function to replace tree_store_set_folder_info() which had been in em-folder-tree.c (em_folder_tree_model_remove_uri): Made private. (em_folder_tree_model_remove_store_info): Made private. (em_folder_tree_model_remove_folders): New function to replace remove_folders() from em-folder-tree.c (em_folder_tree_model_new): No longer takes any args. * em-folder-tree.c (em_folder_tree_new): Updated. * mail-component.c (add_store): Add the store to the model rather than the treeview. (impl_createControls): create a new treeview based on the already-instantiated model. (mail_component_init): Create a new tree model. (mail_component_remove_store): Remove the store from the model directly. (mail_component_get_tree_model): Updated. * em-folder-tree.c (folder_unsubscribed_cb): Call em_folder_tree_model_remove_folders() rather than the deprecated internal remove_folders() function. (folder_renamed_cb): Same. (em_folder_tree_remove_store): Removed. (em_folder_tree_add_store): Removed. (remove_folders): Removed. 2003-12-01 Jeffrey Stedfast * em-composer-utils.c (composer_get_message): rfc2047 encode the Organization header value. * em-folder-tree.c (em_folder_tree_get_folder_info__got): Make sure our parent folder hasn't been unsubscribed or else we get a segfault here if it has. 03-11-28 Dave Camp * em-folder-tree.c (render_pixbuf): Set the pixbuf renderer invisible for stores. 2003-11-25 Jeffrey Stedfast * mail-config.c (mail_config_get_account_by_uid): New function. * em-folder-tree.c (tree_store_set_folder_info): Expand the tree node if the saved state tells us it was expanded the previous session. (em_folder_tree_load_state): Load the saved state. (em_folder_tree_add_store): Conditionally expand the store node. (em_folder_tree_new_with_model): Expand all the nodes that should be expanded. 2003-12-01 Radek Doulik * em-folder-tree.c (render_pixbuf): use CAMEL_VTRASH_NAME, CAMEL_VJUNK_NAME 2003-11-28 Radek Doulik * em-folder-tree.c (render_pixbuf): added junk icon to folder icons 2003-12-01 Not Zed * em-folder-browser.c (emfb_edit_cut, emfb_edit_copy) (emfb_edit_paste): override the em-folder-view impl, and handle the search bar properly. For #48746. * mail-security.glade: added some padding to the security details frames. * em-format-html-display.c (efhd_xpkcs7mime_validity_clicked): some cosmetic layout changes. 2003-11-27 Charles Zhang * mail-account-editor.c (construct): connect "changed" signal. (mail_account_editor_changed): change signal handler. Fixes bug #48998. 2003-11-30 Ettore Perazzoli * mail-offline-handler.c: Remove all the syncFolder stuff since it's not in the Component interface anymore. * mail-mt.c: Remove declaration for global_shell_client. #if 0 all the code that uses that. * mail-component-factory.c: Remove declaration for global_shell_client. * mail-vfolder.c: Remove declaration for global_shell_client. 2003-11-26 JP Rosevear * Makefile.am: turn on deprecated Gtk stuff 2003-11-24 Jeffrey Stedfast * em-folder-tree.c (em_folder_tree_save_state): New function to save tree expanded state. (em_folder_tree_queue_save_state): New function to queue saving of the expanded state. (em_folder_tree_construct): Connect to the row-collapsed signal. (tree_row_collapsed): Queue a save-state. (tree_row_expanded): Queue a save state. (em_folder_tree_get_folder_info__got): Queue a save-state. 2003-11-25 Not Zed * em-folder-view.c (em_folder_view_print): set session on print formatter for signatures to work. * em-message-browser.c (emmb_destroy): kill warning. * em-format-html.c (efh_output_secure): same as efhd_output_secure, output the security bar, but for printing/plain html. (efh_application_xpkcs7mime): use output_secure. (em_format_html_multipart_signed_sign): removed, output_secure does what this did. * em-format-html-display.c (smime_sign_table, smime_encrypt_table): Added a short description for the mail display. (efhd_xpkcs7mime_button): only good/bad signature at this point, if only encrypted, then display 'bad' icon. (efhd_output_secure): output the security bar/button and handle multi-level enveloping properly. (efhd_application_xpkcs7mime): just call output_secure to do the security bar. (efhd_multipart_signed): same. (efhd_signature_button): removed, no longer used. (efhd_signature_check): removed, no longer used. 2003-11-24 Radek Doulik * em-format-html.c (efh_text_plain): use new colors (efh_text_html): ditto * em-format-html-display.c (efhd_gtkhtml_realise): set new colors according to style * em-format-html.c (efh_init): init new colors * em-format-html.h: added frame and content colors * em-format.c (emf_multipart_mixed): do not use horizonal rule, attachment content is now inside simple frame * em-format-html.c (efh_text_plain): add 6 points around text plain content and frame it (efh_text_html): frame text/html (efh_format_do): fix body tag, set bgcolor (em_format_html_format_headers): do not put headers into own table, content body is framed now instead (efh_format_message): update for headers/body changes * em-format-html-display.c (efhd_format_attachment): put additional vertical space around attachment button 2003-11-22 Jeffrey Stedfast * em-folder-tree-model.c (model_drag_data_received) (model_row_drop_possible, model_row_draggable) (model_drag_data_get, model_drag_data_delete): Swap the retval varargs value to the last argument instead of the first. 2003-11-20 Jeffrey Stedfast * mail-config.c (mail_config_uri_deleted): Removed call to mail_tool_delete_meta_data(). Fixes bug #51236. * mail-component.c (impl_handleURI): Implemented. (mail_component_class_init): Overload the handleURI method. 2003-11-20 Jeffrey Stedfast Fixes bug #51012. * em-folder-tree.c (emft_popup_rename_folder): Fixed a FIXME to not use the OS-specific g_path_*() stuff. (em_folder_tree_set_selected): For the case where the tree has already loaded enough subfolders to include the path we need to select, exopand the nodes to that path as well. For the case that the tree hasn't loaded enough of the folder nodes, load them and then have the node selected/expanded to. 2003-11-19 Jeffrey Stedfast * em-folder-selector.c (emfs_create_name_activate): Emit the response signal with the RESPONSE_NEW value. (emfs_create_name_changed): Sanity check the entry text and set OK sensitivity. (folder_selected_cb): If there is an entry widget, then call name_changed() to decide sensitivity, else set OK to be sensitive. * em-utils.c (em_utils_selection_set_urilist): Same. * em-format-html-display.c (efhd_drag_data_get): Same as below. * em-folder-tree.c (drag_text_uri_list): Terminate each url of a text/uri-list with a \r\n. 2003-11-19 Ettore Perazzoli * GNOME_Evolution_Mail.server.in.in: Add an "evolution:uri_schemas" attribute. 2003-11-19 Not Zed * mail-component.c (em_uri_to_camel): if we're setting the fragment, strip leading /'s. * mail-tools.c (mail_tool_get_meta_data) (mail_tool_delete_meta_data, meta_data_key): old stuff killed. (mail_tool_uri_to_folder): handle email: uri's specially. this is a bit of a hack, the filter callbacks should manage this itself since filters are the only bits which use those uri's. 2003-11-18 Jeffrey Stedfast * em-migrate.c (em_migrate_dir): Don't leak the message objects. * em-folder-tree.c (em_copy_folders): Execute asynchronously by queueing the copy in another thread. (em_copy_folders__copy): Moved the original logic here. 2003-11-18 Jeffrey Stedfast * em-folder-tree.c (tree_row_expanded): Queue the camel_store_get_folder_info() call in another thread. (em_folder_tree_get_folder_info__got): Moved all the logic of tree_row_expanded here. 2003-11-17 Jeffrey Stedfast * em-folder-tree.c (tree_row_expanded): Fixed to check fi->child as well (since mbox does it right). (emft_popup_new_folder_response): Fixed to subscribe to the correct folder. (emft_popup_delete_folders): Fixed to use the full_name rather than the path. * em-folder-selection-button.c (set_contents): Fixed to not include leading '/' in the folder name in the label. * em-folder-tree.c (emft_popup_new_folder_response): Implemented error reporting via gtk dialogs. (emft_popup_copy_folder_selected): Same. 2003-11-17 Jeffrey Stedfast * em-folder-tree.c (emft_popup_new_folder_response): Use a folder_name rather than a path as the name argument to camel_store_create_folder(), fixes creation of IMAP folders. 2003-11-17 Not Zed * em-folder-selection-button.c (set_contents): handle an unparsable url without crashing. * mail-tools.c (mail_tool_get_local_inbox): thin wrapper on mail_component_get_local_inbox. * mail-component.c (mail_component_get_local_inbox): helper to get the default local inbox. * mail-ops.c (fetch_mail_fetch): if we can't get the inbox, make sure we still unref the filter driver here by using hte same exit code. Fixes a crash. 2003-11-14 Jeffrey Stedfast * em-folder-tree.c (emft_popup_new_folder_response): We can't use a uri to do a lookup of a store-info on the store_hash, we have to get a CamelStore first. (row_draggable_cb): validate the iter before using it. (row_drop_possible_cb): Same. (drag_data_received_cb): Here too. (drag_data_get_cb): Same. (drag_data_delete_cb): Again here. (tree_store_set_folder_info): Recursively add nodes if fi->child is non-NULL rather than adding a dummy node. (folder_renamed_cb): Implemented. 2003-11-14 Jeffrey Stedfast * mail-mt.c (set_stop): Removed most of the code. This is basically now a nop. Need to somehow get the uic and fix this. * folder-browser-factory.[c,h]: Removed. * mail-component.c (folder_selected_cb): Don't create a new view anymore, simply set the new folder uri on the folder browser. This makes the mailer use a lot less memory than in 1.x (view_control_activate_cb): Moved here from folder-browser-factory.c (impl_createControls): Connect to the activate signal on the view control. 2003-11-14 Jeffrey Stedfast * em-folder-selection.c (folder_selected_cb): Only set OK to sensitive if the selected node is not a store node. * em-folder-tree-model.c: Moved the store_hash and uri_hash from EMFolderTreePrivate into here instead. * em-folder-tree.c: Updated for above changes. 2003-11-14 Jeffrey Stedfast * em-folder-view.c (emfv_popup_move): Updated. (emfv_popup_copy): Updated. * em-folder-tree.c (emft_popup_copy): Updated. (emft_popup_move): Updated. * em-folder-selection.c (create_dialog): New convenience function to construct the dialog contents for all three public functions. (em_folder_selection_run_dialog): Now longer takes a caption arg. (em_folder_selection_run_dialog_uri): Same. (em_select_folder): Here too. 2003-11-13 Jeffrey Stedfast * mail-component.c (mail_component_get_tree_model): Use em_folder_tree_get_model() since an emft is not a GtkTreeView. * em-folder-tree.c (em_folder_tree_get_model): New function to get the tree model. 2003-11-13 Jeffrey Stedfast * em-folder-selection.c: Rewritten to use EMFolderTRee. * mail-vfolder.c (vfolder_load_storage): Updated for function name changes in mail-component.c * mail-offline-handler.c: Updated for function name changes in mail-component.c * mail-account-gui.c (add_new_store): Fixed to not use EStorage. (mail_account_gui_save): Updated for function name changes. * em-account-prefs.c (account_delete_clicked): Updated for function name changes. (account_able_clicked): Same. (account_able_toggled): Same. * mail-component.c: Renamed mail_component_*storage*() functions to mail_component_*store*() since we are no longer dealing with storages, but instead with CamelStore's. (create_view_widget): If the user selects a store node, don't try to open it as a folder. 2003-11-13 Ettore Perazzoli * mail-component.c (impl_sendAndReceive): New, implementation for Evolution.Component.sendAndReceive. (mail_component_class_init): Install. 2003-11-13 Jeffrey Stedfast * mail-vfolder.c (context_rule_removed): Modified to not use EStorage* functions. I don't even think it *needs* to remove the folder from the mail-component, the mail-component should just pick it up automagically via CamelStore events. * em-folder-tree.[c,h]: New folder-tree widget that replaces the shell's folder-tree widget. * em-folder-tree-model.[c,h]: New source files subclassing GtkTreeStore for handling the mess that is drag&drop. * em-folder-selection-button.c: Ported to use EMFolderTree. * em-folder-selection.c: Ported to use EMFolderTree. * em-folder-selector.c: Ported to use EMFolderTree. * mail-component.c: Ported to use EMFolderTree. * mail-offline-handler.c (storage_go_online): Updated to not pass a storage argument. * mail-folder-cache.c: Removed storage stuff. * mail-send-recv.c (receive_update_got_store): Don't do EStorage* stuff anymore. 2003-11-13 Ettore Perazzoli * mail-component.c (impl__get_userCreatableItems): New, implementation for the Component.userCreatableItems attribute. (impl_requestCreateItem): New, implementation for the Component.requestCreateItem() method. (mail_component_class_init): Install. 2003-11-13 Radek Doulik * em-junk-filter.c (em_junk_sa_is_available): new helper function, use it before any call to spamassassin, spamc and sa-learn (em_junk_sa_test_spamd): first test if spamassassin is available (em_junk_sa_test_spamd): rename em_junk_sa_spamd_tested to em_junk_sa_tested, always set em_junk_sa_tested * mail-folder-cache.c (folder_changed): don't call CAMEL_IS_VJUNK_FOLDER, it was added by mistake 2003-11-13 Not Zed * em-format-html.c (em_format_html_add_pobject): use malloc0 for the pobject memory. 2003-11-12 Not Zed * mail-account-gui.c (smime_sign_key_select) (smime_encrypt_key_select, smime_encrypt_key_selected) (smime_sign_key_selected): implement the key selector popup using e-cert-selector. 2003-11-11 Not Zed * em-format-html.c (efh_application_xpkcs7mime): output icons of the status. (em_format_html_add_pobject): Changed to take a size specificier, return the pobject, and re-ordered args to be more consistent with puri stuff. (em_format_html_remove_pobject): handle the free callback if set. * em-format.c (emf_application_xpkcs7mime): moved this to em-format-html since it needs to do icon stuff. * mail-security.glade: new glade file for security related stuff. * mail-config.glade: removed the message security dialogue, it gets opened automatically by the config code :( 2003-11-10 Ettore Perazzoli * GNOME_Evolution_Mail.server.in.in: Set an "evolution:component_alias" property with a value of "mail". 2003-11-10 Not Zed * em-format-html.c (em_format_html_multipart_signed_sign): changed for cipher context api changes. * em-format.c (emf_multipart_signed): ditto. 2003-11-07 Not Zed * mail-config.glade: added security_information_dialog (probably temporarily in this file). * em-format.c (em_format_is_attachment): also treat pkcs7-mime as non-attachment. (emf_application_xpkcs7mime): no longer need to worry about scanning the part. 2003-11-07 Dan Winship * message-list.c: Don't #include e-name-western.h, since the code that uses it is commented out, and we want to remove the local copy, but we don't want to make the mailer depend on the e-d-s copy if it's not even going to be using it. 2003-11-07 JP Rosevear * Makefile.am: build the marshall files right at the beginning 2003-11-11 Not Zed * mail-security.glade: new glade file for security related stuff. * mail-config.glade: removed the message security dialogue, it gets opened automatically by the config code :( 2003-11-10 Ettore Perazzoli * GNOME_Evolution_Mail.server.in.in: Set an "evolution:component_alias" property with a value of "mail". 2003-11-10 Not Zed * em-format-html.c (em_format_html_multipart_signed_sign): changed for cipher context api changes. * em-format.c (emf_multipart_signed): ditto. 2003-11-07 Not Zed * mail-config.glade: added security_information_dialog (probably temporarily in this file). * em-format.c (em_format_is_attachment): also treat pkcs7-mime as non-attachment. (emf_application_xpkcs7mime): no longer need to worry about scanning the part. 2003-11-07 Dan Winship * message-list.c: Don't #include e-name-western.h, since the code that uses it is commented out, and we want to remove the local copy, but we don't want to make the mailer depend on the e-d-s copy if it's not even going to be using it. 2003-11-07 JP Rosevear * Makefile.am: Make sure the marshal files are listed above other sources 2003-11-06 Jeffrey Stedfast * em-migrate.c (em_migrate_filter_file): Call em_migrate_uri() instead of em_uri_from_camel(). (em_migrate_uri): Special-case file: uri's by converting them into email://local@local/ uri's since these folders will have been migrated to the newer mbox tree structure. 2003-11-06 Jeffrey Stedfast * mail-vfolder.c (mail_vfolder_delete_uri): User vfolder rules should be in ${evolution_dir}/mail/vfolders.xml rather than ${evolution_dir}/vfolders.xml (mail_vfolder_rename_uri): Same. (store_folder_deleted): Here too. (store_folder_renamed): And here. (vfolder_load_storage): Again here. (vfolder_editor_response): Same. (edit_rule_response): And here. (new_rule_clicked): Here too. * mail-session.c (main_get_filter_driver): User filter rules should be in ${evolution_dir}/mail/filters.xml rather than ${evolution_dir}/filters.xml * mail-autofilter.c (filter_gui_add_from_message): Same. (mail_filter_rename_uri): And here. (mail_filter_delete_uri): Here too. * em-utils.c (filter_editor_response): Again here. (em_utils_edit_filters): Same. * em-migrate.c (em_migrate_filter_file): Same (also for vfolders.xml) 2003-11-05 Jeffrey Stedfast * em-migrate.[c,h]: New source files to migrate from the old mail directory to the new mail directory. * mail-component.c (mail_component_init): Changed to use ~/.evolution and added code to migrate the old mail folders over if ~/.evolution/mail does not yet exist. 2003-11-03 Ettore Perazzoli * GNOME_Evolution_Mail.server.in.in: Use "evolution2:config_item" properties for the config item instead of "evolution:config_item" ones. 2003-11-01 Jeffrey Stedfast * em-folder-view.c: setup filter-on-thread and vfolder-on-thread. * mail-autofilter.c (rule_from_message): handle AUTO_THREAD (rule_match_thread): new function to setup a filter on a msgid 2003-10-31 Not Zed * mail-config.glade: Rearranged smime config slightly, and added encrypt key preference. * mail-account-gui.c (mail_account_gui_save, mail_account_gui_new): enable smime always if have_nss. Added new options in glade file and handle changed names. (smime_changed, smime_sign_key_select, smime_sign_key_clear) (smime_encrypt_key_select, smime_encrypt_key_clear): Add a bunch of mostly dummy UI behaviour management stuff. 2003-10-30 Not Zed * em-format.c (em_format_is_inline): show application/x-pkcs7-mime inline always by default. 2003-10-30 Not Zed * em-format.c (emf_multipart_signed): handle application/x-pkcs7-signature. 2003-10-29 Not Zed * em-format-html.c (em_format_html_multipart_signed_sign): handle application/x-pkcs7-signature. * em-format.c (emf_application_xpkcs7mime): Handle application/x-pkcs7-mime. 2003-10-29 Jeffrey Stedfast * em-account-prefs.h: Changed the OAFIID. * em-composer-prefs.h: Changed the OAFIID. * em-mailer-prefs.h: Changed the OAFIID. * GNOME_Evolution_Mail.server.in.in: Changed OAFIIDs for the prefs controls. 2003-10-29 Jeffrey Stedfast * GNOME_Evolution_Mail.server.in.in: Nuked the MailConfig interface stuff. * Mailer.idl: Removed. None of the interfaces are needed/used anymore. * folder-info.[c,h]: Removed. The summary was the only thing that needed/used this code and it has been nuked into oblivion, so these interfaces are no longer needed. * mail-config.c: Removed old crufty CORBA interface snot that is no longer needed or used. 2003-10-27 Jeffrey Stedfast * Fixes bug #49816 * em-popup.c (emp_part_popup_reply_sender): No need to pass a parent window arg anymore. (emp_part_popup_reply_list): Same. (emp_part_popup_reply_all): Here too. (emp_part_popup_forward): Same. (emp_uri_popup_address_send): Here too. * em-folder-browser.c (emfb_mail_compose): No need to pass a parent window arg anymore. (emfb_mail_post): Same. * em-folder-view.c (emfv_message_reply): Don't pass a parent window argument anymore. (emfv_popup_forward): Same. (emfv_popup_resend): Same here. (em_folder_view_open_selected): Same. (emfv_message_forward_attached): Here too. (emfv_message_forward_inline): And here. (emfv_message_forward_quoted): Same. (emfv_message_redirect): Here too. (emfv_message_post_reply): And here. (emfv_format_link_clicked): ANd finally here. * em-utils.c (create_new_composer): Don't set_transient_for() anymore. (em_utils_compose_new_message): No longer takes a parent window argument. (em_utils_forward_attached): No longer takes a parent window arg. (em_utils_forward_inline): Same. (em_utils_forward_quoted): Same. (em_utils_forward_message): Same. (em_utils_forward_messages): Here too. (redirect_get_composer): Don't set_transient_for() here either. (em_utils_redirect_message): No longer takes a parent window arg. (em_utils_redirect_message_by_uid): Same. (reply_get_composer): Don't set_transient_for() here. (em_utils_reply_to_message): No longer takes a parent window arg. (em_utils_reply_to_message_by_uid): Same. (post_reply_to_message): Don't set_transient_for() here. (em_utils_post_reply_to_message_by_uid): No longer takes a parent window arg. (em_utils_compose_new_message_with_mailto): Don't set_transient_for() here. (em_utils_post_to_url): Same. (em_utils_edit_message): No longer takes a parent window arg. (em_utils_edit_messages): Same. 2003-10-24 Jeffrey Stedfast * em-account-prefs.[c,h]: Re-Namespaced mail-accounts.c * em-composer-prefs.[c,h]: Re-Namespaced mail-composer-prefs.c * em-mailer-prefs.[c,h]: Re-Namespaced mail-preferences.c * mail-accounts.[c,h]: Removed. * mail-composer-prefs.[c,h]: Removed. * mail-preferences.[c,h]: Removed. * mail-account-editor.c: Updated. * mail-account-gui.c: Updated. * mail-config-factory.c: Updated. * mail-component-factory.c: Updated. 2003-10-22 Ettore Perazzoli * GNOME_Evolution_Mail.server.in.in: Add an "evolution:button_icon" attribute. 2003-10-22 Ettore Perazzoli * GNOME_Evolution_Mail.server.in.in: Add an "evolution:button_sort_order" attribute. 2003-10-22 Jeffrey Stedfast * mail-component.c (parse_uid_list): Removed, use em_utils_selection_get_uidlist() instead. (drop_uid_list): Use em_utils_selection_get_uidlist() to parse the x-uid-list selection data and use mail_tool_uri_to_folder() directly since we have the uri (originally we expected the first component of the selection data to be the e-storage-set-view folder path rather than the uri). (folder_receive_drop_cb): Call gtk_drag_finish() here. * message-list.c: s/x-evolution-message/x-uid-list/ * em-utils.c: Same. 2003-10-22 Ettore Perazzoli * mail-component.c (impl_createControls): Use e_storage_browser_peek_widget_scrolled() to retrieve the scrolled window that the EStorageSetView is contained in. 2003-10-22 Ettore Perazzoli * GNOME_Evolution_Mail.server.in.in: Add an "evolution:button_label" attribute to the Component for use in the shell. 2003-10-22 Not Zed * mail-component.c (em_copy_folders): handle destination of "" properly. (emc_popup_copy_folder_selected): handle url->path properly, strip leading /. (em_copy_folders): if we just created a new folder on a subscribable store, subscribe to it. (em_copy_folders): handle nonselectable folders specially. 2003-10-21 Jeffrey Stedfast * mail-component.c (drag_text_uri_list, folder_dragged_cb) (drop_uid_list, drop_folder, import_message_rfc822) (drop_message_rfc822, drop_text_uri_list, folder_receive_drop_cb): New functions to handle drag & drop to/from the folder tree. (impl_createControls): Setup drag & drop support. * em-format.c (emf_multipart_mixed): Put an
between parts of a multipart. 2003-10-21 Not Zed * mail-component.c (emc_popup_properties): implement. (emc_popup_properties_got_folder): builds dynamic folder-properties dialogue. (emc_popup_properties_response): set the properties on the folder on an ok response. (emc_popup_properties_free): free the properties working data. * mail-folder-cache.c (unset_folder_info): unhook from the right function for message_changed. 2003-10-20 Not Zed * mail-component.c (emc_popup_new_folder): pass the right object to set_selected(). Fixes a new real bug. Undid reformatting. 2003-10-17 Jeffrey Stedfast * mail-component.c: General compile fixes. (emc_popup_new_folder): Fixed to not shadow a parameter. Fixes a real bug. * mail-component.h: Added some prototypes. 2003-10-13 Not Zed * em-popup.c (em_popup_create_menu_once): only hookup target free if we have a target set. * mail-component.c (load_accounts): removed debug i accidentally left in. (emc_tree_right_click): handle right-click context menu, using an EMPopup table. (emc_popup_*): setup empty popup handlers. 2003-10-13 Not Zed * em-folder-selection.c (em_select_folder): asynchornous folder selection call. (emfs_folder_selected): callback for folder selected. * em-folder-view.c (emfv_popup_move): implement. (emfv_popup_copy): " (emfv_popup_move_cb): async folder select callback to run it. 2003-10-10 Not Zed * mail-account-gui.c (mail_account_gui_folder_selector_button_new): use em_folder_selection_button. (mail_account_gui_new): " (folder_selected): " * em-folder-selection-button.c: Make this use camel uri's rather than camelfolders. (set_selection): removed, redundant. (impl_dispose): removed, not needed. * em-folder-selection-button.h: change the selected signal not to actually return the selection, which must get retrieved later. * mail-component.c (em_uri_from_camel): create an evo mail uri from a camel one. (em_uri_to_camel): the reverse. * mail-signature-editor.c (mail_signature_editor): up the version of the gtkhtml editor. 2003-10-09 Not Zed * em-folder-selection-button.c (set_selection): always set selected_folder, otherwise we don't unset it properly. * em-folder-selection.c (em_folder_selection_run_dialog): fix a small memleak. (em_folder_selection_run_dialog_uri): do the same as run_dialog but take, and return physical uri's. * mail-component-factory.c (factory): removed some fixme's, and re-hookedup the composer. 2003-10-09 Frederic Crozat * em-icon-stream.c (emis_sync_close): Use gnome-thumbnail_scale_down_pixbuf if available, for better performance. 2003-10-08 Jeffrey Stedfast * em-folder-view.c: Add a hide_mask to the create-rule-from-message bars so that we don't segfault when we right click with a multi-selection. 2003-10-08 Chris Toshok * em-utils.c (em_utils_camel_address_to_destination): EDestination => EABDestination, and e_destination => eab_destination. (reply_get_composer): same. (post_reply_to_message): same. * em-composer-utils.c (ask_confirm_for_unwanted_html_mail) EDestination => EABDestination, and e_destination => eab_destination. (composer_get_message):same. 2003-10-08 Not Zed * mail-component.c (mail_component_peek): setup vfolders once we hve the component, since its setup will call mail_component_peek, fun recursion. 2003-10-08 Not Zed * mail-component.c (setup_local_folder): removed. (setup_local_store): setup various needed globals properly. (setup_account_storages): renamed to load_accounts. (go_online): turn on interactivity as well as onlinedness. * GNOME_Evolution_Mail.server.in.in: point the preferences pages to the right factory. 2003-10-07 Not Zed * mail-component.[ch]: Fix copyrights. 2003-10-06 Jeffrey Stedfast * mail-config-druid.c (identity_prepare): Fixed. * mail-ops.c (fetch_mail_fetch): Always save the uid cache no matter what. 2003-10-03 Frederic Crozat * mail-config-druid.c (identity_prepare), (config_wizard_new): Convert real name to UTF-8 if needed. 2003-10-03 Jeffrey Stedfast * em-folder-browser.c (emfb_set_folder): Disable the selection of the first unread message for now. This is actually annoying the fuck out of me, Radek, and a few other people. 2003-10-02 Not Zed * mail-component.c (add_storage): Add the storage to the hash after we've initialised it. (mail_component_evomail_uri_from_folder): hardcode "local" account pseudo-id for local folders. (mail_component_get_folder_from_evomail_uri): handle the "local" account case. 2003-10-02 Not Zed * mail-component.c (setup_local_store): use mbox:/path rather than mbox:///path - the mbox code is 'wrong', but this is easier to fix. fixes local unread counts. maybe the provider url-compare should address this too. 2003-10-02 Suresh Chandrasekharan * mail-config-druid.c: Fix for 40917 "Backspace shouldn't highlight the whole remaining string in Setup Assistant". (identity_changed): Removed repeated focussing per keystroke. functions (source_changed): Same. (transport_changed): Here too. (management_changed): And here. (identity_prepare): Removed the initial highlighting for Full Name, also the unneeded intial grab_focus. 2003-10-02 Not Zed * em-format-html.c (efh_format_timeout): zero out last_part if we're clearing. Uh, this fixes, but shouldn't, part of #49034. The problem is the 'last part' logic is based on the address, which can quite easily be repeated for different messages. * em-folder-view.c (emfv_list_message_selected): reverted jeff's patch for #48618, use a much simpler method. * em-message-browser.c (emmb_destroy): hook onto destroy handler, we need to destroy the messagelist ourselves, since we dont attach it to any parent window. 2003-10-01 Not Zed * em-format-html.c (efh_init): turn off blocking writes. (efh_format_timeout): don't do a htmlbegin on the page yet, it'll be handled by em-html-stream when it has data, to reduce flicker. (efh_format_do): close the main gtkhtml stream as soon as we're done writing the body. any sub-jobs should be using frames etc. (efh_text_plain): dont write a table around the text, try to reduce flickering. layout may be out now though. * em-html-stream.c (emhs_sync_write): if we have no html_stream yet, begin a new one. 2003-09-30 Rodney Dawes * em-format-html-print.c: Use "Sans Regular" instead of "Helvetica" Fixes bug #47878 2003-09-30 Not Zed * em-format-html.c (efh_init): remove gconf stuff. (em_format_html_set_xmailer_mask): new method to set the xmailer mask. * em-folder-view.c (emfv_display_keys[]): Added charset key to monitor/retrieve, and xmailer_mask. (emfv_setting_notify): Monitor charset setting, pass onto the formatter, as well as xmailer_mask. * mail-preferences.c (mail_preferences_construct): use the new charset key. (mail_preferences_apply): use the new charset key. * evolution-mail.schemas: Moved the mail/format/charset to mail/display/charset. 1. it makes more sense, and 2. it makes notification update easier in em-folder-view.c * em-format.c (emf_init): remove the gconf charset stuff, for bug #48791, and also actually fixes the fixme that jeff thought he fixed. (em_format_format_text): use default charset as fallback. (em_format_set_default_charset): New method to set the default charset. (gconf_charset_changed): removed. 2003-09-29 Jeffrey Stedfast * em-format.c (emf_init): Oops, put the arguments in the right order. 2003-09-29 Ettore Perazzoli * mail-component.c: New member local_store in MailComponentPrivate. (impl_dispose): Unref. (mail_component_load_storage_by_uri): Return the CamelStore. (setup_local_folder): New. (setup_local_store): New. (mail_component_init): Call it. (mail_component_peek_storage_set): New. (mail_component_get_folder_from_evomail_uri): New. (mail_component_evomail_uri_from_folder): New. * em-folder-selection-button.c: New. * em-folder-selection-button.h: New. * em-folder-selection.c: New. * em-folder-selection.h: New. * em-marshal.list: Add NONE:POINTER. 2003-09-25 Jeffrey Stedfast * mail-account-gui.c (mail_account_gui_save): Allow any file: uri to point to a sent or drafts folder. 2003-09-25 Rodney Dawes * mail-send-recv.c: Make the dialog more HIG-compliant by fixing widget alignment/spacing issues, and removing separators 2003-09-24 Jeffrey Stedfast * mail-preferences.c (mail_preferences_construct): Same as below. * mail-composer-prefs.c (mail_composer_prefs_construct): gconf can return empty string if the charset has not been set, so if the charset string is empty, default the charset to the user's locale charset. Partial fix for bug #47638. 2003-09-23 Ettore Perazzoli * mail-component.c (add_storage): Remove unused arg "uri". (mail_component_add_store): Likewise. (add_storage): Don't set the "Connecting..." node. (mail_component_init): Set up local store at ~/.evolution/mail/local. * evolution-mbox-upgrade.c (get_local_store): Remove a double xmlFree() that was causing it to crash. 2003-09-23 Ettore Perazzoli * mail-component.c (add_storage): Note the new store. * mail-component-factory.c: Don't include "mail-callbacks.h" anymore. * em-format-html.c (em_format_html_get_type): Get the base directory with mail_component_peek_base_directory(). * em-utils.c (filter_editor_response): Likewise. (em_utils_edit_filters): Likewise. * em-folder-browser.c (emfb_init): Get the search context through mail_component_peek_search_context(). 2003-09-23 Jeffrey Stedfast * evolution-mbox-upgrade.c (get_local_store): Don't xmlFree (name) until after we've g_strdup'd it. (em_migrate_dir): If the metadata file doesn't exist, don't even bother trying subfolers (the shell just ignores them so we should too). 2003-09-23 Jeffrey Stedfast Fix for bug #48791 (and also fixes a FIXME) * em-format.c (emf_init): Setup a gconf listener for changes to the charset setting. (gconf_charset_changed): Update the cached gconf charset value. (emf_finalise): Free the EMFormatPrivate data, unref the gconf client, disconnect the charset notify id, and free the cached gconf charset value. (em_format_format_text): Use the cached gconf charset value. 2003-09-22 Not Zed ** See bug #32996 * mail-folder-cache.c (real_flush_updates): don't just pass TRUE to the 'can work offline' parameter of new shell folder. ** See bug #39410 * mail-ops.c (prep_offline_do): sync all messages, not just unread or flagged ones. 2003-09-22 Not Zed * em-popup.c (emp_uri_popup_link_copy): removed, moved to em-folder-view, for now, it has access to an invisible. * em-folder-view.c (emfv_setting_notify): honour the load_http setting, at least the all setting. (emfv_format_popup_event): setup the popup menu item for copy link location here. 2003-09-22 Jeffrey Stedfast * mail-preferences.c (mail_preferences_construct): Connect to "value-changed" rather than "changed" for spin buttons. 2003-09-21 Not Zed * mail-session.c (ms_thread_msg_new): implement, we hook into the mail progress reporting stuff by overriding the CamelOperation member with one from a dummy mail_msg. (ms_thread_msg_free): handle freeing. * mail-mt.c (mail_msg_free): mute the camel-operaiton when we free it so we no longer get updates. 2003-09-19 Jeffrey Stedfast * em-message-browser.c (emmb_set_message): Set the window title to be that of the message subject. Fixes bug #48617. 2003-09-19 Jeffrey Stedfast Fix for bug #48618. * em-folder-view.c (emfv_list_message_selected): See if we have already loaded the message uid that has just been selected, if so - don't bother re-loading it. (emfv_list_done_message_selected): Update loaded_uid and loading_uid. 2003-09-18 Radek Doulik * em-format-html.c (efh_init): use gtkhtml's blocking 2003-09-18 Jeffrey Stedfast * em-inline-filter.c: updated for CamelTransferEncoding namespace changes * em-inline-filter.h: updated for CamelTransferEncoding namespace changes * mail-ops.c: updated for CamelTransferEncoding namespace changes 2003-09-18 Jeffrey Stedfast * component-factory.c: updated for camel namespace changes * em-folder-view.c: updated for camel namespace changes * em-format-html-display.c: updated for camel namespace changes * em-format-html-quote.c: updated for camel namespace changes * em-format.c: updated for camel namespace changes * em-popup.c: updated for camel namespace changes * em-utils.c: updated for camel namespace changes * mail-autofilter.c: updated for camel namespace changes * mail-ops.c: updated for camel namespace changes * mail-session.c: updated for camel namespace changes * message-list.c: updated for camel namespace changes * message-tag-followup.c: updated for camel namespace changes * importers/evolution-mbox-importer.c: updated for camel namespace changes 2003-09-18 Jeffrey Stedfast * em-popup.c (emp_standard_menu_factory): Don't forget to initialise/increment 'i' when using it as an object id in the for-loop. * em-format.c (em_format_format_text): Initialise charset to NULL or it may be used uninitialised. Also include gnome-vfs-mime-handlers.h for gnome_vfs_mime_type_get_description(). * Makefile.am: Added $(MARSHALL_GENERATED) to $(BUILT_SOURCES) so that em-marshal.[c,h] were autogenerated. 2003-09-17 Not Zed * folder-browser.c, folder-browser.h, folder-browser-ui.c folder-browser-ui.h, mail-callbacks.c, mail-callbacks.h mail-display.c, mail-display.h, mail-display-stream.c mail-display-stream.h, mail-format.c, mail-format.h mail-identify.c, mail-search.c, mail-search.h message-browser.c, message-browser.h, subscribe-dialog.c subscribe-dialog.h, mail-font-prefs.c, mail-font-prefs.h: cvs removed. * Makefile.am: Removed mail-font-prefs.[ch], hasn't been built for ages. * em-*.c: killed a bunch of printfs. * em-format-html-display.c (efhd_html_button_press_event): update for html object api chagnes. ** Merge in mail-refactor-2 branch. 2003-09-17 Jeffrey Stedfast * evolution-mbox-upgrade.c: New source file to migrate from the old mbox structure to the new mbox structure. 2003-09-08 Ettore Perazzoli * mail-folder-cache.c (mail_note_store): Allow NULL storage in precondition. * mail-component.c (mail_component_init): Remove debugging message. 2003-08-22 Not Zed * mail-format.c (write_date): translate the local time format. 2003-08-20 David Woodhouse * mail-format.c (write_date): Use e_utf8_strftime() to generate localised time; avoid gratuitous extra translation and array of day names, and the autoconf magic which made Not Zed dislike the inclusion of the timezone name. 2003-08-18 Ettore Perazzoli * GNOME_Evolution_Mail.server.in.in: Rename GNOME_Evolution_Mail_Component2 to GNOME_Evolution_Mail_Component_2 and GNOME_Evolution_Mail_Factory2 to GNOME_Evolution_Mail_Factory_2. * mail-component-factory.c: Update accordingly. 2003-08-18 Jeffrey Stedfast * mail-session.c (main_get_filter_driver): Removed the new-mail-notification mess. * mail-folder-cache.c (notify_idle_cb): New idle callback to alert the user about new mail. (notify_type_changed): New function to intercept user changes to his/her notification settings changes. (real_flush_updates): Initialise new mail notification if not yet initialised and setup an idle callback if none is already set. (update_1folder): Now takes an additional argument `new' which states whether or not the fodler got any new mail so that we may handle notify the user (if needed). (folder_changed): Pass in the number of new messages received. 2003-08-19 Not Zed * mail-callbacks.c (mail_generate_reply): Added a comment for translators. 2003-08-19 David Woodhouse * mail-callbacks.c (mail_generate_reply): Add a timezone offset to the attribution string. 2003-08-19 Not Zed * mail-format.c (write_date): Added translation for day and localtime strings. Also removed the tz_zone stuff, and just use 'localtime' always. 2003-08-15 David Woodhouse * mail-format.c (write_date): Show date in localtime too. 2003-08-19 Harry Lu ** For #45348 * mail-display.c (mail_display_render): Change "%P" to "%p" so that strftime() can work under solaris. 2003-08-14 Jeffrey Stedfast * mail-ops.c (mail_send_message): Don't abort at the first failure after sending (filtering, appending to Sent, syncing). Instead, keep a running tab of exceptions and then set a culmulative exception at the end to report to our caller. Also, if we fail to append to the account Sent folder, try again with the local Sent folder. Fixes bug #46512. 2003-08-13 Suresh Chandrasekharan * e-searching-tokenizer.c (searcher_next_token): Fix for 45818 ( i18n mail messages search only produces '[?]'). Now multibyte character selection works correctly. But due to associated gtkhtml bug, the find button functionallity for multibyte characters is broken. 2003-08-12 Jeffrey Stedfast * mail-tools.h: Removed unused function prototype. 2003-08-11 Jeffrey Stedfast * mail-session.c (remove_timeout): Removed. (register_timeout): Removed. 2003-08-09 Ettore Perazzoli * mail-component.c (storage_go_online): Pass NULL for the operation pointer to mail_note_store(), to sync with Michael's changes. 2003-08-05 Jeffrey Stedfast * mail-format.c (handle_multipart_encrypted): Updated for CamelMimePart::content_type changes. * mail-ops.c (save_part_save): Use camel_data_wrapper_decode_to_stream() here. * mail-display.c (drag_data_get_cb): Updated for CamelMimePart::content_type changes. (do_attachment_header): Same. 2003-07-31 Jeffrey Stedfast * mail-format.c (mail_format_raw_message): Updated to pass FALSE as the 'decode' param to mail_format_data_wrapper_write_to_stream(). (mail_format_data_wrapper_write_to_stream): Now takes a boolean arg telling whether to decode or not. Also reworked the charset logic now that camel doesn't handle this for us any longer. (mail_format_get_data_wrapper_text): Updated. (handle_text_plain): Same. (handle_text_enriched): Here too. * mail-display.c (do_attachment_header): Call decode_to_stream here instead of write_to_stream. (do_external_viewer): Same. (on_url_requested): Same. Also updated for mail_format_data_wrapper_write_to_stream(). (try_part_urls): Call decode_to_stream. (drag_data_get_cb): Same. 2003-08-05 Not Zed ** See bug #32732 * message-list.c (mail_regen_list): use thread_new. * mail-local.c (reconfigure_response): use thread_new. * mail-display.c (stream_write_or_redisplay_when_loaded): use thread_new. * mail-config.c (mail_config_check_service): use thread_new rather than queue. * mail-callbacks.c (view_msg): change to use mail_get_messages(), fixes FIXME. (do_view_messages): handle get_messages callback. (do_view_message): removed. * mail-ops.c (mail_get_folderinfo): Use a new thread thread semantic. (mail_save_part): " (mail_store_set_offline): " (mail_sync_folder): use queued_slow thread queue. (mail_expunge_folder): " (mail_empty_trash): " ** See bug #47224. Hook onto clicked rather than button_pressed, so that dnd works. * mail-display.c (inline_toggle): toggle a part inline. (button_press): change back to only handle button clicked events, renamed to inline_button_clicked. (do_attachment_header): hook onto clicked rather than button_press_event, and move key_press_event to inline_button_pressed. (do_signature): Same. (inline_button_pressed): handle inline button key press event explicitly. 2003-07-29 Not Zed * mail-folder-cache.c (mail_note_store): add a CamelOperation for overriding status handler. * mail-send-recv.c (receive_update_got_store): Pass our own cancel handle to get_folderinfo and mail_note_store. (mail_send_receive, mail_receive_uri): Same for get_store. * mail-ops.c (mail_get_store, mail_get_folderinfo): Add a CamelOperation argument, for overriding the status handler. Fixed most calles to pass NULL to use the default. 2003-09-15 Not Zed * em-folder-browser.c (emfb_activate): remove warning about folder not being loaded yet - it basically never is. * em-popup.c (emp_standard_menu_factory): dont setup any global select menu's yet. they're all handled by folderview atm. 2003-09-11 Not Zed * em-format-html.c (efh_finalise, efh_format_timeout): Use a proper hash free func, otherwise it dont work. 2003-09-11 Not Zed * em-inline-filter.[ch]: A new class which implements an inline snooper via a mime filter, so it is fully streamable. contents merely passes through the filter. * em-format-html.c (efh_finalise): free text substitute parts table. (efh_text_plain): transform a text part into a multipart, scanning for inline data. Keep the multipart around for redraws. (efh_format_timeout): clear the text substitute parts table. 2003-09-10 Not Zed * em-format-html-display.c (efhd_init): hook onto realise so we get the real theme-applied style. (efhd_gtkhtml_realise): get the theme data for colour defaults. Tweak the colour selection to make it work better with dark themes. * em-format-quote.c (emfq_format_source): we need to implement this. (emfq_format_error): we need not to call parent, it doesn't implement it. * message-list.c (message_list_select_uid): don't emit changedhere, let it go through the table cursor change. * em-folder-browser.c (em_folder_browser_show_preview): use folderview.preview_active for this state. (em_folder_browser_show_preview): clear the current message when we turn off the message view, and load the current one when turn it on. * em-folder-view.c (emfv_destroy): zero out preview + list. (emfv_list_message_selected): check preview_active before doing anything. (emfv_edit_cut): (emfv_edit_copy): only run if preview active. * em-format-html.c (efh_format_do): output the proper html headers, etc. 2003-09-10 Jeffrey Stedfast * mail-account-gui.c (mail_account_gui_save): Allow the user to select any fodler for his/her Drafts and Sent folders. Fixes bug #45412. 2003-09-09 Not Zed * em-utils.c (forward_non_attached): implement forward quoted. * em-format-quote.[ch]: New class, em-format-html-quote wont cut it. Sigh. * em-format-html-quote.c (efhq_base_init): move type init stuff here. (efhq_complete): remove, this is a signal. (efhq_multipart_related): we need to override the base class, we don't want to output any attachment html. * em-format-html-print.c (efhp_base_init): move builtin type init to here. * em-format-html.c (efh_init): get xmailer mask from gconf (sigh). (efh_format_header): inmplement most of xmailer mask thing. rupert icon not done yet, probably needs to be done as part of em-format-html-display, sigh. (type_builtin_table[]): add image/svg to supported image formats. (efhd_base_init): move type init to here. (efh_text_enriched): write to the filtered_stream, not stream. * em-format.c (em_format_format_text): oops, actually use any supplied charset. (emf_base_init): move hashtable init into base_init, so we get a new copy for each derived class too. * mail-send-recv.c (build_dialogue): use an eclippedlabel for status. Fixed all uses. 2003-09-08 Not Zed * em-format-html.h (EMFormatHTML): added a simple_headers option, only output headers in basic format. Added hide_headers option, to disable all header output. * em-format-html-quote.c (efhq_format_message): blockquote the contnet, thats how you cite it! (efhq_init): turn on simple headers for html output. (efhq_format_message): output headers and part directly, bypassing parent format_message. (efhq_format_message): implement hide_headers. * em-format-html.c (efh_busy): implement busy. (efh_format_message): implement simple_headers option. (efh_format_text_header): implement simple_headers option. (efh_format_message): move the header formatting stuff into exported em_format_html_format_headers. (efh_format_message): only output headers if not hidden. * em-format.c (emf_busy): base implementation of a new virtual method, returns TRUE if the object is still busy rendering/downloading stuff. * em-utils.c (em_utils_message_to_html): renamed from em_utils_quote_message. Also make sure the html conversion is complete before getting the data. (em_utils_part_to_html): similar, but for parts. (composer_set_body): put in David Woodhouse's timezone in attribution patch. (composer_set_body): we want to quote the part (content), we don't want message headers. (em_utils_message_to_html): add a 'show headers' argument. * folder-browser-factory.c (control_activate): removed. (control_deactivate): removed. * mail-identify.c: * folder-browser.[ch], folder-browser-ui.[ch]: * mail-callbacks.[ch], mail-search.[ch]: * mail-display.[ch], mail-format.[ch], mail-display-stream.[ch]: * message-browser.[ch]: Removed, fixed all users. * component-factory.c (factory): change callbacks to em_utils ones. (configure_folder_popup): comment out some of the reconfigure stuff. Wont have it in 1.6? (handle_external_uri_cb): use em_utils stuff. (user_create_new_item_cb): " (owner_unset_cb): " * em-composer-utils.c (composer_send_cb): rename to em_utils_composer_send_cb, and export, sigh, needed for factory. (composer_save_draft_cb): Same. 2003-09-05 Not Zed * em-format.c (type_builtin_table[]): Add a fallback multipart/* for other types (e.g. multipart/report) (em_format_fallback_handler): fix some bad logic. * em-folder-browser.c: track the pane size if the user changes it. (emfb_set_folder): Added a bit of a mess that will select the first unread message the first time you visit a folder. (emfb_destroy): impelment. clear up outstanding signal handlers. (emfb_list_built): Select the first unread message. this isn't entirely reliable as yet, and not configurable at all. * em-format-html-display.c (em_format_html_display_set_animate) (em_format_html_display_set_caret_mode): guess? :) (efhd_attachment_button): dont desensitise the button, just dont hook onto it, otherwise it looks fugly. * em-folder-view.c (emfv_list_done_message_selected): dont lookup gconf values every time. use g_timeout_add rather than gtk_timeout, remove fixme's. (emfv_setting_notify): listner for gconf changes, reflect internally. (emfv_setting_setup): setup listner for gconf, and read initial settings. (emfv_activate): use local copy of settings rather than snooping gconf. (emfv_caret_mode): propagate caret-mode to display * em-format-html-quote.c (efhq_format_message): remove gconf stuff, our parent already has citation colour. * em-format-html.c (efh_format_timeout): remove gconf stuff. (em_format_html_set_load_http, em_format_html_set_mark_citations): set options on formatter, re-renders if required. (type_builtin_table[]): text/* should go to text/plain, not text/enriched. 2003-09-04 Not Zed * em-utils.c (confirm_expunge): rename it to emu_confirm_expunge and remove leading whitespace before function. (em_utils_expunge_folder): we want to expunge the folder, not empty the trash. Jeff didn't even run this once ... * em-popup.c: Lots of new features, 'global' popup menu's on a per-selection type, via factories, popup selections (targets), a standard factory for many menu items. (emp_apps_open_in): duh, fix uri using logic (emp_standard_menu_factory): only add apps to app list if !requires_terminal. * em-format-html-display.c (efhd_open_in, efhd_popup_free_items): moved to em-popup.c (efhd_popup_save_attachment, efhd_popup_save_message) (efhd_popup_reply_sender, efhd_popup_reply_list) (efhd_popup_reply_all, efhd_popup_forward): (re)moved to em-popup.c (efhd_attachment_popup): use enew popu stuff. (efhd_attachment_button): Scale the icons for mime-type icons. * em-folder-view.c (em_folder_view_disable_mask): removed ... moved to em-popup. (em_folder_view_get_popup_target): new method, get the selection target for the folder view. (emfv_html_popup_saveas, emfv_html_popup_link_open) (emfv_html_popup_link_copy, emfv_html_popup_address_send) (emfv_html_popup_address_add, emfv_format_popup_free_items): moved to em-popup.c (emfv_format_popup_event): use new popup stuff. (emfv_popup): use new popup stuff, but still just use all local menu's. 2003-09-03 Not Zed * em-folder-view.c (emfv_format_popup_event): implement, a popup menu for right-clicking on links and images. (emfv_html_popup_link_copy): implement. (emfv_init): setup an invisible for selection stuff. (emfv_destroy): free invisible * em-utils.c (em_utils_get_proxy_uri): utility to get the current system proxy setting. (emu_set_proxy): implementation. * em-camel-stream.[ch]: removed. * em-format-html.c (efh_url_requested, efh_format_timeout): use em_html_stream rather than em_camel_stream. (emfh_gethttp): set the system proxy on the new stream. (emfh_multipart_related_check): use puri rather than purin inside the loop - duh. (emfh_multipart_related_check): removed 'unrelated part' warning, they can be (and normally are) added by the callbacks. * em-format-html.h (EMFormatHTMLJob): s/estream/stream/ * em-html-stream.[ch]: New subclass of emsyncstream, replacement for em-camel-stream. 2003-09-04 Jeffrey Stedfast * em-folder-browser.c (emfb_folder_expunge): Call em_utils_expunge_folder instead. * em-utils.c (em_utils_expunge_folder): New function. (confirm_expunge): Make private. 2003-09-04 Jeffrey Stedfast * em-folder-browser.c (emfb_folder_expunge): Confirm hat the user wants to expunge. (emfb_empty_trash): Implemented. * em-utils.c (em_utils_prompt_user): Make public (used to be e_question). (em_utils_confirm_expunge): New function to confirm that the user wants to expunge. (em_utils_empty_trash): New function to empty all Trash folders. * em-composer-utils.c: Get rid of e_question and use em-utils' em_utils_prompt_user() function instead. * em-format-html-quote.[c,h]: New formatter for quoting replies/forwards/etc. * em-utils.c (em_utils_quote_message): New function. (composer_set_body): Use the new em_utils_quote_message() function. (em_utils_temp_save_part): Only g_free mfilename if it was malloc'd. * mail-tools.c (mail_tool_quote_message): Removed. (mail_tool_forward_message): Removed. 2003-09-03 Jeffrey Stedfast * em-format.c (em_format_class_remove_handler): New function to remove a mime-type handler from a class. * em-format-html.c (efh_init): Set the CITATION bit for the default html flags. * em-format-html-display.c: Fixed some compiler warnings by adding appropriate includes. (efhd_multipart_signed): Don't write "inlined signature...". 2003-09-03 Not Zed * em-icon-stream.[ch]: New subclass of emsyncstream, write camel stream one side, creates an icon on the other. * em-sync-stream.[ch]: New file, an abstract class for creating write-any-thread-act-gui-thread stuff. 'em-camel-stream' will subclass this. * em-format-html-display.c (efhd_attachment_button): setup a job to write out an icon if the type is an image type, otherwise try and get the icon directly. no caching yet. the system icons aren't scaled properly either. (efhd_write_icon_job): async job to write out image content. 2003-09-02 Not Zed * em-format-html.c (emfh_new_job): renamed to em_format_html_job_new and made public. (emfh_queue_job): renamed to em_format_html_job_queue, and made public. * em-format-html.h: Made EMFormatHTMLJob a public structure. 2003-09-02 Not Zed * em-folder-view.h (struct _EMFolderView): track the uicomponent while we're activated. * em-message-browser.c (em_message_browser_window_new): kill warning. (emmb_init, emmb_finalise): kill printf * em-format-html.c (efh_format_header): Converted code from head from David Woodhouse 's timezone display patch. (efh_format_text_header): support new flag, HEADER_HTML - header alredy in html format. * em-format-html-print.c (em_format_html_print_print): only ref print_config if != NULL. * em-folder-browser.c (emfb_tree_key_press): handle space/backspace in messagelist to scroll the message view. (emfb_create_view_menus): setup view menu's, this should probably live in message-list. (emfb_init): setup the folderbrowser enable map into the list. (emfb_enable_map): folder browser enable map * em-utils.c (em_utils_adjustment_page): new helper to scroll an adjustment up/down 1 page. * em-folder-view.c (emfv_list_double_click): implement, open window. (emfv_list_key_press): implement keybinding overrides. Enhance delete key to undelete if everything is already deleted. (emfv_build_enable_mask): separate out enable mask creation. (emfv_popup): use above to get mask. (emfv_enable_menus): enable/sensitize menus, use the same disable mask system as used for the popups. (emfv_destroy): change to use g_source_remove on seen_id. (emfv_finalise): free up folders, clean up async event thing. (emfv_init): setup an async event handler (emfv_set_folder): handle hook/unhook of folder_changed events. (emfv_folder_changed): proxy folder changed to main thread, ignore the details of what changed. (emfv_gui_folder_changed): update the menu's to reflect any folder changes. (emfv_build_disable_mask): added CAN_THREADED. (em_folder_view_disable_mask): make public (rename from emfv_build_disable_mask). (emfv_enable_menus): changed to work on a list of arrays of enablers, so they can be subclassed. (emfv_init): add our enable map to the ui. (em_folder_view_disable_mask): added support for can hidden (there are hidden messages). 2003-09-01 Not Zed * em-popup.c: New, simple menu-merging popup menu implementation. NOTE: should be temporary, but needs something that has similar merging facilities. * em-folder-view.c (emfv_popup*): added popup callbacks, implement a popup menu, using em_popup. (emfv_message_*): replaced a whole bunch of one-line, or simple functions with macro's to map to the popup implementation. (emfv_tools_vfolder*, emfv_tools_filter*): map to popup equivalents. (emfv_init): drop printf * em-format-html-display.c (efhd_attachment_popup): use the em_popup stuff to build a dynamic menu. * em-utils.c (em_utils_temp_save_part): change assignment order ot kill warning. (emu_get_save_filesel): handle null/empty name by appending / to the filename. 2003-08-30 Not Zed * mail-search.glade: forgot to add this yesterday. * em-utils.h: don't include stuff we dont need to. * em-folder-view.c (emfv_message_forward): just call em_utils_forward_messages. * em-format-html-display.c (em_format_html_display_search): removed unused. (efhd_drag_data_get): cleanup, use em_utils_temp_save_part. (efhd_attachment_popup): quick hack, setup a bunch more menu items, for forwarding inline messages, hook up saving parts, and messages, and hook up the 'open in' menu. (efhd_open_in): implement. * em-utils.c (em_utils_save_message): Renamed to em_utils_save_part. (em_utils_filesel_prompt): removed, it just makes things more complex than having a single response handler. (em_utils_save_part): move dialog stuff here, it also creates a name based on the type of part its given. (emu_get_save_filesel): new method to create a fileselector with standard options. (emu_save_part_response): handle file selector response for save part. (can_save): renamed to emu_can_save (em_utils_save_messages): use get_save_filesel (emu_can_save): handle the path="" case (em_utils_save_part): Add a prompt argument. (filesel_ok_cb): removed. (emu_update_save_path): update the gconf save_dir setting. (em_utils_forward_messages): helper to forward using default style. (forward_non_attached): remove uids argument. (em_utils_forward_message): helper to forward a message using the default forward style. (forward_non_attached): removed folder argument. (em_utils_temp_save_part): helper to save a part to a temporary file, e.g. for dnd, app launch, etc. 2003-08-29 Not Zed * em-folder-view.c: set 'outgoing' properly. * em-folder-browser.c (emfb_tools_subscriptions): enforce a single instance of the subscribe editor. (emfb_subscribe_editor_destroy): clear subscribe editor handle. 2003-08-29 Not Zed * em-camel-stream.c (em_camel_stream_new): Added some optional logging code. (stream_close): and here. (stream_write): and here. * em-folder-browser.c (emfb_init): remove fixme about search bar, its there now. also fixme's about dnd/selection, they are handled in lower-level widgets. (em_folder_browser_show_preview): dont exit if show preview set, but only if it hasn't changed. (emfb_view_hide_selected, emfb_view_show_all) (emfb_view_hide_read): removed some spurious printfs. * Makefile.am (glade_DATA): Added mail-search.glade. FIXME: should all glade files be merged into 1? * em-format-html-display.c (efhd_format_clone): remove search match count code from here - wont be finished rendering at this point anyway. (em_format_html_display_search): new api for running an interactive search popup. (efhd_update_matches, efhd_update_search) (efhd_search_entry_activate, efhd_search_case_toggled) (efhd_search_response): helpers/callbacks for search popup. (efhd_class_init): hook into complete signal on EMFormat. (efhd_complete): complete rendering handler, update match count. * em-folder-view.c: removed fixme about api's - yes, do need two set_folder api's. (emfv_edit_cut, emfv_edit_copy): removed printfs (emfv_edit_paste): removed commented call to html_paste, we never want to do that. 2003-08-29 Jeffrey Stedfast * em-folder-view.c (emfv_message_mark_unread): If there is a mark-as-read timeout handler registered, unregister it here. (emfv_tools_filter_mlist): Implemented. (emfv_tools_filter_recipient): Implemented. (emfv_tools_filter_sender): Implemented. (emfv_tools_filter_subject): Implemented. (emfv_tools_vfolder_mlist): Implemented. (emfv_tools_vfolder_recipient): Implemented. (emfv_tools_vfolder_sender): Implemented. (emfv_tools_vfolder_subject): Implemented. 2003-08-28 Not Zed * em-folder-browser.c (emfb_search_menu_activated) (emfb_search_config_search, emfb_search_search_activated) (emfb_search__query_changed): Implement search-bar callbacks. (emfb_init): setup search bar. 2003-08-28 Not Zed * em-folder-view.c (emfv_message_reply): common reply code entry point, also implement simple reply-to-highlighted text (currently disabled). (emfv_activate): disable resend message on non-sent folders. (emfv_message_reply_all, emfv_message_reply_list) (emfv_message_reply_sender): use message_reply for common code. (em_folder_view_open_selected): in drafts or outbox, edit the message instead. (emfv_activate): force a sync on deactivate. * em-utils.c (em_utils_selection_get_mailbox): get mailbox (message/rfc822?) selection data. (em_utils_read_messages_from_stream): helper to move stuff from a mbox stream to a folder. (em_utils_folder_is_drafts, em_utils_folder_is_sent) (em_utils_folder_is_outbox): from folder browser helpers for customising the user experience. * message-list.c (message_list_construct): hook onto dnd stufd. (ml_tree_drag_data_get): implement drag sending. (ml_tree_drag_data_received): implement drag recieving. * em-format-html-display.c (efhd_drag_data_get): implemented. (efhd_drag_data_delete): implemented. (efhd_attachment_button): setup dnd callbacks. 2003-08-28 Jeffrey Stedfast * em-folder-view.c (emfv_destroy): override the destroy method for GtkObject - unregister the mark-as-seen timeout if one is currently registered. (emfv_list_done_message_selected): Add the mark-as-seen timeout functionality here. (emfv_format_link_clicked): Implemented. 2003-08-27 Jeffrey Stedfast * em-utils.c (get_reply_list): Implemented. 2003-08-27 Not Zed * em-message-browser.c (emmb_activate): disable Edit->Paste menu always. * em-folder-browser.c (emfb_edit_paste): do a message-list paste, not a html one. (emfb_edit_cut, emfb_edit_copy, emfb_edit_paste): Moved to folder-view. * message-list.c (message_list_paste): trigger a paste action. (message_list_set_folder): added a uri argument, and save it internally, fixed all callers. (message_list_finalise): free the folder uri. * em-utils.c (em_utils_selection_set_mailbox): New helper to set the current selection as text in a berkely mailbox format. (em_utils_write_messages): helper to write stuff to a stream in mbox format. 2003-08-27 Not Zed * message-list.c (on_selection_changed_cmd): own/deown the primary selection when it changes. (message_list_init): init private data and invisible for selection. (message_list_destroy): free invisible. (message_list_finalise): free private data. (get_selected_cb): removed. (message_list_copy): new method to do copy and cut. cut/copy to the clipboard. (ml_selection_clear_event): clear the right selection when requested. (message_list_has_primary_selection): helper to find out if the message-list has the selection. is there a gtk way for this? 2003-08-26 Not Zed * mail-local.c (mlf_meta_set, mlf_meta_get): proxy meta-data stuff to subservient folder. 2003-08-23 Not Zed * em-folder-view.c (emfv_init): init preview here always. 2003-08-25 Jeffrey Stedfast * em-folder-view.c (em_folder_view_print): Use e_dialog_set_transient_for(). (emfv_message_delete): Fixed a FIXME. * em-folder-browser.c (emfb_edit_cut): Implemented. (emfb_edit_copy): Implemented. (emfb_edit_paste): Implemented. * em-format-html-display.c (em_format_html_display_cut): New function. (em_format_html_display_copy): New. (em_format_html_display_paste): New. 2003-08-25 Jeffrey Stedfast * em-utils.c (em_utils_flag_for_followup): Use e_dialog_set_transient_for(). (em_utils_filesel_prompt): Same. (post_reply_to_message): Here too. (em_utils_edit_filters): Same. (create_new_composer): And here. (em_utils_compose_new_message_with_mailto): Here too. (em_utils_post_to_url): " (redirect_get_composer): Same. (reply_get_composer): Again... * em-folder-browser.c (emfb_tools_filters): Implemented. * em-utils.c (em_utils_edit_filters): New function to open the filter editor dialog. 2003-08-22 Jeffrey Stedfast * em-utils.c (em_utils_flag_for_followup): Implemented. (em_utils_flag_for_followup_clear): Implemented. (em_utils_flag_for_followup_completed): Implemented. * em-folder-view.c (emfv_message_followup_flag): Implemented. (emfv_message_followup_clear): Implemented. (emfv_message_followup_completed): Implemented. 2003-08-22 Not Zed * em-camel-stream.c (em_camel_stream_new): now take the gtkhtml too, and hook onto it's destroy so we don't try writing anymore after its gone. (stream_write, stream_flush, stream_close, emcs_gui_received): NOOP if the gtkhtml has been destroyed. (emcs_gtkhtml_destroy): null out the stream when the gtkhtml gets destroyed, it is no longer valid. (emcs_gui_received): dont try to soak all outstanding events, it always runs synchronous anyway, just get one and exit. * em-format-html.c (efh_gtkhtml_destroy): if the gtkhtml gets destroyed, abort any pending timeouts/processing. (efh_format_source): fixed implementation to write out all headers. (efh_multipart_related, emfh_multipart_related_check): separate checking for unused parts into a separate job, which is run after previous ones are executed. keep track of visibility tree level in job, etc. 2003-08-22 Jeffrey Stedfast * em-folder-browser.c (emfb_mail_compose): Implemented. (emfb_mail_post): Implemented. * em-utils.c (em_utils_compose_new_message): New function. (em_utils_compose_new_message_with_mailto): New. (em_utils_post_to_url): New. 2003-08-21 Not Zed * subscribe-dialog.glade: removed the text in the progress thing. It never showed up anyway and caused weird resizing stuff when the progress bar was active. * em-subscribe-editor.c: Found the correct version of the new subscribe code (on branch, duh!), and integrated it. (sub_selection_changed): Sensitise buttons based on selection. * em-format-html.c (efh_text_plain, efh_text_enriched) (efh_write_text_html): Use format_text for text output. (efh_write_image): use explicit image writer. (emfh_gethttp): added some progress stuff. (efh_format_do): maintain the accessible uri tree during jobs. (efh_url_requested): store the current uri accessibility tree node in the job, so it can be properly set for sub-jobs. (emh_multipart_related): moved here, can't use super-class version as it doesn't know about async jobs. (type_buildin_table[]): Added image/jpg and image/jpeg for the brokenmailers out there and to reduce the whinge. * em-format.c (em_format_format_content): For text parts, perform default charset/charset snooping/decoding. No longer closes the stream once complete. (emf_write_related): close stream ourselves. 2003-08-21 Jeffrey Stedfast * em-folder-view.c (emfv_message_forward): Implemented. (emfv_message_forward_attached): Implemented. (emfv_message_forward_inline): Implemented. (emfv_message_forward_quoted): Implemented. (emfv_message_redirect): Implemented. (emfv_message_post_reply): Implemented. (emfv_message_reply_all): Implemented. (emfv_message_reply_list): Implemented. (emfv_message_reply_sender): Implemented. (emfv_message_resend): Implemented. (emfv_message_saveas): Implemented. * em-composer-utils.c: New source file containing all the composer send/draft callback mess. * em-utils.c (em_utils_uids_copy): New convenience function to copy a list of uids. (em_utils_uids_free): New convenience function to free a list of uids. (em_utils_save_message): New function to save a CamelMimeMessage (prompts the user for a location to save). (em_utils_save_messages): New function to save a list of messages (given a folder and list of uids). (em_utils_configure_account): Configure a new account... (em_utils_check_user_can_send_mail): Make sure the user has a transport setup. (em_utils_edit_message): New function to edit a message object. (em_utils_edit_messages): New function to open a composer to edit each message. (em_utils_forward_attached): New function to forward messages as an attachment, (em_utils_forward_inline): Forward a bunch of messages inline. (em_utils_forward_quoted): Forward a bunch of messages quoted. (em_utils_redirect_message): Redirect a message object. (em_utils_redirect_message_by_uid): Redirect a message given a folder and uid. (em_utils_reply_to_message): Reply to a message object. (em_utils_reply_to_message_by_uid): Reply to a message given a folder and uid. (em_utils_post_reply_to_message_by_uid): Post a reply to a message given a folder and uid. * mail-ops.c (filter_folder_free): Use em_utils_uids_free(). (transfer_messages_free): Same. (get_messages_free): Here too. (save_messages_free): Same. 2003-08-20 Not Zed * em-subscribe-editor.[ch]: new widget, a dialog for editing subscriptions. * em-format-html.c (efh_format_done): emit a complete when done. * em-format.c (emf_class_init): Added a 'complete' signal, so that printing knows when to print. * em-format-html-print.c (em_format_html_print_print): Changed to take the message and source formatter too. Runs an async render then prints. 2003-08-19 Not Zed * em-*.c: stacks more changes, added some bonobo menu setup, and implemented the trivial functions. * em-message-browser.[ch]: New message browser, inherits from em-folder-view. Basically works. * message-list.c (message_list_select_uid): if we're selecting while still loading, setup a pending select. (regen_list_free): Check for a pending select, and select the message if we're now idle. * em-folder-view.c (em_folder_view_set_message, em_folder_view_set_folder): Make virtual macro's. (emfv_control_activate): added hook to enable bonobo state when setup. * em-format.c (emf_format_clone): base implementation, just clears state data. * em-format.h: change ::format to ::format_clone. Make em_format_format_clone a macro/virtual method. * mail-mt.c (em_channel_setup): new function to setup i/o channels, so we can control the recursive flag. leave off for now. (mail_msg_init): setup MsgPort channels using above. * em-format-html.c (efh_format): serialise/de-recursify formatting via a timeout function. (efh_format_timeout): keep polling to find out if cancellation is complete, then kick off a new render. 2003-08-18 Not Zed * em-*.c: more updates, incl threaded formatting queue. 2003-08-18 Jeffrey Stedfast * em-format-html-display.c (em_format_html_display_zoom_in): New method to zoom-in on the gtkhtml contents. (em_format_html_display_zoom_out): Same but for zoom-out (em_format_html_display_zoom_reset): You get the idea. 2003-08-12 Jeffrey Stedfast * mail-callbacks.c (invert_selection): Use message_list_invert_selection(). (select_thread): Use message_list_select_thread(). (select_all): Use message_list_select_all(). * message-list.c (message_list_select_all): New function. (message_list_select_thread): New function. (message_list_invert_selection): New function. 2003-08-12 Jeffrey Stedfast * mail-session.c: Synced up with HEAD. * component-factory.c: * mail-folder-cache.[c,h]: * mail-tools.h: * mail-ops.[c,h]: * mail-send-recv.c: * mail-format.[c,h]: * mail-display.c: * mail-account-gui.c: * mail-local.c: * mail-offline-handler.c: * subscribe-dialog.c: 2003-08-12 Jeffrey Stedfast * em-format-html-display.c: Fixed some compiler warnings. * em-format.c: Updated for new mime-parser changes made to HEAD. * em-folder-view.c: Fixed some compiler warnings. * em-format-html.c: Fixed some compiler warnings. 2003-08-06 Not Zed * em-format-html-display.c (efhd_format_attachment): Added bonobo embeddables. 2003-08-01 Harry Lu *Fix for bug #6951 * mail-display.c (launch_cb): Bypass the new added menu item. (save_all_parts_cb): New function. Do the real save-all work. (save_all_parts): New function. Get the directory to save to. (save_all_cb): New function. The call-back function for the new added menu item. (pixmap_press): Add the new menu item "Save All Attachment...". (ptr_array_free_notify): A simple wrapper function to free the pointer array. (do_attachment_header): Save attachment pointer in an array for "Save All Attachment" use. 2003-08-01 Yuedong Du * message-browser.c (on_key_press): close mail message window using 'ESC' key, fix bug #47087 2003-07-28 Jeffrey Stedfast * mail-crypto.c: Removed smime functions as they were stale. 2003-07-25 Jeffrey Stedfast * message-browser.c (message_browser_new): Handle our own Delete key presses. Fixes bug #45597. 2003-07-25 Ettore Perazzoli * mail-callbacks.c (do_view_message): No need to pass a shell argument to message_browser_new() anymore. * message-browser.c (message_browser_new): Removed arg shell. No need to pass it to folder_browser_new() either. * mail-component.c (create_view_callback): No need to pass a shell arg to folder_browser_factory_new_control() anymore. * folder-browser-factory.c (folder_browser_factory_new_control): Removed arg shell; folder_browser_browser_new() doesn't need it anymore. * folder-browser.c (folder_browser_destroy): No need to unref ->shell anymore. (folder_browser_new): Removed shell arg. (folder_browser_gui_init): Removed a const qualifier that was not supposed to be there. * folder-browser.h: Removed member shell from struct FolderBrowser. 2003-07-25 Ettore Perazzoli * folder-browser.c (folder_browser_gui_init): Get the search context through mail_component_peek_search_context(), since it's no longer a global variable. (folder_browser_gui_init): Cleaned up an extra unneeded if() statement. * mail-component.c: New member search_context in struct MailComponentPrivate. (mail_component_peek_search_context): New. (setup_search_context): New function to initialize the search_context, based on the old code in component-factory.c. (mail_component_init): Call it here. (impl_dispose): Unref the rule_context. * mail-component-factory.c: Removed global variable search_context. 2003-07-25 Ettore Perazzoli * mail-component.c (browser_page_switched_callback): New callback for the "page_switched" signal on EStorageBrowser; deactivate the previous page, activate the new one. (impl_createControls): Connect. 2003-07-24 Ettore Perazzoli * mail-mt.c (do_op_status): Pass "evolution-mail" as the ID to evolution_activity_client_new(). [This is just a temporary thing to avoid the fact that we don't have component-factory.h anymore. Eventually we'll just get rid of the activity client stuff.] * mail-component-factory.c: Added to the build. Also, finished implementing and moving the factory over from component-factory.c. * component-factory.c: Removed from the build. * component-factory.h: Removed from the build. * mail-component.c: Removed some debugging messages. 2003-07-23 Ettore Perazzoli * subscribe-dialog.c: Converted to use EStorages instead of EvolutionStorages and the new MailComponent object. * mail.h: Nuked a bunch of stuff. This will go away when I am done refactoring. * mail-offline-handler.c: Use the new MailComponent object. * mail-folder-cache.c, mail-folder-cache.h: Converted to use EStorages instead of EvolutionStorages. * mail-display.c: Use g_timeout and g_source functions instead of gtk_timeout functions. * mail-send-recv.c: Use g_timeout and g_source functions instead of gtk_timeout functions. (receive_update_got_store): Updated for the new mail_note_store(). * mail-session.c: Use g_timeout and g_source functions instead of gtk_timeout functions. * mail-config-factory.c (factory): Removed. * folder-browser.c (folder_browser_destroy): Use GLib timeout/source functions instead of the deprecated GTK ones. (done_message_selected): Likewise. (folder_browser_gui_init): Protect against fb->search being NULL. * mail-account-gui.c (add_new_store): Use new MailComponent object and EStorages instead of EvolutionStorages. (mail_account_gui_save): Likewise. * mail-accounts.c (account_delete_clicked): Use new MailComponent object and EStorages instead of EvolutionStorages. (account_able_clicked): Likewise. (account_able_toggled): Likewise. * mail-autofilter.c: Use mail_component_peek_base_directory() instead of the evolution_dir global. * mail-callbacks.c: Likewise. * mail-config.c (uri_to_evname): Likewise. (mail_config_get_signature_list): Likewise. (delete_unused_signature_file): Likewise. * mail-display.c (mail_display_class_init): Likewise. * mail-importer.c (mail_importer_make_local_folder): Likewise. * mail-local.c (mlf_getv): Likewise. * mail-ops.c (uid_cachename_hack): Likewise. * mail-summary.c (generate_folder_summaries): Likewise. * mail-tools.c (mail_tool_get_local_inbox): Likewise. (mail_tools_folder_to_url): Likewise. * mail-vfolder.c (mail_vfolder_delete_uri): Likewise. (mail_vfolder_rename_uri): Likewise. (context_rule_removed): Likewise. (store_folder_deleted): Likewise. (store_folder_renamed): Likewise. (vfolder_load_storage): Likewise. (vfolder_editor_response): Likewise. (edit_rule_response): Likewise. (new_rule_clicked): Likewise. (vfolder_gui_add_rule): Likewise. * mail-session.c (main_get_filter_driver): Likewise. (mail_session_forget_password): Likewise. (mail_session_init): Get a base_directory arg. * component-factory.c, component-factory.h: Disabled a bunch of stuff to get it to compile in the new configuration. These files will eventually go away when I am done refactoring this. * Makefile.am: Do not build importers, compile generate skels/stubs for Evolution. * GNOME_Evolution_Mail.server.in.in: Rename control factory to OAFIID:GNOME_Evolution_Mail_Factory2. Add new component GNOME_Evolution_Mail_Component2. * mail-component-factory.c: New file implementing the Bonobo factory. * mail-component.c, mail-component.h: New files implementing the new mail component, using the new Evolution::Component IDL. 2003-07-23 Jeffrey Stedfast * mail-format.c (mail_format_data_wrapper_write_to_stream): Revert prior changes. 2003-07-23 Dan Winship * folder-browser.c (message_list_drag_data_get): Fix type warnings (folder_browser_toggle_caret_mode): Remove unused variable. * folder-browser-ui.c (basename): remove unused function * mail-account-gui.c (mail_account_gui_build_extra_conf): Fix warnings * mail-callbacks.c (empty_trash): Remove unused variable. * mail-display.c: #include gal/widgets/e-gui-utils.h for e_auto_kill_popup_menu_on_selection_done * mail-importer.c: #include e-util/e-path.h for e_path_to_physical * mail-session.c (main_play_sound): don't declare filename to be const and then free it. * mail-vfolder.c (vfolder_edit_rule, vfolder_gui_add_rule): Fix casts * message-list.c (build_flat_diff): Fix a typo in the non-BROKEN_ETREE code 2003-07-16 Jeffrey Stedfast * mail-format.c (handle_multipart_encrypted): We don't have camel_pgp_mime_is_rfc2015_encrypted() anymore so just look at the protocol for now. (mail_format_data_wrapper_write_to_stream): Updated for the new way camel handles content objects. 2003-07-15 Federico Mena Quintero * folder-browser.c (message_list_drag_data_received): Handle invalid URIs, or more likely, the last empty element in a URI list --- g_strsplit() will yield { "uri1", "", NULL }. Fixes #46398. * component-factory.c (destination_folder_handle_drop): Likewise. 2003-07-15 Yuedong Du * mail-config.c: (config_write_style), (mail_config_init): remove the use of caret mode widget style. * mail-display.c: (display_notify), (mail_display_new): use new gtkhtml api to set caret mode. 2003-07-11 Antonio Xu * folder-browser-ui.c: Change the EditPaste mask to IS_0MESSAGE so that it is always activatable. Fixes bug #46018. 2003-07-04 Maxx Cao ** For bug #41839 * mail-display.c (do_attachment_header): Attachment buttons made accessable with keyboard (focusable). "Inline" button is disabled when attachment can't be viewed inline. (do_signature): Signature button made accessable with keyboard (focusable). (button_press): Function changed to an event callback (originally gtkbutton signal callback). (popup_menu_placement_callback): Function added to place popup menu (of attachment) beside button when activated by keyboard. 2003-07-10 Yuedong Du * evolution-mail.schemas: add a gconf key corresponding to newly introduced caret mode of gtkhtml widget. * folder-browser-ui.c: new verb handling, corresponding the new menu entry for the caret mode flag. * folder-browser.h: declaration of new verb handler to the menu entry that turn caret mode on/off. The function just set the new introduced gconf key. * folder-browser.c: ditto * mail-config.c: lstione to the new gconf key, and when caret mode flag is set/unset,change the style of gtkhtml widget. see bug #44607. 2003-07-09 Jeffrey Stedfast * mail-crypto.h: Removed camel-pgp-mime.h, it no longer exists. * mail-format.c: Remove camel-pgp-mime.h 2003-07-07 Jeffrey Stedfast * mail-callbacks.c (mail_generate_reply): Use camel_strcase_hash/equal. * upgrade-mailer.c: Updated to use the camel-file-utils version of mkdir. 2003-07-02 Jeffrey Stedfast * mail-tools.c (mail_tool_forward_message): Strip the signature from the body text. Fixes bug #45523. While we're here, also fix the code to quote exactly the same way as the mail_tool_quote_message() function. (mail_tool_quote_message): The last arg should not be 'want_plain', because that arg is for whether or not the body should be quoted. * folder-browser.c (message_list_drag_data_get): Apply a From-filter when dragging as a test/uri-list and message/rfc822. Fixes bug #45617. Also free the uids ptrarray for the text/uri-list case. 2003-07-01 Dan Winship * mail-display.c (pixbuf_for_mime_type): Gone (pixbuf_gen_idle): Use e_icon_for_mime_type instead. 2003-06-27 Jeffrey Stedfast * message-list.c (filter_date): Use the newer utf8 versions of the e_strftime*() functions since our format strings are all now in UTF-8. * mail-display.c (mail_display_render): Use the newer e_utf8_strftime_fix_am_pm(). * mail-callbacks.c (mail_generate_reply): Use e_utf8_strftime(), otherwise we can end up with invalid utf-8. 2003-06-25 Radek Doulik * mail-config.c (config_write_style): provide hardcoded default (red) spell error color 2003-06-24 Jeffrey Stedfast Might fix bug #45368 but I wouldn't bet on it. * message-browser.c (message_browser_new): Record the signal id for folder_loaded. (message_browser_folder_loaded): disconnect by id rather than searching for the handler. Save the id of the message_list_built signal handler. (message_browser_message_list_built): Disconnect the handler by id. (message_browser_destroy): Disconnect the signal handlers by id. 2003-06-20 Not Zed ** See bug #43887 * mail-format.c (mail_get_message_body): handle text/enriched and text/richtext explictly, and dont treat them as text/plain. 2003-06-23 Radek Doulik * mail-config.c (config_write_style): add EvolutionMailPrintHTMLWidget style assignment * mail-callbacks.c (do_mail_print): set printing widget name 2003-06-23 Dan Winship * message-list.c (on_selection_changed_cmd): Save the idle_id 2003-06-23 Larry Ewing * folder-browser.c (do_message_selected): make sure not to strcmp a possibly NULL string. 2003-06-19 Not Zed ** See bug #45063 * folder-browser.c (do_message_selected): dont re-load if the same message gets selected again as one we've already shown. Etree sends out selection changed events even when when it hasn't. 2003-06-18 Jeffrey Stedfast * message-list.c (hide_save_state): Only save state if we have a folder reference. Fixes some warnings about casting a NULL object to a CamelFolder. 2003-06-16 Jeffrey Stedfast * message-list.c (ml_tree_value_at): Don't display an unread icon for a parent message status if it has unread children but has been read itself. Instead, show that we have unread children by just making the message test bold (which it was already doing, so yay... this was easy). Fixes bug #42630. 2003-06-16 Not Zed ** See bug #44609 * mail-vfolder.c (vfolder_edit_rule): put the ok/cancel buttons in the stupid gnome 2 order. ** See bug #33593 * message-list.c (on_selection_changed_cmd): also listedn to selection changed events, since the etable api has changed. (get_selected_cb): helper for above. (message_list_construct): hook to selection change signal. * mail-callbacks.c (composer_send_queued_cb): Unref the composer to match the ref composer_send_cb(); ** See bug #44519 * message-browser.c (message_browser_message_list_built): We want to disconnect from the messagelist, not folderbrowser signal. 2003-06-11 Jeffrey Stedfast * mail-format.c (format_mime_part): We only really want to use mail_identify_mime_part() if the content-type is application/octet-stream - any other type (if it doesn't have a handler) should just force the user to save to disk. (handle_text_plain): Only pay attention to format=flowed if the mime-type is text/plain (handle_text_plain is the generic text handler, so we might be processing parts that are not really text/plain, thus the format param may have different meaning for those other textual types). 2003-06-11 Larry Ewing * mail-format.c (mail_lookup_handler): free the application list if we are bailing. * mail-send-recv.c (free_folder_info): free the info structure as well. 2003-06-06 Jeffrey Stedfast * message-tag-followup.c (get_week_start_day): Use mail-config's gconf client. (target_date_new): Same. * message-list.c (message_list_set_folder): Use mail-config's gconf client. (mail_regen_list): Same. * mail-tools.c (mail_tool_quote_message): Use mail-config's gconf client. (mail_tool_forward_message): Same. * mail-session.c (main_get_filter_driver): Use mail-config's gconf client. * mail-preferences.c (mail_preferences_init): Use mail-config's gconf client. (mail_preferences_finalise): Don't unref the gconf client. * mail-format.c (write_headers): Use mail-config's gconf client. (mail_format_data_wrapper_write_to_stream): Same. (handle_text_plain): And here. * mail-display.c (save_data_cb): Use mail-config's gconf client. (save_part): Same. (on_url_requested): Here too. (mail_text_write): And here. (mail_display_init): And here. (mail_display_destroy): Here too. (mail_display_new): Again here. * mail-composer-prefs.c (sig_add_cb): Use mail-config's gconf client. (mail_composer_prefs_construct): Same. * mail-callbacks.c (ask_confirm_for_unwanted_html_mail): Use mail-config's gconf client. (ask_confirm_for_empty_subject): Same. (ask_confirm_for_only_bcc): Here too. (composer_get_message): And here. (create_msg_composer): Again here. (mail_generate_reply): Same. (forward): And here. (transfer_msg_done): " (delete_msg): " (confirm_expunge): " * component-factory.c (owner_unset_cb): Use mail-config's gconf client. * folder-browser-ui.c (folder_browser_ui_add_message): Use the mailer's gconf client. (folder_browser_ui_add_list): Same. (folder_browser_ui_add_global): Here too. * folder-browser.c (save_cursor_pos): Use the mailer's gconf client. (folder_browser_set_message_preview): Same. (folder_browser_toggle_preview): Here too. (folder_browser_toggle_threads): And here. (folder_browser_toggle_hide_deleted): Here as well. (folder_browser_set_message_display_style): And here. (fb_resize_cb): Here. (paned_realised): And here. (done_message_selected): And everywhere... * mail-account-gui.c (sig_add_new_signature): Use the mailer gconf client. * mail-config.c (mail_config_get_gconf_client): New function to return the global GConfClient used by the mailer. (mail_config_write_on_exit): On exit, free our objects and such. (mail_config_signature_run_script): Use config->gconf. 2003-06-04 Jeffrey Stedfast * mail-callbacks.c (invert_selection): Get rid of the if-focused code, that will always prevent the etree from getting the selection inverted because the menu item will always have focus at this time. Fix for bug #43972. 2003-06-11 Not Zed ** See bug #22542 * component-factory.c (storage_create_folder): If we're creating a folder on a vstore, popup a vFolder editor rather than failing. 2003-06-05 Not Zed ** Part of #42691. * importers/Makefile.am (BUILT_SOURCES): added server_DATA. * Makefile.am (%.server.in): create a proper implicit rule for temporary .in file. 2003-06-04 Not Zed ** See bug #43974 * mail-tools.c (mail_tool_do_movemail): use a proper CamelURL to decode the uri, not hacky strcmp stuff. * mail-account-gui.c (extract_values): if we have an conf_entry, ignore username, hostname, and path ones, as these are handled implicitly in the url itself. Came about because of the fix for #42838. 2003-06-03 Federico Mena Quintero * mail-search.c (mail_search_construct): Put the buttons in HIG order; don't replace the label of the stock Find button. Also, add Escape as a keybinding for the Close button (see why GTK+ is on crack on b.g.o #74221 and #101293).