2000-12-15 Jeffrey Stedfast * mail-format.c (handle_multipart_signed): New callback to handle multipart/signed parts. (decode_pgp): Update to account for the cipherlen argument needed for openpgp_decrypt. (is_rfc2015): Removed as we now have a better version in mail-crypto. (handle_multipart_encrypted): Updated to use the PGP/MIME utility functions. * mail-crypto.c (mail_crypto_openpgp_decrypt): Don't check (!*plaintext) as it could be a binary stream. Now also takes a cipherlen argument. (mail_crypto_openpgp_sign): New function. (pgp_mime_part_sign): New function to replace a mime part with the pgp signed equivalent. (pgp_mime_part_encrypt): New function to replace a mime part with the pgp encrypted equivalent. (pgp_mime_part_decrypt): New function to decrypt a pgp encrypted mime part (like from pgp_mime_part_encrypt) and replace it. (is_rfc2015_signed): New function to determine if a mime part is an rfc2015 signed part. (is_rfc2015_encrypted): New function to determine if a mime part is an rfc2015 encrypted part. (mail_crypto_openpgp_verify): New openpgp function to verify a signature. 2000-12-14 Christopher James Lahey * mail-threads.c (update_active_views): Unref the iterator when we're done with it. 2000-12-14 Larry Ewing * mail-display.c (mail_display_new): call gtk_html_set_default_content_type to make gkthtml default to utf-8 when parsing. This requires gtkhtml >= the released 0.8. 2000-12-14 Ettore Perazzoli * mail-threads.c (read_msg): Call `ui_set_busy()' before `ui_set_message()' so that we are sure that the set_busy/unset_busy calls always happen in order. 2000-12-13 Christopher James Lahey * folder-browser.c (my_folder_browser_init): Made the vertical scrollbar always be there. * message-list.c (message_list_get_layout): Changed the minimum width of some of the pixmap column headers. 2000-12-12 Christopher James Lahey * component-factory.c (create_view): Added a cast. * mail-summary.c: Added #include "mail-summary.h". Commented out folder_free, summary_free, and view_destroy_cb since they're not used. (do_changed): Added a cast. (create_summary_view): Changed some types so that casting would be easier. * session.c (mail_session_remember_password): Added a cast. 2000-12-12 Dan Winship * mail-summary.h: Fix to use the right .h instead of the deprecated one. 2000-12-12 Jeffrey Stedfast * mail-callbacks.c (forward_message): Attach a signature when forwarding, fixes bug #826. 2000-12-11 Dan Winship * session.c (mail_session_enable_interaction): New function to tell the code that it's ok (or not) to interact with the user when trying to authenticate to a service. Starts out turned off. (mail_session_request_dialog): If interaction is disabled, fail if the password isn't in the cache. * component-factory.c (owner_set_cb): Call mail_session_enable_interaction() after everything else. (This means that the IMAP password dialog will no longer pop up [under the splash screen] at startup.) 2000-12-11 Dan Winship * component-factory.c (create_view): Deal with "mailstorage" type views (top-level mail storages) by trying to fill the storage's folder tree again if we failed before. (add_storage): Create new storages with a URI and type "mailstorage". * mail-ops.c (cleanup_scan_subfolders): On success, mark the storage as having been loaded, so create_view won't try again. 2000-12-11 Jeffrey Stedfast * mail-format.c (decode_pgp): Updated to reflect arguments to the openpgp functions - now also takes an outlen argument. (try_inline_pgp): Updated. (handle_multipart_encrypted): Updated here too. * mail-crypto.c (crypto_exec_with_passwd): Updated to handle binary streams and such. (mail_crypto_openpgp_encrypt): Always initialize the passwd_fds even if we don't plan on signing. Added an 'inlen' to specify the length of the input data (as it could be binary). Also added a 'userid' argument for cases when we want to sign as well as encrypt. (mail_crypto_openpgp_decrypt): Updated to take an outlen argument in case the ciphertext is encrypted binary data. (mail_crypto_openpgp_clearsign): Added a 'hash' and 'detach' arguments. 'hash' allows the program to specify the preferred hash function (which will come in handy when generating PGP/MIME). 'detach' allows the program to specify whether it wants a detached signature or the entire signed text. 2000-12-11 Dan Winship * message-list.c: Remove the never-once-used BonoboObject stuff and make MessageList be a GtkWidget instead. Also, keep track of the ETable directly rather than repeatedly calling e_table_scrolled_get_table. * folder-browser.c (folder_browser_destroy): Use gtk methods rather than bonobo methods to destroy the message list. (on_right_click, on_double_click): These are being attached to the ETable directly now, so fix the first argument (which isn't being used anyway, but...). Ignore double-clicks on "active" columns (the ones where clicking does something beyond "select"), fixing bug #811, which is what got me started on this to begin with... (folder_browser_gui_init): simplify now that MessageList itself is a widget. Also use message_list->table rather than e_table_scrolled_get_table. * mail-local.c (mail_local_reconfigure_folder): Add "mail_" to the beginning of this function name to match its prototype and the other vague namespace conventions in the mailer. * mail-callbacks.c (select_all, invert_selection): Use ml->table. (configure_folder): s/local_reconfigure_folder/mail_&/ * mail-ops.c (do_flag_messages): clean up the cleanup a bit * mail-tools.c (mail_tool_quote_message): Remove an unused variable. 2000-12-11 Not Zed * local-config.glade: reordered the options and added maildir, mbox, maildir, mh, in that order. * mail-local.c (reconfigure_clicked): Added maildir, re-ordered to match the changed xml file too. (do_reconfigure_folder): WHoever 'threaded' this code forgot to check that folder_browser functions shouldn't be called here. (cleanup_reconfigure_folder): Call it here instead. (lookup_folder): Blah blah, we have to lookup the folder and verify its still the same format, joy. Becaause someone thought it would be wise to make the code 5x more complicated for no reason, and totally break 'mail reconfigure' in the process. i'm really happy about that one. (cleanup_register_folder): Uh, yeah, so like, the local_store->folders hashtable is supposed to point to like, LocalFolders, not CamelFolders. (free_local_folder): Free the localfolder struct properly. (free_folder): Call above to free data properly. (get_folder): Fix for fixing folders hashtable. (local_storage_removed_folder_cb): Same here. (local_storage_new_folder_cb): Ref the local_store when putting it in the local_folder. (cleanup_register_folder): Properly free the local_folder if the op failed. (free_local_folder): Unhook events also. (d): Oops, left debug turned on. 2000-12-09 Christopher James Lahey * message-list.c (message_list_init): Change the "drawfocus" argument on e_table_scrolled_get_table(etable) instead of on etable (etable is an ETableScrolled.) 2000-12-08 Jeffrey Stedfast * mail-callbacks.c (save_msg_ok): Check to see if the file already exists, if it does prompt the user to for permission to overwrite the file. (forward_message): g_strdup the cursor_uid if there is only a single message to be forwarded or we'll segfault later. * mail-ops.c (do_save_messages): Rewrote yet again. I'm back to almost an identical implementation as the first time I wrote this except now we write the From line which I had forgotten last time. This means that we no longer have to unlink the .ev-summary file created and we also use fewer resources (no need to create a CamelMboxFolder object). 2000-12-08 JP Rosevear * folder-browser.c (on_double_click): the e-table double-click signal now has extra params 2000-12-07 Ettore Perazzoli * component-factory.c (add_storage): Pass `NULL' as the @toplevel_node_handler_id arg in `evolution_storage_new()'. FIXME: We should be passing the ID of the mail component here. * mail-vfolder.c (vfolder_create_storage): Likewise. 2000-12-08 Jeffrey Stedfast * message-list.c (message_list_get_layout): Set the "Size" field to sort using integer comparison instead of string. (filter_size): New function to transform a integer size into a more readable form. (ml_value_to_string): Use filter_size. (ml_value_is_empty): COL_SIZE is no longer a string, so handle this as an integer. (ml_initialize_value): Here too. (ml_free_value): And here. (ml_duplicate_value): And here too. (message_list_create_extras): Setup the size etable cell. 2000-12-08 Christopher James Lahey * folder-browser.c: Connect to signals on the ETable instead of the ETableScrolled. * subscribe-dialog.c: Used the e_table_scrolled_get_table function instead of accessing the variable directly. 2000-12-08 Christopher James Lahey * message-list.c: Connect to signals on the ETable instead of the ETableScrolled. 2000-12-07 Christopher James Lahey * message-list.c: Got rid of code referencing the ETableScrolled proxy functions. Changed the call to e_table_set_cursor_row to send a model row instead of a view row. 2000-12-07 Jeffrey Stedfast * mail-callbacks.c (forward_message): Only do a message_list_foreach if we plan on attaching messages, otherwise just use ml->cursor_uid. * mail-ops.c (cleanup_forward_messages): If attaching multiple forwarded message, wrap them in a multipart/digest otherwise just attach the single message as a message/rfc822. 2000-12-07 Dan Winship * mail-display.c (on_object_requested): Make the iTip hack spew a g_warning and not crash if you have no identity configured. To be revisited. * mail-callbacks.c: (various) * folder-browser.c (filter_mlist): * mail-autofilter.c (filter_gui_add_from_message): * mail-vfolder.c (vfolder_gui_add_from_message): Add some g_return_if_fail()s to protect from crashes until the code to enable/disable commands based on how many messages are selected is done. 2000-12-06 Jeffrey Stedfast * mail-vfolder.c (vfolder_gui_add_rule): Make the vfolder editor resize correctly. Fixes bug #835. 2000-12-06 Dan Winship Fix up shutdown so that things that should be destroyed get destroyed. Among other things, this fixes the bug where IMAP stores weren't disconnected at shutdown. * mail-threads.c (update_active_views): Update for folder_browser_factory_get_control_list change to EList. * folder-browser-factory.c: Turn control_list into an EList so that we can safely remove items from it while it's being iterated (which will happen as FolderBrowsers are destroyed at shutdown while the thread code is trying to update the status bars). (control_destroy_cb): Just destroy the folder_browser. (browser_destroy_cb): New callback for FolderBrowser destroy. Remove the control from control_list here instead of control_destroy_cb, because the controls don't seem to get destroyed reliably... * component-factory.c: Clean up stuff. (factory_destroy): Get rid of this. (owner_unset_cb): Schedule an idle handler to quit. (idle_quit): Wait for all of the FolderBrowsers to be destroyed and then destroy the storages and quit. * mail-summary.h (create_summary_view): Fix prototype 2000-12-06 Jeffrey Stedfast * mail-config.c (mail_config_folder_to_cachename): Use e_filename_make_safe (which used to be e_str_make_safe). * mail-display.c (make_safe_filename): And here. * message-list.c (message_list_drag_data_get): Here too. 2000-12-06 Dan Winship * mail-local.c (cleanup_register_folder): Run the folder_changed code on message_changed as well, so the unread message counts update as messages are read. * folder-browser.c: Remove bits of filter-on-demand and toolbar bug workaround cruft that don't do anything useful any more. * mail-ops.c (cleanup_load_folder): unref the ref we added in setup_load_folder. 2000-12-05 Jeffrey Stedfast * mail-display.c (write_data_to_file): Use a charset filter to make sure the data is written out in the charset it was meant to be in instead of UTF-8. * mail-format.c (mail_format_raw_message): Don't use the raw message body as the format argument, use "%s" instead. If the raw message contains %'s then it will segfault otherwise. 2000-12-04 Dan Winship * mail-config-gui.c (service_page_item_new): Fix a typo so that toggling the "remember password" checkbox will activate the "OK" button if it was inactive. 2000-12-05 Ettore Perazzoli * mail-vfolder.c (vfolder_create_storage): Updated the call to `evolution_storage_new()': pass NULL for @toplevel_node_uri. * component-factory.c (add_storage): Updated the call to `evolution_storage_new()': pass NULL for @toplevel_node_uri. 2000-12-04 Jeffrey Stedfast * subscribe-dialog.c (setup_subscribe_folder): Use info->full_name rather than info->name so that we get the namespace part of the folder path as well. 2000-12-04 Ettore Perazzoli * folder-browser-factory.c: Updated to define verbs "MessageForwardInlined" and "MessageForwardAttached" instead of "MessageForwardInline" and "MessageForwardAttach". * folder-browser.c (on_right_click): Make forwarding as an attachment the default. * mail-callbacks.c (forward_inlined): Renamed from `forward_msg'. (forward_attached): Renamed from `forward_attach'. * mail-callbacks.h: Updated accordingly. 2000-12-01 Dan Winship * session.c (mail_session_remember_password): Writes out passwords (to .gnome_private) in our patented proprietary "Best Awesome Super Encryption 64" ("BASE64") format which could not possibly ever be cracked by even the most cryptographically knowledgeable five-year-olds. (mail_session_init): Load remembered passwords at startup. (mail_session_forget_passwords): Erase them from disk as well as memory. * mail-config.c: Add "remember_password" field to MailConfigService. (mail_config_write_on_exit): Call mail_session_remember_password for services with "remember_password" set. * mail-config-gui.c: Add "remember password" checkbox to the dialogs, and make it appear and disappear as appropriate. * component-factory.c (mail_load_storages): Unref the store regardless of whether or not we're using it, so we don't leak references to non-storage stores. 2000-12-01 Jeffrey Stedfast * message-list.c (e_mail_address_new): Perform better error-handling. 2000-12-01 Radek Doulik * mail-ops.c (mail_op_report_status): use mail_op_set_message_plain * mail-threads.c (mail_op_set_message_plain): plain version of mail_op_set_message, doesn't use printf, passes message untouched, use set_message (mail_op_set_message): set_message (set_message): helper function 2000-11-30 Jeffrey Stedfast * mail-ops.c (cleanup_fetch_mail): Don't display a dialog, instead inform the user that there was no new mail by setting a status message. * message-list.c (message_list_drag_data_get): Use the new e_str_make_safe function. * mail-display.c (make_safe_filename): And here. * mail-config.c (mail_config_folder_to_cachename): Here too. 2000-11-30 Not Zed * mail-ops.c (cleanup_load_folder): Set threaded view before setting the folder (cleanup some flash ons tartup). * message-list.c (message_list_init): Initialise a mempool for uid string storage. (new_id_from_uid): Added messagelist arg, allocate strings from uid_pool. (new_id_from_subject): Same. Fixed all callers. (remove_node_diff): Dont free uid here. (build_flat_diff): Nor here. (clear_tree): Flush the mempool, rather than freeing the id's directly. (free_tree_ids): Removed, no longer required. (free_tree_ids): Likewise. (message_list_init): Dont connect to the table destroy signal anymore to free the uid table. (message_list_destroy): Free the uid pool here. (*): Use accessors for messageid stuff. (content_is_attachment): Removed, no longer required. (ml_tree_value_at): Get the attachment flag directly from the summary. (ml_tree_value_at): For 'fake' nodes, try and do something better than "?" for from, to, and size. (subtree_size): New function, add up the total size of a subtree. (subtree_earliest): Get the earliest date from a subtree. (ml_tree_value_at): Return earliest date sent/received for fake nodes. (ml_tree_value_at): Return something to mark a fake subject line as a fake subject, although i dont know, i guess this buggers up sorting ... (subtree_size): Check the info node is still there. (subtree_earliest): Same here. (subtree_unread): And here. The info node might vanish if the folder has changed/is changing and we try and redraw stuff while its doing it. (message_list_drag_data_get): Use accessors. 2000-11-29 Jeffrey Stedfast * message-list.c (message_list_drag_data_get): Implement. (message_list_init): Connect the d&d signal. * mail-ops.c (do_save_messages): Use camel a bit more to help us out. Don't create the file ourselves, treat it as a CamelFolder so we don't have to worry about formatting. 2000-11-29 Dan Winship * main.c (main): Remove no-longer-needed e_unicode_init. * mail-tools.c (mail_tool_quote_message): Fix the allocation here (again) and put a comment explaining it. (Fixes a crash when replying.) 2000-11-28 Dan Winship * component-factory.c (owner_set_cb): Wait until after setting up the local storage to find the Drafts/Outbox/Sent folders. * mail-ops.c (do_setup_folder): Use the file: store rather than mbox:. 2000-11-28 Jeffrey Stedfast * folder-browser-factory.c: Added the SaveAs bonobo menu verb thingy. * mail-callbacks.c (save_msg): New callback for saving messages. (save_msg_ok): * folder-browser.c (on_right_click): Add a Save Ass menu item. * mail-ops.c (cleanup_save_messages): Save all emails to the path given. 2000-11-28 Dan Winship * mail-local.c (cleanup_register_folder): Fix the initial unread counts after the last patch. 2000-11-27 Dan Winship * mail-local.c (local_folder_changed): This needs to run from the main thread, not the camel thread, so add a proxy signal handler to call mail_op_forward_event. Fixes hangs (eg bugzilla #909). 2000-11-27 Jeffrey Stedfast * mail-display.c: Removed some unecessary debugging printf's 2000-11-27 Dan Winship * mail-config-druid.glade: Revert the new druid for now, until the corresponding code is done, so that the druid will work again. 2000-11-21 Iain Holmes * mail-config-gui.c (mail_config): Don't use the "delete-event" signal. 2000-11-21 Iain Holmes * mail-display.c (pixbuf_for_mime_type): free fm_icon. * component-factory (summary_fn): Remove the configure param. (factory_destroy): Made into a generic function so that the summary_factory can be ref-counted as well as the normal factory. 2000-11-21 Dan Winship * Makefile.am: add GPGME_CFLAGS and GPGME_LIBS 2000-11-21 Jeffrey Stedfast * mail-config.c (mail_config_view_source): New function to return if user wants to view message source. (mail_config_set_view_source): New function to set whether the view wants to view source. * mail-ops.c (mail_do_view_message_sources): Removed. We're not gonna view-source this way anymore. * folder-browser-factory.c: Removed the ViewSource bonobo verb from the Message menu. (control_activate): Added ViewSource. * folder-browser.c (on_right_click): Removed Message menu item to view message source. (folder_browser_toggle_view_source): New callback to set whether or not the MailDisplay shows the raw message or the pretty-ified message. * mail-callbacks.c: Removed view_source. * mail-display.c (redisplay): If toggle_raw is set then display the raw message else display the pretty formatted message. (mail_display_redisplay): New function to force the redisplay of a message. * mail-format.c (mail_format_raw_message): New function to write the raw message data. 2000-11-21 Not Zed * mail-vfolder.c (vfolder_uri_to_folder): IF we dont find a source, clear the exception and ignore it silently. for e.g. if the user reconfigured their mailboxes and one of them no longer exists. 2000-11-21 Radek Doulik * mail-display.c: #include 2000-11-21 Not Zed * message-thread.[ch]: Removed. No longer serves a purpose. * Makefile.am (evolution_mail_SOURCES): Removed message-thread.[ch]. * message-list.c (build_subtree): (node_equal): (add_node_diff): (build_subtree_diff): (do_regenerate_messagelist): (cleanup_regenerate_messagelist): Changed to use camel-folder-thread. (message_list_set_folder): If we get set a new folder, unhook any events before unrefing the folder too (the folder is never reset currently, but this would cause problems). (subtree_unread): Check for uid null, wont crash, but its a bug. (ml_tree_value_at): If the uid is null, then fake an obviously bad line. (build_subtree): Yeah well, we can't like freeze/thaw here, because this is called recursive, and freeze/thaw isn't recursive, like pre model and post model change was. (build_tree): Maybe we can try it here, although i dont think it'll help much. (build_flat): And this is also a tree. yes a tree. (build_tree): Added changes arg. If set, then try the 'diff' approach, unless the tree is already empty. (message_list_set_threaded): Dont clear the tree here. (message_list_set_search): Or here. 2000-11-20 Not Zed * message-list.c (save_node_state): Save out the md5 hash of the messageid as hex, since thats all we have for those nodes. (build_subtree): Expand the messageid to a hex string first, then check it. (add_node_diff): And the same here. * message-thread.c (thread_messages): Changed for changes to messageid/references items. (id_hash, id_equal): New functions to hash on the binary message id hash. (thread_messages): removed some more no longer used dead code. 2000-11-20 Jeffrey Stedfast * message-list.c (e_mail_address_compare): New comparison function that will replace address_compare if/when we ever go to save the preparsed addresses in the ETable rather than parsing them each time. Also fixed it so that we should get better sorting when addresses don't contain name parts (I was checking for NULL but not '\0'). (address_compare): Use e_mail_address_compare. 2000-11-19 Peter Williams * mail-ops.c (update_changed_folders): Instead of making the CORBA call in the dispatch thread, store the new display names and have cleanup_fetch_mail make the CORBA calls. Fixes deadlocks. (cleanup_fech_mail): Loop through the update_infos and make the CORBA calls. (setup_fetch_mail): Clear some new data items. 2000-11-17 Jeffrey Stedfast * mail-format.c (mail_generate_reply): Use the new quote_message function and make it start with "On %s, %s wrote:" since people seem to want that. * mail-ops.c (cleanup_forward_messages): Use the new quote_message function. * mail-tools.c (mail_tool_quote_message): New convenience function to quote a message body (since both the reply and forward code do similar quoting) 2000-11-17 Not Zed * message-list.c (message_list_destroy): Before we destroy ourselves, unhook ourselves from the folder update events. Should fix a common crash on exit case. 2000-11-16 Jeffrey Stedfast * folder-browser-factory.c: Added the MessageViewSource bonobo menu verb. * mail-ops.c (mail_do_save_messages): New async function to save messages as individual files in a given path. 2000-11-15 Jeffrey Stedfast * folder-browser-factory.c: Added a new Forward as Attachment bonobo menu item verb. * mail-view.c (view_forward_msg): Updated to reflect changes to mail_do_forward_message(). It now forwards the message without attaching it - is this what we want? * mail-ops.c (mail_do_view_message_sources): New async function to display message source dialog windows. (setup_forward_messages): If we were asked not to forward the message(s) as attachment(s) and the user chose more than a single message, then default to making each message an attachment. (cleanup_forward_messages): If we aren't forwarding the message as an attachment, then quote the text and set the composer's body with it. * mail-callbacks.c (view_source): New callback to view the message source of all messages that are currently selected. (forward_attach): New callback to forward a message as an attachment (forward_msg is now for forwarding a message without it being an attachment). (forward_message): Convenience function for forwarding messages. 2000-11-13 Jeffrey Stedfast * subscribe-dialog.c (subscribe_do_subscribe_folder): Take a 'subscribe' argument so that this can function as a subscribe AND unsibscribe method. (describe_subscribe_folder): Updated. (do_subscribe_folder): Updated. (cleanup_subscribe_folder): Updated. (subscribe_folder_info): Pass along a TRUE as the 'subscribe' param. (unsubscribe_folder_info): Pass along a FALSE as the 'subscribe' param. 2000-11-13 Christopher James Lahey * message-list.c: Removed some e_table_model calls and replaced them with e_tree_model calls. 2000-11-12 Dan Winship * mail-local.c (mail_do_register_folder): Do this the normal way rather than calling mail_operation_wait_for_finish. There was some reason for it originally, but it no longer applies. This makes adding new folders from the folder selection dialog no longer hang. 2000-11-12 Jeffrey Stedfast * mail-ops.c (do_filter_ondemand): Sync the source folder. 2000-11-11 Matt Bissiri * evolution-mail.oafinfo: * mail-threads.c: (retrieve_shell_view_interface_from_control): Update the remaining "IDL:Evolution*" to "IDL:GNOME/Evolution*" to sync up with yesterday's IDL re-scoping. 2000-11-10 Michael Meeks * Makefile.am ($(EVOLUTION_MAIL_CORBA_GENERATED)): sort include order. 2000-11-09 Jeffrey Stedfast * subscribe-dialog.glade[.h]: New glade file for possibly using to create the subscribe dialog. 2000-11-08 Radek Doulik * mail-format.c (mail_generate_reply): likewise * mail-callbacks.c (create_msg_composer): added send_html arg to e_msg_composer_new_with_sig_file call 2000-11-07 Jeffrey Stedfast * mail-search-dialogue.c (mail_search_dialogue_construct): Allow rule part to expand when the user resizes the dialog. 2000-11-07 Jeffrey Stedfast * folder-browser.c (search_save): Don't handle custom searching anymore... we don't want this. (search_full): Same. (folder_browser_search_menu_activated): Set the search entry widget sensitive. (folder_browser_search_query_changed): Same. 2000-11-07 Jeffrey Stedfast * folder-browser.c (search_full_clicked): Updated to use the ESearchBar object rather than the previously used search widgets. (search_full): Same. (search_save): Same. Also use enums to make it a little easier to read now that we have to have enums anyway. (folder_browser_search_menu_activated): New ESearchBar menu callback. (folder_browser_search_query_changed): New ESearchBar query callback. Replaces search_set() (folder_browser_clear_search): Updated to use the ESearchBar object rather than the previously used search widgets. (folder_browser_gui_init): Don't hand construct a search widget, use the new ESearchBar convenience widget. * mail-ops.c (cleanup_load_folder): Updated to reflect changes to FolderBrowser. 2000-11-07 Jesse Pavel * mail-display.c (pixmap_press): modified some of the EPopupMenu structures to account for differences in the popup menu API (as informed by Jeff. (on_object_requested): passed the user's default email address to the iTip control. 2000-11-07 Ettore Perazzoli * Makefile.am (INCLUDES): Add the composer dirs. 2000-11-07 Not Zed * mail-display.c (on_object_requested): God, I sure wish people would listen when i'm saying i'm changing and API. I mean I even mailed everyone and everything. Can't see any changelog either. 2000-11-06 Not Zed * mail-autofilter.c (rule_from_message): Updates for api changes. * mail-tools.c (mail_tool_generate_forward_subject): Fixed for api changes. Sigh, whoever wrote the multithread code of the mailer, had little idea. You can't just lock for getting a const value, until you are finished with it, cause the owner still owns it. Fixed this too. Yuck, what a horrid forwarding format, can we change this, or make it configurable? The mail headers show who forwarded it, we dont need to duplicate it in that UGLY subject. * mail-format.c (write_field_to_stream): Removed some jeffness. dont g_strdup stuff we dont need to, and remove the value_is_encoded thing since we can get the unencoded address now. (write_address): New function to write an address field. (write_headers): Uses write_address to write addresses, cleaner, fixed the god-awful unreadable indenting too. (handle_text_plain): Use a 'smarter' printf format, so we dont need to allocate and copy substrings unecessarily (esp since they're about to be allocated any copied another few times anyway *sigh*). (write_field_to_stream): Commented out the isprint check, which afaik serves no purpose. (list_add_addresses): New function to build a list of display-ready addresses. Although I think the composer then uses these as internet-ready addresses. It should probably take a list of CamelAddress's if thats what it wants. (mail_generate_reply): Cleaned up the address list creation stuff a heap, and fixes for camel api changes. Also fixed a small memory leak as a side effect (fulladdr wasn't freed if it was the same as the sender). * mail-display.c (on_object_requested): Changed for interface changes to the from address. I think passing the encoded (internet version) of the address is right here. 2000-11-06 Jeffrey Stedfast * folder-browser.c (on_right_click): Move filter stuff into a submenu of the popup menu. 2000-11-06 Jesse Pavel * mail-display.c: used Camel to parse the full address before passing the email address to my iTip control. 2000-11-06 Dan Winship First draft of folder tree unread message indication for /local mail folders. * mail-local.c: Add a new CamelStore subclass, MailLocalStore, which attaches to an Evolution_LocalStorage on one side and CamelSession on the other, and keeps track of local folders. Some of this code was previously in mail-local-storage.c, which no longer exists. (local_reconfigure_folder, etc): Various mail_op-related cleanups, and wrap d() around a bunch of printfs. * mail-tools.c (mail_tool_get_local_inbox_url, mail_tool_get_local_movemail_url): Removed (mail_tool_get_local_inbox): Simplified. (mail_tool_do_movemail): Remove unused dest_url variable. (mail_tool_uri_to_folder): Simplify. Now down to two cases (vfolder, and everything else). * component-factory.c (owner_set_cb): Pass evolution_dir to mail_local_storage_startup. * Makefile.am (evolution_mail_SOURCES): Remove mail-local-storage.[ch] * mail-summary.c: Remove mail-local-storage.h include 2000-11-06 Kjartan Maraas * mail-autofilter.c: Fix up #include * mail-crypto.c: Same here. * mail-search-dialog.c: Here too. * main.c: Fix indentation of #ifdef * message-thread.c: Fix include. 2000-11-06 Jeffrey Stedfast * mail-callbacks.c (delete_msg): Don't invert the flag. (undelete_msg): Same (when multiple messages are selected). 2000-11-06 Jeffrey Stedfast * folder-browser-factory.c: Updated to have the same menu items as the new right-click menu - eventually these 2 menus should be the same. * folder-browser.c (on_right_click): Now correctly handles the case of multiple selection. * mail-callbacks.c (enumerate_msg): Make public so it can be used in other source files (it's a useful function!) 2000-11-05 Jeffrey Stedfast * folder-browser.c (on_right_click): Added an "Undelete" option to the right-click menu and also set a mask so it was only selectable if the message is marked as deleted. Also set a mask for "Mark as Read" and "Mark as Unread". * mail-callbacks.c (undelete_msg): New callback to undelete messages. 2000-11-03 Dan Winship * message-list.c (cleanup_regenerate_messagelist): don't free the MessageList search when it's being reused 2000-11-03 Jeffrey Stedfast * mail-local.c (mail_local_map_uri): Don't show the passwd in the url string. (mail_tool_local_uri_to_folder): Same. (do_reconfigure_folder): Same. 2000-11-03 Jeffrey Stedfast * Makefile.am: Added new header files. * component-factory.c (owner_set_cb): s/session_init/mail_session_init * session.c: Renamed public functions to mail_session_*. FIXME: Rename session.c to mail-session.c * folder-browser-factory.c: #include "mail-callbacks.h", #include "mail-session.h" and replace forget_passwords with mail_session_forget_passwords * mail.h: Move session prototypes to mail-session.h, Move mail-crypto prototypes to mail-crypto.h, Move mail-callback prototypes to mail-callbacks.h * mail-session.h: New header file containing public prototypes for session.c * mail-format.c: #include "mail-crypto.h" * mail-view.c: * folder-browser.c: #include "mail-callbacks.h" * mail-crypto.h: New header file containing public prototypes for mail-crypto.c * mail-callbacks.h: New header file containing public prototypes for mail-callbacks.c * message-list.c (message_list_get_layout): Set useful defaults. (message_list_setup_etable): Don't set the Outbox defaults on a folder just because it doesn't have a corresponding saved file. 2000-11-03 Dan Winship * mail-config-gui.c (service_page_item_new): url_flags are now on CamelProvider, not CamelService * main.c: * subscribe-dialog.c: * mail-threads.c: Kill warnings 2000-11-03 Federico Mena Quintero * Makefile.am: Clean the idl-generated files properly. 2000-11-03 Not Zed * mail-view.c: Added mail-display.h. * mail-autofilter.c: Removed unecessary headers. Who ran indent over this code? Sigh. * mail-ops.c (display_message_input_s): Added messagedisplay. (mail_do_display_message): Added messagedisplay arg. (mail_do_display_message): Dont bother doing another thread when we know we dont have a uid. (): Added folder-browser.h to headers. Sigh. * folder-browser-factory.c (control_activate): Setup the viewthreaded callback to the folder_browser function. * folder-browser.c (my_folder_browser_init): Connect to right_click of etable of the messagelist here. (on_right_click): Changed for argument changes. (folder_browser_toggle_threads): Changed to take a fb, and to set threaded mode on the messagelist. (my_folder_browser_init): Connect also to the double_click signal. (my_folder_browser_init): Connect to the message_selected signal of the message_list. (on_message_selected): Signal handler for message selected. (my_folder_browser_init): Fix for change to message_list_new(). * message-list.h: Dont include folder-browser.h. (message_list_toggle_threads): Moved into folder-browser.h. (struct _MessageList): Removed folderbrowser. * mail.h: Dont include folder-browser.h here either, but mail-types.h instead. Moved prototypes moved into folder-browser.c into folder-browser.h. (vfolder_*, filter_*). * mail-display.h: Dont include folder-browser.h here, but mail-types.h and specific camel headers. * message-thread.c (sort_node): Invert the sort order logic so the list is sorted in mailbox order, not reverse mailbox order. * message-list.c (free_tree_ids): Fix a merge foo. (remove_node_diff): Removed unused row argument. Fixed callers/prototype. (clear_tree): pre_change on the removal of the root node. (build_flat): Only perform pre_change if we are rebuilding the whole lot. For incremental change let etable do its thing. (build_tree): Likewise for building the tree view. If making incremental updates, do them as we build it. (vfolder_subject): (vfolder_sender): (vfolder_recipient): (filter_subject): (filter_sender): (filter_recipient): (filter_mlist): (on_right_click): Moved to folder-browser.c, where they belong. (message_list_init): Dont connect to right_click anymore. (message_list_toggle_threads): Moved to folder-browser.c, renamed. (on_double_click): Moved to folder-browser.c (on_click): Set the flags directly, rather than in anothre thread, which is just not necessary. (message_list_class_init): Added a new signal 'message_selected', to indicate when a message was selected. (on_cursor_change_idle): Emit a signal, rather than directly triggering the display update. (select_row): Removed, no longer used. (idle_select_row): And this too. (select_msg): Removed as well. (message_list_select): Emit a signal, rather thandisplaying/clearing the mail-display directly. (mark_msg_seen): Moved to folder-browser.c (message_list_new): Removed folderbrowser argument. 2000-11-02 Jeffrey Stedfast * message-list.c (on_right_click): Sync with message menu. Addresses bugzilla bug #778. 2000-11-02 Christopher James Lahey * message-list.c: Turn on draw grid for the main ETable (this may not be working in ETable itself.) 2000-11-01 Jeffrey Stedfast * mail-threads.c (mail_op_set_message): fmt argument should be const. 2000-11-01 Dan Winship Make "Get Mail" even more functional on IMAP (scans all folders), and do a first cut at folder tree highlighting (for IMAP/news only). * mail-ops.c (do_fetch_mail): For imap (sigh, we *still* shouldn't be hardcoding that), rescan the store's folder tree, rescan each changed folder for new messages, and update the shell folder tree. (do_scan_subfolders): Update for component-factory.c changes, and set folder display names and highlights appropriately when building the storage. * component-factory.c (add_storage): Make this static (was mail_add_new_storage). Use camel_service_get_name for the name rather than url->host. (Among other things, this lets you use a single machine as both an IMAP server and a news server.) (mail_lookup_storage): Hash storages based on their CamelStore rather than the URL. (factory_destroy): Disconnect each of the CamelStores in the storages_hash. * subscribe-dialog.c (cleanup_subscribe_folder): * mail-vfolder.c (vfolder_refresh): Pass "highlighted" flag to evolution_storage_new_folder 2000-11-01 Jeffrey Stedfast * mail-ops.c (mail_op_report_status): Don't call the default logging function. (do_fetch_mail): Set the logfile and don't pass the logfile to filter_driver_set_status_func - it's purpose has been altered. (do_filter_ondemand): Same. 2000-11-02 Not Zed ** Merged in camel-incremental-branch. * mail-format.c (mail_get_message_body): Jeff! Sigh. We should definetly not be strduping the content, it has already been copied and duplicated. Look at get_data_wrapper_text. 2000-11-01 Chris Toshok * subscribe-dialog.h: add fields search_entry and search_top. * subscribe-dialog.c: add mail-ops.c style async operations for getting the store (to remove deadlock in the case where a auth dialog is dismissed at startup and then the subscribe dialog is brought up), and subscribing/unsubscribing to folders. One case remains, that is getting the list of all folders. (subscribe_search): flesh out this function (build_tree): use the search_top field so we can search for groups/folders. (subscribe_dialog_destroy): free search_top. (subscribe_dialog_construct): init search_top. 2000-10-30 Iain Holmes * mail-summary.c (generate_folder_summaries): Fix spelling :) Set folder->uri to NULL for the Inbox. 2000-10-26 Iain Holmes * mail-summary.c (generate_html_summary): Add view:// uris to switch the display to that folder. 2000-11-01 Jeffrey Stedfast * folder-browser-factory.c: Hmmm, someone can't spell Filder, er...I mean Filter ;-) 2000-11-01 Jeffrey Stedfast * mail-autofilter.c (rule_from_message): If the name is NULL or empty, then set the title to "Mail from
". Closes bugzilla bug #777. Also when filtering on Subject, set the file name to "Subject is " rather than just "" - I think this is a bit more user-friendly. (strip_re): Use unsigned char when passing to is() functions from ctype.h. (rule_add_subject): Use the "is" rule instead of "contains". 2000-11-01 Jesse Pavel * mail-display.c: added property bag support for Bonobo controls, support which helps only the iTip control, currently. 2000-11-01 Dan Winship * mail-display.c (pixbuf_gen_idle): Lots of fixes and simplifications. Should get rid of the "missing icon" problem. There is still a problem with some images failing to get thumbnails, even though they display correctly. (pixbuf_for_mime_type): New function to try really hard to get the right icon for a MIME type, including looking in mc and nautilus's pixmap directories. (on_object_requested): Always use pixbuf_gen_idle, even for non-image types, to prevent code duplication. 2000-10-31 Jeffrey Stedfast * mail-format.c (mail_get_message_body): Shouldn't we be strdup'ing the content? This seems to fix the memory corruption problems. (mail_generate_reply): Make sure that the last char in the generated reply text is '\0' (when body text doesn't end with a \n, a random char will appear otherwise). 2000-10-31 Dan Winship * mail-config-gui.c (do_test_service): Update for camel_service_disconnect change. 2000-10-31 Jeffrey Stedfast * mail-autofilter.c (filter_gui_add_for_mailing_list): Match "is" rather than "contains" now that we have the "is"-rule. 2000-10-30 Dan Winship * mail-config-gui.c (config_do_query_authtypes): Redo this so that it works for all pages, not just the first page. (Now that this is finally working again, I expect Anna to finish her redesign in the next 15 minutes.) (service_page_item_new): Fix up the sizing of the Auth line to look more like everything else. 2000-10-29 Dan Winship * mail-tools.c (mail_tool_uri_to_folder): Simplify this a lot by making IMAP and NNTP use the same code, now that the IMAP namespace doesn't need special magic handling. * message-list.c (mail_do_regenerate_messagelist): Don't try to regenerate the message list if there is no folder. (The Bonobo UI code will call this as the callback for the "Threaded View" command.) * mail-ops.c (do_fetch_mail): Sync the folder before refreshing so we don't lose flag settings. 2000-10-27 Jeffrey Stedfast * mail-callbacks.c (composer_send_cb): Check to make sure that the recipient list is neither NULL nor a 0-length list of addresses and pop up a dialog letting the user know why we are not allowing him/her to send the message. 2000-10-26 Dan Winship * mail-display.c (write_data_to_file): Don't destroy a dialog after run_and_close'ing it. 2000-10-26 Jeffrey Stedfast * mail-callbacks.c (composer_send_cb): Check for the TO recipient list being NULL and don't send. 2000-10-25 Jeffrey Stedfast * mail-ops.c (do_send_mail): Don't forget to unref the FilterDriver. * mail-callbacks.c (apply_filters): New callback for applying on-demand filters. (removed the old on-demand filters callback). * mail-ops.c (do_filter_ondemand): Rewrote to apply "incoming" filters to all selected messages. (mail_do_filter_ondemand): No longer takes a FilterContext argument or a destination folder argument (why did we ever need this last one??) but now takes a uids argument. * folder-browser-factory.c: Add a MessageApplyFilters menu item. 2000-10-25 Iain Holmes * mail-summary.[ch]: Updated for the new ExecutiveSummary code. * Makefile.am: Added the summary files and the evolution-services CFLAGS and LIB stuff. * component-factory.c: Re-enabled the summary stuff. 2000-10-25 Dan Winship * main.c (main): Pass send/postpone signal handler functions to evolution_composer_factory_init. 2000-10-25 Jeffrey Stedfast * subscribe-dialog.c (subscribe_select_all): Implemented. (subscribe_invert_selection): (was unselect_all) Implemented. 2000-10-25 Dan Winship * message-list.c: Add a "flagged" column, based on the Camel "flagged" flag, for assigning an arbitrary "hey, I care about this" flag to a message. (ml_tree_set_value_at): Remove (ml_tree_is_cell_editable): No, it's not. (on_click): Handle the read/unread and flagged fields via the click handler. Among other things, this makes it not select a message when you change its read status. 2000-10-24 Dan Winship * subscribe-dialog.c (folder_info_subscribed, subscribe_folder_info, unsubscribe_folder_info): Don't prepend "/" to the folder's full_name. Deal with hierarchy in the EvolutionStorage tree better. (storage_tree_path): Helper function to build a storage path from a CamelFolderInfo. 2000-10-23 Dan Winship * *: Add some missing _()s and N_()s. 2000-10-23 Dan Winship * Makefile.am (INCLUDES): Update EVOLUTION_LOCALEDIR. 2000-10-23 Jeffrey Stedfast * mail-ops.c (do_send_mail): Apply outgoing filters to the message. 2000-10-23 Christopher James Lahey * message-list.c: Fixed a possible error in row numberings. This needs to be changed quite a bit anyway, but this should make things slightly nicer in some cases. 2000-10-23 Christopher James Lahey * folder-browser.c: Made the top of the folder browser a little prettier. * mail-display.c, mail-vfolder.c: Made more dialogs resizable. 2000-10-23 Jeffrey Stedfast * mail-autofilter.c (filter_gui_add_from_message): Don't forget to set the rule source! (eg "incoming", "demand", or "outgoing") 2000-10-22 Ettore Perazzoli * message-list.c (message_list_init): Always display the vertical scrollbar. * mail-display.c (mail_display_new): Always display the vertical scrollbar. 2000-10-20 Jeffrey Stedfast * mail-config.h: #include 2000-10-20 Michael Meeks * mail.h: s/BonoboUIHandler/BonoboUIComponent/ * mail-callbacks.c (run_filter_ondemand): ditto. * session.c (forget_passwords): ditto. 2000-10-20 Dan Winship * evolution-mail.oafinfo: Declare composer factory. * main.c (main): Initialize it 2000-10-19 Chris Toshok * message-list.c (nuke_uids): e-tree-model is now opaque. use the accessor to get the root node. 2000-10-19 Jeffrey Stedfast * mail-callbacks.c: #include "mail-vfolder.h" (vfolder_edit_vfolders): Don't call the dummy vfolder_edit function. * folder-browser-factory.c: s/VFolderEdit/SetVFolder 2000-10-19 Dan Winship * mail-ops.c: (do_fetch_mail): For an imap store, just refresh the INBOX. * folder-browser-factory.c (control_deactivate): Don't sync non-existent folders. * message-list.c (nuke_uids): Don't traverse non-existent trees. 2000-10-19 Ettore Perazzoli * Makefile.am (glade_messages): New. (EXTRA_DIST): Add `$(glade_messages)'. 2000-10-19 Dan Winship * mail-ops.c: Clean up some old #if 0 code. 2000-10-19 Jeffrey Stedfast * mail-format.c (mail_generate_reply): Get the MailConfigIdentity *before* we create a new composer object so that we can set the signature file. 2000-10-18 Michael Meeks * folder-browser-factory.c (register_ondemand): kill. (create_ondemand_hooks): die. (control_activate): remove hook. * test-mail.c (create_container): kill old UI handler. 2000-10-18 Christopher James Lahey * message-list.c: Fixed some column widths. 2000-11-02 Not Zed * message-list.c (get_message_info): Call get_message_uid to get the uid, save some duplicated code. (folder_changed): Handle the case of a NULL changes input. * message-thread.c (thread_messages): Removed pointless variable/assignment 'container'. (thread_messages): Try and cope with duplicate message id's. 2000-11-01 Not Zed * mail-callbacks.c (main_select_first_unread): Changed to use 0 as the first row to select a message. * mail-ops.h (mail_do_regenerate_messagelist): Removed from header. This function is no longer public since it is really an internal message-list function. * folder-browser.c (search_full_clicked): Call the set_search() function, rather than messagelist_rebuild, which is going private. (search_set): Same here. (folder_browser_clear_search): And here. (etable_key): Call message_list_select() instead of message_list_home and message_list_end. Removing some odd code duplication. * message-thread.c (do_thread_messages): Moved the mail lock to here, rather than locking for each message lookup (which is useless anyway). This is still not correct either, as the tree references folder data ... but a bit better than it was. (thread_messages): Removed the mail tool lock stuff, lock in higher functions. * message-list.h: Added a threaded indicator to the message list itself. (threaded_view): removed a mystery variable. * message-list.c (do_regenerate_messagelist): Made the code a little more readable. (build_tree): Fixed argument to be a thread_messages struct, not a container. (cleanup_regenerate_messagelist): Free changeinfo. (mail_do_regenerate_messagelist): If we are adding changes to a flat view, we dont need to goto the other thread at all, so process immediately. (message_list_toggle_threads): Clear the tree if we're changing the view mode. (message_list_toggle_threads): And reset the rowmap, since it is no longer valid. (build_tree): If we are building into an already empty tree, just build into that (probably irrelevant optimisation). (build_subtree): Build hte subtree in the same order as we got it, not inverted order. (message_list_set_threaded): New function to select the threaded view/flat view. (mail_do_regenerate_messagelist): Removed references to mail_config, get it from the ml->threaded var instead. (message_list_destroy): No longer free the key data for the uid_rowmap. (new_id_from_uid): Convert a uid string into an id string. (new_id_from_subject): Likewise for subject strings. 'id' strings replace the 'uid:' and 'subject:' stuff with accessors and macros and use less memory and is more readable. (id_is_uid): macro to check if an id string is a uid. (id_uid): Returns the uid part of a uid id string. (id_subject): Returns the uid part of a subject id string. (build_subtree): Use the new id functions, and dont duplicate the uid in the uid rowmap, but just reference it from the tree node. (node_equal): Use new id functions. (add_node_diff): And here too. (remove_node_diff): And here. Also remove the uid from the rowmap, and dont free it anymore. (get_message_info): And here. (get_message_uid): And here. (subtree_unread): And here. (ml_tree_value_at): " (ml_tree_set_value_at): Noted a memory leak. do_flag_messages() doesn't free the contents of the uid array, just the uid array (well that i can tell, teh code has more problems anyway). (ml_tree_set_value_at): And fix the id accessors. (save_node_state): " (build_flat): Use id macros/functions. Dont alloc memory for hash key. (build_flat_diff): Use id macros. (build_flat_diff): Remove the hash table entry before freeing its key data (in the node). (free_key): Removed. Keys are no longer alloc'd. (clear_tree): When we clear the tree, also clear the uid_rowmap, as it is no longer valid (or contains allocated keys!). (free_tree_ids): Renamed from nuke_uids. (free_ids_cb): Renamed from nuke_uids_cb. (free_tree_ids): Changed arg to be a ETreeModel directly. (ml_tree_value_at): Map id to subject using the right macro. (free_tree_ids): Check we have any nodes to traverse first. (build_flat): Insert to row -1 to append the nodes (faster). (remove_node_diff): Only remove the uid rowmap entry if it is referencing this node (i.e. the key string is the same key string, not just a matching key string). (add_node_diff): Remove the uid rowmap entry before inserting a new one to force the key to be replaced. This is required as the tree may temporarily contain duplicate messages during the rebuilding phase. (message_list_set_search): New function, set the search string. Only redo the search if it has changed, etc. (mail_do_regenerate_messagelist): Made static. There is no need for external code to call this. (message_list_set_folder): NOP if the new folder is the same. (message_list_set_folder): Clear the tree before rebuilding it. (message_list_select): Ok, this wins the award for 'most bizarre interface'. Changed the start row to mean the end of the list if we supply -1, rather than the start of the list. Also fixed the endpoints (it would never select message 0 if searching backwards). (idle_select_row): Changed start row to 0 from -1. (message_list_end): Removed. (message_list_home): Removed. (go_to_message): Removed. message_list_select can do this. (message_list_select): Check that direction is one of the valid ones, otherwise we could be thrown for loops. 2000-10-31 Not Zed * message-list.c (node_equal): Compares an etree node with a message-thread node to see if they point to the same object. (add_node_diff): Adds a new thread node to the etree. (remove_node_diff): Removed an etree node, freeing any additional data. (build_subtree_diff): Takes an existing etree definition, and a new thread definition and makes the etree match, using as few operations as possible. (do_regenerate_messagelist): No longer free/clear the uid/rowmap here. (regenerate_messagelist_input_t): Added a tree field - are we building a tree view? (regnerate_messagelist_data_t): Added a tree field, if we built a tree result. Added a changes parameter, for building diff's after search/etc. (mail_do_regenerate_messagelist): Setup the tree indicator. (build_flat_diff): Apply a changeset to a message list. (build_flat): Added a changes argument, if present, use build_flat_diff() to build the list. (do_regenerate_messagelist): If we are generating a threaded view, build the threaded list here, rather in another separate invocation. (cleanup_regenerate_messagelist): Call build_tree directly on the threaded list. (message_list_init): Init the uid_rowmap hash table here instead of somewhere odd. (message_list_destroy): Assume uid_rowmap exists. (do_regenerate_messagelist): Remove the code here that is messing with the message list data (search/uid_rowmap). We're in a different thread boys ... 2000-10-26 Not Zed * message-list.c (cleanup_regenerate_messagelist): Fixed some logic to make more sense (gboolean)!pointer replaced with (pointer != NULL). (build_tree): Put the tree pre/post change stuff in here, where it should be. (build_flat): Same here. (cleanup_regenerate_messagelist): Remove model_changed stuff here. (setup_regenerate_messagelist): Remove pre_change stuff here. 2000-10-20 Not Zed * message-list.c (main_folder_changed): Perform incremental update of the display for flat view. (ml_tree_value_at): Spit out a mroe meaningful warning when we can't find the uid in our tree, in the folder. * message-thread.c (thread_messages): Made public. (thread_messages_free): Made public. (thread_messages): Now we also return a struct _thread_messages, which is passed to other functions. (container_free): Renamed from thread_messages_free. (thread_messages_free): Take a thread_messages argument. (thread_messages_add): New function to add a list of uid's to the thread list. (thread_messages_remove): Likewise, for removing them. (cleanup_thread_messages): Change for struct changes. (do_thread_messages): Likewise. 2000-10-19 Not Zed * mail-tools.c (mail_tool_do_movemail): removed unused var * folder-browser.c (search_full_clicked): Fix for api changes, such as it can be called an api, its mroe an utter mess infact. (search_set): Same. (search_set): And here. (folder_browser_clear_search): And here. * message-list.c (folder_changed): Copy and forward the changeinfo list to the mian thread. (main_folder_changed): Free the changeinfo. Todo: something smart with this information. (struct regenerate_messagelist_input_s): Added a changes field. (mail_do_regenerate_messagelist): Added a change list argument. (message_list_set_folder): Fix for mail_do_regenreate_messagelist api. (message_list_toggle_threads): Same. 2000-10-18 Iain Holmes * mail-config-gui.c (mail_config): Make all the CLists have passive titles. (identity_dialog): Make the default button the "OK" button, and set the dialog to close on pressing return on the entryboxes. 2000-10-17 Iain Holmes * mail-config-gui.c (service_page_item_new): Disable the optionmenu because it is empty. (service_page_item_auth_fill): Enable the optionmenu as there's stuff in it now. * mail-callbacks.c (reply_to_sender): Call check_send_configuration when we have the FolderBrowser because if it is done in mail_reply (with passing NULL) it will only be able to continue if the mailer has already been configured. (reply_to_all): Same. 2000-10-18 Not Zed * folder-browser.c (folder_browser_gui_init): No, we REALLY dont want to perform an immediate search as the keys are pressed. * mail-display.c (on_object_requested): Kill a minor warning with a cast. * mail-config.c: Include mising ctype.h to kill a warning. * message-thread.c (main): Fixed the test case for api changes. * message-list.c (message_list_drag_data_get): Set some flags to get_folder(). I dont even think this will work because mail_tool_get_folder doesn't handle file url's. * mail-vfolder.c (vfolder_uri_to_folder): Pass appropriate flags. * mail-ops.c (do_setup_folder): Pass appropriate flags. Hmm, whats the difference between setup and create. *shrug* (do_create_folder): Pass appropriate flags to get_folder. Needs a way to specify the index flag. * mail-tools.c (mail_tool_get_folder_from_urlname): Changed create to flags argument. (mail_tool_get_local_inbox_url): Add an index argument. (mail_tool_get_local_inbox): honour index flag. (mail_tool_get_inbox): Changed for api change. (mail_tool_uri_to_folder): Fixed calls to store_get_folder(); * mail-local.c (load_metainfo): Added an indexed field to the metainfo. (save_metainfo): And save it too. (do_reconfigure_folder): Honour index flag when creating the new folder. Do not open the old folder with an index at all. (mail_local_map_uri): Add an index argument - tells if the mbox is indexed. (mail_tool_local_uri_to_folder): Create & pass flags properly. (#include gnome.h): Dont include all of gnome, just what we use, and explicity include xml-memory, so we get xmlFree(). 2000-10-16 Jeffrey Stedfast * folder-browser.c (search_full_clicked): Un #if 0'd out (search_full): Same. (folder_browser_gui_init): Connect search_full and search_activate. (search_set): Uncomment search_full() * Makefile.am: Re-add `mail-search-dialogue.h' and `mail-search-dialogue.c'. 2000-10-16 Jeffrey Stedfast * mail-format.c (mail_generate_reply): Decode recipient names so that they display nicely in the To and Cc fields. (write_field_to_stream): Now takes another argument 'value_is_encoded' so that we know if we should decode that string before proceding onward. Since the message subject is already decoded before it's passed in, we don't want to decode it again (wasted cpu time and/or any 8bit chars will be assumed to be latin1 encoded and thus the decoded value will be corrupt). 2000-10-16 Chris Toshok * mail-config-gui.c (service_page_get_url): only set the url->user field if the user string is non-NULL and not empty. 2000-10-16 Not Zed * message-list.c (message_list_setup_etable): Uh, fixed jeff's wrong fix for setting the speficiation (the function changed to set_state(), as can be seen in the e_table-scrolled_load_state() call only 2 lines above). 2000-10-13 Not Zed * message-list.c (message_list_setup_etable): oops, chose the wrong thing to cut out after a merge conflict. 2000-10-15 Chris Toshok * message-list.c (subtree_unread): ETreePath != GNode now, use accessors. (ml_tree_value_at): same. (save_node_state): same. (save_tree_state): same. (nuke_uids_cb): convert to e_tree_model_node_traverse required type. (nuke_uids): g_node_traverse -> e_tree_model_node_traverse. 2000-10-14 Ettore Perazzoli * evolution-mail.oafinfo: Add "evolution:shell-component-icon" attribute. 2000-10-13 Jeffrey Stedfast * message-list.c (message_list_setup_etable): Don't free the service name. 2000-10-12 Jeffrey Stedfast * mail-ops.c (do_fetch_mail): sync & expunge the source folder after filtering. 2000-10-12 Jeffrey Stedfast * message-list.c (message_list_setup_etable): Create the 'spec' and 'extras' arguments and call e_table_scrolled_new() rather than set_specification as that function no longer (?) exists. Also started to add drag & drop functionality to something like Nautilus (but #if 0'd it out until I had time to finish it and till after 0.6). 2000-10-12 Not Zed * message-list.c (message_list_setup_etable): Duh, fix the test for the folder name, strstr != strcmp is it. 2000-10-10 Not Zed * message-list.c (folder_to_cachename): Removed, changed callers to use mail_config_folder_to_cachename instead. * mail-config.c (mail_config_folder_to_cachename): New utility function to get a cache name for a folder. * mail-tools.c (mail_tool_do_movemail): Changed to return the path to the mbox, rather than opening a folder of it. * mail-ops.c (mail_incorporate_messages): Dont bother making the pseudo messageinfo, filder_driver_filter_message will do it for us. (report_status): Callback to report status of filtering operation. (do_fetch_mail): Changed significantly - for the api changes to the filtering system. Also now incorporates a mailbox file directly, without having to import it into a camel folder first. (mail_incorporate_messages): Removed entirely, no longer needed. * mail-vfolder.c (vfolder_refresh): Fix for context api changes. (vfolder_uri_to_folder): Likewise. * folder-browser-factory.c (create_ondemand_hooks): Changed for api changes. Also only adds demand filters to the menu (fixed a small logic bug). 2000-10-11 Chris Toshok * subscribe-dialog.c (folder_etree_value_at): special case for folders with NULL urls (which aren't selected/subscribeable). (unsubscribe_folder_info): can't (un)subscribe from folders with non-NULL urls. (subscribe_folder_info): same. 2000-10-12 Christopher James Lahey * message-list.c: Replace To with From except in Drafts, Outbox, or Sent boxes. Make Subject column pay attention to text attributes like bold and strikethrough. 2000-10-12 Iain Holmes * component-factory.c: Disable the executive summary. 2000-10-11 Chris Toshok * subscribe-dialog.c (FOLDER_ETABLE_SPEC): set expansion to 0.0, minimum-width to 16, and resizable to false for the subscribed column. (folder_info_subscribed): new function so we can do the correct path munging. (subscribe_folder_info): only add the folder to the storage if there wasn't an exception subscribing it. (unsubscribe_folder_info): same, but unsubscribing. (folder_etree_value_at): use folder_info_subscribed. (folder_toggle_cb): same. (unsubscribe_folder_foreach): same. (subscribe_folder_foreach): same. (subscribe_dialog_gui_init): set the bold column on the text cell, and add the subscribed pixbuf. 2000-10-11 Anna Marie Dirks * mail-threads.c: Changed the password-getting dialog so that the text entry has focus. 2000-10-11 Chris Toshok * subscribe-dialog.c (STORE_ETABLE_SPEC): change cell type to "string" since we're not including it in the extras. 2000-10-11 Christopher James Lahey * message-list.c, message-list.h, subscribe-dialog.c: Changed these to use the proper form for the column element. 2000-10-11 Christopher James Lahey * message-list.c, message-list.h, subscribe-dialog.c: Updated these to the new ETable style of specifications. 2000-10-11 Chris Toshok * subscribe-dialog.c (subscribe_dialog_gui_init): convert to the new gal e-table stuff. (html_size_req): (html_new): (put_html): #if 0 out the html functions since description stuff isn't used and we don't want the warnings. 2000-10-11 Chris Toshok * subscribe-dialog.c (subscribe_dialog_gui_init): remove the html description stuff for now. 2000-10-10 Chris Toshok * subscribe-dialog.c (folder_toggle_cb): umm.. duh :) only subscribe if it's not subscribed, and vice versa. (subscribe_folder_foreach): make sure to call e_tree_model_node_changed. (unsubscribe_folder_foreach): make sure to call e_tree_model_node_changed. 2000-10-10 Chris Toshok * mail-ops.c (setup_scan_subfolders): add a ref to input->storage here so that the ref/unref pattern more closely matches other mail-ops. also, this keeps the storage from being freed when we hit the unref in cleanup_scan_subfolders, which is important because we maintain a reference to it in the storage_hash in component-factory.c * subscribe-dialog.h: add storage field. * subscribe-dialog.c (subscribe_folder_info): new function, subscribe to a folder given it's CamelFolderInfo, and add it to the shell - we're generating a path from the name of the folder which is bad. (unsubscribe_folder_info): same (except we unsubscribe and remove from the shell). (storage_selected_cb): unref the currently selected storage. (subscribe_dialog_destroy): unref the currently selected storage. (subscribe_dialog_construct): sc->storage = NULL. * component-factory.c (mail_lookup_storage): new function, to look up a EvolutionStorage corresponding to a CamelService. we ref the EvolutionStorage before passing it back. (mail_add_new_storage): insert the storage into storages_hash if result is EVOLUTION_STORAGE_OK. * mail.h: add prototype for mail_lookup_storage. 2000-10-10 Larry Ewing * mail-format.c (mail_generate_reply): make sure we dup the return value of get_reply_to or get_from when building the recipient list. 2000-10-10 Iain Holmes * mail-summary.c (generate_html_summary): Removed the
  • from the HTML. 2000-10-10 Cody Russell * mail-threads.c: Added #include 2000-10-09 Iain Holmes * mail-summary.c: Removed the extra arguments to rule_context_load. 2000-10-09 Chris Toshok * subscribe-dialog.c, subscribe-dialog.h: use our own etable to display the stores, and get them from the mail-config api. put #if 0'ed code in place to add/remove the folders from the shell when they're subscribed/unsusbcribed. also, react to double clicks in the folder etable by toggling subscription status. 2000-10-08 Iain Holmes * mail-summary.c (create_summary_view): Updated to use new icon code. 2000-10-08 Iain Holmes * mail-summary.c (generate_html_summary): Generic function to recreate the HTML of the summary. Checks all the folder summaries. (generate_folder_summarys): Create a summary of all the vfolders and the Inbox. (create_summary_view): Generate the folder summarys before the HTML. 2000-10-09 Ettore Perazzoli * folder-browser.c: Don't #include "mail-search-dialogue.h" as it's missing from the repository. (search_full_clicked): Temporarily `#if 0'ed out. (search_full): Likewise. (folder_browser_gui_init): Don't connect `search_full'. (create_option_menu): Don't connect `search_menu_deactivate'. (folder_browser_gui_init): Don't connect `search_activate'. (search_set): Don't do `search_full()'. (folder_browser_gui_init): Likewise. * Makefile.am (evolution_mail_SOURCES): Remove `mail-search-dialogue.h' and `mail-search-dialogue.c' as NotZed forgot to put them into CVS. 2000-10-06 Not Zed * mail-search-dialogue.c: New widget, full search dialogue for mail. * folder-browser.c (search_set): If we click on custom search, run the full search dialogue. (folder_browser_gui_init): Add a button to perform a full search. (search_full): Bring up the mail search dialogue asynchronously. (search_full_clicked): Handle search options. (folder_browser_destroy): Free the saved rule if there is one there. (search_options[]): Added a custom option option - brings up the full search dialogue. (search_set): Disable the search entry if we are doing a full search. * mail-vfolder.c (vfolder_create_storage): Yay, finally depeterised this stuff. (vfolder_uri_to_folder): Removed an irrelevant comment. * mail-callbacks.c (filter_edit): And here. * mail-ops.c (do_fetch_mail): And here too. * mail-autofilter.c (filter_gui_add_from_message): Fixed call to context_load. (filter_gui_add_for_mailing_list): And here too. * folder-browser-factory.c (create_ondemand_hooks): Remove that ondemand callback snot. 2000-10-05 Not Zed * message-list.c (message_list_init_etable): Build the etable once we know what folder we are going to use. (save_header_state): Save the header spec to a cache file. (message_list_destroy): Save the header spec. (message_list_setup_etable): Setup the etable spec for this folder, from a saved version if one exists, or to suit the folder type (sent/received). (message_list_set_folder): Setup the etable here once we have a folder. 2000-10-09 Michael Meeks * message-list.c (message_list_toggle_threads): re-write. * folder-browser-factory.c (control_activate): update paths, need CVS HEAD bonobo, use a listener not a verb. 2000-10-08 Miguel de Icaza * mail-ops.c (mail_incorporate_messages): Tag string for translation (do_flag_messages): ditto. * mail-threads.c (pipe_write): Repeates writes on EINTRS. (pipe_read): Repeats reads on EINTRS. (mail_operation_queue): Use pipe_write (mail_op_set_percentage): ditto. (mail_op_hide_progressbar): ditto. (mail_op_show_progressbar): ditto. (mail_op_set_message): ditto. (mail_op_get_password): ditto. (mail_op_error): ditto. (mail_op_forward_event): ditto. (mail_operations_terminate): ditto. (dispatch): use pipe_read. (dispatch): use pipe_write (dispatch): ditto. * mail-ops.c (mail_incorporate_messages): Only show message being incorporated every 2 seconds, to avoid a bunch of CORBA round trips. (do_transfer_messages): ditto. (do_forward_messages): ditto. 2000-10-07 Miguel de Icaza * mail-ops.c (do_fetch_mail): Move the functionality to incorporate messages into mail_incorporate_messages. (mail_load_evolution_rule_context): New function. Move the functionality for loading the context rules to its own function. 2000-10-06 Iain Holmes * mail-summary.c: Fix the locking up of the mail by only calling camel functions from the camel thread, and ORBit functions from the GTK thread. Watch for the message-changed signal again. * component-factory.c (summary_fn, component_factory_init): Re-enabled it, cos I think it works again. * mail-display.h: Remove the pb_cache. * Makefile.am: Readd the mail-summary.[ch] files and add the evolution-services library to the link. 2000-10-06 Chris Toshok * mail-ops.c (do_scan_subfolders): set the @subscribed_only parameter to TRUE, since the subscribe UI is the only interface that should show unsubscribed groups. 2000-10-06 Ettore Perazzoli * mail-ops.c (do_scan_subfolders): Add missing @subscribed_only parameter in the call to `camel_store_get_folder_info()'. [FALSE, I hope that's right.] 2000-10-05 Jeffrey Stedfast * mail-format.c (write_field_to_stream): Decode the header before writing it to the header box. * mail-callbacks.c (send_receieve_mail): fetch mail before sending, this is a temp fix for POP-before-SMTP authentication. 2000-10-05 Michael Meeks * component-factory.c (summary_fn, component_factory_init): Disable summary stuff, it appears to be badly broken. * Makefile.am (evolution_mail_SOURCES): add mail-summary.[ch] * subscribe-dialog.c (update_pixmaps): upd. (set_pixmap): upd. (subscribe_dialog_gui_init): upd. remove redundant and annoying forward definitions. * folder-browser-factory.c (control_deactivate): upd. (control_activate_cb): upd. (control_activate): upd. (set_pixmap): upd. (update_pixmaps): upd. (register_ondemand): upd. (create_ondemand_hooks): upd. 2000-10-04 Jeffrey Stedfast * message-list.c (address_compare): Use CamelInternetAddress instead of my quick hack (aka InternetAddress). 2000-10-05 Iain Holmes * mail-summary.c: Don't watch for the message-changed signal. 2000-10-05 Iain Holmes * component-factory.c (component_factory_init): Setup the summary factory as well. (summary_fn): New function to create the ExecutiveSummaryComponent. * mail-summary.c: Create the view, and update it when something changes. 2000-10-04 Iain Holmes * mail-display.c (on_object_requested): Removed the pixbuf cache as it would return the pixbufs in the reverse order every so often and generally get all confused. 2000-10-04 Dan Winship * folder-browser-factory.c (control_deactivate): Add back the "sync folder on leave" hack that got lost in the UIHandler merge. 2000-10-04 Jeffrey Stedfast * folder-browser-factory.c: Instead of UnSelectAll, we want InvertSelection. * mail-callbacks.c (select_all): Finished this function. (invert_selection): Finished. (was unselect_all - but that's not what we really wanted as it'd be pointless. invert_selection is a much more useful callback :-) 2000-10-04 Chris Toshok * mail-tools.c (mail_tool_get_root_of_store): remove news specific check. (mail_tool_uri_to_folder): news: -> nntp: 2000-10-04 Jeffrey Stedfast * mail-ops.c (do_filter_ondemand): Don't expunge the source mailbox on completion. 2000-10-04 Dan Winship * mail-ops.c (do_scan_subfolders): Don't try to add_folders if get_folder_info returned NULL. 2000-10-04 Not Zed * message-list.c (message_list_init_header): Fix the attachment icon width. (content_is_attachment): Perform some simple tests to see if the message contains an attachment. (build_subtree): Kill a pointless warning. 2000-10-04 Miguel de Icaza * mail-callbacks.c (delete_msg): Added a comment to a piece of code that I was trying to "fix" just to find that the strange behaviour here that was about to be fixed, was actually a fix to the problem I was trying to fix. So put the original comments from Dan, and will hope that someone with more knowledge about this can figure why the delete key wont delete messages and select the next unread message. 2000-10-02 Chris Toshok * subscribe-dialog.c (subscribe_dialog_destroy): destroy our tree_model and remove the root node. also, release_unref our control and view, and unref the listener. * mail-tools.c (mail_tool_uri_to_folder): news url's contain host names too, now. 2000-10-02 Chris Toshok * subscribe-dialog.c, subscribe-dialog.h: add a storage-set-view-listener, and add a little printf saying what storage was selected. 2000-10-02 Chris Toshok * subscribe-dialog.c (subscribe_dialog_gui_init): get Evolution::StorageSetView interface on our storage set view control, and set "show_folders" to FALSE. 2000-10-02 Chris Toshok * Makefile.am (INCLUDES): add -I$(top_srcdir)/widgets/misc * subscribe-dialog.c (subscribe_dialog_gui_init): change the window title to Manage Subscriptions, bold subscribed folders, and add a title bar ala the evolution shell (but without the close button). 2000-10-02 Chris Toshok * subscribe-dialog.h: add fields for the storage set Bonobo_Control and Evolution_StorageSetView interfaces. * subscribe-dialog.c (subscribe_dialog_gui_init): create the uih as early as possible, and add the storage set view to the left side of the hpaned. 2000-09-22 Michael Meeks * folder-browser-factory.c (set_pixmap): upd. (control_activate): upd. 2000-10-02 Dan Winship * mail-config-gui.c: Remove "Port" entry from source dialog. We'll use "host:port" like Netscape and other programs do. (service_page_get_url): If host ends in ":###", use that as port. (service_page_set_url): If URL contains a port, append it to the hostname, separated by a colon. 2000-10-02 Chris Toshok * Makefile.am (evolution_mail_SOURCES): subscribe-control.[ch] -> subscribe_dialog.[ch] * mail-callbacks.c (manage_subscriptions): subscribe_control -> subscribe_dialog. Also, pass the shell to subscribe_dialog_new. * mail-types.h: SubscribeControl -> SubscribeDialog. * subscribe-dialog.c, subscribe-dialog.h: rename from subscribe-control.[ch]. * subscribe-dialog.c (subscribe_dialog_construct): pass Evolution_Shell in. (subscribe_dialog_new): takes Evolution_Shell argument now. 2000-10-02 Chris Toshok * message-list.c (message_list_init_renderers): remove the 2 tree pixbufs, so adjust the offsets to the score pixbufs. also, pass NULL for the open/closed pixbufs to the tree cell renderer. 2000-10-02 Dan Winship * mail-ops.c (mail_do_scan_subfolders, etc): Update for CamelFolderInfo changes. * message-list.c (message_list_destroy): Don't save_tree_state if there's no folder associated with the MessageList. * folder-browser.c (folder_browser_set_uri): Only call mail_do_load_folder if the URI is not "". 2000-10-02 Iain Holmes * mail-display.[ch]: Add a cache for the pixbufs, hashed on CID, so that we only have to make a thumbnail once. 2000-10-01 Iain Holmes * mail-display.c: Generate the thumbnails on an idle function so that the user interface isn't locked. Checks in case the widget it will use to display the image isn't destroyed. 2000-10-01 Iain Holmes * mail-display.c (on_object_requested): If the attachment is an image display a thumbnail of it, instead of the generic image icon. 2000-09-29 Miguel de Icaza * folder-browser-factory.c: Add print preview verb here. * mail-callbacks.c (do_mail_print): Handle printing here, the complete engine. (mail_print_preview_msg): new. does print previewing. (mail_print_msg): does printing of the message. 2000-09-29 Chris Toshok * subscribe-control-factory.c, subscribe-control-factory.h: nuked. * subscribe-control.c, subscribe-control.h: lots of changes. we now pop up a dialog, and will have a storage set view on our left side, like the shell does. * mail.h: add prototype for manage_subscriptions. * mail-callbacks.c (manage_subscriptions): new function, pops up the subscribe dialog. * folder-browser-factory.c: add the verb for managing subscriptions. * Makefile.am (evolution_mail_SOURCES): add subscribe-control.[ch] again. 2000-09-28 Chris Toshok * subscribe-control.h (subscribe_search): added prototype. * subscribe-control.c (subscribe_search): new function. * subscribe-control-factory.c (make_folder_search_widget): new function, to add search widget to toolbar. (control_activate): create the search widget and add it to the toolbar. 2000-09-28 Jeffrey Stedfast * mail-ops.c (do_send_queue): Messages should be appended to Sent as Seen. (do_send_mail): Same. 2000-09-28 Ettore Perazzoli * Makefile.am: Don't compile `subscribe-control' for now. It needs to be converted to the new UI handler code in Bonobo; it doesn't compile right now. 2000-09-27 Chris Toshok * subscribe-control.c (subscribe_refresh_list): new function. * subscribe-control.h (subscribe_refresh_list): new prototype. * subscribe-control-factory.c (update_pixmaps): add RefreshList pixmap. also, add it to the verbs list. 2000-09-27 Chris Toshok * mail-types.h: add SubscribeControl typedef. * Makefile.am (evolution_mail_SOURCES): add the subscribe stuff. * subscribe-control-factory.h * subscribe-control-factory.c * subscribe-control.c: * subscribe-control.h: Mostly mocked up subscribe ui. 2000-09-27 Jeffrey Stedfast Note: We need a configuration option to specify whether to log filtering actions or not. * mail-ops.c (do_filter_ondemand): Updated to pass a log file pointer to filter_driver_run. (do_fetch_mail): Same. (mail_do_fetch_mail): Fixed a compiler warning. 2000-09-27 Jeffrey Stedfast * mail-callbacks.c (composer_postpone_cb): Fix it so that "send later" will still mark a message as being replied, forwarded, whatever. Closes bug #568 on bugzilla. 2000-09-27 Jeffrey Stedfast * mail-ops.c (do_filter_ondemand): If the message has been deleted, don't try filtering it - skip to the next message. Fixes bugzilla bug #639. 2000-09-25 Jeffrey Stedfast * folder-browser-factory.c: Shuffling (un)select all menu items to the Edit menu. 2000-09-25 Jeffrey Stedfast * folder-browser-factory.c: Added new menu items * mail-callbacks.c (mark_as_seen): New callback to mark all selected messages as Seen. (mark_as_unseen): New callback to mark all selected messages as Unseen. (select_all): New callback to select all messages (not yet finished) (unselect_all): New callback to unselect all messages (not yet finished) 2000-09-25 Not Zed * message-list.c (folder_to_cachename): Function to convert a folder name/path to a filename for per-folder data. (save_tree_state): (load_tree_state): (free_tree_state): For loading/saving the state of the expansion of nodes in the tree. (message_list_destroy): Save the tree state when done. (save_node_state): Changed logic, we save when the node should be closed on startup. i.e. any new nodes with children automatically default to being open. (subtree_unread): Check for unread messages in a subtree. So false messages (for tree roots) are properly displayed. 2000-09-25 Jeffrey Stedfast * message-list.c (address_compare): Updated to use Nat's ENameWestern parser. * Makefile.am: link against e-util/ename/libename.la 2000-09-25 Dan Winship * mail-ops.c: CamelException is not for compile-time errors. Replace lots of argument checks in setup_ functions with g_return_if_fails in the public functions. Also remove some prototypes that weren't needed because they were for static functions that are defined before they're used. 2000-09-23 Michael Meeks * folder-browser-factory.c (set_pixmap): upd. (control_activate): upd. 2000-09-23 Ettore Perazzoli * message-list.c (internet_address_new_from_string): Skip spaces at the beginning of the string first before doing anything else. The code that follows doesn't like the first character of the string to be a space. 2000-09-22 Jeffrey Stedfast * message-list.c (address_compare): New comparison function for email addresses. (subject_compare): New comparison function for message subjects. (message_list_init_header): Updated to use the new compare funcs. 2000-09-21 Jeffrey Stedfast * mail-format.c (mail_generate_reply): Fixed some memory leakage. Call free_recipients() so we don't leak memory. 2000-09-19 Jeffrey Stedfast * mail-ops.c (do_scan_subfolders): Use the folder's full_name so recursive directory structures display correctly ;-) 2000-09-19 Dan Winship * mail-ops.c (do_scan_subfolders): Update for CamelFolder changes (subfolder_names -> subfolder_info). 2000-09-19 Dan Winship * mail-callbacks.c (create_msg_composer, compose_msg, send_to_url, mail_reply, forward_msg): * mail-format.c (mail_generate_reply): * mail-ops.c (cleanup_edit_messages): * mail-view.c (view_forward_msg): Deal with NULL composer. 2000-09-18 Dan Winship * main.c (main): Call gnome_vfs_init() since the composer now does file operations (to get the MIME type of attachments). 2000-09-18 Jeffrey Stedfast * message-list.c: Removed COL_ONLINE_STATUS because we don't want that. Renamed COL_PRIORITY to COL_SCORE and set it up to sort-of work, I'm not really sure which renderer I should use. 2000-09-18 Christopher James Lahey * Makefile.am: Added $(EXTRA_GNOME_CFLAGS) and $(EXTRA_GNOME_LIBS). Removed unneeded libraries. * component-factory.c, folder-browser-factory.c, folder-browser.c, mail-callbacks.c, mail-config-gui.c, mail-display.c, mail-display.h, main.c, message-list.c, message-list.h: Fixed the #include lines to deal properly with gal. 2000-09-16 Michael Meeks * Makefile.am (INCLUDES): add datadir * folder-browser-factory.c (control_activate): use it. 2000-09-15 Dan Winship * mail-callbacks.c (transfer_msg): Revert **Temp fix** from below since the relevant shell bug has been fixed now. * mail-ops.c (do_fetch_mail): Fix the sense of the "keep on server" check so we're not doing this backwards. Don't get_message_flags, because POP doesn't support it and it's pointless anyway since we're setting deleted, not toggling it. call camel_folder_sync with expunge=TRUE so that the deletions are actually recorded. 2000-09-15 Dan Winship This bug was so much fun to fix the first time that I decided to fix it again. 2000-07-11 Dan Winship * mail-ops.c (real_send_mail): Set the post_send_data flag rather than toggling it. (Maybe we'll need more control over it later, but for now, the only flag we set is "replied", and we want that set, not toggled.) 2000-09-14 Jeffrey Stedfast * mail-callbacks.c (transfer_msg): **Temp fix** Send "" as the default folder to select as anything else seems to cause a segfault in shell's user_get_folder(). (check_configured): A spoon full of 'line wrapping' makes the medicine go down, the medicine go dowwwwn... 2000-09-14 Iain Holmes * mail-callbacks.c (check_configured): Ask if you want to configure the mail client if it isn't configured already. (check_send_configuration): Remove the error box if mail isn't configured. (send_queued_mail): Same. 2000-09-14 Dan Winship * mail-ops.c (setup_append_mail): camel_folder_append is perfectly happy to take a NULL info. 2000-09-14 Michael Meeks * folder-browser-factory.c: move fn to bonobo. (set_pixmap): update. (control_deactivate): add bonobo_ui_handler_unset_container 2000-09-14 Christopher James Lahey * mail-config-gui.h: Changed the include here because it caused make distcheck to fail for me. I changed it from to "shell/Evolution.h". This seems to have fixed things. 2000-09-14 Jeffrey Stedfast * mail-ops.c (do_fetch_mail): Only use the cache if the user plans to keep_on_server. 2000-09-14 Michael Meeks * folder-browser-factory.c (control_deactivate): kill warning. (control_activate): set threaded toggle state, add freeze / thaw. (set_pixmap, fill_toolbar, update_pixmaps): update. 2000-09-13 Christopher James Lahey * folder-browser-factory.c: Fixed a warning (Missing include file.) 2000-09-12 Ettore Perazzoli ($(EVOLUTION_MAIL_CORBA_GENERATED)): Add space after `-I'. 2000-09-12 Ettore Perazzoli * Makefile.am: Remove `ui.xml' stuff. 2000-09-12 Dan Winship * mail-local-storage.c (mail_local_storage_startup): set folder_tree before adding the listener, since that will eventually invoke callbacks that will look at it. * folder-browser-factory.c (control_deactivate): sync the folder on deactivate. 2000-09-12 Ettore Perazzoli * message-list.c (on_right_click): Also display the name of the mailing list in the "Filter on Mailing List" item for additional Coolness factor. * mail-autofilter.c (filter_gui_add_for_mailing_list): Create the rule with `filter_filter_new()' so that it also has an action part. * mail-mlist-magic.c (get_header): Use the right header name to retrieve the header. 2000-09-12 Ettore Perazzoli * message-list.c (on_right_click): Grey out the mailing list filter item if `mail_mlist_magic_detect_list()' returns NULL on this message [i.e., if we cannot figure out a mailing list for this message]. (filter_mlist): Good boys don't use F words. * mail-mlist-magic.c (check_sender): Work safely if `header_name_return' or `header_value_return' are NULL. (check_x_been_there): Likewise. (check_delivered_to): Likewise. (check_x_mailing_list): Likewise. (check_x_loop): Likewise. (get_header): Use the right header name to retrieve the header. * message-list.c (on_right_click): Mark strings for translation. 2000-09-12 Ettore Perazzoli * folder-browser-factory.c: Use the latest, shiny, amazing TigerT art for the toolbar. * component-factory.c: #include "mail-local-storage.h". (owner_set_cb): Removed unused variable. * message-list.c (filter_sender): Made static. (filter_recipient): Likewise. (filter_subject): Likewise. (vfolder_recipient): Likewise. (vfolder_sender): Likewise. (vfolder_subject): Likewise. * mail.h (vfolder_subject): Removed prototype [WTF was this doing here?!?!]. (vfolder_sender): Likewise. (vfolder_recipient): Likewise. (filter_subject): Likewise. (filter_sender): Likewise. (filter_recipient): Likewise. * message-list.c: Added a new "Filter on mailing list" menu item. (filter_mlist): Callback for this menu item. Use `filter_gui_add_for_mailing_list' to pop up the filter dialog with the appropriate rule. * mail-autofilter.c (filter_gui_add_for_mailing_list): New. * message-thread.c (dump_tree): Removed unused variable. * mail-mlist-magic.c: New. * mail-mlist-magic.h: New. * mail-autofilter.c (rule_match_recipients): Mark strings for translation. (rule_from_message): Likewise. (filter_gui_add_from_message): Likewise. 2000-09-12 Jeffrey Stedfast * mail-ops.c (do_fetch_mail): Was trying to unhook an event from the wrong folder - oops. 2000-09-12 Not Zed * message-thread.c: Reverted to version 1.15. (remove_node): Ok, if a node has a parent, remove it from the parent list, otherwise remove it from the (supplied) root list. (group_root_set): When we merge children, free the lost node. (thread_messages_free): Remove the return, run as is. (prune_empty): Plugged another small leak. 2000-09-11 Jeffrey Stedfast * mail-callbacks.c (run_filter_ondemand): Updated to use the new mail_do_filter_ondemand. * mail-ops.c (do_fetch_mail): Update to use the new filter_driver_run args. (do_filter_ondemand): Updated to use the new filter_driver_run args. (mail_do_filter_ondemand): Take a FilterContext as a argument instead of a driver as we need to destroy the filter inside the do_filter_ondemand function and things'd get messy. 2000-09-11 Jeffrey Stedfast * mail-ops.c (do_fetch_mail): Don't have the filter driver self_destruct. 2000-09-11 Jeffrey Stedfast * mail-ops.c (do_fetch_mail): If we're fetching from an mbox formatted file then we need to do some special-casing. 2000-09-11 Ettore Perazzoli * component-factory.c (owner_set_cb): Call `mail_local_storage_startup()' to set up handling of the local storage. * mail-local-storage.c: New. * mail-local-storage.h: New. 2000-09-11 Christopher James Lahey * mail-display.c: Fixed some warnings. 2000-09-11 Dan Winship * mail-display.c, mail-format.c: Another big rewrite of this stuff. Now all (well, most) attachments get a small icon with a description and a (non-obvious) right-click pop-up menu with options to save, open in an external program, or show/hide inline. TODO: antialias the icon, add more options to the pop-up for certain MIME types, add an icon to the headers, fix PGP to work like everything else, fix message/external-body to work again, add some icon caching action, etc, etc. 2000-09-09 Jeffrey Stedfast * mail-ops.c (do_fetch_mail): Use the CamelUIDCache so that we only retrieve *new* messages and also send notes to the status bar telling it which message we're downloading so that Ettore can sleep at night ;-) 2000-09-09 Jeffrey Stedfast * mail-ops.c (do_fetch_mail): Updated to not send hook/unhook data to filter_driver_run as it no longer takes those args. (do_filter_ondemand): Same. Also wrap filtering in freeze/thaw to prevent signals from being queued up 2000-09-09 Jeffrey Stedfast * mail-ops.c (do_fetch_mail): Freeze the default folder before filtering and thaw it afterward to prevent a ton of "folder_changed" signals from being queued. 2000-09-08 Christopher James Lahey * folder-browser.c, mail-config-gui.c, mail-ops.c: Fixed some warnings. * message-list.c: Added base ETableModel functions. 2000-09-08 Jeffrey Stedfast * mail-ops.c (do_fetch_mail): Updated to pass a CamelMessageInfo to filter_driver_run (do_filter_ondemand): Same. 2000-09-07 Jeffrey Stedfast * mail-ops.c (do_filter_ondemand): Updated to check the boolean return code from filter_driver_run to find out whether or not the message was filtered so that it can decide whether or not to delete the message from the source folder or not. 2000-09-07 Jesse Pavel * mail-format.c (mail_generate_reply) Changed the behavior of Reply-to-All so that the sender's address does not appear in the cc: list. 2000-09-07 Jeffrey Stedfast * mail-ops.c (do_fetch_mail): Updated to pass an exception to filter_driver_run and also check the exception before deleting the message from the source folder. (do_filter_ondemand): Updated to pass an exception to filter_driver_run 2000-09-07 Dan Winship * session.c (session_init): Pass a storage dir to camel_session_new now. * main.c (main): Can't call session_init here now, because it requires evolution_dir to be set. * component-factory.c (owner_set_cb): call session_init here. * mail-ops.c (do_fetch_mail): Fix previous fix. (Free the uids, just do it correctly.) 2000-09-07 Jeffrey Stedfast * mail-ops.c (do_fetch_mail): Don't free uids, let the camel folder do that when it gets finalized 2000-09-06 Jeffrey Stedfast * mail-ops.c (mail_do_filter_ondemand): New async function to filter messages on demand. (do_fetch_mail): Updated to filter 1 message at a time using the new filter-driver code * mail-callbacks.c (composer_postpone_cb): Send NULL as the message info. (run_filter_ondemand): Use mail_do_filter_ondemand instead of filter_driver_run * mail-tools.c: Removed mail_tool_filter_contents_into and mail_tool_fetch_mail_into_searchable as they have now been deprecated. 2000-09-06 Dan Winship * message-list.c (clear_tree): set the data to NULL for the tree root, so nuke_uids won't try to free anything. 2000-09-06 Ettore Perazzoli * folder-browser.c (folder_browser_new): @shell made const. `CORBA_Object_duplicate()' it before storing it. (folder_browser_destroy): Free the shell object with `CORBA_Object_release()', not `CORBA_free()'. * folder-browser-factory.c (folder_browser_factory_new_control): @shell made const. 2000-09-05 Dan Winship * mail-display.c (make_safe_filename): * mail-format.c (handle_mystery): * mail-identify.c (mail_identify_mime_part): camel_mime_part_get_filename now deals with both Content-Disposition and Content-Type. 2000-09-05 Peter Williams * mail-ops.c (cleanup_load_folder): Check for NULL folder. (mail_do_setup_folder): Copy the 'name' parameter so that we can free it. * message-list.c (nuke_uids): Depth '-1' means "unlimited", not 0. 2000-09-05 Dan Winship * component-factory.c (owner_set_cb): Re-rename "Sent". * folder-browser.c (fb_resize_cb): Remove the "+ 90" here since it seems to break things for me, and it's not commented anyway and there's no excuse for adding 90 to a number with no explanation. 2000-09-05 Peter Williams * folder-browser.c (folder_browser_destroy): Don't free the shell; it's not ours. 2000-09-05 Dan Winship * mail-tools.c (mail_tool_move_folder_contents): only call camel_folder_get_message_info if the folder has summary_capability. Don't hack up a fake CamelMessageInfo: append_message will take NULL. * mail-ops.c: Replace mail_do_setup_draftbox, mail_do_setup_outbox, and mail_do_setup_sentbox with mail_do_setup_folder. (do_send_mail, do_send_queue): s/sentbox_folder/sent_folder/ * component-factory.c (owner_set_cb): Use mail_do_setup_folder, rename sentbox_folder to sent_folder, and call mail_operation_wait_for_finish after the setup_folder calls in case anything needs to use the _folder variables. 2000-09-04 Jeffrey Stedfast * mail-format.c (mail_generate_reply): Applied Jesse's patch that will append a signature to the replied message text * folder-browser-factory.c: Changed "Send & Receieve" back to "Get Mail" temporarily so that the toolbar buttons don't all get stretched to some weird proportion 2000-09-03 JP Rosevear * mail-config.c (mail_config_add_news): Copy the passed in item before adding (mail_config_add_source): ditto (mail_config_add_identity): ditto * mail-config-gui.c (mail_config): We don't actually need a notebook pointer. (identities_edit_clicked): Don't explicitly destroy, we are using gtk_clist_set_data_full now (sources_edit_clicked): ditto (news_edit_clicked): ditto (mail_config): Use gtk_clist_set_row_data_full to kill leaks 2000-09-03 Jeffrey Stedfast * folder-browser-factory.c: Change the "Get Mail" toolbar button to become "Send & Receieve" * mail-callbacks.c (send_queued_mail): New callback function for sending queued mail (send_receieve_mail): New callback for Send & Receieve that basically just calls send_queued_mail and then fetch_mail * mail-ops.c (cleanup_send_mail): Mod to be able to handle a NULL composer window (setup_send_mail): Modified to handle a NULL composer widget (mail_do_send_queue): New convenience async function to send all messages in a folder (aka all messages in a queue) 2000-09-02 Jeffrey Stedfast * mail-tools.c (mail_tool_move_folder_contents): Since POP3 doesn't implement get_message_info, we need to check for info to be NULL. In this case, we need to make our own info structure to pass to append_message and then remember to free it afterward. Should we even bother with get_message_info? And if so, should we then implement get_message_info for POP3? 2000-09-02 Ettore Perazzoli * folder-browser.c (etable_key): Make the `Home' key to move to the beginning of the list and `End' to the end of it, using `message_list_home()' and `message_list_end()'. * message-list.c (message_list_home): New. (message_list_end): New. * folder-browser.c (folder_browser_new): Don't ref the shell here. (folder_browser_destroy): Don't unref the shell. Instead, `CORBA_free()' the object reference. * folder-browser-factory.c (control_activate): Bind "Open in New Window" to `Ctrl-O'. 2000-09-02 Lauris Kaplinski * mail-config-gui.c: Use e_utf8 wrappers * main.c (main): Do e_unicode_init, so we are not confusing libunicode 2000-09-01 Christopher James Lahey * folder-browser.c: Removed a warning. 2000-09-01 Jeffrey Stedfast * mail-callbacks.c (compose_msg): Attach a callback to the postpone signal (send_to_url): Same (mail_reply): Same (forward_msg): Same (composer_postpone_cb): Callback function for the postpone signal * mail-ops.c (mail_do_setup_outbox): New convenience function to load the Outbox folder (mail_do_setup_sentbox): Same, but for Sentbox. (do_send_mail): Now saves messages in Sentbox if sent successfully (mail_do_append_mail): New convenience async function for appending messages to a folder * component-factory.c: Added outbox_folder and sent_folder (owner_set_cb): Call our new convenience functions to load Outbox and Sentbox 2000-09-01 Ettore Perazzoli * mail-ops.c (cleanup_scan_subfolders): Update for the extra arg needed by `evolution_storage_new_folder()'. * mail-vfolder.c (vfolder_refresh): Likewise. 2000-08-31 Peter Williams * folder-browser.c (folder_browser_new): Don't ref the shell: causes a race upon exit. (folder_browser_destroy): Don't unref it. * mail-config-gui.c (service_page_item_new): Add a checkbutton "use default port" to make life simple. (service_page_get_url): Honor use_default_port. (service_page_set_url): Set use_default_port based on the input URL. (toggle_port): New function, sets the sensitivity of the port entry based on "use default port" (config_do_query_authtypes): Make this asynchronous, as it may involve connecting to a server. (service_page_detect): Call the async auth querier. (service_page_item_new): Put the authentication stuff in if the url_flags have URL_ALLOW_AUTH. Call the async auth querier to get the info. 2000-08-30 Ettore Perazzoli * mail-view.c (mail_view_create): Make the HTML widget grab the focus. 2000-08-30 Peter Williams * mail-config-gui.c (do_test_service): Explicitly connect to the service again. * component-factory.c (mail_load_storages): Now that camel_service_get_provider exists, use it to make this function much simpler. 2000-08-29 Peter Williams * folder-browser.c (folder_browser_new): Ref the Evolution_Shell. Is this correct, or is it a circular reference? 2000-08-29 Dan Winship * mail-ops.c (mail_do_send_mail): Update this and related functions to no longer take a From address. (The composer deals with it itself now.) (do_send_mail): Add the Evolution version back to the X-Mailer header (this change got lost in the thread migration). * mail-callbacks.c (composer_send_cb): Don't re-fetch the From address. It's set by the composer now. Don't free the post_send_data from here. (mail_reply): Attach to the composer's destroy signal to free the psd. (The current code would free it more than once if an error occurred while trying to send the first time.) 2000-08-28 Peter Williams * mail-config-gui.c (mail_config_apply_clicked): Add new news sources, not only stores. 2000-08-28 Jeffrey Stedfast * mail-callbacks.c (composer_send_cb): Free the from address when we're done with it. Also, e_msg_composer_hdrs_get_from returns alloc'd memory so don't strdup it. 2000-08-28 Peter Williams * mail-ops.c (do_transfer_messages): Add status messages. (do_flag_messages): Same. (do_scan_subfolders): Same. (do_forward_messages): Same. (do_view_messages): Same. 2000-08-28 Ettore Perazzoli * mail-view.c (mail_view_create): Use `gnome_app_set_toolbar()' the easy way instead of doing things manually with `GnomeDock' and `gnome_app_add_toolbar()'. (MINIMUM_WIDTH): New #define. (MINIMUM_HEIGHT): New #define. (view_size_allocate_cb): New, callback for the "size_allocate" signal of the mail view. It saves the last allocation in a static `last_allocation' variable. (mail_view_create): Connect it. (set_default_size): New function. Set the default width/height to the last allocation width/height; if the width/height is less than the `MINIUM_WIDTH' or `MINIMUM_HEIGHT', use that value instead. * mail-tools.c (mail_tool_move_folder_contents): Show `i + 1', not `i', so that we correctlly start counting from one instead of zero. 2000-08-28 Peter Williams * *.c: s,mail_dialog_run,gnome_dialog_run,g. * main.c (main): Since only the main thread is dealing with GTK+, free the GDK threads mutex and never worry about locking again. 2000-08-28 Jeffrey Stedfast * mail-crypto.c (mail_crypto_openpgp_encrypt): Fix to prevent possible buffer overflows and a logic fix. 2000-08-27 Jeffrey Stedfast * mail-crypto.c (mail_crypto_openpgp_clearsign): New crypto function to clearsign plaintext 2000-08-27 Ariel Rios * folder-browser-factory.c (control_activate): Added bonobo menu handler for mark_all_deleted function. * mail.h: (mark_all_deleted): Added prototype. * mail-callbacks.c (mark_all_deleted): Added callback for marking all displayed messages in a folder as deleted. 2000-08-26 Ettore Perazzoli * mail-view.c (mail_view_create): Use `gtk_window_set_default_size' on the toplevel instead of `gtk_widget_set_usize()', and make the default size smaller. 2000-08-25 Christopher James Lahey * mail-crypto.c: Fixed an uninitialized variable. 2000-08-26 JP Rosevear * evolution-mail.gnorba: Kill * Makefile.am: Remove gnorba related stuff 2000-08-25 Peter Williams * mail-config-gui.c (service_page_item_new): If the service wants a host, also let the user specify a port. (MailDialogServicePageItem): Add members for the port GtkEntry and the default port. (service_page_get_url): Translate the port in the entry back into the CamelURL. (service_page_set_url): Read in the port from the URL or use the default. 2000-08-25 Jeffrey Stedfast * mail-crypto.c (mail_crypto_openpgp_encrypt): Implemented PGP 2.x encryption. We only need to get the passphrase if we plan to sign the text, otherwise we don't need to worry about getting the passphrase. 2000-08-24 Lauris Kaplinski * folder-browser.c: Use e_utf8 wrappers * mail-config-gui.c: Use e_utf8 wrappers 2000-08-24 Peter Williams * folder-browser-factory.c (control_activate): Add all the functions from message-list.c's popup menu to the main menu as well * message-list.c (vfolder_subject): These functions become public. * mail-callbacks.c (mark_all_seen): Don't call camel_folder_get_uids here. IMAP, for example, will try to communicate with the IMAP server during that call. * mail-ops.c (cleanup_fetch_mail): Tell the user which URL has no new mail, as they may be checking more than one source. (mail_do_flag_all_messages): New function. Flags all of the messages in a folder. Something of a hack. This merely extends the flag_messages operation; it doesn't implement a new one. (do_flag_messages et al): Fetch the uids if we need to; use camel_folder_free_uids if necessary, etc. * mail-tools.c (mail_tool_move_folder_contents): Add messages to tell the user what's going on. 2000-08-24 Christopher James Lahey * folder-browser-factory.c: Fixed some warnings in the uihandler code. 2000-08-24 Peter Williams * component-factory.c (mail_load_storages): New function. Loads a list of URI's as mail storages, and inserts them into the shell's folder tree if appropriate (really, only puts them into the folder tree.) (mail_add_new_storage): Insert a storage into the folder tree. Not always appropriate (eg, /var/spool/mail/user is a storage that shouldn't be in the folder tree.) (create_view): Generate the Evolution_Shell and pass it to folder_browser_factor_new_control so that its member 'shell' can be set. (owner_set_cb): Instead of create_news_storage and creating the imap storages, load the news storages and mail storages via mail_load_storages(). * folder-browser-factory.c (control_activate): Change to use providers_config again instead of mail_config. Pass the folderbrowser so that the config code knows where to insert the new storages if any are created. Pass forget_passwords the folderbriwser, too, for good luck. (folder_browser_factory_new_control): Take a new parameter, the Evolution_Shell that we belong to. The field in FolderBrowser has been there but was never getting set by anything, and we need this to be able to insert new storages into the shell's folder list. * folder-browser.c (folder_browser_new): Accept the new Evolution_Shell parameter. Set it. (Should we ref it or something?) * mail-config-gui.c (struct MailDruidDialog): Store an Evolution_Shell. With this we can insert the stores into the shell's folder list. (struct MailDialog): Same. (service_page_item_changed): Close a leak. (identity_dialog): Unswitch the Add/Edit identity titles. (news_dialog): Analogous to above. (mail_druid_finish): Add the new mail source to the shell view. (mail_config_druid): Take a new Evolution_Shell parameter for later use. (mail_config_apply_clicked): Add all the mail sources to the shell view. (mail_config): Take a new Evolution_Shell parameter. * mail-callbacks.c (check_configured): Accept a FolderBrowser so that we know where to put the new storages if any are created. Almost all the callbacks are passed a FB * anyway so this isn't a big deal. (check_send_configuration): Make sure that we're configured enough to be able to send mail. composer_send_cb() used to do this, but it would need a FolderBrowser *, and there are too many entry points to composer_send_cb to make this feasible. (fetch_mail): Pass the extra parm to check_configured(). (free_psd): Move so that composer_send_cb can call this directly. (composer_send_cb): Don't check for proper configuration here -- it is the caller's responsiblity to call check_send_configuration(). Call free_psd() directly. (compose_msg): Call check_send_configuration(). (send_to_url): Same. This is called from mail-display.c, though, and cannot reasonably be passed a FB. So: we can't start up the config dialog directly; the user must do it manually. Oh well. (mail_reply): Same as above. (forward_msg): Same as compose_msg(). (edit_msg): Same as above. (providers_config): Reenable so that we can pass mail_config its FolderBrowser. * mail-display.c (write_data_to_file): Use the much more straightforward run_and_close to retrieve the user's answer, instead of the reply callback stuff. * mail-threads.c (mail_dialog_run): New wrapper for gnome_dialog_run that will take care of the GDK lock correctly. Far far more complicated than it should be. (mail_dialog_run_and_close): Analogous to above. (read_msg): Set inside_read_msg and unset it for the benefit of the two above functions. Don't bracket ourselves in GDK_THREADS_ENTER/_LEAVE anymore. (mail_operation_queue): Use mail_dialog_run_and_close. (show_error): As above. (get_password): As above. * mail-display.c (write_data_to_file): This has the only exception to the rule that "use mail_dialog_run(_and_close) instead of the gnome equivalent always." Not quite sure why it doesn't work here (the file selection window?). * mail-config-gui.c (identity_dialog): Change to mail_dialog_run_and_close. (source_dialog): Same as above. (news_dialog): Same as above. (cleanup_test_service): Same as above. (mail_config): Change to mail_dialog_run(). * session.c (mail_request_dialog): Change to mail_dialog_run_and_close. * mail-tools.c (mail_tool_uri_to_folder_noex): As above. * mail-ops.c (cleanup_fetch_mail): As above. * mail-local.c (local_reconfigure_folder): As above. * mail-callbacks.c (check_send_configuration): As above. (ask_confirm_for_empty_subject): As above. (edit_msg): As above. (filter_edit): As above. 2000-08-23 Dan Winship * folder-browser-factory.c (control_activate): Reformat a bit, make "Folder" appear before "Message", fill in the Message menu more. 2000-08-23 Peter Williams * mail-ops.c (describe_fetch_mail): Don't use the camel calls to describe the operation. 2000-08-22 Peter Williams * mail-tools.c (mail_tool_get_folder_from_urlname): Don't connect to the service explicitly. (mail_tool_send_via_transport): Don't connect to the transport explicitly. (mail_tool_get_root_of_store): Same. * mail-config-gui.c (do_test_service): Just try camel_session_get_service, which will now connect for us. * message-thread.h: Add a note about *next being the first member of struct _container... if it isn't, everything goes Very Wrong. * message-thread.c (free_container): Extra debug print. (remove_node): Handle the case of empty containers holding the child that we're interested in. (thread_messages_free): Extra debug print. 2000-08-20 Jeremy Wise * folder-browser.c: (fb_resize_cb) Added function to monitor resize of the e_paned in the main view. 2000-08-18 Peter Williams * mail-tools.c (mail_tool_filter_contents_into): Fix a race. filter_driver_run is an async operation so it won't even be started by the time we sync the folders and check for the movemailbox to be emtpy. Thus the empty check for the movemail would fail 99% of the time. * mail-callbacks.c (run_filter_ondemand): Pass he new argument to the ever-mushrooming filter_driver_run. 2000-08-17 Peter Williams * folder-browser-factory.c (control_activate): Fix menu item names. (register_ondemand): Put the ondemand hooks into the new folder menu. 2000-08-17 Ettore Perazzoli * mail-vfolder.c (vfolder_gui_add_rule): Use stock OK/Cancel buttons and add i18n support. * folder-browser-factory.c (control_activate): Changed menu item label from "Mark all messages seen" to "Mark All Messages as Read". Changed capitalization of some other menu items. (control_activate): Put the message- and folder- related menu items in new "Message" and "Folder" subtrees which are created in the `' item created by the shell. (control_deactivate): Updated accordingly. (control_activate): Put the filter and vfolder editors, the mail configuration and the "forget password" command into the "settings" menu. (control_deactivate): Updated accordingly. * mail-config-gui.c (transport_page_new): Add translation mark. (service_page_new): Show the menu items before appending them. (service_page_item_new): Use `GTK_FILL' for the "Detect supported types..." button. * local-config.glade: Change the apply button into an ok button. 2000-08-17 Peter Williams Implement filtering on demand. * folder-browser-factory.c (register_ondemand): New function. Callback to put the filter-on-demand filters into the bonobo UIH; (create_ondemand_hooks): New function. Read in our on-demand filters and hook them into the UI. (remove_ondemand_hooks): New function. Remove the hooks when done with them. (control_activate): Call create_ondemand_hooks() (control_deactivate): Call remove_ondemand_hooks(); * mail-callbacks.c (run_filter_ondemand): New function. Callback for running a filter on demand. (filter_edit): Pass NULLs as the new arguments to rule_context_load. * mail.h: Prototype run_filter_ondemand(); * folder-browser.c (oc_destroy): New function. Iterator to destroy an fb_ondemand_closure. (folder_browser_destroy): Free the data associated with the ondemand menu items. (my_folder_browser_init): Clear the filter_ variables. * folder-browser.h: Two new members of FolderBrowser: filter_menu_paths, a list of fb_ondemand_closures so that the menu items can be freed and removed; and filter_context, a permanently loaded FilterContext for running the ondemand filters. Prototype the new fb_ondemand_closure structure. * mail-autofilter.c (filter_gui_add_from_message): Pass NULLs as the new parameters to rule_context_load (we don't need to hook up ondemand menu items...) * mail-tools.c (mail_tool_filter_get_folder_func): Rename from get_folder_func() and make public so mail-callbacks.c:run_filter_ondemand() can use it too. (mail_tool_filter_contents_into): Use the new name of get_folder_func. Pass NULLs as the extra arguments to rule_context_load. Pass the extra source type to filter_driver_run (only use INCOMING). * mail-tools.h: Publicly prototype mail_tool_filter_get_folder_func() * mail-vfolder.c (vfolder_create_storage): Pass NULLs as the extra arguments to rule_context_load. * message-list.c (message_list_init): Free our strdup'd uids when the table model gets destroyed. (nuke_uids): New function. Walk the tree nodes to free the uids. (nuke_uids_cb): New callback for nuke_uids(); 2000-08-16 Richard Hult * mail-ops.c (cleanup_display_message): Use a configurable timeout. * mail-config.c (mail_config_set_mark_as_seen_timeout): New function for the settable mark-as-seen timeout. (mail_config_mark_as_seen_timeout): Likewise. (mail_config_write): Write the timeout setting. (config_read): Read timeout setting. * mail-config-gui.c (mail_config): Add option for the settable mark-as-seen timeout. (mail_config_apply_clicked): Likewise. (timeout_changed): New function for the timeout setting. 2000-08-16 Peter Williams * message-thread.c (walk_containers): More (default disabled) mem debugging here. Fix the big leaks. * mail-format.c (get_url_for_icon): Copy the url_path so that it can't get freed under us. * mail-threads.c (mail_operation_queue): Fix a leak. * mail-ops.c (mail_do_display_message): Fix another leak. * message-list.c (message_list_destroy): Remove the seen_id timeout if necessary. * mail-local.c (mail_tool_local_uri_to_folder): Fix a leak. * session.c (auth_callback): Fix a leak. Almost seems as if I've been using Purify... 2000-08-15 Peter Williams * message-thread.c (alloc_container): Add support for debugging container allocations -- currently disabled. Make sure that the g_strfreev works. * message-list.c (main_message_changed): Address bug #496 -- possible race when forwading a message_changed event. * mail-threads.c (dispatch): Close the dispatch thread's half of pipes when about to exit. (mail_operations_terminate): Close the main thread's half of the pipes when about to exit. (all): Add i18n support. * mail-tools.c (all): Add i18n support. * mail-ops.c (transfer_messages): Generalize move_messages into transfer_messages so that we can copy too. (all): Add i18n supprt where appropriate. * mail-ops.h: Prototype the new mail_do_transfer_messages. * folder-browser-factory.c: Add a UI hook for copy_msg. * mail-callbacks.c (transfer_msg): Generalize move so that it supports copy as well, and add a callback 'copy_msg'. * message-list.c (on_right_click): Add a right-click hook for Copy Message. * session.c (mail_request_dialog): Don't deadlock when in main thread. 2000-08-14 Peter Williams * mail-threads.c (show_error): Fix the error dialogs. (read_msg): Re-enable them. * mail-ops.c (do_scan_subfolders): Silence a compile warning. 2000-08-13 Jeffrey Stedfast * mail-crypto.c (mail_crypto_openpgp_encrypt): Added support for encrypting via PGP 5.0 2000-08-13 Ettore Perazzoli * mail-ops.c (cleanup_create_folder): Release the listener object with `CORBA_Object_release()', not `CORBA_free()'. 2000-08-13 Ettore Perazzoli * main.c (main): Set the signal handlers for `SIGSEGV' and `SIGBUS' to the default ones. 2000-08-13 Jeffrey Stedfast * mail-config.c (mail_config_write): Set config->configured to TRUE 2000-08-13 Ettore Perazzoli * mail-config-gui.c (mail_config_druid): Don't `GDK_THREADS_ENTER()'/`GDK_THREADS_LEAVE()'. 2000-08-13 Ettore Perazzoli * mail-threads.c (update_active_views): Just iterate through all the controls, not just the active ones. * folder-browser-factory.c: Don't keep track of active controls. Rather, keep track of all of them. (folder_browser_factory_get_active_control_list): Removed. (folder_browser_factory_get_control_list): New. 2000-08-13 Dan Winship * Makefile.am (evolution_mail_SOURCES): add mail-local.h 2000-08-13 Ettore Perazzoli * mail-threads.c (read_msg): For now, don't do anything about errors. 2000-08-13 Dan Winship * mail-format.c (add_url): Fix some freed-memory references * mail-threads.c (get_password): Don't free the prompt. It doesn't belong to you. 2000-08-13 Ettore Perazzoli * mail-ops.c (mail_do_create_folder): Duplicate the listener object. (cleanup_create_folder): Free the listener. 2000-08-13 Jeffrey Stedfast * mail-threads.c (get_password): Don't wrap the gnome_dialog_run in GDK_THREADS_ENTER/LEAVE 2000-08-13 Ettore Perazzoli * folder-browser-factory.c (control_destroy_cb): Remove the control from the active control list, if it's there. * mail.h (folder_browser_factory_new_control): Removed prototype. (folder_browser_factory_init): Removed prototype. * folder-browser-factory.h: New. * folder-browser-factory.c: New static variable `active_controls', list of the currently active controls. (control_activate): Add the control to it. (control_deactivate): Remove the control from it. (folder_browser_factory_get_active_control_list): New. * mail-threads.c (mail_operations_get_status): New function. * folder-browser.c (folder_browser_gui_init): Add i18n support for the labels. [The following is actually from a patch by Peter Williams .] * Removed types `PERCENTAGE', `HIDE_PBAR', `SHOW_PBAR'. New struct `block_info_s'. Removed all the code to create and destroy the progress window. 2000-08-13 Jeffrey Stedfast * component-factory.c (create_news_storage): Updated to reflect changes to mail_do_scan_subfolders (create_imap_storage): Same. * mail-ops.c (mail_do_scan_subfolders): No longer takes an add_INBOX argument 2000-08-13 Dan Winship * mail-ops.c (do_scan_subfolders): Lose a reference to the store on purpose. To be fixed later. 2000-08-12 Dan Winship * component-factory.c (create_imap_storage): Take the source as a command-line argument rather than fetching it from mail-config. (owner_set_cb): Call create_imap_storage on each configured IMAP store. * mail-format.c (decode_pgp): Redo this so that the lock icon remains active after a failed decryption so you can click on it and try again. (try_inline_pgp, handle_multipart_encrypted): Put a border around the decrypted data. * message-list.c (cleanup_regenerate_messagelist): Don't clear the tree here. If two "folder_changed"s arrive in close succession, then one possible ordering of events is cleanup_regenerate_messagelist, cleanup_regenerate_messagelist, cleanup_thread_messages, cleanup_thread_messages. Which would result in the message list being filled in twice without being cleared in between. So don't clear it until the rebuilding function itself is called. (clear_tree): New function to empty out the ETreeModel in the message list. (build_tree): Change to simpler interface. Call clear_tree. (build_subtree): Does most of the work of the old build_tree (build_flat): Remove unused arg. Call clear_tree. * message-thread.c (cleanup_thread_messages): Update for build_tree interface change. * mail-ops.c (do_send_mail): Don't leak the transport. * mail-tools.c (mail_tool_get_folder_from_urlname): Don't ref the store returned from camel_session_get_store. It's already reffed. (mail_tool_get_root_of_store): Ditto. (mail_tool_send_via_transport): Remove some commented-out code and fix it to not leave the transport connected if sending fails. * mail-callbacks.c (delete_msg): Toggling a flag is an "instantaneous" operation, so if we're only doing one, just do it and return, rather than queueing it for the other thread. This makes the "Delete" key work correctly (move to the next message) again. * mail-identify.c: Remove workaround for gnome-vfs 0.2 bug. * mail-format.c (lookup_handler): Remove workaround for function introduced between gnome-vfs 0.2 and 0.3, since we depend on 0.3 now. 2000-08-12 Michael Meeks * main.c (main): kill using_oaf assertion. 2000-08-11 Peter Williams * Makefile.am: Make it so that test-mail links 2000-08-11 JP Rosevear * folder-browser-factory.c (control_activate): Move menu items that affect a single message together, ditto with ones that affect multiple messages, put a separator in. 2000-08-11 Christopher James Lahey * mail-format.c, mail-tools.h, message-list.c: Fixed a warning. 2000-08-11 Dan Winship * mail-display.c, mail-format.c: Redo this again. Get rid of struct mail_format_data and move most of that info into MailDisplay itself, and pass the MailDisplay around. Add a GData** to MailDisplay, and put the urls hash table into that. Also add the ability to redisplay the currently-displayed message (with the same GData**), and add a "show_pgp" datum to it that controls whether or not to decrypt PGP messages, and redo the PGP stuff (again) to take that into account. Now you don't get the annoying PGP password dialog box without any warning. 2000-08-11 Peter Williams * mail-config-gui.c (service_acceptable): Make verify-service an asynchronous operation. * Makefile.am (noinst_PROGRAMS): Don't build test-thread while mail-threads.c is in flux. * mail-threads.c (mail_operation_queue): Make the error and query dialogs modal. * mail-local.c (update_progress): Don't use the temporarily-disabled mail_op_set_percentage(). 2000-08-11 Chris Toshok * mail-config.c (mail_config_get_default_news): use config->news instead of config->sources. 2000-08-11 Dan Winship * mail-format.c (destroy_part): Update this for CamelObject (try_inline_pgp): Deal with decrypting here rather than trying to pawn the data off to handle_multipart_encrypted, since it most likely won't be correct (won't have the proper MIME headers inside the encrypted part). (handle_multipart_encrypted): Add code from Nathan Thompson-Amato to re-MIME-parse the decrypted data after decrypting. * mail-crypto.c (mail_crypto_openpgp_{de,en}crypt): Get the password here rather than having it passed in. Remove some dead code. * session.c (mail_request_dialog): Allow this to work in either a sync or an async context. 2000-08-11 Peter Williams * mail-tools.c (mail_tool_fetch_mail_into_searchable): Don't do the imap check here... it's a silly place. * mail-ops.c (do_fetch_mail): Do the imap check here. 2000-08-11 JP Rosevear * mail-config-gui.c (service_page_new): Work around gtk option menu bug. (service_page_item_auth_fill): ditto 2000-08-11 Peter Williams * mail-threads.c (read_msg): Fix the new FORWARD_EVENT handler (didn't free msg, didn't write newline in the debug) * mail-local.c (local_reconfigure_folder): Make the dialog modal. * mail-callbacks.c (select_first_unread): Fix some warnings. * mail-threads.c (mail_op_forward_event): New function that writes a FORWARD_EVENT signal to the compipe, to allow Camel events to be handled in the main thread. (read_msg): Handle a FORWARD_EVENT. * mail-callbacks.c (select_first_unread): Forward the event into the main thread to prevent the GTK calls in the dispatcher thread. (main_select_first_unread): New name of old select_first_unread. * message-list.c (folder_changed): Same as above. (main_folder_changed): Same as above. (message_changed): Same as above. (main_message_changed): Same as above. * mail-format.c (free_byte_array): Note about using mail_op_forward_event. (cmm_destroyed): Same. 2000-08-11 Dan Winship * message-list.c (message_list_select): If the caller passes "-1" for the model row, translate that to view row 0. * message-list.c (idle_select_row): * mail-callbacks.c (select_first_unread): Use new message_list_select kludge^H^H^H^H^H^Hfeature 2000-08-11 JP Rosevear * mail-config-gui.c (source_dialog): Allow the window to be growable * mail-config.c: use void in empty declarations 2000-08-11 Peter Williams * mail-config.c (mail_config_get_news): Change () to (void) if a function takes no arguments. * mail-config.h: Prototype mail_config_get_{sources,news}x 2000-08-11 JP Rosevear * mail-config-gui.c (identity_dialog): iddialog, not sdialog (news_edit_clicked): Kill leftover c-p crud 2000-08-11 JP Rosevear * mail-config-gui.c (news_edit_clicked): Check nrow, not srow. 2000-08-11 JP Rosevear * mail-config-gui.c (service_acceptable): Use camel_object_unref instead of gtk_object_unref (mail_druid_finish): Use new config accessors (mail_config_druid): No need to call config functions (news_add_clicked): Increments maxnrow, not maxsrow (mail_config_apply_clicked): Use new config accessors (mail_config): ditto * component-factory.c (create_imap_storage): Use new config accessors (create_news_storage): ditto * mail-config.glade: Set news clist name correctly * mail-config.c (config_read): Rename from mail_config_read and made private - no one should need to do a read manually. (mail_config_set_send_html): New accessor (mail_config_add_identity): ditto (mail_config_get_sources): ditto (mail_config_add_source): ditto (mail_config_get_default_news): ditto (mail_config_get_news): ditto (mail_config_add_news): ditto * mail-config.h: Prototype new accessors. Config struct is now in mail-config.c and hidden from the world. 2000-08-11 Dan Winship * mail-ops.c (describe_fetch_mail): Use camel_service_get_name rather than showing the URL to the user. 2000-08-11 Peter Williams * mail-ops.c (do_refile_messages): Freeze the folders while moving. (do_flag_messages): Same. * mail-threads.c (get_password_clicked): Fix the case when the user /doesn't/ use escape to cancel the dialog :-/ (show_error_clicked): Same. 2000-08-11 Dan Winship * mail-tools.c (mail_tool_get_folder_name): Add a function to return a useful name for a folder (not just "mbox" or "mh" for any local folder.) * mail-ops.c: Use mail_tool_get_folder_name rather than folder->full_name when printing folder names. 2000-08-11 Not Zed * mail-tools.c (mail_tool_get_local_inbox_url): Properly handle different local file formats. The folder isn't always mbox. (mail_tool_do_movemail): Movemail always uses an mbox format however. (mail_tool_get_local_movemail_url): What is the mbox url, it is always the same type, mbox. (mail_tool_fetch_mail_into_searchable): Same here. * mail-local.c (mail_local_map_uri): Map a local uri to the real uri. 2000-08-10 Christopher James Lahey * folder-browser-factory.c, message-list.c, message-thread.c, session.c: Fixed some warnings. 2000-08-10 Dan Winship * session.c (session_init): Don't call e_setup_base_dir. It was wrong and it doesn't exist any more. * component-factory.c (owner_set_cb): Update for changed prototype, and record the evolution_homedir. Move call to mail_config_init here from session.c so it happens after evolution_dir is initialized. * mail.h: define "extern char *evolution_dir;" (formerly in e-util/e-setup.h) * component-factory.c, mail-callbacks.c, mail-config-gui.c, mail-config.c, mail-display.c, mail-format.c, mail-ops.c, mail-tools.c, session.c: Remove "e-util/e-setup.h" include. 2000-08-10 Peter Williams * test-thread.c (queue_ops): Use mail_operations_terminate() to close the other thread nicely. * mail-threads.c (get_password_deleted): Handle the "close" event as a cancel. (show_error): Same. 2000-08-10 Dan Winship * mail-tools.c (mail_tool_get_folder_from_urlname): Add a "gboolean create" argument to pass to camel_store_get_folder. * mail-ops.c (do_create_folder, do_setup_draftbox): * mail-local.c (mail_tool_local_uri_to_folder): * mail-vfolder.c (vfolder_uri_to_folder): Add create flag to mail_tool_get_folder_from_urlname calls. 2000-08-10 Jeffrey Stedfast * mail-callbacks.c (composer_send_cb): Fix compile warning by casting the object to a CamelObject 2000-08-10 Peter Williams * mail-tools.c (mail_tool_filter_contents_into): Delete the source folder if told to and if it's empty (mail_tool_get_local_movemail_path): New function. 2000-08-10 Dan Winship * mail-callbacks.c (reply_to_all): Fix a bug in the async changes. (This was identical to reply_to_sender.) 2000-08-10 Not Zed * mail-local.c (do_local_reconfigure_folder): Update for append_message api change. * message-list.c (message_list_regenerate): Change for search api change. (ml_tree_value_at): Add a colour column, based on the colour assigned in the summary. (message_list_init_renderers): Init colour column. 2000-08-09 Peter Williams * mail-display.c (part_for_url): Remove a gtk_object_get_data 2000-08-09 Cody Russell * folder-browser-factory.c, mail-view.c: Make the toolbars honor the user's gnomecc settings for detachable toolbars. 2000-08-09 Jeffrey Stedfast * mail-ops.c (composer_send_cb): Get the from address set in the composer, if that fails ONLY THEN get the default from mail config * mail-config.c (mail_config_get_identities): New convenience function for getting a list of the configured identities 2000-08-09 Dan Winship * mail-display.c (on_object_requested): Support controls as well as embeddables. 2000-08-09 Jeffrey Stedfast * mail-view.c (mail_view_create): Changed to only take a FolderBrowser argument * mail-ops.c (real_view_msg): Create a new FolderBrowser for each message being opened in a new window. Also set the message_list->cursor_uid and mail_display->current_message to the appropriate values. (real_view_msg): Updated to reflect changes in the mail_view_create * message-list.c (on_right_click): Nicify a little, add in a menu separator between VFolder and Filter stuff. * mail-ops.c (real_view_msg): Set the UID of the message that is being displayed 2000-08-09 Ettore Perazzoli * folder-browser-factory.c (control_activate): Use `GNOME_STOCK_MENU_*' things instead of `GNOME_STOCK_PIXMAP_*' things, that are too big and look bad. 2000-08-09 Peter Williams * mail-view.c (mail_view_create): Save the top window so that on_close can find it [with set_data]. (on_close): Recover the top window. * mail-threads.c (read_msg): Destroy the window instead of hiding it. 2000-08-09 Not Zed * mail-autofilter.c (filter_gui_add_from_message): Helper function to add with confirm. (rule_match_recipients): Dont set real name if its empty for the filter name. (rule_match_subject): was cutting ] off mailing list names. * message-list.c (on_right_click): Added menu to install vfolders/filters from message. 2000-08-09 Not Zed * mail-autofilter.c: New file to hold auto filter/vfolder stuff. 2000-08-09 Christopher James Lahey * mail-display.c, mail-format.c, mail-ops.c: Fixed some warnings. * message-list.c: Fix the call to e_popup_menu_run to match the new signature. 2000-08-09 Ettore Perazzoli * folder-browser-factory.c (control_activate): Create a "print message" menu item. 2000-08-09 Jeffrey Stedfast * message-list.c (message_list_init): Attached a double_click signal handler (on_double_click): Our lovely new double_click callback. Will display the current selected message in a new window 2000-08-08 Jeremy Wise * mail-config.[ch], folder-browser.c: Added configuration work to save the size of the vpaned widget. It will be functional when the e_paned widget emits a "resized" signal 2000-08-08 Jeffrey Stedfast * mail-config.h: Added void as an argument to functions not needing any parameters to avoid compile warnings. 2000-08-08 Jeremy Wise * mail-config.[ch], main.c, folder-browser-factory.c: State of the threaded list toggle is now saved via gnome_config 2000-08-08 Dan Winship * mail-config-gui.c (service_page_item_new): Attach a signal handler to call the "changed" function when the user clicks the "keep on server" checkbox. 2000-08-08 Jeffrey Stedfast * mail-ops.c (view_msg): New convenience function with params of a normal Gtk callback function. We also now create a new FolderBrowser object so that the message-view window isn't tied to the display in the main window (view_message): Now calls view_msg (this function is a bonobo callback and can't be used with gtk widgets) (edit_msg): Same idea as view_msg() (edit_message): Again, same as view_message() * message-list.c (on_right_click): Callback for creating an e-popup-menu (message_list_init): Added a right_click event to trigger a pop-up menu to be displayed 2000-08-08 Dan Winship * mail-config-gui.c: Add "Don't delete messages from server" button to remote SOURCEs that aren't STORAGEs (ie, POP). (provider_list): Only list SOURCEs. (ie, not mh) * mail-config.c: Save/load "keep_on_server" flag. * mail-ops.c (fetch_remote_mail): New function, split out of real_fetch_mail. Deals with copying mail from a remote server into a temporary mbox, possibly using a CamelUIDCache to leave the messages on the server. * mail-crypto.c, mail-format.c, message-thread.c: Fix some compiler warnings. * mail-format.c (mail_generate_reply): Fix up format of addresses. (write_headers): Use CamelAddress functions to simplify this. 2000-08-08 Jeffrey Stedfast * mail-view.c: Lets get rid of the last separator in the toolbar until we add n/p 2000-08-08 Ettore Perazzoli * mail-threads.c (queue_window_delete_event_cb): Callback for "delete_event", just doing nothing. (create_queue_window): Connect it to the "delete_event" signal of the progress dialog. 2000-08-08 Peter Williams * mail-threads.c (remove_next_pending): Sanity check for job queue, which seems to have some issues. (read_msg): Make sure that the next operation isn't started before the last one is cleaned up. * mail-callbacks.c (fetch_mail): Fix erroneous free. * mail-config-gui.c (mail_config_druid): Wrap the gtk_main call. * mail-ops.c (do_flag_messages): Allow specification of whether to set the flags unconditionally or toggle their current state. * message-list.c (ml_tree_set_value_at): Toggle the seen status; don't set it unconditionally. * mail-callbacks.c (delete_msg): Toggle the deletion status; don't set it unconditionally. * mail-tools.c (mail_tool_do_movemail): Fix for undeclared tmpfd. * mail-local.c (local_reconfigure_folder): Big rewrite; make into an asynchronous operation. Use some mail tools to make life easy. 2000-08-08 Dan Winship * main.c (main): Move mail_config_init after session_init, since it depends on evolution_dir being set. 2000-08-08 JP Rosevear * mail-ops.c (check_configured): Use config accessors (fetch_mail): ditto (composer_send_cb): ditto (create_msg_composer): ditto * mail-config-gui.h: Update API * mail-config.h: Update API * mail-config.c: Add accessor functions (mail_config_is_configured): accessor function (mail_config_get_default_identity): ditto (mail_config_get_default_source): ditto (mail_config_get_transport): ditto (mail_config_send_html): ditto (identity_copy): Make public (identity_destroy): ditto (identity_destroy_each): ditto (service_copy): ditto (service_destroy): ditto (service_destroy_each): ditto (mail_config_init): Rename from init_config and make public (mail_config_clear): Rename from clear_config and make public (mail_config_read): Rename from read_config and make public (mail_config_write): Reanme from write_config and make public * main.c (main): Call mail_config_init. * mail.h: Include mail-config-gui.h * mail-config-gui.c: Move config gui stuff here. (source_dialog): Kill memory leak from debug leftovers. Make sure returned source is NULL by default 2000-08-07 Not Zed * mail-local.c (local_reconfigure_folder): Redone to show a dialogue first, and show progress of whats happening as its done. * Makefile.am (glade_DATA): Added local-config.glade, for mailbox reconfig dialogue. 2000-08-04 Not Zed * folder-browser.c (mail_uri_to_folder): Use local_uri_to_folder() for local uri's (file://). * mail-local.c (local_uri_to_folder): Handle looking up folder storage type before opening the store/folder. (local_reconfigure_folder): Function to reconfigure the format of a local mailbox into another storage format. * Makefile.am (evolution_mail_SOURCES): Added mail-local.c and missing mail-vfolder.h. 2000-08-07 Jeffrey Stedfast * Makefile.am: Added mail-view.c * folder-browser-factory.c (control_activate): Adda menu item for viewing the message * mail-view.c: New file containing methods for viewing messages in separate windows * mail-ops.c (view_message): New callback for viewing messages in a new window. 2000-08-07 Jeffrey Stedfast * component-factory.c (real_create_generic_storage): New function to replace real_create_imap_storage and real_create_news_storage (create_imap_storage): Updated. (create_news_storage): Updated. 2000-08-07 Peter Williams * mail-ops.c (cleanup_edit_messages): New operation: edit_messages For continuing draft messages. (attach_messages): Fix accidental 0 datasize. (do_setup_draftbox): New operation: setup_draftbox. Soooo hacky. * mail-callbacks.c: Move fejj's edit message to the async home. * component-factory.c (owner_set_cb): Use mail_do_setup_draftbox. 2000-08-07 Jeffrey Stedfast * mail-display.c: * component-factory.c: s/strncasecmp/g_strncasecmp * mail-format.c (write_headers): Get rid of kludge around subject beginning with spaces. (mail_generate_reply): Get rid of kludge around subject beginning with spaces and also use g_strncasecmp instead of strncasecmp for portability * mail-ops.c (forward_msg): Get rid of kludges around subject beginning with spaces. 2000-08-07 Dan Winship * message-list.c (message_list_select): Clarify that the input row is a model row, and swap it to a view row when finding the next/previous row. (idle_select_row): Select view row 0, not model row 0. * mail-ops.c (select_first_unread): Start from view row 0, not model row 0. 2000-08-07 Jeffrey Stedfast * mail-format.c (mail_get_message_body): Renamed from reply_body() so other functions can use it (mail_generate_reply): Updated to reflect function name changes * mail-ops.c (real_edit_msg): Attach a callback to the send signal 2000-08-07 Jeffrey Stedfast * folder-browser-factory.c (control_activate): New menu item under Actions to allow editing of messages. * mail-ops.c (edit_message): New function for editing messages. * component-factory.c (owner_set_cb): Create a global reference to the Drafts mbox folder for the Composer to use 2000-08-06 JP Rosevear * mail-config.c (ndialog_page_undone): Desensitize ok button (sdialog_page_undone): ditto (iddialog_page_undone): ditto (news_page_new): Typo - news, not mail (transport_page_new): Typo - transport, not source (identity_dialog): Set undone callback (source_dialog): ditto (news_dialog): ditto (mail_druid_identity_undone): Desensitize next button and mark done flag as false (mail_druid_source_undone): ditto (mail_druid_transport_undone): ditto (mail_druid_identity_done): Mark done flag as true (mail_druid_source_done): ditto (mail_druid_transport_done): ditto (mail_druid_prepare): Use done flag to set next button sensitivity, fixes #467 2000-08-06 Jeffrey Stedfast * mail-crypto.c (mail_crypto_openpgp_encrypt): Added support for encrypting with GnuPG. Support for PGP5 and PGP2 are still in progress. 2000-08-05 Dan Winship * folder-browser-factory.c (control_activate): Remove bonobo 0.15 vs 0.15-and-a-half ifdef, since we require post-0.16 now. 2000-08-04 Dan Winship * mail-threads.c (mail_operation_wait_for_finish): Don't use "while (gtk_events_pending ()) gtk_main_iteration ();" inside another tight loop, because it makes the thread spin rather than blocking and waiting like it should. 2000-08-04 Peter Williams * message-thread.c (do_thread_messages): Uninitialized variable fix. * mail-threads.c (read_msg): Small leak fix. * component-factory.c (owner_unset_cb): Use mail_operations_ terminate() instead of wait_for_finish(). * mail-threads.c (mail_operation_queue): Centralize the clur handling functions; fix a race condition where the dispatcher would overwrite the closure before the main thread could free the old one. (mail_operations_terminate): New function, wait for ops to finished and kill the other thread. (dispatch): changes to die when terminate is called (abort on NULL spec). * mail-ops.c (cleanup_display_message): Fix improper handling of displaying a NULL message (which means clear the message display). 2000-08-04 Ettore Perazzoli * message-list.c (message_list_regenerate): Free the GPtrArray correctly instead of using `g_strfreev()'. 2000-08-04 Michael Meeks * folder-browser-factory.c (control_activate): release the ui_handler after set_container. 2000-08-03 Michael Meeks * mail-config.c (identity_page_new): only whack the sig in if the file exists. * component-factory.c (factory_fn): count running instances, attach destroy signal (factory_destroy): add. * main.c (main): pass orb around. 2000-08-03 Jeffrey Stedfast * mail-ops.c (composer_send_cb): Yay, no more compiler warnings * mail-config.c: set config = NULL (provider_list) Eek! Initialize news to NULL! Also, use g_slist_prepend() for "performance" gains ;-) (init_config): Set the config member data to NULL just to be on the safe side (clear_config): Don't bother freeing slist data if the slist is NULL 2000-08-03 Peter Williams * mail-ops.c (op_forward_messages): Use the new dynamic operation naming. * message-thread.c (describe_thread_messages): Ditto. * message-list.c (describe_regenerate_messagelist): Ditto. * mail-threads.c (get_password_clicked): Dynamic generation of descriptive text for mail operations. "Opening a folder" -> "Opening INBOX". Supported only so far, will be implemented quickly. g_strdup() the old_message when changing the queue_window_label's text. * main.c (main): One more gconf reference to take out... * mail-ops.c (composer_send_cb): Check for an identity before sending. 2000-08-03 JP Rosevear * mail-config.glade: Increase window size slightly, rename "Transport" to "Mail Transport" * mail-config.c (init_config): Remove gconf references (clear_config): ditto (read_config): ditto (write_config): ditto (mail_config): Null provider lists before filling them (mail_config_druid): ditto (identity_page_new): Increase spacing of vbox (service_page_new): ditto * Makefile.am: Remove gconf references. 2000-08-02 Dan Winship * mail-config.c (service_page_item_new): Make the "test settings" button FILL rather than SHRINK so it doesn't end up oddly-placed. * mail-config-druid.glade: Make the icon background dark blue like the surrounding area. 2000-08-02 Peter Williams * component-factory.c (owner_unset_cb): Wait for async operations to finish before exiting. 2000-08-02 Christopher James Lahey * mail-ops.c, message-list.c: Emit "model_pre_change" where appropriate. 2000-08-02 Peter Williams * mail-config.h: #ifdef _MAIL_CONFIG_H protect the header. 2000-08-01 Peter Williams * mail-threads.c: Implement Solaris threads. Attempt to join to the thread upon exit -- hopefully prevents all those nasty zombie processes from popping up :-( 2000-08-01 Dan Winship * mail-crypto.c: New code to spawn off GPG/PGP to do stuff. Currently only deals with decryption. From Nathan Thompson-Amato , with bunches of changes from me. * session.c (mail_request_dialog): Expose the password dialog to the rest of the app (for use by the GPG/PGP code). * mail-format.c (handle_text_plain): Handle special inline data types. (Currently uuencoding, BinHex, and PGP encryption.) This is not the best way to deal with it, but it works for now. (try_inline_pgp): Convert an inline PGP-encrypted message into a multipart/encrypted part. (try_inline_binhex): Convert an inline BinHex attachment into an application/mac-binhex40 part (which we currently don't deal with...) (try_uudecoding): Convert a uuencoded attachment to an application/octet-stream part. (handle_multipart_encrypted): Deal with RFC2015 MIME-encoded PGP encrypted messages. (From ndt.) * mail-display.c (mail_text_write, mail_error_write): New utility functions. * Makefile.am (evolution_mail_SOURCES): add mail-crypto.c 2000-07-31 Christopher James Lahey * component-factory.c, folder-browser.c: Fixed some warnings. * message-list.c: Made the icon column non sortable. 2000-07-31 Dan Winship * mail-config.c (service_page_set_url): Fix a NULL-pointer strcmp noticed by peterw. 2000-07-31 Not Zed * mail-vfolder.h: Header for vfolder functions. * folder-browser.c (mail_uri_to_folder): Use new scheme to open vfolders. (search_save): New button/function to save a search as a vfolder. * mail-vfolder.c (vfolder_edit): Made asynchronous. (vfolder_uri_to_folder): New function for loading vfolders and setting up their source folders. (vfolder_refresh): Change shell vfolder uri's to indirect references rather than the real vfolder uri. (vfolder_gui_add_rule): Add a rule with user confirmation. (vfolder_create_part): Get a new part by name, for creating rules in code. * message-thread.c (thread_messages): Check for uid lookup failure, which indicates an error in the folder or calling code. 2000-07-29 Not Zed * component-factory.c (create_view): Remove hack to pass the storage around. * folder-browser-factory.c (control_activate): Changed to call renamed vfolder editor. * mail-ops.c (vfolder_edit_vfolders): renamed from vfolder_edit, call new edit function. (vfolder_editor_clicked): Removed. (filter_druid_clicked): (filter_edit): Updated for api change. (real_fetch_mail): Fixed up for api change and fucked up indent. (filter_get_folder): callback for filter driver. * mail-vfolder.c: New file to manage virtual folders. 2000-07-29 JP Rosevear * mail-format.c (mail_generate_reply): Use new mail config stuff * component-factory.c (create_imap_storage): Use new mail config stuff (create_news_storage): ditto * evolution-mail.schemas: Gconf schema for evolution mail * mail-config-druid.glade: Gladification of config druid * mail-config.h: New header with config structs. * mail-config.c: Rewrite of GUI configuration tools to use new config structs. Stores multiple identities and sources now. Still only uses the first one found. (mail_config_fetch): Returns MailConfig struct to caller for configuration queries. (mail_config): Renamed function to show mail config dialog. (mail_config_druid): Renamed function to show mail config druid. * mail-ops.c (create_msg_composer): Use e_msg_composer_new_with_sig_file and new config stuff (check_configured): Use new config stuff (fetch_mail): ditto (composer_send_cb): ditto 2000-07-28 Cody Russell * mail-ops.c, mail.h: Added mark_all_seen(), to mark every message in the list with CAMEL_MESSAGE_SEEN. * folder-browser-factory.c: Added "Actions/Mark all seen". 2000-07-27 Jeffrey Stedfast * mail-config.c: Lets fix Dan's kludge the Right Way (tm) (set_service_url): Only strip off the leading "/" from the url->path if url->host is NULL (get_service_url): Only prepend a leading "/" to the path if the host is NULL 2000-07-27 Dan Winship * mail-config.c (get_service_url): toss in a kludge to deal with the IMAP vs mbox path problem for now. 2000-07-26 Christopher James Lahey * message-list.c, message-list.h: Removed counting of selected messages. 2000-07-26 Dan Winship * mail-ops.c (real_fetch_mail): Don't create the tmp_mbox before calling movemail, because the external movemail requires it to not exist. Contrariwise, delete it in the cleanup code if it's empty. Update for camel_movemail interface change. Do the "No new messages" dialog in the mbox case as well as the remote mail issue. 2000-07-26 Jeffrey Stedfast * mail-ops.c: s/struct refile_data/struct move_data (real_move_msg): Renamed from real_refile_msg() (move_msg): Renamed from refile_msg() * folder-browser-factory.c: Changed Refile to Move. 2000-07-26 Dan Winship * mail-format.c (lookup_handler): Update for OAF and for external apps as well as components. (handle_via_external): Handler to set up for data that can be displayed by an external application. * mail-display.c (on_link_clicked, etc): Refactor the save_data() code and add launch_external() as a handler for x-evolution-external URLs. (embeddable_destroy_cb): Remove this, since it seems like it's all wrong. (on_object_requested): Update for OAF, and fix some bugs. 2000-07-25 Jeffrey Stedfast * mail-config.c (get_service_url): Always prepend a leading "/" to the url->path. (set_service_url): Added more error checking and also strip the leading '/' from the url->path (create_identity_page): Set the signature file to the one specified in the identity record, else set the default path to ~/.sugnature 2000-07-25 Michael Meeks * mail-config.c (create_identity_page): set default signature to ~/.signature 2000-07-25 Peter Williams * mail-ops.c (reply): Check for the case of fb->mail_display-> current_message = NULL, which shouldn't happen, but has happened to me. 2000-07-25 Dan Winship * message-thread.c (group_root_set): Don't group together messages with the same non-Re: subject and no References/In-Reply-To. More often than not, they're unrelated. (eg, "[No subject]".) (thread_messages): Handle messages with no Message-Id. "This shouldn't happen", but it does sometimes, and it's not much code to make it just work. 2000-07-25 Ettore Perazzoli * mail-config.c (create_service_page): Call `gtk_option_menu_set_menu()' as the last thing, as `GtkOptionMenu' is fscking broken. Also, `gtk_widget_show()' the individual menu items. 2000-07-24 Dan Winship * message-list.c (mark_msg_seen, ml_tree_set_value_at, message_list_regenerate): Update for CamelFolder API changes. (Certain functions no longer take a CamelException.) * mail-ops.c (real_fetch_mail, real_send_mail, real_delete_msg): ditto * component-factory.c (real_create_imap_storage, real_create_news_storage): ditto 2000-07-24 Dan Winship * component-factory.c, folder-browser-factory.c, test-mail.c: Remove GOAD support. * main.c: Remove GOAD support. (main): More "guess the build mistake" fun, this time for the failure to initialize Bonobo case. 2000-07-24 Peter Williams * mail-tools.c (mail_tool_set_uid_flags): Change function to faithfully pass parameters to camel_folder_set_message_flags; this function is somewhat useless now. Other files synced with API change. * mail-ops.c (op_display_message): Change "display a message" into "retrieve a messsage" in the description of mail_op_display_message. * mail-threads.c (display_timeout): New function. Only display the progress dialog if the operation takes more than a second to perform. (hide_queue_window): New function. Hide the queue window as an idle function... I'm thinking maybe the problem with hiding it was due to us not being in a GTK event sequence? Perhaps it's only the timeout, which was not being cancelled, which is now. * message-list.c (get_message_uid): New function, copy of get_message_info, except gets only the UID, as that's all that most functions want, and we avoid a Camel call. 2000-07-23 Ettore Perazzoli * mail-ops.c (create_message_composer): New. (compose_msg): Use it. (send_to_url): Likewise. (forward_msg): Likewise. * folder-browser-factory.c (control_activate): Use `_()' instead of `N_()'. 2000-07-21 Peter Williams * message-thread.c (setup_thread_messages): New operation: thread_messages, simple wrapper around thread_messages () and thread_messages_free(); * message-list.c (cleanup_regenerate_messagelist): Use new thread_messages operation instead of just calling ... thread_messages :-) * folder-browser.c (folder_browser_destroy): Use new sync_folder operation instead of calling camel_folder_sync directly. * component-factory.c (create_folder): Changed to use new create_folder operation. * mail-ops.c (mail_do_create_folder): New operation: create folder. New operation: sync folder. * mail-format.c (cmm_destroyed): Remove the url hashtable from the larger hashtable when it gets destroyed. * mail-callbacks.c (fetch_mail): Pass a hook function and data down the chain to pick up the folder_changed and change the view. * mail-ops.c: Rename from mail-ops-new.c now that it's a little more solid. (fetch_mail): Add new options to hook and unhook an event while the filter driver runs. A hack, but all of the operations are to some extent. (cleanup_fetch_mail): Unref the destination folder if not NULL. * mail-tools.c (mail_tool_filter_contents_into): Intermediate the event hook/unhook hack here. 2000-07-20 Peter Williams * mail-ops-new.c (setup_send_mail): Fix silly forgetting-to-ref problem on some sends (when not replying). Note the early exit path with a big comment. * message-list.c (message_list_set_folder): Don't call folder_changed, call mail_do_regenerate_messagelist, as the GDK_THREADS_ENTER in the former can deadlock us! * folder-browser.c (folder_browser_set_uri): Ah, screw it. Make 'load folder' asynchronous and pretend that it always succeeds. * mail-ops-new.c (mail_do_load_folder): New operation, loads a folder into a FolderBrowser. * mail-threads.c (read_msg): Check if the exception is a user cancel; don't complain if it is. (mail_operation_queue): Same. (dispatch_func): Same. 2000-07-20 Peter Williams * mail-ops-new.c (cleanup_send_mail): Fix evil mistaken unref. * test-thread.c: Fit the new mail_operation_spec prototype. * mail-callbacks.c (composer_send_cb): Hide the composer upon start of send operation. * folder-browser.c: #include "mail-ops-new.h" * mail-threads.h: Change text fields of mail_operation_spec to provide two forms of the name. * mail-threads.c: Use appropriate new string fields. (dispatch_func): Hide the progressbar by default. * message-list.c (op_regenerate_messagelist): Fix the datasize from 0 -> sizeof (regenerate_messagelist_data_t). Add the new gerund and infinitive strings. (do_regenerate_messagelist): Include some code that fell between the cracks. * mail-ops-new.c (op_scan_subfolders): Same datasize fix for scan_subfolders. (op_forward_message): Same. (all): Add new gerund and inifinitive strings for mail_operation_spec. (cleanup_send_mail): Destroy the composer on success; re-show it on error. I'm so clever! 2000-07-20 Ettore Perazzoli * component-factory.c (factory_fn): Updated for the new `evolution_shell_component_new()' arg. 2000-07-19 Jeffrey Stedfast * message-thread.c (thread_messages): What if message info is NULL? 2000-07-17 Peter Williams * component-factory.c (real_create_{imap,news}_storage): Instead of directly calling evolution_storage_new_folder, queue up a list of folders to register so that we don't do our CORBA in The Other Thread. (create_{imap,news}_storage): Changes ancillary to the above. (add_new_mailbox): New function to queue up a folder (cleanup_create_info): New function to dequeue the folders and free mem. * test-thread.c: s,ENABLE_BROKEN_THREADS,USE_BROKEN_THREADS -- oops * mail-format.c: (mail_lookup_url_table): New function to get the url table associated with a CamelMimeMessage because we can no longer gtk_object_get_data on it. * mail-display.c: replace 'gtk_object_get_data( message, "urls" )' with 'mail_lookup_url_table( message )' 2000-07-16 Jeffrey Stedfast * folder-browser.c, component-factory.c: Initial code to support IMAP folders that don't use "/" as a directory separator. 2000-07-15 Ettore Perazzoli * mail-ops.c (set_x_mailer_header): New helper function to set the `X-Mailer:' header to to `Evolution [Developer Preview]". (real_send_mail): Call it. 2000-07-14 Peter Williams * message-list.c (message_list_set_folder): Ported to CamelObject: GTK_OBJECT->CAMEL_OBJECT; gtk_signal_connect->camel_object_hook_event; GDK_THREADS_ENTER/LEAVE around "changed" event hooks. * folder-browser.c (folder_browser_destroy): likewise. (mail_uri_to_folder): likewise. (folder_browser_load_folder): likewise. 2000-07-14 Ettore Perazzoli * Makefile.am (evolution_mail_LDADD): Add `GCONF_LIBS'. 2000-07-14 Dan Winship * mail-format.c (write_headers): put a

    at the end of the header table. (I think there used to be whitespace after it, but then some gtkhtml change got rid of it...) (handle_text_plain): Don't do this 

    . Instead, CONVERT_NL and
	CONVERT_SPACES and wrap it in . Now if the sender didn't
	include any newlines, it will be wrapped to the width of the
	window instead of extending off into infinity.

2000-07-13  Dan Winship  

	* message-list.c (message_list_destroy): Only unref the folder if
	it's been set.

	* folder-browser.c (folder_browser_destroy): Only sync the folder
	if it's been set.

2000-07-13  Jonathan Blandford  

	* mail-config.c (create_transport):
	s/CAMEL_SERVICE_NEED_HOST/CAMEL_SERVICE_URL_NEED_HOST.

2000-07-13  Dan Winship  

	* mail-config.c (add_row): Add a "gboolean required" argument, and
	set its value on the entry.
	(create_source, create_transport): Create rows for URL elements if
	the URL ALLOWs them. Mark them required if it NEEDs them.
	(service_note_doneness): Only require the required fields to be
	filled in.

	Now the IMAP config page allows the user to enter a path, but
	doesn't require it.
	
2000-07-13  Jeffrey Stedfast  

	* mail-ops.c (real_fetch_mail): Back to the old way to avoid
	g_warnings, yay. Also fix append to send a flags argument (0)

2000-07-12  Chris Toshok  

	* mail-config.c (providers_config_new): fix some cut & paste bung.

2000-07-12  Chris Toshok  
	
	* mail-format.c (setup_function_table): add "message/news" to the
	mime_function_table using the same handler as message/rfc822.

2000-07-12  Chris Toshok  

	* mail-config.glade*: add news server tab to dialog.

	* mail-config.c (on_NewsServerConfigDialogButton_clicked): new function.
	(on_clistNewsServers_select_row): new function.
	(on_cmdNewsServersAdd_clicked): new function.
	(on_cmdNewsServersEdit_clicked): new function.
	(on_cmdNewsServersDelete_clicked): new function.
	(providers_config_new): mirror the source tab's code to fill in
	the news server tab.
	(write_config): save out the news server.
	(create_news_server_config_dialog): new function.
	(create_news_server_page): new function.

2000-07-12  Peter Williams  

	* mail-display.c (save_data): Change from evolution_dir to
	g_get_home_dir() for default location of save file.

2000-07-11  Dan Winship  

	* Update for CamelFolder API changes

2000-07-11  Jeffrey Stedfast  

	* mail-ops.c (real_fetch_mail): Changed to use 
	camel_folder_move_message_to () rather than get_message () and then
	append_message (). This also makes it so we don't have to worry about
	fetching message flags to pass to the new append_message () method.

	* folder-browser.c (folder_browser_load_folder): Disable
	Search capability menu/entry if folder doesn't support it.

	* message-list.c (message_list_regenerate): Don't perform
	a search if the folder doesn't support it.

2000-07-11  Dan Winship  

	* mail-ops.c (real_send_mail): Set the post_send_data flag rather
	than toggling it. (Maybe we'll need more control over it later,
	but for now, the only flag we set is "replied", and we want
	that set, not toggled.)

2000-07-10  Dan Winship  

	* folder-browser-factory.c (control_activate): Work with both
	current and 0.15 bonobo

	* kill more debugging messages

	* mail-ops.c (real_fetch_mail): Don't multiply free dest_url.

	* message-list.c (message_list_select): Update
	message_list_select_next to do either next or previous.

	* folder-browser.c (etable_key): Make 'n' and 'p' do next and
	previous unread message.

	* mail-ops.c (select_first_unread): Update.
	(real_fetch_mail): clean up a bit.

2000-07-10  Ettore Perazzoli  

	* mail-ops.c (forward_msg): Initialize `fwd_subj' to NULL if
	`from' is NULL.

2000-07-10  Jeffrey Stedfast  

	* mail-ops.c (real_fetch_mail): Fixed broken POP fetching

2000-07-10  Ettore Perazzoli  

	* component-factory.c: Removed variable `browsers'.
	(create_view): Don't update it.
	(owner_unset_cb): Don't sync the folders here anymore, because at
	this point the folder browser is dead already so we cannot get a
	valid list of folders from it anymore.

	* folder-browser.c (folder_browser_destroy): Sync the associated
	mailbox first.

2000-07-10  Christopher James Lahey  

	* message-list.c, message-list.h: Switched from ETable to
	ETableScrolled.

2000-07-10  Jeffrey Stedfast  

	* mail-ops.c (real_fetch_mail): Fixed movemail so that it too would
	deliver to Inbox.

2000-07-09  Dan Winship  

	* message-list.c (get_message_info): Don't g_warn if the user
	selects a fake tree parent.
	(message_list_select_next): Ignore fake rows
	(build_tree): Store the "root_subject" for fake rows
	(ml_tree_value_at): Display the correct subject for fake rows.
	(on_cursor_change_cmd): Update for the other changes and set
	cursor_uid to NULL when the cursor is on a fake row.

	* mail-ops.c (reply): Don't try to reply when no (real) message is
	selected.
	(forward_msg): Ditto.

2000-07-09  Christopher James Lahey  

	* message-list.c: Remove setting of dnd_code since that's handled
	internally to ETable.

2000-07-08  Dan Winship  

	* folder-browser.c (etable_key): Fix up the pageup/pagedown
	increment a bit.

	* folder-browser-factory.c (control_activate): Add a "Threaded
	Message List" item to the "View" menu.

	* message-list.c (message_list_toggle_threads): Handler for that.
	(build_flat): New function to build a "flat" message list using
	the tree model.
	(message_list_regenerate): Build tree or flat message list
	depending on the global setting.

	* message-thread.c (get_root_subject): fix a "Re:" parsing bug

2000-07-08  Jeffrey Stedfast  

	* mail-ops.c (real_fetch_mail): Always dump incoming messages to
	Inbox (assuming not filtered to another location).

2000-07-08  Ettore Perazzoli  

	* folder-browser-factory.c (control_activate): Move the
	"Expunge" item to the "Action" menu.
	(control_deactivate): Accordingly.

2000-07-08  Dan Winship  

	* mail-ops.c (forward_msg): Deal with having multiple selected
	messages.

	* mail-format.c (mail_generate_forward): Removed. (Integrated into
	forward_msg)

2000-07-08  Jeffrey Stedfast  

	* message-list.c (build_tree): Small fix to stop uid data from
	being set on a message-list tree node when it didn't correspond
	to an actual message.

2000-07-08  Dan Winship  

	* message-list.c (get_message_info): Fix Jeff's FIXME: This does
	get called with out-of-range data sometimes, so we do need the
	check. Use e_table_model_row_count to get the actual right answer.

2000-07-07  Jeffrey Stedfast  

	* message-list.c (get_message_info): This wasn't quite right, it
	will now work but still isn't perfect. See FIXME comment.

2000-07-07  Dan Winship  

	* message-thread.c (remove_node): Add another argument "clast"
	pointing to the container before the current one in the list,
	which it can update if that turns out to be the one that it
	removed.
	(group_root_set): Update for remove_node change, and remove both
	nodes in the "subjects are common" case. Fixes a bug that would
	cause the message list to be truncated if this rule was invoked.

	(sort_node): sort the tree by the original order of the messages
	in the folder rather than by date.

2000-07-07  Dan Winship  

	* message-list.c: Lots of changes. Store uids as node data on the
	tree nodes and use those rather than rows where possible. (The
	concept of "row" is just getting too complicated.) Get rid of the
	summary_table, because given a uid we can call
	camel_folder_get_message_info, which makes more sense than keeping
	a separate uid->row hash table ourselves.

	(get_message_info): update
	(get_message_row): removed
	(ml_col_cound, ml_row_count, ml_value_at, ml_set_value_at,
	ml_cell_is_editable, ml_duplicate_value, ml_free_value,
	ml_initialize_value, ml_value_is_empty, ml_value_to_string):
	Removed. We always use the tree model now.
	(message_list_init): Remove the non-tree code.
	(build_tree): store uids in the tree rather than row numbers,
	and build the message_list->uid_rowmap to map from uids to rows
	when needed.
	(message_list_regenerate): Renamed from _set_search, since it's
	used to redraw in non-search cases too.
	(message_changed): Use the uid_rowmap to get a model row number.

	* message-thread.c (thread_messages): Change the interface on this
	to work with the new MessageList.

	* folder-browser.c (search_set, folder_browser_clear_search): 
	s/message_list_set_search/message_list_regenerate/

2000-07-07  Christopher James Lahey  

	* message-list.c (get_message_info): Handle a row number of -1
	properly.

2000-07-06  Dan Winship  

	* message-list.c (get_message_info): Map tree model row numbers to
	summary row numbers.
	(ml_tree_value_at, ml_tree_set_value_at,
	ml_tree_is_cell_editable): So don't do that here.

2000-07-06  JP Rosevear  

	* mail-config.glade*: Glade files for the configuration dialog.
	
	* mail-config.c (providers_config_new): Build the dialog with
	glade.

2000-07-06  Dan Winship  

	* folder-browser-factory.c, folder-browser.c, mail-ops.c,
	message-list.c: fix warnings.

	* main.c (main): gtkhtmllib_init is no more. Call gconf_init
	directly instead.

	* message-list.c (message_list_select_next): New function to
	select the first message on or after the given row that meets
	certain flag criteria.

	* mail-ops.c (real_fetch_mail): call message_list_select_next to
	select first unread message in current folder if it changes.
	(real_delete_msg): Remove the code to move the etable cursor. It
	only makes sense really if you deleted the message with the
	keyboard, so do it from etable_key.

	* folder-browser.c (etable_key): call message_list_select_next to
	select next non-deleted message after Delete.

	* mail-identify.c: Add a workaround for a small gnome-vfs 0.2 bug
	so we don't need to require CVS gnome-vfs.

2000-07-06  Not Zed  

	* message-thread.c (sort_thread): sort messages based on date for
	the initial sort order.
	(thread_messages_free): Implement.

	* message-list.c (message_list_init_header): Setup the subject
	renderer to a tree in tree mode.
	(on_cursor_change_cmd): For a tree model, map the view row to the
	data row.
	(build_tree): Builds the tree data structure of all messages.
	(message_list_set_search): For a tree model, build the tree here.
	(ml_tree_icon_at): Icon callback, returns nothing.
	(ml_tree_value_at):
	(ml_tree_set_value_at): 
	(ml_tree_is_cell_editable): Maps tree node to data row, and calls
	the equivalent table callback
	(message_list_init_renderers): Setup the tree renderer if needed.
	(message_list_init): set the root node invisible afterall.
	(message_list_set_search): Clear the old tree before putting in a
	new one.

	* message-list.h: Add a tree renderer to render list, and
	tree_view indicator.

	* message-thread.[ch]: Code for message threading. 

2000-07-05  Dan Winship  

	* mail-identify.c (mail_identify_mime_part): Oops. My gnome-vfs
	was out-of-date. Update for changed function name.

2000-07-05  Dan Winship  

	* mail-identify.c (mail_identify_mime_part): Use the gnomevfs
	sniff buffer interface to try to identify the MIME type when
	everything else fails.

	* mail-display.c (on_object_requested):
	* mail-format.c (lookup_handler, handle_undisplayable,
	handle_audio): s/gnome_mime/gnome_vfs_mime/

	* Makefile.am: Add gnomevfs stuff

2000-07-03  Ettore Perazzoli  

	* component-factory.c (create_folder): Get rid of a compiler
	warning by making sure `folder' is always initialized to some
	value for any code path.

2000-07-03  Dan Winship  

	* message-list.c (select_msg): call mail_display_set_message with
	NULL if the message we tried to select doesn't exist (probably
	meaning we tried to selecte the first message and the folder is
	empty.)

	* mail-display.c (mail_display_set_message): deal with NULL as an
	input (meaning "undisplay previous message and display nothing").

2000-07-02  Dan Winship  

	* mail-ops.c (real_fetch_mail): Remove hack to redisplay the
	inbox, since folder_changed signals will now be emitted
	appropriately.

	* component-factory.c (create_vfolder_storage): Fix
	filter_driver_new invocation.

	* Makefile.am (bin_PROGRAMS): test-mail and test-thread should be
	noinst.

	* mail-ops.c (real_fetch_mail): 
	(vfolder_editor_clicked): 
	* component-factory.c (create_vfolder_storage):
	Pass mail_uri_to_folder and rules to filter_driver_new.

2000-07-02  Ettore Perazzoli  

	* folder-browser.c (mail_uri_to_folder): Fix double freeing of the
	local exception `ex'.

2000-07-01  Ettore Perazzoli  

	* mail-ops.c (refile_msg): Only allow type "mail" in the folder
	selection dialog.

2000-07-01  Dan Winship  

	* pixmaps.h, pixmaps/*.xpm: Removed. These aren't being used any
	more. (The real pixmaps are in ../art.)

2000-07-01  Jeffrey Stedfast  

	* message-list.c (get_message_info):
	(select_msg): Updated to reflect camel-folder changes.

	* mail-ops.c (real_fetch_mail): Modified to reflect camel-folder
	changes.

2000-06-30  Dan Winship  

	* mail-ops.c (print_msg): Use gnome-print to do a print preview.

	* folder-browser-factory.c: Hook up "Print" button.

	* message-list.c (message_list_foreach): New function, a wrapper
	around e_table_selected_row_foreach, which calls the callback
	function with UIDs rather than row numbers.

	* folder-browser-factory.c: Remove never-used "Find" button from
	the toolbar and replace it with "Refile". (We need a better icon
	for this...). Hook up "Refile" to "refile_msg".

	* mail-ops.c (refile_msg): Call the shell's user_select_folder
	routine, and then use message_list_foreach and real_refile_msg to
	do the work.
	(delete_msg): Update to use message_list_foreach.

	* folder-browser.c (mail_uri_to_folder): new function, extracted
	from folder_browser_load_folder, to turn a URI into a folder.
	(folder_browser_load_folder): Use it.

2000-06-30  Peter Williams  

	* component-factory.c (create_news_storage, create_imap_storage):
	Fixed to use new EvolutionShellClient proxy thingamajiggie.

2000-06-30  Dan Winship  

	* message-list.c (on_row_selection): use the ETable row_selection
	signal to track how many rows are selected. Eventually we will use
	this info to disable toolbar buttons when you have too few/too
	many messages selected, but the current toolbar widget doesn't
	allow that.

	* message-list.h, message-list.c, mail-ops.c: Change selected_row
	and selected_uid fields of MessageList to cursor_row and
	cursor_uid to be more correct according to the new ETable
	interfaces.

2000-06-30  Ettore Perazzoli  

	* component-factory.c: Eeek.  Fix typo: add missing star in the
	declaration of `global_shell_client'.

2000-06-29  Ettore Perazzoli  

	* component-factory.c: Replace `global_shell_interface' with
	`global_shell_client'.

2000-06-29  Jeffrey Stedfast  

	* mail-ops.c (delete_msg): Clean up compile warnings
	(real_fetch_mail): Fetching from IMAP should do nothing

2000-06-29  Christopher James Lahey  

	* mail-ops.c: Handle multiple deletes (change by Peter Williams.)

2000-06-29  Jeffrey Stedfast  

	* folder-browser-factory.c: Changed "Send" to "Compose" to
	avoid user confusion. Compose is a little more intuitive.
	Also changed the pixmap to MAIL_NEW instead of MAIL_SND

	* mail-ops.c (compose_msg): Renamed to avoid confusion

2000-06-29  Dan Winship  

	* component-factory.c (create_imap_storage, create_news_storage):
	remove some code incorrectly copied and pasted from
	create_vfolder_storage which caused vfolder creation to stop
	working.

2000-06-29  Christopher James Lahey  

	* message-list.c, mail-ops.c: Changed the name of
	e_table_select_row to e_table_set_cursor_row.

2000-06-29  Peter Williams  

	* message-list.c (message_list_init): Set the dnd_code of the
	ETableHeader to something so that Solaris sprintf doesn't die
	on a NULL string.

	* mail-config.c (providers_config_new): Check for a null "transport"
	string (not all OS' handle NULL strings well *cough* Solaris)

2000-06-28  Dan Winship  

	* mail-format.c (mail_generate_forward): add default subjects

	* component-factory.c (create_folder): Refuse to create folders
	not of type "mail", and correctly create an empty "mbox" folder
	for new folders in /local.

	* main.c (init_corba): Call od_assert_using_oaf() or
	od_assert_using_goad() as appropriate to make sure people didn't
	somehow trick the build system.

2000-06-28  Jeffrey Stedfast  

	* message-list.c: Added prototype for filter_date to make
	it build cleanly

2000-06-27  Christopher James Lahey  

	* message-list.c: Made dates display grouping information
	properly.

2000-06-27  Peter Williams  

	* message-list.c (mark_msg_seen): Need to return a value
	on error.

	* main.c (main): Don't start threads or enter threads if
	there's no threading! Sigh.

	* test-thread.c: Don't compile if no threads.

	* session.c: Work without broken threads.

	* message-list.c (filter_date): Solve the ctime_r problem the
	correct way, with the magic of autoconf.

2000-06-27  Christopher James Lahey  

	* message-list.c: Work around mismatched ctime_r functions.  This
	will be fixed.

2000-06-27  Peter Williams  

	* mail-threads.c: Don't compile this if we don't have
	threads enabled. This should maybe be on the Makefile.am
	level.

2000-06-27  Michael Zucchi  

	* component-factory.c (owner_set_cb): Put in a gross hack to
	export the shell reference elsewhere.

2000-06-26  Christopher James Lahey  

	* message-list.c: Added a value_to_string handler.

2000-06-26  Peter Williams  

	* component-factory.c, mail-ops.c: #ifdef the threads stuff so
	that if USE_BROKEN_THREADS is not defined we just call the functions
	in the main thread.

	* mail-threads.h: Don't declare funcs if USE_BROKEN_THREADS not
	defined.

	* mail-threads.c: Put the query and message boxes on top so that
	you can see them.

2000-06-26  Jeffrey Stedfast  

	* mail-config.c (error_dialog): va_start() returns void, don't
	assign it's retval to a variable.

2000-06-26  Ettore Perazzoli  

	* main.c (main): Call `GDK_THREADS_ENTER()' and
	`GDK_THREADS_LEAVE()' around the main loop as in the examples from
	the GTK+ FAQ.

	* mail-threads.c (DEBUG): New macro for debugging.
	(read_msg): Use it.

2000-06-25  Peter Williams  

	* Makefile.am: Clean up the various _LIBS and _CFLAGS
	to work with simpler THREADS_LIBS and THREADS_CFLAGS scheme.

2000-06-23  Jeffrey Stedfast  

	* folder-browser.c (folder_browser_load_folder): Improved the
	code to separate the imap namespace from the folder name.

2000-06-23  Peter Williams  

	* component-factory.c: Include e-util/e-setup.h for the
	prototype of evolution_dir; prototype create_news_storage.
	(real_create_imap_storage, real_create_news_storage): New
	functions moving the camel stuff into the async callback.
	(create_imap_storage, create_news_storage): Chopped in
	half to move camel stuff as above.

	* mail-ops.c: Include "mail-threads.h" for threading protos.
	(real_fetch_mail, real_send_mail, real_expunge_folder): 
	New functions moving the camel stuff into the async callback.
	(async_mail_exception_dialog): A version of mail_exception_dialog
	to be called from the async handlers (just calls mail_op_error())
	(fetch_mail, expunge_folder, composer_send_cb): Cut in half to
	move camel stuff as above.
	(cleanup_send_mail): Clean up after the async real_send_mail
	with the gtk_object_destroys et al.

	* mail-threads.c: Instead of hiding the progress bar, make it
	zip back and forth constantly.
	(progress_timeout): New func. Timeout called to make the pbar
	shimmy.
	(timeout_toggle): New func. Turn on and off the shimmy effect.
	(check_cond): New func. Make sure that the GCond for modal
	operation is initialized before mail_op_{error,get_password}.
	(show_error_clicked, read_msg, get_password_clicked): Move
	over to timeout_toggle.
	(mail_op_error,mail_op_get_password): Add check_cond() call.

	* main.c: (main) Call g_thread_init.

	* session.c: Change auth_callback stuff over to assume that it's
	being called async. Note: no real good way to tell if this is
	the case or not.
	(request_callback): ifdef'ed out
	(evolution_auth_callback): Use mail_op_get_password.
	
2000-06-22  Jeffrey Stedfast  

	* folder-browser.c (folder_browser_load_folder): Now should
	correctly get the selected folder from the given URL.

2000-06-22  Chris Toshok  

	* folder-browser.c (folder_browser_load_folder): add handling for
	loading "news:" folders.

	* component-factory.c (create_news_storage): add a root for news
	source.
	(owner_set_cb): call create_news_storage.

2000-06-22  Jeffrey Stedfast  

	* folder-browser.c (folder_browser_load_folder): Updated to
	prepend url-> path if it exists for that imap store.

	* component-factory.c (create_imap_storage): Modified to not
	prepend a hard-coded namespace.

2000-06-22  Chris Toshok  

	* mail-ops.c (fetch_mail_cleanup): new function, passed as arg to
	mail_operation_try.
	(fetch_mail): add cleanup func arg.

2000-06-22  Christopher James Lahey  

	* message-list.c: Changed ml_value_at to return "" instead of NULL
	in some cases.

2000-06-22  Peter Williams  
	* Makefile.am: Add GNOME_EXTRA_LIBS so that we get libgthread
	in our LIBS for evolution-mail.
	
	* mail-threads.c: Make the dialog boxes for error and
	question non-modal. They're modal relative to the dispatch
	thread, but before they would also eg lock up the toolbar
	buttons (while the menus, managed by another process, were
	active -- a weird effect).
	
2000-06-22  Peter Williams  

	* mail-threads.[ch]: Extra argument to mail_operation_try:
	'cleanup', a function to be called in the main thread after
	the dispatcher thread exits. gtk_object_destroy's et al may
	attempt to unmap windows so we can't do them in the dispatcher
	thread :-(

	* test-thread.c: Updated with demo of new argument working.

2000-06-22  Peter Williams  

	* test-thread.c (op_5): New tests for the get_password
	hook.

	* mail-threads.[ch]: New hook, mail_op_get_password, for
	getting a user response from an async operation. The operation
	blocks while waiting for the response. A big whole mutex 
	condition threading blocking dealie to make sure that it 
	works.

	Also the error hook creates a dialog again, which also needs
	to block its caller while we wait for the user to press ok.

2000-06-22  Peter Williams  

	* mail-threads.c (various functions): Prettify the UI
	so that the progress bar doesn't become all huge 'n stuff.
	(mail_operation_try): Now save the operation's description,
	so that we can display it later as the default message.
	(read_msg): When the operation starts set the label to its
	UI-friendly name.
	(dispatch_func): Free the saved prettyname.

2000-06-21  Christopher James Lahey  

	* message-list.c: Removed an erroneous comment.

2000-06-21  Dan Winship  

	* mail-config.c (create_transport_page): Make this not crash if
	you don't have a transport configured.
	
	* message-list.c: Update received date to work like sent date.

2000-06-21  Peter Williams  

	* mail-thread.{c,h}: New files -- a simple API for executing
	the major mail ops (fetch_mail etc) asynchronously, allowing
	the operations to send messages and update a progress bar.

	* test-thread.{c,h}: Tests the mail-thread API.

	* Makefile.am: add mail-thread.[ch] to evolution_mail_SOURCES
	and declare the test_thread noinst_PROGRAM.

2000-06-21  Peter Williams  

	* mail-format.c (mail_generate_reply): Include "e-setup.h" to
	get the prototype for evolution_dir.

2000-06-20  Jeffrey Stedfast  

	* component-factory.c (create_imap_storage): Oops. Should
	have checked for a NULL sources.

2000-06-20  Dan Winship  

	* message-list.c (mark_msg_seen): Quick hack to prevent a NULL
	pointer dereference. Things need to be cleaned up a bit more here
	though.

	* mail-sources.c: Oops. This should have been removed a long time
	ago.

2000-06-20  Jeffrey Stedfast  

	* folder-browser.c (folder_browser_load_folder): Working on getting 
	this to work :)

	* component-factory.c (create_imap_storage): Should now correctly
	construct the folder path allowing the selection of a folder.

2000-06-20  Ettore Perazzoli  

	* mail-format.c (mail_generate_reply): Declare `evolution_dir'.
	Ugly, ugly, ugly, but I am not sure where it should go instead.

2000-06-19  Ettore Perazzoli  

	* mail-ops.c (ask_confirm_for_empty_subject): New function to ask
	confirmation for an empty subject line.
	(composer_send_cb): Use it if the subject is empty and only send
	the message if the user confirms.

2000-06-20  Jeffrey Stedfast  

	* component-factory.c (create_imap_storage): Now creates the IMAP
	storage (listing subfolders and such)

2000-06-19  Dan Winship  

	* mail-format.c (find_preferred_alternative): add an option to
	prefer text/plain.
	(reply_body): add an option to prefer text/plain
	(mail_generate_reply): Check the mail sending preferences, and
	generate a text/plain reply if the user prefers to send plain text
	(and we have a text/plain part to generate a reply from).

2000-06-19  Jeffrey Stedfast  

	* mail-config.c (providers_config_new): Should now correctly display
	the Transport page (made it set the optionmenu correctly, before it
	would only set SMTP).
	(create_transport_page): Updated to set the page info to sendmail/smtp
	based on the url.
	(create_service_page): Had to add some code to set data on some objects
	so I could grab the objects I needed to modify in the above function.

2000-06-18  Jeffrey Stedfast  

	* folder-browser.c (folder_browser_load_folder): started to add
	code to load an IMAP folder.
	
	* component-factory.c: Started to add a create_imap_storage 
	method so that we can eventually have our IMAP store displayed 
	in the tree view.
	(create_vfolder_storage): Renamed from
	create_test_storage().
	(owner_set_cb): Updated.

2000-06-17  Dan Winship  

	* message-list.c (message_list_set_folder): Prevent double-freeing
	action on summary_table and uid_rowmap.

2000-06-16  Dan Winship  

	* message-list.c (ml_set_value_at): Implement clicking on the
	envelope icon to set read/unread. Based on a patch by clahey.
	(select_msg): keep the timeout id for the "seen" flagging in the
	message_list structure, so ml_set_value_at can clear it so it
	doesn't re-mark a message seen after you click it unseen.

2000-06-16  Dan Winship  

	* message-list.c (get_message_row): new function to do a uid to
	row mapping.
	(mark_msg_seen, select_msg, message_changed,
	message_list_set_folder): Update for Camel flag changes.
	(on_cursor_change_cmd): Rename "row_to_select" to "selected_row",
	and keep a "selected_uid" as well.

	* mail-ops.c (composer_send_cb): Update for Camel flag changes,
	and fix some memory-handling bugs. (Free the post_send_data when
	the composer is destroyed, not when the user clicks "send", which
	could happen never, or more than once.)
	(delete_msg): Update for Camel flag changes, and fix the "holding
	down the delete key skips some messages" bug.

2000-06-15  Dan Winship  

	* mail-ops.c (fetch_mail): 
	* component-factory.c (owner_unset_cb): 
	* message-list.c (message_list_set_folder): Update for CamelFolder
	changes.

	* folder-browser.c (folder_browser_clear_search): New function to
	revert back to non-searching mode.

	* mail-ops.c (fetch_mail): Use folder_browser_clear_search.

	* mail-display.c (on_url_requested): if the document requests an
	unknown URL, it's not an error; just ignore the URL.

	* mail-ops.c (fetch_mail): If there's no new mail, tell the user.

2000-06-14  Radek Doulik  

	* main.c (main): call gtkhtmllib_init here

2000-06-13  Jeffrey Stedfast  

	* mail-config.c (on_SourceConfigDialogButton_clicked): Make sure source
	is always pointing to something, so a blank is not written to the config file
	on close.

2000-06-13  Ettore Perazzoli  

	* Makefile.am (SHELL_OBJS): Removed.
	(evolution_mail_LDADD): Use `libeshell.a'.  Also use
	`top_builddir' consistently.

2000-06-12  Jeffrey Stedfast  

	* mail-config.c: Got rid of sources_max_row and identities_max_row
	as they are not really needed (just use clist->rows)
	(on_cmdSourcesEdit_clicked): Modified to make 'source'
	point to the data being edited.
	(on_cmdSourcesAdd_clicked): Adds a new clist item and selects it so the
	editor knows where to stick the data when it's done.

2000-06-12  Federico Mena Quintero  

	* message-list.c: Removed the ETableModel thaw handler.

2000-06-12  Dan Winship  

	* folder-browser.c (folder_browser_set_uri): Return the result of
	folder_browser_load_folder.
	(get_prop, set_prop, folder_browser_properties_init): Remove. No
	longer needed.

	* folder-browser-factory.c (folder_browser_factory_new_control):
	Add a "uri" argument, return NULL if setting it fails.
	(folder_browser_factory_new_control): Remove property bag stuff.
	(folder_browser_factory_init, folder_browser_factory): Remove
	this, since we're using the component factory now.

	* component-factory.c (create_view): Update for
	folder_browser_factory_new_control change and return NOTFOUND as
	appropriate.

	* main.c (main): Don't call folder_browser_factory_init.

	* mail-format.c (mail_generate_reply): Fix the subject generation
	so we don't get "Re:  Re:". This is working around something that
	may later be declared a misfeature in Camel.

2000-06-10  Ettore Perazzoli  

	* component-factory.c (create_folder): New stub implementation for
	the folder creation function in the EvolutionShellComponent we
	expose [it simply returns success all the time].
	(factory_fn): Pass this function to `evolution_shell_component_new'.

2000-06-09  Dan Winship  

	* folder-browser.c (folder_browser_new): Add a serial number to
	FolderBrowser.

	* folder-browser-factory.c (control_activate, control_deactivate):
	Include fb serial number in the name of the Bonobo toolbar to
	prevent problems with disappearing toolbars. This is a kludge and
	should go away.


	* mail-ops.c (expunge_folder): display error from
	camel_folder_expunge if there is one.

	* message-list.c (select_row): install an idle function to
	select the row rather than doing it directly. Ugh. What a
	kludge, but at least it works now.

	* session.c (evolution_auth_callback): Update for
	CamelAuthCallback changes. (Uncache passwords when asked to.)

	* mail-ops.c (fetch_mail): close and expunge the source folder
	after copying it to a local folder.

2000-06-09  Ettore Perazzoli  

	* component-factory.c (create_view): Updated to match the changes
	to the definition of `EvolutionShellComponentCreateFn'.  If @type
	is not "mail", return an "unsupported type" error.
	(factory_fn): Pass NULL for the `remove_folder' and
	`create_folder' functions.

2000-06-09  Dan Winship  

	* mail-format.c: Redo things a bit so that whitespace-only
	text parts aren't displayed. (In particular, so that
	whitespace-only subparts of multipart/mixed aren't displayed as
	separate (empty) parts.)

2000-06-06  Dan Winship  

	* mail-ops.c (fetch_mail): 
	* folder-browser.c (folder_browser_load_folder): Update for folder
	creation/existence changes.

	* message-list.c (message_list_set_folder): Remove the code to
	create the folder if it doesn't exist, since we don't want to do
	that.

2000-06-05  Dan Winship  

	* mail-ops.c (composer_send_cb): Leave the composer window around
	if the message doesn't get sent.

2000-06-05  Matt Loper  

	* folder-browser.c (etable_key): Allow "GDK_KP_Delete", a keypad
	delete key, to delete a message.

2000-06-05  Dan Winship  

	* session.c (evolution_auth_callback): Remember passwords between
	calls.
	(forget_passwords): Callback for "Forget Passwords" menu item.

	* folder-browser-factory.c (control_activate): 
	(control_deactivate): Add "Forget Passwords" menu item.

	* mail.h, mail-ops.c: fix some function prototypes

	* folder-browser.c (etable_key): Add "Delete" = delete message.

	* mail-format.c (mail_generate_forward): Update for new composer
	attachment interface.

2000-06-02  Jeffrey Stedfast  

	* mail-config.c (providers_config_new): Added a new notebook
	page that allowed for mail format (text/plain or 
	multipart/alternative)

2000-06-02  Dan Winship  

	* message-list.c (filter_date): If the date in the summary is 0,
	output "?".

	* component-factory.c (create_view): keep a GList of folder
	browsers created
	(owner_unset_cb): Go through the list and close each folder before
	exiting so they sync their summary state, etc to disk.

	* mail-ops.c (fetch_mail): Use camel_service_connect, not
	connect_with_url, since we already passed the URL into
	camel_session_get_store.

2000-06-02  Christopher James Lahey  

	* message-list.c: Use camel_folder_free_summary instead of
	g_ptr_array_free.  Unref the folder when we're done with it.

2000-06-02  Christopher James Lahey  

	* session.c: Revert removal of e_setup_base_dir.

2000-06-02  Dan Winship  

	* folder-browser.c (my_folder_browser_init): Connect to ETable's
	key_press signal.
	(etable_key): scroll mail on space/backspace.

2000-06-02  Christopher James Lahey  

	* message-list.c: Made sent column as wide as from column.

2000-06-02  Jeffrey Stedfast  

	* mail-config.c (on_cmdSourcesAdd_clicked): Changed identity_row
	to source_row as this is a Sources clist we are dealing with and
	not an identity clist
	(on_cmdSourcesEdit_clicked): same
	(on_cmdSourcesDelete_clicked): again, same
	(on_cmdSourcesEdit_clicked): Source editor now fills in data from
	the clist

2000-06-01  Dan Winship  

	* message-list.c: Add a date column.	
	(COL_SENT_WIDTH_MIN): Make this wider.
	(ml_value_at): return the sent date (as a time_t) for COL_SENT.
	(Fix COL_TO too while I'm here.) 
	(ml_duplicate_value, ml_free_value, ml_initialize_value,
	ml_value_is_empty): COL_SENT is numeric now.
	(message_list_init_renderers): Create a date renderer (using
	text_filter to translate the time_t into a string).
	(message_list_init_header): Use render_date for COL_SENT.

2000-06-01  Christopher James Lahey  

	* session.c: Don't call e_setup_base_dir.

2000-06-01  Dan Winship  

	* mail-format.c (mail_generate_forward): Fix forwarding to work
	for people other than me. :) [Although apparently it doesn't
	really.]

	* mail-ops.c (delete_msg): Add a quick hack to move the selection
	down a row when you delete a message.

	* mail-format.c (handle_message_rfc822): use 
     rather
	than 
     to frame the embedded
	message. If 
     text in the subtable won't fit in the 95% width,
	GtkHTML will write past the border of the table (and
	
     causes creeping updates so it's not
	usable for now).
	
2000-06-01  Christopher James Lahey  

	* message-list.c (message_list_init): Turn off the grid in our
	ETable.

2000-06-01  Dan Winship  

	* mail-format.c (write_headers): Oops. This needs to take a
	message argument because we might be writing headers for an
	embedded message/rfc822 subpart rather than the root document.

2000-06-01  Jeffrey Stedfast  

	* mail-config.c: Config dialogs are completed.
	(service_acceptable): Fixed a segfault caused by duplicate 
	camel_exception_free()
	(providers_config_new): Identity and Source clists are now filled in
	when the dialog is created as well as the Transport page

	* folder-browser-factory.c: Renamed Tool/ menu items
	Vfolder was changed to Virtual Folder and
	Configure Camel Providers was changed to Mail Configuration

2000-06-01  Ettore Perazzoli  

	* Makefile.am (evolution_mail_LDADD): Link with
	`libemiscwidgets.a'.

	* mail-display.c (mail_display_new): Use an EScrollFrame instead
	of a GtkScrolledWindow.
	(mail_display_set_message): Likewise.

	* mail-display.h: Replace the GtkScrolledWindow with an
	EScrollFrame.

2000-06-01  Dan Winship  

	* component-factory.c (owner_unset_cb): Quit when the shell exits.
	This is a kludge, but a pretty necessary one until the refcounting
	bugs that keep the component from exiting properly are fixed.

2000-05-31  Jeffrey Stedfast  

	* mail-config.c: Partially implemented the source
	configuration, seems to segfault due to a destroyed
	gnome dialog being destroyed again in the method
	on_SourceConfigDialogButton_clicked()

2000-05-31  Dan Winship  

	* mail-format.c (free_url, handle_text_enriched,
	get_url_for_icon): Fix up memory management of x-evolution-data
	URLs so the URLs and/or their data don't get freed while there are
	still references to them.

	* message-list.c (message_list_init_header): redo the (unused)
	online status column to no longer refer to pixmaps that no longer
	exist.

2000-06-01  Ettore Perazzoli  

	* folder-browser-factory.c (control_activate): Put the toolbar
	into a frame to make it look like standard GNOME toolbars.  Also,
	set `GNOME_DOCK_ITEM_BEH_NEVER_VERTICAL' so that it does not do
	evil things when its moved to the left or the right of the window.

2000-05-31  Jeffrey Stedfast  

	* mail-config.c: Configuration dialog now allows 
	adding/editing/deleting of Identities (which leaves
	adding/editing/deleting of sources left to implement).
	The data is also saved when the dialog is exited via 
	the OK button.

2000-05-31  Dan Winship  

	* mail-format.c (mail_format_mime_message): Initialize the "urls"
	hash table stored on the message and store cid and other URLs
	there rather than as object data on the message.
	(get_cid): rewrite this a bunch
	(handle_text_enriched): move the code from write_iframe_string()
	into here, since it's the only place that actually needs it.
	(handle_text_html): simplify this a lot. We can use a cid: URL
	here rather than x-evolution-data.
	(get_url_for_icon): New routine to return URLs for icons, and
	cache the results, so we don't have to keep re-reading the icon
	files (and so we can't be spoofed into reading non-icon files).
	(handle_mystery, handle_audio): use get_url_for_icon.

	* mail-display.c (save_data): move the CamelMimePart filename
	extracting code from get_cid to here.
	(on_link_clicked, on_object_requested): Update for cid: changes.
	(on_url_requested): Kill off the kludgy, exploitable x-gnome-icon
	URL schema, update cid and x-evolution-data to match
	mail-format.c.

	It should now be easier to implement RFC 2557 (Content-Location,
	etc), but that RFC still pretty much sucks.

2000-05-30  Dan Winship  

	* mail-format.c: Redo this back to the old way: a single GtkHTML
	with various things inline in it. (Gets rid of flicker, simplifies
	some scrolling, selecting, and printing issues.)
	(handle_text_enriched, handle_text_html): Use