2000-08-11 Peter Williams * mail-local.c (local_reconfigure_folder): Make the dialog modal. * mail-callbacks.c (select_first_unread): Fix some warnings. * mail-threads.c (mail_op_forward_event): New function that writes a FORWARD_EVENT signal to the compipe, to allow Camel events to be handled in the main thread. (read_msg): Handle a FORWARD_EVENT. * mail-callbacks.c (select_first_unread): Forward the event into the main thread to prevent the GTK calls in the dispatcher thread. (main_select_first_unread): New name of old select_first_unread. * message-list.c (folder_changed): Same as above. (main_folder_changed): Same as above. (message_changed): Same as above. (main_message_changed): Same as above. * mail-format.c (free_byte_array): Note about using mail_op_forward_event. (cmm_destroyed): Same. 2000-08-11 Dan Winship * message-list.c (message_list_select): If the caller passes "-1" for the model row, translate that to view row 0. * message-list.c (idle_select_row): * mail-callbacks.c (select_first_unread): Use new message_list_select kludge^H^H^H^H^H^Hfeature 2000-08-11 JP Rosevear * mail-config-gui.c (source_dialog): Allow the window to be growable * mail-config.c: use void in empty declarations 2000-08-11 Peter Williams * mail-config.c (mail_config_get_news): Change () to (void) if a function takes no arguments. * mail-config.h: Prototype mail_config_get_{sources,news}x 2000-08-11 JP Rosevear * mail-config-gui.c (identity_dialog): iddialog, not sdialog (news_edit_clicked): Kill leftover c-p crud 2000-08-11 JP Rosevear * mail-config-gui.c (news_edit_clicked): Check nrow, not srow. 2000-08-11 JP Rosevear * mail-config-gui.c (service_acceptable): Use camel_object_unref instead of gtk_object_unref (mail_druid_finish): Use new config accessors (mail_config_druid): No need to call config functions (news_add_clicked): Increments maxnrow, not maxsrow (mail_config_apply_clicked): Use new config accessors (mail_config): ditto * component-factory.c (create_imap_storage): Use new config accessors (create_news_storage): ditto * mail-config.glade: Set news clist name correctly * mail-config.c (config_read): Rename from mail_config_read and made private - no one should need to do a read manually. (mail_config_set_send_html): New accessor (mail_config_add_identity): ditto (mail_config_get_sources): ditto (mail_config_add_source): ditto (mail_config_get_default_news): ditto (mail_config_get_news): ditto (mail_config_add_news): ditto * mail-config.h: Prototype new accessors. Config struct is now in mail-config.c and hidden from the world. 2000-08-11 Dan Winship * mail-ops.c (describe_fetch_mail): Use camel_service_get_name rather than showing the URL to the user. 2000-08-11 Peter Williams * mail-ops.c (do_refile_messages): Freeze the folders while moving. (do_flag_messages): Same. * mail-threads.c (get_password_clicked): Fix the case when the user /doesn't/ use escape to cancel the dialog :-/ (show_error_clicked): Same. 2000-08-11 Dan Winship * mail-tools.c (mail_tool_get_folder_name): Add a function to return a useful name for a folder (not just "mbox" or "mh" for any local folder.) * mail-ops.c: Use mail_tool_get_folder_name rather than folder->full_name when printing folder names. 2000-08-11 Not Zed * mail-tools.c (mail_tool_get_local_inbox_url): Properly handle different local file formats. The folder isn't always mbox. (mail_tool_do_movemail): Movemail always uses an mbox format however. (mail_tool_get_local_movemail_url): What is the mbox url, it is always the same type, mbox. (mail_tool_fetch_mail_into_searchable): Same here. * mail-local.c (mail_local_map_uri): Map a local uri to the real uri. 2000-08-10 Christopher James Lahey * folder-browser-factory.c, message-list.c, message-thread.c, session.c: Fixed some warnings. 2000-08-10 Dan Winship * session.c (session_init): Don't call e_setup_base_dir. It was wrong and it doesn't exist any more. * component-factory.c (owner_set_cb): Update for changed prototype, and record the evolution_homedir. Move call to mail_config_init here from session.c so it happens after evolution_dir is initialized. * mail.h: define "extern char *evolution_dir;" (formerly in e-util/e-setup.h) * component-factory.c, mail-callbacks.c, mail-config-gui.c, mail-config.c, mail-display.c, mail-format.c, mail-ops.c, mail-tools.c, session.c: Remove "e-util/e-setup.h" include. 2000-08-10 Peter Williams * test-thread.c (queue_ops): Use mail_operations_terminate() to close the other thread nicely. * mail-threads.c (get_password_deleted): Handle the "close" event as a cancel. (show_error): Same. 2000-08-10 Dan Winship * mail-tools.c (mail_tool_get_folder_from_urlname): Add a "gboolean create" argument to pass to camel_store_get_folder. * mail-ops.c (do_create_folder, do_setup_draftbox): * mail-local.c (mail_tool_local_uri_to_folder): * mail-vfolder.c (vfolder_uri_to_folder): Add create flag to mail_tool_get_folder_from_urlname calls. 2000-08-10 Jeffrey Stedfast * mail-callbacks.c (composer_send_cb): Fix compile warning by casting the object to a CamelObject 2000-08-10 Peter Williams * mail-tools.c (mail_tool_filter_contents_into): Delete the source folder if told to and if it's empty (mail_tool_get_local_movemail_path): New function. 2000-08-10 Dan Winship * mail-callbacks.c (reply_to_all): Fix a bug in the async changes. (This was identical to reply_to_sender.) 2000-08-10 Not Zed * mail-local.c (do_local_reconfigure_folder): Update for append_message api change. * message-list.c (message_list_regenerate): Change for search api change. (ml_tree_value_at): Add a colour column, based on the colour assigned in the summary. (message_list_init_renderers): Init colour column. 2000-08-09 Peter Williams * mail-display.c (part_for_url): Remove a gtk_object_get_data 2000-08-09 Cody Russell * folder-browser-factory.c, mail-view.c: Make the toolbars honor the user's gnomecc settings for detachable toolbars. 2000-08-09 Jeffrey Stedfast * mail-ops.c (composer_send_cb): Get the from address set in the composer, if that fails ONLY THEN get the default from mail config * mail-config.c (mail_config_get_identities): New convenience function for getting a list of the configured identities 2000-08-09 Dan Winship * mail-display.c (on_object_requested): Support controls as well as embeddables. 2000-08-09 Jeffrey Stedfast * mail-view.c (mail_view_create): Changed to only take a FolderBrowser argument * mail-ops.c (real_view_msg): Create a new FolderBrowser for each message being opened in a new window. Also set the message_list->cursor_uid and mail_display->current_message to the appropriate values. (real_view_msg): Updated to reflect changes in the mail_view_create * message-list.c (on_right_click): Nicify a little, add in a menu separator between VFolder and Filter stuff. * mail-ops.c (real_view_msg): Set the UID of the message that is being displayed 2000-08-09 Ettore Perazzoli * folder-browser-factory.c (control_activate): Use `GNOME_STOCK_MENU_*' things instead of `GNOME_STOCK_PIXMAP_*' things, that are too big and look bad. 2000-08-09 Peter Williams * mail-view.c (mail_view_create): Save the top window so that on_close can find it [with set_data]. (on_close): Recover the top window. * mail-threads.c (read_msg): Destroy the window instead of hiding it. 2000-08-09 Not Zed * mail-autofilter.c (filter_gui_add_from_message): Helper function to add with confirm. (rule_match_recipients): Dont set real name if its empty for the filter name. (rule_match_subject): was cutting ] off mailing list names. * message-list.c (on_right_click): Added menu to install vfolders/filters from message. 2000-08-09 Not Zed * mail-autofilter.c: New file to hold auto filter/vfolder stuff. 2000-08-09 Christopher James Lahey * mail-display.c, mail-format.c, mail-ops.c: Fixed some warnings. * message-list.c: Fix the call to e_popup_menu_run to match the new signature. 2000-08-09 Ettore Perazzoli * folder-browser-factory.c (control_activate): Create a "print message" menu item. 2000-08-09 Jeffrey Stedfast * message-list.c (message_list_init): Attached a double_click signal handler (on_double_click): Our lovely new double_click callback. Will display the current selected message in a new window 2000-08-08 Jeremy Wise * mail-config.[ch], folder-browser.c: Added configuration work to save the size of the vpaned widget. It will be functional when the e_paned widget emits a "resized" signal 2000-08-08 Jeffrey Stedfast * mail-config.h: Added void as an argument to functions not needing any parameters to avoid compile warnings. 2000-08-08 Jeremy Wise * mail-config.[ch], main.c, folder-browser-factory.c: State of the threaded list toggle is now saved via gnome_config 2000-08-08 Dan Winship * mail-config-gui.c (service_page_item_new): Attach a signal handler to call the "changed" function when the user clicks the "keep on server" checkbox. 2000-08-08 Jeffrey Stedfast * mail-ops.c (view_msg): New convenience function with params of a normal Gtk callback function. We also now create a new FolderBrowser object so that the message-view window isn't tied to the display in the main window (view_message): Now calls view_msg (this function is a bonobo callback and can't be used with gtk widgets) (edit_msg): Same idea as view_msg() (edit_message): Again, same as view_message() * message-list.c (on_right_click): Callback for creating an e-popup-menu (message_list_init): Added a right_click event to trigger a pop-up menu to be displayed 2000-08-08 Dan Winship * mail-config-gui.c: Add "Don't delete messages from server" button to remote SOURCEs that aren't STORAGEs (ie, POP). (provider_list): Only list SOURCEs. (ie, not mh) * mail-config.c: Save/load "keep_on_server" flag. * mail-ops.c (fetch_remote_mail): New function, split out of real_fetch_mail. Deals with copying mail from a remote server into a temporary mbox, possibly using a CamelUIDCache to leave the messages on the server. * mail-crypto.c, mail-format.c, message-thread.c: Fix some compiler warnings. * mail-format.c (mail_generate_reply): Fix up format of addresses. (write_headers): Use CamelAddress functions to simplify this. 2000-08-08 Jeffrey Stedfast * mail-view.c: Lets get rid of the last separator in the toolbar until we add n/p 2000-08-08 Ettore Perazzoli * mail-threads.c (queue_window_delete_event_cb): Callback for "delete_event", just doing nothing. (create_queue_window): Connect it to the "delete_event" signal of the progress dialog. 2000-08-08 Peter Williams * mail-threads.c (remove_next_pending): Sanity check for job queue, which seems to have some issues. (read_msg): Make sure that the next operation isn't started before the last one is cleaned up. * mail-callbacks.c (fetch_mail): Fix erroneous free. * mail-config-gui.c (mail_config_druid): Wrap the gtk_main call. * mail-ops.c (do_flag_messages): Allow specification of whether to set the flags unconditionally or toggle their current state. * message-list.c (ml_tree_set_value_at): Toggle the seen status; don't set it unconditionally. * mail-callbacks.c (delete_msg): Toggle the deletion status; don't set it unconditionally. * mail-tools.c (mail_tool_do_movemail): Fix for undeclared tmpfd. * mail-local.c (local_reconfigure_folder): Big rewrite; make into an asynchronous operation. Use some mail tools to make life easy. 2000-08-08 Dan Winship * main.c (main): Move mail_config_init after session_init, since it depends on evolution_dir being set. 2000-08-08 JP Rosevear * mail-ops.c (check_configured): Use config accessors (fetch_mail): ditto (composer_send_cb): ditto (create_msg_composer): ditto * mail-config-gui.h: Update API * mail-config.h: Update API * mail-config.c: Add accessor functions (mail_config_is_configured): accessor function (mail_config_get_default_identity): ditto (mail_config_get_default_source): ditto (mail_config_get_transport): ditto (mail_config_send_html): ditto (identity_copy): Make public (identity_destroy): ditto (identity_destroy_each): ditto (service_copy): ditto (service_destroy): ditto (service_destroy_each): ditto (mail_config_init): Rename from init_config and make public (mail_config_clear): Rename from clear_config and make public (mail_config_read): Rename from read_config and make public (mail_config_write): Reanme from write_config and make public * main.c (main): Call mail_config_init. * mail.h: Include mail-config-gui.h * mail-config-gui.c: Move config gui stuff here. (source_dialog): Kill memory leak from debug leftovers. Make sure returned source is NULL by default 2000-08-07 Not Zed * mail-local.c (local_reconfigure_folder): Redone to show a dialogue first, and show progress of whats happening as its done. * Makefile.am (glade_DATA): Added local-config.glade, for mailbox reconfig dialogue. 2000-08-04 Not Zed * folder-browser.c (mail_uri_to_folder): Use local_uri_to_folder() for local uri's (file://). * mail-local.c (local_uri_to_folder): Handle looking up folder storage type before opening the store/folder. (local_reconfigure_folder): Function to reconfigure the format of a local mailbox into another storage format. * Makefile.am (evolution_mail_SOURCES): Added mail-local.c and missing mail-vfolder.h. 2000-08-07 Jeffrey Stedfast * Makefile.am: Added mail-view.c * folder-browser-factory.c (control_activate): Adda menu item for viewing the message * mail-view.c: New file containing methods for viewing messages in separate windows * mail-ops.c (view_message): New callback for viewing messages in a new window. 2000-08-07 Jeffrey Stedfast * component-factory.c (real_create_generic_storage): New function to replace real_create_imap_storage and real_create_news_storage (create_imap_storage): Updated. (create_news_storage): Updated. 2000-08-07 Peter Williams * mail-ops.c (cleanup_edit_messages): New operation: edit_messages For continuing draft messages. (attach_messages): Fix accidental 0 datasize. (do_setup_draftbox): New operation: setup_draftbox. Soooo hacky. * mail-callbacks.c: Move fejj's edit message to the async home. * component-factory.c (owner_set_cb): Use mail_do_setup_draftbox. 2000-08-07 Jeffrey Stedfast * mail-display.c: * component-factory.c: s/strncasecmp/g_strncasecmp * mail-format.c (write_headers): Get rid of kludge around subject beginning with spaces. (mail_generate_reply): Get rid of kludge around subject beginning with spaces and also use g_strncasecmp instead of strncasecmp for portability * mail-ops.c (forward_msg): Get rid of kludges around subject beginning with spaces. 2000-08-07 Dan Winship * message-list.c (message_list_select): Clarify that the input row is a model row, and swap it to a view row when finding the next/previous row. (idle_select_row): Select view row 0, not model row 0. * mail-ops.c (select_first_unread): Start from view row 0, not model row 0. 2000-08-07 Jeffrey Stedfast * mail-format.c (mail_get_message_body): Renamed from reply_body() so other functions can use it (mail_generate_reply): Updated to reflect function name changes * mail-ops.c (real_edit_msg): Attach a callback to the send signal 2000-08-07 Jeffrey Stedfast * folder-browser-factory.c (control_activate): New menu item under Actions to allow editing of messages. * mail-ops.c (edit_message): New function for editing messages. * component-factory.c (owner_set_cb): Create a global reference to the Drafts mbox folder for the Composer to use 2000-08-06 JP Rosevear * mail-config.c (ndialog_page_undone): Desensitize ok button (sdialog_page_undone): ditto (iddialog_page_undone): ditto (news_page_new): Typo - news, not mail (transport_page_new): Typo - transport, not source (identity_dialog): Set undone callback (source_dialog): ditto (news_dialog): ditto (mail_druid_identity_undone): Desensitize next button and mark done flag as false (mail_druid_source_undone): ditto (mail_druid_transport_undone): ditto (mail_druid_identity_done): Mark done flag as true (mail_druid_source_done): ditto (mail_druid_transport_done): ditto (mail_druid_prepare): Use done flag to set next button sensitivity, fixes #467 2000-08-06 Jeffrey Stedfast * mail-crypto.c (mail_crypto_openpgp_encrypt): Added support for encrypting with GnuPG. Support for PGP5 and PGP2 are still in progress. 2000-08-05 Dan Winship * folder-browser-factory.c (control_activate): Remove bonobo 0.15 vs 0.15-and-a-half ifdef, since we require post-0.16 now. 2000-08-04 Dan Winship * mail-threads.c (mail_operation_wait_for_finish): Don't use "while (gtk_events_pending ()) gtk_main_iteration ();" inside another tight loop, because it makes the thread spin rather than blocking and waiting like it should. 2000-08-04 Peter Williams * message-thread.c (do_thread_messages): Uninitialized variable fix. * mail-threads.c (read_msg): Small leak fix. * component-factory.c (owner_unset_cb): Use mail_operations_ terminate() instead of wait_for_finish(). * mail-threads.c (mail_operation_queue): Centralize the clur handling functions; fix a race condition where the dispatcher would overwrite the closure before the main thread could free the old one. (mail_operations_terminate): New function, wait for ops to finished and kill the other thread. (dispatch): changes to die when terminate is called (abort on NULL spec). * mail-ops.c (cleanup_display_message): Fix improper handling of displaying a NULL message (which means clear the message display). 2000-08-04 Ettore Perazzoli * message-list.c (message_list_regenerate): Free the GPtrArray correctly instead of using `g_strfreev()'. 2000-08-04 Michael Meeks * folder-browser-factory.c (control_activate): release the ui_handler after set_container. 2000-08-03 Michael Meeks * mail-config.c (identity_page_new): only whack the sig in if the file exists. * component-factory.c (factory_fn): count running instances, attach destroy signal (factory_destroy): add. * main.c (main): pass orb around. 2000-08-03 Jeffrey Stedfast * mail-ops.c (composer_send_cb): Yay, no more compiler warnings * mail-config.c: set config = NULL (provider_list) Eek! Initialize news to NULL! Also, use g_slist_prepend() for "performance" gains ;-) (init_config): Set the config member data to NULL just to be on the safe side (clear_config): Don't bother freeing slist data if the slist is NULL 2000-08-03 Peter Williams * mail-ops.c (op_forward_messages): Use the new dynamic operation naming. * message-thread.c (describe_thread_messages): Ditto. * message-list.c (describe_regenerate_messagelist): Ditto. * mail-threads.c (get_password_clicked): Dynamic generation of descriptive text for mail operations. "Opening a folder" -> "Opening INBOX". Supported only so far, will be implemented quickly. g_strdup() the old_message when changing the queue_window_label's text. * main.c (main): One more gconf reference to take out... * mail-ops.c (composer_send_cb): Check for an identity before sending. 2000-08-03 JP Rosevear * mail-config.glade: Increase window size slightly, rename "Transport" to "Mail Transport" * mail-config.c (init_config): Remove gconf references (clear_config): ditto (read_config): ditto (write_config): ditto (mail_config): Null provider lists before filling them (mail_config_druid): ditto (identity_page_new): Increase spacing of vbox (service_page_new): ditto * Makefile.am: Remove gconf references. 2000-08-02 Dan Winship * mail-config.c (service_page_item_new): Make the "test settings" button FILL rather than SHRINK so it doesn't end up oddly-placed. * mail-config-druid.glade: Make the icon background dark blue like the surrounding area. 2000-08-02 Peter Williams * component-factory.c (owner_unset_cb): Wait for async operations to finish before exiting. 2000-08-02 Christopher James Lahey * mail-ops.c, message-list.c: Emit "model_pre_change" where appropriate. 2000-08-02 Peter Williams * mail-config.h: #ifdef _MAIL_CONFIG_H protect the header. 2000-08-01 Peter Williams * mail-threads.c: Implement Solaris threads. Attempt to join to the thread upon exit -- hopefully prevents all those nasty zombie processes from popping up :-( 2000-08-01 Dan Winship * mail-crypto.c: New code to spawn off GPG/PGP to do stuff. Currently only deals with decryption. From Nathan Thompson-Amato , with bunches of changes from me. * session.c (mail_request_dialog): Expose the password dialog to the rest of the app (for use by the GPG/PGP code). * mail-format.c (handle_text_plain): Handle special inline data types. (Currently uuencoding, BinHex, and PGP encryption.) This is not the best way to deal with it, but it works for now. (try_inline_pgp): Convert an inline PGP-encrypted message into a multipart/encrypted part. (try_inline_binhex): Convert an inline BinHex attachment into an application/mac-binhex40 part (which we currently don't deal with...) (try_uudecoding): Convert a uuencoded attachment to an application/octet-stream part. (handle_multipart_encrypted): Deal with RFC2015 MIME-encoded PGP encrypted messages. (From ndt.) * mail-display.c (mail_text_write, mail_error_write): New utility functions. * Makefile.am (evolution_mail_SOURCES): add mail-crypto.c 2000-07-31 Christopher James Lahey * component-factory.c, folder-browser.c: Fixed some warnings. * message-list.c: Made the icon column non sortable. 2000-07-31 Dan Winship * mail-config.c (service_page_set_url): Fix a NULL-pointer strcmp noticed by peterw. 2000-07-31 Not Zed * mail-vfolder.h: Header for vfolder functions. * folder-browser.c (mail_uri_to_folder): Use new scheme to open vfolders. (search_save): New button/function to save a search as a vfolder. * mail-vfolder.c (vfolder_edit): Made asynchronous. (vfolder_uri_to_folder): New function for loading vfolders and setting up their source folders. (vfolder_refresh): Change shell vfolder uri's to indirect references rather than the real vfolder uri. (vfolder_gui_add_rule): Add a rule with user confirmation. (vfolder_create_part): Get a new part by name, for creating rules in code. * message-thread.c (thread_messages): Check for uid lookup failure, which indicates an error in the folder or calling code. 2000-07-29 Not Zed * component-factory.c (create_view): Remove hack to pass the storage around. * folder-browser-factory.c (control_activate): Changed to call renamed vfolder editor. * mail-ops.c (vfolder_edit_vfolders): renamed from vfolder_edit, call new edit function. (vfolder_editor_clicked): Removed. (filter_druid_clicked): (filter_edit): Updated for api change. (real_fetch_mail): Fixed up for api change and fucked up indent. (filter_get_folder): callback for filter driver. * mail-vfolder.c: New file to manage virtual folders. 2000-07-29 JP Rosevear * mail-format.c (mail_generate_reply): Use new mail config stuff * component-factory.c (create_imap_storage): Use new mail config stuff (create_news_storage): ditto * evolution-mail.schemas: Gconf schema for evolution mail * mail-config-druid.glade: Gladification of config druid * mail-config.h: New header with config structs. * mail-config.c: Rewrite of GUI configuration tools to use new config structs. Stores multiple identities and sources now. Still only uses the first one found. (mail_config_fetch): Returns MailConfig struct to caller for configuration queries. (mail_config): Renamed function to show mail config dialog. (mail_config_druid): Renamed function to show mail config druid. * mail-ops.c (create_msg_composer): Use e_msg_composer_new_with_sig_file and new config stuff (check_configured): Use new config stuff (fetch_mail): ditto (composer_send_cb): ditto 2000-07-28 Cody Russell * mail-ops.c, mail.h: Added mark_all_seen(), to mark every message in the list with CAMEL_MESSAGE_SEEN. * folder-browser-factory.c: Added "Actions/Mark all seen". 2000-07-27 Jeffrey Stedfast * mail-config.c: Lets fix Dan's kludge the Right Way (tm) (set_service_url): Only strip off the leading "/" from the url->path if url->host is NULL (get_service_url): Only prepend a leading "/" to the path if the host is NULL 2000-07-27 Dan Winship * mail-config.c (get_service_url): toss in a kludge to deal with the IMAP vs mbox path problem for now. 2000-07-26 Christopher James Lahey * message-list.c, message-list.h: Removed counting of selected messages. 2000-07-26 Dan Winship * mail-ops.c (real_fetch_mail): Don't create the tmp_mbox before calling movemail, because the external movemail requires it to not exist. Contrariwise, delete it in the cleanup code if it's empty. Update for camel_movemail interface change. Do the "No new messages" dialog in the mbox case as well as the remote mail issue. 2000-07-26 Jeffrey Stedfast * mail-ops.c: s/struct refile_data/struct move_data (real_move_msg): Renamed from real_refile_msg() (move_msg): Renamed from refile_msg() * folder-browser-factory.c: Changed Refile to Move. 2000-07-26 Dan Winship * mail-format.c (lookup_handler): Update for OAF and for external apps as well as components. (handle_via_external): Handler to set up for data that can be displayed by an external application. * mail-display.c (on_link_clicked, etc): Refactor the save_data() code and add launch_external() as a handler for x-evolution-external URLs. (embeddable_destroy_cb): Remove this, since it seems like it's all wrong. (on_object_requested): Update for OAF, and fix some bugs. 2000-07-25 Jeffrey Stedfast * mail-config.c (get_service_url): Always prepend a leading "/" to the url->path. (set_service_url): Added more error checking and also strip the leading '/' from the url->path (create_identity_page): Set the signature file to the one specified in the identity record, else set the default path to ~/.sugnature 2000-07-25 Michael Meeks * mail-config.c (create_identity_page): set default signature to ~/.signature 2000-07-25 Peter Williams * mail-ops.c (reply): Check for the case of fb->mail_display-> current_message = NULL, which shouldn't happen, but has happened to me. 2000-07-25 Dan Winship * message-thread.c (group_root_set): Don't group together messages with the same non-Re: subject and no References/In-Reply-To. More often than not, they're unrelated. (eg, "[No subject]".) (thread_messages): Handle messages with no Message-Id. "This shouldn't happen", but it does sometimes, and it's not much code to make it just work. 2000-07-25 Ettore Perazzoli * mail-config.c (create_service_page): Call `gtk_option_menu_set_menu()' as the last thing, as `GtkOptionMenu' is fscking broken. Also, `gtk_widget_show()' the individual menu items. 2000-07-24 Dan Winship * message-list.c (mark_msg_seen, ml_tree_set_value_at, message_list_regenerate): Update for CamelFolder API changes. (Certain functions no longer take a CamelException.) * mail-ops.c (real_fetch_mail, real_send_mail, real_delete_msg): ditto * component-factory.c (real_create_imap_storage, real_create_news_storage): ditto 2000-07-24 Dan Winship * component-factory.c, folder-browser-factory.c, test-mail.c: Remove GOAD support. * main.c: Remove GOAD support. (main): More "guess the build mistake" fun, this time for the failure to initialize Bonobo case. 2000-07-24 Peter Williams * mail-tools.c (mail_tool_set_uid_flags): Change function to faithfully pass parameters to camel_folder_set_message_flags; this function is somewhat useless now. Other files synced with API change. * mail-ops.c (op_display_message): Change "display a message" into "retrieve a messsage" in the description of mail_op_display_message. * mail-threads.c (display_timeout): New function. Only display the progress dialog if the operation takes more than a second to perform. (hide_queue_window): New function. Hide the queue window as an idle function... I'm thinking maybe the problem with hiding it was due to us not being in a GTK event sequence? Perhaps it's only the timeout, which was not being cancelled, which is now. * message-list.c (get_message_uid): New function, copy of get_message_info, except gets only the UID, as that's all that most functions want, and we avoid a Camel call. 2000-07-23 Ettore Perazzoli * mail-ops.c (create_message_composer): New. (compose_msg): Use it. (send_to_url): Likewise. (forward_msg): Likewise. * folder-browser-factory.c (control_activate): Use `_()' instead of `N_()'. 2000-07-21 Peter Williams * message-thread.c (setup_thread_messages): New operation: thread_messages, simple wrapper around thread_messages () and thread_messages_free(); * message-list.c (cleanup_regenerate_messagelist): Use new thread_messages operation instead of just calling ... thread_messages :-) * folder-browser.c (folder_browser_destroy): Use new sync_folder operation instead of calling camel_folder_sync directly. * component-factory.c (create_folder): Changed to use new create_folder operation. * mail-ops.c (mail_do_create_folder): New operation: create folder. New operation: sync folder. * mail-format.c (cmm_destroyed): Remove the url hashtable from the larger hashtable when it gets destroyed. * mail-callbacks.c (fetch_mail): Pass a hook function and data down the chain to pick up the folder_changed and change the view. * mail-ops.c: Rename from mail-ops-new.c now that it's a little more solid. (fetch_mail): Add new options to hook and unhook an event while the filter driver runs. A hack, but all of the operations are to some extent. (cleanup_fetch_mail): Unref the destination folder if not NULL. * mail-tools.c (mail_tool_filter_contents_into): Intermediate the event hook/unhook hack here. 2000-07-20 Peter Williams * mail-ops-new.c (setup_send_mail): Fix silly forgetting-to-ref problem on some sends (when not replying). Note the early exit path with a big comment. * message-list.c (message_list_set_folder): Don't call folder_changed, call mail_do_regenerate_messagelist, as the GDK_THREADS_ENTER in the former can deadlock us! * folder-browser.c (folder_browser_set_uri): Ah, screw it. Make 'load folder' asynchronous and pretend that it always succeeds. * mail-ops-new.c (mail_do_load_folder): New operation, loads a folder into a FolderBrowser. * mail-threads.c (read_msg): Check if the exception is a user cancel; don't complain if it is. (mail_operation_queue): Same. (dispatch_func): Same. 2000-07-20 Peter Williams * mail-ops-new.c (cleanup_send_mail): Fix evil mistaken unref. * test-thread.c: Fit the new mail_operation_spec prototype. * mail-callbacks.c (composer_send_cb): Hide the composer upon start of send operation. * folder-browser.c: #include "mail-ops-new.h" * mail-threads.h: Change text fields of mail_operation_spec to provide two forms of the name. * mail-threads.c: Use appropriate new string fields. (dispatch_func): Hide the progressbar by default. * message-list.c (op_regenerate_messagelist): Fix the datasize from 0 -> sizeof (regenerate_messagelist_data_t). Add the new gerund and infinitive strings. (do_regenerate_messagelist): Include some code that fell between the cracks. * mail-ops-new.c (op_scan_subfolders): Same datasize fix for scan_subfolders. (op_forward_message): Same. (all): Add new gerund and inifinitive strings for mail_operation_spec. (cleanup_send_mail): Destroy the composer on success; re-show it on error. I'm so clever! 2000-07-20 Ettore Perazzoli * component-factory.c (factory_fn): Updated for the new `evolution_shell_component_new()' arg. 2000-07-19 Jeffrey Stedfast * message-thread.c (thread_messages): What if message info is NULL? 2000-07-17 Peter Williams * component-factory.c (real_create_{imap,news}_storage): Instead of directly calling evolution_storage_new_folder, queue up a list of folders to register so that we don't do our CORBA in The Other Thread. (create_{imap,news}_storage): Changes ancillary to the above. (add_new_mailbox): New function to queue up a folder (cleanup_create_info): New function to dequeue the folders and free mem. * test-thread.c: s,ENABLE_BROKEN_THREADS,USE_BROKEN_THREADS -- oops * mail-format.c: (mail_lookup_url_table): New function to get the url table associated with a CamelMimeMessage because we can no longer gtk_object_get_data on it. * mail-display.c: replace 'gtk_object_get_data( message, "urls" )' with 'mail_lookup_url_table( message )' 2000-07-16 Jeffrey Stedfast * folder-browser.c, component-factory.c: Initial code to support IMAP folders that don't use "/" as a directory separator. 2000-07-15 Ettore Perazzoli * mail-ops.c (set_x_mailer_header): New helper function to set the `X-Mailer:' header to to `Evolution [Developer Preview]". (real_send_mail): Call it. 2000-07-14 Peter Williams * message-list.c (message_list_set_folder): Ported to CamelObject: GTK_OBJECT->CAMEL_OBJECT; gtk_signal_connect->camel_object_hook_event; GDK_THREADS_ENTER/LEAVE around "changed" event hooks. * folder-browser.c (folder_browser_destroy): likewise. (mail_uri_to_folder): likewise. (folder_browser_load_folder): likewise. 2000-07-14 Ettore Perazzoli * Makefile.am (evolution_mail_LDADD): Add `GCONF_LIBS'. 2000-07-14 Dan Winship * mail-format.c (write_headers): put a

at the end of the header table. (I think there used to be whitespace after it, but then some gtkhtml change got rid of it...) (handle_text_plain): Don't do this 

. Instead, CONVERT_NL and
	CONVERT_SPACES and wrap it in . Now if the sender didn't
	include any newlines, it will be wrapped to the width of the
	window instead of extending off into infinity.

2000-07-13  Dan Winship  

	* message-list.c (message_list_destroy): Only unref the folder if
	it's been set.

	* folder-browser.c (folder_browser_destroy): Only sync the folder
	if it's been set.

2000-07-13  Jonathan Blandford  

	* mail-config.c (create_transport):
	s/CAMEL_SERVICE_NEED_HOST/CAMEL_SERVICE_URL_NEED_HOST.

2000-07-13  Dan Winship  

	* mail-config.c (add_row): Add a "gboolean required" argument, and
	set its value on the entry.
	(create_source, create_transport): Create rows for URL elements if
	the URL ALLOWs them. Mark them required if it NEEDs them.
	(service_note_doneness): Only require the required fields to be
	filled in.

	Now the IMAP config page allows the user to enter a path, but
	doesn't require it.
	
2000-07-13  Jeffrey Stedfast  

	* mail-ops.c (real_fetch_mail): Back to the old way to avoid
	g_warnings, yay. Also fix append to send a flags argument (0)

2000-07-12  Chris Toshok  

	* mail-config.c (providers_config_new): fix some cut & paste bung.

2000-07-12  Chris Toshok  
	
	* mail-format.c (setup_function_table): add "message/news" to the
	mime_function_table using the same handler as message/rfc822.

2000-07-12  Chris Toshok  

	* mail-config.glade*: add news server tab to dialog.

	* mail-config.c (on_NewsServerConfigDialogButton_clicked): new function.
	(on_clistNewsServers_select_row): new function.
	(on_cmdNewsServersAdd_clicked): new function.
	(on_cmdNewsServersEdit_clicked): new function.
	(on_cmdNewsServersDelete_clicked): new function.
	(providers_config_new): mirror the source tab's code to fill in
	the news server tab.
	(write_config): save out the news server.
	(create_news_server_config_dialog): new function.
	(create_news_server_page): new function.

2000-07-12  Peter Williams  

	* mail-display.c (save_data): Change from evolution_dir to
	g_get_home_dir() for default location of save file.

2000-07-11  Dan Winship  

	* Update for CamelFolder API changes

2000-07-11  Jeffrey Stedfast  

	* mail-ops.c (real_fetch_mail): Changed to use 
	camel_folder_move_message_to () rather than get_message () and then
	append_message (). This also makes it so we don't have to worry about
	fetching message flags to pass to the new append_message () method.

	* folder-browser.c (folder_browser_load_folder): Disable
	Search capability menu/entry if folder doesn't support it.

	* message-list.c (message_list_regenerate): Don't perform
	a search if the folder doesn't support it.

2000-07-11  Dan Winship  

	* mail-ops.c (real_send_mail): Set the post_send_data flag rather
	than toggling it. (Maybe we'll need more control over it later,
	but for now, the only flag we set is "replied", and we want
	that set, not toggled.)

2000-07-10  Dan Winship  

	* folder-browser-factory.c (control_activate): Work with both
	current and 0.15 bonobo

	* kill more debugging messages

	* mail-ops.c (real_fetch_mail): Don't multiply free dest_url.

	* message-list.c (message_list_select): Update
	message_list_select_next to do either next or previous.

	* folder-browser.c (etable_key): Make 'n' and 'p' do next and
	previous unread message.

	* mail-ops.c (select_first_unread): Update.
	(real_fetch_mail): clean up a bit.

2000-07-10  Ettore Perazzoli  

	* mail-ops.c (forward_msg): Initialize `fwd_subj' to NULL if
	`from' is NULL.

2000-07-10  Jeffrey Stedfast  

	* mail-ops.c (real_fetch_mail): Fixed broken POP fetching

2000-07-10  Ettore Perazzoli  

	* component-factory.c: Removed variable `browsers'.
	(create_view): Don't update it.
	(owner_unset_cb): Don't sync the folders here anymore, because at
	this point the folder browser is dead already so we cannot get a
	valid list of folders from it anymore.

	* folder-browser.c (folder_browser_destroy): Sync the associated
	mailbox first.

2000-07-10  Christopher James Lahey  

	* message-list.c, message-list.h: Switched from ETable to
	ETableScrolled.

2000-07-10  Jeffrey Stedfast  

	* mail-ops.c (real_fetch_mail): Fixed movemail so that it too would
	deliver to Inbox.

2000-07-09  Dan Winship  

	* message-list.c (get_message_info): Don't g_warn if the user
	selects a fake tree parent.
	(message_list_select_next): Ignore fake rows
	(build_tree): Store the "root_subject" for fake rows
	(ml_tree_value_at): Display the correct subject for fake rows.
	(on_cursor_change_cmd): Update for the other changes and set
	cursor_uid to NULL when the cursor is on a fake row.

	* mail-ops.c (reply): Don't try to reply when no (real) message is
	selected.
	(forward_msg): Ditto.

2000-07-09  Christopher James Lahey  

	* message-list.c: Remove setting of dnd_code since that's handled
	internally to ETable.

2000-07-08  Dan Winship  

	* folder-browser.c (etable_key): Fix up the pageup/pagedown
	increment a bit.

	* folder-browser-factory.c (control_activate): Add a "Threaded
	Message List" item to the "View" menu.

	* message-list.c (message_list_toggle_threads): Handler for that.
	(build_flat): New function to build a "flat" message list using
	the tree model.
	(message_list_regenerate): Build tree or flat message list
	depending on the global setting.

	* message-thread.c (get_root_subject): fix a "Re:" parsing bug

2000-07-08  Jeffrey Stedfast  

	* mail-ops.c (real_fetch_mail): Always dump incoming messages to
	Inbox (assuming not filtered to another location).

2000-07-08  Ettore Perazzoli  

	* folder-browser-factory.c (control_activate): Move the
	"Expunge" item to the "Action" menu.
	(control_deactivate): Accordingly.

2000-07-08  Dan Winship  

	* mail-ops.c (forward_msg): Deal with having multiple selected
	messages.

	* mail-format.c (mail_generate_forward): Removed. (Integrated into
	forward_msg)

2000-07-08  Jeffrey Stedfast  

	* message-list.c (build_tree): Small fix to stop uid data from
	being set on a message-list tree node when it didn't correspond
	to an actual message.

2000-07-08  Dan Winship  

	* message-list.c (get_message_info): Fix Jeff's FIXME: This does
	get called with out-of-range data sometimes, so we do need the
	check. Use e_table_model_row_count to get the actual right answer.

2000-07-07  Jeffrey Stedfast  

	* message-list.c (get_message_info): This wasn't quite right, it
	will now work but still isn't perfect. See FIXME comment.

2000-07-07  Dan Winship  

	* message-thread.c (remove_node): Add another argument "clast"
	pointing to the container before the current one in the list,
	which it can update if that turns out to be the one that it
	removed.
	(group_root_set): Update for remove_node change, and remove both
	nodes in the "subjects are common" case. Fixes a bug that would
	cause the message list to be truncated if this rule was invoked.

	(sort_node): sort the tree by the original order of the messages
	in the folder rather than by date.

2000-07-07  Dan Winship  

	* message-list.c: Lots of changes. Store uids as node data on the
	tree nodes and use those rather than rows where possible. (The
	concept of "row" is just getting too complicated.) Get rid of the
	summary_table, because given a uid we can call
	camel_folder_get_message_info, which makes more sense than keeping
	a separate uid->row hash table ourselves.

	(get_message_info): update
	(get_message_row): removed
	(ml_col_cound, ml_row_count, ml_value_at, ml_set_value_at,
	ml_cell_is_editable, ml_duplicate_value, ml_free_value,
	ml_initialize_value, ml_value_is_empty, ml_value_to_string):
	Removed. We always use the tree model now.
	(message_list_init): Remove the non-tree code.
	(build_tree): store uids in the tree rather than row numbers,
	and build the message_list->uid_rowmap to map from uids to rows
	when needed.
	(message_list_regenerate): Renamed from _set_search, since it's
	used to redraw in non-search cases too.
	(message_changed): Use the uid_rowmap to get a model row number.

	* message-thread.c (thread_messages): Change the interface on this
	to work with the new MessageList.

	* folder-browser.c (search_set, folder_browser_clear_search): 
	s/message_list_set_search/message_list_regenerate/

2000-07-07  Christopher James Lahey  

	* message-list.c (get_message_info): Handle a row number of -1
	properly.

2000-07-06  Dan Winship  

	* message-list.c (get_message_info): Map tree model row numbers to
	summary row numbers.
	(ml_tree_value_at, ml_tree_set_value_at,
	ml_tree_is_cell_editable): So don't do that here.

2000-07-06  JP Rosevear  

	* mail-config.glade*: Glade files for the configuration dialog.
	
	* mail-config.c (providers_config_new): Build the dialog with
	glade.

2000-07-06  Dan Winship  

	* folder-browser-factory.c, folder-browser.c, mail-ops.c,
	message-list.c: fix warnings.

	* main.c (main): gtkhtmllib_init is no more. Call gconf_init
	directly instead.

	* message-list.c (message_list_select_next): New function to
	select the first message on or after the given row that meets
	certain flag criteria.

	* mail-ops.c (real_fetch_mail): call message_list_select_next to
	select first unread message in current folder if it changes.
	(real_delete_msg): Remove the code to move the etable cursor. It
	only makes sense really if you deleted the message with the
	keyboard, so do it from etable_key.

	* folder-browser.c (etable_key): call message_list_select_next to
	select next non-deleted message after Delete.

	* mail-identify.c: Add a workaround for a small gnome-vfs 0.2 bug
	so we don't need to require CVS gnome-vfs.

2000-07-06  Not Zed  

	* message-thread.c (sort_thread): sort messages based on date for
	the initial sort order.
	(thread_messages_free): Implement.

	* message-list.c (message_list_init_header): Setup the subject
	renderer to a tree in tree mode.
	(on_cursor_change_cmd): For a tree model, map the view row to the
	data row.
	(build_tree): Builds the tree data structure of all messages.
	(message_list_set_search): For a tree model, build the tree here.
	(ml_tree_icon_at): Icon callback, returns nothing.
	(ml_tree_value_at):
	(ml_tree_set_value_at): 
	(ml_tree_is_cell_editable): Maps tree node to data row, and calls
	the equivalent table callback
	(message_list_init_renderers): Setup the tree renderer if needed.
	(message_list_init): set the root node invisible afterall.
	(message_list_set_search): Clear the old tree before putting in a
	new one.

	* message-list.h: Add a tree renderer to render list, and
	tree_view indicator.

	* message-thread.[ch]: Code for message threading. 

2000-07-05  Dan Winship  

	* mail-identify.c (mail_identify_mime_part): Oops. My gnome-vfs
	was out-of-date. Update for changed function name.

2000-07-05  Dan Winship  

	* mail-identify.c (mail_identify_mime_part): Use the gnomevfs
	sniff buffer interface to try to identify the MIME type when
	everything else fails.

	* mail-display.c (on_object_requested):
	* mail-format.c (lookup_handler, handle_undisplayable,
	handle_audio): s/gnome_mime/gnome_vfs_mime/

	* Makefile.am: Add gnomevfs stuff

2000-07-03  Ettore Perazzoli  

	* component-factory.c (create_folder): Get rid of a compiler
	warning by making sure `folder' is always initialized to some
	value for any code path.

2000-07-03  Dan Winship  

	* message-list.c (select_msg): call mail_display_set_message with
	NULL if the message we tried to select doesn't exist (probably
	meaning we tried to selecte the first message and the folder is
	empty.)

	* mail-display.c (mail_display_set_message): deal with NULL as an
	input (meaning "undisplay previous message and display nothing").

2000-07-02  Dan Winship  

	* mail-ops.c (real_fetch_mail): Remove hack to redisplay the
	inbox, since folder_changed signals will now be emitted
	appropriately.

	* component-factory.c (create_vfolder_storage): Fix
	filter_driver_new invocation.

	* Makefile.am (bin_PROGRAMS): test-mail and test-thread should be
	noinst.

	* mail-ops.c (real_fetch_mail): 
	(vfolder_editor_clicked): 
	* component-factory.c (create_vfolder_storage):
	Pass mail_uri_to_folder and rules to filter_driver_new.

2000-07-02  Ettore Perazzoli  

	* folder-browser.c (mail_uri_to_folder): Fix double freeing of the
	local exception `ex'.

2000-07-01  Ettore Perazzoli  

	* mail-ops.c (refile_msg): Only allow type "mail" in the folder
	selection dialog.

2000-07-01  Dan Winship  

	* pixmaps.h, pixmaps/*.xpm: Removed. These aren't being used any
	more. (The real pixmaps are in ../art.)

2000-07-01  Jeffrey Stedfast  

	* message-list.c (get_message_info):
	(select_msg): Updated to reflect camel-folder changes.

	* mail-ops.c (real_fetch_mail): Modified to reflect camel-folder
	changes.

2000-06-30  Dan Winship  

	* mail-ops.c (print_msg): Use gnome-print to do a print preview.

	* folder-browser-factory.c: Hook up "Print" button.

	* message-list.c (message_list_foreach): New function, a wrapper
	around e_table_selected_row_foreach, which calls the callback
	function with UIDs rather than row numbers.

	* folder-browser-factory.c: Remove never-used "Find" button from
	the toolbar and replace it with "Refile". (We need a better icon
	for this...). Hook up "Refile" to "refile_msg".

	* mail-ops.c (refile_msg): Call the shell's user_select_folder
	routine, and then use message_list_foreach and real_refile_msg to
	do the work.
	(delete_msg): Update to use message_list_foreach.

	* folder-browser.c (mail_uri_to_folder): new function, extracted
	from folder_browser_load_folder, to turn a URI into a folder.
	(folder_browser_load_folder): Use it.

2000-06-30  Peter Williams  

	* component-factory.c (create_news_storage, create_imap_storage):
	Fixed to use new EvolutionShellClient proxy thingamajiggie.

2000-06-30  Dan Winship  

	* message-list.c (on_row_selection): use the ETable row_selection
	signal to track how many rows are selected. Eventually we will use
	this info to disable toolbar buttons when you have too few/too
	many messages selected, but the current toolbar widget doesn't
	allow that.

	* message-list.h, message-list.c, mail-ops.c: Change selected_row
	and selected_uid fields of MessageList to cursor_row and
	cursor_uid to be more correct according to the new ETable
	interfaces.

2000-06-30  Ettore Perazzoli  

	* component-factory.c: Eeek.  Fix typo: add missing star in the
	declaration of `global_shell_client'.

2000-06-29  Ettore Perazzoli  

	* component-factory.c: Replace `global_shell_interface' with
	`global_shell_client'.

2000-06-29  Jeffrey Stedfast  

	* mail-ops.c (delete_msg): Clean up compile warnings
	(real_fetch_mail): Fetching from IMAP should do nothing

2000-06-29  Christopher James Lahey  

	* mail-ops.c: Handle multiple deletes (change by Peter Williams.)

2000-06-29  Jeffrey Stedfast  

	* folder-browser-factory.c: Changed "Send" to "Compose" to
	avoid user confusion. Compose is a little more intuitive.
	Also changed the pixmap to MAIL_NEW instead of MAIL_SND

	* mail-ops.c (compose_msg): Renamed to avoid confusion

2000-06-29  Dan Winship  

	* component-factory.c (create_imap_storage, create_news_storage):
	remove some code incorrectly copied and pasted from
	create_vfolder_storage which caused vfolder creation to stop
	working.

2000-06-29  Christopher James Lahey  

	* message-list.c, mail-ops.c: Changed the name of
	e_table_select_row to e_table_set_cursor_row.

2000-06-29  Peter Williams  

	* message-list.c (message_list_init): Set the dnd_code of the
	ETableHeader to something so that Solaris sprintf doesn't die
	on a NULL string.

	* mail-config.c (providers_config_new): Check for a null "transport"
	string (not all OS' handle NULL strings well *cough* Solaris)

2000-06-28  Dan Winship  

	* mail-format.c (mail_generate_forward): add default subjects

	* component-factory.c (create_folder): Refuse to create folders
	not of type "mail", and correctly create an empty "mbox" folder
	for new folders in /local.

	* main.c (init_corba): Call od_assert_using_oaf() or
	od_assert_using_goad() as appropriate to make sure people didn't
	somehow trick the build system.

2000-06-28  Jeffrey Stedfast  

	* message-list.c: Added prototype for filter_date to make
	it build cleanly

2000-06-27  Christopher James Lahey  

	* message-list.c: Made dates display grouping information
	properly.

2000-06-27  Peter Williams  

	* message-list.c (mark_msg_seen): Need to return a value
	on error.

	* main.c (main): Don't start threads or enter threads if
	there's no threading! Sigh.

	* test-thread.c: Don't compile if no threads.

	* session.c: Work without broken threads.

	* message-list.c (filter_date): Solve the ctime_r problem the
	correct way, with the magic of autoconf.

2000-06-27  Christopher James Lahey  

	* message-list.c: Work around mismatched ctime_r functions.  This
	will be fixed.

2000-06-27  Peter Williams  

	* mail-threads.c: Don't compile this if we don't have
	threads enabled. This should maybe be on the Makefile.am
	level.

2000-06-27  Michael Zucchi  

	* component-factory.c (owner_set_cb): Put in a gross hack to
	export the shell reference elsewhere.

2000-06-26  Christopher James Lahey  

	* message-list.c: Added a value_to_string handler.

2000-06-26  Peter Williams  

	* component-factory.c, mail-ops.c: #ifdef the threads stuff so
	that if USE_BROKEN_THREADS is not defined we just call the functions
	in the main thread.

	* mail-threads.h: Don't declare funcs if USE_BROKEN_THREADS not
	defined.

	* mail-threads.c: Put the query and message boxes on top so that
	you can see them.

2000-06-26  Jeffrey Stedfast  

	* mail-config.c (error_dialog): va_start() returns void, don't
	assign it's retval to a variable.

2000-06-26  Ettore Perazzoli  

	* main.c (main): Call `GDK_THREADS_ENTER()' and
	`GDK_THREADS_LEAVE()' around the main loop as in the examples from
	the GTK+ FAQ.

	* mail-threads.c (DEBUG): New macro for debugging.
	(read_msg): Use it.

2000-06-25  Peter Williams  

	* Makefile.am: Clean up the various _LIBS and _CFLAGS
	to work with simpler THREADS_LIBS and THREADS_CFLAGS scheme.

2000-06-23  Jeffrey Stedfast  

	* folder-browser.c (folder_browser_load_folder): Improved the
	code to separate the imap namespace from the folder name.

2000-06-23  Peter Williams  

	* component-factory.c: Include e-util/e-setup.h for the
	prototype of evolution_dir; prototype create_news_storage.
	(real_create_imap_storage, real_create_news_storage): New
	functions moving the camel stuff into the async callback.
	(create_imap_storage, create_news_storage): Chopped in
	half to move camel stuff as above.

	* mail-ops.c: Include "mail-threads.h" for threading protos.
	(real_fetch_mail, real_send_mail, real_expunge_folder): 
	New functions moving the camel stuff into the async callback.
	(async_mail_exception_dialog): A version of mail_exception_dialog
	to be called from the async handlers (just calls mail_op_error())
	(fetch_mail, expunge_folder, composer_send_cb): Cut in half to
	move camel stuff as above.
	(cleanup_send_mail): Clean up after the async real_send_mail
	with the gtk_object_destroys et al.

	* mail-threads.c: Instead of hiding the progress bar, make it
	zip back and forth constantly.
	(progress_timeout): New func. Timeout called to make the pbar
	shimmy.
	(timeout_toggle): New func. Turn on and off the shimmy effect.
	(check_cond): New func. Make sure that the GCond for modal
	operation is initialized before mail_op_{error,get_password}.
	(show_error_clicked, read_msg, get_password_clicked): Move
	over to timeout_toggle.
	(mail_op_error,mail_op_get_password): Add check_cond() call.

	* main.c: (main) Call g_thread_init.

	* session.c: Change auth_callback stuff over to assume that it's
	being called async. Note: no real good way to tell if this is
	the case or not.
	(request_callback): ifdef'ed out
	(evolution_auth_callback): Use mail_op_get_password.
	
2000-06-22  Jeffrey Stedfast  

	* folder-browser.c (folder_browser_load_folder): Now should
	correctly get the selected folder from the given URL.

2000-06-22  Chris Toshok  

	* folder-browser.c (folder_browser_load_folder): add handling for
	loading "news:" folders.

	* component-factory.c (create_news_storage): add a root for news
	source.
	(owner_set_cb): call create_news_storage.

2000-06-22  Jeffrey Stedfast  

	* folder-browser.c (folder_browser_load_folder): Updated to
	prepend url-> path if it exists for that imap store.

	* component-factory.c (create_imap_storage): Modified to not
	prepend a hard-coded namespace.

2000-06-22  Chris Toshok  

	* mail-ops.c (fetch_mail_cleanup): new function, passed as arg to
	mail_operation_try.
	(fetch_mail): add cleanup func arg.

2000-06-22  Christopher James Lahey  

	* message-list.c: Changed ml_value_at to return "" instead of NULL
	in some cases.

2000-06-22  Peter Williams  
	* Makefile.am: Add GNOME_EXTRA_LIBS so that we get libgthread
	in our LIBS for evolution-mail.
	
	* mail-threads.c: Make the dialog boxes for error and
	question non-modal. They're modal relative to the dispatch
	thread, but before they would also eg lock up the toolbar
	buttons (while the menus, managed by another process, were
	active -- a weird effect).
	
2000-06-22  Peter Williams  

	* mail-threads.[ch]: Extra argument to mail_operation_try:
	'cleanup', a function to be called in the main thread after
	the dispatcher thread exits. gtk_object_destroy's et al may
	attempt to unmap windows so we can't do them in the dispatcher
	thread :-(

	* test-thread.c: Updated with demo of new argument working.

2000-06-22  Peter Williams  

	* test-thread.c (op_5): New tests for the get_password
	hook.

	* mail-threads.[ch]: New hook, mail_op_get_password, for
	getting a user response from an async operation. The operation
	blocks while waiting for the response. A big whole mutex 
	condition threading blocking dealie to make sure that it 
	works.

	Also the error hook creates a dialog again, which also needs
	to block its caller while we wait for the user to press ok.

2000-06-22  Peter Williams  

	* mail-threads.c (various functions): Prettify the UI
	so that the progress bar doesn't become all huge 'n stuff.
	(mail_operation_try): Now save the operation's description,
	so that we can display it later as the default message.
	(read_msg): When the operation starts set the label to its
	UI-friendly name.
	(dispatch_func): Free the saved prettyname.

2000-06-21  Christopher James Lahey  

	* message-list.c: Removed an erroneous comment.

2000-06-21  Dan Winship  

	* mail-config.c (create_transport_page): Make this not crash if
	you don't have a transport configured.
	
	* message-list.c: Update received date to work like sent date.

2000-06-21  Peter Williams  

	* mail-thread.{c,h}: New files -- a simple API for executing
	the major mail ops (fetch_mail etc) asynchronously, allowing
	the operations to send messages and update a progress bar.

	* test-thread.{c,h}: Tests the mail-thread API.

	* Makefile.am: add mail-thread.[ch] to evolution_mail_SOURCES
	and declare the test_thread noinst_PROGRAM.

2000-06-21  Peter Williams  

	* mail-format.c (mail_generate_reply): Include "e-setup.h" to
	get the prototype for evolution_dir.

2000-06-20  Jeffrey Stedfast  

	* component-factory.c (create_imap_storage): Oops. Should
	have checked for a NULL sources.

2000-06-20  Dan Winship  

	* message-list.c (mark_msg_seen): Quick hack to prevent a NULL
	pointer dereference. Things need to be cleaned up a bit more here
	though.

	* mail-sources.c: Oops. This should have been removed a long time
	ago.

2000-06-20  Jeffrey Stedfast  

	* folder-browser.c (folder_browser_load_folder): Working on getting 
	this to work :)

	* component-factory.c (create_imap_storage): Should now correctly
	construct the folder path allowing the selection of a folder.

2000-06-20  Ettore Perazzoli  

	* mail-format.c (mail_generate_reply): Declare `evolution_dir'.
	Ugly, ugly, ugly, but I am not sure where it should go instead.

2000-06-19  Ettore Perazzoli  

	* mail-ops.c (ask_confirm_for_empty_subject): New function to ask
	confirmation for an empty subject line.
	(composer_send_cb): Use it if the subject is empty and only send
	the message if the user confirms.

2000-06-20  Jeffrey Stedfast  

	* component-factory.c (create_imap_storage): Now creates the IMAP
	storage (listing subfolders and such)

2000-06-19  Dan Winship  

	* mail-format.c (find_preferred_alternative): add an option to
	prefer text/plain.
	(reply_body): add an option to prefer text/plain
	(mail_generate_reply): Check the mail sending preferences, and
	generate a text/plain reply if the user prefers to send plain text
	(and we have a text/plain part to generate a reply from).

2000-06-19  Jeffrey Stedfast  

	* mail-config.c (providers_config_new): Should now correctly display
	the Transport page (made it set the optionmenu correctly, before it
	would only set SMTP).
	(create_transport_page): Updated to set the page info to sendmail/smtp
	based on the url.
	(create_service_page): Had to add some code to set data on some objects
	so I could grab the objects I needed to modify in the above function.

2000-06-18  Jeffrey Stedfast  

	* folder-browser.c (folder_browser_load_folder): started to add
	code to load an IMAP folder.
	
	* component-factory.c: Started to add a create_imap_storage 
	method so that we can eventually have our IMAP store displayed 
	in the tree view.
	(create_vfolder_storage): Renamed from
	create_test_storage().
	(owner_set_cb): Updated.

2000-06-17  Dan Winship  

	* message-list.c (message_list_set_folder): Prevent double-freeing
	action on summary_table and uid_rowmap.

2000-06-16  Dan Winship  

	* message-list.c (ml_set_value_at): Implement clicking on the
	envelope icon to set read/unread. Based on a patch by clahey.
	(select_msg): keep the timeout id for the "seen" flagging in the
	message_list structure, so ml_set_value_at can clear it so it
	doesn't re-mark a message seen after you click it unseen.

2000-06-16  Dan Winship  

	* message-list.c (get_message_row): new function to do a uid to
	row mapping.
	(mark_msg_seen, select_msg, message_changed,
	message_list_set_folder): Update for Camel flag changes.
	(on_cursor_change_cmd): Rename "row_to_select" to "selected_row",
	and keep a "selected_uid" as well.

	* mail-ops.c (composer_send_cb): Update for Camel flag changes,
	and fix some memory-handling bugs. (Free the post_send_data when
	the composer is destroyed, not when the user clicks "send", which
	could happen never, or more than once.)
	(delete_msg): Update for Camel flag changes, and fix the "holding
	down the delete key skips some messages" bug.

2000-06-15  Dan Winship  

	* mail-ops.c (fetch_mail): 
	* component-factory.c (owner_unset_cb): 
	* message-list.c (message_list_set_folder): Update for CamelFolder
	changes.

	* folder-browser.c (folder_browser_clear_search): New function to
	revert back to non-searching mode.

	* mail-ops.c (fetch_mail): Use folder_browser_clear_search.

	* mail-display.c (on_url_requested): if the document requests an
	unknown URL, it's not an error; just ignore the URL.

	* mail-ops.c (fetch_mail): If there's no new mail, tell the user.

2000-06-14  Radek Doulik  

	* main.c (main): call gtkhtmllib_init here

2000-06-13  Jeffrey Stedfast  

	* mail-config.c (on_SourceConfigDialogButton_clicked): Make sure source
	is always pointing to something, so a blank is not written to the config file
	on close.

2000-06-13  Ettore Perazzoli  

	* Makefile.am (SHELL_OBJS): Removed.
	(evolution_mail_LDADD): Use `libeshell.a'.  Also use
	`top_builddir' consistently.

2000-06-12  Jeffrey Stedfast  

	* mail-config.c: Got rid of sources_max_row and identities_max_row
	as they are not really needed (just use clist->rows)
	(on_cmdSourcesEdit_clicked): Modified to make 'source'
	point to the data being edited.
	(on_cmdSourcesAdd_clicked): Adds a new clist item and selects it so the
	editor knows where to stick the data when it's done.

2000-06-12  Federico Mena Quintero  

	* message-list.c: Removed the ETableModel thaw handler.

2000-06-12  Dan Winship  

	* folder-browser.c (folder_browser_set_uri): Return the result of
	folder_browser_load_folder.
	(get_prop, set_prop, folder_browser_properties_init): Remove. No
	longer needed.

	* folder-browser-factory.c (folder_browser_factory_new_control):
	Add a "uri" argument, return NULL if setting it fails.
	(folder_browser_factory_new_control): Remove property bag stuff.
	(folder_browser_factory_init, folder_browser_factory): Remove
	this, since we're using the component factory now.

	* component-factory.c (create_view): Update for
	folder_browser_factory_new_control change and return NOTFOUND as
	appropriate.

	* main.c (main): Don't call folder_browser_factory_init.

	* mail-format.c (mail_generate_reply): Fix the subject generation
	so we don't get "Re:  Re:". This is working around something that
	may later be declared a misfeature in Camel.

2000-06-10  Ettore Perazzoli  

	* component-factory.c (create_folder): New stub implementation for
	the folder creation function in the EvolutionShellComponent we
	expose [it simply returns success all the time].
	(factory_fn): Pass this function to `evolution_shell_component_new'.

2000-06-09  Dan Winship  

	* folder-browser.c (folder_browser_new): Add a serial number to
	FolderBrowser.

	* folder-browser-factory.c (control_activate, control_deactivate):
	Include fb serial number in the name of the Bonobo toolbar to
	prevent problems with disappearing toolbars. This is a kludge and
	should go away.


	* mail-ops.c (expunge_folder): display error from
	camel_folder_expunge if there is one.

	* message-list.c (select_row): install an idle function to
	select the row rather than doing it directly. Ugh. What a
	kludge, but at least it works now.

	* session.c (evolution_auth_callback): Update for
	CamelAuthCallback changes. (Uncache passwords when asked to.)

	* mail-ops.c (fetch_mail): close and expunge the source folder
	after copying it to a local folder.

2000-06-09  Ettore Perazzoli  

	* component-factory.c (create_view): Updated to match the changes
	to the definition of `EvolutionShellComponentCreateFn'.  If @type
	is not "mail", return an "unsupported type" error.
	(factory_fn): Pass NULL for the `remove_folder' and
	`create_folder' functions.

2000-06-09  Dan Winship  

	* mail-format.c: Redo things a bit so that whitespace-only
	text parts aren't displayed. (In particular, so that
	whitespace-only subparts of multipart/mixed aren't displayed as
	separate (empty) parts.)

2000-06-06  Dan Winship  

	* mail-ops.c (fetch_mail): 
	* folder-browser.c (folder_browser_load_folder): Update for folder
	creation/existence changes.

	* message-list.c (message_list_set_folder): Remove the code to
	create the folder if it doesn't exist, since we don't want to do
	that.

2000-06-05  Dan Winship  

	* mail-ops.c (composer_send_cb): Leave the composer window around
	if the message doesn't get sent.

2000-06-05  Matt Loper  

	* folder-browser.c (etable_key): Allow "GDK_KP_Delete", a keypad
	delete key, to delete a message.

2000-06-05  Dan Winship  

	* session.c (evolution_auth_callback): Remember passwords between
	calls.
	(forget_passwords): Callback for "Forget Passwords" menu item.

	* folder-browser-factory.c (control_activate): 
	(control_deactivate): Add "Forget Passwords" menu item.

	* mail.h, mail-ops.c: fix some function prototypes

	* folder-browser.c (etable_key): Add "Delete" = delete message.

	* mail-format.c (mail_generate_forward): Update for new composer
	attachment interface.

2000-06-02  Jeffrey Stedfast  

	* mail-config.c (providers_config_new): Added a new notebook
	page that allowed for mail format (text/plain or 
	multipart/alternative)

2000-06-02  Dan Winship  

	* message-list.c (filter_date): If the date in the summary is 0,
	output "?".

	* component-factory.c (create_view): keep a GList of folder
	browsers created
	(owner_unset_cb): Go through the list and close each folder before
	exiting so they sync their summary state, etc to disk.

	* mail-ops.c (fetch_mail): Use camel_service_connect, not
	connect_with_url, since we already passed the URL into
	camel_session_get_store.

2000-06-02  Christopher James Lahey  

	* message-list.c: Use camel_folder_free_summary instead of
	g_ptr_array_free.  Unref the folder when we're done with it.

2000-06-02  Christopher James Lahey  

	* session.c: Revert removal of e_setup_base_dir.

2000-06-02  Dan Winship  

	* folder-browser.c (my_folder_browser_init): Connect to ETable's
	key_press signal.
	(etable_key): scroll mail on space/backspace.

2000-06-02  Christopher James Lahey  

	* message-list.c: Made sent column as wide as from column.

2000-06-02  Jeffrey Stedfast  

	* mail-config.c (on_cmdSourcesAdd_clicked): Changed identity_row
	to source_row as this is a Sources clist we are dealing with and
	not an identity clist
	(on_cmdSourcesEdit_clicked): same
	(on_cmdSourcesDelete_clicked): again, same
	(on_cmdSourcesEdit_clicked): Source editor now fills in data from
	the clist

2000-06-01  Dan Winship  

	* message-list.c: Add a date column.	
	(COL_SENT_WIDTH_MIN): Make this wider.
	(ml_value_at): return the sent date (as a time_t) for COL_SENT.
	(Fix COL_TO too while I'm here.) 
	(ml_duplicate_value, ml_free_value, ml_initialize_value,
	ml_value_is_empty): COL_SENT is numeric now.
	(message_list_init_renderers): Create a date renderer (using
	text_filter to translate the time_t into a string).
	(message_list_init_header): Use render_date for COL_SENT.

2000-06-01  Christopher James Lahey  

	* session.c: Don't call e_setup_base_dir.

2000-06-01  Dan Winship  

	* mail-format.c (mail_generate_forward): Fix forwarding to work
	for people other than me. :) [Although apparently it doesn't
	really.]

	* mail-ops.c (delete_msg): Add a quick hack to move the selection
	down a row when you delete a message.

	* mail-format.c (handle_message_rfc822): use 
 rather
	than 
 to frame the embedded
	message. If 
 text in the subtable won't fit in the 95% width,
	GtkHTML will write past the border of the table (and
	
 causes creeping updates so it's not
	usable for now).
	
2000-06-01  Christopher James Lahey  

	* message-list.c (message_list_init): Turn off the grid in our
	ETable.

2000-06-01  Dan Winship  

	* mail-format.c (write_headers): Oops. This needs to take a
	message argument because we might be writing headers for an
	embedded message/rfc822 subpart rather than the root document.

2000-06-01  Jeffrey Stedfast  

	* mail-config.c: Config dialogs are completed.
	(service_acceptable): Fixed a segfault caused by duplicate 
	camel_exception_free()
	(providers_config_new): Identity and Source clists are now filled in
	when the dialog is created as well as the Transport page

	* folder-browser-factory.c: Renamed Tool/ menu items
	Vfolder was changed to Virtual Folder and
	Configure Camel Providers was changed to Mail Configuration

2000-06-01  Ettore Perazzoli  

	* Makefile.am (evolution_mail_LDADD): Link with
	`libemiscwidgets.a'.

	* mail-display.c (mail_display_new): Use an EScrollFrame instead
	of a GtkScrolledWindow.
	(mail_display_set_message): Likewise.

	* mail-display.h: Replace the GtkScrolledWindow with an
	EScrollFrame.

2000-06-01  Dan Winship  

	* component-factory.c (owner_unset_cb): Quit when the shell exits.
	This is a kludge, but a pretty necessary one until the refcounting
	bugs that keep the component from exiting properly are fixed.

2000-05-31  Jeffrey Stedfast  

	* mail-config.c: Partially implemented the source
	configuration, seems to segfault due to a destroyed
	gnome dialog being destroyed again in the method
	on_SourceConfigDialogButton_clicked()

2000-05-31  Dan Winship  

	* mail-format.c (free_url, handle_text_enriched,
	get_url_for_icon): Fix up memory management of x-evolution-data
	URLs so the URLs and/or their data don't get freed while there are
	still references to them.

	* message-list.c (message_list_init_header): redo the (unused)
	online status column to no longer refer to pixmaps that no longer
	exist.

2000-06-01  Ettore Perazzoli  

	* folder-browser-factory.c (control_activate): Put the toolbar
	into a frame to make it look like standard GNOME toolbars.  Also,
	set `GNOME_DOCK_ITEM_BEH_NEVER_VERTICAL' so that it does not do
	evil things when its moved to the left or the right of the window.

2000-05-31  Jeffrey Stedfast  

	* mail-config.c: Configuration dialog now allows 
	adding/editing/deleting of Identities (which leaves
	adding/editing/deleting of sources left to implement).
	The data is also saved when the dialog is exited via 
	the OK button.

2000-05-31  Dan Winship  

	* mail-format.c (mail_format_mime_message): Initialize the "urls"
	hash table stored on the message and store cid and other URLs
	there rather than as object data on the message.
	(get_cid): rewrite this a bunch
	(handle_text_enriched): move the code from write_iframe_string()
	into here, since it's the only place that actually needs it.
	(handle_text_html): simplify this a lot. We can use a cid: URL
	here rather than x-evolution-data.
	(get_url_for_icon): New routine to return URLs for icons, and
	cache the results, so we don't have to keep re-reading the icon
	files (and so we can't be spoofed into reading non-icon files).
	(handle_mystery, handle_audio): use get_url_for_icon.

	* mail-display.c (save_data): move the CamelMimePart filename
	extracting code from get_cid to here.
	(on_link_clicked, on_object_requested): Update for cid: changes.
	(on_url_requested): Kill off the kludgy, exploitable x-gnome-icon
	URL schema, update cid and x-evolution-data to match
	mail-format.c.

	It should now be easier to implement RFC 2557 (Content-Location,
	etc), but that RFC still pretty much sucks.

2000-05-30  Dan Winship  

	* mail-format.c: Redo this back to the old way: a single GtkHTML
	with various things inline in it. (Gets rid of flicker, simplifies
	some scrolling, selecting, and printing issues.)
	(handle_text_enriched, handle_text_html): Use