2000-07-13 Jeffrey Stedfast * providers/imap/camel-imap-folder.c: * providers/imap/camel-imap-store.c: Updated to use CAMEL_IMAP_OK, CAMEL_IMAP_NO, CAMEL_IMAP_BAD, and CAMEL_IMAP_FAIL rather than the ones copied from the POP3 provider. 2000-07-13 Jeffrey Stedfast * providers/imap/camel-imap-folder.c (imap_get_summary): Oops. If the number of messages in the folder is 0, don't fetch summaries 1 thru 0, just return an empty summary. (imap_copy_message_to): Fixed to use message UID and also send the source folder as an arg to camel_imap_command rather than NULL. (imap_move_message_to): Same. (imap_init): If SELECT is successful, we need to set the current folder to the one selected, this was causing problems with move/copy 2000-07-13 Dan Winship * camel-service.h: define a set of CAMEL_SERVICE_URL_ALLOW_* flags parallel to the _NEED_* flags, and make the _NEED_* flags imply the _ALLOW_* ones. * providers/imap/camel-imap-store.c (camel_imap_store_init): imap urls ALLOW_PATH 2000-07-13 Jeffrey Stedfast * providers/imap/camel-imap-folder.c (imap_get_summary): New and improved approach to fetching an entire folder summary that should be much much faster than the old way as it gets the entire folder summary in 1 shot rather than requesting message by message. As with the last update, this version also only fetches the minimum number of header fields. (imap_get_summary): Oops, forgot to free the temp GPtrArray *headers 2000-07-13 Jeffrey Stedfast * providers/imap/camel-imap-folder.c (imap_get_summary): Don't fetch the entire RFC822 header, just fetch the fields we want. (imap_get_message_info): Same. 2000-07-13 Not Zed * camel-mime-filter-basic.c (camel_mime_filter_basic_new_type): Reset filter on setup. (reset): When resetting qp encoding, set the state to -1, instead of 0. * camel-mime-utils.c (quoted_encode_step): Actually count the characters output sofar (it never counted any). Bunch of other fixes. (quoted_encode_close): Also flush out final character, if there's one. 2000-07-12 Jeffrey Stedfast Chris forgot to add #include to the source files * providers/imap/camel-imap-store.c (imap_connect): Fixed Peter's fix, we don't want to send a string to a %d. 2000-07-12 Christopher James Lahey * camel-folder-search.c, providers/imap/camel-imap-store.c: Changed from strstrcase to e_strstrcase. * string-utils.c, string-utils.h: Removed strstrcase (in favor of e_strstrcase in e-util/e-util.c.) 2000-07-12 Chris Toshok * providers/nntp/camel-nntp-folder.c (nntp_folder_set_message_flags): get the article num out of our uid and mark it read in the newsrc. (nntp_folder_get_message): get the message id out of the uid to fetch the article. * providers/nntp/camel-nntp-utils.c (get_XOVER_headers): the uid is now , (get_HEAD_headers): same. * camel-mime-parser.c (folder_scan_step): go to HSCAN_MESSAGE state when ct->subtype is "news" as well as "rfc822". this makes attachments of type "message/news" display properly. 2000-07-12 Dan Winship * camel-folder.c (camel_folder_free_deep, camel_folder_free_shallow, camel_folder_free_nop): Useful default implementations for free_{uids,subfolder_names,summary}. (free_subfolder_names, free_uids): Make these g_warning-ing default implementations. * providers/*/camel-*-folder.c: Use the new functions where appropriate, remove duplicated code. 2000-07-12 Peter Williams * providers/imap/camel-imap-store.c (query_auth_types): Check for NULL parameters when setting the exception so as to not crash on Solaris (can't handle a %s passed NULL). (imap_connect): Same. 2000-07-12 Jeffrey Stedfast * providers/mbox/camel-mbox-folder.c (mbox_delete_message): Use mbox_set_message_flags () instead of setting the flags by hand. This fixes the problem of the "message_changed" signal not being emitted at the correct time. * providers/imap/camel-imap-folder.c: "folder_changed" signals should pass a third argument (which is ignored). * camel-folder.c: Undo gtk signal emits done in set_flags and expunge. (move_message_to): (copy_message_to): Create info as a const CamelMessageInfo 2000-07-12 Chris Toshok * providers/nntp/Makefile.am: don't add test-newsrc to the build since it needs libcamel (which isn't built at the time test-newsrc needs linking.) * providers/nntp/camel-nntp-utils.c (get_HEAD_headers): fill in MessageInfo->message_id. (get_XOVER_headers): same. * providers/nntp/camel-nntp-folder.c (nntp_folder_init): move summary loading here. (nntp_folder_sync): summary/newsrc changes should be stored here. put a comment to that effect. (nntp_folder_set_message_flags): don't save the newsrc here. (nntp_folder_get_uids): use g_ptr_array_index instead of the cast/addition. (nntp_folder_get_summary): no need to check if we should generate the summary here. already done. (nntp_folder_get_message_info): implement. * providers/nntp/camel-nntp-store.c (camel_nntp_store_get_toplevel_dir): use evolution_dir instead of computing it ourselves. (nntp_store_disconnect): call camel_nntp_newsrc_write. (ensure_news_dir_exists): new function to create the news/ subdir. (camel_nntp_store_class_init): hook up connect/disconnect and finalize. (nntp_store_connect): if ensure_news_dir_exists fails throw an exception. 2000-07-12 Peter Williams * camel-folder.c (camel_folder_set_message_flags): Emit a message_changed signal once the flags are set on the message. (camel_folder_set_user_flag): Ditto. (camel_folder_expunge): Emit a folder_changed if no exception. 2000-07-12 Jeffrey Stedfast * camel-stream.c: Use size_t and ssize_t for read/write methods * providers/imap/camel-imap-folder.c (imap_set_message_flags): Updated to emit the message_changed signal. (imap_delete_message): Updated to use imap_set_message_flags (). (imap_move_message_to): Updated to use imap_set_message_flags () and to emit the folder_changed signal on the destination folder. (imap_copy_message_to): Updated to emit the folder_changed signal on the destination folder. (imap_append_message): Updated to emit the folder_changed signal on the destination folder. 2000-07-11 Jeffrey Stedfast * camel-folder.c (camel_folder_append_message): Now takes a flags argument to specify the flags to be set on the message since we might not necessarily want the flags to be wiped clean. (move_message_to): (copy_message_to): Updated to send a flags argument to append_message (); currently sends the original message's flags. * providers/mbox/camel-mbox-folder.c (mbox_append_message): * providers/imap/camel-imap-folder.c (imap_append_message): Updated. 2000-07-11 Jeffrey Stedfast * providers/imap/camel-imap-folder.c (imap_search_by_expression): This shouldn't return NULL, it should return g_ptr_array_new () so the mailer gets what it expects. 2000-07-10 Jeffrey Stedfast * camel-folder-summary.c (camel_folder_summary_decode_string): Oops, an unsigned integer can never be < 0 2000-07-10 Dan Winship * providers/vee/camel-vee-folder.c (vee_search_by_expression): Initialize a variable to make this not crash again. And fix a bug so it actually does something. 2000-07-10 Jeffrey Stedfast * camel-folder-summary.c: Cleaned up a bunch of compile warnings 2000-07-10 Dan Winship * providers/vee: kill more debugging messages 2000-07-10 Jeffrey Stedfast * providers/mbox/camel-mbox-folder.c (mbox_get_unread_message_count): * providers/vee/camel-vee-folder.c (vee_get_unread_message_count): * providers/imap/camel-imap-folder.c (imap_get_unread_message_count): Implemented. * camel-folder.c (camel_folder_get_unread_message_count): New convenience function to allow the mailer to query the number of unread messages in a folder (for displaying message stats in a folder tree?). 2000-07-09 Dan Winship * camel-mime-utils.c (header_references_dup): New function to copy a header_references structure. * camel-folder-summary.c (camel_message_info_dup_to): New function to (deep) copy the data from one CamelMessageInfo into another. (camel_message_info_free): And free the data. * providers/vee/camel-vee-folder.c (vee_sync): Implement. (empty). (vee_search_by_expression): belatedly update for camel_folder_search change. (vee_folder_build): belatedly update for camel_folder_search change. Use camel_message_info_dup_to and camel_message_info_free (in particular, so that we get message_id and references info so vfolders can be threaded). (vee_folder_build_folder): Ditto. 2000-07-08 Jeffrey Stedfast * providers/nntp/camel-nntp-folder.c: * providers/nntp/camel-nntp-utils.c: * providers/nntp/camel-nntp-store.c: Update to reflect past changes in the Camel API. Use gtk macro casts wherever possible and use glib's memory functions instead of standard c's (since they are not compatable) * providers/smtp/camel-smtp-transport.c: * providers/imap/camel-imap-store.c: Wrap debug print statements in a macro * providers/imap/camel-imap-stream.c (stream_read): Make sure that we get up to and including the last \n of the mime part. * providers/imap/camel-imap-folder.c (imap_get_message): Make sure that we get up to and including the last \n of the mime part. Wrap debug print statements in a macro. * providers/imap/camel-imap-stream.c (stream_read): Only cache the important data (aka the mime part requested and no extra server response stuff) 2000-07-07 Dan Winship * camel-mime-utils.c (header_references_decode): Work around In-Reply-To's with unquoted punctuation. So many broken mailers. * camel-folder.c (camel_folder_search_by_expression): Make this return a GPtrArray rather than a GList. * camel-folder-search.c (camel_folder_search_execute_expression): * providers/imap/camel-imap-folder.c (imap_search_by_expression): * providers/mbox/camel-mbox-folder.c (mbox_search_by_expression): * providers/nntp/camel-nntp-folder.c (nntp_search_by_expression): Update to return a GPtrArray rather than a GList. 2000-07-07 Jeffrey Stedfast * providers/smtp/camel-smtp-transport.c (esmtp_get_authtypes): Fixed the parser to actually work 2000-07-06 Dan Winship * camel-mime-utils.c (header_references_decode): Make this deal with the full RFC822 References/In-Reply-To format rather than just the more-nicely-behaved RFC1036 version. (Needed to parse In-Reply-To headers with extra junk in them.) 2000-07-06 Jeffrey Stedfast * providers/imap/camel-imap-folder.c (imap_get_summary): Parse for more header information to allow message threading in IMAP. (imap_get_message_info): Same. * camel-folder-summary.c: Renamed summary_format_* to camel_summary_format_* and moved them into public scope. * providers/smtp/camel-smtp-transport.c (smtp_connect): Oops. Don't pass port # as a string in the error code (if it fails to connect). * providers/imap/camel-imap-folder.c (imap_append_message): Changed over to camel_imap_command_extended as that was the source of the problems - apparently appending replies with more than just 1 line. 2000-07-05 Dan Winship * camel-folder-search.c (search_header_contains): make header matching case-insensitive * camel-folder-summary.c: * camel-session.c: * providers/mbox/camel-mbox-folder.c: * providers/mbox/camel-mbox-summary.c: Remove some non-error case debugging-type messages. 2000-07-05 Ettore Perazzoli * providers/mbox/camel-mbox-summary.c (d): Define to empty so that we get rid of a ton of debugging messages. 2000-07-05 Jeffrey Stedfast * camel-mime-utils.h: Added prototype for uudecode_step * camel-mime-utils.c (uudecode_step): Cleaned up some junk that should have been cleaned up when debugging printf's were taken out. 2000-07-05 Ettore Perazzoli * providers/mbox/camel-mbox-summary.c (camel_mbox_summary_sync): Update the X-Evolution: header even if the in-memory UID and the saved UID are not the same. Otherwise mboxes with clashing UIDs can never be fixed. * camel-folder-summary.c (camel_folder_summary_add_from_parser): Add the message to the summary before doing any ibex stuff. In fact, this might also have the side effect of reassigning the UID so it needs to be done before we start using the UID. * providers/mbox/camel-mbox-folder.c (mbox_append_message): Add debugging message to keep track of the UIDs we add. 2000-07-05 Dan Winship * camel-folder-summary.c: Add "Cc" to summary and bump summary version number. * camel-folder-search.c (search_header_contains): make "Cc" a searchable header. 2000-07-03 Ettore Perazzoli * camel-folder-summary.c (camel_folder_summary_next_uid_string): New. (camel_folder_summary_add): Use `camel_folder_summary_next_uid_string()' instead of recomputing the UID manually here. (camel_folder_summary_add_from_parser): Likewise. 2000-07-03 Ettore Perazzoli * camel-folder-summary.c (camel_folder_summary_set_uid): Removed. 2000-07-03 Dan Winship * camel-folder-summary.c (message_info_new): Parse In-Reply-To with header_references_decode, not header_msgid_decode. * camel-mime-message.c (camel_mime_message_class_init): message headers are case-insensitive. * providers/pop3/camel-pop3-store.c (camel_pop3_command): Fix a bug in error-setting code. (pop3_connect): Don't re-prompt for password in the KPOP case. (pop3_get_response): New function, split out from camel_pop3_command. (connect_to_server): Use pop3_get_response to parse the greeting message, and error out appropriately if it's -ERR. 2000-07-02 Dan Winship * camel-folder.c (camel_folder_freeze, camel_folder_thaw): New functions to freeze and thaw a folder (to prevent message/folder changed signals in the middle of a long series of operations). (camel_folder_class_init): Change signals to GTK_RUN_FIRST. (message_changed, folder_changed): Add default implementations that stop the emission and record info for later if the folder is frozen. * providers/mbox/camel-mbox-folder.c (mbox_sync): leftover fixes from the close->sync change: don't destroy the ibex, summary, and search when syncing. (append_message): emit "folder_changed" on a successful append. 2000-07-02 Jeffrey Stedfast * camel-mime-utils.c (uudecode_step): A rather complex uudecoder written in the spirit of Zucchi-ness, is it up to par? Only the Z-man can tell us :-) 2000-07-01 Dan Winship * camel-service.c (camel_service_get_name): New method, to return an end-user-friendly name corresponding to a service. (eg, "POP service for danw on trna.helixcode.com"). * providers/imap/camel-imap-store.c, providers/mbox/camel-mbox-store.c, providers/nntp/camel-nntp-store.c, providers/pop3/camel-pop3-store.c, providers/sendmail/camel-sendmail-transport.c, providers/smtp/camel-smtp-transport.c: Implement. * providers/imap/Makefile.am: remove unneeded libcamelimap_la_LDADD. * providers/pop3/camel-pop3-store.c (connect_to_server): fix the CAPA-parsing code to not get into an infinite loop. 2000-07-01 Jeffrey Stedfast * providers/imap/camel-imap-folder.c (imap_get_message): Fixed the bug that would sometimes leave part of the server response tacked on to the end of the message. * camel-folder.c: Renamed _by_uid methods. Since we no longer have get-by-number methods, no need to have the _by_uid extensions. (get_message_by_uid): Renamed to get_message (delete_message_by_uid): Renamed to delete_message (summary_get_by_uid): Renamed to get_message_info * providers/mbox/camel-mbox-folder.c: * providers/pop3/camel-pop3-folder.c: * providers/imap/camel-imap-folder.c: * providers/vee/camel-vee-folder.c: Updated to reflect camel-folder changes. 2000-06-30 Jeffrey Stedfast * camel-folder.c (camel_folder_copy_message_to): New function, to copy a message from one folder to another. The default implementation just uses append_message, but providers can implement more efficient versions for use when both folders are on the same store. * broken-date-parser.[c,h]: Utilities for parsing broken date strings. * providers/imap/camel-imap-folder.c (imap_move_message_to): (imap_copy_message_to): Implemented. * camel-mime-utils.c (header_decode_date): Wrote some code to try and un-mangle broken date formats and then parse that new string instead. 2000-06-30 Dan Winship * camel-folder.c (camel_folder_move_message_to): New function, to move a message from one folder to another. The default implementation just uses append_message and delete_message, but providers can implement more efficient versions for use when both folders are on the same store. 2000-06-29 Jeffrey Stedfast * providers/imap/camel-imap-folder.c (imap_expunge): Should now print a meaningful error message when it doesn't succeed 2000-06-28 Jeffrey Stedfast * providers/imap/camel-imap-store.c (imap_connect): Changed to keep prompting user for a valid password until it either authenticates or until Canceled by the user. (camel_imap_command_extended): Improved speed (replaced the g_strjoinv call with a faster implementation) * providers/pop3/camel-pop3-store.c (camel_pop3_command_get_additional_data): Fixed. (pop3_connect): Changed to keep prompting the user for a password until it either works or until Canceled by the user. * providers/mbox/camel-mbox-summary.c: General cleanup (camel_mbox_summary_sync): Fixed a memory leak and added CamelException handling. * providers/mbox/camel-mbox-store.c (delete_folder): Fixed a memory leak * providers/mbox/camel-mbox-folder.c (mbox_append_message): Default 'off_t seek' to -1 so as to make sure it's initialized before it's used in the case of a bad stat() call. (mbox_sync): Updated (mbox_expunge): Updated 2000-06-27 Jeffrey Stedfast * providers/imap/camel-imap-store.c (imap_connect): Move the CAPABILITY command here so we don't have to keep checking each time we open a folder. (camel_imap_command_extended): If we are doing an EXAMINE, don't bother doing a SELECT first. * providers/imap/camel-imap-folder.c (imap_init): Update so folder->has_search_capability depends on the parent IMAP store (since this is really dependant on the IMAP implementation and not the folder) 2000-06-27 Christopher James Lahey * providers/smtp/camel-smtp-transport.c: Don't close the filter stream when done with it (this causes the source stream to close); Instead, just flush it when done. 2000-06-27 Michael Zucchi * camel-folder-search.c (search_header_contains): Make header search 'to' match 'to', and not 'from', small typo, fixes #317. 2000-06-26 Christopher James Lahey * providers/mbox/camel-mbox-summary.c: Added debugging information. 2000-06-23 Jeffrey Stedfast * providers/imap/camel-imap-store.c: * providers/imap/camel-imap-folder.c: Improved folder parsing. Not specifying a namespace should no longer list the entire filesystem. 2000-06-22 Chris Toshok * providers/nntp/.cvsignore: ignore test-newsrc * providers/nntp/camel-nntp-store.c, providers/nntp/camel-nntp-store.h, providers/nntp/camel-nntp-folder.c, providers/nntp/camel-nntp-folder.h, providers/nntp/camel-nntp-utils.c: Bring the nntp provider up to a state where it builds and is usable with the current camel. there are still warts (semi-broken .newsrc file handling, and a lack of a subscribe ui -- in fact no way to add a new server, really), but it'll display news messages. * providers/nntp/Makefile.am (libcamelnntp_la_SOURCES): add camel-nntp-newsrc.c (libcamelnntpinclude_HEADERS): add camel-nntp-newsrc.h also, add test-newsrc stuff. * providers/nntp/test-newsrc.c: new file that tests the newsrc stuff by parsing and regurgitating a .newsrc file for a particular server. * providers/nntp/camel-nntp-newsrc.c, providers/nntp/camel-nntp-newsrc.h: new files, initial support for .newsrc files. 2000-06-22 Jeffrey Stedfast * providers/imap/camel-imap-folder.c (imap_get_message_count): Oops. Now appends the namespace to the folder before querying for the number of messages. * providers/imap/camel-imap-store.c (imap_folder_exists): New convenience function for use by imap_create(). (get_folder): If folder is specified as "/", we really want "INBOX". * providers/sendmail/camel-sendmail-provider.c: * providers/vee/camel-vee-provider.c: * providers/smtp/camel-smtp-provider.c: * providers/mbox/camel-mbox-provider.c: * providers/pop3/camel-pop3-provider.c: * providers/imap/camel-imap-provider.c: Updated * camel-session.c: Moved service_cache hash table into the providers. (service_cache_remove): Updated. (camel_session_get_service): Updated. * camel-url.c (camel_url_hash): Took out the hashing of url->passwd. We don't want this anymore. * providers/imap/camel-imap-folder.c (imap_init): Took out references to 'namespace' (camel_imap_folder_init): Same * providers/imap/camel-imap-folder.h: No more namespace. We are instead going to use url->path as the namespace. 2000-06-21 Jeffrey Stedfast * providers/imap/camel-imap-store.c (imap_create): Modified to use the "namespace" (url->path) if it exists. * providers/imap/camel-imap-folder.c (imap_delete_message_by_uid): Now just sets the deleted flag on the summary rather than speaking directly to the IMAP server. This is both faster and cleaner. 2000-06-21 Dan Winship * providers/pop3/camel-pop3-store.c (query_auth_types): Fix dumb bug. 2000-06-21 Jeffrey Stedfast * providers/imap/camel-imap-folder.c (imap_get_message_by_uid): We are getting mail in IMAP now!! whoo-hoo!. Stripped out the filtering so messages may have some dot-stuffing, but the filtering can always be added back in later when we know it works and isn't the problem. 2000-06-21 Peter Williams * providers/mbox/camel-mbox-folder.c (mbox_init): Use the basename of the mailbox so we don't get pathnames like ~/evolution/inbox///movemail.ibex 2000-06-21 Dan Winship * camel-folder-summary.c (message_info_new): Set date_received based on the first (most recent) "Received" header. 2000-06-20 Dan Winship * camel-mime-part.c (write_to_stream): flush the filter stream before unreffing it, so it will camel_mime_filter_complete. * camel-stream-filter.c (camel_stream_filter_class_init): Fix a braino so camel_stream_flush works here. * camel-stream-mem.c (stream_seek): Fix a bug that resulted in large attachments being silently dropped. * providers/pop3/camel-pop3-store.c (camel_pop3_command_get_additional_data): Don't use g_strjoinv here, since it is O(n^2) on the length of the output string, and we can do O(n). * camel-mime-part-utils.c (simple_data_wrapper_construct_from_parser): add a CRLF decoder after the QP/B64 decoder if it's text. 2000-06-20 Jeffrey Stedfast * providers/imap/camel-imap-folder.c (imap_get_summary): Only fetch the summary if the folder summary doesn't already exist. When the summary *does* exist, start fetching from 1, not 0. (imap_free_summary): Don't do anything here. (imap_finalize): Free the summary here instead of in imap_free_summary(). (imap_set_message_flags): Implemented (imap_sync): Added code to set flags on messages that have had their flags changed (however I #if'd it out until we are more confidant in the IMAP code :) (imap_summary_get_by_uid): Now parese flags correctly. (imap_get_summary): Now parese flags correctly. Also correctly parses the UID correctly. * camel-url.c (check_equal): No need to check s1 if s2 is NULL (camel_url_equal): Don't check the passwd component of the url. 2000-06-20 Dan Winship * camel-folder-summary.c (camel_folder_summary_add): mark the message info with CAMEL_MESSAGE_FOLDER_FLAGGED if we change the uid, so the folder will know that it's dirty. 2000-06-20 Jeffrey Stedfast * providers/imap/camel-imap-store.c (camel_imap_command_extended): Now returns the last line of data that the server sends back as well. This is needed for commands like SELECT (like Peter pointed out). (camel_imap_command): No longer checks for SELECT (no need) * providers/imap/camel-imap-folder.c: Added namespace stuff which we will need later on... (imap_parse_subfolder_line): Convenience function for use in get_subfolder_names() (imap_get_subfolder_names): Updated. Also changed it to use LIST instead of LSUB (temporary change). 2000-06-19 Jeffrey Stedfast * providers/imap/camel-imap-folder.c (camel_imap_folder_init): Set summary equal to NULL. (imap_get_summary): Store the summary in the ImapFolder (imap_summary_get_by_uid): If we have a summary cache in the ImapFolder, first check to see if that message info is in the cached summary first, if not fetch it directly from the IMAP server and append it to the summary cache. (imap_get_message_flags): Don't free the message info that we get back from summary_get_by_uid as we don't want to be corrupting our cached summary. 2000-06-19 Peter Williams * providers/imap/camel-imap-store.c (camel_imap_command{,_extended}): When SELECT'ing a folder for an IMAP command, use _extended to grab the entire response (before we just used camel_imap_command and missed the OK codes) 2000-06-18 Jeffrey Stedfast * providers/imap/camel-imap-folder.c (imap_summary_get_by_uid): Now gets the message flags as it should. (imap_get_summary): Same as imap_summary_get_by_uid (imap_get_permanent_flags): Return the permanent flags stored on the folder. (imap_get_message_flags): Return message flags associated with given uid. Note: we may want to somehow cache summary info so that we don't have to keep querying the IMAP provider in imap_summary_get_by_uid(). 2000-06-17 Jeffrey Stedfast * providers/imap/camel-imap-folder.c (imap_free_summary): We were leaking memory - but not anymore! (imap_get_summary): We now get the UIDs and the beginnings of the code to get the message flags as well. 2000-06-17 Dan Winship * camel-mime-parser.c (folder_scan_header): Don't copy newlines into the parsed header text, and turn any number of tabs and spaces after a newline into a single space. 2000-06-17 Jeffrey Stedfast * providers/imap/camel-imap-folder.c (imap_init): Should now correctly do CAPABILITY. 2000-06-17 Dan Winship * providers/mbox/camel-mbox-summary.c: Add some debugging printfs when rebulding summary to help figure out why people's summaries are always being rebuilt. 2000-06-17 Jeffrey Stedfast * providers/imap/camel-imap-folder.c (imap_search_by_expression): Began to implement, need to get information on how to deconstruct @expression into an IMAP search expression and parse the results. (imap_init): Now queries the IMAP provider for CAPABILITY to determine if SEARCH is implemented or not. * providers/imap/imap.c: Removed - no longer a need to have this as an example for anyone interesting to help mecode IMAP support. 2000-06-16 Jeffrey Stedfast * providers/imap/camel-imap-folder.c (imap_sync): Added code to expunge if called for (still need to finish coding this). (imap_get_uids): Implemented. (imap_get_summary): Found a way to get the date (imap_summary_get_by_uid): Same. (imap_free_summary): Implemented. * string-utils.c (strstrcase): Fixed a compile warning * providers/imap/camel-imap-summary.c: Removed - we don't need a CamelImapSummary structure. 2000-06-16 Dan Winship Move flag handling from CamelMimeMessage to CamelFolder. This simplifies several flag-handling pieces of code in the mailer, and lets you change a message's flags without having to fetch the message body. It also means that fully-constructed CamelMimeMessages are now essentially constant, which will help simplify locking issues later since it means two threads interested in the same message can just work with separate copies of it. * camel-mime-message.h (struct _CamelMimeMessage): Removed flags and user_flags (moved to summary). Removed expunged and message_number which were unused. Removed message_uid and folder which are no longer needed in the new scheme. (struct CamelMimeMessageClass): Removed message_changed signal and get/set_message_number methods. * camel-mime-message.c: Updates for CamelMimeMessage changes. (camel_mime_message_get/set_flags, camel_mime_message_get/set_user_flag): Replaced with methods in CamelFolder. (camel_flag_get, camel_flag_set, camel_flag_list_size, camel_flag_list_free): Moved verbatim to camel-folder-summary.c * camel-folder.c (camel_folder_get/set_message_flags, camel_folder_get/set_message_user_flag): New methods (and corresponding useless default implementations) (camel_folder_class_init): add a message_changed signal * camel-folder-summary.c (camel_flag_get, camel_flag_set, camel_flag_list_size, camel_flag_list_free): Moved here from camel-mime-message.c * providers/mbox/camel-mbox-folder.c (message_changed): Removed. (mbox_get_message_flags, mbox_set_message_flags, mbox_get_message_user_flag, mbox_set_message_user_flag): Tweak summary bits as appropriate. (Functionality moved here from message_changed.) (mbox_get_message_by_uid): Update for CamelMimeMessage changes (less stuff to initialize). * providers/imap/camel-imap-folder.c (message_changed): Remove this. It was just copied from the mbox provider and doesn't deal with the real IMAP flag stuff anyway. (So there's currently no flag support in the IMAP provider.) (imap_get_message_by_uid): Update for CamelMimeMessage changes. * providers/vee/camel-vee-folder.c: (message_changed): Remove old one. Add a new one to listen for message_changed on each folder and re-emit message_changed signals that correspond to messages in the vfolder. (vee_get/set_message_flags, vee_get/set_message_user_flag): Proxy flag setting to the underlying real messages. (vee_append_message): Removed for now; there's no way to translate this into the new CamelMimeMessage/CamelFolder scheme, but (a) there's also no code which would ever call it and (b) we're probably going want a better interface than append_message for message drag and drop to work anyway. To be revisited. 2000-06-16 Dan Winship * camel-mime-utils.c (rfc2047_decode_word): * camel-mime-part-utils.c (simple_data_wrapper_construct_from_parser): * camel-folder-summary.c (summary_build_content_info): KLUDGE! Since neither ETable nor GtkHTML supports UTF-8 yet, output ISO-8859-1 instead, so Ettore can read his Italian mail. :) This will be reverted later. 2000-06-15 Jeffrey Stedfast * providers/imap/camel-imap-folder.c (imap_get_summary): Started to implement - may want to use ENVELOPE instead of BODY.PEEK[HEADER] (imap_summary_get_by_uid): Started to code, I've got to find a way to get the date in time_t format and also get the flags * string-utils.c (strstrcase): Added this convenience function - I know about strcasestr() but it's not portable. 2000-06-15 Dan Winship * camel-service.c: Remove camel_service_connect_with_url. (URLs must be specified when the service is requested from the session, so that there can only ever be one service for any URL.) * camel-folder.c: (camel_folder_open, camel_folder_is_open, camel_folder_get_mode): Kill. Folders are now always open, and handle "closing" sorts of operations at sync or finalize time. (camel_folder_sync): renamed from camel_folder_close. Syncs state to the store but doesn't necessarily close/disconnect. * providers/*/camel-*-folder.c: Merge "open" methods into "init" methods. Rename close to sync and update appropriately. * providers/imap/camel-imap-store.c: Remove camel_imap_store_open and camel_imap_store_close, which should not have been copied from the POP provider (where the exist to work around limitations of the POP protocol). * providers/mbox/camel-mbox-summary.c: fix a bug. (don't expunge deleted messages if called with expunge == FALSE) * providers/pop3/camel-pop3-store.c (connect_to_server): Check server for various interesting extensions. * providers/pop3/camel-pop3-folder.c (get_uids): If the server supports UIDL, use real UIDs rather than fake ones. (etc): Map uids back to numbers appropriately * providers/mbox/camel-mbox-folder.c (mbox_append_message): Fix to previous change: make sure the "seek" variable ends up with the value it should. * providers/mbox/camel-mbox-summary.c (summary_rebuild): Update summary mtime as well as size. 2000-06-14 Dan Winship * providers/mbox/camel-mbox-folder.c (mbox_append_message): if the mbox doesn't end with a '\n', write one before appending the new message. 2000-06-14 Jeffrey Stedfast * camel-mime-filter-crlf.c (filter): Updated the encoder to allocate more memory (since we are also now adding dots). Also updated the decoder as we have found that it sometimes passes the end of the buffer. * providers/pop3/camel-pop3-folder.c (get_message_by_uid): Took out the filter code (we already filter in camel_pop3_command_get_additional_data) * camel-folder.c (init): Updated: a separator is now a char* rather than a single char because IMAP can have a string for a directory separator. Also, since IMAP does not begin with a directory separator, there is a new argument (path_begins_with_sep) which decides if a directory should begin with a directory separator. * providers/imap/camel-imap-store.c (imap_create): Since, on connect, Camel tries to create INBOX (which already exists on every IMAP provider) we can return TRUE when the folder name is "INBOX". * providers/vee/camel-vee-folder.c (vee_init): Updated. * providers/imap/camel-imap-folder.c (camel_imap_folder_new): Updated. * providers/mbox/camel-mbox-store.c (get_folder): Updated. * providers/mbox/camel-mbox-folder.c (mbox_init): Updated. * providers/pop3/camel-pop3-folder.c (camel_pop3_folder_new): Updated. 2000-06-14 Dan Winship * providers/mbox/camel-mbox-summary.c (camel_mbox_summary_sync): Renamed from camel_mbox_summary_expunge. Takes a gboolean saying whether to expunge or just sync the mbox file. Change some g_errors to g_warning so we don't abort. Make the quick X-Evolution updating code lseek around correctly. Update the mbox mtime in the summary file even in the quick case. * providers/mbox/camel-mbox-summary.h: make CAMEL_MESSAGE_FOLDER_NOXEV not conflict with CAMEL_MESSAGE_FOLDER_FLAGGED defined in camel-mime-message.h * providers/mbox/camel-mbox-folder.c (mbox_close): call camel_mbox_summary_sync to save flag state if not expunging. (mbox_expunge): Update for camel_mbox_summary_expunge rename. 2000-06-13 Jeffrey Stedfast * providers/imap/camel-imap-store.c (camel_imap_store_open): (camel_imap_store_close): Added. (camel_imap_command_extended): Fixed a segfault and updated to use camel_imap_status() (camel_imap_command): Updated to use camel_imap_status() (camel_imap_status): New convenience function for parsing the return status of an IMAP command 2000-06-12 Jeffrey Stedfast * providers/imap/camel-imap-folder.c (imap_get_message_by_uid): Works like the POP fetch code, should work temporarily until we get around to coding it the way it "Should Be". * providers/pop3/camel-pop3-folder.c (get_message_by_uid): Now uses the camel-mime-filter-crlf decoder when retrieving messages. * camel-mime-filter-smtp.c: Deprecated. * providers/smtp/camel-smtp-transport.c (smtp_data): Updated to use camel-mime-filter-crlf with my 'dot' extension in place of camel-mime-filter-smtp * camel-mime-part.c (write_to_stream): Updated to reflect changes made to camel-mime-filter-crlf.c * camel-mime-filter-crlf.c (filter): Modified to be able to encode/decode dots ("\n.\n"<->"\n..\n"). Also fixed the decoder so that it should no longer get caught in an infinite loop. 2000-06-12 Dan Winship * providers/*/Makefile.am: don't pass a second (incorrect) -rpath in addition to the (correct) one automatically provided by automake. * camel-mime-filter-crlf.c: New filter to do CRLF<->LF conversion. (Currently only tested in the LF->CRLF direction.) * camel-mime-part.c (write_to_stream): if content-type is text, and it's QP or B64 encoded, pass through the CRLF filter before the other filter to satisfy the "canonical encoding" rules in the MIME spec. 2000-06-09 Dan Winship * camel-session.c (camel_session_query_authenticator): Add another argument, "mode", which can be CAMEL_AUTHENTICATOR_ASK or CAMEL_AUTHENTICATOR_TELL, so callers can get the app to un-cache bad info. * providers/pop3/camel-pop3-store.c (pop3_connect): uncache the password if it doesn't work. 2000-06-09 Jeffrey Stedfast * providers/imap/camel-imap-stream.c (stream_read): Updated to reflect changes made in camel-imap-store.c * providers/imap/camel-imap-store.c (imap_create): No longer checks to make sure a folder doesn't already exists (as this is no longer needed) (camel_imap_command): Now takes a CamelFolder argument so it can detect whether or not it needs to SELECT a folder or not (camel_imap_command_extended): Same. * providers/smtp/camel-smtp-transport.c (smtp_connect): Will now always send EHLO first, if that fails it will fall back on HELO. (esmtp_get_authtypes): Should now correctly parse authtypes. 2000-06-07 Jeffrey Stedfast * providers/imap/camel-imap-summary.c: Now builds (not that it's worth much yet). * providers/imap/camel-imap-folder.c (imap_get_uids): Now uses the correct cast to a CamelImapMessageInfo structure (should get rid of compile warnings). * providers/imap/Makefile.am: Added rules to build camel-imap-stream * providers/imap/camel-imap-store.c (get_folder): Update. Moved imap_create here. * providers/imap/camel-imap-folder.c (delete_messages): Remove. (imap_create): Removed. (imap_delete): Removed. (imap_exists): Removed. * providers/imap/camel-imap-stream.h: Added typedef's for the stream * providers/imap/camel-imap-stream.c: Modified to build cleanly 2000-06-07 Not Zed * camel-mime-utils.c (header_msgid_decode_internal): Properly dereference warning/debug messages. (header_references_decode): Check we actually have msgid stuff before trying to decode it ... 2000-06-06 Jeffrey Stedfast * camel-imap-stream.[c,h]: Removed * providers/imap/camel-imap-stream.[c,h]: Relocated to this location * providers/imap/camel-imap-summary.c: Added 2000-06-06 Dan Winship * camel-folder.c: Remove exists, create, delete. A CamelFolder now always references an existing folder. Remove delete_messages too since it wasn't being used. Add a "create" flag to get_subfolder saying whether or not to create the subfolder if it doesn't yet exist. * camel-store.c (camel_store_get_folder): Add a "create" flag to say whether or not to create the folder if it doesn't yet exist. (camel_store_delete_folder): New method, moved from CamelFolder. (cache_folder, uncache_folder): Fix up a bit. (get_folder_name): Explain what this is for. * providers/mbox/camel-mbox-folder.c: * providers/mbox/camel-mbox-store.c: Update. Remove support for hierarchical folders to simplify this for now, since we're not using it, and it's not completely clear how they should work in an ELocalStorage world. Needs to be revisited. * providers/pop3/camel-pop3-folder.c (delete_messages): Remove. * providers/pop3/camel-pop3-store.c (get_folder): Update. * providers/vee/camel-vee-folder.c (exists): Remove. * providers/vee/camel-vee-store.c (vee_get_folder): Update. 2000-06-06 Jeffrey Stedfast * providers/imap/camel-imap-*.[c,h]: Started on getting imap to build cleanly (tho some work has not been completed so it still won't build until camel-imap-summary is finished along with a few methods in camel-imap-folder) * camel-stream.[c,h]: Changed the read and write method prototypes to return an ssize_t type rather than an int and also changed the 'number of bytes' to read or write to a size_t type * camel-stream-fs.c: same as above * camel-stream-mem.c: again, same as above * camel-stream-buffer.c: same * camel-imap-stream.[c,h]: Added this new stream, cache's previously read data so each successive call will instead read from the cache 2000-06-05 Dan Winship * camel-mime-part.c (camel_mime_part_set_disposition): fix typo/braino (set "Content-Disposition", not "Content-Description") (camel_mime_part_set_filename): const poison 2000-06-02 Not Zed * camel-mime-utils.c (base64_encode_step): Ick, damn signs! Fix a bug with sign extended bytes. * camel-mime-filter-smtp.c (filter): Changed layout/logic slightly (to match From filter) 2000-06-02 Jeffrey Stedfast * camel-mime-filter-smtp.c (filter): Fixed the filter so that it wouldn't insert garbage under certain conditions. 2000-06-02 Christopher James Lahey * camel-session.c: Don't ref the services in the cache. 2000-06-02 Jeffrey Stedfast * providers/smtp/camel-smtp-transport.c: Rearanged where debug fprintf statements we placed so that any data the server sends back is printed out before an exception is set and the function returns. 2000-06-02 Not Zed * camel-mime-utils.c (header_decode_date): If we get a funny result, just throw it out. Basically a fix for the one true broken TradeClient. 2000-06-01 Not Zed * camel-folder-summary.c (message_info_free): Free references/messsage id. (message_info_save): Save them. (message_info_load): Load them. (message_info_new): And get them from the new message. (CAMEL_FOLDER_SUMMARY_VERSION): Bumped for new changes. * camel-folder-summary.h: Added references and messageid to summary. 2000-06-02 Christopher James Lahey * camel-session.c: Ref and unref objects in the service cache properly. * camel-store.c: Ref the folder when returning it using lookup_folder. Used the folder's full name for the key for the folder cache since that's used to uncache it. 2000-06-02 Dan Winship Fun with purify. * providers/pop3/camel-pop3-store.c (pop3_connect): free msg on success as well as failure. (camel_pop3_command_get_additional_data): free buf after reading the last line ("."). * providers/pop3/camel-pop3-folder.c (get_message_by_uid): free body data after creating the memstream from it (which will copy the data). * providers/mbox/camel-mbox-folder.c (mbox_finalize): free summary and index paths. * camel-data-wrapper.c (finalize): unref the stream, if it exists. 2000-06-01 Not Zed * camel-mime-part.c (construct_from_parser): For a message part, set the default content-type to message/rfc822. Maybe needs to be done for multiparts too? 2000-05-31 Not Zed * camel-mime-message.c (construct_from_parser): Typo in assersion. * camel-mime-parser.c (folder_scan_step): Use a default type of message/rfc822 for multipart/digest. Bug Z192. (folder_scan_drop_step): Remove warning. 2000-05-30 Not Zed * providers/mbox/camel-mbox-folder.c (mbox_append_message): Init filter_from to NULL, for exception case. (mbox_get_message_by_uid): Cast off_t to long int for diagnostics. * camel-url.c (camel_url_hash): Hash funciton for using camel url's as hash keys. (camel_url_equal): equal function for same. * camel-session.c (camel_session_finalise): Free cached services. (camel_session_init): Init service cache. (service_cache_remove): destroy callback to remove a service from the cache. * camel-store.c (get_folder_internal): Remove the extra ref of the folder. That seems the right behaviour ...? (camel_store_get_type): Doh, actually call store init, so the cache works. (cache_folder): strdup the folder name! no wonder it never found it again. 2000-05-30 Jeffrey Stedfast * providers/imap/camel-imap-folder.c: Implemented a few more methods like imap_append and 1 or 2 others 2000-05-29 Not Zed * camel-store.c (camel_store_init): Move it to here. If this level is going to maintain it, it should set it up. Lets see what caching folders breaks :( * providers/pop3/camel-pop3-store.c (camel_pop3_store_init): Dont init folder cache here. * providers/mbox/camel-mbox-summary.c (camel_mbox_summary_expunge): Make sure we copy messages which are still intact to the new folder. (camel_mbox_summary_expunge): Update the frompos as well when moving the content. (camel_mbox_summary_expunge): Remove some debug, and dont offset frompos? * providers/vee/camel-vee-folder.c (vee_folder_build): Check the searched folder is open before trying to search it. (message_changed): Track changes to the source message in the summary. (folder_changed): Track folder changes, re-query the folder that changed, and cascade the changed event as well. (camel_vee_folder_finalise): Free subfolder and subfolder summary. 2000-05-29 Dan Winship * camel-service.c (camel_service_new): Fix up some glib precondition stuff. Try to set the URL in camel_service_new before checking whether or not it's "empty" so that you can successfully set "sendmail:" as a URL. 2000-05-28 Dan Winship * camel-provider.h: Add a domain field to CamelProvider, to say what kind of data it provides. * providers/imap/camel-imap-provider.c: * providers/mbox/camel-mbox-provider.c: * providers/pop3/camel-pop3-provider.c: * providers/sendmail/camel-sendmail-provider.c: * providers/smtp/camel-smtp-provider.c: Set domain to "mail". * providers/nntp/camel-nntp-provider.c: Set domain to "news". * providers/vee/camel-vee-provider.c: Set domain to "vfolder". (So it doesn't end up being listed as a potential mail source in the mail config wizard.) * providers/pop3/camel-pop3-store.c: Split apart password and APOP auth, since some servers seem to do both, but don't really. (connect_to_server): Renamed from try_connect. Now actually does the connection up to the point of checking the greeting for APOP support. (query_auth_types): Return APOP, if appropriate. Call pop3_disconnect after connect_to_server since we don't really want to be connected. (pop3_connect): Use connect_to_server rather than duplicating code. Fix a one-byte buffer overrun in the APOP code. (pop3_disconnect): Make this able to clean up after a partial connect. (connect_to_server): Remove port number from error message since it's not terribly useful and we were getting it from the wrong place anyway. * camel-mime-utils.c (header_address_list_format_append): Use `foo@bar' rather than `"" ' for email addresses with no name component. 2000-05-27 Jeffrey Stedfast * providers/imap/camel-imap-store.c: Removed camel_imap_command_get_additional_data() as it was completely useless, replaced with camel_imap_command_extended() which may eventually replace camel_imap_command() as well. * providers/imap/camel-imap-store.h: Modified to reflect changes made to camel-imap-store.c * providers/imap/camel-imap-folder.c: Wrote the first of many methods: camel_imap_init(), imap_open(), imap_expunge(), imap_get_message_count(), and imap_get_subfolder_names() 2000-05-26 Dan Winship * camel-multipart.c (camel_multipart_init): Don't set a default boundary. Require the caller to do that. (set_boundary): if boundary is NULL, generate a "random" boundary. * camel-mime-part-utils.c (camel_mime_part_construct_content_from_parser): Add a call to camel_multipart_set_boundary after creating a new multipart. 2000-05-25 Jeffrey Stedfast * providers/imap/camel-imap-store.c (try_connect): Removed Exception code - Pop doesn't seem to set exceptions * providers/imap/camel-imap-folder.c: Initial code, mostly just a template for future code * providers/imap/imap.[c,h]: Source code from my personal mailer - for reference only! 2000-05-25 NotZed * camel-mime-part-utils.c (camel_mime_part_construct_content_from_parser): Replace simple data wrapper here too, oops. * Makefile.am (libcamel_la_SOURCES): Removed camel-simple-data-wrapper again. Less code to maintain == better code. * camel-data-wrapper.c (construct_from_stream): Fixes for bug where text attachments dont work. Made data-wrapper concrete for the second time. 2000-05-23 NotZed * providers/vee/camel-vee-folder.c (vee_folder_build_folder): Update the vfolder details for a single folder. 2000-05-25 Jeffrey Stedfast * providers/smtp/camel-smtp-transport.c (_send_to): Took out code that had been there to reconnect to the server if it was not already connected - Mailer code was fixed so that this should not be needed. * providers/imap/camel-imap-store.[c,h]: Initial code. 2000-05-24 Dan Winship * camel.h: Re-add camel-simple-data-wrapper.h, which was removed for some reason. 2000-05-24 Jeffrey Stedfast * providers/smtp/camel-smtp-transport.[c,h]: Moved global variables into struct CamelSmtpTransport to make SMTP thread-safe * providers/imap/camel-imap-*.h: Stolen from Mbox. Rough structure for Imap. 2000-05-23 Jeffrey Stedfast * providers/imap: Added some initial code to the camel tree for IMAPv4 * providers/imap/.cvsignore: Added to repository * providers/smtp/camel-smtp-transport.c: Added debug fprintf's so that testers can provide more information. Tested with simple messages and a reply to the hello@helixcode.com default message but should really be tested more. (smtp_data): Fixed to use data_wrapper_write_to_stream. * camel-mime-filter-smtp.c (filter): Modified to escape all lines beginning with a '.' and to place a \r before each \n if one did not previously exist. Removed code to escape "From " as it was found to not be needed for SMTP. 2000-05-22 Jeffrey Stedfast * providers/smtp/camel-smtp-transport.c (smtp_data): Fixed the filtered stream. Fixes for stream changes, updated to use camel-mime-filter-smtp. * Makefile.am: Added camel-mime-filter-smtp.c * camel-mime-filter-smtp.[c,h]: Added to camel tree Smtp filter used to change \n into \r\n, escape lone dots, and escape "From "'s. 2000-05-19 NotZed * camel-simple-data-wrapper.c (construct_from_stream): If we already have been constructed, unref our content. (write_to_stream): Check we've been constructued, and change for stream api changes. * camel-mime-parser.c: Removed exception stuff. * md5-utils.c (md5_get_digest_from_stream): repaired. * camel-mime-message.c: Remove exception from write_to_stream, and fix, and fix formatting. * providers/sendmail/camel-sendmail-transport.c (_send_internal): Fix for stream changes. * providers/pop3/camel-pop3-store.c (camel_pop3_command): Fixes for stream changes. * providers/mbox/camel-mbox-folder.c, and elsewhere, fix all stream api changes. (mbox_append_message): Use stream_close() now its back. (mbox_append_message): unref the from filter. * camel-stream-mem.c: And here. * camel-stream-fs.[ch]: Here too. * camel-stream-filter.c: Likewise. This is getting tedious. * camel-stream-buffer.c (stream_write): Fix a few little problems. (stream_close): Reimplement. (camel_stream_buffer_read_line): Slightly more efficient version, that also only allocates the right amount of memory for strings. * camel-seekable-substream.c: Likewise. * camel-seekable-stream.[ch]: Remove exceptions, fix formatting, changes for stream (re)fixes. set_bounds returns an error. * camel-stream.[ch]: Remove exceptions. Make flush and reset return an error code, repair all the screwed up formatting, and put back close. * camel-mime-part-utils.c (camel_mime_part_construct_content_from_parser): And here. * camel-mime-part.c (camel_mime_part_set_content): And this too. (write_to_stream): Fixed for stream changes. * camel.h: Fixed. * providers/vee/camel-vee-folder.c (vee_search_by_expression): Implement. Performs an intersection of the two searches. (camel_vee_folder_finalise): Unref search folders. (vee_append_message): Implement append. 2000-05-18 Dan Winship * camel-folder.c: remove message_number_capability and require uid capatibility. (camel_folder_list_subfolders, camel_folder_get_uid_list, camel_folder_get_subfolder_info, camel_folder_get_message_info): removed (camel_folder_get_subfolder_names, camel_folder_free_subfolder_names): new subfolder interfaces. (camel_folder_get_uids, camel_folder_free_uids): new uid interfaces (camel_folder_get_summary, camel_folder_free_summary): new summary interfaces * providers/mbox/camel-mbox-folder.c, * providers/nntp/camel-nntp-folder.c: * providers/vee/camel-vee-folder.c: Update for changes * providers/pop3/camel-pop3-folder.c: Implement get_uids, update for other changes. 2000-05-18 NotZed * providers/vee/camel-vee-folder.c: Guess! * camel-folder-search.c (search_user_flag): Implement user_flag search term. * camel-folder-search.h: Added user_flag search capability (user-flag "blah") * providers/mbox/camel-mbox-folder.c (mbox_init): Set USER flag in permanent flags for the folder. 2000-05-17 Dan Winship * camel-folder.c: Remove unused async open/close and copy_message_to functions. Rename functions without initial _. Fix glib preconditions and gtk-doc comments. 2000-05-17 Dan Winship * camel-data-wrapper.c: remove get/set_output_stream operations. They're redundant with write_to_stream, and CamelMimePart and CamelMimeMessage only implement the latter, meaning that trying to get_output_stream on a CamelMimeMessage that was built from pieces rather than being parsed from a stream doesn't work. Anything that uses get_output_stream can be rewritten to use write_to_stream, so we'll standardize on that. (camel_data_wrapper_new): remove this: CamelDataWrapper is supposed to be an abstract class. (write_to_stream): remove default implementation. (Moved to CamelSimpleDataWrapper) * camel-simple-data-wrapper.c: resurrect, although it's not really the same thing it was before. A simple data wrapper, which is backed by a CamelStream. * camel-mime-part-utils.c (simple_data_wrapper_construct_from_parser): Use construct_from_stream rather than set_output_stream. (camel_mime_part_construct_content_from_parser): Change camel_data_wrapper_new to camel_simple_data_wrapper_new. * camel-mime-part.c (camel_mime_part_set_content): Change camel_data_wrapper_new to camel_simple_data_wrapper_new. 2000-05-17 Darin Adler * camel-folder-summary.c: (message_info_load): Quick fix to get it to compile. I hope I don't get into trouble. 2000-05-17 Dan Winship * camel.h: Don't include the no-longer-distributed possibly-to-be-removed headers. * providers/smtp/camel-smtp-transport.c (smtp_get_email_addr_from_text): fix an off-by-one error in address parsing (smtp_data): use camel_data_wrapper_get_output_stream rather than data_wrapper->output_stream 2000-05-17 NotZed * providers/mbox/camel-mbox-folder.c (message_changed): Snoop changes to user flags on the message into the summary as well. * providers/mbox/camel-mbox-summary.c (camel_mbox_summary_init): Changed version init to include the parent class version info (i.e. add it not overwrite it). * camel-folder-summary.c (message_info_new): Initialise user_flags to empty. (message_info_load): And load user flags. (message_info_save): And save user flags. (message_info_free): And free them. (CAMEL_FOLDER_SUMMARY_VERSION): Bumped file revision. * camel-folder-summary.h: Added user-flags to summary. * camel-mime-message.c (camel_mime_message_set_user_flag): Dont use a hashtable for user flags. (camel_mime_message_get_user_flag): And changed here too. (camel_flag_get): New interface to get a flag from a flag list. Flag lists are easier to work with than hash tables, and save memory too. (camel_flag_set): And set. (camel_flag_list_free): And free. (free_key_only): Discard. (finalize): Remove the flag list. 2000-05-17 Jeffrey Stedfast * providers/smtp/camel-smtp-transport.c: (smtp_helo): Error checking on gethostbyaddr() eliminating a possible segfault. 2000-05-16 NotZed * providers/mbox/camel-mbox-folder.c (mbox_delete_message_by_uid): Implement. 2000-05-12 NotZed * camel-movemail.c (camel_movemail): Open the destination with O_APPEND, so we dont blow away a partially transferred mbox. (camel_movemail): Loop if we get errno=INTR, and not fail. 2000-05-11 NotZed * providers/mbox/camel-mbox-summary.c (summary_rebuild): Update the summarised file size, if everything went ok. (camel_mbox_summary_expunge): Clear header flags after updating. 2000-05-16 Chris Toshok * providers/nntp/camel-nntp-folder.c: * providers/nntp/camel-nntp-folder.h: * providers/nntp/camel-nntp-provider.c: * providers/nntp/camel-nntp-store.c: * providers/nntp/camel-nntp-utils.c: * providers/nntp/camel-nntp-utils.h: get things working with new camel summary stuff. * providers/nntp/camel-nntp-summary.c: * providers/nntp/camel-nntp-summary.h: removed files since camel-folder-summary does all we need. 2000-05-15 Jeffrey Stedfast * providers/smtp/camel-smtp-transport.c: Added some preliminary AUTH support. 2000-05-15 Dan Winship * camel-folder.h: Remove camel_folder_get_summary, which no longer exists. 2000-05-11 Dan Winship * Makefile.am: remove some cruft that we're not currently using. * camel-stream-mem.c (camel_stream_mem_new_with_buffer): Change to match prototype (size_t vs unsigned int) so it works on 64-bit machines. Noted by msw. 2000-05-11 NotZed * providers/mbox/camel-mbox-folder.c (message_changed): Indicate the summary changed also. 2000-05-11 Jeffrey Stedfast * providers/smtp/camel-smtp-transport.c: (smtp_helo): Updated to more closely comply with RFC 821 standards 2000-05-11 NotZed * camel-mime-part.c (write_to_stream): Unref the filter after adding it to the filtering stream. * providers/mbox/camel-mbox-summary.c (camel_mbox_summary_finalise): Free the folder path. (camel_mbox_summary_update): Also save summary when done. (camel_mbox_summary_expunge): Unindex items when deleting them. (camel_mbox_summary_expunge): Save the index as well as the summary. * camel-folder-summary.c (camel_folder_summary_finalise): Free the summary path. (camel_folder_summary_touch): New function, indicate the summary info changed. (camel_folder_summary_remove): Dirty here. * camel-internet-address.c (internet_decode): Free multiple entry addresses properly. * camel-mime-utils.c (header_decode_mailbox): Plugged another memleak, free text after converting it. (header_decode_addrspec): More leaks plugged. * camel-mime-message.c (finalize): Free message_uid. (finalize): Free the recipients hashtable. 2000-05-11 * camel-folder-summary.c (camel_folder_summary_finalise): Free summary items and charset filters. 2000-05-10 * camel-folder-summary.c (camel_folder_summary_finalise): Don't free stuff in p, after we've free'd p. * providers/mbox/camel-mbox-folder.c (mbox_append_message): Unref the stream we created for appending. 2000-05-10 Jeffrey Stedfast * providers/smtp/camel-smtp-transport.c: (camel_smtp_transport_class_init): Added initialization for service_class 2000-05-10 Dan Winship * camel-multipart.c (write_to_stream): fix a stupid typo. Thank you, C. * camel-mime-part.c (write_to_stream): don't ref the stream before wrapper a filter around it, since nothing will ever unref it. 2000-05-10 Christopher James Lahey * Makefile.am: Added camel-types.h, camel-folder-pt-proxy.h, and camel-thread-proxy.h. 2000-05-09 Dan Winship * providers/sendmail/camel-sendmail-transport.c (_send_internal): Bleah. Can't fsync a pipe. As a quick kludge, just don't stream_flush it. The right fix will require bringing back stream_close though. 2000-05-09 Jeffrey Stedfast * camel-internet-address.[c,h]: Undid my changes (moved struct _address back into came-internet-address.c) * providers/smtp/camel-smtp-transport.c: (_send): changed from using it's own address manipulation (using struct _address) to using camel_internet_address_get(). Also some format changes to keep consistant with the rest of Camel 2000-05-09 Jeffrey Stedfast * camel-internet-address.[c,h]: Moved struct _address from camel-internet-address.c to camel-internet-address.h (hopefully this doesn't break anything...) * providers/smtp/camel-smtp-transport.c: (_send): now populates the recipient list with To, Cc, and Bcc addresses. Should now be able to use this module. 2000-05-09 Dan Winship * providers/mbox/camel-mbox-folder.c (mbox_get_message_by_uid): one more refcounting fix I missed before. 2000-05-08 Jeffrey Stedfast * providers/smtp/camel-smtp-transport.c: no longer frees memory it shouldn't, updated to reflect camel-stream changes involving CamelException (perhaps it should use a different CamelException variable than is passed to the camel smtp module?) 2000-05-08 Dan Winship * camel-stream.c (camel_stream_read, camel_stream_write, camel_stream_flush, camel_stream_reset, camel_stream_printf, camel_stream_write_to_stream): Use CamelException to signal failure. (camel_stream_write_strings): Remove. camel_stream_printf is more useful in most of the places that used this. (camel_stream_write_string): Change from macro to function to prevent problems with double-evaluation. * camel-seekable-stream.c (camel_seekable_stream_seek, camel_seekable_stream_set_bounds): Use CamelException. (reset): Update. * camel-seekable-substream.c, camel-stream-buffer.c, camel-stream-filter.c, camel-stream-fs.c, camel-stream-mem.c: Update. * camel-stream-fs.c: Remove the virtual init functions and move the code into the creator functions. Add CamelExceptions to creation functions that could fail. * camel-data-wrapper.c (camel_data_wrapper_write_to_stream): Use CamelException. * camel-mime-message.c, camel-mime-part.c, camel-multipart.c (write_to_stream): Update. * camel-mime-parser.c: add an exception to the mime parser private data and pass that to stream functions as needed. * gmime-content-field.c, md5-utils.c: Update (badly) for stream changes. * camel-exception.h (camel_exception_is_set): convenience macro. * providers/Makefile.am: disable SMTP for now * providers/mbox/camel-mbox-folder.c (mbox_append_message): Pass CamelException to the functions that now need it. Check the exception after calling camel_stream_flush, and fail if it fails. (mbox_get_message_by_uid): More updates. * providers/pop/camel-pop3-folder.c, providers/pop/camel-pop3-store.c, providers/sendmail/camel-sendmail/transport.c: Update. 2000-05-08 NotZed * camel-mime-message.c (process_header): Format From and Reply-To to at least a decoded string. Should probably store them as an camelinternetaddress. * Merged NEW_SUMMARY branch back to trunk, and resolved conflicts. * providers/mbox/camel-mbox-summary.c (camel_mbox_summary_update): Return status. (camel_mbox_summary_expunge): Force an update of the summary before we do anything. (camel_mbox_summary_expunge): Build new xev line in xevnew, and free that, and consify xev. (camel_mbox_summary_load): If we are rebuilding from scratch, make sure we clear the summary content. * camel-stream-filter.c (do_close): We NEED a stream close. 2000-05-07 Dan Winship Make camel not leak like a sieve. * camel-object.c: New subclass of GtkObject which is now the base of the Camel object hierarchy. Currently the only difference between CamelObject and GtkObject is that CamelObjects don't start out floating. * *.h: Move a bunch of typedefs to camel-types.h. Standardize on using in header files rather than , "foo.h", or "camel/foo.h". Remove some unneeded includes. * camel-address.c, camel-data-wrapper.c, camel-folder-search.c, camel-folder-summary.c, camel-folder.c, camel-mime-filter.c, camel-mime-parser.c, camel-service.c, camel-session.c, camel-stream.c: These are now subclasses of CamelObject. * camel-data-wrapper.c (set_output_stream): * camel-medium.c (set_content_object): * camel-seekable-substream.c (init_with_seekable_stream_and_bounds): * providers/mbox/camel-mbox-folder.c (mbox_get_message_by_uid): remove gtk_object_sink calls. * camel-stream-buffer.c (init_vbuf): * camel-stream-filter.c (camel_stream_filter_new_with_stream): ref the original stream. * camel-folder-summary.c (camel_folder_summary_finalise): unref the filters when finalizing. * camel-mime-part-utils.c (simple_data_wrapper_construct_from_parser, camel_mime_part_construct_content_from_parser): * camel-mime-part.c (camel_mime_part_set_content): Unref objects that are created only to be handed off to other objects. If they're going to be needed later, they will have been additionally ref'ed by the object that needs them. * providers/pop3/camel-pop3-folder.c (get_message_by_number): unref the message stream after creating the data from it. * camel-stream.c, camel-stream-buffer.c, camel-stream-filter.c, camel-stream-fs.c, camel-stream-mem.c: Remove camel_stream_close, since its semantics are dubious (what happens when you close a stream other people still have references on?). * providers/nntp/camel-nntp-store.c: * providers/smtp/camel-smtp-transport.c: * providers/pop3/camel-pop3-store.c: replace camel_stream_close calls with gtk_object_unref. * providers/mbox/camel-mbox-folder.c: * providers/nntp/camel-nntp-folder.c: * providers/sendmail/camel-sendmail-transport.c: replace camel_stream_close with camel_stream_flush + gtk_object_unref 2000-05-06 Dan Winship * providers/pop3/camel-pop3-store.c (query_auth_types): A machine which serves neither POP nor KPOP is not a POP server. * providers/smtp/camel-smtp-provider.c: Note in the description that this provider is not yet tested. 2000-05-08 * camel-mime-part.c (write_to_stream): Free the filter stream when done. * camel-mime-parser.c (folder_seek): Make sure we add the \n terminal when we seek as well (frob!). * camel-mime-utils.c (header_decode_addrspec): Plug minor memleak. * camel-mime-part.c (finalize): Free header tables once finished. * camel-folder-summary.c (camel_folder_summary_remove): Dont try to access info after its free'd. 2000-05-07 NotZed * camel-mime-part.c (write_to_stream): Apply encoding to content part, when writing to a stream *sigh*. * camel-stream-filter.c (do_write): implement write for the filtering stream. Writes shouldn't be mixed with reads. (do_flush): Implemented flush. Again write/flush shouldn't be mixed with reads. Only flushes if the last op was write. (do_close): Force flush on close. * camel-mime-filter.c (filter_run): Oops, make sure we include the backlen in the total length before passing onto the filter. * camel-mime-filter-from.c: New filter, munges 'From ' lines into '>From ', for mbox. * camel-mime-parser.c (camel_mime_parser_header_remove): New function to remove the parser's raw header, rather than manipulating the header directly (wich doesn't work with mempools). * camel-mime-utils.c (header_address_list_clear): Fixed some broken(tm) logic, which would leak entries on multivalued lists. * providers/mbox/camel-mbox-summary.c (camel_mbox_summary_load): Use ibex_save() to save the ibex. Makes a big difference to startup times for very large mailboxes. (camel_mbox_summary_expunge): Dum de dum, reimplemented. Designed to be much more robust, and to stop immediately if anything awry happens. (copy_block): Utility function to copy n bytes from one fd to another. (header_write): Utility function to write out raw headers to an fd. (camel_mbox_summary_update): Incremental summary updater. * providers/mbox/camel-mbox-folder.c (mbox_get_message_by_uid): Dont unref the stream, because of the broken(tm) ref model of gtk widget that for some odd reason is being perpetuated in camel. (mbox_expunge): Reenable expunge again. (mbox_append_message): Removed the optimised mbox append. If its an issue, it can go back later. Cleaned up a lot, checks error returns, and automagically translates 'From ' into '>From' as necessary. 2000-05-07 * camel-mime-filter.c (filter_run): Oops, forgot to add the backlen to the pre-buffer (*poof*). 2000-05-07 NotZed * camel-mime-message.c (construct_from_parser): Allow HSCAN_FROM_END to terminate the processing of a message. * camel-folder-summary.c (perform_content_info_load): Ick, dont try and append a node onto its own list. (camel_folder_summary_clear): Actually clear the indexes after we've removed the messages. (camel_folder_summary_clear): Set dirty if it changes. (camel_folder_summary_load): Clear dirty. (camel_folder_summary_save): Only save if dirty. * providers/mbox/camel-mbox-summary.c (summary_header_load): Oops, remember to call that parent class first ... (summary_header_save): Here too. (camel_mbox_summary_load): Do more checking to verify the index contents as well as teh summary contents, against the mbox contents. (camel_mbox_summary_load): Removed some fo that checking, it needs more code to work reliably. 2000-05-07 * providers/mbox/camel-mbox-summary.c (camel_mbox_summary_load): Set the size and mtime of the mbox we indexed once done. * camel-folder-summary.c (camel_folder_summary_set_index): Dont write the index if it changes - let the claler fix it (uh, kind of impacts performance). (camel_folder_summary_load): close in. * camel-folder-summary.c (summary_format_string): Check header exists before trying to strip its leading spaces. 2000-05-06 NotZed * camel-folder.h: Removed summary info from here, and include camel-folder-summary.h as well. * camel-mime-parser.c (camel_mime_parser_step): Allow it to accept a NULL databuffer. * providers/mbox/camel-mbox-summary.c: Totally new file, now subclasses camel-folder-summary. * camel-folder-summary.c (message_info_load): Load the uid as a string. (message_info_save): And save too. (camel_folder_summary_clear): New function, clears the contents of the summary. * providers/mbox/camel-mbox-folder.c: Fixes for summary changes. (mbox_get_message_by_uid): Completely redone. Now cross-checks the summary information to make sure we get a real message. (mbox_append_message): Disabled the copy version of append for now. (mbox_expunge): Temporarily disabled the expunge function, until it is put back in camel-mbox-summary.c 2000-05-05 NotZed * camel-folder-summary.c: And same here ... (camel_folder_summary_encode_fixed_int32): Ugh, fwrite doesn't return -1 on error .. (camel_folder_summary_decode_fixed_int32): Neither deos fread. (camel_folder_summary_encode_token): Fix here too. (summary_build_content_info): Use start-headers to get the pos of the message, not parser_tell(), which might not be what we expected because of parser_unstep(). (camel_folder_summary_encode_token): Use bserch() to tokenise the values, rather than a linear search. * camel-mime-utils.c: Defined out some memory profiling stuff I left there by mistake. (header_decode_mailbox): Dont try to append the word part of a local address if we ran out of words. * camel-mime-parser.c (folder_scan_content): Apply the fix from the header scanner to here too. (folder_scan_header): Only check for end of header if we have space for it (didn't end the read with a newline) (folder_scan_header): inptr is the only real thing we need registerised for performance. Try to help the compiler be smart about it .. (folder_scan_header): Simplified the save header case a tad. Commented out some memory profiling stuff. 2000-05-05 * camel-mime-utils.c (header_decode_mailbox): Plug a memory leak. (header_decode_text): Fixed memory leaks with g_string_append(). (header_encode_string): And here too, and a few other places. The glib api is so awful ... (header_content_type_decode): More memory leaks. 2000-05-05 * camel-mime-parser.c (folder_scan_init_with_fd): Make sure we init the end of buffer sentinal! (folder_scan_init_with_stream): And here too ... 2000-05-04 NotZed * providers/mbox/camel-mbox-folder.c (summary_get_message_info): Maxcount is minimum of the max and the requested count, not the maximum :) * camel-mime-parser.c (folder_scan_content): Properly set midline, so we dont falsely catch offset boundary markers (i.e. From inside content). (folder_read): Set a sentinal on the end of the read data (\n) so we dont have to check the buffer boundary in the inner loop. (mempool_*): New experimental memory management routines, speed up simple structure parsing by about 25% ... not compiled in by default. Something similar may be needed for camel-mime-utils to address performance issues with g_malloc and friends. * camel-mime-utils.c: Added a macro w(x) used to wrap all warnings about mime/rfc violations, so they can be turned off. * camel-folder-summary.c (summary_build_content_info): Step after the end of a message ... Turn into a stand-alone program for testing and profiling. 2000-05-04 Dan Winship * providers/pop3/camel-pop3-store.c (pop3_connect): Don't fall back to plaintext passwords if APOP fails, since it should also fail. 2000-05-04 Dan Winship * camel-session.c (camel_session_list_providers): New function to replace camel_provider_scan. Returns a list of either (a) all currently-loaded providers, or (b) all available providers. * camel-url.[ch]: Add an "empty" flag to CamelURL (indicating that it contains only a protocol). * camel-service.c (camel_service_query_auth_types): Make this take a CamelException (since it may have to try to connect to the server, and it might not able to.) * providers/pop3/camel-pop3-store.c: add KPOP (Kerberized POP) support. This is mostly so I have two kinds of authmech to play with instead of just one. (But it does actually work.) * providers/smtp/camel-smtp-transport.c (query_auth_types): update for prototype change, but disable the functionality, since it doesn't really support any auth types yet. (camel_smtp_transport_get_type): add an object init function to set the service url_flags. 2000-05-04 NotZed * providers/mbox/camel-mbox-summary.c: Yes, and anotherone. * camel-mime-utils.c: And another one. * camel-mime-part.c: And another one. * camel-mime-part-utils.c: And another one. * camel-folder-search.c: And another one. * camel-mime-parser.c: Reverted a change wihtout a ChangeLog entry. 2000-05-04 NotZed * camel-folder-summary.[hc]: Yes, CamelFolderSummary is back ... ... re-usable class to summarise and index any stream or message and to manage/load/save the created summaries. * camel-folder.c: Include string.h to kill a warning. 2000-05-03 Jason Leach * Makefile.am (INCLUDES): add $(UNICODE_CFLAGS) to the INCLUDES, people who installed libunicde in non-standard include paths need this. 2000-05-03 NotZed * camel-folder.h: Added pos/bodypos/endpos to the basic message content info object. Size to be removed? Moved the messageconentinfo and messageinfo back to camel-folder-summary.h. * camel-mime-filter-index.c (camel_mime_filter_index_set_ibex): New function to (re)set the index to use on a filter. * camel-mime-parser.c (camel_mime_parser_scan_from): Whole bunch of inline docs. (camel_mime_parser_drop_step): New function to drop a state from the parser. Needs more testing. * camel-mime-utils.c (rfc2047_decode_word): If the iconv handle is -1, then dont try and convert (crashes unicode_iconv?). (rfc2047_decode_word): Use alloca for variables instead of g_malloc - by the rfc they should always be short. (rfc2047_decode_word): If we can't do the charset conversion, undo the quoted-printable/base64 at least? Should probably convert unknown characters to the utf-8 unknown character. 2000-05-02 Larry Ewing * camel-mime-utils.c (header_decode_date): fix typo when dereferencing saveoffset. 2000-05-02 NotZed * camel-folder-search.c: Added some header doco. * camel.h: REmove gmime-utils.h from here. * providers/mbox/camel-mbox-search.[ch]: Removed. Functionally redundant. * providers/mbox/camel-mbox-folder.c (mbox_search_by_expression): Use the new CamelFolderSearch class to do the actual searching, just setup the search here. * camel-folder-search.[ch]: A helper class that providers may subclass to provide their own search functionality, or they can simply use as is, it supports body searches if an ibex is supplied, and header searches if a summary is supplied. 2000-05-02 Matt Loper * Makefile.am: set G_LOG_DOMAIN. * providers/MH/Makefile.am: same. * providers/maildir/Makefile.am: same. * providers/mbox/Makefile.am: same. * providers/nntp/Makefile.am: same. * providers/pop3/Makefile.am: same. * providers/sendmail/Makefile.am: same. * providers/smtp/Makefile.am: same. 2000-05-02 NotZed * providers/mbox/camel-mbox-search.c (camel_mbox_folder_search_by_expression): Dont store/remove current search from the search list. * providers/mbox/camel-mbox-folder.h: Removed searches list, searches are all sync now. * gmime-utils.[ch]: What the hell, remove it. This will break the nntp provider. The mime parser can be used instead though. Removed from all code including it (but none were using it). * gmime-utils.c (_store_header_pair_from_string): Removed bizarre string_dichotomy version of this. This code is somewhat redundant now, and is headed for death anyway. * gstring-util.c (g_string_dichotomy): Same with this one. (g_string_clone): Removed a memory leak, g_string_new() allocates its own memory. (g_string_append_g_string): Allow to append an empty gstring onto another gstring, dont abort()! * string-utils.c (string_dichotomy): Removed this incredibly weird function. * camel-folder.c (_create): Replaced the rather obtuse use of "string_dichotomy" function with a simple strrchr(). Still not sure it'll work. * camel-folder-summary.c: cvs removed a long-removed file. * camel-mime-parser.c (folder_scan_header): Fix the previous overflow problem properly (can happen in 2 places). (header_append): A new macro to include the code changed above, so it only appears in one place. (folder_scan_step): Change the content type to text/plain if the multipart is broken. Doesn't actually change the header though. (header_append): Also move the header-start tracking stuff here. Could be a static function to save code. 2000-05-02 * camel-mime-part-utils.c (simple_data_wrapper_construct_from_parser): Dont use autofill on these fucking long function anmes!!!!!! 2000-05-02 NotZed * providers/mbox/camel-mbox-summary.c (camel_mbox_summary_expunge): Fix the offset for the summary when an item is expunged to take account of the From line. 2000-05-01 NotZed * providers/mbox/camel-mbox-folder.h (CamelMboxFolder): Removed search_id. * providers/mbox/camel-mbox-search.c (camel_mbox_folder_search_cancel): Remove.d (camel_mbox_folder_search_complete): Removed. (camel_mbox_folder_search_by_expression): Changed back to sync api. (struct _searchcontext): Removed cancelled flag. (find_context): Removed. (func_header_contains): Debug out some search stuff. * providers/mbox/camel-mbox-search.h (camel_mbox_folder_search_by_expression): Moved back to sync api. * providers/mbox/camel-mbox-summary.c (camel_mbox_summary_set_flags_by_uid): New function to update the flags in the summary. (camel_mbox_summary_expunge): Expunge messages from a folder. (offset_content): Re-align offsets of summary when messages added/removed to an existing summary. (camel_mbox_summary_remove_uid): Remove a message summary entry by uid. (index_folder): Restore flags from X-Evolution header, if they are set. (index_folder): Make sure we index using a decimal uid, since thats what everything else indexes off (oops). Upped SUMMARY_VERSION as a result. (camel_mbox_summary_expunge): Oops, my wrong, use the string uid to unindex on. * providers/mbox/camel-mbox-folder.c (_get_message_by_uid): Connect to the message_changed signal. (_init): Set permanent flags to something reasonable. No user flags yet ... (message_changed): If the flags of the message change, update the flags in the summary. (mbox_expunge): Implement the expunge. (camel_mbox_folder_class_init): Renamed all leading _'s to mbox_'s (mbox_expunge): Emit a folder_changed signal on expunge (uh, even if it didn't ...) * camel-folder.c (_finalize): Uh, dont free permanent_flags anymore (this wouldn't failed anyway, it was a GList !!!) (camel_folder_search_complete): Removed. (camel_folder_search_cancel): Removed. (camel_folder_expunge): Changed to only allow expunge on an open folder. It doesn't make sense for mbox, otherwise (?) (camel_folder_class_init): Added a folder_changed signal. * camel-folder.h (struct _CamelFolder): Change permanent_flags to a bitfield. (list_permanent_flags): Renamed to get_permanent_flags, and returns a bitfield. (camel_folder_expunge): Changed expunge to a void type. The messages would no longer be useful after they have been removed ... (CamelFolderClass): New function summary_get_by_uid() to get a single summary. (*search*): Moved back to synchronous search api ... *sigh* * camel-folder.h: Removed CamelSearchFunc. * camel-mime-message.c (set_flag): Removed. (camel_mime_message_set_flag): Removed. (get_flag): Removed. (camel_mime_message_get_flag): Removed. (add_flag_to_list): Removed. (get_flag_list): Removed. (camel_mime_message_get_flag_list): Removed. (camel_mime_message_get_flags): New interface to get system flags. (camel_mime_message_set_flags): " to set ". (camel_mime_message_get_user_flag): To get a user flag. (camel_mime_message_set_user_flag): To set a user flag. (finalize): Hmm, the old one free'd the key and data, not good when the data is a boolean ... 2000-04-30 Dan Winship * camel-provider.h: Tweak the definition of CamelProvider. Among other things, a provider may now be both a store and a transport. * camel-provider.c: Remove a lot of code we had no intention of using. This now only contains two functions: camel_provider_init to read the installed .urls files, and camel_provider_load to load and register a new provider. * camel-session.c: Remove more unused code and simplify some of the remaining code. The list of available provider modules is now stored in the session, and it handles calling camel_provider_load to load them as needed. Provider registration is now done by calling back from the module init routine, which allows a single module to register providers for multiple URL types. * providers/*: Update provider structures and init routines for the new stuff. Add a .urls file to each provider specifying what urls it handles, and install that with the library. * providers/nntp/camel-nntp-provider.c: Add hints towards supporting both news: and nntp: URLs, and using nntp as both a store and a transport. 2000-04-29 Dan Winship * camel-internet-address.c (camel_internet_address_get): const poison * camel-mime-part-utils.c (simple_data_wrapper_construct_from_parser): camel_mime_parser_tell() returns an offset from where it started parsing, not necessarily from the start of data. Since we're parsing a bounded seekable_stream, we need to add the stream's starting bound to camel_mime_parser_tell's return value to create the substream in the right place. * camel-seekable-substream.c (camel_seekable_substream_new_with_seekable_stream_and_bounds): say CAMEL_STREAM_UNBOUND rather than -1 in doc. * camel-seekable-stream.c (camel_seekable_stream_seek): Add more info to docs. 2000-04-28 Dan Winship * camel-mime-parser.c (folder_scan_header): fix a bug that would cause corruption with very long headers. 2000-04-27 Ettore Perazzoli * providers/pop3/Makefile.am (INCLUDES): Add `-I$(srcdir)/../../..' to pick the Camel includes. * providers/sendmail/Makefile.am (INCLUDES): Likewise. * camel.h: Don't #include anymore. 2000-04-27 NotZed * camel-mime-utils.c (check_header): Dont try and check a NULL header. * camel-recipient.[ch]: Dead. Its not pining. * camel-mime-message.h: Dont include recipients.h anymore. * camel-mime-message.c (camel_mime_message_add_recipient): Accept name/address separately, and store in an CamelInternetAddress. (add_recipient): Removed. (remove_recipient): Removed. (remove_recipient_address): Renamed from remove_receipient, works via address. (camel_mime_message_remove_recipient_name): New function to remove by name. (get_recipients): Removed. (camel_mime_message_get_recipients): Return a camel-internet-address. (write_to_stream): No longer write receipients directly. (write_recipients_to_stream): Removed. (write_one_recipient_to_stream): Removed. (camel_mime_message_init): Setup recipients hashtable, rather than usign the recipients stuff. (set_recipient_list_from_string): Killed, a violent and lengthy death. (process_header): Simplified recipient handling code a lot. (received_date_str, sent_date_str, reply_to_str, subject_str, from_str): Removed some oddly-defined global statics. (camel_mime_message_class_init): Dont initialise above variables anymore. (init_header_name_table): Removed, use a table to init this, and do it in class init (2 lines of code ...). * camel-news-address.c: Class to represent news addresses - currently empty, and not built. * camel-internet-address.h: Class to represent internet (email) addresses. * camel-address.h: Abstract class to represent (lists of) addresses. 2000-04-27 Dan Winship * camel-mime-part.c (write_to_stream): Revert previous change. I was confused. * camel-url.[ch] (camel_url_encode, camel_url_decode): expose these routines. 2000-04-26 Dan Winship * camel-mime-part.c (write_to_stream): Only write a newline between the headers and the content object if the content object is not a CamelMedium. (If the content is a medium, it may have its own headers, which then need to go before the blank line.) * camel-mime-body-part.[ch]: Remove. We weren't using the fields that made this different from camel-mime-part, so it basically just forced us to do lots of gratuitous typecasting. * camel-multipart.[ch]: Use CamelMimePart. Remove the multipart parent stuff, since we weren't using that either. * etc: update for CamelMimeBodyPart -> CamelMimePart 2000-04-26 Dan Winship * camel-medium.c (set_content_object): sink the content object after referencing it. * camel-mime-part.c: fix various little things in the handling of CamelMedium methods. Change camel_mime_part_set_text to the more generic camel_mime_part_set_content. * camel.h: sync to current reality * camel-folder-utils.[ch]: removed * camel-mime-utils.c (header_format_date): fix format specifier for time zone. Fix typo in month names array. 2000-04-26 NotZed * camel-seekable-substream.c (stream_seek): Changed to have absolute seek semantics, not relative to the bounds. * camel-seekable-stream.c (reset): When we reset, seek to the start of the bound, if there is one. (stream_tell): Make tell virtual. * camel-stream-filter.c (do_available): Removed. * camel-stream-buffer.c: Remove leading _'s from static functions. (stream_read): Renamed from read(). Fancy that conflicting! (my boo!) Others too. * providers/pop3/camel-pop3-folder.c (get_message_by_number): Changed to stream_mem interface. * providers/mbox/camel-mbox-folder.c (_get_message_by_uid): Fixed for streamfs interface changes, and implement a failure case. (_append_message): Changed for fs stream interface change. * camel-multipart.c (print_part): Iterate rahter than callback. I hate glists's interface (hence, move this to write_to_stream). (write_to_stream): Return an error (yuck, this is a royal PITA to do with the stream write interface). * camel-mime-message.c: Removed leading _ from static names. * camel-mime-part.h: construct_from_parser() now returns an error code. * camel-mime-part-utils.c (camel_mime_part_construct_content_from_parser): Changed to use a camel-data-wrapper instead of a camel-simple-data-wrapper (no change needed elsewhere?). (simple_data_wrapper_construct_from_parser): Fixes for stream-mem interface changes. * camel-simple-data-wrapper.[ch], camel-simple-data-wrapper-stream.[ch], camel-stream-data-wrapper.[ch], removed. Fixed including of these files. * camel-mime-part.c (camel_mime_part_set_text): Remove the use of the camel-simple-data-wrapper-stream, just use a mem stream. (write_to_stream): Renamed from my_* (construct_from_stream): Return an error on error. * camel-stream-mem.c (camel_stream_mem_new*): Remove mode parameter. * camel-stream-mem.h (enum CamelStreamMemMode): Removed. It wasn't used at all. * camel-data-wrapper.h: Add camel_data_wrapper_new() to create these. (write_to_stream, construct_from_stream): Return an error indicator for success. Fixed all methods to match (ICK). * Makefile.am (libcamel_la_SOURCES): Remove camel-simple-data-wrapper.c, camel-simple-data-wrapper-stream.c, camel-stream-data-wrapper.c. Obsoleted by code re-use! * camel-data-wrapper.c (construct_from_stream): Change the default implementation to just set the output stream == construction stream. Well, this lets me get rid of both simple-data-wrapper and stream-data-wrapper (unused anyway), and simple-data-wrapper-stream in one hit. CamelDataWrapper is now also a concrete class. (write_to_stream): Use camel_stream_write_to_stream() to calculate/return values (and save code). Include for obvious reasons. * camel-stream.c (eos): Provide a default implementation of .eos(). (camel_stream_write_to_stream): Make it return an error code on error. (camel_stream_printf): Changed to return the number of bytes written/error. (camel_stream_available): Removed. * camel-stream-fs.h (enum CamelStreamFsMode): Removed. Changed to use unix modes and so forth (wasn't used for anything but new file creation and didn't work well either). * camel-stream-fs.c: Removed leading _'s for names. And removed some virtual method 'documentation'. (destroy): Dont try and close a closed/error fd. Only report error if close returns -1. Moved all the code to finalise(), and killed this function. (init_with_fd): Properly setup the seek offset, if it is a valid and seekable file descriptor. (init_with_fd_and_bounds): Use off_t for bounds, set bounds on the seekable stream. (init_with_name): Return error codes. (init_with_name_and_bounds): Ditto. (camel_stream_fs_new_with_name): REturn NULL object if it failed. (camel_stream_fs_new_with_name_and_bounds): Return NULL object on failure. Changed with_name* api's to take unix open style args and flags. (read): The bounded stream bounds checking seemed off, simplified code a bit. (write): Implement bounds checking for writing, the comment was wrong, it could make sense to bound writing. Cleaned up a little. (available): Gone. (eos): Removed. Use CamelStream's implementation now. (close): Reset the fd to -1, provide a warning for bad usage. (seek): Cleaned up. Changed the behaviour a little, the returned offset is the absolute position in the file, even in bounded streams. (seek): Seek from end mirrors lseek() behaviour (reverse seeking). 2000-04-25 NotZed * camel-stream-fs.h (struct _CamelStreamFs): Moved bounds and eof indicator to other parent classes. * camel-stream.c (camel_stream_printf): New utility function. Obvious use. * camel-stream-mem.c: Removed leading _'s from static func's. (camel_stream_mem_new_with_byte_array): Fixed for api changes, set the owner for the byte array to us. : Removed A bunch of gtk doc stuff for static (implementation) functions. (available): Removed. (write): Fixed the write implementation so that seek() works on a seekable memory stream, as expected. Seeking past the end of the buffer has unix semantics (filling with 0). (available): Removed. (write): Implement seekable stream bounded stream. (read): Implement seekable stream bounded stream. (close): Dont free the stream_mem if we're not the owner. (seek): Allow to seek beyond the end of memory area, implement bounds checking. (seek): Set errno on bad policy. * camel-stream-mem.h (struct _CamelStreamMem): Changed position to off_t. (new_with_buffer): Changed len to be a size_t. (set_buffer, set_byte_array): New interface functions. (struct _CamelStreamMem): Removed position, it is stored in the superclass. * camel-stream.h: Removed some of the seemingly random whitespace. Removed the available method (its not impelemented/useful enough). * camel-seekable-substream.c (init_with_seekable_stream_and_bounds): Remove the data_available stuff, it hasn't been properly implemented/finished, and may never work (unfortunately *sigh). (reemit_parent_signal): Removed part of the above change. (set_bounds): Removed (moved to seekable-stream). : Fixed up some of the generally unreadable indenting (sorry, wrapping at 80 characters with camels_really_long_function_names() just_doesnt_work_very_well_does_it(). (available): Removed. (stream_seek): Fixup for object changes. Make sure we return -1 if the parent stream can't seek. * camel-seekable-stream.c (ccamel_seekable_stream_set_bounds): New function to bound any seekable stream. : Removed _'s. (camel_seekable_stream_class_init): Implement an init function, to setup the stream bounds to unbound. * camel-seekable-stream.h (CamelSeekableStreamClass): New virtual method set_bounds for seekable streams. (CAMEL_STREAM_UNBOUND): New define for no bound. * camel-seekable-substream.h (struct _CamelSeekableSubstream): Removed sup_bound and inf_bound, moved to CamelSeekableStream (and renamed, and changed to off_t's). (new_with_seekable_stream_and_bounds): Use off_t as the bounds. (CamelSeekableSubstreamClass): Uh, why was the intialiser virtual? Removed. * camel-seekable-stream.[ch] (CamelSeekableStreamClass): Changed seek to accept an off_t as the offset. (struct _CamelSeekableStream): Renamed cur_pos to position and changed it to an off_t type. (enum CamelStreamSeekPolicy): Set to match the SEEK_* constants from lseek(). (get_current_position): Renamed to tell(). * camel-stream-buffer.h: Commented out set_vbuf - never implemented. 2000-04-25 Dan Winship * camel-stream-buffer.c (_eos): only return TRUE if the parent is at eos AND the buffer has been exhausted * camel-mime-message.c: fix some incorrect macro usage that resulted in bogus casts 2000-04-24 Dan Winship * camel-mime-part-utils.c (simple_data_wrapper_construct_from_parser): fix a cut-and-pasto. * providers/mbox/camel-mbox-folder.c (_get_message_by_uid): ref (and sink) the message stream if we're going to unref it later. Otherwise it could get destroyed while there are still substreams attached to it. This needs a cleaner solution. * camel.h: remove data-wrapper-repository.h include(s) 2000-04-24 NotZed * camel-mime-message.c (construct_from_parser): Allow MESSAGE_END _or_ EOF as valid termination conditions. * providers/mbox/camel-mbox-summary.c (message_struct_new): Decode and then re-encode the addresses, so they are consistently formatted. * camel-mime-utils.c (header_decode_mailbox): Store the address in a _header_address. And try to get a comment-stored name if there is one. (header_decode_address): Actually return an address. (header_to_decode): Renamed to header_address_decode() (header_mailbox_decode): New function to get a single mailbox. (header_mime_decode): Return the major/minor value, as appropriate. (header_address_new, and friends): Whole bunch of utility functions for working with the address thingies. (header_decode_domain): Free the string header, and dont expand '.' into ' . '. * camel.c (camel_init): No longer call data_wrapper_repository_init. * camel-medium.c (write_to_stream): Moved (back) to camel-mime-part. (add_header): (set_header): (remove_header): (get_header): Make all these abstract, and spit warnings if called. I guess it could manage the list, but well, it doesn't. * camel-medium.h (struct _CamelMedium): Dont store headers here, the implementor is the only one who knows their format. (CamelMediumClass): Changed header values to be void *'s. They need not be strings? * camel-simple-data-wrapper.c (construct_from_stream): And we're back. Set the output stream. (construct_from_parser): Moved to camel-mime-part-utils. * camel-mime-part-utils.c (camel_mime_part_construct_content_from_parser): Create the contents of multipart and simple messages. (camel_mime_part_construct_content_from_parser): Oops, this was totally screwed up, try creating the right cotnent on the right object. * camel-multipart.c (construct_from_parser): Moved to camel-mime-part-utils. (separate_part): Removed. * camel-mime-part.c (construct_from_stream): Back again! This now switches over to using a mime parser for any mime parts, only. (my_write_to_stream): Write our headers and so forth here. (add_header): Add header directly, parent class is abstract. (remove_header): Ditto. (set_header): Ditto. * camel-data-wrapper.c (camel_data_wrapper_construct_from_stream): Remade abstract. (camel_data_wrapper_construct_from_parser): Moved to camel_mime_part. * camel-data-wrapper.h: Put back construct_from_stream. * camel-mime-part.h: Put construct_from_parser in here, the data-wrapper shouldn't know about mime. Ok, so now to undo half of the last hours changes ... duh. 2000-04-23 Dan Winship * camel-mime-utils.c (header_to_decode, header_mime_decode): fix some obvious minor bugs noted by -Wall. 2000-04-23 NotZed * providers/pop3/camel-pop3-folder.c (get_message_by_number): Use construct_from_stream instead of set_input_stream(). * camel-simple-data-wrapper-stream.c (camel_simple_data_wrapper_stream_construct): REmoved the destroy callback code. (wrapper_destroy_cb): Removed. * camel-simple-data-wrapper.h: Add prototype for _construct() method. * camel.c: Include unicode.h to kill a warning. * camel-data-wrapper.h (CameldataWrapperClass): Removed construct_from_stream virtual method. Removed get/set input stream. * data-wrapper-repository.[ch]: Removed&from build. Obsoleted? The justification as is follows: It is mixing storage protocol/format with message architecture. It really just doesn't serve any purpose, as each medium implementor will have to have its own type->handler mapping, and the only current implementor, mimepart has a very simple structure and no need for this. * camel-medium.c (write_to_stream): Moved here from most of the stuff in camel-mime-part. Well, the MEDIUM is the one that knows what the headers are, and the content is, let it write it out. * camel-mime-part-utils.c (camel_mime_part_construct_content): Copied from camel-mime-part.c, removed handling of message followon state (moved to camel-mime-message). (camel_mime_part_construct_content_from_parser): Renamed from construct_content. (camel_mime_part_construct_headers_from_stream): (camel_mime_part_construct_content_from_stream): (camel_mime_part_store_stream_in_buffer): Removed. Replaced by the new construct from parser stuff. * camel-mime-message.c (construct_from_parser): Do construct_from_parser for mime-message. (_write_to_stream): Set the mime-version header for medium to write out, rather than writing it out ourselves. * camel-data-wrapper.c (set_mime_type_field): Ref the content_field when we get it? (construct_from_stream): Removed. (camel_data_wrapper_construct_from_stream): Changed to a helper function, creates a mime_parser, and constructs from that. (set_input_stream): Removed. (camel_data_wrapper_set_input_stream): Removed. (get_input_stream): Removed. (camel_data_wrapper_get_input_stream): Removed. * camel-mime-parser.c (camel_mime_parser_unstep): New function. Cause a subsequent call to mime_parser_step() to return the same state over again. * providers/mbox/camel-mbox-folder.c (_get_message_by_uid): Initial test code using the mime parser to construct the message. (_get_message_by_uid): Use construct_from_stream() instead of creating our own parser. * camel-mime-part.c (construct_from_parser): part constructor. (camel_mime_part_construct_content): Basically a simpler replacement for the datawrapper repository. (camel_mime_part_init): Set the default type to text/plain. (camel_mime_part_construct_content): Removed to camel-mime-part-utils.c (my_get_output_stream): Removed. The streeam is in the data-wrapper. (my_get_content_object): Removed. The content object is stored in the medium. If none is there, the object wasn't created properly. (my_write_content_to_stream): Removed. The content object is the one that knows how to write itself out!!!!!!!! (my_write_to_stream): Remove the base header writing stuff - has been moved to camel-medium, where it belongs. This can just be used to check for mandatory headers. (my_construct_from_stream): Removed. (my_set_input_stream): What the hell, i'll remove this too. Nobody seems to understand how it differs from create from stream, and they both seem to serve the same purpose ... * camel-simple-data-wrapper.c (construct_from_parser): Initial implementation of a content constructor. (construct_from_stream): Removed! Job taken over by construct_from_parser. * camel-multipart.c (construct_from_parser): Multipart construction routine. (camel_multipart_init): Set the default multipart type to multipart/mixed. Duh, no subtype is not allowed anyway. (set_input_stream): REmoved. Replaced by construct_from_parser. 2000-04-22 Dan Winship * camel-multipart.[ch]: clean, document, etc. (camel_multipart_init): pick a prettier default boundary. Still need to deal with the larger problem 2000-04-22 NotZed * camel-mime-message.h (struct _CamelMimeMessage): Removed send_date, and received_date, and replaced it with a time_t 'date' (this is what the header is called), and date_offset to store the GMT offset of the date. * camel-mime-message.c (camel_mime_message_set_from): Update raw header as we go. (_set_from): Removed. (_get_from): Removed. (camel_mime_message_get_from): Moved implementation here. (camel_mime_message_get_subject): Move implementation here. (_get_subject): Nuked. (camel_mime_message_set_subject): Handle utf-8 input, and also update raw header when changed. (_set_subject): Removed. (_set_received_date): Removed. (camel_mime_message_set_received_date): Removed. (_get_received_date): Removed. (camel_mime_message_get_received_date): Removed. (_get_sent_date): Removed. (camel_mime_message_get_sent_date): Removed. (camel_mime_message_get_date): New function to get the date as a time_t/offset. (camel_mime_message_set_date): Set the date as a time_t/offset. (camel_mime_message_get_date_string): Get the date as a string. (camel_mime_message_init): Initialise the current date as 'CMAEL_MESSAGE_DATE_CURRENT'. (_set_reply_to): Removed. (camel_mime_message_set_reply_to): Moved implementation here. This is still broken, reply-to can have multiple addresses. (_get_reply_to): Removed. (_set_field): Removed, no longer used anywhere. (_get_field): Also removed. (_init_header_name_table): Add the Date header. (process_header): Also handle snooping of Date header here. * camel-stream-filter.c (finalise): Unref the source stream on finalise, and also call the parent class (oops). * camel-mime-parser.c (camel_mime_parser_state): New function to get the current parser state. (camel_mime_parser_stream): Allow you to get the stream back from the mime_parser. (camel_mime_parser_fd): Alternative to allow you to get the fd back from the mime_parser. (folder_scan_init_with_stream): Properly ref/unref the stream. (folder_scan_close): Properly unref the stream/close the fd on exit. (folder_scan_init_with_fd): Close the old fd if there is one. * camel-data-wrapper.c (camel_data_wrapper_construct_from_parser): New method, construct a data wrapper from an initialised parser. (construct_from_parser): Empty implementation. * providers/mbox/camel-mbox-summary.c (message_struct_new): Convert subject line to unicode, before storing in the summary. (strdup_trim): Removed, no longer needed. * providers/mbox/camel-mbox-folder.c (_get_message_by_uid): Ref the folder after setting it in the new message. * camel-mime-part.c (my_set_content_object): Have the headers follow the content-type change here too. (my_write_to_stream): Dont write content-type here, automatically stored in the headers ... (my_write_to_stream): Use header_disposition_format() to format the content-disposition header. (my_write_to_stream): Removed old code, all headers are now stored in the camel-medium level, always. Need to do the same with camel-mime-message i suppose ... (my_write_to_stream): Write the content using the parent class, not some weird function. (camel_mime_part_class_init): Dont override get_output_stream. (camel_mime_part_encoding_from_string): Bleh, make it case-insensitive. * camel-mime-utils.c (header_content_type_is): Handle empty types. (header_encode_string): Start of an implementation of the rfc2047 encoder. It does iso-8859-1, and us-ascii, and utf-8 (others get tricky *sigh*) (rfc2047_encode_word): Convert a single word/string into rfc2047 encoding. (quoted_encode): Different quoted-printable encoding for rfc2047 encoding of headers. * gmime-content-field.c (gmime_content_field_write_to_stream): Use header_content_type_format() to format it. 2000-04-21 NotZed * camel-mime-utils.h: Add prototype for header_param_list_free. * camel-recipient.c: New function to remove all the types of a recipient list. I think this whole object needs a major review. * camel-mime-message.c (camel_mime_message_class_init): Removed parse_header_pair override, override add_header instead. (_parse_header_pair): Renamed to add_header. (remove_header): Add this method, to make sure we keep upto date with removed headers too. (_set_field): If given a NULL value, clear it out. (_set_recipient_list_from_string): Constify. (set_header): Override set_header from camel_medium. (process_header): Local function to handle set/add/remove of each header we know about. * camel-mime-part.c (camel_mime_part_class_init): Removed parse_header_pair setup. (my_parse_header_pair): Moved into add_header(), removed. (my_set_disposition): Allow a NULL disposition to clear it. (my_set_content_id): Allow NULL content id to clear it. (remove_header): Track removed headers. (my_set_description): Allow NULL description to clear it. (my_set_content_MD5): Make sure we copy the md5 value, and allow a NULL value to reset it. (my_set_filename): Copy the filename. (my_set_header_lines): Removed. Nothing uses it, it doesn't actually serve any purpose. (camel_mime_part_set_header_lines): Ditto. (my_get_header_lines): Ditto. (camel_mime_part_get_header_lines): Ditto. (camel_mime_part_class_init): Remove *_header_lines setup. (camel_mime_part_init): Remove header_lines init. (my_finalize): Remove header_lines finalise. (my_write_to_stream): Write the headers here. This is just WRONG, camel_medium should be doing this. (my_get_output_stream): Kill a warning. (camel_mime_part_encoding_to_string): Ditto. (camel_mime_part_set_description): Unvirtualiase, use add_header() to do the processing. (my_set_description): Removed. (set_disposition): Renamed from my_set_disposition. (camel_mime_part_get_description): Get the descriptionf rom the get_header method. (my_get_description): Removed. (my_set_filename): Removed. (camel_mime_part_get_filename): Get the parameter from the disposition. (camel_mime_part_encoding_from_string): Handle NULL string. (camel_mime_part_init): Remove reference to filename. (my_finalize): Dont free filename. * camel-mime-part.h (CamelMimePartClass): Removed parse_header_pair() method, it doesn't add anything that add_header() can't be used for. (CamelMimePartClass): Remove *_header_lines methods. (struct _CamelMimePart): Remove header_lines list. (struct _CamelMimePart): Removed filename attribute. * camel-medium.c (camel_medium_init): Init headers to null, not a hashtable. (add_header): Append the headers as a list. (remove_header): Remove headers as a list. (get_header): Likewise for lookup. (free_header): Removed, no longer needed. (finalize): Free headers using header_raw_clear(). (camel_medium_set_header): New function, to reset and override all values of a header with a new value. * camel-medium.h (struct _CamelMedium): Changed to use a header_raw struct rather than a hash table, to store headers (many headers can occur multiple times). * camel-mime-utils.c (header_raw_find_next): New function, allows you to find multi-valued header fields. (header_disposition_format): New function to format/create content-disposition header string. (header_param_list_format_append): Function to format parameter lists into a GString. (header_content_type_format): Function to format content-type into a usable format. (header_set_param): allow NULL value to remove the parameter. (decode_token): Renamed from header_decode_token. (header_decode_token): New interface for external use. (quoted_decode): Made static to kill annoying warnings. (g_strdup_len): Killed, replaced with calls to g_strndup(). (rfc2047_decode_word): Made static to kill warnings. (decode_coded_string): Terminated. (g_string_append_len): Made static to kill warnings. (header_decode_text): Made static to kill warnings. (header_decode_text): Constify. (rfc2047_decode_word): Constify. (header_param): Constify. (header_content_type_new): Copy the type/subtype strings. (header_param_list_decode): Made static. (header_param_list_format_append): Made static. (quoted_decode): Constify. (g_string_append_len): Constify. (header_token_decode): New function to decode a single token. * providers/mbox/camel-mbox-summary.c (header_write): Append a trailing \n when writing headers. (strdup_trim): Killed a warning. (camel_mbox_summary_set_uid): Make sure the next uid is at least 1 higher than any existing one. (header_evolution_decode): Use header_token_decode to get the token. * camel-mime-parser.c (folder_scan_header): Strip the trailing \n of the end of all header lines. 2000-04-20 NotZed * providers/mbox/camel-mbox-utils.[ch]: Removed. * providers/mbox/camel-mbox-parser.[ch]: Removed. Removed references to it. 2000-04-20 Dan Winship * camel-mime-utils.c (rfc2047_decode_word): use libunicode iconv functions rather than libc ones (since libc might not have them). (header_decode_date): add autoconfiscation on timezone code * camel.c (camel_init): call unicode_init () 2000-04-20 NotZed * providers/mbox/camel-mbox-summary.c (message_struct_new): Trim leading/trailing spaces off the raw headers. * MERGE NEW_PARSER branch into HEAD, fixed conflicts. * gmime-content-field.c (_print_parameter): Duh, removed again (@@#$@ cvs merge). * camel-mime-utils.c (header_content_type_is): Constify. (header_content_type_unref): Killed a couple warnings. * camel-folder.c (_init): Removed more log crap. * providers/Makefile.am (SUBDIRS): Removed nntp, pending fixes for summary changes. * providers/mbox/camel-mbox-folder.c (_get_message_by_number): Fixed for new summary interface. Added a warning for using this broken api. (_get_message_by_uid): Fixed for message new with session vanishing. 2000-04-19 Dan Winship * camel-simple-data-wrapper-stream.c (camel_simple_data_wrapper_stream_get_type): This is a subtype of CamelSeekableStream, not CamelStream. * camel-seekable-substream.c: clean up a lot. (eos): When testing for end-of-stream, reset the parent position before testing if it is at end-of-stream, since either (a) it may have been seek'ed to eos by someone else, or (b) we may have been seek'ed away from eos and it hasn't been synced yet. * camel-medium.[ch] (camel_medium_add_header): const poison. (Belatedly goes with my change of 2000-02-23.) (camel_medium_init): Use g_strcase_{hash,equal} on the header array. 2000-04-18 Dan Winship * camel-mime-part.c (my_set_input_stream): * camel-data-wrapper.c (set_input_stream, set_output_stream): do better reference counting of streams so they actually go away when they should. * camel-log.[ch], *: Nuke camel log stuff. Replace calls to CAMEL_LOG_WARNING with calls to g_warning. * camel-data-wrapper.[ch]: * camel-simple-data-wrapper.[ch]: * camel-medium.[ch]: Clean, polish, document. Most of the gtk-doc comments added to camel-data-wrapper.c note serious problems that need to be fixed. 2000-04-17 Dan Winship * camel-mime-message.[ch]: Remove the "session" field from CamelMimeMessage. Nothing uses it, about half of the existing calls to camel_mime_message_new_with_session pass NULL, and there's no obvious reason for it to be there. * providers/MH/camel-mh-folder.c: * providers/maildir/camel-maildir-folder.c: * providers/mbox/camel-mbox-folder.c: * providers/mbox/camel-mbox-utils.c: * providers/nntp/camel-nntp-folder.c: * providers/pop3/camel-pop3-folder.c: Use camel_mime_message_new instead of camel_mime_message_new_with_session. * camel-session.c (get_store_for_protocol_with_url): Set the exception if no provider is found. * camel-url.c: Add code to encode and decode %-escapes in URLs, and do some additional correctness-checking on URL syntax. From Tiago Antào with modifications by me. 2000-04-14 Chris Toshok * providers/Makefile.am (SUBDIRS): add nntp 2000-04-14 Christopher James Lahey * providers/mbox/camel-mbox-folder.c: Fix switch statement. 2000-04-14 Chris Toshok * providers/nntp/camel-nntp-folder.c (_exists): always return TRUE for now. we need to check the server response to make sure the group exists. (_get_message_by_uid): make sure to account for the \n we add to the string after every line. * providers/nntp/camel-nntp-utils.c (get_XOVER_headers): function to get the headers using the XOVER command. (get_HEAD_headers): function to get the headers using the HEAD command on each message. slooooooow. (camel_nntp_get_headers): make this function use either XOVER or HEAD versions depending on whether or not the server extension is present. 2000-04-14 Dan Winship * camel-formatter.[ch]: This didn't belong in Camel. Move to mail/ * Makefile.am, camel-types.h: remove references to camel-formatter. 2000-04-12 Matt Loper * camel-folder-pt-proxy.c (_folder_open_cb): Print warning message for broken function. (_folder_close_cb): Same. 2000-04-12 Miguel de Icaza * Makefile.am (pthread_SRC): Use correct names for the pthread source variables. 2000-04-10 Dan Winship * providers/pop3/camel-pop3-store.c (pop3_connect): fix various bugs in APOP code (still untested) and some of the error cases. * camel-provider.h: Clarify what provider.protocol, provider.name, and provider.description should be. * providers/mbox/camel-mbox-provider.c: * providers/pop3/camel-pop3-provider.c: * providers/sendmail/camel-sendmail-provider.c: * providers/smtp/camel-smtp-provider.c: update protocols, names, and descriptions * providers/mbox/camel-mbox-folder.c (_get_message_by_number): implement get_message_by_number for the mail fetch code. 2000-04-09 Jeffrey Stedfast * providers/smtp/camel-smtp-transport.c: reformatted to fit the standard indent format used by helix code 2000-04-09 Dan Winship * camel-movemail.c: New file with new function to dot-lock an mbox file and copy it to a safe private directory. 2000-04-08 Christopher James Lahey * providers/smtp/.cvsignore: Added a .cvsignore file. 2000-04-08 Dan Winship * providers/sendmail/camel-sendmail-transport.c (_send_internal): actually record the pid returned by fork(). Noticed by clahey. * providers/smtp/camel-smtp-transport.c: #include for MAXHOSTNAMELEN. (This is a stopgap: some of the uses of MAXHOSTNAMELEN are wrong anyway...) 2000-04-07 Jeffrey Stedfast * providers/smtp/camel-smtp-transport.c: fixes to numerous bugs; should now build fine. * providers/Makefile.am: Readded smtp now that smtp builds without error. 2000-04-20 NotZed * providers/mbox/camel-mbox-summary.c (camel_mbox_summary_next_uid): Public function to get the next uid, makes sure its saved to disk too. * camel-mime-part.c (my_finalize): Fix disposition crap with a real disposition. (my_set_disposition): Likewise. (my_get_disposition): And here. (my_write_to_stream): And here, needs more cleanup. * providers/mbox/camel-mbox-folder.c (_append_message): Assign a new uid at this point. * gmime-content-field.c (gmime_content_field_write_to_stream): Make something up if we have an invalid/missing content type (i.e. text/plain). 2000-04-19 NotZed * providers/mbox/camel-mbox-folder.c (_delete): Fixed completely broken switch() syntax, only compiled because errno is a macro on some systems. (_list_subfolders): Likewise. 2000-04-18 NotZed * camel-mime-parser.c (folder_scan_init): init stream to null. * providers/mbox/camel-mbox-summary.c (CAMEL_MBOX_SUMMARY_VERSION): Moved to .c file, incremented. (index_folder): Changed to have index passed via the summary. (decode_string): Do a sanity check on the string size, so we dont visit g_malloc()'s friendly abort(). * camel-folder-pt-proxy.c (camel_folder_pt_proxy_class_init): Removed reference to set_name. (_set_name): Removed. * providers/mbox/camel-mbox-utils.c (parsed_information_to_mbox_summary): Removed. Most of this file is about to be binned. * providers/mbox/camel-mbox-search.c (func_header_contains): Fixes for changes to summary interface. (struct _searchcontext): Remove pointer to message info, get it straight from the mboxsummary. (camel_mbox_folder_search_by_expression): New summary interface. (camel_mbox_folder_search_by_expression): Uh, the summary is not an object anymore (well not yet). * providers/mbox/camel-mbox-folder.c (camel_mbox_folder_class_init): Removed set_name init. (_set_name): Removed. (_open): Call new summary interface. (_close): Use new summary interface. (_create): Removed a summary object leak. (_get_message_count): New summary interface. (_get_uid_list): Use new summary interface. FIXME: this is leaky. (_get_message_by_uid): Use the new summary interface, some cleanup. (_append_message): Totally changed, basically just appends the message directly, ignores the summary (for now), the summary will fix itself up if it needs to. (_check_get_or_maybe_generate_summary_file): Bye bye old code. (summary_get_message_info): Implement get_message_info again, for folder. * camel-folder.c (camel_folder_class_init): Removed set_name setup. (_set_name): Moved contents into _init. (_init): Perform the old functions of set_name here. * camel-folder.h: Removed the set_name internal interface. 2000-04-14 NotZed * providers/mbox/camel-mbox-summary.[ch]: Completely replaced with new code. * Makefile.am (libcamel_la_SOURCES): Removed camel-folder-summary.[ch]. * camel-folder.h (struct _CamelFolder): Removed summary. (struct _CamelFolder): Changed flags to be 1 bit bitfields. * camel-folder-summary.[ch]: Class removed entirely. * camel-folder.c (camel_folder_get_summary): Removed. (camel_folder_summary_get_message_info): Moved from camel-folder-summary.c (camel_folder_summary_get_subfolder_info): Moved from camel-folder-summary.c * camel-mime-parser.c (folder_scan_step): Store the start of headers and start of from in the scan state. (camel_mime_parser_tell_start_headers): Query the start of the headers. (camel_mime_parser_tell_start_from): Query the cached start of from marker. 2000-04-13 NotZed * gmime-content-field.c (gmime_content_field_free): Removed this function. If its too dangerous to use, it shouldn't be here. (gmime_content_field_ref): Also ref the embedded content-type. (gmime_content_field_unref): Ditto to unref it. * camel-mime-utils.h: Add a refcount for content-type header. * camel-mime-utils.c (header_content_type_unref): Implement unref for content-type. (header_content_type_ref): Implement ref for header content type. 2000-04-12 NotZed * gmime-content-field.h: Changed to use a _header_content_type. Added type/subtype back for compatability with clients. * gmime-content-field.c: Basically a total rewrite, and now just a thin wrapper ontop of header_content_type. (_free_parameter): Got rid of it. (gmime_content_field_new): Use header_content_type_* functions. (gmime_content_field_set_parameter): Likewise. (_print_parameter): Blow away. (gmime_content_field_write_to_stream): Get details from the content_type field. Should check if it needs to escape chars in the paramter value. (gmime_content_field_get_mime_type): Likewise. (___debug_print_parameter): Get rid of this rather annoyingly named function. (gmime_content_field_get_parameter): Simplified function. (gmime_content_field_construct_from_string): Fixed this to use a real parser. (gmime_content_field_is_type): New function to test if a type matches. (gmime_content_field_construct_from_string): Track type/subtype from subordinate content_type header struct. * gmime-rfc2047.[ch]: Removed. Unused. * camel-stream-b64.[ch]: Blown away more duplicated code. * Makefile.am: Removed camel-stream-b64.[ch], and gmime-base64.[ch]. * camel-mime-part.c (my_get_content_object): Replaced camel-stream-b64 with camel-stream-filter/camel-mime-filter-basic. (my_write_content_to_stream): Replaced camel-stream-b64 with the camel-stream-filter with an encoder. (my_get_content_object): Also implement quoted-printable decoding. (my_write_content_to_stream): Also implement quoted-printable encoding. (my_get_output_stream): Took out stream-b64 code (nothing's being executed yet anyway). * gmime-base64.[ch]: Blown away. Not used, dont need it. * camel-mime-utils.h: Added offset for this header. Records where it is in the source. * camel-mime-utils.c (header_raw_append_parse): Add offset parameter, to store where the header is stored in the stream. (header_raw_append): Added offset param. (header_raw_find): Return offset, if a pointer supplied for it. (header_raw_replace): Add offset param. (header_content_type_new): New function, to create an empty content type. (header_content_type_set_param): Set a parameter in the content-type. (header_set_param): Generic header parameter setting function. (header_decode_string): Handle NULL input. * camel-mime-parser.c (camel_mime_parser_headers_raw): New function to get access to all the raw headers. (folder_scan_header): Keep track of the header start position, and store it when saving the header. 2000-04-11 NotZed * camel-mime-utils.c: Moved a bunch of printf's to debug. * camel-mime-parser.c: Moved a bunch of printf's to debug. (folder_scan_header): Detect end of each header line using the last scanned char, and not the last scanned position. * camel-mime-filter-index.[ch]: Indexing filter. Indexes unicode sequences into ibex files. 2000-04-09 NotZed * camel-mime-part.c: Dont include gmime-base64.h * camel-mime-filter-charset.c (complete): Implement the completion function. * camel-mime-parser.c (folder_scan_step): If we get to the end of the body data, check any filters for outstanding completion data. (camel_mime_parser_scan_from): Set whether we scan for "From " headers or not. * camel-stream-filter.c (do_read): If we get to end of stream on the source, then call the filtering completion function to see if we have any more data to return. * camel-mime-filter-basic.c (filter): Implement quoted printable encoding and decoding filters. (complete): And the complete function as well. * camel-mime-utils.c (base64_encode_close): Also take an input buffer, allow closing of filters. (quoted_encode_step): First cut, simple quoted-printable encoder. Doesn't handle trailing spaces/tabs on end of line properly yet. (quoted_encode_close): Complete a quoted-encoding. (is_qpsafe): New type check, for quoted-printable safe characters (that do not need encoding). Thats all bits used in the type table! Rebuilt the types table. (header_content_type_is): Checks a content type against at type/subtype match. (header_content_type_param): Handle NULL content type pointer. 2000-04-08 NotZed * camel-mime-filter-basic.c (filter): Implement the base64 encoder. Problem is, there is no way to know when to close it. Close/Reset will have to provide the same args as filter, so it can flush remaining data *sigh* * camel-mime-utils.c (base64_encode_step): A rather complex base64 encoder, fast? (base64_step_close): Companion function to finish off the base64 sequence. * camel-mime-part.c (my_write_content_to_stream): Changed to use camel_stream_write_to_stream(). * camel-stream.[ch] (camel_stream_write_to_stream): From camel_stream_b64_write_to_stream(). Fixed some infinite loop bugs with error conditions. * camel-stream-b64.[ch] (camel_stream_b64_write_to_stream): Removed. This has nothing to do with stream-b64, so i've moved it to CamelStream. * camel-mime-utils.h: Add a comment about refcounting header_content_type struct. * Makefile.am: Added camel-stream-filter*.[ch]. * camel-stream-filter.[ch]: Class to implement a generic (multipass) filter ontop of a stream. Only implements a read-only stream. * camel-mime-parser.c (camel_mime_parser_filter_add): Ref the filter we just added. * Makefile.am: Added camel-mime-filter*.[ch]. * camel-mime-filter-charset.[ch]: A filter to preform character set conversion (uses unicode_iconv). * camel-mime-filter-save.[ch]: A simple filter which will save all data directly to a file or file descriptor. * camel-mime-filter-basic.[ch]: Implements the basic mime filters, base64 and quoted-printable decoding (encoding not implemented yet). * camel-mime-filter.[ch]: A filtering class, which can filter streams of data without having to copy them. Simpler than stream classes, and can be plugged into a single stream class (when i write it). 2000-04-07 Dan Winship * providers/pop3/camel-pop3-store.c (pop3_connect): Clarify error messages. (finalize): fix a bug in camel_exception usage (pop3_connect): Remember the password after asking for it the first time. 2000-04-07 NotZed * Makefile.am: Added camel-mime-parser/camel-mime-utils. * camel-mime-parser.c: Fast mime parser. * camel-mime-utils.c: Mime utility functions, and email header parsers. 2000-04-07 NotZed * providers/Makefile.am: Removed smtp for now, its a long way from building. * providers/smtp/Makefile.in: Removed file that shouldn't have been checked in. 2000-04-06 Matt Loper * camel-folder-pt-proxy.c (_get_full_name): Remove exception param from get_full_name() called, since get_full_name() was changed to not have an exception in the last param (see dan's notes below). (_get_name): same. 2000-04-06 Dan Winship * camel-store.[ch]: Reorganize the folder-fetching methods and implement a folder cache so that multiple requests for the same folder will yield the same CamelFolder object (as long as it remains active). Includes some code to remove no-longer-active folders from the cache, but it doesn't get used since nothing is ever unref'ed in Camel right now... * providers/mbox/camel-mbox-store.c: * providers/pop3/camel-pop3-store.c: update for CamelStore changes. * camel-folder.[ch]: Remove the (unused) CamelException argument from camel_folder_get_name and camel_folder_get_full_name. (camel_folder_set_name): make this go away since changing a folder's name after it has been created could result in it conflicting with a separately-issued folder. 2000-04-05 Dan Winship * g_url_new really wanted to take a CamelException. So, rename Gurl to CamelURL, g_url_* to camel_url_* (with camel_url_new taking an exception), and url-util.[ch] to camel-url.[ch]. Also force url->port to be numeric and remove camel_service_getport. (I was confused before: the URL RFC says the port must be numeric, so we don't want to do getportbyname.) 2000-04-01 Dan Winship * providers/mbox/camel-mbox-folder.c (_check_get_or_maybe_generate_summary_file): Compare mbox_file_size and mbox_modtime to the results of stat()ing the mbox file, not the summary file. Duh. (_close): Update the summary's mbox_file_size and mbox_modtime before writing it to disk. * providers/mbox/camel-mbox-summary.c (camel_mbox_summary_save, camel_mbox_summary_load): Wow. I must have been tired when I wrote this code. First, the comparison bug above. Second, it was using ntohs and htons instead of ntohl and htonl. Third, I was reading the status flag byte in two different places and thus getting out of sync. Fourth, it was writing out field_length bytes of each header field after having converted field_length to network byte order, resulting in lots of random crap being appended, and the summary files being huge. (Fortunately, since the size/modtime comparison was biffed, the garbage summary read from disk was always immediately discarded.) * providers/mbox/camel-mbox-parser.c (camel_mbox_parse_file): fix an off-by-one error that caused the last-used UID to be reused if the summary file was regenerated. (That one wasn't my fault. :-) 2000-03-31 Dan Winship * camel-stream-mem.c: implement unimplemented methods * gmime-content-field.c (gmime_content_field_construct_from_string): * data-wrapper-repository.c (data_wrapper_repository_get_data_wrapper_type): * camel-simple-data-wrapper.c (my_write_to_stream): * camel-mime-part.c (my_set_input_stream): remove debugging printf()s that no longer seem useful. 2000-03-31 Matt Loper * camel-formatter.c (text_to_html): Added "convert_newlines_to_br" boolean param, to give the option of not converting '\n's to
tags. This way, when we stick stuff in a 
 tag, newlines stay
	newlines.

2000-03-30  Matt Loper  

	* camel-formatter.c (handle_text_plain): Use 
 tag to force
	the use of monospaced fonts.

2000-03-30  Dan Winship  

	* camel-service.c (camel_service_getport): Add a htons in the
	default_number case, and document the fact that the function
	returns the port in network byte order.

	* providers/pop3/camel-pop3-store.c (pop3_connect): Revert
	Miguel's change. The port number bug was actually somewhere
	else, and the IP address copying code was fine already.
	
2000-03-29  Miguel de Icaza  

	* providers/pop3/camel-pop3-store.c (pop3_connect): Add htons
	(port), and only copy 4 bytes for the IP address to prevent a DNS
	attack. 

2000-03-28  Dan Winship  

	* camel-seekable-substream.c
	(camel_seekable_substream_new_with_seekable_stream_and_bounds):
	make this return a CamelStream rather than a
	CamelSeekableSubstream, because that's the way Gtk objects tend to
	work.

	* camel-service.c (camel_service_gethost,
	camel_service_getport): convenience functions to canonicalize
	the host and port values of a service's URL.
	* providers/pop3/camel-pop3-store.c: use them

	* providers/mbox/camel-mbox-folder.c
	(_check_get_or_maybe_generate_summary_file): Make this work when
	the inbox file doesn't yet exist.

2000-03-27  Dan Winship  

	* providers/mbox/camel-mbox-folder.c (_append_message): uncomment
	the call to unlink the temp file: there's no way to tell
	camel_stream_fs to truncate a file, so reusing the same file was
	resulting in junk at the ends of messages.

	* camel-folder.[ch]: add delete_message_by_{number,uid}.

	* providers/pop3/camel-pop3-folder.[ch]: implement
	delete_message_by_uid. Add a close method to do expunging
	of deleted messages if requested.

	* providers/pop3/camel-pop3-store.[ch]: support for
	CamelPop3Folder::close. (You have to close the connection
	in order to expunge the folder, thus the store may be
	connected in the CamelService::is_connected sense when it
	is not actually connected to the server.) Also some bugfixes.

2000-03-27  NotZed  

	* providers/mbox/camel-mbox-folder.c (_append_message): Unref the
	output_stream when done, close doesn't do it.
	(_append_message): Clear all uid's from the appending messages, so
	they are reassigned proper unique id's.

	* gmime-utils.c (get_header_array_from_stream): Actually free the
	header, it is copied elsewhere.

2000-03-26  NotZed  

	* providers/mbox/camel-mbox-utils.c (camel_mbox_write_xev): Added
	folder parameter to function.  Fixed callers.
	(index_message): Index a message as it is assigned a unique id.

	* camel-mime-part.c (my_set_content_id): Make sure we malloc and
	copy the content_id, otherwise *poof*

2000-03-25  NotZed  

	* camel-medium.c (_finalize): Another leak, unref the content if
	finished with it.

	* camel-recipient.c (camel_recipient_table_free): Plug another
	memory leak - actually free the recipient table.

	* camel-mime-message.c (_finalize): Plugged a memory leak with the
	flags table.

	* gmime-utils.c (_store_header_pair_from_string): A simpler, more
	debuggable and functionally identical header extraction function.

2000-03-24  NotZed  

	* gmime-content-field.c (gmime_content_field_set_parameter):
	Remove the hash table entry before freeing its key and data.

2000-03-27  Dan Winship  

	* providers/Makefile.am (SUBDIRS): Add pop3.

	* providers/pop3/camel-pop3-store.c: keep separate input and
	output streams so the output doesn't end up being buffered.

	* providers/pop3/camel-pop3-folder.c (get_message_by_number):
	finish implementing this.

2000-03-27  Michael Meeks  

	* camel-mime-part.c (my_set_disposition): fix so less broken.
	(my_finalize): remove dodgy disposition free.

	* camel-data-wrapper.c (my_set_mime_type_field): unref instead of
	free on mime_type.

2000-03-27  Dan Winship  

	* camel-service.c (camel_service_free_auth_types): new routine to
	free the data allocated by camel_service_query_auth_types.

	* providers/pop3/camel-pop3-store.c (free_auth_types): implement

	* camel-stream-mem.c (camel_stream_mem_new_with_buffer): rename
	camel_stream_mem_new_with_buffer to ..._with_byte_array and add a
	new ..._with_buffer that takes a char * rather than a GByteArray.

	* Remove CamelStreamBufferedFs, since CamelStreamBuffer makes it
	redundant.

2000-03-25  Dan Winship  

	* camel-folder-summary.[ch]: change the CamelFolderSummary
	interfaces to allow partial summary queries (for dealing
	with very large folders). Remove the "extended_fields" from
	CamelFolderInfo and CamelMessageInfo: this is better dealt
	with by subtyping.

	* providers/mbox/camel-mbox-summary.[ch]: Make CamelMboxSummary a
	subclass of CamelFolderSummary. Update interfaces for that. Remove
	the internal/external summary distinction. Remove the (unused) md5
	checksum in the folder summary. Change the summary file format
	(primarily to make it no longer byte-order dependent) and add a
	version number to it so it will be easier to change in the future.
	
	* providers/mbox/camel-mbox-folder.[ch]
	* providers/mbox/camel-mbox-search.c
	* providers/mbox/camel-mbox-utils.c: update for summary changes

	* camel-exception-list.def: add
	CAMEL_EXCEPTION_FOLDER_SUMMARY_INVALID
	
2000-03-23  NotZed  

	* providers/mbox/camel-mbox-provider.c: Added flag to provider
	initialisation, to match changed structure.

2000-03-22  NotZed  

	* camel-folder.[ch]: Added async search api.

	* providers/mbox/camel-mbox-search.c
	(camel_mbox_folder_search_by_expression): Changed to use an
	asynchronous interface.
	(camel_mbox_folder_search_cancel): Cancel function for async
	interface.

2000-03-23  Dan Winship  

	* camel-stream-buffer.c (camel_stream_buffer_read_line): Function
	to read one line of any size from a stream and return it in
	allocated memory.

2000-03-22  Dan Winship  

	* camel-service.c (camel_service_query_auth_types): New function
	to query a service for the authentication protocols it supports.
	* providers/pop3/camel-pop3-store.c (query_auth_types): implement

	* camel-provider.c (camel_provider_scan): New function to
	scan the provider dir and return a list of all providers.

	* providers/pop3/camel-pop3-folder.c: fill this in partially
	* providers/pop3/camel-pop3-store.c: make camel_pop3_command
	return the text after "+OK"/"-ERR" and add a separate
	camel_pop3_get_additional_data to get the message body or
	whatever. Also make them take a CamelPop3Store rather than
	a CamelStreamBuffer.

2000-03-22  Matt Loper  

	* camel-formatter.c (debug): Disabled some useless debug
	messaging.

2000-03-21  Dan Winship  

	* providers/pop3: some initial bits of the POP3 provider, to
	make Matt happy. Incomplete, untested, etc.

2000-03-21  bertrand  

	* providers/mbox/camel-mbox-summary.c 
	(camel_mbox_summary_append_internal_to_external): copy the size field

	* providers/mbox/camel-mbox-folder.c (_get_message_by_uid): initialize 
	message_info to NULL

	* camel-folder-summary.h: added the size field.

	* providers/mbox/camel-mbox-summary.h: 
	added the received_date field.

	* providers/mbox/camel-mbox-summary.c:
	documented all functions.

	* camel-folder-summary.h: name change and 
	new fields.

	* providers/mbox/camel-mbox-search.c: update to 
	conform to name change in the summary fields.

2000-03-10  bertrand  

	* camel-service.h: cosmetic changes.

2000-03-09  Dan Winship  

	* s/HelixCode/Helix Code, Inc./ in the copyrights

2000-03-07  bertrand  

	* camel-formatter.c (handle_mime_part): 
	plug mem leaks due to bad documentation
	of camel_content_field_get_mime_type
	(print_camel_body_part): idem
	(handle_multipart_alternative): idem

	* gmime-content-field.c (gmime_content_field_get_mime_type): 
	documentation fix.


	* camel-mime-part.c (my_finalize): unref the 
	content_input_stream if any. 

2000-03-06  bertrand  

	* camel-stream-fs.c (_seek): fix a bogus calculation
	in the return position.

2000-03-05  bertrand  

	* camel-session.h: cosmetic fixes.

	* camel-stream-fs.c (_read): 
	(_seek): fixed the current position so that it refers
	to the current position in the stream, not in its parent.

2000-03-04  NotZed  

	* providers/mbox/camel-mbox-search.c
	(camel_mbox_folder_search_by_expression): Ref the summary
	after we have got it.

2000-03-04  bertrand  

	* camel-mime-part.c (my_write_content_to_stream): 
	stream the raw content instead of nothing if the encoding
	is not supported.

	* camel-stream-fs.c (_seek): handle eos more
	properly.

	* camel-formatter.c (get_bonobo_tag_for_object): 
	bonobo-goad-id is the good key to look for. 
	(get_bonobo_tag_for_object): close the  tag.
	(get_bonobo_tag_for_object): the correct syntax for the
	to set a parameter inside an  tag is :
	  
	

2000-03-03  bertrand  

	* providers/mbox/camel-mbox-folder.c (_get_message_by_uid): 
	use set_input_stream instead of construct_from_stream
	to feed the message object. 

	* camel-data-wrapper.c (my_write_to_stream): reset output stream.
	(my_set_input_stream): unref the previous input stream.
	use the set_output_stream for default behaviour.
	(my_set_output_stream): unref previous output stream.

	* camel-mime-part.c (my_write_content_to_stream): reset content
	object output stream.

2000-03-03  NotZed  

	* providers/mbox/camel-mbox-utils.c (camel_mbox_write_xev): Make
	sure we open with create with a creation mask.

2000-03-01  NotZed  

	* camel-mime-part-utils.c
	(camel_mime_part_construct_content_from_stream): DO NOT assert on
	content type, we have fallback code 4 lines below it ... *sigh*

2000-02-29  NotZed  

	* Makefile.am (libcamelinclude_HEADERS): Added camel-stream-buffer
	to build.

	* camel-stream-buffer.[ch]: Generic buffer which can be applied to
	any stream.

2000-03-03  bertrand  

	* camel-formatter.c (handle_image): in the case
	of images, put the content object output stream
	in the url. This allows the message browser
	to show inline images.

	* camel-stream-b64.c (my_read_encode): fixed state
	0 keep value. 

2000-03-02  bertrand  

	* camel-stream-b64.c (my_read_encode): don't forget to 
	set the state to 0 after 3.
	(my_read_encode): don't forget to encode, even in state 3.

	* camel-simple-data-wrapper.c: static functions are prefixed 
	with my_ instead of _
	* camel-multipart.c: static functions are prefixed 
	with my_ instead of _
	(my_write_to_stream): commented.
	(my_write_to_stream): warning in case the boudary is set
	but is a zero length string.

	* camel-mime-part.c (camel_mime_part_encoding_from_string): 
	remove debug trace. 
	
	* camel-mime-part.c: Replaced all static functions
	with name begining with _ by the same name begining
	with "my_" to prevent the possible conflicts 
	with system symbols Dan warned us about. 
	
	* camel-stream-b64.c (camel_stream_b64_write_to_stream): 
	use CamelStreamB64 type for the input stream.

	* camel-mime-part.c (_get_content_object): remove 
	debugging trace
	(_write_content_to_stream): implement the b64 
	encoding the new way (that is using camel_stream_b64)

	* camel-data-wrapper.c (my_write_to_stream): 
	fix implementation so that it writes properly
	to the output stream even.

	* camel-stream-b64.c (camel_stream_b64_write_to_stream): 
	fix implementation. 

2000-02-29  bertrand  

	* camel-stream-b64.c (camel_stream_b64_write_to_stream): new
	utility function. 

	* camel-data-wrapper.c (_write_to_stream): default
	implementation. 

	* gmime-utils.c (_store_header_pair_from_string): 
	revert strange changes. 

	* camel-stream-b64.c (my_read_decode): set eos to true when we
	have read the whole input stream. 
	(my_reset): set eos to FALSE.

2000-02-28  NotZed  

	* camel-mime-part.c (_parse_header_pair): Dont free this either.

	* camel-medium.c (_remove_header): Ugh, dont free the header
	before we actually remove it.
	(_add_header): Ugh, dont free hashtable entries which may be
	duplicated (hash_insert _will_ reference that memory).

	* string-utils.c (string_trim): Trimming a 0-length string is not
	an error.

	* camel-mime-message.c (_parse_header_pair): Fixed very broken
	memory handling of header_name/value.

	* providers/mbox/camel-mbox-utils.c (camel_mbox_write_xev):
	Initialise end_of_last_message always.
	(camel_mbox_copy_file_chunk): Stop trying to read if we run out of
	data, rather than looping forever.
	(camel_mbox_write_xev): Use an open flag when opening with create.

	* camel-folder.c (camel_folder_search_by_expression): No, its not
	a fatal error to search on a non-searchable folder, you just dont
	get any matches.
	(_open): Dont open an opened folder (i dont see why this is really
	a bug, but what the hell ...)

	* providers/mbox/camel-mbox-folder.c (_init): Set search cap on.
	(_open): Call parent class to perform open.  Remove folder-open
	check to parent instead.
	(_create): open takes a creation mask, dont use umask to try and
	set the open mode.
	(_delete): Dont bother checking folder==NULL, its already been
	checked on the external interface (changed to an assertion, this
	would have to be a camel bug).
	(_delete_messages): Likewise.
	(_create): Ditto.
	(_init): Dont go and clear all the paths and shit that the parent
	open just setup for us.
	(_delete_messages): Get rid of more umask stuff.
	(_append_message): Make sure we pass file mode to open with create.
	(_append_message): Cleaned up some indenting to make it readable.

	* camel-stream-b64.c (my_read_encode): Fixed a typo.

	* providers/mbox/camel-mbox-search.c: Changed to use e-sexp,
	rather than filter-sexp.

2000-02-28  bertrand  

	* camel-stream-b64.c (my_read_encode): encoding
	filter.

2000-02-23  bertrand  

	* camel-stream-b64.c: changed the __static 
	suffix into a my_ prefix. 
	(camel_stream_b64_set_mode): reset the persistent
	status. 
	(my_read_decode): remove superfluous %
	
	* providers/mbox/camel-mbox-utils.c (camel_mbox_copy_file_chunk): 
	fix exception description message.

2000-02-24  Dan Winship  

	* camel-session.c: Add camel_session_get_transport_for_protocol.

	* camel-transport.h:
	* camel-transport.c: Add an abstract CamelTransport class.

	* providers/sendmail/*: A CamelTransport that uses sendmail
	to deliver mail.

2000-02-24  Dan Winship  

	* camel-folder.c: use CamelExceptions for run-time errors, not
	incorrect code. Don't bother validating that an object exists from
	inside one of its methods, since you couldn't have gotten there if
	it didn't. Fix some code style bugs.

	(_init): Rename init_with_store to init and add parent_folder,
	separator, and name arguments.
	(_set_name): Get separator from self, not parent_store now.

	* camel-store.h:
	* camel-store.c: Remove get/set_separator.

	* providers/mbox/: Update for above.

2000-02-23  Dan Winship  

	* camel-medium.c (_finalize): Free the data in the headers hash
	table.
	(_add_header): g_strdup the header name and value when adding it.

	* camel-mime-part-utils.c
	(camel_mime_part_construct_headers_from_stream): Free the header
	data after calling camel_medium_add_header, since it will have
	g_strdup()ed it itself.

2000-02-22  NotZed  

	* providers/mbox/camel-mbox-search.c: Dont compile by default.

	* providers/mbox/Makefile.am: Fuck off the filter code.

2000-02-22  bertrand  

	* camel-stream-b64.c (read_decode__static): 
	don't read the char if we reached the length
	of the output buffer. Hours lost on this
	%$!@# bug : 3.5

	* camel-folder.c (camel_folder_get_subfolder): 
	(camel_folder_create): 
	(camel_folder_delete): 
	(camel_folder_delete_messages): 
	(camel_folder_list_subfolders): 
	(camel_folder_expunge): 
	(camel_folder_get_message_by_number): 
	(camel_folder_get_message_count): 
	(camel_folder_append_message): 
	(camel_folder_copy_message_to): 
	(camel_folder_get_summary): 
	(camel_folder_get_message_uid): 
	(camel_folder_get_message_by_uid): 
	(camel_folder_get_uid_list): 
	Check folder state (open/close) and raise an
	exception if it is not ok. 
	
	* providers/mbox/camel-mbox-folder.c (_create): 
	create the file and the path with two different
	names.

	* camel-folder.c (_create): handle the case 
	when the folder name starts with '/'

	* camel-exception.c (camel_exception_new): use 
	(void) instead of () in decl.

	* camel-exception.h: cosmetic fixes.

	* camel-exception.c (camel_exception_init): new routine.
	Fix a bug in mail/message-list.c
	

	* camel-folder.h: cosmetic changes.

	* camel-stream-b64.c (reset__static): added a
	reset method. Thanks message-browser to find
	so much bugs :)

	* providers/mbox/Makefile.am (libcamelmbox_la_LIBADD): readd
	Unicode libs.

2000-02-21  bertrand  

	* camel-formatter.c (lookup_unique_id): 
	awful hack to test get_output_stream.
	* camel-stream-b64.[ch] :
	b64 encoding/decoding is now implemented as
	a stream. 
	

2000-02-21  bertrand  

	* camel-seekable-substream.c (_reemit_parent_signal): 
	emit "data_available" when parent stream emits it. 


2000-02-21  NotZed  

	* providers/mbox/Makefile.am: Uh, fixed LIBADD again.  What was
	there was never ever going to work, wasn't it tested?


2000-02-21  Dan Winship  

	* camel-session.h: (struct _CamelSession): Add authenticator.

	* camel-session.c (camel_session_new): Add authenticator.
	(camel_session_query_authenticator): New function to query the
	session authenticator for password, etc, information.

2000-02-21  Dan Winship  

	* camel-session.c: add CamelExceptions to several functions. Use
	camel_session_new to initialize the session and URL fields of
	created CamelStores as appropriate.

	* camel-store.h:
	* camel-store.c
	* camel-service.h:
	* camel-service.c: Move the session and url (and associated
	functions) from CamelStore to CamelService. Add url_flags to
	CamelService so subclasses can specify which URL components
	are mandatory for them.	Add camel_session_new for
	camel_session_get_store* to use.

	* providers/mbox/camel-mbox-folder.c:
	* providers/mbox/camel-mbox-store.c:
	* providers/mbox/camel-mbox-store.h: Update for above changes.

	* camel-exception-list.def: Once camel is being used for real,
	exceptions won't be renumberable. So renumber them now to make
	more room to add exceptions to the various categories later, and
	add a big warning message.

2000-02-20  Dan Winship  

	* providers/mbox/Makefile.am: add libibex back to
	libcamelmbox_la_LIBADD

2000-02-18  NotZed  

	* providers/mbox/camel-mbox-search.h
	(camel_mbox_folder_search_by_expression): Added exception to call,
	and fixed caller.

	* providers/mbox/camel-mbox-search.c
	(camel_mbox_folder_search_by_expression): Major changes, to use
	the sexp evaluator from filter/filter-sexp.c to implement the
	searching.
	(func_body_contains): Changed to support multiple strings in 1
	command (results or'd together)

	* url-util.c (g_url_new): Fixed a typo (colon == 0 isn't right),
	and made it so full url's are absolute pathed (Dan, this is how it
	has to work!).  Also, always include a path part, even if it is an
	empty string.

2000-02-18  Dan Winship  

	* camel/camel-types.h: New header with the typedefs for all camel
	classes. Now the class headers can just include this and the
	header for the parent type. This makes it possible for
	CamelService to include a CamelSession without creating an
	#include loop.

	* camel/*:	
	* composer/e-msg-composer-attachment-bar.h:
	* mail/folder-browser.c:
	* mail/message-list.c: frob #includes to match the new reality

2000-02-17  Dan Winship  

	* camel/camel-service.h:
	* camel/camel-service.c: Make camel-service us a Gurl internally.
	Remove the login/password interfaces and instead provide
	camel_service_connect_with_url. Add CamelExceptions

2000-02-17  bertrand  

	* camel/camel-formatter.c (handle_text_plain): 
	(handle_text_html): use camel_stream_reset instead
	of seek. The formatter should be able to work 
	with all streams, not only seekable streams. 
	In the case where some provider implementation
	would not be able to provide a reset method 
	to their stream, implementors would have
	to find a workaround.

	* camel/camel-session.c (camel_session_new): use
	(void) instean of () in function decl.

	* camel/camel-folder.c: ifdef async operation 
	related code. 

	* camel/camel-seekable-stream.c (_seek): added a warning.
	(_reset): default implementation of reset for seekable
	stream.

	* camel/camel-mime-message.h: set_received_date declaration fix.
	cosmetic changes.

	* camel/providers/mbox/camel-mbox-provider.c (camel_provider_module_init): 
	use (void) instead of ().

	* camel/camel-stream.c (camel_stream_reset): 
	new method for CamelStream.

2000-02-17  Dan Winship  

	* camel/url-util.c (g_url_to_string): New function to convert
	a Gurl back into a char *.

2000-02-17  bertrand  

	* camel/camel-formatter.c (handle_text_plain): 
	revamped so that it uses the output stream
	of the data wrapper
	(handle_text_html): ditto.
	
	
	* camel/camel-simple-data-wrapper.h: 
	* camel/camel-simple-data-wrapper.c (camel_simple_data_wrapper_new): 
	use (void) instead of ().
	(_get_output_stream): simple implementation. 

2000-02-16  bertrand  

	* camel/camel-data-wrapper.c (_set_input_stream): ref input stream
	(_set_output_stream): ref output stream
	(_finalize): unref input and output streams

	* camel/camel-seekable-substream.c (_set_bounds): don't
	seek the begining of the substream.
	(_eos): fix eos condition testing. 
	(_finalize): unref parent stream
	(_init_with_seekable_stream_and_bounds): ref parent stream

	* camel/gstring-util.c (g_string_equal_for_hash): 
	(g_string_equal_for_glist): return type is int.

	* camel/camel.h: 
	* camel/camel.c (camel_init): use (void) 
	instead of ().
	
2000-02-16  NotZed  

	* providers/mbox/Makefile.am (libcamelmbox_la_LIBADD): Added
	libfilter to link line (temporarily?).  Required for
	filter-sexp.

2000-02-15  bertrand  

	* camel/camel-multipart.c (_localize_part): 
	this routine replaces the _read_part routine
	and does not store the part in a buffer. 
	(_set_input_stream): use the set_input_stream
	instead of the construct_from_stream.
	each bodypart is given an input stream. 

	* camel/camel-mime-part-utils.c: 
	include the data-wrapper-repository header. 
	(camel_mime_part_construct_content_from_stream): 
	use the set_input_stream instead of the 
	construct_from_stream method. 

	* camel/camel-seekable-substream.c (_set_bounds): 
	cur position is set to 0 not to inf_bound.

2000-02-15  bertrand  

	* camel/camel-mime-part.c: include gmime-base64.h
	various compilation and runtime fixes.
	(_set_input_stream): store the input substream 
	for the content object.

	* camel/camel-data-wrapper.h: declare the 
	set/get function on input/output stream.

	* camel/camel-mime-part.c (_get_content_object): 
	don't use a temporary mem stream. 	

	* camel/camel-seekable-substream.c (_seek): 
	(_eos): 
	(_read): the substream can be unlimited in length

	* camel/camel-data-wrapper.c (camel_data_wrapper_class_init): 
	set the get/set_input/output_stream methods. 	

	* camel/camel-multipart.c (_construct_from_stream): 
	camel_stream_seek -> camel_seekable_stream_seek

2000-02-14  Miguel de Icaza  

	* camel/providers/mbox/Makefile.am (libcamelmbox_la_LIBADD): Add
	the unicode libraries as well.

	* camel/camel-provider.c (camel_provider_register_as_module): Add
	error reporting here.  Desire to use Solaris increases.  Hair loss
	in the last two hours: 5,400.

	* camel/providers/mbox/camel-mbox-provider.c
	(camel_mbox_get_provider): Renamed function.

	* camel/camel.h: All include files use camel/ now here.

	* camel/providers/mbox/Makefile.am: Drop all the dynamism from
	Camel, and make this a standard library.

2000-02-14  bertrand  

	* camel/gmime-utils.c (get_header_array_from_stream): use the 
	eos stream method. 
	(gmime_read_line_from_stream): ditto.

	* camel/camel-stream-fs.h (struct ): add the eof field
	cosmetics changes. 

	* camel/camel-stream-fs.c (camel_stream_fs_init): set eof.
	(_read): set eof on end of file.
	(_eos): implemented.

	* camel/gmime-utils.c (get_header_array_from_stream): 
	make a blocking version of the header parser. 
	When the fs stream uses gnome-vfs, this should
	be changed. 
	(gmime_read_line_from_stream): ditto. 

2000-02-11  bertrand  

	* camel/camel-stream-fs.c: 
	everywhere, when using the cur_pos field, do it
	on the CamelSeekableStream object.
	(_seek): small fix. 

	* camel/camel-seekable-stream.c (camel_seekable_stream_seek): 
	s/camel_stream_seek/camel_seekable_stream_seek/g

	* camel/camel-seekable-stream.h: 
	(struct ): added a field to store the
	current position.

	* camel/camel-seekable-stream.c (camel_seekable_stream_get_current_position): 
	New function. Allows to get the current position 
	of a seekable stream.
	

2000-02-13  NotZed  

	* providers/mbox/camel-mbox-search.c: New file, implements the
	search api for mbox folders.

	* providers/mbox/Makefile.am: Link with ibex.

	* camel-folder.c (camel_folder_has_search_capability): Api
	additions.
	(camel_folder_search_by_expression): Ditto.

2000-02-12  NotZed  

	* providers/mbox/camel-mbox-folder.c (_set_name): Setup index
	filename as well.
	(_init_with_store): Init index filename.  Hmm, none of these
	names ever seem to get free'd (FIXME?)

	* providers/mbox/camel-mbox-folder.h: Add index file name.

2000-02-12  NotZed  

	* camel-folder.h: Add folder search functions.

	** Created ChangeLog just for camel **
	 - refer to ../ChangeLog for changes prior to this date.