From 31485fd4119368e7c208a1ff86860a7e2370532f Mon Sep 17 00:00:00 2001 From: Tor Lillqvist Date: Wed, 28 Sep 2005 11:35:31 +0000 Subject: Use g_ascii_strcasecmp() instead of strcasecmp(). We are comparing to 2005-09-28 Tor Lillqvist * e-charset-picker.c (e_charset_picker_new, e_charset_picker_bonobo_ui_populate): Use g_ascii_strcasecmp() instead of strcasecmp(). We are comparing to strings known to be plain ASCII, so just casefolding ASCII is enough. Also better for portability. svn path=/trunk/; revision=30406 --- widgets/misc/ChangeLog | 8 ++++++++ widgets/misc/e-charset-picker.c | 8 ++++---- 2 files changed, 12 insertions(+), 4 deletions(-) (limited to 'widgets') diff --git a/widgets/misc/ChangeLog b/widgets/misc/ChangeLog index 8a8ba84774..c4b0eb859c 100644 --- a/widgets/misc/ChangeLog +++ b/widgets/misc/ChangeLog @@ -1,3 +1,11 @@ +2005-09-28 Tor Lillqvist + + * e-charset-picker.c (e_charset_picker_new, + e_charset_picker_bonobo_ui_populate): Use g_ascii_strcasecmp() + instead of strcasecmp(). We are comparing to strings known to be + plain ASCII, so just casefolding ASCII is enough. Also better for + portability. + 2005-09-20 Devashish Sharma * e-search-bar.c (subitem_activated_cb): Emits the signal "search diff --git a/widgets/misc/e-charset-picker.c b/widgets/misc/e-charset-picker.c index 79693ace1b..f0cb307000 100644 --- a/widgets/misc/e-charset-picker.c +++ b/widgets/misc/e-charset-picker.c @@ -300,13 +300,13 @@ e_charset_picker_new (const char *default_charset) const char *locale_charset; g_get_charset (&locale_charset); - if (!strcasecmp (locale_charset, "US-ASCII")) + if (!g_ascii_strcasecmp (locale_charset, "US-ASCII")) locale_charset = "iso-8859-1"; if (!default_charset) default_charset = locale_charset; for (def = 0; def < num_charsets; def++) { - if (!strcasecmp (charsets[def].name, default_charset)) + if (!g_ascii_strcasecmp (charsets[def].name, default_charset)) break; } @@ -466,13 +466,13 @@ e_charset_picker_bonobo_ui_populate (BonoboUIComponent *uic, const char *path, int def, i; g_get_charset (&locale_charset); - if (!strcasecmp (locale_charset, "US-ASCII")) + if (!g_ascii_strcasecmp (locale_charset, "US-ASCII")) locale_charset = "iso-8859-1"; if (!default_charset) default_charset = locale_charset; for (def = 0; def < num_charsets; def++) { - if (!strcasecmp (charsets[def].name, default_charset)) + if (!g_ascii_strcasecmp (charsets[def].name, default_charset)) break; } -- cgit v1.2.3