From 1bdc6e147f19384e42679512130cfc5f4d93364b Mon Sep 17 00:00:00 2001 From: Jon Trowbridge Date: Tue, 6 Mar 2001 00:13:23 +0000 Subject: Set version number to 0.5.99.5 2001-03-05 Jon Trowbridge * configure.in: Set version number to 0.5.99.5 * gal/e-text/e-entry.c (e_entry_class_init): Add a "popup" signal. If you have trepidations about this, see the technical argument below. (e_entry_init): Connect to the EText's popup signal. (e_entry_proxy_popup): Proxy emitter for popup signals from the EText. * gal/e-text/e-text.c (e_text_class_init): Added a "popup" signal. (e_text_event): Emit the "popup" signal on right-clicks. Now you could ask yourself: "should there be a signal named 'popup' in EText that gets emitted on right-clicks?" And this is a reasonable question, since... well, this has a funny feeling to it. But the whole point of GNOME, or at least one of the original points of GNOME, was to impose policy in a reasonable way when it made sense in order to simplify the user's experience. Convention dictates that popup menus are tied to right-clicks --- so rather than setting up some elaborate forwarding of button-press signals, why not just impose a little policy and set up a signal that is closely tied to a familiar set of semantics? Maybe it isn't the best thing to do from a aesthetics-of-the-API point of view, but I doubt anyone could condemn it as being anything more than mostly harmless. svn path=/trunk/; revision=8565 --- widgets/text/e-entry.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'widgets/text/e-entry.h') diff --git a/widgets/text/e-entry.h b/widgets/text/e-entry.h index 8b62ddcc29..64b6fb7875 100644 --- a/widgets/text/e-entry.h +++ b/widgets/text/e-entry.h @@ -58,8 +58,9 @@ struct _EEntry { struct _EEntryClass { GtkTableClass parent_class; - void (* changed) (EEntry *entry); + void (* changed) (EEntry *entry); void (* activate) (EEntry *entry); + void (* popup) (EEntry *entry, GdkEventButton *ev, gint pos); }; GtkType e_entry_get_type (void); -- cgit v1.2.3