From bbe6437d089381bb2a3008e98a03aebef53af0e6 Mon Sep 17 00:00:00 2001 From: Matthew Barnes Date: Thu, 14 May 2009 10:50:38 -0400 Subject: =?UTF-8?q?Bug=20582585=20=E2=80=93=20Crash=20when=20deleting=20mu?= =?UTF-8?q?ltiple=20attachments=20from=20composed=20mail?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- widgets/misc/e-attachment-view.c | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'widgets/misc/e-attachment-view.c') diff --git a/widgets/misc/e-attachment-view.c b/widgets/misc/e-attachment-view.c index 27ef5d84a8..48292cfbc3 100644 --- a/widgets/misc/e-attachment-view.c +++ b/widgets/misc/e-attachment-view.c @@ -1038,6 +1038,12 @@ e_attachment_view_remove_selected (EAttachmentView *view, store = e_attachment_view_get_store (view); model = GTK_TREE_MODEL (store); + /* Remove attachments in reverse order to avoid invalidating + * tree paths as we iterate over the list. Note, the list is + * probably already sorted but we sort again just to be safe. */ + selected = g_list_reverse (g_list_sort ( + selected, (GCompareFunc) gtk_tree_path_compare)); + for (item = selected; item != NULL; item = item->next) { EAttachment *attachment; GtkTreePath *path = item->data; -- cgit v1.2.3