From 570c6374806d0f1ec59cf7a72543efe6b5b637be Mon Sep 17 00:00:00 2001 From: Milan Crha Date: Fri, 15 Nov 2013 09:06:57 +0100 Subject: Fix/mute issues found by Coverity scan This makes the code free of Coverity scan issues. It is sometimes quite pedantic and expects/suggests some coding habits, thus certain changes may look weird, but for a good thing, I hope. The code is also tagged with Coverity scan suppressions, to keep the code as is and hide the warning too. Also note that Coverity treats g_return_if_fail(), g_assert() and similar macros as unreliable, and it's true these can be disabled during the compile time, thus it brings in other set of 'weird' changes. --- shell/e-shell-utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'shell/e-shell-utils.c') diff --git a/shell/e-shell-utils.c b/shell/e-shell-utils.c index 97982cfbf9..1c3f8f88c0 100644 --- a/shell/e-shell-utils.c +++ b/shell/e-shell-utils.c @@ -156,7 +156,7 @@ e_shell_run_save_dialog (EShell *shell, gchar **flts = g_strsplit (filters, ";", -1); gint i; - for (i = 0; flts[i]; i++) { + for (i = 0; flts && flts[i]; i++) { GtkFileFilter *filter = gtk_file_filter_new (); gchar *flt = flts[i]; gchar *delim = strchr (flt, ':'), *next = NULL; -- cgit v1.2.3