From a0bb856b78226d72fdbada28f554f717658749ba Mon Sep 17 00:00:00 2001 From: Milan Crha Date: Mon, 18 Feb 2008 11:10:10 +0000 Subject: ** Part of fix for bug #515744 2008-02-18 Milan Crha ** Part of fix for bug #515744 * addressbook/gui/component/addressbook-migrate.c: (get_source_name): * plugins/groupwise-features/send-options.c: (get_source): * plugins/groupwise-features/share-folder-common.c: (get_container_id): * plugins/groupwise-features/install-shared.c: (install_folder_response): * plugins/external-editor/external-editor.c: (convert_to_camel_internet_address), (org_gnome_external_editor): * plugins/itip-formatter/itip-formatter.c: (idle_open_cb): * mail/em-folder-view.c: (emfv_setup_view_instance): * mail/mail-component.c: (impl_finalize): * mail/message-list.c: (ml_tree_value_at): * composer/e-msg-composer.c: (drop_action): * e-util/e-config.c: (ep_finalise): Use proper member to free. * widgets/misc/e-cursors.c: (e_cursors_init): * widgets/misc/e-calendar-item.c: (e_calendar_item_draw_month): * calendar/gui/dialogs/comp-editor.c: (drop_action): * calendar/gui/calendar-config.c: (calendar_config_get_hide_completed_tasks_sexp): * calendar/gui/comp-editor-factory.c: (edit_existing): * calendar/gui/e-day-view.c: (e_day_view_reshape_long_event), (e_day_view_on_top_canvas_drag_data_received): * calendar/gui/e-day-view-main-item.c: (e_day_view_main_item_draw_events_in_vbars), (e_day_view_main_item_draw_long_events_in_vbars): * calendar/gui/e-day-view-top-item.c: (e_day_view_top_item_draw_long_event): * calendar/gui/e-cal-model.c: (redo_queries): * calendar/gui/e-calendar-table.c: (e_calendar_table_open_task): * calendar/gui/e-memo-table.c: (open_memo): * calendar/gui/print.c: (print_todo_details): * calendar/gui/migration.c: (get_source_name): Memory leak fix. * calendar/gui/e-week-view.c: (e_week_view_reshape_events): Simplifies things. svn path=/trunk/; revision=35044 --- plugins/groupwise-features/ChangeLog | 9 +++++++++ plugins/groupwise-features/install-shared.c | 6 +++++- plugins/groupwise-features/send-options.c | 1 + plugins/groupwise-features/share-folder-common.c | 5 +++-- 4 files changed, 18 insertions(+), 3 deletions(-) (limited to 'plugins/groupwise-features') diff --git a/plugins/groupwise-features/ChangeLog b/plugins/groupwise-features/ChangeLog index 075bd3661a..2aa572f794 100644 --- a/plugins/groupwise-features/ChangeLog +++ b/plugins/groupwise-features/ChangeLog @@ -1,3 +1,12 @@ +2008-02-18 Milan Crha + + ** Part of fix for bug #515744 + + * send-options.c: (get_source): + * share-folder-common.c: (get_container_id): + * install-shared.c: (install_folder_response): + Memory leak fix. + 2008-01-28 Andre Klapper * proxy-add-dialog.glade: string "Read" needs gettext context, diff --git a/plugins/groupwise-features/install-shared.c b/plugins/groupwise-features/install-shared.c index c0bffb23e0..0b12c39983 100644 --- a/plugins/groupwise-features/install-shared.c +++ b/plugins/groupwise-features/install-shared.c @@ -97,6 +97,7 @@ install_folder_response (EMFolderSelector *emfs, int response, gpointer *data) camel_exception_init (&ex); if (!(store = (CamelStore *) camel_session_get_service (mail_component_peek_session(NULL), uri, CAMEL_PROVIDER_STORE, &ex))) { camel_exception_clear (&ex); + g_strfreev (names); return; } @@ -122,12 +123,15 @@ install_folder_response (EMFolderSelector *emfs, int response, gpointer *data) camel_exception_init (&ex); if (!(provider = camel_provider_get(uri, &ex))) { camel_exception_clear (&ex); + g_strfreev (names); return; } /* make sure the new store belongs in the tree */ - if (!(provider->flags & CAMEL_PROVIDER_IS_STORAGE)) + if (!(provider->flags & CAMEL_PROVIDER_IS_STORAGE)) { + g_strfreev (names); return; + } em_folder_tree_model_add_store (model, store, account->name); camel_object_unref (store); diff --git a/plugins/groupwise-features/send-options.c b/plugins/groupwise-features/send-options.c index abfde2fd61..860b8469ec 100644 --- a/plugins/groupwise-features/send-options.c +++ b/plugins/groupwise-features/send-options.c @@ -374,6 +374,7 @@ get_source (ESourceList *list) if (so_uri) { if (!strcmp (so_uri, uri)) { g_free (so_uri), so_uri = NULL; + g_strfreev (temp); return E_SOURCE (r->data); } g_free (so_uri), so_uri = NULL; diff --git a/plugins/groupwise-features/share-folder-common.c b/plugins/groupwise-features/share-folder-common.c index 36b2d15449..ca1f235651 100644 --- a/plugins/groupwise-features/share-folder-common.c +++ b/plugins/groupwise-features/share-folder-common.c @@ -531,8 +531,9 @@ get_container_id(EGwConnection *cnc, gchar *fname) g_free (name); } e_gw_connection_free_container_list (container_list); - if (names) - g_strfreev(names); } + + if (names) + g_strfreev (names); return id; } -- cgit v1.2.3