From af493cae450d3b0d42d0806bd9b728af15b67270 Mon Sep 17 00:00:00 2001 From: Matthew Barnes Date: Sat, 9 Mar 2013 08:44:37 -0500 Subject: e_mail_config_notebook_commit: Skip non-writable sources. In some cases the collection source is non-writable but its child sources _are_ writable. In that case, the one non-writable source causes the whole operation to fail. Commit only writable sources. --- mail/e-mail-config-notebook.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'mail') diff --git a/mail/e-mail-config-notebook.c b/mail/e-mail-config-notebook.c index fd43b20c7e..bd7f5485df 100644 --- a/mail/e-mail-config-notebook.c +++ b/mail/e-mail-config-notebook.c @@ -807,18 +807,18 @@ e_mail_config_notebook_commit (EMailConfigNotebook *notebook, /* Queue the collection data source if one is defined. */ source = e_mail_config_notebook_get_collection_source (notebook); - if (source != NULL) + if (source != NULL && e_source_get_writable (source)) g_queue_push_tail (source_queue, g_object_ref (source)); /* Queue the mail-related data sources for the account. */ source = e_mail_config_notebook_get_account_source (notebook); - if (source != NULL) + if (source != NULL && e_source_get_writable (source)) g_queue_push_tail (source_queue, g_object_ref (source)); source = e_mail_config_notebook_get_identity_source (notebook); - if (source != NULL) + if (source != NULL && e_source_get_writable (source)) g_queue_push_tail (source_queue, g_object_ref (source)); source = e_mail_config_notebook_get_transport_source (notebook); - if (source != NULL) + if (source != NULL && e_source_get_writable (source)) g_queue_push_tail (source_queue, g_object_ref (source)); list = gtk_container_get_children (GTK_CONTAINER (notebook)); -- cgit v1.2.3