From 733462ca84044f3fe956b4578870ab7698242fd6 Mon Sep 17 00:00:00 2001 From: Milan Crha Date: Wed, 26 Mar 2014 16:48:03 +0100 Subject: Fix two memory leaks a) ETableColumnSpecification: the 'title' property is always overwritten during the spec file loading, thus no need to allocate it here b) the 'uids' are leaked on message move, because the GPtrArray is supposed to be always unreffed --- mail/e-mail-reader.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) (limited to 'mail') diff --git a/mail/e-mail-reader.c b/mail/e-mail-reader.c index e1c477ed12..b7d380ac8d 100644 --- a/mail/e-mail-reader.c +++ b/mail/e-mail-reader.c @@ -868,20 +868,16 @@ action_mail_move_cb (GtkAction *action, g_free (default_xfer_messages_uri); default_xfer_messages_uri = g_strdup (uri); - if (uri != NULL) { + if (uri != NULL) mail_transfer_messages ( session, folder, uids, TRUE, uri, 0, NULL, NULL); - uids = NULL; - } exit: - if (uids != NULL) - g_ptr_array_unref (uids); - gtk_widget_destroy (dialog); g_clear_object (&folder); + g_ptr_array_unref (uids); } static void -- cgit v1.2.3