From 31128ea462c72c1e00d7864f39cbdc1bc2294108 Mon Sep 17 00:00:00 2001 From: Milan Crha Date: Wed, 14 Jul 2010 15:30:20 +0200 Subject: Bug #624335 - Abort after group-by-thread with certain sorting --- mail/message-list.c | 17 ++--------------- 1 file changed, 2 insertions(+), 15 deletions(-) (limited to 'mail') diff --git a/mail/message-list.c b/mail/message-list.c index 969412de4b..f88f08bc37 100644 --- a/mail/message-list.c +++ b/mail/message-list.c @@ -4211,21 +4211,8 @@ static void free_message_info_data (gpointer uid, struct sort_message_info_data *data, struct sort_array_data *sort_data) { if (data->values) { - gint i; - - g_return_if_fail (data->values->len <= sort_data->sort_columns->len); - - for (i = 0; i < data->values->len; i++) { - gpointer v = g_ptr_array_index (data->values, i); - struct sort_column_data *scol; - - if (!v) - continue; - - scol = g_ptr_array_index (sort_data->sort_columns, i); - ml_free_value (NULL, scol->col->compare_col, v, NULL); - } - + /* values in this array are not newly allocated, even ml_tree_value_at_ex + returns gpointer, not a gconstpointer */ g_ptr_array_free (data->values, TRUE); } -- cgit v1.2.3