From f15bb6a3ebcadfc4dbe8e9d2a2c82c98ac2da35a Mon Sep 17 00:00:00 2001 From: Jon Trowbridge Date: Wed, 6 Jun 2001 21:09:20 +0000 Subject: Check that the chain of deferences in gui->account->source->url is safe. 2001-06-06 Jon Trowbridge * mail-account-gui.c (source_type_changed): Check that the chain of deferences in gui->account->source->url is safe. This was causing a segfault when adding a new account if any of the existing accounts had their sources set to "None". (i.e. gui->account->source == NULL) * mail-accounts.c (load_accounts): Check that account->source != NULL before dereferencing it. (load_accounts): The selection is cleared when the account clist is rebuilt (say after a call to add), but no unselect event is emitted. Yes, the clist is evil. We work around this by explictly calling mail_unselect, our unselect signal handler. (Otherwise, the edit and delete buttons remain sensitive and accounts_row != 0, but the user can't see which row the dialog thinks is selected.) (load_news): Check the account->source != NULL before dereferencing it. (mail_unselect): If an insensitive button in a button box has the focus, and if you hit tab, there is a segfault deep inside of gtk. This is probably a gtk bug. We work around it by having the add button (which is always sensitive) grab the focus on an unselect. svn path=/trunk/; revision=10136 --- mail/ChangeLog | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) (limited to 'mail/ChangeLog') diff --git a/mail/ChangeLog b/mail/ChangeLog index cc5a2008ce..5cf9910a36 100644 --- a/mail/ChangeLog +++ b/mail/ChangeLog @@ -1,3 +1,27 @@ +2001-06-06 Jon Trowbridge + + * mail-account-gui.c (source_type_changed): Check that the chain + of deferences in gui->account->source->url is safe. This was + causing a segfault when adding a new account if any of the + existing accounts had their sources set to "None". + (i.e. gui->account->source == NULL) + + * mail-accounts.c (load_accounts): Check that account->source != + NULL before dereferencing it. + (load_accounts): The selection is cleared when the account clist + is rebuilt (say after a call to add), but no unselect event is + emitted. Yes, the clist is evil. We work around this by + explictly calling mail_unselect, our unselect signal handler. + (Otherwise, the edit and delete buttons remain sensitive and + accounts_row != 0, but the user can't see which row the dialog + thinks is selected.) + (load_news): Check the account->source != NULL before + dereferencing it. + (mail_unselect): If an insensitive button in a button box has the + focus, and if you hit tab, there is a segfault deep inside of gtk. + This is probably a gtk bug. We work around it by having the add + button (which is always sensitive) grab the focus on an unselect. + 2001-06-05 Jason Leach (Fix bug #3211: Should undelete when flagging a delete message as -- cgit v1.2.3