From c003c99a75587ba39a45d164272760c33f9666b5 Mon Sep 17 00:00:00 2001 From: Milan Crha Date: Fri, 25 Feb 2011 16:20:41 +0100 Subject: Bug #614480 - Avoid using G_TYPE_INSTANCE_GET_PRIVATE repeatedly --- filter/e-filter-datespec.c | 12 ++++-------- filter/e-filter-rule.c | 6 +----- filter/e-rule-context.c | 6 +----- filter/e-rule-editor.c | 6 +----- 4 files changed, 7 insertions(+), 23 deletions(-) (limited to 'filter') diff --git a/filter/e-filter-datespec.c b/filter/e-filter-datespec.c index 2c79899bf6..95e9dfd68a 100644 --- a/filter/e-filter-datespec.c +++ b/filter/e-filter-datespec.c @@ -47,10 +47,6 @@ #define localtime_r(tp,tmp) memcpy(tmp,localtime(tp),sizeof(struct tm)) #endif -#define E_FILTER_DATESPEC_GET_PRIVATE(obj) \ - (G_TYPE_INSTANCE_GET_PRIVATE \ - ((obj), E_TYPE_FILTER_DATESPEC, EFilterDatespecPrivate)) - #define d(x) typedef struct { @@ -172,7 +168,7 @@ set_button (EFilterDatespec *fds) static void get_values (EFilterDatespec *fds) { - EFilterDatespecPrivate *p = E_FILTER_DATESPEC_GET_PRIVATE (fds); + EFilterDatespecPrivate *p = fds->priv; switch (fds->priv->type) { case FDST_SPECIFIED: { @@ -207,7 +203,7 @@ set_values (EFilterDatespec *fds) { gint note_type; - EFilterDatespecPrivate *p = E_FILTER_DATESPEC_GET_PRIVATE (fds); + EFilterDatespecPrivate *p = fds->priv; p->type = fds->type==FDST_UNKNOWN ? FDST_NOW : fds->type; @@ -270,7 +266,7 @@ set_combobox_past_future (GtkComboBox *combobox, EFilterDatespec *fds) static void button_clicked (GtkButton *button, EFilterDatespec *fds) { - EFilterDatespecPrivate *p = E_FILTER_DATESPEC_GET_PRIVATE (fds); + EFilterDatespecPrivate *p = fds->priv; GtkWidget *content_area; GtkWidget *toplevel; GtkDialog *dialog; @@ -465,7 +461,7 @@ e_filter_datespec_class_init (EFilterDatespecClass *class) static void e_filter_datespec_init (EFilterDatespec *datespec) { - datespec->priv = E_FILTER_DATESPEC_GET_PRIVATE (datespec); + datespec->priv = G_TYPE_INSTANCE_GET_PRIVATE (datespec, E_TYPE_FILTER_DATESPEC, EFilterDatespecPrivate); datespec->type = FDST_UNKNOWN; } diff --git a/filter/e-filter-rule.c b/filter/e-filter-rule.c index f80146a600..ab39940843 100644 --- a/filter/e-filter-rule.c +++ b/filter/e-filter-rule.c @@ -35,10 +35,6 @@ #include "e-filter-rule.h" #include "e-rule-context.h" -#define E_FILTER_RULE_GET_PRIVATE(obj) \ - (G_TYPE_INSTANCE_GET_PRIVATE \ - ((obj), E_TYPE_FILTER_RULE, EFilterRulePrivate)) - typedef struct _FilterPartData FilterPartData; typedef struct _FilterRuleData FilterRuleData; @@ -864,7 +860,7 @@ e_filter_rule_class_init (EFilterRuleClass *class) static void e_filter_rule_init (EFilterRule *rule) { - rule->priv = E_FILTER_RULE_GET_PRIVATE (rule); + rule->priv = G_TYPE_INSTANCE_GET_PRIVATE (rule, E_TYPE_FILTER_RULE, EFilterRulePrivate); rule->enabled = TRUE; } diff --git a/filter/e-rule-context.c b/filter/e-rule-context.c index a167d01c5d..95ca9bbc7a 100644 --- a/filter/e-rule-context.c +++ b/filter/e-rule-context.c @@ -53,10 +53,6 @@ #include "e-filter-rule.h" #include "e-rule-context.h" -#define E_RULE_CONTEXT_GET_PRIVATE(obj) \ - (G_TYPE_INSTANCE_GET_PRIVATE \ - ((obj), E_TYPE_RULE_CONTEXT, ERuleContextPrivate)) - struct _ERuleContextPrivate { gint frozen; }; @@ -518,7 +514,7 @@ e_rule_context_class_init (ERuleContextClass *class) static void e_rule_context_init (ERuleContext *context) { - context->priv = E_RULE_CONTEXT_GET_PRIVATE (context); + context->priv = G_TYPE_INSTANCE_GET_PRIVATE (context, E_TYPE_RULE_CONTEXT, ERuleContextPrivate); context->part_set_map = g_hash_table_new (g_str_hash, g_str_equal); context->rule_set_map = g_hash_table_new (g_str_hash, g_str_equal); diff --git a/filter/e-rule-editor.c b/filter/e-rule-editor.c index a69f40b7fa..e1e702638c 100644 --- a/filter/e-rule-editor.c +++ b/filter/e-rule-editor.c @@ -37,10 +37,6 @@ #include "e-rule-editor.h" -#define E_RULE_EDITOR_GET_PRIVATE(obj) \ - (G_TYPE_INSTANCE_GET_PRIVATE \ - ((obj), E_TYPE_RULE_EDITOR, ERuleEditorPrivate)) - static gint enable_undo = 0; enum { @@ -654,7 +650,7 @@ e_rule_editor_class_init (ERuleEditorClass *class) static void e_rule_editor_init (ERuleEditor *editor) { - editor->priv = E_RULE_EDITOR_GET_PRIVATE (editor); + editor->priv = G_TYPE_INSTANCE_GET_PRIVATE (editor, E_TYPE_RULE_EDITOR, ERuleEditorPrivate); } /** -- cgit v1.2.3