From e06b88c4fda627599d7c1a33ddec0a35a4374e4f Mon Sep 17 00:00:00 2001 From: Milan Crha Date: Tue, 13 Oct 2009 16:24:10 +0200 Subject: Bug #594471 - Shouldn't call e_error_new/run with NULL 'parent' --- filter/filter-datespec.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) (limited to 'filter/filter-datespec.c') diff --git a/filter/filter-datespec.c b/filter/filter-datespec.c index fcfc877dc0..dcd3078ec1 100644 --- a/filter/filter-datespec.c +++ b/filter/filter-datespec.c @@ -45,7 +45,7 @@ #define d(x) -static gboolean validate (FilterElement *fe); +static gboolean validate (FilterElement *fe, GtkWindow *error_parent); static gint date_eq (FilterElement *fe, FilterElement *cm); static void xml_create (FilterElement *fe, xmlNodePtr node); static xmlNodePtr xml_encode (FilterElement *fe); @@ -178,18 +178,14 @@ filter_datespec_new (void) } static gboolean -validate (FilterElement *fe) +validate (FilterElement *fe, GtkWindow *error_parent) { FilterDatespec *fds = (FilterDatespec *) fe; gboolean valid; valid = fds->type != FDST_UNKNOWN; if (!valid) { - /* FIXME: FilterElement should probably have a - GtkWidget member pointing to the value gotten with - ::get_widget() so that we can get the parent window - here. */ - e_error_run(NULL, "filter:no-date", NULL); + e_error_run (error_parent, "filter:no-date", NULL); } return valid; -- cgit v1.2.3