From 73fa3a6e62f671e34ab1206425c39d8d8b987ba2 Mon Sep 17 00:00:00 2001 From: Jeffrey Stedfast Date: Sat, 4 Jan 2003 22:50:01 +0000 Subject: Instead of checking recipients != NULL, check that camel_address_length 2003-01-04 Jeffrey Stedfast * providers/smtp/camel-smtp-transport.c (smtp_send_to): Instead of checking recipients != NULL, check that camel_address_length (recipients) != 0 since it is illegal for recipients to be NULL (camel_transport_send_to already checks this). svn path=/trunk/; revision=19235 --- camel/ChangeLog | 7 +++++++ camel/providers/smtp/camel-smtp-transport.c | 4 ++-- 2 files changed, 9 insertions(+), 2 deletions(-) (limited to 'camel') diff --git a/camel/ChangeLog b/camel/ChangeLog index 168edae899..5acca4ea20 100644 --- a/camel/ChangeLog +++ b/camel/ChangeLog @@ -1,3 +1,10 @@ +2003-01-04 Jeffrey Stedfast + + * providers/smtp/camel-smtp-transport.c (smtp_send_to): Instead of + checking recipients != NULL, check that camel_address_length + (recipients) != 0 since it is illegal for recipients to be NULL + (camel_transport_send_to already checks this). + 2002-12-17 Jeffrey Stedfast * providers/imap/camel-imap-utils.c: Replace calls to diff --git a/camel/providers/smtp/camel-smtp-transport.c b/camel/providers/smtp/camel-smtp-transport.c index 03e7d03bd6..bfe9737d40 100644 --- a/camel/providers/smtp/camel-smtp-transport.c +++ b/camel/providers/smtp/camel-smtp-transport.c @@ -698,14 +698,14 @@ smtp_send_to (CamelTransport *transport, CamelMimeMessage *message, return FALSE; } - if (!recipients) { + len = camel_address_length (recipients); + if (len == 0) { camel_exception_setv (ex, CAMEL_EXCEPTION_SYSTEM, _("Cannot send message: no recipients defined.")); camel_operation_end (NULL); return FALSE; } - len = camel_address_length (recipients); cia = CAMEL_INTERNET_ADDRESS (recipients); for (i = 0; i < len; i++) { if (!camel_internet_address_get (cia, i, NULL, &addr)) { -- cgit v1.2.3