From 3ec585e1b510620a718d672ac682f2b467fe43c2 Mon Sep 17 00:00:00 2001 From: NotZed Date: Mon, 27 Mar 2000 22:46:13 +0000 Subject: Unref the output_stream when done, close doesn't do it. (_append_message): 2000-03-27 NotZed * providers/mbox/camel-mbox-folder.c (_append_message): Unref the output_stream when done, close doesn't do it. (_append_message): Clear all uid's from the appending messages, so they are reassigned proper unique id's. * gmime-utils.c (get_header_array_from_stream): Actually free the header, it is copied elsewhere. 2000-03-26 NotZed * providers/mbox/camel-mbox-utils.c (camel_mbox_write_xev): Added folder parameter to function. Fixed callers. (index_message): Index a message as it is assigned a unique id. * camel-mime-part.c (my_set_content_id): Make sure we malloc and copy the content_id, otherwise *poof* 2000-03-25 NotZed * camel-medium.c (_finalize): Another leak, unref the content if finished with it. * camel-recipient.c (camel_recipient_table_free): Plug another memory leak - actually free the recipient table. * camel-mime-message.c (_finalize): Plugged a memory leak with the flags table. * gmime-utils.c (_store_header_pair_from_string): A simpler, more debuggable and functionally identical header extraction function. 2000-03-24 NotZed * gmime-content-field.c (gmime_content_field_set_parameter): Remove the hash table entry before freeing its key and data. svn path=/trunk/; revision=2199 --- camel/providers/mbox/camel-mbox-parser.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'camel/providers/mbox/camel-mbox-parser.c') diff --git a/camel/providers/mbox/camel-mbox-parser.c b/camel/providers/mbox/camel-mbox-parser.c index b17c5c1e95..7c0eec5379 100644 --- a/camel/providers/mbox/camel-mbox-parser.c +++ b/camel/providers/mbox/camel-mbox-parser.c @@ -488,6 +488,8 @@ read_header (CamelMboxPreParser *parser, gchar **header_content) c = buffer[parser->current_position]; } + + /* FIXME: this can cause a memory leak, for duplicated headers? */ /* copy the buffer in the preparsing information structure */ *header_content = g_strndup (parser->tmp_string->str, parser->tmp_string->len); @@ -647,10 +649,7 @@ camel_mbox_parse_file (int fd, while (parser->buffer[parser->current_position] != '\0') { - - - - /* read the current character */ + /* read the current character */ if (!newline) { c = parser->buffer[parser->current_position]; newline = (c == '\n'); -- cgit v1.2.3