From f81ae069e4ef8a49f826c458c7b80996cec2036a Mon Sep 17 00:00:00 2001 From: NotZed Date: Mon, 28 Feb 2000 23:26:13 +0000 Subject: Fix a bunch of serious small bugs. 2000-02-28 NotZed * camel-mime-part.c (_parse_header_pair): Dont free this either. * camel-medium.c (_remove_header): Ugh, dont free the header before we actually remove it. (_add_header): Ugh, dont free hashtable entries which may be duplicated (hash_insert _will_ reference that memory). * string-utils.c (string_trim): Trimming a 0-length string is not an error. * camel-mime-message.c (_parse_header_pair): Fixed very broken memory handling of header_name/value. * providers/mbox/camel-mbox-utils.c (camel_mbox_write_xev): Initialise end_of_last_message always. (camel_mbox_copy_file_chunk): Stop trying to read if we run out of data, rather than looping forever. * providers/mbox/camel-mbox-folder.c (_init): Set search cap on. (_open): Call parent class to perform open. Remove folder-open check to parent instead. (_create): open takes a creation mask, dont use umask to try and set the open mode. (_delete): Dont bother checking folder==NULL, its already been checked on the external interface (changed to an assertion, this would have to be a camel bug). (_delete_messages): Likewise. (_create): Ditto. (_init): Dont go and clear all the paths and shit that the parent open just setup for us. (_delete_messages): Get rid of more umask stuff. (_append_message): Make sure we pass file mode to open with create. (_append_message): Cleaned up some indenting to make it readable. svn path=/trunk/; revision=1985 --- camel/gmime-utils.c | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'camel/gmime-utils.c') diff --git a/camel/gmime-utils.c b/camel/gmime-utils.c index 7ceb0219ec..d903eb8a71 100644 --- a/camel/gmime-utils.c +++ b/camel/gmime-utils.c @@ -130,6 +130,13 @@ _store_header_pair_from_string (GArray *header_array, gchar *header_line) if (header_line) { + char *p = strchr(header_line, ':'); + if (p) { + header.name = g_strndup(header_line, p-header_line); + header.value = g_strdup(p+1); + g_array_append_val (header_array, header); + } +#if 0 dich_result = string_dichotomy ( header_line, ':', &header_name, &header_value, STRING_DICHOTOMY_NONE); @@ -152,6 +159,7 @@ _store_header_pair_from_string (GArray *header_array, gchar *header_line) header.value = header_value; g_array_append_val (header_array, header); } +#endif } CAMEL_LOG_FULL_DEBUG ( "_store_header_pair_from_string:: Leaving\n"); -- cgit v1.2.3