From f81ae069e4ef8a49f826c458c7b80996cec2036a Mon Sep 17 00:00:00 2001 From: NotZed Date: Mon, 28 Feb 2000 23:26:13 +0000 Subject: Fix a bunch of serious small bugs. 2000-02-28 NotZed * camel-mime-part.c (_parse_header_pair): Dont free this either. * camel-medium.c (_remove_header): Ugh, dont free the header before we actually remove it. (_add_header): Ugh, dont free hashtable entries which may be duplicated (hash_insert _will_ reference that memory). * string-utils.c (string_trim): Trimming a 0-length string is not an error. * camel-mime-message.c (_parse_header_pair): Fixed very broken memory handling of header_name/value. * providers/mbox/camel-mbox-utils.c (camel_mbox_write_xev): Initialise end_of_last_message always. (camel_mbox_copy_file_chunk): Stop trying to read if we run out of data, rather than looping forever. * providers/mbox/camel-mbox-folder.c (_init): Set search cap on. (_open): Call parent class to perform open. Remove folder-open check to parent instead. (_create): open takes a creation mask, dont use umask to try and set the open mode. (_delete): Dont bother checking folder==NULL, its already been checked on the external interface (changed to an assertion, this would have to be a camel bug). (_delete_messages): Likewise. (_create): Ditto. (_init): Dont go and clear all the paths and shit that the parent open just setup for us. (_delete_messages): Get rid of more umask stuff. (_append_message): Make sure we pass file mode to open with create. (_append_message): Cleaned up some indenting to make it readable. svn path=/trunk/; revision=1985 --- camel/camel-mime-message.c | 4 ---- 1 file changed, 4 deletions(-) (limited to 'camel/camel-mime-message.c') diff --git a/camel/camel-mime-message.c b/camel/camel-mime-message.c index 8fe1764f96..a00d74a938 100644 --- a/camel/camel-mime-message.c +++ b/camel/camel-mime-message.c @@ -681,7 +681,6 @@ _parse_header_pair (CamelMimePart *mime_part, gchar *header_name, gchar *header_ header_value ); _set_recipient_list_from_string (message, "To", header_value); - g_free (header_value); header_handled = TRUE; break; @@ -691,7 +690,6 @@ _parse_header_pair (CamelMimePart *mime_part, gchar *header_name, gchar *header_ header_value ); _set_recipient_list_from_string (message, "Cc", header_value); - g_free (header_value); header_handled = TRUE; break; @@ -701,14 +699,12 @@ _parse_header_pair (CamelMimePart *mime_part, gchar *header_name, gchar *header_ header_value ); _set_recipient_list_from_string (message, "Bcc", header_value); - g_free (header_value); header_handled = TRUE; break; } if (header_handled) { - g_free (header_name); return TRUE; } else return parent_class->parse_header_pair (mime_part, header_name, header_value); -- cgit v1.2.3