From 8c9b0cc3f0d9cf8ca0c7b416a08d742b2694af07 Mon Sep 17 00:00:00 2001 From: NotZed Date: Mon, 24 Apr 2000 06:05:41 +0000 Subject: No longer call data_wrapper_repository_init. 2000-04-24 NotZed * camel.c (camel_init): No longer call data_wrapper_repository_init. * camel-medium.c (write_to_stream): Moved (back) to camel-mime-part. (add_header): (set_header): (remove_header): (get_header): Make all these abstract, and spit warnings if called. I guess it could manage the list, but well, it doesn't. * camel-medium.h (struct _CamelMedium): Dont store headers here, the implementor is the only one who knows their format. (CamelMediumClass): Changed header values to be void *'s. They need not be strings? * camel-simple-data-wrapper.c (construct_from_stream): And we're back. Set the output stream. (construct_from_parser): Moved to camel-mime-part-utils. * camel-mime-part-utils.c (camel_mime_part_construct_content_from_parser): Create the contents of multipart and simple messages. * camel-multipart.c (construct_from_parser): Moved to camel-mime-part-utils. (separate_part): Removed. * camel-mime-part.c (construct_from_stream): Back again! This now switches over to using a mime parser for any mime parts, only. (my_write_to_stream): Write our headers and so forth here. (add_header): Add header directly, parent class is abstract. (remove_header): Ditto. (set_header): Ditto. * camel-data-wrapper.c (camel_data_wrapper_construct_from_stream): Remade abstract. (camel_data_wrapper_construct_from_parser): Moved to camel_mime_part. * camel-data-wrapper.h: Put back construct_from_stream. * camel-mime-part.h: Put construct_from_parser in here, the data-wrapper shouldn't know about mime. Ok, so now to undo half of the last hours changes ... duh. 2a51,93 * providers/pop3/camel-pop3-folder.c (get_message_by_number): Use construct_from_stream instead of set_input_stream(). * camel-simple-data-wrapper-stream.c (camel_simple_data_wrapper_stream_construct): REmoved the destroy callback code. (wrapper_destroy_cb): Removed. * camel-simple-data-wrapper.h: Add prototype for _construct() method. * camel.c: Include unicode.h to kill a warning. * camel-data-wrapper.h (CameldataWrapperClass): Removed construct_from_stream virtual method. Removed get/set input stream. * data-wrapper-repository.[ch]: Removed&from build. Obsoleted? The justification as is follows: It is mixing storage protocol/format with message architecture. It really just doesn't serve any purpose, as each medium implementor will have to have its own type->handler mapping, and the only current implementor, mimepart has a very simple structure and no need for this. * camel-medium.c (write_to_stream): Moved here from most of the stuff in camel-mime-part. Well, the MEDIUM is the one that knows what the headers are, and the content is, let it write it out. * camel-mime-part-utils.c (camel_mime_part_construct_content): Copied from camel-mime-part.c, removed handling of message followon state (moved to camel-mime-message). (camel_mime_part_construct_content_from_parser): Renamed from construct_content. (camel_mime_part_construct_headers_from_stream): (camel_mime_part_construct_content_from_stream): (camel_mime_part_store_stream_in_buffer): Removed. Replaced by the new construct from parser stuff. * camel-mime-message.c (construct_from_parser): Do construct_from_parser for mime-message. (_write_to_stream): Set the mime-version header for medium to write out, rather than writing it out ourselves. 4a96,102 (construct_from_stream): Removed. (camel_data_wrapper_construct_from_stream): Changed to a helper function, creates a mime_parser, and constructs from that. (set_input_stream): Removed. (camel_data_wrapper_set_input_stream): Removed. (get_input_stream): Removed. (camel_data_wrapper_get_input_stream): Removed. 11a110,111 (_get_message_by_uid): Use construct_from_stream() instead of creating our own parser. 16a117,131 (camel_mime_part_construct_content): Removed to camel-mime-part-utils.c (my_get_output_stream): Removed. The streeam is in the data-wrapper. (my_get_content_object): Removed. The content object is stored in the medium. If none is there, the object wasn't created properly. (my_write_content_to_stream): Removed. The content object is the one that knows how to write itself out!!!!!!!! (my_write_to_stream): Remove the base header writing stuff - has been moved to camel-medium, where it belongs. This can just be used to check for mandatory headers. (my_construct_from_stream): Removed. (my_set_input_stream): What the hell, i'll remove this too. Nobody seems to understand how it differs from create from stream, and they both seem to serve the same purpose ... 19a135,136 (construct_from_stream): Removed! Job taken over by construct_from_parser. 24a142 (set_input_stream): REmoved. Replaced by construct_from_parser. svn path=/trunk/; revision=2577 --- camel/camel-data-wrapper.c | 118 +++++++-------------------------------------- 1 file changed, 18 insertions(+), 100 deletions(-) (limited to 'camel/camel-data-wrapper.c') diff --git a/camel/camel-data-wrapper.c b/camel/camel-data-wrapper.c index 1cff54a7c1..777d0361d9 100644 --- a/camel/camel-data-wrapper.c +++ b/camel/camel-data-wrapper.c @@ -6,8 +6,7 @@ /* * - * Author : - * Bertrand Guiheneuf + * Authors: Bertrand Guiheneuf * * Copyright 1999, 2000 Helix Code, Inc. (http://www.helixcode.com) * @@ -37,16 +36,11 @@ static GtkObjectClass *parent_class = NULL; #define CDW_CLASS(so) CAMEL_DATA_WRAPPER_CLASS (GTK_OBJECT (so)->klass) -static void set_input_stream (CamelDataWrapper *data_wrapper, - CamelStream *stream); -static CamelStream *get_input_stream (CamelDataWrapper *data_wrapper); static void set_output_stream (CamelDataWrapper *data_wrapper, CamelStream *stream); static CamelStream *get_output_stream (CamelDataWrapper *data_wrapper); -static void construct_from_stream (CamelDataWrapper *data_wrapper, - CamelStream *stream); -static void construct_from_parser(CamelDataWrapper *, CamelMimeParser *); +static void construct_from_stream(CamelDataWrapper *, CamelStream *); static void write_to_stream (CamelDataWrapper *data_wrapper, CamelStream *stream); static void set_mime_type (CamelDataWrapper *data_wrapper, @@ -67,18 +61,16 @@ camel_data_wrapper_class_init (CamelDataWrapperClass *camel_data_wrapper_class) /* virtual method definition */ camel_data_wrapper_class->write_to_stream = write_to_stream; - camel_data_wrapper_class->construct_from_stream = construct_from_stream; - camel_data_wrapper_class->construct_from_parser = construct_from_parser; camel_data_wrapper_class->set_mime_type = set_mime_type; camel_data_wrapper_class->get_mime_type = get_mime_type; camel_data_wrapper_class->get_mime_type_field = get_mime_type_field; camel_data_wrapper_class->set_mime_type_field = set_mime_type_field; - camel_data_wrapper_class->set_input_stream = set_input_stream; - camel_data_wrapper_class->get_input_stream = get_input_stream; camel_data_wrapper_class->set_output_stream = set_output_stream; camel_data_wrapper_class->get_output_stream = get_output_stream; + camel_data_wrapper_class->construct_from_stream = construct_from_stream; + /* virtual method overload */ gtk_object_class->finalize = finalize; } @@ -135,71 +127,6 @@ finalize (GtkObject *object) parent_class->finalize (object); } - -static void -set_input_stream (CamelDataWrapper *data_wrapper, CamelStream *stream) -{ - if (data_wrapper->input_stream) - gtk_object_unref (GTK_OBJECT (data_wrapper->input_stream)); - - data_wrapper->input_stream = stream; - - if (!data_wrapper->output_stream && stream) - set_output_stream (data_wrapper, stream); - - if (stream) { - gtk_object_ref (GTK_OBJECT (stream)); - gtk_object_sink (GTK_OBJECT (stream)); - } -} - -/** - * camel_data_wrapper_set_input_stream: - * @data_wrapper: a data wrapper - * @stream: a stream that can be read from, or %NULL - * - * This sets the data wrapper's input stream from @stream, most likely - * causing @data_wrapper to initialize itself from that stream. - * @data_wrapper may or may not notice future changes to @stream, and - * if @stream is closed before @data_wrapper is destroyed, it could - * be arbitrarily bad. This function may fail, but there is no way - * for the caller to know this. - * - * If @data_wrapper has no output stream, its output stream will also - * be set to @stream. - **/ -void -camel_data_wrapper_set_input_stream (CamelDataWrapper *data_wrapper, - CamelStream *stream) -{ - g_return_if_fail (CAMEL_IS_DATA_WRAPPER (data_wrapper)); - g_return_if_fail (stream == NULL || CAMEL_IS_STREAM (stream)); - - CDW_CLASS (data_wrapper)->set_input_stream (data_wrapper, stream); -} - - -static CamelStream * -get_input_stream (CamelDataWrapper *data_wrapper) -{ - return data_wrapper->input_stream; -} - -/** - * camel_data_wrapper_get_input_stream: - * @data_wrapper: a data wrapper - * - * Return value: @data_wrapper's input stream - **/ -CamelStream * -camel_data_wrapper_get_input_stream (CamelDataWrapper *data_wrapper) -{ - g_return_val_if_fail (CAMEL_IS_DATA_WRAPPER (data_wrapper), NULL); - - return CDW_CLASS (data_wrapper)->get_input_stream (data_wrapper); -} - - static void set_output_stream (CamelDataWrapper *data_wrapper, CamelStream *stream) { @@ -219,13 +146,13 @@ set_output_stream (CamelDataWrapper *data_wrapper, CamelStream *stream) * @data_wrapper: a data wrapper * @stream: a stream that can be read from * - * This sets the data wrapper's output stream to @stream. Unlike - * camel_data_wrapper_set_input_stream(), this function has no side - * effects. + * This is an internal function to be used by implementors of + * the camel-data-wrapper to set their contents as a stream. * * The output stream should theoretically be a stream that, if read * from, produces the data wrapper's contents. However, while certain * pieces of code assume this, nothing enforces it. + * **/ void camel_data_wrapper_set_output_stream (CamelDataWrapper *data_wrapper, @@ -249,6 +176,11 @@ get_output_stream (CamelDataWrapper *data_wrapper) * camel_data_wrapper_get_output_stream: * @data_wrapper: a data wrapper * + * If the data wrapper has contents, this will return a stream representing + * the data wrappers contents. Currently only the body of a simple + * mime part may be read in this way, although conceivably a whole + * mime message or partial mime message could be processed this way. + * * Return value: @data_wrapper's output stream **/ CamelStream * @@ -311,21 +243,20 @@ camel_data_wrapper_write_to_stream (CamelDataWrapper *data_wrapper, CDW_CLASS (data_wrapper)->write_to_stream (data_wrapper, stream); } - static void -construct_from_stream (CamelDataWrapper *data_wrapper, CamelStream *stream) +construct_from_stream(CamelDataWrapper *data_wrapper, + CamelStream *stream) { - /* nothing */ + g_warning("Construct from stream unimplemented for class: %s", gtk_type_name(((GtkObject *)data_wrapper)->klass->type)); } /** * camel_data_wrapper_construct_from_stream: * @data_wrapper: a data wrapper - * @stream: a stream that can be read from + * @stream: A stream that can be read from. * - * This constructs a data wrapper object from a stream. It is not clear - * how this differs from camel_data_wrapper_set_input_stream(), nor is - * it clear how it affects the data wrapper's input and output streams. + * Constructs the content of the data wrapper from the + * supplied @stream. * * This could fail, but you can't know if it did. **/ @@ -440,16 +371,3 @@ camel_data_wrapper_set_mime_type_field (CamelDataWrapper *data_wrapper, CDW_CLASS (data_wrapper)->set_mime_type_field (data_wrapper, mime_type); } - -static void construct_from_parser(CamelDataWrapper *d, CamelMimeParser *mp) -{ - /* do nothing? */ - g_warning("Construct from parser not implemented for: %s", gtk_type_name(((GtkObject *)d)->klass->type)); -} - -void -camel_data_wrapper_construct_from_parser(CamelDataWrapper *data_wrapper, CamelMimeParser *mp) -{ - CDW_CLASS (data_wrapper)->construct_from_parser (data_wrapper, mp); -} - -- cgit v1.2.3