From 0933b12476c210975487cd29c3e05a0f248eac04 Mon Sep 17 00:00:00 2001 From: Jeffrey Stedfast Date: Wed, 9 Apr 2003 23:21:15 +0000 Subject: Removed. I just realised that we ALWAYS want to get gpg's stderr in UTF-8, 2003-04-09 Jeffrey Stedfast * camel-gpg-context.c (gpg_ctx_get_utf8_diagnostics): Removed. I just realised that we ALWAYS want to get gpg's stderr in UTF-8, so the better solution (plus less code duplication) is to just have the diagnostics buffer be a CamelStreamMem with a charset filter. (gpg_ctx_new): Setup a filter stream to convert our gpg stderr diagnostics into UTF-8 if needed. (gpg_ctx_free): Unref the diagnostcis stream. (gpg_ctx_parse_status): Flush the diagnostics stream if we are going to use the data in an exception. (gpg_ctx_op_step): Use camel_stream_write() to append to the diagnostics stream rather than appending the buffer to a GByteArray like we used to do. (gpg_ctx_op_step): Flush the diagnostics stream here too. (gpg_verify): Use a const char *diagnostics string here, forcing a slight rearrangement of calls - use the const char *dignostics before we gpg_ctx_free, otherwise we'll be passing free'd memory off to the cipher_validity. (gpg_ctx_get_diagnostics): Do the work here to flush the diagnostics stream and nul-terminate the buffer. Also return const now, instead of strdupping. No need for that. (gpg_ctx_parse_status): Convert the user hint to UTF-8. svn path=/trunk/; revision=20798 --- camel/ChangeLog | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) (limited to 'camel/ChangeLog') diff --git a/camel/ChangeLog b/camel/ChangeLog index f07d3c83f3..51046e119d 100644 --- a/camel/ChangeLog +++ b/camel/ChangeLog @@ -1,3 +1,27 @@ +2003-04-09 Jeffrey Stedfast + + * camel-gpg-context.c (gpg_ctx_get_utf8_diagnostics): Removed. I + just realised that we ALWAYS want to get gpg's stderr in UTF-8, so + the better solution (plus less code duplication) is to just have + the diagnostics buffer be a CamelStreamMem with a charset filter. + (gpg_ctx_new): Setup a filter stream to convert our gpg stderr + diagnostics into UTF-8 if needed. + (gpg_ctx_free): Unref the diagnostcis stream. + (gpg_ctx_parse_status): Flush the diagnostics stream if we are + going to use the data in an exception. + (gpg_ctx_op_step): Use camel_stream_write() to append to the + diagnostics stream rather than appending the buffer to a + GByteArray like we used to do. + (gpg_ctx_op_step): Flush the diagnostics stream here too. + (gpg_verify): Use a const char *diagnostics string here, forcing a + slight rearrangement of calls - use the const char *dignostics + before we gpg_ctx_free, otherwise we'll be passing free'd memory + off to the cipher_validity. + (gpg_ctx_get_diagnostics): Do the work here to flush the + diagnostics stream and nul-terminate the buffer. Also return const + now, instead of strdupping. No need for that. + (gpg_ctx_parse_status): Convert the user hint to UTF-8. + 2003-04-09 Jeffrey Stedfast * camel-gpg-context.c (gpg_ctx_get_utf8_diagnostics): Changed my @@ -6,6 +30,8 @@ just skip over invalid sequences. Also, in the noop failure case, close the iconv_t so we don't leak it. +2003-04-09 Jeffrey Stedfast + * providers/imap/camel-imap-utils.c (imap_body_decode): Save the content size in a temp variable until after we've successfully parsed all of the body_type_1part expr. Also fixed a type-o in the -- cgit v1.2.3