From 0586d60922ca2a7b21edd27d0f5a42feab4576c1 Mon Sep 17 00:00:00 2001 From: Damon Chaplin Date: Mon, 1 Oct 2001 20:12:00 +0000 Subject: unref the page objects here, instead of in close_dialog(). (This was fixed 2001-10-01 Damon Chaplin * gui/dialogs/comp-editor.c (comp_editor_destroy): unref the page objects here, instead of in close_dialog(). (This was fixed a while ago, but accidentally reverted.) Fixes bug #7543. svn path=/trunk/; revision=13278 --- calendar/gui/dialogs/comp-editor.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) (limited to 'calendar/gui') diff --git a/calendar/gui/dialogs/comp-editor.c b/calendar/gui/dialogs/comp-editor.c index 593544c11f..79f692223d 100644 --- a/calendar/gui/dialogs/comp-editor.c +++ b/calendar/gui/dialogs/comp-editor.c @@ -243,6 +243,7 @@ comp_editor_destroy (GtkObject *object) { CompEditor *editor; CompEditorPrivate *priv; + GList *l; editor = COMP_EDITOR (object); priv = editor->priv; @@ -254,6 +255,12 @@ comp_editor_destroy (GtkObject *object) priv->window = NULL; } + /* We want to destroy the pages after the widgets get destroyed, + since they have lots of signal handlers connected to the widgets + with the pages as the data. */ + for (l = priv->pages; l != NULL; l = l->next) + gtk_object_unref (GTK_OBJECT (l->data)); + if (priv->comp) { gtk_object_unref (GTK_OBJECT (priv->comp)); priv->comp = NULL; @@ -899,15 +906,11 @@ static void close_dialog (CompEditor *editor) { CompEditorPrivate *priv; - GList *l; priv = editor->priv; g_assert (priv->window != NULL); - for (l = priv->pages; l != NULL; l = l->next) - gtk_object_unref (GTK_OBJECT (l->data)); - gtk_object_destroy (GTK_OBJECT (editor)); } -- cgit v1.2.3