From 072795e5a3081544314466d51870c670a08c6198 Mon Sep 17 00:00:00 2001 From: Suman Manjunath Date: Mon, 28 Jan 2008 04:46:58 +0000 Subject: Patch from Milan Crha ** Fix for bug #355864 (Calendar critical warning when unchecking a webcal) svn path=/trunk/; revision=34907 --- calendar/gui/e-week-view.c | 36 +++++++++++++++++++++++++----------- 1 file changed, 25 insertions(+), 11 deletions(-) (limited to 'calendar/gui/e-week-view.c') diff --git a/calendar/gui/e-week-view.c b/calendar/gui/e-week-view.c index cca54b0d22..e6dd84ad66 100644 --- a/calendar/gui/e-week-view.c +++ b/calendar/gui/e-week-view.c @@ -1926,19 +1926,33 @@ e_week_view_remove_event_cb (EWeekView *week_view, e_cal_model_free_component_data (event->comp_data); event->comp_data = NULL; - /* We leave the span elements in the array, but set the canvas item - pointers to NULL. */ - for (span_num = 0; span_num < event->num_spans; span_num++) { - span = &g_array_index (week_view->spans, EWeekViewEventSpan, - event->spans_index + span_num); + if (week_view->spans) { + /* We leave the span elements in the array, but set the canvas item + pointers to NULL. */ + for (span_num = 0; span_num < event->num_spans; span_num++) { + span = &g_array_index (week_view->spans, EWeekViewEventSpan, + event->spans_index + span_num); - if (span->text_item) { - gtk_object_destroy (GTK_OBJECT (span->text_item)); - span->text_item = NULL; + if (span->text_item) { + gtk_object_destroy (GTK_OBJECT (span->text_item)); + span->text_item = NULL; + } + if (span->background_item) { + gtk_object_destroy (GTK_OBJECT (span->background_item)); + span->background_item = NULL; + } } - if (span->background_item) { - gtk_object_destroy (GTK_OBJECT (span->background_item)); - span->background_item = NULL; + + /* Update event_num numbers for already created spans with event_num higher than our event_num */ + for (span_num = 0; span_num < week_view->spans->len; span_num++) { + span = &g_array_index (week_view->spans, EWeekViewEventSpan, span_num); + + if (span && span->background_item && E_IS_WEEK_VIEW_EVENT_ITEM (span->background_item)) { + EWeekViewEventItem *wveitem = E_WEEK_VIEW_EVENT_ITEM (span->background_item); + + if (wveitem->event_num > event_num) + wveitem->event_num--; + } } } -- cgit v1.2.3