From 8e8fcea05d20217a19285cb7599d1d0b96de4b3b Mon Sep 17 00:00:00 2001 From: Rodrigo Moya Date: Thu, 4 Mar 2004 11:17:56 +0000 Subject: Fixes #53137 2004-03-04 Rodrigo Moya Fixes #53137 * gui/dialogs/comp-editor-page.[ch]: made fill_widgets virtual method return a gboolean. (comp_editor_page_fill_widgets): return value from virtual method implementation. * gui/dialogs/event-page.c (event_page_fill_widgets): * gui/dialogs/meeting-page.c (meeting_page_fill_widgets): * gui/dialogs/recurrence-page.c (recurrence_page_fill_widgets): * gui/dialogs/schedule-page.c (schedule_page_fill_widgets): * gui/dialogs/task-details-page.c (task_details_page_fill_widgets): * gui/dialogs/task-page.c (task_page_fill_widgets): * gui/dialogs/alarm-page.c (alarm_page_fill_widgets): return value, as expected from the virtual method signature. * gui/dialogs/comp-editor.c (comp_editor_append_page): dont add the page if there was an error calling the fill_widgets method. svn path=/trunk/; revision=24960 --- calendar/gui/dialogs/comp-editor.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'calendar/gui/dialogs/comp-editor.c') diff --git a/calendar/gui/dialogs/comp-editor.c b/calendar/gui/dialogs/comp-editor.c index d204de56e8..b298952a6e 100644 --- a/calendar/gui/dialogs/comp-editor.c +++ b/calendar/gui/dialogs/comp-editor.c @@ -722,7 +722,11 @@ comp_editor_append_page (CompEditor *editor, ECalComponent *comp; comp = comp_editor_get_current_comp (editor); - comp_editor_page_fill_widgets (page, comp); + if (!comp_editor_page_fill_widgets (page, comp)) { + /* dont add the pagge if there is an error */ + g_object_unref (comp); + return; + } g_object_unref (comp); } -- cgit v1.2.3